From patchwork Mon Jan 30 09:41:51 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Stein X-Patchwork-Id: 13120815 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 94EE9C54EAA for ; Mon, 30 Jan 2023 09:45:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=TWraO96m7kPE/IqLygvDN3Ig/esqRY9IrtbTVtdRgtM=; b=zIUkKktiuQm5yb yanhvPcoiagnJSJysPlFzDGXn8Bm3ZARzFPwQ3LCBgY/9pG7dPzk4Q/kx7rBGWR2jxMiOjEyLz4+Y +KTRR8KJ/2aBYD7B1y7xtE8yJz9Sii6EYdCCUX9/rcT5Jji3xeW/N/n6duPcWyYWE9MNBQ0XsUE4K +EHZ648/9NcMNMRxACJLBv1UN8z3ZOTHpkSO82DvexAsp19/fjW+bH4ymxZUXXQ4LzQFcSThnI5Vg csjoDSwNe85YXWLwVWqp1mpJk83O2i8fTecaS3QCfRcNgyaa41d0VsrQYhJHfu052izZof71WWImD dmWLQrI5/M2I0oCFFfkQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pMQgW-002wdl-Qr; Mon, 30 Jan 2023 09:42:44 +0000 Received: from mx1.tq-group.com ([93.104.207.81]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pMQfq-002wUX-Ca for linux-arm-kernel@lists.infradead.org; Mon, 30 Jan 2023 09:42:04 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1675071722; x=1706607722; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=mm/GfHCn+O+KygVwNrpVYXUTt0wsS2Agnd9MGjg6AmE=; b=guyQlGfI3mlQyynmD1lX+ReS0wuGOgygbAQtbAlmHuf/6n/ePlA6wpFB NdR7Xq1PA08X7TE9ELPos8PVYrZJbRLfqwAhJcncbqE7RLnsSVaTwkvgG I75XyiWdYEurAnsrn5tYMzd8xMHLa9hA9zvhHgsb2xaUUeXPDVRSbBpmu +1igJ0De7ieCUA0hYVgdBoyIl5tpFRpnX5J4I4miiblqVxekvhn2k7QPl +LD5ItLMsTFGdjx1hiuoI3UtF0Hw5LiUAKC9PZ6QOQyEnTPUIQ6an0hCJ Ndtji9rd14DCkwzAcqI9DYkc/6Y7cBGcdpsXVK7n56KHRnEkNTlb9r9CG Q==; X-IronPort-AV: E=Sophos;i="5.97,257,1669071600"; d="scan'208";a="28735458" Received: from unknown (HELO tq-pgp-pr1.tq-net.de) ([192.168.6.15]) by mx1-pgp.tq-group.com with ESMTP; 30 Jan 2023 10:41:57 +0100 Received: from mx1.tq-group.com ([192.168.6.7]) by tq-pgp-pr1.tq-net.de (PGP Universal service); Mon, 30 Jan 2023 10:41:57 +0100 X-PGP-Universal: processed; by tq-pgp-pr1.tq-net.de on Mon, 30 Jan 2023 10:41:57 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1675071717; x=1706607717; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=mm/GfHCn+O+KygVwNrpVYXUTt0wsS2Agnd9MGjg6AmE=; b=YFcz26vuAa1ps1FMvi7RZzOUojb+fCing+WE+9m01FMaaEyzumftYkds bTa/+J8HawAs7wloD2h02BzW9g7hQOgfYD9Zk3M3S/6JMVL8FfKLYzux3 pXQH9FGUnpxrqkkaIdBeYs0lO/8a8cqovRz/Erd/3AvwFT5Xnjp47OeWB ooPfkK5yOtMHcqxKWLSuNR4oSBlK2KDNGXAwFM7SHYA8Ow9i/NEI3PilF /k6vHh6TUBpY+ph76wCNHfpDj3LQ3TKOWg8sM1YA2PHnkg01Mbn1lLATK Y+f9jc9bKIeS7+X+AT4IBO1wWyc4R5a67k5h16M6Vmo7A70gT2PMQxhEd w==; X-IronPort-AV: E=Sophos;i="5.97,257,1669071600"; d="scan'208";a="28735457" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 30 Jan 2023 10:41:57 +0100 Received: from steina-w.tq-net.de (unknown [10.123.53.21]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by vtuxmail01.tq-net.de (Postfix) with ESMTPSA id ADA59280056; Mon, 30 Jan 2023 10:41:56 +0100 (CET) From: Alexander Stein To: Peter Chen , Greg Kroah-Hartman , Shawn Guo , Sascha Hauer , Fabio Estevam Cc: Alexander Stein , Pengutronix Kernel Team , linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 1/1] usb: chipidea: ci_hdrc_imx: use dev_err_probe Date: Mon, 30 Jan 2023 10:41:51 +0100 Message-Id: <20230130094151.95174-1-alexander.stein@ew.tq-group.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230130_014202_851509_0329FB55 X-CRM114-Status: GOOD ( 14.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Add error message if finding USB PHY fails or is deferred. Signed-off-by: Alexander Stein Acked-by: Peter Chen --- drivers/usb/chipidea/ci_hdrc_imx.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/usb/chipidea/ci_hdrc_imx.c b/drivers/usb/chipidea/ci_hdrc_imx.c index 0dc482542d85..2eeccf4ec9d6 100644 --- a/drivers/usb/chipidea/ci_hdrc_imx.c +++ b/drivers/usb/chipidea/ci_hdrc_imx.c @@ -413,15 +413,19 @@ static int ci_hdrc_imx_probe(struct platform_device *pdev) data->phy = devm_usb_get_phy_by_phandle(dev, "fsl,usbphy", 0); if (IS_ERR(data->phy)) { ret = PTR_ERR(data->phy); - if (ret != -ENODEV) + if (ret != -ENODEV) { + dev_err_probe(dev, ret, "Failed to parse fsl,usbphy\n"); goto err_clk; + } data->phy = devm_usb_get_phy_by_phandle(dev, "phys", 0); if (IS_ERR(data->phy)) { ret = PTR_ERR(data->phy); - if (ret == -ENODEV) + if (ret == -ENODEV) { data->phy = NULL; - else + } else { + dev_err_probe(dev, ret, "Failed to parse phys\n"); goto err_clk; + } } }