From patchwork Mon Jan 30 16:48:52 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shyam Sundar S K X-Patchwork-Id: 13121440 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED3C0C54EED for ; Mon, 30 Jan 2023 16:49:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234744AbjA3Qtl (ORCPT ); Mon, 30 Jan 2023 11:49:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49138 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236454AbjA3Qtk (ORCPT ); Mon, 30 Jan 2023 11:49:40 -0500 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2046.outbound.protection.outlook.com [40.107.223.46]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5C52AF77D for ; Mon, 30 Jan 2023 08:49:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Qimq0+5eeGz7gXj7uTPUl/qdO9oTtY/4AxU8maMfMPFTtJODGjMtqKP4h6VYxDysipBvqOIPRUG1jTybbZL8Bh6bW8mTseqLsmhiHw8rU5wvrcJvhGUbvqNtBa5MEP2gWCxWAbM2v5HkCQaGt6bdCT8DpsfiffzZKOf/rUwSdX1h+1g1qxVvn0NKL/uM5Fz/6Zce/J5xmeM8XkgHhFO9+LhNGkGXYNpmNfMmX9MZwMpIJm+KKkYY36wu6A3grIyD+k+n/n0sM5L/1nNYwr8icCh0q/tE3XSSNFFyFr+5yJQha0wxmo23vvJndudXzj8VGtr3NSqvCLnXv54GWES3Dw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=d1OiyZ3MWh/Nr0XAQEKrs2CzZdpUR2iN4dLTlpSKchw=; b=KGR2glY2twE96Fwf2XhN/BIFOd19B3PONJ0MKBa1vz9h7N7Y7bCmBD1JrNGuloLvvUQp6s5/zMiFFqLfUFtwuIahMF2oC50AagjzErJ6aoyARjSdAoB7dWkKKnimSopxZo8irPSgTDfGuLPd2/YmfAnKARyKkvleeubJHsUQZLRdUY2Pzvk1T+r2DMRh48wXTZCJBhHXjXTgnYlYq1T06e+zfyG9yBS+xfopzJSwHbP0TjF4RlF/jG5zKBzubvR4O9wwgK2jd7bA63fRmpYm8vIu5fvgO8m8L/9ARgWmrGtVEpaYeBeq2r6Oqq0yJKTNtC0ep5eLvO331cJCca8fQQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=redhat.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=d1OiyZ3MWh/Nr0XAQEKrs2CzZdpUR2iN4dLTlpSKchw=; b=onIipk+67tnF55qCIAmx/CmB7Z+tkSckXeGaFx2vVYt5kSgEjze1jE5je+aw9hynEVT6mtQVG34FDvZv44t08btSWsjUEZ3fwp7PyW2HfN6aldXaFMYQ+A/h9XA2nKGGtwF0Z/nZlUxWbVSsJD8pDLBDhfx6RKGYnRjuNGFPkFs= Received: from CY5PR19CA0118.namprd19.prod.outlook.com (2603:10b6:930:64::22) by BL1PR12MB5825.namprd12.prod.outlook.com (2603:10b6:208:394::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.36; Mon, 30 Jan 2023 16:49:37 +0000 Received: from CY4PEPF0000C978.namprd02.prod.outlook.com (2603:10b6:930:64:cafe::bb) by CY5PR19CA0118.outlook.office365.com (2603:10b6:930:64::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.36 via Frontend Transport; Mon, 30 Jan 2023 16:49:37 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CY4PEPF0000C978.mail.protection.outlook.com (10.167.241.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6064.19 via Frontend Transport; Mon, 30 Jan 2023 16:49:36 +0000 Received: from jatayu.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 30 Jan 2023 10:49:34 -0600 From: Shyam Sundar S K To: , CC: , , "Shyam Sundar S K" Subject: [PATCH v2 1/4] platform/x86/amd: pmc: Add num_samples message id support to STB Date: Mon, 30 Jan 2023 22:18:52 +0530 Message-ID: <20230130164855.168437-2-Shyam-sundar.S-k@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230130164855.168437-1-Shyam-sundar.S-k@amd.com> References: <20230130164855.168437-1-Shyam-sundar.S-k@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000C978:EE_|BL1PR12MB5825:EE_ X-MS-Office365-Filtering-Correlation-Id: 5bd28815-527e-4c54-3faf-08db02e1f8eb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: zDhrERS6mMjWUODFKaPEm3fbOIFi1mtAo1Jld12kKz5iUfs2Xofpp1FzwRtXBqxVWWHceDQlp+PmpEFpj25Oernm5SIccd5ppz+uCLKvfvVBvpO3Xv0Ph4ts1BC6v0uO5ug6U2Q7VdEQ6tEMYqnyTgUHp4AyYicWJ2vDoQvYLMoACq/88Y4eNu9C+vkQ9bO1f7wJo4aEyTGQr3PaKH+8XSyNipk8VvliH4SNZXqTZSHn2SOk4YQrt2Ze75hqzDHIVtm6WC0ilM0QbOK1XcU/JbuqqgLM+/TLRuGdFF3uIi0RW8m92VY4VFV1LIwk/i9hYzncgGVI6tw/r0x2qSWz8pex1/ut6il6yPSFnrF0idIm9yXpNWaO64pf4FpsV83RPWjbJV44mne9TKdYSqPYsK5JW86aP2+IfARej9jM4URmbxIq0Y4Hi6IzLwsFVWKifKoh507tM83YA4KUef+39QWT6ZMiZqieQ0tEFhcvM/nLFke92k5sla772+qGDYdKcQ3wO/l4voL82ajsp+/2kbPYPg+YSLrnQF4pFOsP5gfwb0rsBqye0AQQ9Z6C/aHHix6zvNycx4/VTAe/oXZtxcKOGV4A490Rn+fJkiUNDu2Frpp4zO+kE6cskvwjvWVdiJ3D0lLP7d/U/45n/GsjQUblTPA5/LrI2s/WZBsaehDZGi4DoDkH8jD8khhOid2+GgNA/yIuTfEKwpCXc6bKoDyTMHiAmcw3/NonuTzAgbq6n6yYN/uHx0iUcaYQBxRDA0VfV0SXtfaGwZvL+BV8cw== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230025)(4636009)(346002)(376002)(39860400002)(136003)(396003)(451199018)(46966006)(40470700004)(36840700001)(86362001)(82310400005)(356005)(36756003)(7696005)(2906002)(54906003)(110136005)(15650500001)(6666004)(478600001)(8936002)(40480700001)(5660300002)(41300700001)(4326008)(70206006)(8676002)(316002)(70586007)(40460700003)(81166007)(83380400001)(16526019)(186003)(26005)(82740400003)(36860700001)(1076003)(426003)(47076005)(336012)(2616005)(750200003)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jan 2023 16:49:36.9027 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5bd28815-527e-4c54-3faf-08db02e1f8eb X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000C978.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5825 Precedence: bulk List-ID: X-Mailing-List: platform-driver-x86@vger.kernel.org Recent PMFWs have the support for S2D_NUM_SAMPLES message ID that can tell the current number of samples present within the STB DRAM. num_samples returned would let the driver know the start of the read from the last push location. This way, the driver would emit the top most region of the STB DRAM. Co-developed-by: Sanket Goswami Signed-off-by: Sanket Goswami Signed-off-by: Shyam Sundar S K --- drivers/platform/x86/amd/pmc.c | 28 ++++++++++++++++++++++++++-- 1 file changed, 26 insertions(+), 2 deletions(-) diff --git a/drivers/platform/x86/amd/pmc.c b/drivers/platform/x86/amd/pmc.c index 3cbb01ec10e3..b0f98a201a81 100644 --- a/drivers/platform/x86/amd/pmc.c +++ b/drivers/platform/x86/amd/pmc.c @@ -114,6 +114,7 @@ enum s2d_arg { S2D_TELEMETRY_SIZE = 0x01, S2D_PHYS_ADDR_LOW, S2D_PHYS_ADDR_HIGH, + S2D_NUM_SAMPLES, }; struct amd_pmc_bit_map { @@ -246,13 +247,36 @@ static const struct file_operations amd_pmc_stb_debugfs_fops = { static int amd_pmc_stb_debugfs_open_v2(struct inode *inode, struct file *filp) { struct amd_pmc_dev *dev = filp->f_inode->i_private; - u32 *buf; + u32 *buf, fsize, num_samples, stb_rdptr_offset = 0; + int ret; buf = kzalloc(S2D_TELEMETRY_BYTES_MAX, GFP_KERNEL); if (!buf) return -ENOMEM; - memcpy_fromio(buf, dev->stb_virt_addr, S2D_TELEMETRY_BYTES_MAX); + /* Spill to DRAM num_samples uses separate SMU message port */ + dev->msg_port = 1; + + /* Get the num_samples to calculate the last push location */ + ret = amd_pmc_send_cmd(dev, S2D_NUM_SAMPLES, &num_samples, STB_SPILL_TO_DRAM, 1); + if (ret) { + dev_err(dev->dev, "error: S2D_NUM_SAMPLES not supported : %d\n", ret); + return ret; + } + + /* Clear msg_port for other SMU operation */ + dev->msg_port = 0; + + /* Start capturing data from the last push location */ + if (num_samples > S2D_TELEMETRY_BYTES_MAX) { + fsize = S2D_TELEMETRY_BYTES_MAX; + stb_rdptr_offset = num_samples - fsize; + } else { + fsize = num_samples; + stb_rdptr_offset = 0; + } + + memcpy_fromio(buf, dev->stb_virt_addr + stb_rdptr_offset, fsize); filp->private_data = buf; return 0; From patchwork Mon Jan 30 16:48:53 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shyam Sundar S K X-Patchwork-Id: 13121441 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6AD79C54EED for ; Mon, 30 Jan 2023 16:49:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236454AbjA3Qto (ORCPT ); Mon, 30 Jan 2023 11:49:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49160 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236494AbjA3Qtn (ORCPT ); Mon, 30 Jan 2023 11:49:43 -0500 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam02on2045.outbound.protection.outlook.com [40.107.212.45]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 457523CE36 for ; Mon, 30 Jan 2023 08:49:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MH1RawyCPpeI78L76bhxDqLojsxy966aijjkloN/FvgHNPAEVWbaj+kPUJB+idxm2aXWeRxLyDQBVvtE1smwGqmVqHtChni5UkjRxeY8hAiFEagxvI0CYl1+BndYlOtMntM/1AX70O0BTKC9B5IXacUdyN6p/8jpVLi5aCvJ+9U3Zi1urttGOlydvOoqpdTFTu5Ic7i3WYXq/1wuj5WKdGGNK2kNCacjzFngHIfHimP9nRZV9n9XX/fc2TnYCiCc7kU6a3yiJ7VpC6lQfVzbvU5VX7J2+iXkwT/I/GU9/+pvyaFI74P5NyYkyMo6mYpockehNDgccDwcYFZ2QMCzdg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mXKcYeq/C6+k88yHRt7RR81nRFIoeF3UaX7kmaWFk+s=; b=hmuF+hiFZphMfIIgaX/ck5PHdw8W89alBnd7A02oaxDpoDdE9duGXvb48Bd85SrVQmtcyHQJiUzgV5Z/yQyyyjhrqz1NihMJCNZoiv1ko2CpCjLjV0ypUS9zLCcYV/NtbtnfeHM311VczSWf5VGIEXke6A6ykAkNNjDhUafvuiSRutM5D+rjgYCILptCreNR102cTqQheqG+tAODTI2wVtcY/KdiksonxDAA2gY/UdCGP1/ENKZ/gSmSiPhMvhEhDIjWGrI4rbw+ThEsm8EXnKT1iYCZM7CEbj3vMBcb4HI1XfpsvpyTgXkYrp1/vIe2S7Vw3OHy2kCP1KCnDhvJ/A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=redhat.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mXKcYeq/C6+k88yHRt7RR81nRFIoeF3UaX7kmaWFk+s=; b=wUeI21yrkoSRYzuj5MZ9QLNAa75KMzSOWeouv7KaHROwc5WoLqusg6PFZlwzk1cvqhWBrsohRLomh6DIguD5Ip30UhVWgz0VXP4lueZZ92gbiF0mMy1E8nWqnb/iexjJNCmBpibbbK2x0cIfvdQKPYAbfevvdq/9fjXhZSLZACY= Received: from CY5PR15CA0217.namprd15.prod.outlook.com (2603:10b6:930:88::6) by BL1PR12MB5851.namprd12.prod.outlook.com (2603:10b6:208:396::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.36; Mon, 30 Jan 2023 16:49:39 +0000 Received: from CY4PEPF0000C97D.namprd02.prod.outlook.com (2603:10b6:930:88:cafe::34) by CY5PR15CA0217.outlook.office365.com (2603:10b6:930:88::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.36 via Frontend Transport; Mon, 30 Jan 2023 16:49:39 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CY4PEPF0000C97D.mail.protection.outlook.com (10.167.241.136) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6064.17 via Frontend Transport; Mon, 30 Jan 2023 16:49:38 +0000 Received: from jatayu.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 30 Jan 2023 10:49:36 -0600 From: Shyam Sundar S K To: , CC: , , "Shyam Sundar S K" Subject: [PATCH v2 2/4] platform/x86/amd: pmc: Write dummy postcode into the STB DRAM Date: Mon, 30 Jan 2023 22:18:53 +0530 Message-ID: <20230130164855.168437-3-Shyam-sundar.S-k@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230130164855.168437-1-Shyam-sundar.S-k@amd.com> References: <20230130164855.168437-1-Shyam-sundar.S-k@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000C97D:EE_|BL1PR12MB5851:EE_ X-MS-Office365-Filtering-Correlation-Id: 9dc968b4-59fe-4868-d981-08db02e1fa19 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gsXWnIvATMKoLYMdldRD+usD2pjSzc4Fnji6EDuQb91dnxP7LdgCAxgnv2fkjreVOlLdi8i+JanWKPww/zyc861IwfeedQ0PoUdQHfeNgxSo815BiKx3k+w42EKQPNKaJgTVMFZRh65ywryoQ2imWvIIh8CaotXoE4bYjkkW0UVxgg7j2MtXqujwT9dk4z4tpF1KU1RKOSEdzOxgF+wtiK5PYfklKBToekwQtpiFP79927vnJdTHEzsj07cZgrWJnI70A6ZgXkW0kLYVAmL2eKzIvGeHf8ArCb308kyTksgPeAI6uDWcTatY9wkcSVJttlfbc2Y2Kd9Mb8DVV1eK23Igc6biwNU9fuzbbiYPFP9pHFbFvI2Gy+PK0ZeoVV7jz0M+OibtMaqfA33wU/ylhl4frWgO+dfZy1mvOWCKDAASkyfSViUHJzC2iM+gzVJKgbaZ66AMbkiS3PUkhvfXOakX3TOSUEUngJjQFzn1ur9qHUKsf4Jnwhg8k9d3zvle8SPMefQHZu7GjP/9EFk1jNBZNh5LzPOTM2M0bBaOmUB8OAUtOj0eT/VecpeTuwbqnMiHJYfEwoyfrG4JxC5W1BtBUqOsF+n5tNjhgiav5Qi56V+vfACMB7dA+ioyB0iH4MIdSdsD9lCvtvvCnLCj8vNRhmsSy58gn3hECYRptN+lv7LrJMF/2+peQl1WFlcQ7BJ+xWEJznIDoR3/l4+fHVjPgPim9Xlxk7WzOOUm2d0= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230025)(4636009)(39860400002)(396003)(346002)(376002)(136003)(451199018)(36840700001)(46966006)(40470700004)(83380400001)(2616005)(336012)(426003)(47076005)(86362001)(82740400003)(82310400005)(356005)(81166007)(2906002)(7696005)(40460700003)(36756003)(36860700001)(1076003)(26005)(186003)(478600001)(16526019)(6666004)(40480700001)(110136005)(8676002)(8936002)(41300700001)(4326008)(54906003)(5660300002)(70206006)(316002)(70586007)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jan 2023 16:49:38.8858 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9dc968b4-59fe-4868-d981-08db02e1fa19 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000C97D.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5851 Precedence: bulk List-ID: X-Mailing-List: platform-driver-x86@vger.kernel.org Based on the recommendation from the PMFW team in order to get the recent telemetry data present on the STB DRAM the driver is required to send one dummy write to the STB buffer, so it internally triggers the PMFW to emit the latest telemetry data in the STB DRAM region. Reviewed-by: Hans de Goede Signed-off-by: Shyam Sundar S K --- drivers/platform/x86/amd/pmc.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/platform/x86/amd/pmc.c b/drivers/platform/x86/amd/pmc.c index b0f98a201a81..4073ad9fe63a 100644 --- a/drivers/platform/x86/amd/pmc.c +++ b/drivers/platform/x86/amd/pmc.c @@ -43,6 +43,7 @@ #define AMD_PMC_STB_S2IDLE_PREPARE 0xC6000001 #define AMD_PMC_STB_S2IDLE_RESTORE 0xC6000002 #define AMD_PMC_STB_S2IDLE_CHECK 0xC6000003 +#define AMD_PMC_STB_DUMMY_PC 0xC6000007 /* STB S2D(Spill to DRAM) has different message port offset */ #define STB_SPILL_TO_DRAM 0xBE @@ -250,6 +251,11 @@ static int amd_pmc_stb_debugfs_open_v2(struct inode *inode, struct file *filp) u32 *buf, fsize, num_samples, stb_rdptr_offset = 0; int ret; + /* Write dummy postcode while reading the STB buffer */ + ret = amd_pmc_write_stb(dev, AMD_PMC_STB_DUMMY_PC); + if (ret) + dev_err(dev->dev, "error writing to STB: %d\n", ret); + buf = kzalloc(S2D_TELEMETRY_BYTES_MAX, GFP_KERNEL); if (!buf) return -ENOMEM; From patchwork Mon Jan 30 16:48:54 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shyam Sundar S K X-Patchwork-Id: 13121442 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD560C54EAA for ; Mon, 30 Jan 2023 16:49:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236704AbjA3Qtq (ORCPT ); Mon, 30 Jan 2023 11:49:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49160 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236494AbjA3Qtp (ORCPT ); Mon, 30 Jan 2023 11:49:45 -0500 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2051.outbound.protection.outlook.com [40.107.220.51]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7ECCA3D0A4 for ; Mon, 30 Jan 2023 08:49:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Wl0M5Bk5EjdsgRbECd7gJF1J7eZOapx9DF8/CRDDxY2Z0McsYHEG1BwJhmLOelXXM41EVh8Hyt7tr+iwSo5lgk87zgFuxLhRGmu7jmn6UNN6Bk24cJbeTQKAgUt/2sVaaqEIb1zQ1M2dSZNaHs+/rJV53MMTCNoc3Pii3oK99pZ3nNeOI9Orav9M5CRVXkhKekd0nK+Nip9/vZTCtFvLjxv8S6t+n+Z3zmcsPGFio2xN0sjRqxthiCizVbSE5RlPleHZa1mhWptvvGntQ1GhgLIsgJJ2KpDHJ0moZU+NX5osa7JLATBTrm2A6EhPQINu9W5BxnUKeqbXAHaYIwURQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RiLjLbf25W+tnxMUwClA/DXcLG2Do+dvrejjyGvoOsw=; b=JeBbAIvClc2lz3gXLeQXBeg2Bjz62adzXrImjcgo5DRpClzvEI5cOXXbQuW1mOuF2rfZUAJ1FAAVzbJ1vUuMHpJ1xJF/DvewOMNoX8MMLRTmlsIKbglf+4OkIbj2h1u1k1/btfX35FDg0yDmSu4AcUwVEBlzyBnpoLkHymkj04Wcv4pDTS6hjFiEFgzaVeDXr6QZDaUo1Tg1z3uFaDljyvnHcMY48X9pAoTIoI7wfrs3vW1MpKvkqlaXmfbZsF4//XRBeLYlWlxvN+u/MkFo5DWQrIPiGgng0d/b88OK+g2KHpIVeEw10JlHPHo1xUyeKh04X2Mo5Pgg9aEMf8T4rA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=redhat.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RiLjLbf25W+tnxMUwClA/DXcLG2Do+dvrejjyGvoOsw=; b=DQO9NpG0PglyEzJCwj104OjFptSc8sp5S8oyF243OKNixRbC7LD1GlgG2iZbVE2tkvMbQB2X/fPZ4PJpwSoZjZEhZ/yTpktOy4j6wNeSms6cW/ZfZxNsZ4u/+aTR/uihkXw/5ZuCI/dSpa6UYrwWGvYsfGkS1DRH6l8l8RVJ598= Received: from DM6PR08CA0053.namprd08.prod.outlook.com (2603:10b6:5:1e0::27) by DS0PR12MB7802.namprd12.prod.outlook.com (2603:10b6:8:145::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.28; Mon, 30 Jan 2023 16:49:41 +0000 Received: from CY4PEPF0000C97A.namprd02.prod.outlook.com (2603:10b6:5:1e0:cafe::35) by DM6PR08CA0053.outlook.office365.com (2603:10b6:5:1e0::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.36 via Frontend Transport; Mon, 30 Jan 2023 16:49:40 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CY4PEPF0000C97A.mail.protection.outlook.com (10.167.241.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6064.17 via Frontend Transport; Mon, 30 Jan 2023 16:49:40 +0000 Received: from jatayu.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 30 Jan 2023 10:49:38 -0600 From: Shyam Sundar S K To: , CC: , , "Shyam Sundar S K" Subject: [PATCH v2 3/4] platform/x86/amd: pmc: differentiate STB/SMU messaging prints Date: Mon, 30 Jan 2023 22:18:54 +0530 Message-ID: <20230130164855.168437-4-Shyam-sundar.S-k@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230130164855.168437-1-Shyam-sundar.S-k@amd.com> References: <20230130164855.168437-1-Shyam-sundar.S-k@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000C97A:EE_|DS0PR12MB7802:EE_ X-MS-Office365-Filtering-Correlation-Id: 120cea53-5204-4b22-6cdc-08db02e1fb39 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Id+7wFdgROdSMfHqZ/K+puTPCgmNUdxyPq8XC3Yva9jm5FUkGGMbSXmhTypN/6l7mXRkU4TTz3mo8S5a91fPVA8lbGuWMo4PuBC2sosFSnRwY5xONvcErwVuadrfXNNcZSi71MsTHDoRRD6O6PTrKv3lDRbJkrxePGqxeV7xHqEbc4CTDdaN4QtWmHhVeiU63QojuPaaYTtjRVSJUncLErKpnBTyUjR3fgdWt9iH82F6ZF3qQmb25dBet7LMC0sFVwfo364GpsXAViRZdtg6/coVGOSicuGgmfIPYbW0Y956gzoaPzOuvfFcRkltfuuqjKFFASzdVhl6iT5GUng8Xc3/rXVbthly8ZXAn/t/BNZ2R1cFi9Np0TcKoM4jb+YJ1mYVe+N3Vh3q2dMh2CP31ot3tuqPGRh8xLpc56YyA9ytIwrT7ahF2jxmfLq+mPnTcamHjZm6m4dg4jKM0HWN60FokgeFY5oPdoqrTaG0f7icqPp4MKdhM2JUVpEh+cGiuKjDWB22PSRWtElx4hXqqeDdROkkDDs15J7TpTHJR5lUpbII8MTLMiWvtrM4Sai8Rma6fws1OriVmiDxEr0ODdxxbZdhuQ32kQ3ZYJRfR7Pl4FkUh2f/t+77iOVd6HKxFeXqkEmoZfPKdHKVs9BUTetCgzGaxX6vCX7liv5wQJzt0jHGoHset5NRHN1JuVNHH9LALVrPdt+c7VlljXvWThgNcQVQPJpoTDG8EX7C8Qk= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230025)(4636009)(39860400002)(376002)(136003)(396003)(346002)(451199018)(36840700001)(46966006)(40470700004)(36756003)(2906002)(6666004)(478600001)(110136005)(54906003)(7696005)(81166007)(356005)(82310400005)(86362001)(41300700001)(426003)(336012)(47076005)(1076003)(4326008)(316002)(70206006)(40460700003)(8676002)(8936002)(5660300002)(2616005)(40480700001)(16526019)(186003)(70586007)(82740400003)(36860700001)(83380400001)(26005)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jan 2023 16:49:40.7705 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 120cea53-5204-4b22-6cdc-08db02e1fb39 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000C97A.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB7802 Precedence: bulk List-ID: X-Mailing-List: platform-driver-x86@vger.kernel.org Modify the dynamic debug print to differentiate between the regular and spill to DRAM usage of the SMU message port. Suggested-by: Sanket Goswami Reviewed-by: Hans de Goede Signed-off-by: Shyam Sundar S K --- drivers/platform/x86/amd/pmc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/platform/x86/amd/pmc.c b/drivers/platform/x86/amd/pmc.c index 4073ad9fe63a..9c8d04a591ec 100644 --- a/drivers/platform/x86/amd/pmc.c +++ b/drivers/platform/x86/amd/pmc.c @@ -590,13 +590,13 @@ static void amd_pmc_dump_registers(struct amd_pmc_dev *dev) } value = amd_pmc_reg_read(dev, response); - dev_dbg(dev->dev, "AMD_PMC_REGISTER_RESPONSE:%x\n", value); + dev_dbg(dev->dev, "AMD_%s_REGISTER_RESPONSE:%x\n", dev->msg_port ? "S2D" : "PMC", value); value = amd_pmc_reg_read(dev, argument); - dev_dbg(dev->dev, "AMD_PMC_REGISTER_ARGUMENT:%x\n", value); + dev_dbg(dev->dev, "AMD_%s_REGISTER_ARGUMENT:%x\n", dev->msg_port ? "S2D" : "PMC", value); value = amd_pmc_reg_read(dev, message); - dev_dbg(dev->dev, "AMD_PMC_REGISTER_MESSAGE:%x\n", value); + dev_dbg(dev->dev, "AMD_%s_REGISTER_MESSAGE:%x\n", dev->msg_port ? "S2D" : "PMC", value); } static int amd_pmc_send_cmd(struct amd_pmc_dev *dev, u32 arg, u32 *data, u8 msg, bool ret) From patchwork Mon Jan 30 16:48:55 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shyam Sundar S K X-Patchwork-Id: 13121443 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9EB78C54EED for ; Mon, 30 Jan 2023 16:49:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236494AbjA3Qt6 (ORCPT ); Mon, 30 Jan 2023 11:49:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49204 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237237AbjA3Qtt (ORCPT ); Mon, 30 Jan 2023 11:49:49 -0500 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2055.outbound.protection.outlook.com [40.107.243.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B42F8EF85 for ; Mon, 30 Jan 2023 08:49:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bbyqfHBG6k+QPWDMipvKXBnPh+7BMyQgk5YR0xR70xRD7XM3GsxtC3pAUp5CKmvWOGQAWaBd/V3QfJmapaM7G2lcMRYQwN6VLi7+wwj0FfTKc0a2ZMR91eCaYqSvVVrdkR86xd1/XoCcaZcpHPjdg9iS+2uEgiL4fbypnbVstcVfSb2TBIdBXRbB2oe9l+cwVlxi8ePNuWOu2XwUYN/pMhr4/qfwlC5NL+yOl2EUf9YNzHIa5Vo4VKj3dyHOmCDTk897Bpe8OuVTSQgNNwgUZst3OE+d7bpiHpo0rD/7HXveRXZtIisxl1d6/wkaaiqFTOZQz02Idm9bGlSL351Wgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Q0ioLbqG47R5Aoj09C5GlC4uRZFhm8tM1XNt8tTlEQk=; b=GnWOadO5EKBg+ukhEijs/WBjWMnoDkCYJjkD+dlmNKM8tKgLWdE7qLgJgtsHUAz+MDw4sPwrD1BYT4uTE238tqD/rn+Fh7tVTUdNyIfeyp4JjN58WlJMRYIEJPUPChclaDAQoPJo6Tt+tF29TQI0PK6MspvQqzWwwlWrTeiH8LKV2TuDPpv7olgfatnFpcdwTteOCZ6kJNenS4ZUB8S9RyX8WOaTaiSBZIWngPro4EVn+UtGmIZMtTG+Vmm0HPI6IAozbiXqz3fyHx2Pk+rneu75VuCx1sxWB7sIcYZ5HmxOGZx+nk4oB+AQAII/U2yVi4P7ja0Jy98k/qTBmF2oug== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=redhat.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Q0ioLbqG47R5Aoj09C5GlC4uRZFhm8tM1XNt8tTlEQk=; b=GLHi8DKt9MAByXwPaBKmulVJq1VyKI3ALp9qfrnUFh2YQwvlGYhjw//zZdFoRHDHr+7HUJafetfjdciQ3UptUJ+ESMi7FNTpTN7nryaKfRM3EOZLKYcvtpRimpS5NPcESU12NVvcOYYzhMYzQ9ukrLzS3tU4cJqeRd8myO+DHGM= Received: from CY5P221CA0007.NAMP221.PROD.OUTLOOK.COM (2603:10b6:930:b::14) by CY8PR12MB7706.namprd12.prod.outlook.com (2603:10b6:930:85::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.36; Mon, 30 Jan 2023 16:49:44 +0000 Received: from CY4PEPF0000C976.namprd02.prod.outlook.com (2603:10b6:930:b:cafe::6b) by CY5P221CA0007.outlook.office365.com (2603:10b6:930:b::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.36 via Frontend Transport; Mon, 30 Jan 2023 16:49:42 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CY4PEPF0000C976.mail.protection.outlook.com (10.167.241.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6064.19 via Frontend Transport; Mon, 30 Jan 2023 16:49:42 +0000 Received: from jatayu.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 30 Jan 2023 10:49:40 -0600 From: Shyam Sundar S K To: , CC: , , "Shyam Sundar S K" Subject: [PATCH v2 4/4] platform/x86/amd: pmc: Add line break for readability Date: Mon, 30 Jan 2023 22:18:55 +0530 Message-ID: <20230130164855.168437-5-Shyam-sundar.S-k@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230130164855.168437-1-Shyam-sundar.S-k@amd.com> References: <20230130164855.168437-1-Shyam-sundar.S-k@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000C976:EE_|CY8PR12MB7706:EE_ X-MS-Office365-Filtering-Correlation-Id: e6cba4a4-3be5-417d-a54e-08db02e1fc62 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2qPTt2bfsmmNnFNp50IMW0vJg3ybua/JydfEt/Di+jnlxvHrsmC2ocqsg7EpzeSDdG0rIRMAqT9YDac2gb3ndgVUVY3Fwnc02+CRnoF6hvpXMVbtG2dq6rXsuqrxM5MjX6WjkAxI/HHBEipTm+DXGXObUvpqxlkGFvyVRnFDsZ5XsSzuD9VKIKv3bq0fCoj/HiB/Kwl4BixW70RXPb0rr4fH/+Z6qzVsHRKZeWrKBV63nVJXJNhf2u1ipWBRveoECc1vq+XROSQq+OFT1x2weZOvVmAyqD9PeKA/yrSk3SXkPVh7s1WgKMqhjsEFAW1O459Ma/0zcJ8xAH23S/liEAJZPOVzLGPkrlpTM7zgXrYd6vkdpH+6SsQMMeuUFbF1Q5o4fxbKl4KZcYPqd2DPFtLxC55PewXdGs/Fh0sBQR+agFv7h8v0eo4EtsldkUlrbwu6jJVeB6h0zsGF4le2Aiy8MraZ904H/USDOxDi3MiLhGnDABWb9pyC1oLxTN9NqGJyhBSPJ5xHklMmWYlybTq/uzS3pqAcYOJujMAsp4eF9kihTaU4tqEwDOKKYTRhWFDmlaEYtylMEDvqUorhSdd6JgfZqsPb2LzBZuowI8zoE+tunqeTA41aMoCLB2o/VZ+3DcJeJH2/LgVvreJZ0DgVinLpHCAJgygnAgIWs8hSBNIYHRl8Z1rLeZUaCGeBoCWmxGy8IbaLgFZxwDwgvJcKM4WN6FFkRa/LonriBBI= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230025)(4636009)(346002)(376002)(396003)(39860400002)(136003)(451199018)(46966006)(40470700004)(36840700001)(8936002)(81166007)(41300700001)(356005)(40460700003)(86362001)(4744005)(5660300002)(426003)(47076005)(336012)(36860700001)(2616005)(110136005)(54906003)(82740400003)(316002)(70586007)(16526019)(70206006)(4326008)(40480700001)(8676002)(6666004)(26005)(1076003)(7696005)(186003)(36756003)(478600001)(82310400005)(2906002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jan 2023 16:49:42.7184 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e6cba4a4-3be5-417d-a54e-08db02e1fc62 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000C976.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB7706 Precedence: bulk List-ID: X-Mailing-List: platform-driver-x86@vger.kernel.org Add a line break for the code readability. Reviewed-by: Hans de Goede Signed-off-by: Shyam Sundar S K --- drivers/platform/x86/amd/pmc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/platform/x86/amd/pmc.c b/drivers/platform/x86/amd/pmc.c index 9c8d04a591ec..6a5ddd0f1e8c 100644 --- a/drivers/platform/x86/amd/pmc.c +++ b/drivers/platform/x86/amd/pmc.c @@ -105,6 +105,7 @@ #define DELAY_MIN_US 2000 #define DELAY_MAX_US 3000 #define FIFO_SIZE 4096 + enum amd_pmc_def { MSG_TEST = 0x01, MSG_OS_HINT_PCO,