From patchwork Tue Jan 31 06:32:06 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?b?S3Vhbi1ZaW5nIExlZSAo5p2O5Yag56mOKQ==?= X-Patchwork-Id: 13122283 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88EA0C636CD for ; Tue, 31 Jan 2023 06:32:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0F2286B0072; Tue, 31 Jan 2023 01:32:49 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0A23B6B0073; Tue, 31 Jan 2023 01:32:49 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EAB176B0074; Tue, 31 Jan 2023 01:32:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id D86E96B0072 for ; Tue, 31 Jan 2023 01:32:48 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 85428C068B for ; Tue, 31 Jan 2023 06:32:48 +0000 (UTC) X-FDA: 80414126016.12.8BE25E5 Received: from mailgw01.mediatek.com (mailgw01.mediatek.com [216.200.240.184]) by imf19.hostedemail.com (Postfix) with ESMTP id 8C1FD1A0016 for ; Tue, 31 Jan 2023 06:32:45 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=mediatek.com header.s=dk header.b=EmeyFqQE; dmarc=pass (policy=quarantine) header.from=mediatek.com; spf=pass (imf19.hostedemail.com: domain of kuan-ying.lee@mediatek.com designates 216.200.240.184 as permitted sender) smtp.mailfrom=kuan-ying.lee@mediatek.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675146766; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=gfOqWGWbqteN5psBJELTgrd0wVgMuYJEk7v1sLB2r3c=; b=ggU5zgae+H4hcOzZsG5E9dVO1oudyF7fKdB3vQtHHnip5dg6EtTf7x6TFHdyI7g6XfMxpK UoZ6ZYvNjr2b4DlkbYUfrSfGPKfCH22e6lqVURHIPhEYaEdQ+y5LPv2vx3zp5d6phn/dFt eoXDpt8z5TbHddeD1hDQuiS8kZOZ4zw= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=mediatek.com header.s=dk header.b=EmeyFqQE; dmarc=pass (policy=quarantine) header.from=mediatek.com; spf=pass (imf19.hostedemail.com: domain of kuan-ying.lee@mediatek.com designates 216.200.240.184 as permitted sender) smtp.mailfrom=kuan-ying.lee@mediatek.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675146766; a=rsa-sha256; cv=none; b=EflhrtYinGYMgLCj2beO5ky1qhtUqT8Npi258KharqfxYNV/8UJOojKj1BrtbDuazA6iLD zGJKCrR8xMieUwOv/e67Jq6FAvjXoP0+AKWCSytu3D/s7eGbrpV2w9Fqp19aAwWNUhnVE/ 1NvJZXiC4slCo8XcX2kbY/EN8f2YCDQ= X-UUID: 0cbbdc1ca13111edbbe3f76fe852e059-20230130 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Type:MIME-Version:Message-ID:Date:Subject:CC:To:From; bh=gfOqWGWbqteN5psBJELTgrd0wVgMuYJEk7v1sLB2r3c=; b=EmeyFqQEGvSyO1agWudyGOX39L6kPSMbVCy5GwksUJM9hOr9TMAkvG5dud3bwDQ5hUS3ffNwmhHOnGxhb6jcaPRtELtOp/tuVgxUG43cvJuI29VFMZkCdb6v71hF7P8UFYBxDjGKjRgKWvh6o+C2/l6z5jijjHv1JlnlA1V1ELw=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.18,REQID:cfcfd129-8e40-4381-aa7d-4da2bc68448c,IP:0,U RL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION: release,TS:0 X-CID-META: VersionHash:3ca2d6b,CLOUDID:e9a6d455-dd49-462e-a4be-2143a3ddc739,B ulkID:nil,BulkQuantity:0,Recheck:0,SF:102,TC:nil,Content:0,EDM:-3,IP:nil,U RL:0,File:nil,Bulk:nil,QS:nil,BEC:nil,COL:0,OSI:0,OSA:0 X-CID-BVR: 0 X-UUID: 0cbbdc1ca13111edbbe3f76fe852e059-20230130 Received: from mtkmbs11n1.mediatek.inc [(172.21.101.185)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 1895450219; Mon, 30 Jan 2023 23:32:35 -0700 Received: from mtkmbs13n2.mediatek.inc (172.21.101.194) by mtkmbs10n2.mediatek.inc (172.21.101.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.792.3; Tue, 31 Jan 2023 14:32:15 +0800 Received: from mtksdccf07.mediatek.inc (172.21.84.99) by mtkmbs13n2.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.792.15 via Frontend Transport; Tue, 31 Jan 2023 14:32:15 +0800 From: Kuan-Ying Lee To: Andrew Morton , Matthias Brugger , Alistair Popple , John Hubbard CC: , , Kuan-Ying Lee , , , , Subject: [PATCH] mm/gup: Add folio to list when folio_isolate_lru() succeed Date: Tue, 31 Jan 2023 14:32:06 +0800 Message-ID: <20230131063206.28820-1-Kuan-Ying.Lee@mediatek.com> X-Mailer: git-send-email 2.18.0 MIME-Version: 1.0 X-MTK: N X-Rspamd-Queue-Id: 8C1FD1A0016 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: dn7n3wbnyzy65oxqepdt19aoby1zwrs9 X-HE-Tag: 1675146765-733253 X-HE-Meta: U2FsdGVkX18S8uu14nlg93Ce8lL8bo4c5DuCegNaxtX8vScL2/JD4li6QeUd4DbbVsB2tevYiXsF5pc85+ttBiBrw9t7k138U5Flnfepfe2npyMhRMP7Gc+X2w4UlfKeFFjCotKbSDTMaL6qopdNQEyRjqsmBdEEPqWRCCFh5CmeRjaRP5yDuPuHglhaiNUQBTVLkxIXaYSfKbloAUTypGROy9Vqz5v2QPbfqeELTvlBpp6dAGWGI1eg965rR06o7pWrYLxnUmCCJsM59IpGsg8M4TeJ0AnxgTOoe68joyYZKRPOhJqe7amv2DpGaceX5TWP4Cs+FwQ00IjOy9+orQxngqce7x5oDxAQceDsPzfBo395g665l8oggsJNkb45tyAhK8AzfXewQVsxcJsUUQAQnl6TP5zu8YA2RmtIY11ryf4bGMn6Z8DOqifIdvcn3MFlYERojaPWjcau6J8n61s6h07ws1Ou2Gb5F/1k6hp+Le1bLC+Dr7ri4vYyqceCeVVZSieNq9hb8ZBVZzaWqlv7vfCVBi7jy9vSDvpwBfj5XwdUZXMh0xrT+8TEofn0o9ugwFahLrpnYlYN0B/MLVk7JlQlbQaelo8DH0uSWLybdmM/cNxyxCX6aBr8jSSJRgZObPdrJgSeFMGwBkEYY0YXCPSM4Cv1wNFT/fmR3bI2KC+IeSSpv/3uAn8UQ6EyyRi6DliqgLv8Us3b9Bb3DRj9zlpyzM0Rz4jv9BUPrIdmPvDFSWyIashKdLgU38CasiiBTmL5gr/Ksm7Onazr5X8hS3761qpKbUOuKkd9v8OhSUTH1LQSkNANJV8T+2QdnMlfA1O89Yu3EVBgbS7U2zWkCzwL9a10wk+WPfwBYjiKeltxrS4Wz3n4hVOQblkLZ6vsussDS8j2Z96fYodNyDs74oJ81RA0NxQFd0Q0uFR18VyrfXYF8dteBdC/B2IdiFeca8urN5bgn5xj0I0 cLHMoob+ TlRJjDFh//WQy0MAwzODQ80z29vo27Nva9T0+9k6ckkQckiTeprmMwfHwfg0XQKatqrSUiwkaNUxuCtcWSoPNtEvBHRPSqKQcxSm0foLoghb9gRrS9VEthfWXfwVbGnWulQiZPVX4Kj2z1e7Su+qh2ADsHkmAE2RWle+v2DQ2If+T/jf6LlopwHpdYROty1wUMBM+zWQNnWEZDzeV2CBvOkMOyEVRJI1sF9kZJQH0OfzBghuzQI5X7fF35KBDorPH2Glm2gWMCuViWeNO+yjC87HwmGW++68w3T04+wtEhxyh1fUx4aeG9Q1WfA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: If we call folio_isolate_lru() successfully, we will get return value 0. We need to add this folio to the movable_pages_list. Fixes: 67e139b02d99 ("mm/gup.c: refactor check_and_migrate_movable_pages()") Signed-off-by: Kuan-Ying Lee Reviewed-by: Baolin Wang Reviewed-by: Alistair Popple Acked-by: David Hildenbrand --- mm/gup.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/gup.c b/mm/gup.c index f3d2cccb89f8..918c364d01ac 100644 --- a/mm/gup.c +++ b/mm/gup.c @@ -1914,7 +1914,7 @@ static unsigned long collect_longterm_unpinnable_pages( drain_allow = false; } - if (!folio_isolate_lru(folio)) + if (folio_isolate_lru(folio)) continue; list_add_tail(&folio->lru, movable_page_list);