From patchwork Wed Feb 1 16:40:56 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marc Zyngier X-Patchwork-Id: 13124736 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1D75EC38142 for ; Wed, 1 Feb 2023 16:42:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=lHPD5ryvVR5CAunEWjn6gVFG1v8v5nNDyQ+WUD0ZQdg=; b=iUU6boJGs9wBXk 931glg2ALgynsJ6V8nDSIBv40FGHsrgaGhJ+SHamzp2l3InH8BSJs889u6xFqaZf5aCTJg3F9PMZj gZL9fIsMl8Xhe9vEr5BPB9gytxuT+1/L2Gff8zEZ7vxph6mOgV8q4Hg3HBeLY1ZDQ05LKFH/Qvo8H 3hcNNclectDQ0FrPDggiIvKSFAmTnMk85bY7qUYLfs3sLYhxkXZSjlh0BZWMC+sCOnAThncZ0c2sU gpmbB+Aj9W1+US1uzjgn90VaeMGt9yeXN0ePIoo5Q+2lP2X2UFLGZi2GZqvHX9u3lgq34oo/BmUa0 57CwzuvT/6HlQzViLUFg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pNGAk-00Cr0p-9G; Wed, 01 Feb 2023 16:41:22 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pNGAc-00Cqz5-SG for linux-arm-kernel@lists.infradead.org; Wed, 01 Feb 2023 16:41:16 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3CBE16185C; Wed, 1 Feb 2023 16:41:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A5370C433EF; Wed, 1 Feb 2023 16:41:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1675269673; bh=a8VOca+QniEvdF4EQd1Ik351xx1oiB6pY475DXdYSN8=; h=From:To:Cc:Subject:Date:From; b=OfNVYOrWxOGHDtsqZOcRnqPwxHF2VscNbFwjzYDqZmhGgd2FprCtmi8BGwd1jWnd6 mpUUtSQPicyd6TrqiJduPebaWXRPiK82T5Zb2p7kPKz7j4rNm1S2FHK4SNmyN6RpO4 7V/ZQQE3I/KzL6XqiA899torX/pMu4C4uwG6CtWEthBCZ4BE5yNJ5Hbq95h+3jbjco +x7wFsvR5R6wMACnkiiMy3A+kBu8wuuF/N2549cQmGew2KvwjFEAq25g4mkh600ZDE OJK1EcXKBsJo9eEg9YsxyMzkXn5TJ4Wb08YrWtNWdBKOQY4o3BebV5lelP+62Uw2F7 BX9v+Wxlo5sjg== Received: from sofa.misterjones.org ([185.219.108.64] helo=valley-girl.lan) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pNGAZ-006ZnZ-Bz; Wed, 01 Feb 2023 16:41:11 +0000 From: Marc Zyngier To: linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org Cc: Hector Martin , Oliver Upton Subject: [PATCH] irqchip/apple-aic: Correctly map the vgic maintenance interrupt Date: Wed, 1 Feb 2023 16:40:56 +0000 Message-Id: <20230201164056.669509-1-maz@kernel.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org, marcan@marcan.st, oliver.upton@linux.dev X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230201_084114_972849_ECAE1777 X-CRM114-Status: GOOD ( 13.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org We currently allocate the vgic maintenance interrupt by calling into the low-level irqdomain code. Not only this is unnecessary, but this is also pretty wrong: we end-up skipping a bunch of irqdesc state setup A simple "cat /proc/interrupt" shows how wrong we are, as the interrupt appears as "Edge" instead of "Level". Instead, just call the standard irq_create_fwspec_mapping(), which is the right tool for the job. Duh. Signed-off-by: Marc Zyngier Reviewed-by: Hector Martin --- Notes: This applies to Oliver's kvm-arm64/apple-vgic-mi branch. drivers/irqchip/irq-apple-aic.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/irqchip/irq-apple-aic.c b/drivers/irqchip/irq-apple-aic.c index 09fd52d91e45..76ee7c5e7b7e 100644 --- a/drivers/irqchip/irq-apple-aic.c +++ b/drivers/irqchip/irq-apple-aic.c @@ -1201,9 +1201,7 @@ static int __init aic_of_ic_init(struct device_node *node, struct device_node *p }, }; - vgic_info.maint_irq = irq_domain_alloc_irqs(irqc->hw_domain, - 1, NUMA_NO_NODE, - &mi); + vgic_info.maint_irq = irq_create_fwspec_mapping(&mi); WARN_ON(!vgic_info.maint_irq); }