From patchwork Thu Feb 2 03:10:44 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Longlong Xia X-Patchwork-Id: 13125224 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C021C61DA4 for ; Thu, 2 Feb 2023 03:12:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 993306B0073; Wed, 1 Feb 2023 22:12:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 942C76B0075; Wed, 1 Feb 2023 22:12:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 80A756B0078; Wed, 1 Feb 2023 22:12:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 64BC76B0073 for ; Wed, 1 Feb 2023 22:12:30 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 36566120A7C for ; Thu, 2 Feb 2023 03:12:30 +0000 (UTC) X-FDA: 80420878860.29.2DD5CCB Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by imf30.hostedemail.com (Postfix) with ESMTP id BEE3080008 for ; Thu, 2 Feb 2023 03:12:26 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=none; spf=pass (imf30.hostedemail.com: domain of xialonglong1@huawei.com designates 45.249.212.255 as permitted sender) smtp.mailfrom=xialonglong1@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675307548; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oVX2crRn1FAq4qTesKQvRNzmjw7BdA1Tgt3Ci5a2tCY=; b=CtLoqEXd253t6AmRXPomZqHG4yMFppSkuxbHsGg++sFfCO1b/VXiH1yXd8nO9KsHjhX1Qu r+JsXpLuKODew6XsQjcerKMqCMxhTEoaO8a72LaLFa/9K6IrGDxrBdqWSVMF7XZ5EQZ0Ry YbfUUfs7mScX8fP/K9xBG3/colwqx9s= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=none; spf=pass (imf30.hostedemail.com: domain of xialonglong1@huawei.com designates 45.249.212.255 as permitted sender) smtp.mailfrom=xialonglong1@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675307548; a=rsa-sha256; cv=none; b=WTjHvN1YCa56xdegpPSwjp2WYxxeipntJZ+izJAsOWT8e3u/9lNxw8AWqdPf1Efdwq3jgL CFT2kfmtr3OvcGUN47LZgQ9FMfrk/XoF2b5j5Sux1qHLbRK7JIQ9lF1woOHDMMAO2bmoKb SXamYiV6JEmGTtGDQNks+TC7C9cCGnk= Received: from kwepemm600003.china.huawei.com (unknown [172.30.72.55]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4P6kLM1KQXz16NMP; Thu, 2 Feb 2023 11:10:19 +0800 (CST) Received: from localhost.localdomain (10.175.112.125) by kwepemm600003.china.huawei.com (7.193.23.202) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 2 Feb 2023 11:12:21 +0800 From: Longlong Xia To: CC: , , , , Subject: [PATCH -next 1/3] devtmpfs: convert to pr_fmt Date: Thu, 2 Feb 2023 03:10:44 +0000 Message-ID: <20230202031046.1224338-2-xialonglong1@huawei.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230202031046.1224338-1-xialonglong1@huawei.com> References: <20230202031046.1224338-1-xialonglong1@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.175.112.125] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To kwepemm600003.china.huawei.com (7.193.23.202) X-CFilter-Loop: Reflected X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: a7bmh5t1pgyksg1zwo37zna4qyi4sxad X-Rspamd-Queue-Id: BEE3080008 X-HE-Tag: 1675307546-564733 X-HE-Meta: U2FsdGVkX19NeMB3qp5XaJZXPhDXv1DukoSThKnYGLmIHNxP/vFpRWforYpm03IY0qSRr/XzXGFvteEZgmuNXEPFnFvw1U9zOtfk7OEgZpeEbtEwoZw8JOBDGljqXT7kJ3Y6MrICWJBllksLYaQbD7yL5o7NVbu7JifR99SVmtXyof0D9HGpQOhhPS0jh++Foc2RfRss1CAWLRRnbRjQl2kduqD9pdQTAycYrB4h8dsVEsxNtzrXmoTxt9BWJ1MFF/JDpikpr2QlU2aTl/iZ1KZsBA/zvno6PVEqMJ0Vxvx2Da8fskLUIAc5F9vy/eU3VlC/tIJdK0XVZa4GEv0vJa41VMC/IX/eRAVPhh2FtkPYtkOWzcWxn8gn5c8n1e1+vLnJ5Usj17ENPzXW0a8XN4sqOis5hw/skHAu5LlFcC6PZWjiIQsCO5X8q+sWxPtONEI/taQxYmH44Eqqnv6fPUet7f6mKdggCMzivx4UY36TbnTC2AL7Urpqudzmk0+FFW0BMkx8ZZEAyUPie5AG6d8/scnczQf5xq6qgCCohLew/UkoDyihxtqAujNpKgzR8C4nh3mGMptBQZxl0DasKq0aWvQHottspDoeJZZn9yc1OSfkrOuQrL8tIPlB07Edv85sg426340givPyE9voQlQufhVex5loxWRDy4z/hIqq1oNAStz9FAFeqJpI9M/S9LW9Dagm54zH6OHfR/GvvltW1qtowjXIj8nywQ3bs9WuTT86PcHeUpMh7jrbC3QEfT7FcCij4m8SkZaRGwZ/tHl1LzBF5hPBjpigK9e5i5rDCK9/TB45fca4u/vGFcJsLjZaEmmXuWJevzTJ6OJ9Z4CM276QiTVPGpx2Z7Gq5lrPuOM+PNmoBLW2R+RwZ3Yxp/ssgfbmrBjtEwvo0t5T8bSHeinewVzD1asiTZa0tznXIycqw+s7XumuPFpdWL9x+KnxS9iADpDEQd3k3be KkKnSLDB //yy9Rzyg/aruq4pflD9jdHO97KjaHkaOUYJYfXa7QZUkZiK1cgXMSDZ16DlFKjvfUAf2PHw/1AsBYScj4jQyBTHgXwLto3Kze6EFUeWF7SxtT5/tmji5m1GmJj2VvtS/ciozWGK0eJGdwFUmeE6+jMsSEbGDjfPor1xGPxCRYISY3b6BgMnOJ7WxT3YP150I/zrGtK9n608zAmKync8atJk8oV43IfjtP20RtGRNSVrSL2A= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Use the pr_fmt() macro to prefix all the output with "devtmpfs: ". while at it, convert printk() to pr_(). Signed-off-by: Longlong Xia --- drivers/base/devtmpfs.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/base/devtmpfs.c b/drivers/base/devtmpfs.c index 03e8a95f1f35..ae72d4ba8547 100644 --- a/drivers/base/devtmpfs.c +++ b/drivers/base/devtmpfs.c @@ -13,6 +13,8 @@ * overwrite the default setting if needed. */ +#define pr_fmt(fmt) "devtmpfs: " fmt + #include #include #include @@ -376,9 +378,9 @@ int __init devtmpfs_mount(void) err = init_mount("devtmpfs", "dev", "devtmpfs", DEVTMPFS_MFLAGS, NULL); if (err) - printk(KERN_INFO "devtmpfs: error mounting %i\n", err); + pr_info("error mounting %d\n", err); else - printk(KERN_INFO "devtmpfs: mounted\n"); + pr_info("mounted\n"); return err; } @@ -460,14 +462,12 @@ int __init devtmpfs_init(void) mnt = vfs_kern_mount(&internal_fs_type, 0, "devtmpfs", opts); if (IS_ERR(mnt)) { - printk(KERN_ERR "devtmpfs: unable to create devtmpfs %ld\n", - PTR_ERR(mnt)); + pr_err("unable to create devtmpfs %ld\n", PTR_ERR(mnt)); return PTR_ERR(mnt); } err = register_filesystem(&dev_fs_type); if (err) { - printk(KERN_ERR "devtmpfs: unable to register devtmpfs " - "type %i\n", err); + pr_err("unable to register devtmpfs type %d\n", err); return err; } @@ -480,12 +480,12 @@ int __init devtmpfs_init(void) } if (err) { - printk(KERN_ERR "devtmpfs: unable to create devtmpfs %i\n", err); + pr_err("unable to create devtmpfs %d\n", err); unregister_filesystem(&dev_fs_type); thread = NULL; return err; } - printk(KERN_INFO "devtmpfs: initialized\n"); + pr_info("initialized\n"); return 0; } From patchwork Thu Feb 2 03:10:45 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Longlong Xia X-Patchwork-Id: 13125226 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5EB4C636D3 for ; Thu, 2 Feb 2023 03:12:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5E9CE6B0075; Wed, 1 Feb 2023 22:12:31 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 572776B0078; Wed, 1 Feb 2023 22:12:31 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 413106B007B; Wed, 1 Feb 2023 22:12:31 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 32CC76B0075 for ; Wed, 1 Feb 2023 22:12:31 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 046C480363 for ; Thu, 2 Feb 2023 03:12:30 +0000 (UTC) X-FDA: 80420878902.26.7F0991F Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by imf23.hostedemail.com (Postfix) with ESMTP id A380A14000A for ; Thu, 2 Feb 2023 03:12:28 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=none; spf=pass (imf23.hostedemail.com: domain of xialonglong1@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=xialonglong1@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675307549; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=znlQkz01T07XUFYZDSHFhwE8Fn9kYmtXmiBcD3xoUUo=; b=GfEw6Fd9V5gaXmKMaxz7La08PdXXr9lKmsu77Ejan2o+fQ6lj2kSx0e0/ctJVAFrmKJFDu CXvDANSVNeX8sa3OueggUf0o9tpTldXpgjYj+mqZPyNlKwDW/ujWSnpdq78irdAqaanBI2 Y8dxYLcvVQeuBBCe2J3+cgEvpKMw4cM= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=none; spf=pass (imf23.hostedemail.com: domain of xialonglong1@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=xialonglong1@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675307549; a=rsa-sha256; cv=none; b=r7NoExymYk7/qWXdGpOCvadwYPnB137BD5Fo51ZQOgOXz87I2RtwjP4TSce3g/7o1J3xSr A9461O/7isaS0foP7VMZ6pJJlqAGV6Gnew0Jl8v1EvssQTrA3wA4XvitSn7UhQPhKo/H27 rmJ9S5hwVfL4R3zDMcoM8x9DG0bj6Os= Received: from kwepemm600003.china.huawei.com (unknown [172.30.72.57]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4P6kL85NvgzRrG2; Thu, 2 Feb 2023 11:10:08 +0800 (CST) Received: from localhost.localdomain (10.175.112.125) by kwepemm600003.china.huawei.com (7.193.23.202) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 2 Feb 2023 11:12:22 +0800 From: Longlong Xia To: CC: , , , , Subject: [PATCH -next 2/3] devtmpfs: add debug info to handle() Date: Thu, 2 Feb 2023 03:10:45 +0000 Message-ID: <20230202031046.1224338-3-xialonglong1@huawei.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230202031046.1224338-1-xialonglong1@huawei.com> References: <20230202031046.1224338-1-xialonglong1@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.175.112.125] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To kwepemm600003.china.huawei.com (7.193.23.202) X-CFilter-Loop: Reflected X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: 36n4c3sfqb8o65mj1kjhc9dyyst1i7fw X-Rspamd-Queue-Id: A380A14000A X-HE-Tag: 1675307548-393124 X-HE-Meta: U2FsdGVkX1+ReJ9y/1baaZ6EcS88H4358UafM2n7UQCKaqcyVi+jpssiAiBmDOy05R9riA7o/1WVHRynOf2ED2ZqTQgOJHcMALJTTp9is23Ipu9lyv8D/NaVGgstBLACjohQQjXAAfAMn+PRbZV9j6+SeXZHVLMw3U+cNqbFKnTGjs5IrFOX2DHnlFXbg1aWypkM02o79ryvwKYKdW/Hx8eQ/Xp8ktW/AkE/xnVvnvWeFkluOyBxDRDW1pPujX+ir+par8PBeRaAJUCf4u1GoB5z8qoVfuaepze1eF2UVFsgIk4gyUpmM1CI+a5/Uf3925bVgI7DGR5QyLM/JF9wdlaPDIquHhMyhWnwiw3ojDbvxpRspPm1F8ZUs2Uxx8R4cvJPQjlQ2uukgwLkEuNn2qboy+jjPBugTjFwL1Zmk81DeO2d2vQlGuUDg1HQTp/G7lpO6IVgSlS9kwBLQX2P9ZsEpx2A2oGEFmfdJwa3Z35wYC3qGxy58IBKWcarblbP272/fY0o4bh6fzUOauEBKSBTI9K58QtOiAcyDebhdQkKTyx4DXaBoDG6x4c8BwjIQ+eVz4dX0/Nt77IK/SzQ/+vYqRUzJncZ5OpsvFsmxWrlOCjft06OUr4SZQO53mr7qCRZRojxF5vIQbEVkFCTHFuejh3LXCjKWJHm1MclMQExqr6sJQgaNMexlXY2zNy7pI6yRp7OW+YeODAWhFzQJR+zUZVGY6dqpbHAeGHfAR7cl6VOdR7lFdDShw6cMAN4/7vSkcgnuoa43+QhDSeG1MingES2u3rnslY8OkEYLNVo9BRJslTvmc06JjEcpfEd4PtWa+g58+Bxcs9wtFkllukx7aUH9E99gEe1wrY4GU57TqxUhqaUlixjBKNI2QPYfJBgEWFFElfPgq638rxYHtqMX6cr/nR95DhWW9p9uAZIVlbLloDQLC9y8PEjxK7jGQVJR8i9HoZBrXqa+R9 ZZsjG2PP uOFMi8YxOXJY1R87y70u2LCdD7NkcdlBgPNQuyXtDT2yLplJUvsy4+RyS6rujrBOcvkd6BgQ6AnNjo/MJXPTVp1vL+93z95G85++y6M7+68v4XSJSy8YoYbcQgAq3bg0sIlC7eXuGZjrI7suh4azSYxke8SBJkoGs8Se7 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The devtmpfs_*_node() are used to mount/unmount devices to /dev, but their callers don't check their return value, so we don't know the reason for the failure. Let's add some debug info in handle() to help users know why failed. Signed-off-by: Longlong Xia --- drivers/base/devtmpfs.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/base/devtmpfs.c b/drivers/base/devtmpfs.c index ae72d4ba8547..77ca64f708ce 100644 --- a/drivers/base/devtmpfs.c +++ b/drivers/base/devtmpfs.c @@ -389,10 +389,18 @@ static __initdata DECLARE_COMPLETION(setup_done); static int handle(const char *name, umode_t mode, kuid_t uid, kgid_t gid, struct device *dev) { + int ret; + if (mode) - return handle_create(name, mode, uid, gid, dev); + ret = handle_create(name, mode, uid, gid, dev); else - return handle_remove(name, dev); + ret = handle_remove(name, dev); + + if (ret) + pr_err_ratelimited("failed to %s %s, ret = %d\n", + mode ? "create" : "remove", name, ret); + + return ret; } static void __noreturn devtmpfs_work_loop(void) From patchwork Thu Feb 2 03:10:46 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Longlong Xia X-Patchwork-Id: 13125227 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3AE63C61DA4 for ; Thu, 2 Feb 2023 03:12:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 43E716B007B; Wed, 1 Feb 2023 22:12:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3ED546B007D; Wed, 1 Feb 2023 22:12:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2B79B6B007E; Wed, 1 Feb 2023 22:12:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 1D1056B007B for ; Wed, 1 Feb 2023 22:12:34 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id EEF0A140DB5 for ; Thu, 2 Feb 2023 03:12:33 +0000 (UTC) X-FDA: 80420878986.30.5BF4B7B Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by imf19.hostedemail.com (Postfix) with ESMTP id 725391A000F for ; Thu, 2 Feb 2023 03:12:30 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf19.hostedemail.com: domain of xialonglong1@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=xialonglong1@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675307551; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=joBD8uzrif102mTzb4KXY9g9UvP/gaLL8z0/pgtt1No=; b=Re9QPEDfgctAvpYEwds6hY7+ucv1cKIEHLVHm9SGSbmQdbJy3Ju26REbp2QXFvYQuWkUmd 9dhQ6uWjiruxnPFsW/zLAuxE5rO8cTFbVT7FCwPNS2xsAWlJPsW/59FHjafBe69umnxNdt f5Y8gk2LwuCwq0v+JfbC5yNX7EBVaZI= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf19.hostedemail.com: domain of xialonglong1@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=xialonglong1@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675307551; a=rsa-sha256; cv=none; b=yAbs/RoflOZK5w7srzjcqpinxTSH+HRxcNWym8Lq5MyAzkUDhAVhOAd71qyrTnoUHUrzoj hd3/A97whKjXR6kJLcyOlq+kGCOisWUS0hMRdkWTctk30YTN7bwXvOFWfhVtqmpqtUVaDh Mng4nCHkBRDUNvtDUlHlT1oH78V3nhs= Received: from kwepemm600003.china.huawei.com (unknown [172.30.72.57]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4P6kHY1gtFzJqrH; Thu, 2 Feb 2023 11:07:53 +0800 (CST) Received: from localhost.localdomain (10.175.112.125) by kwepemm600003.china.huawei.com (7.193.23.202) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 2 Feb 2023 11:12:22 +0800 From: Longlong Xia To: CC: , , , , Subject: [PATCH -next 3/3] devtmpfs: remove return value of devtmpfs_*_node() & devtmpfs_submit_req() Date: Thu, 2 Feb 2023 03:10:46 +0000 Message-ID: <20230202031046.1224338-4-xialonglong1@huawei.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230202031046.1224338-1-xialonglong1@huawei.com> References: <20230202031046.1224338-1-xialonglong1@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.175.112.125] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To kwepemm600003.china.huawei.com (7.193.23.202) X-CFilter-Loop: Reflected X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 725391A000F X-Stat-Signature: nx88n6ftf8kz4nnnee3tjknnueqqu4a5 X-HE-Tag: 1675307550-982546 X-HE-Meta: U2FsdGVkX1/f/sh+ZJNwonfPdJ6ZpfV3WupndOl4tWn0IocU+HCeKzuVdVky48WIjGMGd0IkHVmPzR2cciruI9wSjwTFlCBRLfuTiobXz62PpIQa/4ld8GglS8b1Pak5CrqFoXJZHiWNAFS/Q/peCelL0yhyBJRvWV3vPcxSvGHxcS9912g4GrNNBa3AxYGVs9ZxCXIhixKXYoQqpZsv4NRcSRlebFnbY9Ix/FsYqaNY8bb0fqDI65kSA5VdZFMEKDalIjDuk5vinK4956ayukBB92HrCj0aYVaHiSzDpc1vrL3r0XXAYhzTgmNXqJW7JNddVCYQai15saCiX3+zgzlmDOfBKm8CXQ83tyem8y+V+rwiDcS21+ZaVuBnMv2LSxAFpCPB5dYH1fywt+Lm4CJ6dEp2Hbw02SfpUzFCfNnLZM2fDpLBlhmvcg4qyRLonJBDd0pOI33sraKA+kUcB8kkz3rNljTgDPE/V6dnXGWJGEyklLrPckXJY0LeHKdIcXmJlgLfzmvwx699jqbrzY0vQZa2zEwNi+fGnP/T/veDNs5srRaByJVE7Z3vIl/N/V5rwOzjboRzi+OKC3/e3xmGTLaw9HrreorkplUlT3rEzjry/wkdv2mNB9vz3j1dVNI0XfRoeP8MhZzgc0R4xkAVv2RFCQTf07V0WQ1yGQzOBgL9p2usUORUngzm6iFbNx3Nu0oPp/k6LvBlS963bH80L6qaoaVjpLRJsXF8tROaCkH6S5dfZ/U7MRVjVqDiwu+if7SNrPk0AEGIWOuuN+9bm9imyByG5aqllTDsbJszAOVBDIGzFcLTuG8k0MfHdO1MX2REfl1YM6iXAYU5vIlAmB9/jOiCAFFwGiQPjSUws5U0ZYCC8kwDEKNKKVbis4R6ffIYhld/k+hPtI50YOkPd/ZQcvViQcB6NO9+eCf9k8tnDzveimrUNmpam5eLOI21N0wzb48jecCioFy jXUfxXMS LLretVZNnUuU483j75YO0RziuhQgtx899S7Kl4KcWlf7CafdfbdZJKuH+eAry6i8PkrHmeS25i0D+DjaoWC4ULZW8QY1qstJeJVc25wjPXXIqfXU0PM55MIGP5+gafnDkzstSl0M0VizZraGbBJAyXfLin29vVq3NH2xbmpGO78YxOONNJRiX8h2N7StkfNUmyyImltd/XfMoVnnyafahot28rw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Because the return value of devtmpfs_*_node() and devtmpfs_submit_req() are not used by their callers, change them into void functions. Signed-off-by: Longlong Xia --- drivers/base/base.h | 8 ++++---- drivers/base/devtmpfs.c | 20 +++++++++----------- 2 files changed, 13 insertions(+), 15 deletions(-) diff --git a/drivers/base/base.h b/drivers/base/base.h index 2208af509ce8..ffb7321e39cf 100644 --- a/drivers/base/base.h +++ b/drivers/base/base.h @@ -198,11 +198,11 @@ extern void fw_devlink_drivers_done(void); void device_pm_move_to_tail(struct device *dev); #ifdef CONFIG_DEVTMPFS -int devtmpfs_create_node(struct device *dev); -int devtmpfs_delete_node(struct device *dev); +void devtmpfs_create_node(struct device *dev); +void devtmpfs_delete_node(struct device *dev); #else -static inline int devtmpfs_create_node(struct device *dev) { return 0; } -static inline int devtmpfs_delete_node(struct device *dev) { return 0; } +static inline void devtmpfs_create_node(struct device *dev) { } +static inline void devtmpfs_delete_node(struct device *dev) { } #endif void software_node_notify(struct device *dev); diff --git a/drivers/base/devtmpfs.c b/drivers/base/devtmpfs.c index 77ca64f708ce..3c4e61c99b77 100644 --- a/drivers/base/devtmpfs.c +++ b/drivers/base/devtmpfs.c @@ -103,7 +103,7 @@ static inline int is_blockdev(struct device *dev) static inline int is_blockdev(struct device *dev) { return 0; } #endif -static int devtmpfs_submit_req(struct req *req, const char *tmp) +static void devtmpfs_submit_req(struct req *req, const char *tmp) { init_completion(&req->done); @@ -116,24 +116,22 @@ static int devtmpfs_submit_req(struct req *req, const char *tmp) wait_for_completion(&req->done); kfree(tmp); - - return req->err; } -int devtmpfs_create_node(struct device *dev) +void devtmpfs_create_node(struct device *dev) { const char *tmp = NULL; struct req req; if (!thread) - return 0; + return; req.mode = 0; req.uid = GLOBAL_ROOT_UID; req.gid = GLOBAL_ROOT_GID; req.name = device_get_devnode(dev, &req.mode, &req.uid, &req.gid, &tmp); if (!req.name) - return -ENOMEM; + return; if (req.mode == 0) req.mode = 0600; @@ -144,25 +142,25 @@ int devtmpfs_create_node(struct device *dev) req.dev = dev; - return devtmpfs_submit_req(&req, tmp); + devtmpfs_submit_req(&req, tmp); } -int devtmpfs_delete_node(struct device *dev) +void devtmpfs_delete_node(struct device *dev) { const char *tmp = NULL; struct req req; if (!thread) - return 0; + return; req.name = device_get_devnode(dev, NULL, NULL, NULL, &tmp); if (!req.name) - return -ENOMEM; + return; req.mode = 0; req.dev = dev; - return devtmpfs_submit_req(&req, tmp); + devtmpfs_submit_req(&req, tmp); } static int dev_mkdir(const char *name, umode_t mode)