From patchwork Sat Jan 26 15:55:43 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luc Van Oostenryck X-Patchwork-Id: 10782497 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A23911390 for ; Sat, 26 Jan 2019 15:55:54 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8814C2C8A4 for ; Sat, 26 Jan 2019 15:55:54 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7BEB32C8B2; Sat, 26 Jan 2019 15:55:54 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2C3282C8A4 for ; Sat, 26 Jan 2019 15:55:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726075AbfAZPzx (ORCPT ); Sat, 26 Jan 2019 10:55:53 -0500 Received: from mail-ed1-f67.google.com ([209.85.208.67]:33500 "EHLO mail-ed1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726070AbfAZPzx (ORCPT ); Sat, 26 Jan 2019 10:55:53 -0500 Received: by mail-ed1-f67.google.com with SMTP id p6so9749933eds.0 for ; Sat, 26 Jan 2019 07:55:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=lFGpiuFlk8M49vfS5y03scId4kD6o+bCMxL80qu9PC8=; b=bmfWQpNkQ2Tw2fEAydNRDeJakN/rJ+/96JxcWOhDkzJeTqsUVeqccL5iZUQy8yvtCb O63GwIbNZ28jKtj4AOXirx4cBsTMnmNOYJ6GlwYFT44kI/QBMUeiKiQRwJ2ebHUuxBUE 9IS4SJq/mPsS1q3TwiGMSgU/2uZX4ls61xZRwsCBYVscGrS52eCG18ZKUGsrDeIt/NJI JYrgKKz48ZXVpHfpbTz5LEIO1cvoaBtHo8XrRIbnT8hD5wgyyTw0AZeodGuf922klWl4 BnGO4byFiVWtfeJ5MmCAS2q9rMk9Ot/dKMBxevHO3LLxzO2DBD2ufJ15GGQYjNuPcf06 BJzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=lFGpiuFlk8M49vfS5y03scId4kD6o+bCMxL80qu9PC8=; b=nj6fhlU8zqdZxFMx3h6EkXNBaBZOxYxLsMtGMpfFRjS5eQBmpO1sxjGJJJ1es7D4Ao LrtpqeUHyC6xSJ7kXNrejDMYsD2Nj/zwqX/IIsCv1si1tdfOidJsK+nvZX1Qlv4XmXv1 64IVOactdOQrlNGnV+oWnbA4XgTvy5HOJ+a7ZWCpm7c7FPxIxDUcc4VLUJwXSO1x9Nru qdbKKPhWZcwqYJk1aBX+33ofpvetsrSdugATm8vohuYGPQFoEwIx3gLUoB3c6wtyOiO3 2G66ZHE34+6BxSGFfTUX48J4UTaj7Dw9cJtstqO3xYtQufc3lFraCw/lmTEMnWZWAh25 NIgQ== X-Gm-Message-State: AJcUukekL/L3JmRwHkEZUbGDMS1h0wEt17/NgF2AHoEq1os8fxMRLhFm ieKQxTxwLu7SlkVFtHi2MGfApSvZ X-Google-Smtp-Source: ALg8bN6SeKijknxFTHL08J94h1j8qjlmMZ3ftKgOzNnXfZ4TA+giPy1CDlAFEYnlRWfgCDmWGbEnDw== X-Received: by 2002:aa7:dace:: with SMTP id x14mr15391592eds.13.1548518151281; Sat, 26 Jan 2019 07:55:51 -0800 (PST) Received: from localhost.localdomain ([2a02:a03f:40eb:400:288e:c567:deda:96dc]) by smtp.gmail.com with ESMTPSA id e53sm12655428ede.90.2019.01.26.07.55.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 26 Jan 2019 07:55:50 -0800 (PST) From: Luc Van Oostenryck To: linux-sparse@vger.kernel.org Cc: Luc Van Oostenryck , Oleg Nesterov Subject: [PATCH] dissect: fix processing of ASM statements Date: Sat, 26 Jan 2019 16:55:43 +0100 Message-Id: <20190126155543.53573-1-luc.vanoostenryck@gmail.com> X-Mailer: git-send-email 2.20.0 MIME-Version: 1.0 Sender: linux-sparse-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-sparse@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Before commit 756731e9 ("use a specific struct for asm operands"), ASM operands ('name', 'constraint, 'expression') were stored as a sequence of 3 expressions. After, they had their own expression type: EXPR_ASM_OPERAND. However, dissect.c:do_asm_xputs() was not adapated for this change. Fix this in do_asm_xputs() by processing the 'expression' of every entries (instead of only processing every third entries). CC: Oleg Nesterov Signed-off-by: Luc Van Oostenryck --- dissect.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/dissect.c b/dissect.c index 5f067eb4c..b50c268b9 100644 --- a/dissect.c +++ b/dissect.c @@ -452,11 +452,7 @@ again: static void do_asm_xputs(usage_t mode, struct expression_list *xputs) { - int nr = 0; - - DO_LIST(xputs, expr, - if (++nr % 3 == 0) - do_expression(U_W_AOF | mode, expr)); + DO_LIST(xputs, op, do_expression(U_W_AOF | mode, op->expr)); } static struct symbol *do_statement(usage_t mode, struct statement *stmt)