From patchwork Mon Feb 6 14:08:00 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabiano Rosas X-Patchwork-Id: 13130005 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3C999C636D6 for ; Mon, 6 Feb 2023 14:11:43 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pP2Cb-00061c-MR; Mon, 06 Feb 2023 09:10:37 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pP2CZ-00060m-3m for qemu-devel@nongnu.org; Mon, 06 Feb 2023 09:10:35 -0500 Received: from smtp-out1.suse.de ([195.135.220.28]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pP2CW-0002Zp-3B for qemu-devel@nongnu.org; Mon, 06 Feb 2023 09:10:34 -0500 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id D561533D27; Mon, 6 Feb 2023 14:10:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1675692629; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yRt17INxw+r/097qGsN3dpcq/vEASg9fuWlP5GWMX1g=; b=lpA+IOzCKrFDbrWW+Ug4f/kcLUFqVom/CDn1ZCP4/5+P/icPr9lztmr5EUEwmkzi0dPJpC GD4Gz1BWDMYh54I5R0jGVFiV9TKy7LdExhJvJt8TyyCtb7XcRkm/cOvkN73HVivAdZlmSY JlSDvcL0hfdNEoSi5L//+zXATPWJijM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1675692629; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yRt17INxw+r/097qGsN3dpcq/vEASg9fuWlP5GWMX1g=; b=5AYePBDWHAo+9NxQ4Et5jOzwJ0m9uIubT6K8A4E4sw1jWzWjSBqbNj4bsNJfxr9GLyTKnv YxTGeGCKcRyjZJDQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B157D138E7; Mon, 6 Feb 2023 14:10:28 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id KNgTHlQK4WOgQAAAMHmgww (envelope-from ); Mon, 06 Feb 2023 14:10:28 +0000 From: Fabiano Rosas To: qemu-devel@nongnu.org Cc: Thomas Huth , Paolo Bonzini Subject: [PATCH 01/10] vl.c: Do not add isa-parallel if it's not present Date: Mon, 6 Feb 2023 11:08:00 -0300 Message-Id: <20230206140809.26028-2-farosas@suse.de> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230206140809.26028-1-farosas@suse.de> References: <20230206140809.26028-1-farosas@suse.de> MIME-Version: 1.0 Received-SPF: pass client-ip=195.135.220.28; envelope-from=farosas@suse.de; helo=smtp-out1.suse.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Currently the isa-parallel driver is always added by default regardless of the presence of the actual code in the build, which can lead to a crash: qemu-system-i386: unknown type 'isa-parallel' Aborted (core dumped) Check for the presence of the QOM class and do not include isa-parallel by default if it's not found. Signed-off-by: Fabiano Rosas --- softmmu/vl.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/softmmu/vl.c b/softmmu/vl.c index 9177d95d4e..614e6cf66e 100644 --- a/softmmu/vl.c +++ b/softmmu/vl.c @@ -1269,7 +1269,8 @@ static void qemu_disable_default_devices(void) if (!has_defaults || machine_class->no_serial) { default_serial = 0; } - if (!has_defaults || machine_class->no_parallel) { + if (!has_defaults || machine_class->no_parallel || + !object_class_by_name("isa-parallel")) { default_parallel = 0; } if (!has_defaults || machine_class->no_floppy) { From patchwork Mon Feb 6 14:08:01 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabiano Rosas X-Patchwork-Id: 13130014 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8708CC636D6 for ; Mon, 6 Feb 2023 14:14:43 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pP2Cd-00064h-7M; Mon, 06 Feb 2023 09:10:39 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pP2CZ-000614-HI for qemu-devel@nongnu.org; Mon, 06 Feb 2023 09:10:35 -0500 Received: from smtp-out1.suse.de ([195.135.220.28]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pP2CX-0002bD-Dr for qemu-devel@nongnu.org; Mon, 06 Feb 2023 09:10:35 -0500 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 5861F33D29; Mon, 6 Feb 2023 14:10:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1675692632; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Mykl+BdE21hEMrBw4HHu6ROq7yGSZl8D6OrvyFyeVd4=; b=KWbZVjg8+s6+GNhzUMk7d+13HiiGfGaLYpEVJbIo4Yra9GhnRVHFvlfnopUEx5B/xgovMh MWbENbMzCQ3aEhRojWb6I2EZBpUfEYUt8RnNNbQb9AItmf7FzdKJFtgRw5G5oHju3AcP6y zPu4e7AUgzO3Iy2QA1N3dX/85xhQWtA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1675692632; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Mykl+BdE21hEMrBw4HHu6ROq7yGSZl8D6OrvyFyeVd4=; b=4VIz7Ik3xnYc98ulFgLxszQbLg1C2WzS1MbrCdQBo50i/8IgCtIpfex28khgVnt41bzr/D h/xR+zFFyuqQ21Cw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 50995138E7; Mon, 6 Feb 2023 14:10:30 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id UCF0BlYK4WOgQAAAMHmgww (envelope-from ); Mon, 06 Feb 2023 14:10:30 +0000 From: Fabiano Rosas To: qemu-devel@nongnu.org Cc: Thomas Huth , Paolo Bonzini , Richard Henderson , Eduardo Habkost , "Michael S. Tsirkin" , Marcel Apfelbaum Subject: [PATCH 02/10] hw/i386: Select E1000E for q35 Date: Mon, 6 Feb 2023 11:08:01 -0300 Message-Id: <20230206140809.26028-3-farosas@suse.de> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230206140809.26028-1-farosas@suse.de> References: <20230206140809.26028-1-farosas@suse.de> MIME-Version: 1.0 Received-SPF: pass client-ip=195.135.220.28; envelope-from=farosas@suse.de; helo=smtp-out1.suse.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org The e1000e network adapter is the default network card for the q35 machine. Make sure that CONFIG is always selected for that machine. Signed-off-by: Fabiano Rosas Reviewed-by: Thomas Huth --- hw/i386/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/i386/Kconfig b/hw/i386/Kconfig index 1bf47b0b0b..527b95df81 100644 --- a/hw/i386/Kconfig +++ b/hw/i386/Kconfig @@ -93,7 +93,6 @@ config Q35 bool imply VTD imply AMD_IOMMU - imply E1000E_PCI_EXPRESS imply VMPORT imply VMMOUSE select PC_PCI @@ -104,6 +103,7 @@ config Q35 select DIMM select SMBIOS select FW_CFG_DMA + select E1000E_PCI_EXPRESS config MICROVM bool From patchwork Mon Feb 6 14:08:02 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabiano Rosas X-Patchwork-Id: 13130013 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 80E39C61DA4 for ; Mon, 6 Feb 2023 14:14:42 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pP2Cd-00064m-VC; Mon, 06 Feb 2023 09:10:39 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pP2Cb-00063m-V9 for qemu-devel@nongnu.org; Mon, 06 Feb 2023 09:10:38 -0500 Received: from smtp-out2.suse.de ([195.135.220.29]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pP2Ca-0002f1-GG for qemu-devel@nongnu.org; Mon, 06 Feb 2023 09:10:37 -0500 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id CFE0E20E1B; Mon, 6 Feb 2023 14:10:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1675692634; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PxPdLXH9DmKt7VkrYzZg7R/L6jDlTL/4xksbd9VouN0=; b=Mpk0FuTZJ9jEnMggUYmhDpj/LqgZEe01oSRze1xGqLzcOeR4PSRvM4NraQvfAUR8p5oA2+ 3Uxn+Vzfg/T4lhueLSPuAOJy8L7EqVkvQ6UcG2roH6k7DzycCzl491uOvinTf+WN6udF55 nfq8gp51QajQ8XFMXp/G4Mi7x0QRzOM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1675692634; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PxPdLXH9DmKt7VkrYzZg7R/L6jDlTL/4xksbd9VouN0=; b=jvK2cECAS6HqRUij46JH6wlXbzWGKI98yh5aaa4Z+IZoriWJ4PU2L4vT0NOBsT/pBfW/4B Rk3L43TQgJdOy/Dg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id C7506138E7; Mon, 6 Feb 2023 14:10:32 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id eEhsI1gK4WOgQAAAMHmgww (envelope-from ); Mon, 06 Feb 2023 14:10:32 +0000 From: Fabiano Rosas To: qemu-devel@nongnu.org Cc: Thomas Huth , "Michael S. Tsirkin" , Marcel Apfelbaum , Paolo Bonzini , Richard Henderson , Eduardo Habkost Subject: [PATCH 03/10] hw/i386: Select VGA_PCI in Kconfig Date: Mon, 6 Feb 2023 11:08:02 -0300 Message-Id: <20230206140809.26028-4-farosas@suse.de> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230206140809.26028-1-farosas@suse.de> References: <20230206140809.26028-1-farosas@suse.de> MIME-Version: 1.0 Received-SPF: pass client-ip=195.135.220.29; envelope-from=farosas@suse.de; helo=smtp-out2.suse.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Machines that have "std" as default VGA display need to always build vga-pci.c, otherwise we get a crash when CONFIG_PCI_DEVICES=n: $ ./qemu-system-x86_64 -M q35 -vga std qemu-system-x86_64: unknown type 'VGA' Aborted (core dumped) Signed-off-by: Fabiano Rosas --- hw/i386/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/i386/Kconfig b/hw/i386/Kconfig index 527b95df81..8e59cb6634 100644 --- a/hw/i386/Kconfig +++ b/hw/i386/Kconfig @@ -30,9 +30,9 @@ config PC imply TEST_DEVICES imply TPM_CRB imply TPM_TIS_ISA - imply VGA_PCI imply VIRTIO_VGA imply NVDIMM + select VGA_PCI select FDC_ISA select I8259 select I8254 From patchwork Mon Feb 6 14:08:03 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabiano Rosas X-Patchwork-Id: 13130007 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 321D7C636D6 for ; Mon, 6 Feb 2023 14:12:00 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pP2Cf-000658-US; Mon, 06 Feb 2023 09:10:41 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pP2Ce-00064v-0j for qemu-devel@nongnu.org; Mon, 06 Feb 2023 09:10:40 -0500 Received: from smtp-out2.suse.de ([2001:67c:2178:6::1d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pP2Cc-0002fN-JE for qemu-devel@nongnu.org; Mon, 06 Feb 2023 09:10:39 -0500 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 5522A603A0; Mon, 6 Feb 2023 14:10:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1675692637; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=csDUJZUgv5WSSEjj/YsjXMEE0X0IjozXL8PPvowcxCM=; b=Wk/j7BcJxNM7C2U/0SD+fnzXxu40hsIe40ltvenAu9IkeP8hJAPsDBrDlWb4ThLOgIShvt L5XcjfaxfHdyx0FIOeKBFsnlpa8XF3VnQd/tCpVjLh7PshZgw3h1NDok2veaMqeb3+9l2U Bq496GQkJmAUenX+7TNTbwoQQdAgnT0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1675692637; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=csDUJZUgv5WSSEjj/YsjXMEE0X0IjozXL8PPvowcxCM=; b=6C2F0aLxw6PABMTQSpMvnnT+zk0DTWTYYBVN6FQYQgs2o/HiN0qCzKqbKDkIWOt6uNuaGi VywWYBtlnaWYglAg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 4D322138E7; Mon, 6 Feb 2023 14:10:35 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id yEiFBVsK4WOgQAAAMHmgww (envelope-from ); Mon, 06 Feb 2023 14:10:35 +0000 From: Fabiano Rosas To: qemu-devel@nongnu.org Cc: Thomas Huth , Paolo Bonzini , Richard Henderson , Eduardo Habkost , "Michael S. Tsirkin" , Marcel Apfelbaum Subject: [PATCH 04/10] hw/i386: Select E1000_PCI for i440fx Date: Mon, 6 Feb 2023 11:08:03 -0300 Message-Id: <20230206140809.26028-5-farosas@suse.de> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230206140809.26028-1-farosas@suse.de> References: <20230206140809.26028-1-farosas@suse.de> MIME-Version: 1.0 Received-SPF: pass client-ip=2001:67c:2178:6::1d; envelope-from=farosas@suse.de; helo=smtp-out2.suse.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org The i440fx machines uses the e1000 adapter as the default when no other network card is configured. Move the E1000_PCI entry in Kconfig from 'imply' to 'select' to avoid the following situation: ./qemu-system-i386 -machine pc-i440fx-8.0 qemu-system-i386: Unsupported NIC model: e1000 Signed-off-by: Fabiano Rosas Reviewed-by: Thomas Huth --- hw/i386/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/i386/Kconfig b/hw/i386/Kconfig index 8e59cb6634..343783ea3e 100644 --- a/hw/i386/Kconfig +++ b/hw/i386/Kconfig @@ -66,7 +66,6 @@ config PC_ACPI config I440FX bool - imply E1000_PCI imply VMPORT imply VMMOUSE select ACPI_PIIX4 @@ -78,6 +77,7 @@ config I440FX select DIMM select SMBIOS select FW_CFG_DMA + select E1000_PCI config ISAPC bool From patchwork Mon Feb 6 14:08:04 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabiano Rosas X-Patchwork-Id: 13130008 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ECA7BC61DA4 for ; Mon, 6 Feb 2023 14:12:05 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pP2Cj-000663-17; Mon, 06 Feb 2023 09:10:45 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pP2Cg-00065A-0v; Mon, 06 Feb 2023 09:10:42 -0500 Received: from smtp-out1.suse.de ([2001:67c:2178:6::1c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pP2Ce-0002fa-HS; Mon, 06 Feb 2023 09:10:41 -0500 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 2CFE433CF9; Mon, 6 Feb 2023 14:10:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1675692639; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FEGE8pycELFg8/TWdTKjH83z3RR5mzFkoQaZma3+j+8=; b=phpX8Ui0tb9oUlgo2rJlliCGS+K1vTcDzOmkjw06bqCWhhMZxKMKizsd8Ay9mA3q0a+fT7 VCdM56C/rv5x+Bd/6zM1mYXv8VKbi+9HM2vfRCBCZPvNha7Lfd3SXbd7tqD/mQnPUozUsM s1hxZgYLh9Bd/oZ2cH3NgAXlmmjkE68= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1675692639; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FEGE8pycELFg8/TWdTKjH83z3RR5mzFkoQaZma3+j+8=; b=MMXrNsp3nWjQLcMhNMA5eR6o7a0v56jxJ2tP2CPn+GuVero7ntpLVWl36gixQHWyIMGWfA WS7twA7/Fd4HncAg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id C5AB6138E7; Mon, 6 Feb 2023 14:10:37 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id UHeOIl0K4WOgQAAAMHmgww (envelope-from ); Mon, 06 Feb 2023 14:10:37 +0000 From: Fabiano Rosas To: qemu-devel@nongnu.org Cc: Thomas Huth , Peter Maydell , qemu-arm@nongnu.org Subject: [PATCH 05/10] hw/arm: Select VIRTIO_NET for virt machine Date: Mon, 6 Feb 2023 11:08:04 -0300 Message-Id: <20230206140809.26028-6-farosas@suse.de> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230206140809.26028-1-farosas@suse.de> References: <20230206140809.26028-1-farosas@suse.de> MIME-Version: 1.0 Received-SPF: pass client-ip=2001:67c:2178:6::1c; envelope-from=farosas@suse.de; helo=smtp-out1.suse.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org The 'virt' machine uses virtio-net-pci as a fallback when no other network driver has been selected via command line. Select VIRTIO_NET and VIRTIO_PCI from CONFIG_ARM_VIRT to avoid errors when PCI_DEVICES=n (due to e.g. --without-default-devices): $ ./qemu-system-aarch64 -M virt -accel tcg -cpu max qemu-system-aarch64: Unsupported NIC model: virtio-net-pci Signed-off-by: Fabiano Rosas Reviewed-by: Thomas Huth --- hw/arm/Kconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig index 2d157de9b8..8dcc08b7ec 100644 --- a/hw/arm/Kconfig +++ b/hw/arm/Kconfig @@ -31,6 +31,8 @@ config ARM_VIRT select VIRTIO_MEM_SUPPORTED select ACPI_CXL select ACPI_HMAT + select VIRTIO_PCI + select VIRTIO_NET config CHEETAH bool From patchwork Mon Feb 6 14:08:05 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabiano Rosas X-Patchwork-Id: 13130009 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C8DF9C05027 for ; Mon, 6 Feb 2023 14:12:37 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pP2Co-00067T-MZ; Mon, 06 Feb 2023 09:10:50 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pP2Ch-000662-Uj; Mon, 06 Feb 2023 09:10:44 -0500 Received: from smtp-out2.suse.de ([195.135.220.29]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pP2Cg-0002g0-Bi; Mon, 06 Feb 2023 09:10:43 -0500 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 0311E60420; Mon, 6 Feb 2023 14:10:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1675692641; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2nF6Q1feagG1j59SSALXFHCj/mrnFM3pmdWjXUdvEyk=; b=2OyAQdYAuGIZZE+HtUF3pb3GSFde3he6QRrJZBlgGiuq9dFyjPEjOUpQDaFdNy26aMVoIl 4+W89l9r/RIkSFJwNOVwm5POLGFWSPQoAA4+BZ/EJHLk9vP4zeOkR0KZFz+spUQOX2Lb5s vG0EiiMrNS+ECpBlHNhvO43PdpT7DMI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1675692641; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2nF6Q1feagG1j59SSALXFHCj/mrnFM3pmdWjXUdvEyk=; b=OIZjmeufdyR2kyZ7nHEmRVxefLjDZSE31xo571EU0XTrj1PVHAFLH3exKanxMAYsputE73 y26HJq+sdrhRF6BA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 9B35E138E7; Mon, 6 Feb 2023 14:10:39 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id KEWOGF8K4WOgQAAAMHmgww (envelope-from ); Mon, 06 Feb 2023 14:10:39 +0000 From: Fabiano Rosas To: qemu-devel@nongnu.org Cc: Thomas Huth , Peter Maydell , qemu-arm@nongnu.org Subject: [PATCH 06/10] hw/arm: Select VIRTIO_BLK for virt machine Date: Mon, 6 Feb 2023 11:08:05 -0300 Message-Id: <20230206140809.26028-7-farosas@suse.de> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230206140809.26028-1-farosas@suse.de> References: <20230206140809.26028-1-farosas@suse.de> MIME-Version: 1.0 Received-SPF: pass client-ip=195.135.220.29; envelope-from=farosas@suse.de; helo=smtp-out2.suse.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org The virt machine has IF_VIRTIO as block_default_type, which causes the generic code to try to create a virtio-blk-pci device pair at configure_blockdev()/qemu_create_cli_devices(). Select VIRTIO_BLK and VIRTIO_PCI from CONFIG_ARM_VIRT to avoid errors when PCI_DEVICES=n (due to e.g. --without-default-devices): $ ./qemu-system-aarch64 -M virt -accel tcg -cpu max -nodefaults -cdrom foo.qcow2 qemu-system-aarch64: -cdrom foo.qcow2: 'virtio-blk' (alias 'virtio-blk-pci') is not a valid device model name Signed-off-by: Fabiano Rosas --- hw/arm/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig index 8dcc08b7ec..296d4f5176 100644 --- a/hw/arm/Kconfig +++ b/hw/arm/Kconfig @@ -33,6 +33,7 @@ config ARM_VIRT select ACPI_HMAT select VIRTIO_PCI select VIRTIO_NET + select VIRTIO_BLK config CHEETAH bool From patchwork Mon Feb 6 14:08:06 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabiano Rosas X-Patchwork-Id: 13130010 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EB300C636D6 for ; Mon, 6 Feb 2023 14:12:45 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pP2Cw-000695-9h; Mon, 06 Feb 2023 09:10:58 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pP2Cj-00066c-Uv; Mon, 06 Feb 2023 09:10:46 -0500 Received: from smtp-out1.suse.de ([2001:67c:2178:6::1c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pP2Ci-0002gG-FA; Mon, 06 Feb 2023 09:10:45 -0500 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id CD85233CF9; Mon, 6 Feb 2023 14:10:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1675692642; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Lp4o1O8f765MbOnRuP5UY6glSkqkwGjbVkLqSoECOQI=; b=ppeVkGJLN7wTtutOd6i4/98cAPqW4C6ImEaBa2ZbVdeZ2UPmgIUoWOaHmfjLL2xG3pOziN GKySULC2Yb8O5hs4fFtfoIUfHny0TKQqf3QvRkoa82+0WGF5f/Fv231+Mg8/RbTO8DTN6t HIgbK3FxOQis/cMdvJOvuX9tz6hyZx0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1675692642; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Lp4o1O8f765MbOnRuP5UY6glSkqkwGjbVkLqSoECOQI=; b=teOz5c/9zyHdz0sN8mxrayyQ5mhXqNrd5YPx5iJtNR5z8RbErNhqDFEFaaX+QJ0StZVz39 iAFaUKxzuoQvqoDA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 72C04138E7; Mon, 6 Feb 2023 14:10:41 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id IDu+DmEK4WOgQAAAMHmgww (envelope-from ); Mon, 06 Feb 2023 14:10:41 +0000 From: Fabiano Rosas To: qemu-devel@nongnu.org Cc: Thomas Huth , Peter Maydell , qemu-arm@nongnu.org Subject: [PATCH 07/10] hw/arm: Select XLNX_USB_SUBSYS for xlnx-zcu102 machine Date: Mon, 6 Feb 2023 11:08:06 -0300 Message-Id: <20230206140809.26028-8-farosas@suse.de> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230206140809.26028-1-farosas@suse.de> References: <20230206140809.26028-1-farosas@suse.de> MIME-Version: 1.0 Received-SPF: pass client-ip=2001:67c:2178:6::1c; envelope-from=farosas@suse.de; helo=smtp-out1.suse.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org This machine hardcodes initialization of the USB device, so select the corresponding Kconfig. It is not enough to have it as "default y if XLNX_VERSAL" at usb/Kconfig because building --without-default-devices disables the default selection resulting in: $ ./qemu-system-aarch64 -M xlnx-zcu102 qemu-system-aarch64: missing object type 'usb_dwc3' Aborted (core dumped) Signed-off-by: Fabiano Rosas --- hw/arm/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig index 296d4f5176..552e3d04ee 100644 --- a/hw/arm/Kconfig +++ b/hw/arm/Kconfig @@ -405,6 +405,7 @@ config XLNX_VERSAL select OR_IRQ select XLNX_BBRAM select XLNX_EFUSE_VERSAL + select XLNX_USB_SUBSYS config NPCM7XX bool From patchwork Mon Feb 6 14:08:07 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabiano Rosas X-Patchwork-Id: 13130015 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2FD27C61DA4 for ; Mon, 6 Feb 2023 14:14:53 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pP2Cy-0006A6-Cd; Mon, 06 Feb 2023 09:11:00 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pP2Cl-000672-EW; Mon, 06 Feb 2023 09:10:48 -0500 Received: from smtp-out1.suse.de ([195.135.220.28]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pP2Ck-0002gd-2W; Mon, 06 Feb 2023 09:10:47 -0500 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id A929133D27; Mon, 6 Feb 2023 14:10:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1675692644; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HZXJRI3amPAYNCwVYdZzgSDNv7iQO8gV9ZNjrmjggUI=; b=B+Ckmfx/59LljsiW3ZPHHzPqGZxVnxsCTztOmITUhTCwHwSPhJci+bhKv/Hug9A5vtGXth XAjFvlP6SZIn9RqBQ6Jr7YOaoX/MZiTu+61PzeecSzp8dC34Vea7zggKX/Quc7k4Dk3LlG tmJD0uXRK+/7KYJc6mGdfUUebNXqcDU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1675692644; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HZXJRI3amPAYNCwVYdZzgSDNv7iQO8gV9ZNjrmjggUI=; b=iaWTxJTTnGdF8LDLnhuYLxvmBU//hRQtzNtCOjh5r3IEXxXBKQ/SSKi2LoZaQggtThimcN 9ptycREOXHItLiBA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 47302138E7; Mon, 6 Feb 2023 14:10:43 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id oA0SBGMK4WOgQAAAMHmgww (envelope-from ); Mon, 06 Feb 2023 14:10:43 +0000 From: Fabiano Rosas To: qemu-devel@nongnu.org Cc: Thomas Huth , Peter Maydell , qemu-arm@nongnu.org Subject: [PATCH 08/10] hw/arm: Select GICV3_TCG for sbsa-ref machine Date: Mon, 6 Feb 2023 11:08:07 -0300 Message-Id: <20230206140809.26028-9-farosas@suse.de> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230206140809.26028-1-farosas@suse.de> References: <20230206140809.26028-1-farosas@suse.de> MIME-Version: 1.0 Received-SPF: pass client-ip=195.135.220.28; envelope-from=farosas@suse.de; helo=smtp-out1.suse.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org This machine hardcodes the creation of the interrupt controller, so make sure the dependency is explicitly described in the Kconfig. Signed-off-by: Fabiano Rosas Reviewed-by: Peter Maydell --- hw/arm/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig index 552e3d04ee..823f8b11f1 100644 --- a/hw/arm/Kconfig +++ b/hw/arm/Kconfig @@ -232,6 +232,7 @@ config SBSA_REF select PL061 # GPIO select USB_EHCI_SYSBUS select WDT_SBSA + select ARM_GICV3_TCG config SABRELITE bool From patchwork Mon Feb 6 14:08:08 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabiano Rosas X-Patchwork-Id: 13130006 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 234BDC05027 for ; Mon, 6 Feb 2023 14:12:00 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pP2D1-0006Br-VQ; Mon, 06 Feb 2023 09:11:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pP2Co-00067z-Rn; Mon, 06 Feb 2023 09:10:52 -0500 Received: from smtp-out2.suse.de ([195.135.220.29]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pP2Cm-0002h2-Kj; Mon, 06 Feb 2023 09:10:49 -0500 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 8DE9F6042A; Mon, 6 Feb 2023 14:10:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1675692646; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6Sr6k0UBoZ4rpW7+N3yTty4+4axcyqsEsxFDoi5sJPA=; b=ybztKT7l+Ad1tS0evGb3xpqrJtygw25BQ5uIRjUOVXIYq9WtOQ1h2QFB22o5sZLQbksi+U LeF79aDl3dYj7ExKv8GQygQ+50RNKU6ypAVQvE8Q19jEMknXHiz5PQXiKmuNwfAwoIBHLC dcqQRzykVElC8EqVWK20mkj6vjCAuxY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1675692646; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6Sr6k0UBoZ4rpW7+N3yTty4+4axcyqsEsxFDoi5sJPA=; b=yaO9VE5O+slz20P51rLo020ziIBxUr47DNgE9g8wIhGvkpa+1Fq7ib2/aOLrasp0QMip1M muFIIIfQA4VFNhBg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 25F49138E7; Mon, 6 Feb 2023 14:10:44 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id YAZTN2QK4WOgQAAAMHmgww (envelope-from ); Mon, 06 Feb 2023 14:10:44 +0000 From: Fabiano Rosas To: qemu-devel@nongnu.org Cc: Thomas Huth , Peter Maydell , qemu-arm@nongnu.org Subject: [PATCH 09/10] hw/arm: Select e1000e for sbsa-ref machine Date: Mon, 6 Feb 2023 11:08:08 -0300 Message-Id: <20230206140809.26028-10-farosas@suse.de> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230206140809.26028-1-farosas@suse.de> References: <20230206140809.26028-1-farosas@suse.de> MIME-Version: 1.0 Received-SPF: pass client-ip=195.135.220.29; envelope-from=farosas@suse.de; helo=smtp-out2.suse.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org This machine explicitly selects the e1000e network adapter if no other option was given in the command line. Make sure e1000e is present in the build. Signed-off-by: Fabiano Rosas --- hw/arm/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig index 823f8b11f1..5022d519ea 100644 --- a/hw/arm/Kconfig +++ b/hw/arm/Kconfig @@ -233,6 +233,7 @@ config SBSA_REF select USB_EHCI_SYSBUS select WDT_SBSA select ARM_GICV3_TCG + select E1000E_PCI_EXPRESS config SABRELITE bool From patchwork Mon Feb 6 14:08:09 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabiano Rosas X-Patchwork-Id: 13130004 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A7138C05027 for ; Mon, 6 Feb 2023 14:11:41 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pP2Cz-0006Ar-IB; Mon, 06 Feb 2023 09:11:01 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pP2Cq-00068N-CT; Mon, 06 Feb 2023 09:10:55 -0500 Received: from smtp-out2.suse.de ([195.135.220.29]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pP2Co-0002hI-UZ; Mon, 06 Feb 2023 09:10:52 -0500 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 759DF60420; Mon, 6 Feb 2023 14:10:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1675692648; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=R/6PxDjMpu/2Zw++Jd22Tn23zYiQZOKZQKl2YBkloAA=; b=S28wz16xcYpWVw5ZtHMZJ1XYbUrXJQRxkctlj7+qTuWgSIh1Uch14ns3ELcavsyxc1H46T YWihhCBqLFbUI7lxDeedXZUpt8UQw/+tCd1CI1ZSMSjF7DfGXHrEYsMBX+wHUXOXBt9STe xcKNymCeg+87rRPN5i6cEGuYtzSpHsQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1675692648; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=R/6PxDjMpu/2Zw++Jd22Tn23zYiQZOKZQKl2YBkloAA=; b=h8ZDu4fbAJPaUgbcTm3uCotoTjmc76V4S5XQ5n2fcREgctU78upGhqk4Rf5Jc3CjuWwth+ S8deTqv1Il0sgaCQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 0BD92138E7; Mon, 6 Feb 2023 14:10:46 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 0O/XMGYK4WOgQAAAMHmgww (envelope-from ); Mon, 06 Feb 2023 14:10:46 +0000 From: Fabiano Rosas To: qemu-devel@nongnu.org Cc: Thomas Huth , Peter Maydell , qemu-arm@nongnu.org Subject: [PATCH 10/10] hw/arm: Select VGA_PCI for sbsa-ref machine Date: Mon, 6 Feb 2023 11:08:09 -0300 Message-Id: <20230206140809.26028-11-farosas@suse.de> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230206140809.26028-1-farosas@suse.de> References: <20230206140809.26028-1-farosas@suse.de> MIME-Version: 1.0 Received-SPF: pass client-ip=195.135.220.29; envelope-from=farosas@suse.de; helo=smtp-out2.suse.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org The sbsa-ref machine explicitly creates a VGA PCI device, so make sure vga-pci.c is included in the build. Signed-off-by: Fabiano Rosas Reviewed-by: Peter Maydell --- hw/arm/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig index 5022d519ea..74fceb419d 100644 --- a/hw/arm/Kconfig +++ b/hw/arm/Kconfig @@ -234,6 +234,7 @@ config SBSA_REF select WDT_SBSA select ARM_GICV3_TCG select E1000E_PCI_EXPRESS + select VGA_PCI config SABRELITE bool