From patchwork Mon Feb 6 15:08:52 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shyam Sundar S K X-Patchwork-Id: 13130086 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96697C636D6 for ; Mon, 6 Feb 2023 15:09:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229990AbjBFPJb (ORCPT ); Mon, 6 Feb 2023 10:09:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49076 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229508AbjBFPJa (ORCPT ); Mon, 6 Feb 2023 10:09:30 -0500 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2060f.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe59::60f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 51DDA9032 for ; Mon, 6 Feb 2023 07:09:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hXK0bCki2sikyT2CTchjEjT+7R9lS/Cj+Y7qIlcbms9I535nRc4voLTKaJAPB47vB/ODH2SW7ZJAX71McelXfL6u7ZHJ7nLEbSkAQx5auUXzHciX96zn7vRIqcyDtX+jPEbPO2nXEwbTmnjCCQMmjQMVq2Byl4Md6RGl/awdHAGwWqsXl+37MfMq9KJ7JyiWDpBANPi3wCPU6t+djRkfe2T8dljA+A10tJnJChgRZgdI0F8gpDGJhhbCxEUv3dK7ncfKW98VWqy/W0m5e70Hbexh2j3oiFqdCoxvCE4m7fMiqtIBjjc3CJ1zVvZexyjEQIe6BCkdy2vq3yUkaV9Rjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zUYVrbsWdvZwqQn4T+1H251afDKC+ka/p/UIqXlGNQs=; b=VrWKgshec/tf+UJRCxxFwiUO8n3OOkngg2afA0t9Q+nlPykiPNNscQz5jgjLtfoMaMhr3T3ZFSAms4uXXXQzBLsMG7WgSuaqz3QpQRL0eFkY6RGolwgbJy4g7RFiMwQigSYsiE0CT/OiWUFOcqkDN/PPMHKUyKeJ6UzIWKTLuTbF2LBM1FPcrsTnPb1Ug7yTySTZChnZsYNu3DLslaZh0qkKtcCf/fh/5ZLRS3m9OARb47SOySeaz1j2lRB4revur5QB390s0Diroe61YTP2Qk2Fov/bM5BR6PKsBd9uzPItXypyKYDQE7tdl3D4rfUvQUSp+Ynn4/9raAoLk0N1rQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=redhat.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zUYVrbsWdvZwqQn4T+1H251afDKC+ka/p/UIqXlGNQs=; b=O+s6DEt3jDhu9yO79icatnVbWW2J985XUSqC6ItsAYHXU7hRX6On+XmcVCLNS/9fW3JGMYfbSPrj3YN87lkX6fapZy6qfE/LKp1hxBkHTyDDQdiPJoaf2WaI69sbO3C19k81GNj+uMrR/Z2qalJ9QWv1r/7SQz8UiK4KFO3LNX0= Received: from MW2PR2101CA0027.namprd21.prod.outlook.com (2603:10b6:302:1::40) by IA1PR12MB8223.namprd12.prod.outlook.com (2603:10b6:208:3f3::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.32; Mon, 6 Feb 2023 15:09:26 +0000 Received: from CO1NAM11FT033.eop-nam11.prod.protection.outlook.com (2603:10b6:302:1:cafe::a2) by MW2PR2101CA0027.outlook.office365.com (2603:10b6:302:1::40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.3 via Frontend Transport; Mon, 6 Feb 2023 15:09:26 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1NAM11FT033.mail.protection.outlook.com (10.13.174.247) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6064.35 via Frontend Transport; Mon, 6 Feb 2023 15:09:26 +0000 Received: from jatayu.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 6 Feb 2023 09:09:23 -0600 From: Shyam Sundar S K To: , CC: , , "Shyam Sundar S K" Subject: [PATCH v3 1/4] platform/x86/amd: pmc: Add num_samples message id support to STB Date: Mon, 6 Feb 2023 20:38:52 +0530 Message-ID: <20230206150855.1938810-2-Shyam-sundar.S-k@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230206150855.1938810-1-Shyam-sundar.S-k@amd.com> References: <20230206150855.1938810-1-Shyam-sundar.S-k@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT033:EE_|IA1PR12MB8223:EE_ X-MS-Office365-Filtering-Correlation-Id: f9f952e7-65be-4dd1-681d-08db08542326 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: FpQTa5hai91tQcexLfMohXwTRqObnGuqKxscTcjFTcioFv4Ii35ogfb8Ca4wc+1dGoXwGGgFd2cDoWe9RloWlPq8SuKj8ZB4/zr9Wmw5jconGp+nPJVuh7YkPszddL+v9az4LAfcmQzYjZ0ihH+KSsr7I8ZBmS67r6Qp2hsnFRJwRuhNCEDHwjH87O8PbWRwm2Q5PwbxdZHQBGhYlJmRvIQOdLU+KKN/ayMNVREnV7JVm+qjbjYemS+z91zIfOLvyuiwiwBjnT1DwxcheggBPq5yJ91gxZPubgEFfdM9RCgIcbiNFdlw+11gPIejvew+d9YizdqgoniC0prTXjhnNoMjkfYAQ3eT+iI0xydur66BcDqmqKC7swkjp1COYyn6fgTbdkTpOiuqlw1/Nx+zbdkCDmYtub+eC8ppRLU28IQyH//IruuCuadCj6Oq115GUQZHV8lvhOmSkf9e3gSTwLXfMQl/s+PcrzAJVxYv0zJle/KocEhkQFNqgnZY+4/xOO0PLs0nOIY6LC66KaakktHNo4VBQ44dJ3DHYMn+X5eSSPfhvEQrO0v+OivGprPqPdkJY8wTdGh20KLRK4qNHhMLgECsZZxnVKB+QCqdfHi44HXOdKjtZo9SDNI2YZMC+s7NOSjs1kpsEOOiaQka9GiV1TCHcenqo0eBXAMSRGPEqofXalFXePkq9p3g4pziDgHyu11g1Yo0JU+Tx+YoTFB2WUkOCVCqm+FPtvwMZt2ESbrjMVupLKSKT5aX7hlVC3HPcF2oSlzCRkFPWyphow== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230025)(4636009)(376002)(396003)(136003)(346002)(39860400002)(451199018)(36840700001)(46966006)(40470700004)(2906002)(70586007)(4326008)(7696005)(70206006)(8676002)(2616005)(47076005)(426003)(336012)(36756003)(82310400005)(86362001)(36860700001)(83380400001)(8936002)(41300700001)(40480700001)(16526019)(186003)(54906003)(356005)(110136005)(478600001)(82740400003)(1076003)(40460700003)(6666004)(26005)(316002)(5660300002)(15650500001)(81166007)(750200003)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Feb 2023 15:09:26.1333 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f9f952e7-65be-4dd1-681d-08db08542326 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT033.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB8223 Precedence: bulk List-ID: X-Mailing-List: platform-driver-x86@vger.kernel.org Recent PMFWs have the support for S2D_NUM_SAMPLES message ID that can tell the current number of samples present within the STB DRAM. num_samples returned would let the driver know the start of the read from the last push location. This way, the driver would emit the top most region of the STB DRAM. Co-developed-by: Sanket Goswami Signed-off-by: Sanket Goswami Signed-off-by: Shyam Sundar S K --- drivers/platform/x86/amd/pmc.c | 27 +++++++++++++++++++++++++-- 1 file changed, 25 insertions(+), 2 deletions(-) diff --git a/drivers/platform/x86/amd/pmc.c b/drivers/platform/x86/amd/pmc.c index 3cbb01ec10e3..23440f70d3df 100644 --- a/drivers/platform/x86/amd/pmc.c +++ b/drivers/platform/x86/amd/pmc.c @@ -114,6 +114,7 @@ enum s2d_arg { S2D_TELEMETRY_SIZE = 0x01, S2D_PHYS_ADDR_LOW, S2D_PHYS_ADDR_HIGH, + S2D_NUM_SAMPLES, }; struct amd_pmc_bit_map { @@ -246,13 +247,35 @@ static const struct file_operations amd_pmc_stb_debugfs_fops = { static int amd_pmc_stb_debugfs_open_v2(struct inode *inode, struct file *filp) { struct amd_pmc_dev *dev = filp->f_inode->i_private; - u32 *buf; + u32 *buf, fsize, num_samples, stb_rdptr_offset = 0; + int ret; buf = kzalloc(S2D_TELEMETRY_BYTES_MAX, GFP_KERNEL); if (!buf) return -ENOMEM; - memcpy_fromio(buf, dev->stb_virt_addr, S2D_TELEMETRY_BYTES_MAX); + /* Spill to DRAM num_samples uses separate SMU message port */ + dev->msg_port = 1; + + /* Get the num_samples to calculate the last push location */ + ret = amd_pmc_send_cmd(dev, S2D_NUM_SAMPLES, &num_samples, STB_SPILL_TO_DRAM, 1); + /* Clear msg_port for other SMU operation */ + dev->msg_port = 0; + if (ret) { + dev_err(dev->dev, "error: S2D_NUM_SAMPLES not supported : %d\n", ret); + return ret; + } + + /* Start capturing data from the last push location */ + if (num_samples > S2D_TELEMETRY_BYTES_MAX) { + fsize = S2D_TELEMETRY_BYTES_MAX; + stb_rdptr_offset = num_samples - fsize; + } else { + fsize = num_samples; + stb_rdptr_offset = 0; + } + + memcpy_fromio(buf, dev->stb_virt_addr + stb_rdptr_offset, fsize); filp->private_data = buf; return 0; From patchwork Mon Feb 6 15:08:53 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shyam Sundar S K X-Patchwork-Id: 13130089 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 531EBC636D3 for ; Mon, 6 Feb 2023 15:09:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229508AbjBFPJx (ORCPT ); Mon, 6 Feb 2023 10:09:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49154 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230026AbjBFPJw (ORCPT ); Mon, 6 Feb 2023 10:09:52 -0500 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2060.outbound.protection.outlook.com [40.107.243.60]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EA3AA59F4 for ; Mon, 6 Feb 2023 07:09:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Q7DkJHUYvGbxFpONIWkdiaVFmiExciAwxn30Q1LOEQakC1yTCgeKaS24UVxoRMvwVHNcuaTfyvTc5Y9b8jBe2+mkXRkFoC9ynEuYq4wRmXKQKvPRMje9530zX5vEq30hHpHXFne3eNDl1+yvDfCwcmPeT1kC8h/rH6vdnyRVChJMZTx/P6L4FW3juuoyQFcD1gZdimQt9yozRgPvOaNh2OGgC/nvbLOtfLaKi3AH94o82tFgyMz78sECvUQWhV0/vG1WCz+kxloV6VUc8U5G+xOvrkJK9bEv/MN3v8RRDL+iNFPbDN50Bnl5MHb4DJfeZq4TfeTH3Fy5gxebeEiITw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ENxmEu+WXRCE8iGSgc2SyBg79SpcmSVlmpF63Tf/mMQ=; b=UPN+ar/uMzSUsyPUxl/xEIpu09LDAa54ML/tBTPDoHRWVfaHMcJjAgtJ3QFaMxtIhlPzcBg0Tx5JOf2vuJaLMFZYvm6bs5QD8UONryMTy1qgY6Dd+7STXpgmhHDAq7J7GXUW98uHMu3YF2xD6rlcE2dluh6V4lUc651h1Hx20pAFSwrCC23Bq4LDq6emU3qy3d9WyUCG8Y/pbzbV1RncphUVZQLpz/obQGl+WS7iP1Q/V1ygWTn8evFu54PQbN5p5/X5wxF6Im+ZM2mI3u07vWTZnkV4hLWqQBKeID8jsvle7qKicN+oaoEQ2CBPgUKwZbOCudfsvZW3stjw9UeqDQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=redhat.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ENxmEu+WXRCE8iGSgc2SyBg79SpcmSVlmpF63Tf/mMQ=; b=FrnxdmEYfTGc9INilQ6VKsUdrYtu0DhSr7nUPMw+ehqfGZkt4RBvfJXkctdKoYBygLUhOgrcK41Htib1d03oBs5nI/JoGDrSOGy2dUaEyI4pRAWNzVxXGcFMNw1jorsEtPZxrtNHS8/lAO9uEznqUpeTkv3oStDvP3kV0TqKAYY= Received: from MW3PR05CA0019.namprd05.prod.outlook.com (2603:10b6:303:2b::24) by MN0PR12MB6319.namprd12.prod.outlook.com (2603:10b6:208:3c0::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.34; Mon, 6 Feb 2023 15:09:29 +0000 Received: from CO1NAM11FT043.eop-nam11.prod.protection.outlook.com (2603:10b6:303:2b:cafe::57) by MW3PR05CA0019.outlook.office365.com (2603:10b6:303:2b::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.15 via Frontend Transport; Mon, 6 Feb 2023 15:09:28 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1NAM11FT043.mail.protection.outlook.com (10.13.174.193) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6064.25 via Frontend Transport; Mon, 6 Feb 2023 15:09:28 +0000 Received: from jatayu.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 6 Feb 2023 09:09:25 -0600 From: Shyam Sundar S K To: , CC: , , "Shyam Sundar S K" Subject: [PATCH v3 2/4] platform/x86/amd: pmc: Write dummy postcode into the STB DRAM Date: Mon, 6 Feb 2023 20:38:53 +0530 Message-ID: <20230206150855.1938810-3-Shyam-sundar.S-k@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230206150855.1938810-1-Shyam-sundar.S-k@amd.com> References: <20230206150855.1938810-1-Shyam-sundar.S-k@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT043:EE_|MN0PR12MB6319:EE_ X-MS-Office365-Filtering-Correlation-Id: 87d6991d-0f84-4554-0e91-08db0854245e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: cGkkGgGIOtMc8BaSoMABaR+8i5/+ea0jdq3expgc4h3BoK9lBZC9ye5ptaSviEYVjhq27YkYqfcanqeHzcsnhFIfe/5fwAMwwNNiklr65JvEx1mONIQhBYcfH5JsF8zHUueKBAjFPNWQ0sDsRO3nEnNGPVXHmxn0jYFdztAtBEUyOcCsHqtHEfu9wLNjBQIyjWrQgG2EuNXkDfNH2M1A6K0amGcMv1nj32/nyrjM7byO9H0ys6nHfnU1ukAhTJ5+L9AALcCIKvrMUQnbfI6qMbeny5ZnTG7O33uxFa/pVl7WG63F6dw+c52nWlxN4C03NlXv2KTdmQBXYr/SRHafNJR6uYbZ5BvW8ggjA8i1fNsrgkj/ax4M6g/osb6adltMnzeROVGfboA8o+YsivnJGHkEWjKUK/A+QW2AavVmPp4Nf0Hl9QAm2Qz6E9nohnk41VbUiDpJ62ZYTQnwR/fBSUIMXWr7RTBHM+Ifbi9Nv/JGKQS8DiR4w8n8D1V6qCGZUpWRTj5CIF6R76HnESas/XAmeEhOhISjcTMju1XzI+5qqfk/owuczcvfydcn4Ja0UgtkSA5XHi7K4muMKC4SPptUV4Gru07tnDv9TxGz9GoPpH11J0dwotSP5YbAaSPXcyd8FgfFZ4NZ3lDXn5sBNNz53ErXUTI2iSoLV+WErBn7PzVZs5dKyNeGOw16O10kUcUuSfqhr+HMvj/pzsaBIQmq5nTfvaUi7KTKjf9NP4E= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230025)(4636009)(396003)(376002)(136003)(346002)(39860400002)(451199018)(46966006)(40470700004)(36840700001)(41300700001)(478600001)(6666004)(8676002)(4326008)(5660300002)(7696005)(8936002)(316002)(70586007)(40460700003)(54906003)(86362001)(110136005)(70206006)(82310400005)(47076005)(336012)(426003)(83380400001)(2906002)(16526019)(186003)(26005)(1076003)(2616005)(40480700001)(356005)(36756003)(36860700001)(82740400003)(81166007)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Feb 2023 15:09:28.1913 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 87d6991d-0f84-4554-0e91-08db0854245e X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT043.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB6319 Precedence: bulk List-ID: X-Mailing-List: platform-driver-x86@vger.kernel.org Based on the recommendation from the PMFW team in order to get the recent telemetry data present on the STB DRAM the driver is required to send one dummy write to the STB buffer, so it internally triggers the PMFW to emit the latest telemetry data in the STB DRAM region. Reviewed-by: Hans de Goede Signed-off-by: Shyam Sundar S K --- drivers/platform/x86/amd/pmc.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/platform/x86/amd/pmc.c b/drivers/platform/x86/amd/pmc.c index 23440f70d3df..27774020597c 100644 --- a/drivers/platform/x86/amd/pmc.c +++ b/drivers/platform/x86/amd/pmc.c @@ -43,6 +43,7 @@ #define AMD_PMC_STB_S2IDLE_PREPARE 0xC6000001 #define AMD_PMC_STB_S2IDLE_RESTORE 0xC6000002 #define AMD_PMC_STB_S2IDLE_CHECK 0xC6000003 +#define AMD_PMC_STB_DUMMY_PC 0xC6000007 /* STB S2D(Spill to DRAM) has different message port offset */ #define STB_SPILL_TO_DRAM 0xBE @@ -250,6 +251,11 @@ static int amd_pmc_stb_debugfs_open_v2(struct inode *inode, struct file *filp) u32 *buf, fsize, num_samples, stb_rdptr_offset = 0; int ret; + /* Write dummy postcode while reading the STB buffer */ + ret = amd_pmc_write_stb(dev, AMD_PMC_STB_DUMMY_PC); + if (ret) + dev_err(dev->dev, "error writing to STB: %d\n", ret); + buf = kzalloc(S2D_TELEMETRY_BYTES_MAX, GFP_KERNEL); if (!buf) return -ENOMEM; From patchwork Mon Feb 6 15:08:54 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shyam Sundar S K X-Patchwork-Id: 13130087 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15589C636D3 for ; Mon, 6 Feb 2023 15:09:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229834AbjBFPJe (ORCPT ); Mon, 6 Feb 2023 10:09:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49094 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229508AbjBFPJd (ORCPT ); Mon, 6 Feb 2023 10:09:33 -0500 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2047.outbound.protection.outlook.com [40.107.223.47]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5D36AA5D4 for ; Mon, 6 Feb 2023 07:09:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jvmLNnfx6PZqrtZdal/GzUocRPTCd+76Dg+/oe2iKuFsGNz9JWjycxRCNOzGlPh0wr3c3aV5K12uPoEyV9IZYtQu5wQjonEieJTkc1rekermsGbumNJiXrDOYaK4nSBFjv/y9j5tLA1s0xn8pt9XrYGprX092hQhhshrReoqjk1qDxfaOA/MwCbQNHc9dlSybEgPaDixbEjmgU8ISBOAZo56/6Gjtj74GZEaPM8GS66HmDCACyO0/N5hyvqThOtuPo6nvSQgkdXCQIByrC7tAPPnShPgxYCaJJN2CZMinUvv/Lz/RJIvkbHMw9lqpLF545y04SaYC4q2DWmTuHOmSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ECeYvIKQF7yz9Rw0Oeu+SmJ/mc502bgnj7jYoQ5dM2c=; b=UZKvBrQSLqx14MYPSyJjyOXupTEzrtAaNnkC+r6LRKGgnhMxTIbm2CFJHQtE8Tx9LV6XoqO1NhHcj3iPtRG7NC91v6XlujUbOCwHSLXa5sMKIlecOVvdevdfhc/4JoNsISUFbFmmkib4kuNh7H6AgRSssgqIuz8BvWwpwkagKPVP7YNTysM03bAVo7veq5GU/AuIxl5XKsrIaNmXuuix9Y/9HKOLcw5kEkswmdM0gqSrGgIsE/JShdYHxwl82/9JaW+y8ZuywrtIVqHk0zQaOkg+6tg7zSDf6PQSqhWksXSVIzYx3mO05Kda5xByydnaVStFtlEaHd3XbVOJ3k/1bw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=redhat.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ECeYvIKQF7yz9Rw0Oeu+SmJ/mc502bgnj7jYoQ5dM2c=; b=EqxD2euv4Babria68F4TUZt5p1Pq5eUZOG1N9nlojFR5i1XJATJ8RyJRUSHI8GRQ9/pRUIZwwLAPq1n/z1RBK76NionOwGgaNE/EmPULiDX4xSLN28x89df2DPAFuJk1J3W6tG9kCWd883XlS/IHsuFHdCL6KBZZpBQn0S0yS7s= Received: from MW4PR04CA0224.namprd04.prod.outlook.com (2603:10b6:303:87::19) by BL0PR12MB4881.namprd12.prod.outlook.com (2603:10b6:208:1c7::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.34; Mon, 6 Feb 2023 15:09:30 +0000 Received: from CO1NAM11FT079.eop-nam11.prod.protection.outlook.com (2603:10b6:303:87:cafe::9) by MW4PR04CA0224.outlook.office365.com (2603:10b6:303:87::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.35 via Frontend Transport; Mon, 6 Feb 2023 15:09:30 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1NAM11FT079.mail.protection.outlook.com (10.13.175.134) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6064.32 via Frontend Transport; Mon, 6 Feb 2023 15:09:30 +0000 Received: from jatayu.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 6 Feb 2023 09:09:27 -0600 From: Shyam Sundar S K To: , CC: , , "Shyam Sundar S K" Subject: [PATCH v3 3/4] platform/x86/amd: pmc: differentiate STB/SMU messaging prints Date: Mon, 6 Feb 2023 20:38:54 +0530 Message-ID: <20230206150855.1938810-4-Shyam-sundar.S-k@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230206150855.1938810-1-Shyam-sundar.S-k@amd.com> References: <20230206150855.1938810-1-Shyam-sundar.S-k@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT079:EE_|BL0PR12MB4881:EE_ X-MS-Office365-Filtering-Correlation-Id: 3b55fad3-2c44-47f6-07d3-08db0854258d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4wtR9q+A2Kq9YkuwjXvpZYimK3w12N5yNo6uhfAXMHwhF28V8D3MysOf/sTugRj/4Al4I70xScaBc30S3j8Hq6ouxyQomuuNyAZLHlQ+gQQYz+5JOkHhAbey27J/hxiYiWprpxblJSrSFq2ycBDErTdq9pLq2jtsKIQjRRSSKoK4Szww4TfrOwXdzuj25/jZFoH0Iq02tBTFwBFyoEgE9S9lSUVbIE+pfNgm1VblEKnYVLuHK44Rgzb/YVwtkGkqDay9wzHu6KtTHfEKVcfBn1SY5DaYLmUz8eQ8wSrv9+yB2R6mWQlk0lybcznq2+nZiLofuC4aQ0bmTc/LSIP5z6MXrj+XGXN/aJyDWjOBkgfNUxemuJ38RWauvcOdExLqL6Yl1XQ6MBlbx35bAJYe8ygJZyUJV/5a0YZ2fbeET0BfBBA9Zt9YR8VAToLY9MXRE/e7AHd9pGfuqSYgCkvsIRACNK/RtyGDn3aLlPNx43drKgrPWBbfQlbMebycrd6LrBoy4vhQz3vEdYTlw4RwwQ3Nb0zqbswoSYvByJETMJDn/KfdTgewAvk5+wUyY4h32W+lutY+dg5mQid8MQboBNmvVG0gpkIRF4yHpOTlQZQPTWTECIAK3PND72/pPY6r4cKGZl7vRSrzRPFYB4x5cJNKgks9RpkHiDHffWpklUOoXbr/Uo0UPeQUp5DMDbskLymQttoNgqYn7xJPnGtmZxQzUqYg3TJFZ1Gx5k7gNBU= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230025)(4636009)(39860400002)(376002)(136003)(346002)(396003)(451199018)(46966006)(36840700001)(40470700004)(2906002)(36756003)(7696005)(16526019)(26005)(186003)(40460700003)(82740400003)(36860700001)(47076005)(83380400001)(426003)(336012)(41300700001)(2616005)(4326008)(70206006)(86362001)(316002)(5660300002)(40480700001)(8936002)(8676002)(70586007)(1076003)(6666004)(110136005)(54906003)(356005)(81166007)(478600001)(82310400005)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Feb 2023 15:09:30.1769 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3b55fad3-2c44-47f6-07d3-08db0854258d X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT079.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR12MB4881 Precedence: bulk List-ID: X-Mailing-List: platform-driver-x86@vger.kernel.org Modify the dynamic debug print to differentiate between the regular and spill to DRAM usage of the SMU message port. Suggested-by: Sanket Goswami Reviewed-by: Hans de Goede Signed-off-by: Shyam Sundar S K --- drivers/platform/x86/amd/pmc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/platform/x86/amd/pmc.c b/drivers/platform/x86/amd/pmc.c index 27774020597c..b99fa676d35e 100644 --- a/drivers/platform/x86/amd/pmc.c +++ b/drivers/platform/x86/amd/pmc.c @@ -589,13 +589,13 @@ static void amd_pmc_dump_registers(struct amd_pmc_dev *dev) } value = amd_pmc_reg_read(dev, response); - dev_dbg(dev->dev, "AMD_PMC_REGISTER_RESPONSE:%x\n", value); + dev_dbg(dev->dev, "AMD_%s_REGISTER_RESPONSE:%x\n", dev->msg_port ? "S2D" : "PMC", value); value = amd_pmc_reg_read(dev, argument); - dev_dbg(dev->dev, "AMD_PMC_REGISTER_ARGUMENT:%x\n", value); + dev_dbg(dev->dev, "AMD_%s_REGISTER_ARGUMENT:%x\n", dev->msg_port ? "S2D" : "PMC", value); value = amd_pmc_reg_read(dev, message); - dev_dbg(dev->dev, "AMD_PMC_REGISTER_MESSAGE:%x\n", value); + dev_dbg(dev->dev, "AMD_%s_REGISTER_MESSAGE:%x\n", dev->msg_port ? "S2D" : "PMC", value); } static int amd_pmc_send_cmd(struct amd_pmc_dev *dev, u32 arg, u32 *data, u8 msg, bool ret) From patchwork Mon Feb 6 15:08:55 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shyam Sundar S K X-Patchwork-Id: 13130088 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D39E6C636D3 for ; Mon, 6 Feb 2023 15:09:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229949AbjBFPJk (ORCPT ); Mon, 6 Feb 2023 10:09:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49110 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229508AbjBFPJj (ORCPT ); Mon, 6 Feb 2023 10:09:39 -0500 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2045.outbound.protection.outlook.com [40.107.244.45]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A6B434C00 for ; Mon, 6 Feb 2023 07:09:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=d03VNs6QPNCcxyG7NxqD6PUAvZe4E42oPaKDMAfXIziOr8SCfSWiYY4q2GzLjLMuymnn5vvcqUuHcE1u3P3zy4It5NSbMgzTyq8QDoJ5uRqDreNd/Po2UoIFmXaCE8qmE6yrQl6orRc0ATN2Y1eXmYxqPgxDcTKGJsd3BzuHC3CBymFW6eCqWsJrBZqh51reTFXgqXVqh7SPBlI5oktc19Y4m4XUM2DOBL1HE4HP+LdiEMZZhnkCQTjDfOxV6T5SUbvo/Z65C8Zu3cfiiW52AkKqEWpuQ9R0yR1i04e4XCtER1YUNND86XSUDGSIDwSdI9qiRlCzQXc3iG1v2NLmyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WD/DIJ2ioMg+Epb5T5eiZbBUeZFNfdETHugsw9Bjros=; b=Ox6ZKetelFPzoWGYGqWAp3tfUbyhIQQZwTrxFkhRiGaMmTmNWOIuvtWsugK9j/AMD9LPnXe4UD7DD6idu39HcVeMhMXfktPSIHXjyqPxpY0v1oVIe3Fi0MQhRmAV2QrgEI18cNRPOibdErsCuhqHKEX4TUtxLbPWEcxtLjpvDcrQ5cHznAItz44/lcCJiS9otX+pn4SAIzdq0rQUp1rZPUYoY94feSPFuf1JJQdbKby/kNLGoSju7eMr5wy9QnEHIda+uzYCTMfvraG1q9qNS7HXX0+X7ACo/6GV9h7BGrflqg7xL9CTO+Swq0BNJbyOrXQxkbT41Oc63ajjLs4wsA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=redhat.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WD/DIJ2ioMg+Epb5T5eiZbBUeZFNfdETHugsw9Bjros=; b=dt8uFh0k6LTkDz0oj1tIFEgQz3mkIuSILEPY/4QQJ74U8APrIhEiYbkzniCvvNhYPJLGPniekYAAWaGbgjgac36m/+mzn/+6EzmCqEVzK1ZKTiVWgeD1WK+EhJbuwy5ISmZXs5UGAORPJYjMeO3Oa6+YMyXQ2PNYsVjvYpwTA7Y= Received: from MW2PR16CA0033.namprd16.prod.outlook.com (2603:10b6:907::46) by MN2PR12MB4110.namprd12.prod.outlook.com (2603:10b6:208:1dd::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.32; Mon, 6 Feb 2023 15:09:33 +0000 Received: from CO1NAM11FT011.eop-nam11.prod.protection.outlook.com (2603:10b6:907:0:cafe::f4) by MW2PR16CA0033.outlook.office365.com (2603:10b6:907::46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.35 via Frontend Transport; Mon, 6 Feb 2023 15:09:32 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1NAM11FT011.mail.protection.outlook.com (10.13.175.186) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6064.32 via Frontend Transport; Mon, 6 Feb 2023 15:09:32 +0000 Received: from jatayu.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 6 Feb 2023 09:09:29 -0600 From: Shyam Sundar S K To: , CC: , , "Shyam Sundar S K" Subject: [PATCH v3 4/4] platform/x86/amd: pmc: Add line break for readability Date: Mon, 6 Feb 2023 20:38:55 +0530 Message-ID: <20230206150855.1938810-5-Shyam-sundar.S-k@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230206150855.1938810-1-Shyam-sundar.S-k@amd.com> References: <20230206150855.1938810-1-Shyam-sundar.S-k@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT011:EE_|MN2PR12MB4110:EE_ X-MS-Office365-Filtering-Correlation-Id: 8793a0ae-d39a-4f99-2a22-08db085426c2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XofPVTiOljuAGs/wBNuMtUH2lg0HMSgNsvLgfUzf/t0hZiC8B581yVtbCVXVrYSGoCRBMHqWnXC4h3XL7pho3vyAeVsVfr/xxmdNoyjG8sb+QJoNyLKXAWNYDW+ouBynnFvz60Bjp5u6hhb6taoUWfYWysGVUMVsemPo2nDoxvAxFpwig27h9Hk4JAwRh9/6TsnBrUV3E3BnXjYlw49+9CM7JmE4RdJXnrjDIY4EWdZL3hPCrtFa+jnl8uZ+WHyzg3M13YuTCkdBE2+Q9IdHNcUJimxyk1v07E+nYURSzrQq5nO4cubWoj5aKT3CG86uvQNzV2Ydpc/3mJSKg2ysvklWfAOpsMaETT9vqvR4xUp0iS0We5bF/qBxdVLwmdKZ5e/FzVei2oKIjoIN4R+PtBofeJS2E1fQgJnlYRvBrS/oZ+zfUQT+8H3Ciha5ygi8V9Y9tM9UaisLNScAVstJ2JeQSiOZbzlHLfX8U0oWSMQ0B2GS2a5fiahWHDzMMjcvvCHUxPPqafeOk3ag/p+ixeUTocAiqYZiZlKEqwJf6KHg9HZUKoMiNwpurYorDTTOudy5C8yPlhU5TJRGLzqoh2XRItoErfYmRLFxQzQYqrnQaGrpB5SGH8svuB/7n85l4RatjT1yyBDmxG8CAz7YU42G4oN63Xx8zVT1W0NODZEbqtjCqeqtrqHw8lArifebHj37X6bRFI+ZsjqKWHzhMUT3RhryHQFNPSlcr2jbPIM= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230025)(4636009)(136003)(39860400002)(346002)(376002)(396003)(451199018)(40470700004)(36840700001)(46966006)(54906003)(110136005)(316002)(86362001)(6666004)(82740400003)(7696005)(81166007)(16526019)(1076003)(356005)(186003)(478600001)(26005)(82310400005)(2616005)(2906002)(5660300002)(4744005)(40460700003)(36860700001)(36756003)(426003)(336012)(40480700001)(70206006)(70586007)(8936002)(4326008)(41300700001)(47076005)(8676002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Feb 2023 15:09:32.1872 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8793a0ae-d39a-4f99-2a22-08db085426c2 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT011.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4110 Precedence: bulk List-ID: X-Mailing-List: platform-driver-x86@vger.kernel.org Add a line break for the code readability. Reviewed-by: Hans de Goede Signed-off-by: Shyam Sundar S K --- drivers/platform/x86/amd/pmc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/platform/x86/amd/pmc.c b/drivers/platform/x86/amd/pmc.c index b99fa676d35e..ab05b9ee6655 100644 --- a/drivers/platform/x86/amd/pmc.c +++ b/drivers/platform/x86/amd/pmc.c @@ -105,6 +105,7 @@ #define DELAY_MIN_US 2000 #define DELAY_MAX_US 3000 #define FIFO_SIZE 4096 + enum amd_pmc_def { MSG_TEST = 0x01, MSG_OS_HINT_PCO,