From patchwork Tue Feb 7 03:33:37 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Tomlinson X-Patchwork-Id: 13130947 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 594C4C636CC for ; Tue, 7 Feb 2023 03:33:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230106AbjBGDdu (ORCPT ); Mon, 6 Feb 2023 22:33:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42930 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230088AbjBGDdt (ORCPT ); Mon, 6 Feb 2023 22:33:49 -0500 Received: from gate2.alliedtelesis.co.nz (gate2.alliedtelesis.co.nz [IPv6:2001:df5:b000:5::4]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B64972B63E for ; Mon, 6 Feb 2023 19:33:44 -0800 (PST) Received: from svr-chch-seg1.atlnz.lc (mmarshal3.atlnz.lc [10.32.18.43]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by gate2.alliedtelesis.co.nz (Postfix) with ESMTPS id 897E72C02A4; Tue, 7 Feb 2023 16:33:41 +1300 (NZDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alliedtelesis.co.nz; s=mail181024; t=1675740821; bh=B9TvaMmkUAniP3h7ay7qPQ4OgQJ2sokxLiIjsCV1DuQ=; h=From:To:Cc:Subject:Date:From; b=sW7koW0nwth9NyRW5311JyXeB9OLNc69bIrJ921uh8lMBSeGe/88fc3ZTTSEpaHXx wHMQKc+Zv9/TT0muQJYu73gAWL8CAl6nUWV+wLX5M92XiXc/SMOPmmaZ6sQwcQ+uef exOuGIiaXUZrkGPOn4/xsuoo1oGD0Da0tF5x7ax6UkKiigNnheICK/iXdG6SKoMnTc wtoj4YJVHteUKm8u3pshCoeQ8jUnfBdkiQ8yWIVTqY5OlwLzWZYYLPtdYA7P6Fh9VD 5FK25jj3abYP/RixX7aEGbEbRsGgBWqUj4ujCxwQj9hCAwwmho3uFABwaX3Y2ZRvXQ Brz3Nft3MnxCg== Received: from pat.atlnz.lc (Not Verified[10.32.16.33]) by svr-chch-seg1.atlnz.lc with Trustwave SEG (v8,2,6,11305) id ; Tue, 07 Feb 2023 16:33:41 +1300 Received: from markto-dl.ws.atlnz.lc (markto-dl.ws.atlnz.lc [10.33.23.25]) by pat.atlnz.lc (Postfix) with ESMTP id 5DB5B13EDC1; Tue, 7 Feb 2023 16:33:41 +1300 (NZDT) Received: by markto-dl.ws.atlnz.lc (Postfix, from userid 1155) id 5A30433E965; Tue, 7 Feb 2023 16:33:41 +1300 (NZDT) From: Mark Tomlinson To: gregkh@linuxfoundation.org Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Mark Tomlinson Subject: [PATCH] usb: max-3421: Fix setting of I/O pins Date: Tue, 7 Feb 2023 16:33:37 +1300 Message-Id: <20230207033337.18112-1-mark.tomlinson@alliedtelesis.co.nz> X-Mailer: git-send-email 2.39.1 MIME-Version: 1.0 X-SEG-SpamProfiler-Analysis: v=2.3 cv=a6lOCnaF c=1 sm=1 tr=0 a=KLBiSEs5mFS1a/PbTCJxuA==:117 a=m04uMKEZRckA:10 a=mwjI7TqugprM___TUpMA:9 X-SEG-SpamProfiler-Score: 0 x-atlnz-ls: pat Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org To update the I/O pins, the registers are read/modified/written. The read operation incorrectly always read the first register. Although wrong, there wasn't any impact as all the output pins are always written, and the inputs are read only anyway. Fixes: 2d53139f3162 ("Add support for using a MAX3421E chip as a host driver.") Signed-off-by: Mark Tomlinson --- drivers/usb/host/max3421-hcd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/host/max3421-hcd.c b/drivers/usb/host/max3421-hcd.c index 352e3ac2b377..19111e83ac13 100644 --- a/drivers/usb/host/max3421-hcd.c +++ b/drivers/usb/host/max3421-hcd.c @@ -1436,7 +1436,7 @@ max3421_spi_thread(void *dev_id) * use spi_wr_buf(). */ for (i = 0; i < ARRAY_SIZE(max3421_hcd->iopins); ++i) { - u8 val = spi_rd8(hcd, MAX3421_REG_IOPINS1); + u8 val = spi_rd8(hcd, MAX3421_REG_IOPINS1 + i); val = ((val & 0xf0) | (max3421_hcd->iopins[i] & 0x0f));