From patchwork Thu Feb 9 17:48:28 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Chen X-Patchwork-Id: 13134908 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96E82C636D6 for ; Thu, 9 Feb 2023 17:48:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8C6D76B0071; Thu, 9 Feb 2023 12:48:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 877826B0072; Thu, 9 Feb 2023 12:48:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 717F96B0074; Thu, 9 Feb 2023 12:48:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 624416B0071 for ; Thu, 9 Feb 2023 12:48:47 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 34B8614063E for ; Thu, 9 Feb 2023 17:48:47 +0000 (UTC) X-FDA: 80448488694.16.E3AFBF0 Received: from mx0a-002c1b01.pphosted.com (mx0a-002c1b01.pphosted.com [148.163.151.68]) by imf21.hostedemail.com (Postfix) with ESMTP id 92FFD1C000A for ; Thu, 9 Feb 2023 17:48:42 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=nutanix.com header.s=proofpoint20171006 header.b=iEZCGb+I; dkim=pass header.d=nutanix.com header.s=selector1 header.b=DzxgYRsv; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf21.hostedemail.com: domain of david.chen@nutanix.com designates 148.163.151.68 as permitted sender) smtp.mailfrom=david.chen@nutanix.com; dmarc=pass (policy=none) header.from=nutanix.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675964923; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=xL7awbJObVbc2nRJTOIIb3UurSH7DRGDnYjHphwmBAQ=; b=Z5OQrv/wKYkKqfLE7GeOoNuAtqbByOeyUuIYShybGycKPqIhA/nkJFLRgDhOJd2ebaUq+l Ga2ZNwgXvQpL0pO9dEu9xeCaOWYIqu2mi5Z0S932shnb8pmHWRSw/m+k4jmmRD7GNwSlt7 zhxpvxw8x86vi7IIkwN0UFCbBhSgTUM= ARC-Authentication-Results: i=2; imf21.hostedemail.com; dkim=pass header.d=nutanix.com header.s=proofpoint20171006 header.b=iEZCGb+I; dkim=pass header.d=nutanix.com header.s=selector1 header.b=DzxgYRsv; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf21.hostedemail.com: domain of david.chen@nutanix.com designates 148.163.151.68 as permitted sender) smtp.mailfrom=david.chen@nutanix.com; dmarc=pass (policy=none) header.from=nutanix.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1675964923; a=rsa-sha256; cv=pass; b=O4m3twMWFjJaoBp5KJoYQLxgg3Zhbsyo+SyJRBQob4dg2rQzWmAw3QIDHUSjjcZcD8Kf/J gM5d+7eiV3Z+BXIUwXiEJJdpio0WPNRdkM3OM21d6Pzbu5+Om6noi0tWsijvyd/sF3u1q9 UVA0re6bwBnoNlKAHr/eBWpTMA17dCc= Received: from pps.filterd (m0127837.ppops.net [127.0.0.1]) by mx0a-002c1b01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 319HaPC4009716; Thu, 9 Feb 2023 09:48:33 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h=from : to : cc : subject : date : message-id : content-type : content-transfer-encoding : mime-version; s=proofpoint20171006; bh=xL7awbJObVbc2nRJTOIIb3UurSH7DRGDnYjHphwmBAQ=; b=iEZCGb+IzMmn2uwL6wgKKdP64P3E8s31C87kXkr6DiQod65GWqjGGypm8AzKZh68tCBi 1x3OBTg3w1N4YjrmIttsekvTXlkNru1cW2UcUwPqbgNDBbFGnM/2EJZIInQPNSB27zf6 L3YegAWizCeqefuy1Tr+LR1DLR3332ABgPJFTTUjnjG7dQ/HTObAGkdoILBYxAsZytUV p4oIpbUeBMSOOyt8s/Fln6rzzTBsHwr5aK7AW/m68xQJNnALIEatF9OuUZFAg6i2fYn2 Zc/DELfmkHQ+QbEHvOqq5Kz+3RwZPP8nZDikQR1BlOpSiFI4ufohVAEdED2brN2GHrwq Qg== Received: from nam02-bn1-obe.outbound.protection.outlook.com (mail-bn1nam02lp2042.outbound.protection.outlook.com [104.47.51.42]) by mx0a-002c1b01.pphosted.com (PPS) with ESMTPS id 3nhm5j0n5w-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 09 Feb 2023 09:48:32 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nL2s8vJ1kpdWrnVZZTUXNHR8y7r5PJzmA6VyjU2rKtH1YaK2mpE0aLQRrz5ZKfFNQtUPiFXKjiQ2taGEO1+J2I7+vcvYexlkMHeXFluyDg4nu7s0912eYO5vTOKQJAomkYNvdJRG5zEcXCn7rV1YUJk+UeKopRdfulAnzfNRMt5hP56sX0UTqZG3gXvVvRw+co7YDDn61GEaCDScq/7pw8J1RqWC0BbBju+TPC/SvIn7h6fEMKrd7xkZg89ZPx9HvO+iDJmijsHhdhTHLbWZdKFQmfGR+HMiJRnY0/csbRMy/XHiawTGRO2qHZdQd/NDMNWB58XuligLVXW3/Ixhwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xL7awbJObVbc2nRJTOIIb3UurSH7DRGDnYjHphwmBAQ=; b=eYdbies08SFyG6vGB7q3PgXbVFgnCklQpwmt/HMZ5ATe02gNEY1VNwdOdALHsyjR4XamWjXtcw0HDVe/bGte1J3N6zVuMI3JE6Mdl1HO9c7pU3/qU2Fg0U3fRVshw4ZH5pkwmbAODlW2EgItkXl5NrHOIhSkgHJlH+EtxH5MonHc/n0N2OD/TCJ4j7k9VNNOhjp/irKH0GghcoPoda5cseLnCbpzQat2GtYQyDyiAIONpbW8glGD1+b68wp0LWe5nb7dlZiN1p++LmYCj0m45q8+NQnChcEE64yV22chWqMWvzjWv/tj/9QVt/+jxPEc7HfYBUn0y4TPHI9Kqfby+g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xL7awbJObVbc2nRJTOIIb3UurSH7DRGDnYjHphwmBAQ=; b=DzxgYRsv24slc87b+MkIzyWBUO74HN0EikyoCWcB2nuRfXaiabd9II7Tkq+4pXzFNsq71jCo9BhpVA/jinUv4jLtIJBhfX9PyVAZcFIyEdoVHMgm947PpTKspSV2z0QoxMrCbYMDMGOoCnRW/4HzH87kvm4wpFiL3MA85rbfi2aRk66Xi93Lh++hhfaM1DlNuK5O4mEnE3Hmh73XUGRIqtZIM2tiEpjjBRGsUGLT0afX72N5CzPtbIgToLSvTRydmxelg1Wi76MrBG1lKAWf4Z4gbzRHPrig6uf3naKAmqJorZhyzbwCLTNaJ2nGzJ4iINLlt3hVEmndhFx6UPN9xg== Received: from BYAPR02MB4488.namprd02.prod.outlook.com (2603:10b6:a03:57::28) by BN0PR02MB7936.namprd02.prod.outlook.com (2603:10b6:408:166::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.17; Thu, 9 Feb 2023 17:48:29 +0000 Received: from BYAPR02MB4488.namprd02.prod.outlook.com ([fe80::8ca2:b10b:6212:28f4]) by BYAPR02MB4488.namprd02.prod.outlook.com ([fe80::8ca2:b10b:6212:28f4%5]) with mapi id 15.20.6086.017; Thu, 9 Feb 2023 17:48:28 +0000 From: David Chen To: "linux-kernel@vger.kernel.org" CC: Andrew Morton , "Matthew Wilcox (Oracle)" , "linux-mm@kvack.org" , "stable@vger.kernel.org" Subject: [PATCH] Fix page corruption caused by racy check in __free_pages Thread-Topic: [PATCH] Fix page corruption caused by racy check in __free_pages Thread-Index: Adk8reA65mQ6l+W5TEuqm6ZJpEFBNQ== Date: Thu, 9 Feb 2023 17:48:28 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR02MB4488:EE_|BN0PR02MB7936:EE_ x-ms-office365-filtering-correlation-id: fb7cc447-b7bb-43b9-ef39-08db0ac5da37 x-proofpoint-crosstenant: true x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: tG1aYfQi0DkDUnZJ+rT38VRsaf1PChxxe8jS3+DQWWtlQCO4kfN2B0sEojP6rDfNhZwthKenTLwoYppq5UwgnD357UAqkiivchd/q0jw/YsV9dcBAOJLJ3cSiLcaH0ibDFg1tEbHCWGM9yN2FWEHkVdqw6CHZiAvSCk+HlPbsx/nI+L6sTbnZz1Cn/8RBVAyg3adqdoRZCEwwRmmRKZ5Cy9Jio1POwsSisd6AhrPl9HhJqB4eamKwlgBRTjEWItC9Zu9P7yjUp7J/WJdkLAUnA8gd7KCt17ePGaDpHnd8IOTYYjODS2SZXqxLM2P9/h0kKs0u0n4dRYho9ht6xvzCN2MdPSPszxta1mOsAZGrLVxhR6id+y4cc759JGi9Sw5V+/wbJkx9KQCNFjaEDr2PImn2yFxpUVeplnI0aPZJrg4/NyobIH366Q9aZYhIWin/lWbHs2x0RECW95gUKeKTQOoPv5wIP9W5V8p0jq1bPE4UAiAf5Tm8Tx/ZsNMC2orDxRK+LGY5MBJ8AlDS8aL7M9yJAjn8qV7W2/XRcWhfrE69HB1uFA0xSo3qn1U0tb0QMYhEFvqE1SjTjfVcee/4jMjGeYRbt0mAqKmi4CfaMjIh5pdfwvvTtKovoyXhk+CkSVH/YQD0/97IpRoOqyNFP4aROxtQABzK12Ts7uqMMAONz/8rL/jnPGrlDFUFfaH31GqOLuNIcdIabxmQ1XdRA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR02MB4488.namprd02.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(396003)(39860400002)(136003)(366004)(376002)(346002)(451199018)(76116006)(66556008)(66476007)(6916009)(66946007)(41300700001)(478600001)(33656002)(54906003)(316002)(83380400001)(38070700005)(38100700002)(7696005)(44832011)(8676002)(9686003)(186003)(86362001)(71200400001)(55016003)(26005)(66446008)(122000001)(52536014)(8936002)(5660300002)(64756008)(2906002)(6506007)(4326008);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: XlFg6ijqmqOi8+NuUZQoin5XY9xTCDRAZSndDehKxet5zw/bRy3/ATGo7/y9eIWvJlTPqxK52LDWCfIRFoM9KW1y5jrMGqO+sePAhUuA6IERccvWnj5wZN/SMv/wJE3kfAgWr7tm1VQckYVkbT3XF8/yPAn1MBk/Idpf1L8Tkv9D0XR/jOK6hCNnuwIa4TIS57d2q/nw0tf312m6Fo3ybgn6skxgVAO0t3guCHtW32DAR0KIQjIe1iQVtzlN80lP8xVFrMw+bN/LbgcCuhFU1zFHKCuHk4OyBX2lOFYyLU4NtnW97pwUHTCp3kEgJT/yR/LwWd0sxP2X8XRE7vCEq1ZzH5Xw3oECDKoTwcztSE7tYe1Fr7MzkBWInwBDSHXxZKo3fkkjO0XEd557xrd0kPHZJF8Lc5TJkNxTninRPc1ENmJJFCiG+xgEJNoFpaPIB/0swp5c2jvz2TfwFd6isr/ycuEonnyX7GpL80MCeQ72Fy2ACsoi/h8AI7T49pQ47kHrAuqbdqWGYCEGpwwfDwCVx5ZnjTnDYkjjxllOch7B9YVBtPbrQ7paaLEbvn8+qOolUh+0iUNU2dvW3p3XR0xllaHg1qa4IKBY0bOO5+9E51KNLGmgszZ4SOyVgHQPGFxM86hVzC02tBB9EwWoElh2lCfRgNMX5Agps6wbtRC6kbyB+kZrsplNNbEhJrkWTGjZS+QMawbxRH2BFIvcawa9srmaWSP8aWx+SMRHE/uOqe3ykETfOdfsVoTvrWkBfgLRwkdsMQ37ucyJ9Yl8Yx4CBkUtwD/uub61RF08/lGsPdg4I+qLQZApz8aItweUgMZ9BiLTCtE5khFytgx3T+ZLX1OKMmVv+d4TSA/QHpnr0pCZ+0wXhzFLfOBtMAm1MVsA/Yl2f89XLYlH9onJ4m1sCdNfm1maT2UDlvb3wrW+rvGEM4ZzkofmLME28NBSLhDRSeEZWWsTbi75lZgwSFnq3KrNoMhfwmUHT18SvkhTc+0YNcX9JZBPoKtT9M4UVaFkoKYKb1bid0aotSIschG0qCZ8QHFwFDf1iYdjyCUsULz6rshQ38iT8LRK6xWT7pqxC9lzyL7MBud5jFXpsPBpotNVDblpmA1PIEtIxII7BUWIllUD3zju1ri90fxmAaPzxBqHH926tRikHKnXCkT1QO3Z8fCpD+abLCYe3Mw0KWfZzcHPzCGNSVIJawwaATRoNmCSTl3lgtNDZRIlGWgBTigDC0rlONd5226BWB7R1J3C7RqVmXgeWovkiTEbtutsC9ry/s2AMpBcdQaDj1tDwg2AVsSfQ+I9TYQs6iUEieIGNvmf7lCDEJp6VK61iXeVrpynyQJnHZYUK5oUO0orUsQqxSxFXmOuzaVuajEhFtL4WfW/UeBWhhCfwyaDHiuqrFFAtMKl8zkse7l8K6SH/RAvamwwgSVLk5x3RASIMk79KrLBFossqZh6q+XFWpWXhtVZ0iVRWohG5YMTjoBJm2ww1GdkSIm0SIdY1PPLO4sq5OATCHA/bHBk6DSF5U77d3hMRX3D+ofKB/smqxAyx7tLT/GucP7PHeYN0MDgbgEtY5ffR/TCnRxb6VIl MIME-Version: 1.0 X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR02MB4488.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fb7cc447-b7bb-43b9-ef39-08db0ac5da37 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Feb 2023 17:48:28.8522 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: qn53YpWb60AGsHa6NAk7gkbe2te41rpvGfAHTEuws6h4uglGTDvZJtb3Yo2eiWHtyD+O7+brq++dXUfShMFr5g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR02MB7936 X-Proofpoint-GUID: qDqEsuMsGq48t1PnPidx8s2Flp-VXRJa X-Proofpoint-ORIG-GUID: qDqEsuMsGq48t1PnPidx8s2Flp-VXRJa X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.170.22 definitions=2023-02-09_13,2023-02-09_03,2023-02-09_01 X-Proofpoint-Spam-Reason: safe X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 92FFD1C000A X-Stat-Signature: u9q1yn3n4ia4gc8tnxmbjcyfgexd3m84 X-Rspam-User: X-HE-Tag: 1675964922-353238 X-HE-Meta: U2FsdGVkX18ZxKQ+iNrjkuhQxxcQh+We/crMbQTGxguDXVsZ456NQDwO02Ebce7YiLbw9PGx9BBLau2ghqnH9602n3gjMPnHDDJKFDpl4wzKf8GxnuD84LfJxPiPYETmOXJd1P6UV8cK/mqxh8o5yfr103KjAHlJ48aKLDAtap/FKP6f9E0JPYQsoFMbFZUuFTbgi5qSQ5kRlJK1DtOVODRojzgw0BzYi3ztEyGLhuLBJ/ycFqTFInY4Pl9RE7le1/6LNGBIxaCPCZnvEYlUbcJeYB2uxwNZ5ycC89yIAa25OEcVA1I3NwiNqFhOjVW7qhunoaIIy4O/pkZe87T6Ukv4KUO2B3JmCJ7SpSYuHm4VKtyvvsBTxFS9ZjLpqffqaZJl+8crMbcNmn3Mg/qKLLjeZkyoJnvnXGJFqVDYs5efRlF3gO42DJm+bKl9vavQNJHmzxqdL1FvYXa3IbYEzdep2sYH0gewCR9zQYsRV91vnXsUBZVGt/p7Bc9eUc1lGyJbyP2WbG4ga9puSv7R4lXztwqejq+R5MCP79ghu4IOTBPijksDVwouU99KBGK4QO+i4QPggWnNXqxKCdUj1XPRaZnMofJ+7NbZQzIRELtds/NzVrkg/yOnq7DpFz6G7K8lWZAyo1hVunETUxNwjArVzRxXk5ksTH0frPiJSMUBgi/0Cu2htHxVxHLXR/+hGmbNJPWkCgWa2Ab6lJYG8zBZoWYES53UEfwxx6zoYyPvib0E5m09V/HcLRZciJ4dAzoEBSe3GjS3zw1g8kQN3XZGbH09bT/ov18g5gZFh7WTe73BpjYVsJM2XB/kK08LfjCGv2r6JLk/bHHaI+B+/dlVfT/30J9a7T2XX3k2woCvSJsbRgDq/7J4INId5OaTgtj9NTx5v1eO3AaXUOS3EKACYZMXfAXVt+HSicU2zLMT+Xe8zEKLDe3+6YsdsHccaWm3e/nQbuA6rjONRWy YXCTf4xV ViG1CUI+vIGaWmVkUXAoI015ydZ6CdiRTp/quXezqiUyafcMvQi23wUPLcR9rdO1r9J00o6pdLyWi6gGcyn3GyxEtunPlumoAzIkaKqR/iRpYEmWHxQr3wJo48KT3TOJV6GwzGB7jFub4HTlI/qpC3mLfeVIS8mUQXDdh7gr3WmmYEBv1h8lp/6qhiSkHzHRIG7j/JvREPeVWEiM6q2zP+VOf6OrkxQhWn/pGYLlJpjbpQAxUPN6EW+4gyyRMiI6ZgnbKCrHUo1b/u7Xcn1JBlJwB1BLMnXR+TghGzK9O30OAzbdKFiOZitOIgpx1oVZzKL+2cLuFmlyuG7j7Nq9vJRX+CnzGdimt/sBqmwSvbIEtxNnJ47ifwivdbOxsgsdq1q66hMt6qchLt9HRvq9cV0ByAJQrrpvRtxh4dkrYyXwSjqA9hGSAGOV4MZ1oHBQ/nBoU2+gsKJikTsQeevUYuUz1Y7yMkPFgQhYmc/F+MvFi8b4IjLw2yxiIBGt+vzWNxuVE9d3eBbgNxPj6jS/gPxDpnSpjU8DDN4QiVXNTj5xABgJ2BNspTwsyTx/dtOedtQEhMrVri74bO+egpGSiaVxI6b4gb6lJngbBn54L/ghkgiHCFkfwuaDwrmzN1B/YsVOB4ZkOv/t3OUFae0oseS0wRi7sAFN/B8MD7Trzs2PQdAr3zlGmNUtMmCWrzoyR/oBXZAIPl64oRRP3Oo05X7TNidgJQIy7ASsv6nOJo+wCuuH/CzprkitHeQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: When we upgraded our kernel, we started seeing some page corruption like the following consistently: BUG: Bad page state in process ganesha.nfsd pfn:1304ca page:0000000022261c55 refcount:0 mapcount:-128 mapping:0000000000000000 index:0x0 pfn:0x1304ca flags: 0x17ffffc0000000() raw: 0017ffffc0000000 ffff8a513ffd4c98 ffffeee24b35ec08 0000000000000000 raw: 0000000000000000 0000000000000001 00000000ffffff7f 0000000000000000 page dumped because: nonzero mapcount CPU: 0 PID: 15567 Comm: ganesha.nfsd Kdump: loaded Tainted: P B O 5.10.158-1.nutanix.20221209.el7.x86_64 #1 Hardware name: VMware, Inc. VMware Virtual Platform/440BX Desktop Reference Platform, BIOS 6.00 04/05/2016 Call Trace: dump_stack+0x74/0x96 bad_page.cold+0x63/0x94 check_new_page_bad+0x6d/0x80 rmqueue+0x46e/0x970 get_page_from_freelist+0xcb/0x3f0 ? _cond_resched+0x19/0x40 __alloc_pages_nodemask+0x164/0x300 alloc_pages_current+0x87/0xf0 skb_page_frag_refill+0x84/0x110 ... Sometimes, it would also show up as corruption in the free list pointer and cause crashes. After bisecting the issue, we found the issue started from e320d3012d25: if (put_page_testzero(page)) free_the_page(page, order); else if (!PageHead(page)) while (order-- > 0) free_the_page(page + (1 << order), order); So the problem is the check PageHead is racy because at this point we already dropped our reference to the page. So even if we came in with compound page, the page can already be freed and PageHead can return false and we will end up freeing all the tail pages causing double free. Fixes: e320d3012d25 ("mm/page_alloc.c: fix freeing non-compound pages") Cc: Andrew Morton Cc: Matthew Wilcox (Oracle) Cc: linux-mm@kvack.org Cc: stable@vger.kernel.org Signed-off-by: Chunwei Chen Reviewed-by: Matthew Wilcox (Oracle) Reviewed-by: Vlastimil Babka --- mm/page_alloc.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 0745aedebb37..3bb3484563ed 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -5631,9 +5631,12 @@ EXPORT_SYMBOL(get_zeroed_page); */ void __free_pages(struct page *page, unsigned int order) { + /* get PageHead before we drop reference */ + int head = PageHead(page); + if (put_page_testzero(page)) free_the_page(page, order); - else if (!PageHead(page)) + else if (!head) while (order-- > 0) free_the_page(page + (1 << order), order); }