From patchwork Sat Feb 11 10:13:17 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mike Rapoport X-Patchwork-Id: 13136987 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 583A6C61DA4 for ; Sat, 11 Feb 2023 10:13:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AF73C6B0072; Sat, 11 Feb 2023 05:13:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AA66F6B0073; Sat, 11 Feb 2023 05:13:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 994FB6B0074; Sat, 11 Feb 2023 05:13:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 88DB46B0072 for ; Sat, 11 Feb 2023 05:13:32 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 5A505AB973 for ; Sat, 11 Feb 2023 10:13:32 +0000 (UTC) X-FDA: 80454599064.13.319EABE Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf14.hostedemail.com (Postfix) with ESMTP id C8616100002 for ; Sat, 11 Feb 2023 10:13:30 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=fmOrGje9; spf=pass (imf14.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676110410; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=2Io40V8HxmOsYCTT6cunPXC0M/b2w/Zhf26sdd7r+C8=; b=oX14ajPIraTurmk/nwc2WqB+3d89PGMcrr0UXPKMBFMQm/KjO9AFBG2ae/2zx6hSba/0DX 8n777FKxwGZOr0ojP1+rUxKQc5uphMNWFejvzdmjf4oJeqGcJ2WLs6yDhQJw3A/9qfd4Q/ MRHh/MZ5YO7Z4hpJnDGcMx4f77HolI8= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=fmOrGje9; spf=pass (imf14.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676110410; a=rsa-sha256; cv=none; b=IS67rGa05cS7/j4CpKn2RcGX8uTCQCMGJbhg0gvs7qCqccGmHp1agoUijYFnCB5QDgy4I4 GYGI1nbobs9+r0RBiTNcpeDlUJp0D/ZQTAg49d0fiwJoVtcZc3rvMbNNa549Rop2H5q33C 4BBGXuAIVP0Dl2POpC1qeQEB1KNbxwk= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C922F60AF0; Sat, 11 Feb 2023 10:13:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A169BC433EF; Sat, 11 Feb 2023 10:13:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1676110409; bh=p+IdxaBG7C0I9P6ldP+PpkrL7/XCuQ5WEyqo+TXFHXE=; h=Date:From:To:Cc:Subject:From; b=fmOrGje95DQT3J1lJkLkBlgX0jcrdRhmgbH7yYiT04I3k2DtJvgFCms1WrQLD9DRe DPVwfwXBX29epAl+HYwzjyLPKILn+wsV1MrTlv7kUMleoOZ09CTwVXJaybcaca2Ji1 tk5ZFL8nQ9bu5++4AHmbOxu9yWYZTNp/uOPwSn3xWaN9x44Wv5hI9rGIr+7MFb6wR/ oeNyG6Wh9QS/lcWZT88L6CsCdlb32jGB41s+gk8ZW/fiXKY6XjAt4DjUFLZO7Q8Qf1 Yf2O2a+r8u8v3nlTPRlspAsm9gC+fT+4A4ktwQA8WFqDJDWjmdHgfWGiQZ2jd/ASSm +BVss6ol6Z7JQ== Date: Sat, 11 Feb 2023 12:13:17 +0200 From: Mike Rapoport To: Linus Torvalds Cc: Aaron Thompson , Mike Rapoport , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [GIT PULL] memblock: Revert "mm: Always release pages to the buddy allocator in memblock_free_late()." Message-ID: MIME-Version: 1.0 Content-Disposition: inline X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: C8616100002 X-Rspam-User: X-Stat-Signature: oy5p7yspffydgh3c8xjhzbw8mf1b6xrx X-HE-Tag: 1676110410-282787 X-HE-Meta: U2FsdGVkX196VoSH6/b9mWzHA+l+Fk5goSmm+qYsP20GSJBZ1NhxhO0vt5lcN8bYDgMfpEbl07gaiFmd4egG6dysTJyu3VyUn5oT3nRG8eHlZ7oqKVWO8qT+tb2nWhopLgRITFe6pg4dRT0MIdhotelu3Je22Y6ocj8qsad6lIPYUcI++UNjUfNZTvDL5LIuG11srO4bKmAZnkkV3y2R6ezQu2H6C8LqJPfNoyp6gEh/BQSpoGCLSUIpdLeAwYMzAy1b73ph7WA+PQymJlCuBJmyKpw9WFvuwh9DrjXWpvhuS2rfeV0XTQ0bsxbessmXKxcsa+5pho9KGmwImKkpOmrw/VKaviYnr/zlQyEO7Z3Nw7eTUKG/7I7LLAA6Llb0eXqt2q+zITEjvrM1x9wrDi0ClbJJbex0OLou21G31VLKKcTLdu7HUypmc2jw6bvr2SwwVdepqXmD2KEYrBN8lfAuDw+1NYrOFsAekLbbjDQrxstTKpx0MGmhtNjr21fU1MPQhXMjmT/nm8Y/NgG5vW9puR5XxlNa8s0vwo7TCTxKVLkP91sqSKUJp/PDmw9oVqygXeELogxfFiTFC+2MdkqIUB2zL/gCXOWjLgZkI77SND7FJUHLJcMgnIOLDO0/SD27MhzWqIoEdo636+o1i2rokTyFABA26NehCe4Iqhgf6TK8lR78XgJSyoZYfQXTikUnJ8qFRy8GqdCYeJo7SacesA7oXKlC7bMfn/ue+uwIi1EfNKtOD/C/p+F3gT6kf8ZjtPgLDU5oa3PZnivcewtO7YI0jCpM4lO4EPoY4yvYWt6aW9Hhuqt1G+cXhflkajyLNqASvTeAz6FU1Pfa/jDs67JB3qohPEjRsWCzFVebd2Td9sVnP63eGu3cqeLLTxYXaGT6sN1tKBtKY5geE3LZLTk4zx+d8CVGd8WQA1j3o9EjVYlvYAymF9C+iLtj1xswEKOdqiB7aNVK7eJ Bl90ttng 3VSHTt1A3u6c0+3DANDavNUkbkJFmeBU0jAo3ASXcI1Wsk27YVT0E7wt7SbmnzJUmUVpYyhwPn2f1KgQX0oz9DdmLeovoQwGD7ZVqyZ8nm1DDDKL2riEhgi4SlrrUyDFj61sGquN5De6yharHp1OmXxkIhLlTKroT/qyK/3OLQxu59O6hrg4Pjd875BdTUK6I+vQ+vVIMcPKbhFH4nacsxDL3wpse4cqqtZzTUHZ80YezAET/CwMUefElTtmaoDatmGKqieu5t5Ni87jant48LDQqawJRFqGh/UBPSGbLrJ7Wf6Dr+hgInYL0Z27py/bdRwqGwNut4FU5AIhJYpvcivL6G3XSCGz5mPtFqT3BqLHCKRF8LCwZFmA2a1kPwWiQsNuBqmhaKihlBy0AITFThLywJ6C5NBzy0Svq X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Linus, The following changes since commit 4ec5183ec48656cec489c49f989c508b68b518e3: Linux 6.2-rc7 (2023-02-05 13:13:28 -0800) are available in the Git repository at: https://git.kernel.org/pub/scm/linux/kernel/git/rppt/memblock tags/fixes-2023-02-11 for you to fetch changes up to 647037adcad00f2bab8828d3d41cd0553d41f3bd: Revert "mm: Always release pages to the buddy allocator in memblock_free_late()." (2023-02-07 13:07:37 +0200) ---------------------------------------------------------------- Revert "mm: Always release pages to the buddy allocator in memblock_free_late()." This reverts commit 115d9d77bb0f9152c60b6e8646369fa7f6167593. The pages being freed by memblock_free_late() have already been initialized, but if they are in the deferred init range, __free_one_page() might access nearby uninitialized pages when trying to coalesce buddies, which will cause a crash. A proper fix will be more involved so revert this change for the time being. ---------------------------------------------------------------- Aaron Thompson (1): Revert "mm: Always release pages to the buddy allocator in memblock_free_late()." mm/memblock.c | 8 +------- tools/testing/memblock/internal.h | 4 ---- 2 files changed, 1 insertion(+), 11 deletions(-)