From patchwork Mon Feb 13 16:31:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Muhammad Usama Anjum X-Patchwork-Id: 13138676 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10D31C636D4 for ; Mon, 13 Feb 2023 16:31:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 40BC96B0073; Mon, 13 Feb 2023 11:31:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 394EE6B0074; Mon, 13 Feb 2023 11:31:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 23638280001; Mon, 13 Feb 2023 11:31:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 140FA6B0073 for ; Mon, 13 Feb 2023 11:31:48 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 98A17AB07B for ; Mon, 13 Feb 2023 16:31:47 +0000 (UTC) X-FDA: 80462809854.24.1610067 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by imf17.hostedemail.com (Postfix) with ESMTP id 79B9C4002A for ; Mon, 13 Feb 2023 16:31:44 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b=Uc3zOm2n; spf=pass (imf17.hostedemail.com: domain of usama.anjum@collabora.com designates 46.235.227.172 as permitted sender) smtp.mailfrom=usama.anjum@collabora.com; dmarc=pass (policy=reject) header.from=collabora.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676305904; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=maUh+Knwdfgzx8QLtD/ZJAtuBBfS0rEEBYG7dP5ByWQ=; b=uQ0M9Peq1LZ+y0ybdC+JLs9lG5EptgNp9tJKpRZkmKZ0+F1FvZCmhWgVYMp5CNS0fnRHo2 NKz3pyq7VdFbkMJze04I1lPVhMt1RQw5GsPV97NZoAgSIFwOh6c0SskZ5dyeLVDuKT1zO9 Zv0XB1rEoznAB3S+TT2GLCbRvhEC4hg= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b=Uc3zOm2n; spf=pass (imf17.hostedemail.com: domain of usama.anjum@collabora.com designates 46.235.227.172 as permitted sender) smtp.mailfrom=usama.anjum@collabora.com; dmarc=pass (policy=reject) header.from=collabora.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676305904; a=rsa-sha256; cv=none; b=YmA9GhNO3Ja78wAnb6A33V8DvMuFTJ4m9MhG6qPg8jnYnT0YyRhWS3cY11K268tTVKkm5r 0lJbHiI+ETdiR+5Ht/e45CsD4CMpOm4XSZjIWYTgkNQhuVLF+NqfiLMmomMdUqBeri54GQ HW0J0KC89MgdhGFO2V26DPe8G4mO3sM= Received: from localhost.localdomain (unknown [39.45.179.179]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: usama.anjum) by madras.collabora.co.uk (Postfix) with ESMTPSA id 030E26602146; Mon, 13 Feb 2023 16:31:40 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1676305902; bh=OiTcyrHZ0v3oC/V7QnPlyQu3zF7d7MV1OS0jVwPURZU=; h=From:To:Cc:Subject:Date:From; b=Uc3zOm2nBYWIjJv2z1Is850ACuGzKXcoqliy3ugB5rRc28XwAUkhcyLgGezS62dNw vWsv8rsKCEB+V4zQOzvteoxgT//NwYQ0BSlVzV+dNnOuwp3otEQWzbiqnKHRbCei/l osOICLKHWG29ijdU4Rha4hg7tq/Nsk9r4mTZYSajGQHnlqDVWh55D5mYB0OJxHdvyQ 52yFWnOTgus4Nstl0Iva3Mw9bUSYhyjz6m2SCf2qRMXT8PFb3UdY8LyrOO3cS9SERP xyelRMHwlM9SbA5h+7MCpehfW5a8HWQyrDx/zZFw9cNC9TKcjWFgK/J3+sc6gVMZcn +5VpNA5l3YPxQ== From: Muhammad Usama Anjum To: peterx@redhat.com, david@redhat.com, Andrew Morton Cc: Muhammad Usama Anjum , kernel@collabora.com, Paul Gofman , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 1/2] mm/userfaultfd: Support WP on multiple VMAs Date: Mon, 13 Feb 2023 21:31:23 +0500 Message-Id: <20230213163124.2850816-1-usama.anjum@collabora.com> X-Mailer: git-send-email 2.39.1 MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 79B9C4002A X-Stat-Signature: j4ro4fuiftrho7ze3qwsoh69ouf8kd8i X-HE-Tag: 1676305904-292394 X-HE-Meta: U2FsdGVkX19DkaCv8VXbgBUG6a9oP5l8iFCkOHqhCO/3/epuMJEqOZE6t+7YBKkh8NDCjnvTH074tRT6+LpN58DrhofOKlyMGV6y2W3R3uRtGwJaZ4Y0nUGdTDdNpJHfK3tN/EK3lYaHvGFkz2m4ESGSEVDSSMgcyFKK9v0dw/DkexRJfXplX6sl5X1bvKnXWqag87O444e3LB7yBUXCfnu5atWY9BuURTUVMbJq0Zs4iRZ4opDGZxI6Zq97MvZDHVNHEg7+YtqzLKejE2GfSoNhjb3ojLg0A3EiPtWKjDSNGa2zDQ5zKIH5veyLkksS6ZAsR33kCJB5iQ1tUXJuwc7iy2+DqEeT5eKTIWLart34e9hTBR3sMtUGXv6CZIk0FzbdaJlZt6CvSslPVjlLzpCXDgbBnYtIof5jHtSEWYpE0OhFaPSnPBm/aXEl3LnqJSRgNSDWityu0qAjUlSp1CpIqIs0U3YeogxmEOcauGIm5e3gYfOOzl3EWMmods26bQHfJ55vZgBu/aBmjmjBQ+yseShrlZna3yU2/2S0YYwfJVZjkO5utA8nFyLvmHoSuoUcGL2aChU96Z+5sOsbgFAiDF23WyWJd2E6RKBeXJ35DI1hLW2ZQq9uefVco6BzD2TihwCLwVMKW5RmeN+zzLO5yrWTZnzl+lzyV9mfglPquWyMO6PoHW0N+i57uimkW7HFujIHsrlZrEBZCtmNB2fi7h72pPTRVq5NWp2mf39oDMMmERwkmNh0iAYvSmoKS7jlNn3LtaAuXV/G9k159CxrX75FZhCFWbAAvZxcR75z/rSfg9/f67K9nl9YyPhj/LoEqIoCfvwq6jdj2uRLOsIZjga3Xo/JZa5Y7nTZxdtfNeHn60KyazwKwOsuKVw18Dju/wSzMMiB4ZHtZ4nZWPCwHErNdNNL0riwOcvkMBtL/npWL643MIeFOsTkqIAd46PlzbWXDIPTfdDrrz4 nNq06sS7 T8GjRUDN/Lo3D0ugNrpPn/K8hbatpEAas2cWkubtDpDAA0vF3ymRvPUkHTH4eG2P3fSW7LaQX3eQnB0rWXSenaV630CApniTHb+zC9b0zaVAqgqMTzdXw0MjPp9RFvxwnWrvTVLnd6tflzZ0U42LQ13Ao73guA2ZTwVGCUxBwrALmHybJvTJI/ad3z8Sms/Y/bICJcxrZ/e32YnKu4vN4/zhL/CtVKJIQQK97M7apNoDlNgI21o7g1zvI3I/XZGJ7xETH4gXv5grnmsOLncwXr8PdIEiBpJNDQpcO5TWAWYwhO29PIP7jF0jjqRZhaI6xH30/ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: mwriteprotect_range() errors out if [start, end) doesn't fall in one VMA. We are facing a use case where multiple VMAs are present in one range of interest. For example, the following pseudocode reproduces the error which we are trying to fix: - Allocate memory of size 16 pages with PROT_NONE with mmap - Register userfaultfd - Change protection of the first half (1 to 8 pages) of memory to PROT_READ | PROT_WRITE. This breaks the memory area in two VMAs. - Now UFFDIO_WRITEPROTECT_MODE_WP on the whole memory of 16 pages errors out. This is a simple use case where user may or may not know if the memory area has been divided into multiple VMAs. Reported-by: Paul Gofman Signed-off-by: Muhammad Usama Anjum --- Changes since v1: - Correct the start and ending values passed to uffd_wp_range() --- mm/userfaultfd.c | 38 ++++++++++++++++++++++---------------- 1 file changed, 22 insertions(+), 16 deletions(-) diff --git a/mm/userfaultfd.c b/mm/userfaultfd.c index 65ad172add27..bccea08005a8 100644 --- a/mm/userfaultfd.c +++ b/mm/userfaultfd.c @@ -738,9 +738,12 @@ int mwriteprotect_range(struct mm_struct *dst_mm, unsigned long start, unsigned long len, bool enable_wp, atomic_t *mmap_changing) { + unsigned long end = start + len; + unsigned long _start, _end; struct vm_area_struct *dst_vma; unsigned long page_mask; int err; + VMA_ITERATOR(vmi, dst_mm, start); /* * Sanitize the command parameters: @@ -762,26 +765,29 @@ int mwriteprotect_range(struct mm_struct *dst_mm, unsigned long start, if (mmap_changing && atomic_read(mmap_changing)) goto out_unlock; - err = -ENOENT; - dst_vma = find_dst_vma(dst_mm, start, len); + for_each_vma_range(vmi, dst_vma, end) { + err = -ENOENT; - if (!dst_vma) - goto out_unlock; - if (!userfaultfd_wp(dst_vma)) - goto out_unlock; - if (!vma_can_userfault(dst_vma, dst_vma->vm_flags)) - goto out_unlock; + if (!dst_vma->vm_userfaultfd_ctx.ctx) + break; + if (!userfaultfd_wp(dst_vma)) + break; + if (!vma_can_userfault(dst_vma, dst_vma->vm_flags)) + break; - if (is_vm_hugetlb_page(dst_vma)) { - err = -EINVAL; - page_mask = vma_kernel_pagesize(dst_vma) - 1; - if ((start & page_mask) || (len & page_mask)) - goto out_unlock; - } + if (is_vm_hugetlb_page(dst_vma)) { + err = -EINVAL; + page_mask = vma_kernel_pagesize(dst_vma) - 1; + if ((start & page_mask) || (len & page_mask)) + break; + } - uffd_wp_range(dst_mm, dst_vma, start, len, enable_wp); + _start = (dst_vma->vm_start > start) ? dst_vma->vm_start : start; + _end = (dst_vma->vm_end < end) ? dst_vma->vm_end : end; - err = 0; + uffd_wp_range(dst_mm, dst_vma, _start, _end - _start, enable_wp); + err = 0; + } out_unlock: mmap_read_unlock(dst_mm); return err; From patchwork Mon Feb 13 16:31:24 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Muhammad Usama Anjum X-Patchwork-Id: 13138677 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E210BC64EC7 for ; Mon, 13 Feb 2023 16:31:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0FF2B6B0074; Mon, 13 Feb 2023 11:31:49 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 061B16B0075; Mon, 13 Feb 2023 11:31:49 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E442D6B0078; Mon, 13 Feb 2023 11:31:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id D6B236B0074 for ; Mon, 13 Feb 2023 11:31:48 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 5B9821408DE for ; Mon, 13 Feb 2023 16:31:48 +0000 (UTC) X-FDA: 80462809896.08.73DE5B8 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by imf10.hostedemail.com (Postfix) with ESMTP id 7E78AC002C for ; Mon, 13 Feb 2023 16:31:46 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b=GYFOIYPm; spf=pass (imf10.hostedemail.com: domain of usama.anjum@collabora.com designates 46.235.227.172 as permitted sender) smtp.mailfrom=usama.anjum@collabora.com; dmarc=pass (policy=reject) header.from=collabora.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676305906; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YwurXtxIMyWbgqUgY9xnVPmcbG6KUXlJ5n173RtX8eM=; b=QvLg5W2n+XerlrSdWf1jG8tW6/Q0scSWf991QHQJrZLIIhWnh028LUsCQvQeqU+p1d1DEK KSb1DOIyfzcxoQgPFYxcLhIhk6cHDX1sqM+5ziSJZXweegbn5KNPKu3TEKHw7isXEHtJoZ EYl2z2rahjFA0BTRJm67MKcuLGu3v9w= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b=GYFOIYPm; spf=pass (imf10.hostedemail.com: domain of usama.anjum@collabora.com designates 46.235.227.172 as permitted sender) smtp.mailfrom=usama.anjum@collabora.com; dmarc=pass (policy=reject) header.from=collabora.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676305906; a=rsa-sha256; cv=none; b=endaYUx6Pp3wR3vGVjCXBHlhSGFViqf2JGPL1OK4sMf4KlyNzxYSHGvu53ZCtFM5xfE9hE C7uSDagLxZRerwprUtNkSzgAHzCA6lz85UE5QlpYt/jQAu+bEI0TetkloWPpZiC4cbI5x1 B5Ak9RHO8h+eg6RWSVuOv9e0aXL3Go8= Received: from localhost.localdomain (unknown [39.45.179.179]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: usama.anjum) by madras.collabora.co.uk (Postfix) with ESMTPSA id 9B3276602149; Mon, 13 Feb 2023 16:31:43 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1676305905; bh=zXPbJqCldaAU06/Pl15/EuPbGqrq9pdX/EO4Oo9v1hc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=GYFOIYPmxJOzBKz1ZV9fqB+BQADrG3NwplIW6YVJvdlwMcF900XODPcitVTeMK+xu WyzYsudjY2R0JcqaW0yu+kJjo4I2Y2Ktr4vOe8ItJX8fERsZLx/mlS3FcyoUROreqD 04wSEDRf2I1KSq3MSFXmP+Org06bmw3vWmE5n2DN+gDw2DqPPGQqO4u2fuJeq/3Q1k O2JW0/FF5FGvPOdeNKqofOVsixD9WHdLZVNG1p3O0cBuR3bxaaObpw9J6V+hqzZJ5j 34sbj4V4u2gcbXyYW9zdXNQww0NppB1iq++eIsgoAULWBJLUftJYUY/XduedhHk0Na bRDn8Iu/ee5ow== From: Muhammad Usama Anjum To: peterx@redhat.com, david@redhat.com, Andrew Morton Cc: Muhammad Usama Anjum , kernel@collabora.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 2/2] mm/userfaultfd: add VM_WARN_ONCE() Date: Mon, 13 Feb 2023 21:31:24 +0500 Message-Id: <20230213163124.2850816-2-usama.anjum@collabora.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230213163124.2850816-1-usama.anjum@collabora.com> References: <20230213163124.2850816-1-usama.anjum@collabora.com> MIME-Version: 1.0 X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 7E78AC002C X-Stat-Signature: 3s49f6r4whwkdcsatoiei3j5cdhcwq5c X-Rspam-User: X-HE-Tag: 1676305906-340013 X-HE-Meta: U2FsdGVkX1/wsa0eqYpoO4n8DW7eMFxZ5ptDK2faKJ4dlp8v82y9GAy83vRKrHfx+Qzj/yI5nmf6TByXGwAiF9mauxyaMD90IjESyzTnMieYXio1fCgMmBpy3X2ZYsIcTmKWJPE+9JbR5uMGUKRbM9e4CMWyZJ73nsgftCCNvJ2zITLktuiiUuX164byECexojuRn5XruSsAfD/5o0erpyNBXBlfAoYlKCQkXSR5EiBKlChhZlPLDhvanXapes3fwfoIwcuLKYX4b0sv03nukIj14d+0wOUpt3oQxqYa7PZZWl6WohAWBx2Od7QtUOonGzO19s/Lq0KmeFeC30kcXzARY0shlbgQYUKrDyQOV3ZIe2hSND/FLiiU6suzvJr8RzXUlKzpv4eGKQaXKI3ugEnKiusrepc6dax9j0zk5v8qK4803WJYe2H7/b0Br+/HKLORCptR2pZdnTTQIdalc7mQF7oPHG6vNeLy7mexoyLbtr8iFXdKH/qhFa04a07JSFM/RYs2v3QQZopGWbkgu7Sz54h7+ChgXGulOaRu343XtuZSvvv5DnnJJ1lv5ISiPEdq0DBtCedbQaiH7PMVMXIJa/hyEcIFs/ULj4N6wJviyh7XB3WDfOBneqzkTd/YGywBv3s9U6k6XkmEpEbQFU5o9GLYXT9MP4wE4xQkaod+QAwmOKJGJy4ShZCd2PQm+j0fVNwqIhpTVX6NtCEIK3J94e6XWs+k7R9fnAjgQjvehYq7f7r9qUY2MJ5Lfu6jBEWbeyzfo6r259Zb93L4g+PI9L5rDz9j/7nV7K1a65ndsPaTaTHjAXvtmteTf8JbNxAjJLW0KMhvAV+7UyccE6sAUBkOieDv7/ZbQot8qzWKkwA6j54ZmZ0uqUsq2z9kbiFiQ4CaAMC/VXHMRfWPBYj3L/uDB0jN4GsdhasyZFgEEke+G2tYPVnJJ2RUlqLezvq5HbykWk7fXm0IYcD E7rT/Z4X idtZBsHgKDNa9sp+ytqUAr6NdeSaIx0zQ5k9GMRvwUHaBQRG1ARmAY1RD9oDFyYFv4Qi+z3gaFoyX3fKUPeycKvAnOrYNOlBbe0+08DK5bIrblwePhFF7vcYHgDH6koODy2bLJlkaxEk9ReZdaxn+cxwIesVLjSnZF0MLS6fVEho4ub4B1uvW/Cq4FUMB3JMouOfVNuhO1yT1rtCCEPn8oKbBGQhZPhaWnCQ+wKhmWiYxebfKy4XJqMcn4MGdYZqki3VVQau7/8X2zg8VNJrAqFPgjg3kQUDV840hZKH4V6+m4Lyh6XStt9TuIw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Add VM_WARN_ONCE() to uffd_wp_range() to detect range (start, len) abuse. Signed-off-by: Muhammad Usama Anjum --- mm/userfaultfd.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/mm/userfaultfd.c b/mm/userfaultfd.c index bccea08005a8..14ec88301511 100644 --- a/mm/userfaultfd.c +++ b/mm/userfaultfd.c @@ -716,6 +716,8 @@ void uffd_wp_range(struct mm_struct *dst_mm, struct vm_area_struct *dst_vma, unsigned int mm_cp_flags; struct mmu_gather tlb; + VM_WARN_ONCE(start < dst_vma->vm_start || start + len > dst_vma->vm_end, + "The address range exceeds VMA boundary.\n"); if (enable_wp) mm_cp_flags = MM_CP_UFFD_WP; else