From patchwork Sun Feb 19 08:39:02 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brett Creeley X-Patchwork-Id: 13145817 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 055CEC64ED6 for ; Sun, 19 Feb 2023 08:40:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229724AbjBSIje (ORCPT ); Sun, 19 Feb 2023 03:39:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58654 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229715AbjBSIjd (ORCPT ); Sun, 19 Feb 2023 03:39:33 -0500 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2086.outbound.protection.outlook.com [40.107.93.86]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C584FE061; Sun, 19 Feb 2023 00:39:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=e97puKAc8+/bXOBYXPjggNU2QBvnjeZHDafSe1VRMjzwVEXMoe2pcLY0qlEa5xIV3XPGr1XEfW97Y8W0rgtRD2AsVbEicC4iBbCyZ/0zAK1bVu8RDpLDSUlx1FZg3kmu6H4suLa9dcaqk5HMbMY2qSnv3lxJn5ONS7FhvRrBOcLkf0wp42nbkW4LnfVZunq/LqNNHIatP43QiGW+YRwnxuRxnWEaov5qTkPOgdV86dBgwyqM3+bFLMZ9qzHDwfA4oIggrVyFiWc5Ze6cWbvev4Ww3CgD0IE2VyhDKxSqTJulNloS85cWsyx8+vYwarpmIfJvSob65OwtBLCUGDkIxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qtT1WE3KlJpxveho+U9/cEr8uZ0TuKuR0LbRAnDyd4w=; b=CSzVRInRy3EaB7w6nXqj6m13jpZfgo7xX1wXS3C2qh/rpy8lRHdNDEbLBr72kL44GtJju1XZObgUZjfUNw3miMRfCn2WI9T51G6vDzdNHEsXhoj2cDSaqMJ61/GBf1vDRpADpMv66yLXg+jNjLOMoejRU1pmjZhXBK4eG5hD5VUbEy/KWAiPFCZqYAcHDh/ccn3LUIa/6HDgFqxyBTjM6LdAzzGK7RvijEVSLHb3f7a0szrjtl5ZcW0lRCt7X2Np07Fe5wplxpJqoEgXHATNMy+OHlJ2AcBiHWBDwCiWcAMpis9ERlLXkEixrAf0CtiUrdoXjonKvxACARt4sNsP8Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qtT1WE3KlJpxveho+U9/cEr8uZ0TuKuR0LbRAnDyd4w=; b=LiXeWEHLwQ9gNXJRRBW6f44w46LieOcuKo/inmfZdpSegIj+ysE5NR1wAFt4/r4iaC/vKG5uj74v0sc0qzmxf6apPicCfOB/IC6hPuQZi4qRZtNXv1WzuehD8+yozJjIHBBAO1+zBD8oodZyLkkahU/Fqdoa6EkIgRBAi+oAFtM= Received: from MW4PR04CA0382.namprd04.prod.outlook.com (2603:10b6:303:81::27) by DM4PR12MB5771.namprd12.prod.outlook.com (2603:10b6:8:62::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.18; Sun, 19 Feb 2023 08:39:29 +0000 Received: from CO1NAM11FT096.eop-nam11.prod.protection.outlook.com (2603:10b6:303:81:cafe::6e) by MW4PR04CA0382.outlook.office365.com (2603:10b6:303:81::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.18 via Frontend Transport; Sun, 19 Feb 2023 08:39:29 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1NAM11FT096.mail.protection.outlook.com (10.13.175.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6111.18 via Frontend Transport; Sun, 19 Feb 2023 08:39:29 +0000 Received: from driver-dev1.pensando.io (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Sun, 19 Feb 2023 02:39:27 -0600 From: Brett Creeley To: , , , , , , , CC: , , Subject: [PATCH v3 1/7] vfio/pds: Initial support for pds_vfio VFIO driver Date: Sun, 19 Feb 2023 00:39:02 -0800 Message-ID: <20230219083908.40013-2-brett.creeley@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230219083908.40013-1-brett.creeley@amd.com> References: <20230219083908.40013-1-brett.creeley@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT096:EE_|DM4PR12MB5771:EE_ X-MS-Office365-Filtering-Correlation-Id: 15be097b-5a86-4a3f-7987-08db1254d10a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +86Cb2jUkxZ6Hp/wHyc8HhcfriUVaS9W7nGV0rBnT21bKgQuqo6zI4m4fbe/W7roSOeG0/QXzkSUaGVcohVNnEnn7Km8AR7Bk2JkoiKFjEbBoyun9wJBtIlK5ZcofqZqQNM5qLX8Tspsq5lOr3Mut7NqrBriDkcpdtncpNwZRL515qOwtVpDFPw8kQnq5USZird1ltDC1NwAd/8pf81hvYpCLGu1zKhcHN/9fS8o0CeC+KGZtyLgyv4JOZPD0PuFaX2xzUbSNNABFaSqQN7717yw06DAtLqhzfc8AfMcUCOdn0Vmfi8xJy+BfxIFAFPgLsi9QHPcL8QeDGKesV+g79Duod+bpNc7j7Gn2bMV8eiPbUmCEMiM9B4pJucLXtaJHQyvSpURvSolQI75UPWJYgIYRC4/Gjl7H5u/gr0tyZEis6ubDTBSQmepafLikSE06onhq/OZJlEauLEwMSOaiPtipGehSJfLhr72F47U6fn59yothhCufhx2rE8+i4VZ3tLPpBVmAVr76JOON5ymMPCOYaDxIel2e+UtXsGLRfGM1PQzxM7rssbkxvEcyTUa3W1eYaYsk7OIYx8ajZ2az91dv6+15E042YLCFMsTEz/jhMEP47WJO9j9daxnHnYKNttC95RUqWQVrdOZ1e2YV5OKhHAAZ3hYp+b2dMbEirucRD1TvVZ4Z+25g/b+cWckSoYvWVHZw97kGdvzi0d+I7mUTYFY+XorNeRWAF3UzL0= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230025)(4636009)(136003)(39860400002)(396003)(346002)(376002)(451199018)(46966006)(40470700004)(36840700001)(40460700003)(82310400005)(81166007)(356005)(16526019)(2616005)(6666004)(336012)(186003)(26005)(36860700001)(426003)(40480700001)(83380400001)(47076005)(41300700001)(8936002)(70586007)(70206006)(2906002)(44832011)(5660300002)(4326008)(8676002)(36756003)(316002)(82740400003)(86362001)(1076003)(110136005)(54906003)(478600001)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Feb 2023 08:39:29.4703 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 15be097b-5a86-4a3f-7987-08db1254d10a X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT096.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5771 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This is the initial framework for the new pds_vfio device driver. This does the very basics of registering any PDS PCI device and configuring as a VFIO PCI device. With this change, the VF device can be bound to the pds_vfio driver on the host and presented to the VM as the VF's device type. Signed-off-by: Brett Creeley Signed-off-by: Shannon Nelson --- drivers/vfio/pci/pds/Makefile | 8 +++ drivers/vfio/pci/pds/pci_drv.c | 94 +++++++++++++++++++++++++++++++++ drivers/vfio/pci/pds/vfio_dev.c | 74 ++++++++++++++++++++++++++ drivers/vfio/pci/pds/vfio_dev.h | 23 ++++++++ 4 files changed, 199 insertions(+) create mode 100644 drivers/vfio/pci/pds/Makefile create mode 100644 drivers/vfio/pci/pds/pci_drv.c create mode 100644 drivers/vfio/pci/pds/vfio_dev.c create mode 100644 drivers/vfio/pci/pds/vfio_dev.h diff --git a/drivers/vfio/pci/pds/Makefile b/drivers/vfio/pci/pds/Makefile new file mode 100644 index 000000000000..e1a55ae0f079 --- /dev/null +++ b/drivers/vfio/pci/pds/Makefile @@ -0,0 +1,8 @@ +# SPDX-License-Identifier: GPL-2.0 +# Copyright (c) 2023 Advanced Micro Devices, Inc. + +obj-$(CONFIG_PDS_VFIO_PCI) += pds_vfio.o + +pds_vfio-y := \ + pci_drv.o \ + vfio_dev.o diff --git a/drivers/vfio/pci/pds/pci_drv.c b/drivers/vfio/pci/pds/pci_drv.c new file mode 100644 index 000000000000..96e155598a50 --- /dev/null +++ b/drivers/vfio/pci/pds/pci_drv.c @@ -0,0 +1,94 @@ +// SPDX-License-Identifier: GPL-2.0 +/* Copyright(c) 2023 Advanced Micro Devices, Inc. */ + +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt + +#include +#include +#include +#include + +#include + +#include "vfio_dev.h" + +#define PDS_VFIO_DRV_NAME "pds_vfio" +#define PDS_VFIO_DRV_DESCRIPTION "AMD/Pensando VFIO Device Driver" +#define PCI_VENDOR_ID_PENSANDO 0x1dd8 + +static int +pds_vfio_pci_probe(struct pci_dev *pdev, + const struct pci_device_id *id) +{ + struct pds_vfio_pci_device *pds_vfio; + int err; + + pds_vfio = vfio_alloc_device(pds_vfio_pci_device, vfio_coredev.vdev, + &pdev->dev, pds_vfio_ops_info()); + if (IS_ERR(pds_vfio)) + return PTR_ERR(pds_vfio); + + dev_set_drvdata(&pdev->dev, &pds_vfio->vfio_coredev); + pds_vfio->pdev = pdev; + + err = vfio_pci_core_register_device(&pds_vfio->vfio_coredev); + if (err) + goto out_put_vdev; + + return 0; + +out_put_vdev: + vfio_put_device(&pds_vfio->vfio_coredev.vdev); + return err; +} + +static void +pds_vfio_pci_remove(struct pci_dev *pdev) +{ + struct pds_vfio_pci_device *pds_vfio = pds_vfio_pci_drvdata(pdev); + + vfio_pci_core_unregister_device(&pds_vfio->vfio_coredev); + vfio_put_device(&pds_vfio->vfio_coredev.vdev); +} + +static const struct pci_device_id +pds_vfio_pci_table[] = { + { PCI_DRIVER_OVERRIDE_DEVICE_VFIO(PCI_VENDOR_ID_PENSANDO, PCI_ANY_ID) }, + { 0, } +}; +MODULE_DEVICE_TABLE(pci, pds_vfio_pci_table); + +static struct pci_driver +pds_vfio_pci_driver = { + .name = PDS_VFIO_DRV_NAME, + .id_table = pds_vfio_pci_table, + .probe = pds_vfio_pci_probe, + .remove = pds_vfio_pci_remove, + .driver_managed_dma = true, +}; + +static void __exit +pds_vfio_pci_cleanup(void) +{ + pci_unregister_driver(&pds_vfio_pci_driver); +} +module_exit(pds_vfio_pci_cleanup); + +static int __init +pds_vfio_pci_init(void) +{ + int err; + + err = pci_register_driver(&pds_vfio_pci_driver); + if (err) { + pr_err("pci driver register failed: %pe\n", ERR_PTR(err)); + return err; + } + + return 0; +} +module_init(pds_vfio_pci_init); + +MODULE_DESCRIPTION(PDS_VFIO_DRV_DESCRIPTION); +MODULE_AUTHOR("Advanced Micro Devices, Inc."); +MODULE_LICENSE("GPL"); diff --git a/drivers/vfio/pci/pds/vfio_dev.c b/drivers/vfio/pci/pds/vfio_dev.c new file mode 100644 index 000000000000..f1221f14e4f6 --- /dev/null +++ b/drivers/vfio/pci/pds/vfio_dev.c @@ -0,0 +1,74 @@ +// SPDX-License-Identifier: GPL-2.0 +/* Copyright(c) 2023 Advanced Micro Devices, Inc. */ + +#include +#include + +#include "vfio_dev.h" + +struct pds_vfio_pci_device * +pds_vfio_pci_drvdata(struct pci_dev *pdev) +{ + struct vfio_pci_core_device *core_device = dev_get_drvdata(&pdev->dev); + + return container_of(core_device, struct pds_vfio_pci_device, + vfio_coredev); +} + +static int +pds_vfio_init_device(struct vfio_device *vdev) +{ + struct pds_vfio_pci_device *pds_vfio = + container_of(vdev, struct pds_vfio_pci_device, + vfio_coredev.vdev); + struct pci_dev *pdev = to_pci_dev(vdev->dev); + int err; + + err = vfio_pci_core_init_dev(vdev); + if (err) + return err; + + pds_vfio->vf_id = pci_iov_vf_id(pdev); + pds_vfio->pci_id = PCI_DEVID(pdev->bus->number, pdev->devfn); + + return 0; +} + +static int +pds_vfio_open_device(struct vfio_device *vdev) +{ + struct pds_vfio_pci_device *pds_vfio = + container_of(vdev, struct pds_vfio_pci_device, + vfio_coredev.vdev); + int err; + + err = vfio_pci_core_enable(&pds_vfio->vfio_coredev); + if (err) + return err; + + vfio_pci_core_finish_enable(&pds_vfio->vfio_coredev); + + return 0; +} + +static const struct vfio_device_ops +pds_vfio_ops = { + .name = "pds-vfio", + .init = pds_vfio_init_device, + .release = vfio_pci_core_release_dev, + .open_device = pds_vfio_open_device, + .close_device = vfio_pci_core_close_device, + .ioctl = vfio_pci_core_ioctl, + .device_feature = vfio_pci_core_ioctl_feature, + .read = vfio_pci_core_read, + .write = vfio_pci_core_write, + .mmap = vfio_pci_core_mmap, + .request = vfio_pci_core_request, + .match = vfio_pci_core_match, +}; + +const struct vfio_device_ops * +pds_vfio_ops_info(void) +{ + return &pds_vfio_ops; +} diff --git a/drivers/vfio/pci/pds/vfio_dev.h b/drivers/vfio/pci/pds/vfio_dev.h new file mode 100644 index 000000000000..4d497695c4e9 --- /dev/null +++ b/drivers/vfio/pci/pds/vfio_dev.h @@ -0,0 +1,23 @@ +// SPDX-License-Identifier: GPL-2.0 +/* Copyright(c) 2023 Advanced Micro Devices, Inc. */ + +#ifndef _VFIO_DEV_H_ +#define _VFIO_DEV_H_ + +#include +#include + +struct pds_vfio_pci_device { + struct vfio_pci_core_device vfio_coredev; + struct pci_dev *pdev; + + int vf_id; + int pci_id; +}; + +const struct vfio_device_ops * +pds_vfio_ops_info(void); +struct pds_vfio_pci_device * +pds_vfio_pci_drvdata(struct pci_dev *pdev); + +#endif /* _VFIO_DEV_H_ */ From patchwork Sun Feb 19 08:39:03 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brett Creeley X-Patchwork-Id: 13145815 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3F45C6379F for ; Sun, 19 Feb 2023 08:40:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229734AbjBSIjp (ORCPT ); Sun, 19 Feb 2023 03:39:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58818 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229736AbjBSIjl (ORCPT ); Sun, 19 Feb 2023 03:39:41 -0500 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2062.outbound.protection.outlook.com [40.107.93.62]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9A67910A92; Sun, 19 Feb 2023 00:39:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nYFJBbQQldI2Ap9S+koslgCW/cBHDVkgADLVc2BCvCtlI0xb6rJB0Dx20d8R6o8FHR+pf57BwDGB41L/wibTxFLHueSag0D7wpnAywIt2leaTodmVf3gNlVSk+aY1iPx6ZLWvz+UBlcLhAAiB0LXZAMgiF1xWXs3Yc1xlF8tBhP4hDxbhWMN7/33cyGCwjgGhVUkFYGRNi197B7z8015WOA9wE0203Bh2kzFG4HvXtJsfQLh8UKzl5lETHKCqjHjDoltU5kJ153hgWfqLiKrhtteNmWfktFpEZ67KYkDBhQiAEw4R1pBqlKPhL2pwBMMvn5tTVkSyXoBRlWSzLkXIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yVEi2gyRLTTrIVYo/HaEtSd6fFFSk2jl0LISrkNj4gM=; b=VwEA7RHJCbfdCbmc86FO0McHKdc68KhWwf8wjTXlWjR5ckMxjIMaZhTE/CMMB72/SN8HLHTZWVgFZtfVquD7PWpaAEcgZjwIr/I14yjw+/Jf0nBcphLx90LAdXmAc9+bMOna+ItvWotP0DyCNc3zpwUAkmhS51IZiIgeyMoFs7FXKTeOT1x+mlhIOFBxlS/jUT98wNisNC7EWCovqDVaGjA/9CH6H9xRIvHImH3dQPY+gbdGiCxJk+RnDP42jFfi3ZnFRJkgKXbEZHWogjrAgr4SODYLuVXrXq9cv/7w0xkIv+VfP6yinyZoLcJDWgNCccwuZB89YRageV2LTvprbQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yVEi2gyRLTTrIVYo/HaEtSd6fFFSk2jl0LISrkNj4gM=; b=rRGkCPsEmuJ9cnSJGVfIgtlVP9Dg/tV8SOOF966+31D25qXDV3P0ySJDzNkAb1u5JwLZU8NCGN99ilRkxqkFdRLtIIOpyCCH1w/FPGxdistli59Ibdueah81NdDL8WiRq4urHuu7R965cEHbmd80iqHB02OW7PhGwVYlOSnNNrI= Received: from MWH0EPF000554DF.namprd21.prod.outlook.com (2603:10b6:30f:fff2:0:1:0:4) by PH0PR12MB7485.namprd12.prod.outlook.com (2603:10b6:510:1e9::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.18; Sun, 19 Feb 2023 08:39:33 +0000 Received: from CO1NAM11FT089.eop-nam11.prod.protection.outlook.com (2a01:111:f400:7eab::204) by MWH0EPF000554DF.outlook.office365.com (2603:1036:d20::b) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.5 via Frontend Transport; Sun, 19 Feb 2023 08:39:33 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1NAM11FT089.mail.protection.outlook.com (10.13.175.179) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6111.18 via Frontend Transport; Sun, 19 Feb 2023 08:39:32 +0000 Received: from driver-dev1.pensando.io (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Sun, 19 Feb 2023 02:39:30 -0600 From: Brett Creeley To: , , , , , , , CC: , , Subject: [PATCH v3 2/7] vfio/pds: Add support to register as PDS client Date: Sun, 19 Feb 2023 00:39:03 -0800 Message-ID: <20230219083908.40013-3-brett.creeley@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230219083908.40013-1-brett.creeley@amd.com> References: <20230219083908.40013-1-brett.creeley@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT089:EE_|PH0PR12MB7485:EE_ X-MS-Office365-Filtering-Correlation-Id: 74be17a7-f577-48d2-e5a8-08db1254d2ce X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: soQAdDH59VVSBlSeYTy/VPmDhokt6jzT6i2sTU3A0h1UmfO1rrA1Uol+kJR9g+Jhfpz4pcziXQBXgyp5BqCtJKseVVzeqaJevUqKckUPeCLDWYKdi0r0KLVimpGrbtLrmFleH9iwgEH5+BtBrD4qC39ihQVVjwGc3gfLcM0nqtizUImmud6GcsaFzQQFRJ2MIDOZgJCz9c5+eBWJpdeETdE/RQkjVV/E3xVfKdTAzAU5MLccxgOOnOkhiGDFfAMPGtt7/48Dm1u5OaiFwuSk+t/U+5tG1KPvEyXlKaxp9b36aALc2wrmlT5ZTjZwFkWgQgYtpk5MN1hDV0K7UuzfMgOVk8bshgibgFnD1yRbOH6aRCIhYISqYxepxwc/Z5eTreyOH4PjZ3VfStxH3m12jezykjYNcFyoor1hIbCjx4wVbGpLWFyMMZdGRDcKSjGRNzLkaxxWzod9KXIY8CrhMxkonHrPXjUewn6KMcPZBSxph1QTP3xjqKeA3FXG/coS2Y3TAq2hnH8KWJ2ECQopgKExEMUaEV56GpDzMu5zExSg07PdGExSQhCf20x5xT3LcmUSjxASUxJGEdg1Cxbkip6tg/V09CoDHVayjBVCpDb/dcONeCavvCTiufFzQALhxvGnAQrJNvOCFy5bF8G5sH0qxwVEBxbH8M8zTb25hGgwDk/X24oOKPM6Jt0GkHJ7k1hsxi1AHNlTEJ74S5CUvj889B6+0u7QT6h8JK8KXzI= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230025)(4636009)(376002)(136003)(346002)(396003)(39860400002)(451199018)(36840700001)(40470700004)(46966006)(26005)(6666004)(1076003)(186003)(16526019)(54906003)(110136005)(478600001)(82310400005)(30864003)(8936002)(44832011)(40460700003)(36756003)(356005)(2906002)(82740400003)(81166007)(83380400001)(316002)(40480700001)(5660300002)(41300700001)(70586007)(70206006)(8676002)(4326008)(47076005)(86362001)(426003)(336012)(2616005)(36860700001)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Feb 2023 08:39:32.4665 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 74be17a7-f577-48d2-e5a8-08db1254d2ce X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT089.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB7485 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The pds_core driver will create auxiliary devices for each PCI device supported by pds_vfio. In order to communicate with the device, the pds_vfio driver needs to register as an auxiliary driver for the previously mentioned auxiliary device. Once the auxiliary device is probed, the pds_vfio driver can send admin queue commands and receive events from the device by way of pds_core. Use the following commands to enable a VF and tell pds_core to create its corresponding auxiliary device: echo 1 > /sys/bus/pci/drivers/pds_core/$PF_BDF/sriov_numvfs devlink dev param set pci/$PF_BDF name enable_migration value true cmode runtime This functionality is needed to support live migration commands, which are added later in the series. Signed-off-by: Brett Creeley Signed-off-by: Shannon Nelson --- drivers/vfio/pci/pds/Makefile | 2 + drivers/vfio/pci/pds/aux_drv.c | 148 ++++++++++++++++++++++++++++++++ drivers/vfio/pci/pds/aux_drv.h | 27 ++++++ drivers/vfio/pci/pds/cmds.c | 30 +++++++ drivers/vfio/pci/pds/cmds.h | 14 +++ drivers/vfio/pci/pds/pci_drv.c | 17 ++++ drivers/vfio/pci/pds/pci_drv.h | 14 +++ drivers/vfio/pci/pds/vfio_dev.c | 6 ++ drivers/vfio/pci/pds/vfio_dev.h | 1 + include/linux/pds/pds_lm.h | 12 +++ 10 files changed, 271 insertions(+) create mode 100644 drivers/vfio/pci/pds/aux_drv.c create mode 100644 drivers/vfio/pci/pds/aux_drv.h create mode 100644 drivers/vfio/pci/pds/cmds.c create mode 100644 drivers/vfio/pci/pds/cmds.h create mode 100644 drivers/vfio/pci/pds/pci_drv.h create mode 100644 include/linux/pds/pds_lm.h diff --git a/drivers/vfio/pci/pds/Makefile b/drivers/vfio/pci/pds/Makefile index e1a55ae0f079..92cc392fd487 100644 --- a/drivers/vfio/pci/pds/Makefile +++ b/drivers/vfio/pci/pds/Makefile @@ -4,5 +4,7 @@ obj-$(CONFIG_PDS_VFIO_PCI) += pds_vfio.o pds_vfio-y := \ + aux_drv.o \ + cmds.o \ pci_drv.o \ vfio_dev.o diff --git a/drivers/vfio/pci/pds/aux_drv.c b/drivers/vfio/pci/pds/aux_drv.c new file mode 100644 index 000000000000..eda262e7d895 --- /dev/null +++ b/drivers/vfio/pci/pds/aux_drv.c @@ -0,0 +1,148 @@ +// SPDX-License-Identifier: GPL-2.0 +/* Copyright(c) 2023 Advanced Micro Devices, Inc. */ + +#include +#include +#include + +#include +#include +#include +#include + +#include "aux_drv.h" +#include "vfio_dev.h" +#include "pci_drv.h" +#include "cmds.h" + +static const +struct auxiliary_device_id pds_vfio_aux_id_table[] = { + { .name = PDS_LM_DEV_NAME, }, + {}, +}; + +static void +pds_vfio_aux_notify_handler(struct pds_auxiliary_dev *padev, + union pds_core_notifyq_comp *event) +{ + struct device *dev = &padev->aux_dev.dev; + u16 ecode = le16_to_cpu(event->ecode); + + dev_dbg(dev, "%s: event code %d\n", __func__, ecode); +} + +static int +pds_vfio_aux_probe(struct auxiliary_device *aux_dev, + const struct auxiliary_device_id *id) + +{ + struct pds_auxiliary_dev *padev = + container_of(aux_dev, struct pds_auxiliary_dev, aux_dev); + struct pds_vfio_pci_device *pds_vfio; + struct device *dev = &aux_dev->dev; + struct pds_vfio_aux *vfio_aux; + struct pci_dev *pdev; + struct pci_bus *bus; + int busnr; + u16 devfn; + int err; + + /* Find our VF PCI device */ + busnr = PCI_BUS_NUM(padev->id); + devfn = padev->id & 0xff; + bus = pci_find_bus(0, busnr); + pdev = pci_get_slot(bus, devfn); + + if (!pds_vfio_is_vfio_pci_driver(pdev)) { + dev_dbg(&aux_dev->dev, "unbind %s from %s driver and bind to %s driver for live migration support\n", + pci_name(pdev), dev_driver_string(&pdev->dev), PDS_VFIO_DRV_NAME); + return -EPROBE_DEFER; + } + + pds_vfio = pci_get_drvdata(pdev); + if (!pds_vfio) { + dev_dbg(&pdev->dev, "PCI device not probed yet, defer until PCI device is probed by %s driver\n", + PDS_VFIO_DRV_NAME); + return -EPROBE_DEFER; + } + + vfio_aux = kzalloc(sizeof(*vfio_aux), GFP_KERNEL); + if (!vfio_aux) + return -ENOMEM; + + vfio_aux->padev = padev; + vfio_aux->pds_vfio = pds_vfio; + auxiliary_set_drvdata(aux_dev, vfio_aux); + + dev_dbg(dev, "%s: id %#04x busnr %#x devfn %#x bus %p pds_vfio %p\n", + __func__, padev->id, busnr, devfn, bus, vfio_aux->pds_vfio); + + vfio_aux->pds_vfio->vfio_aux = vfio_aux; + + vfio_aux->padrv.event_handler = pds_vfio_aux_notify_handler; + err = pds_vfio_register_client_cmd(vfio_aux->pds_vfio); + if (err) { + dev_err(dev, "failed to register as client: %pe\n", + ERR_PTR(err)); + goto err_out; + } + + return 0; + +err_out: + auxiliary_set_drvdata(aux_dev, NULL); + kfree(vfio_aux); + + return err; +} + +static void +pds_vfio_aux_remove(struct auxiliary_device *aux_dev) +{ + struct pds_vfio_aux *vfio_aux = auxiliary_get_drvdata(aux_dev); + struct pds_vfio_pci_device *pds_vfio = vfio_aux->pds_vfio; + + if (pds_vfio) { + pds_vfio_unregister_client_cmd(pds_vfio); + vfio_aux->pds_vfio->vfio_aux = NULL; + pci_dev_put(pds_vfio->pdev); + } + + kfree(vfio_aux); + auxiliary_set_drvdata(aux_dev, NULL); +} + +static struct auxiliary_driver +pds_vfio_aux_driver = { + .name = PDS_DEV_TYPE_LM_STR, + .probe = pds_vfio_aux_probe, + .remove = pds_vfio_aux_remove, + .id_table = pds_vfio_aux_id_table, +}; + +struct auxiliary_driver * +pds_vfio_aux_driver_info(void) +{ + return &pds_vfio_aux_driver; +} + +static int +pds_vfio_aux_match_id(struct device *dev, const void *data) +{ + dev_dbg(dev, "%s: %s\n", __func__, (char *)data); + return !strcmp(dev_name(dev), data); +} + +struct pds_vfio_aux * +pds_vfio_aux_get_drvdata(int vf_pci_id) +{ + struct auxiliary_device *aux_dev; + char name[32]; + + snprintf(name, sizeof(name), "%s.%d", PDS_LM_DEV_NAME, vf_pci_id); + aux_dev = auxiliary_find_device(NULL, name, pds_vfio_aux_match_id); + if (!aux_dev) + return NULL; + + return auxiliary_get_drvdata(aux_dev); +} diff --git a/drivers/vfio/pci/pds/aux_drv.h b/drivers/vfio/pci/pds/aux_drv.h new file mode 100644 index 000000000000..be5948575a0c --- /dev/null +++ b/drivers/vfio/pci/pds/aux_drv.h @@ -0,0 +1,27 @@ +// SPDX-License-Identifier: GPL-2.0 +/* Copyright(c) 2023 Advanced Micro Devices, Inc. */ + +#ifndef _AUX_DRV_H_ +#define _AUX_DRV_H_ + +#include + +#include +#include +#include +#include + +struct pds_vfio_pci_device; + +struct pds_vfio_aux { + struct pds_auxiliary_dev *padev; + struct pds_auxiliary_drv padrv; + struct pds_vfio_pci_device *pds_vfio; +}; + +struct auxiliary_driver * +pds_vfio_aux_driver_info(void); +struct pds_vfio_aux * +pds_vfio_aux_get_drvdata(int vf_pci_id); + +#endif /* _AUX_DRV_H_ */ diff --git a/drivers/vfio/pci/pds/cmds.c b/drivers/vfio/pci/pds/cmds.c new file mode 100644 index 000000000000..6ac39703cb54 --- /dev/null +++ b/drivers/vfio/pci/pds/cmds.c @@ -0,0 +1,30 @@ +// SPDX-License-Identifier: GPL-2.0 +/* Copyright(c) 2023 Advanced Micro Devices, Inc. */ + +#include +#include + +#include +#include +#include + +#include "vfio_dev.h" +#include "aux_drv.h" +#include "cmds.h" + +int +pds_vfio_register_client_cmd(struct pds_vfio_pci_device *pds_vfio) +{ + struct pds_vfio_aux *vfio_aux = pds_vfio->vfio_aux; + struct pds_auxiliary_dev *padev = vfio_aux->padev; + + return padev->ops->register_client(padev, &vfio_aux->padrv); +} + +void +pds_vfio_unregister_client_cmd(struct pds_vfio_pci_device *pds_vfio) +{ + struct pds_auxiliary_dev *padev = pds_vfio->vfio_aux->padev; + + padev->ops->unregister_client(padev); +} diff --git a/drivers/vfio/pci/pds/cmds.h b/drivers/vfio/pci/pds/cmds.h new file mode 100644 index 000000000000..eb39a3ad5089 --- /dev/null +++ b/drivers/vfio/pci/pds/cmds.h @@ -0,0 +1,14 @@ +// SPDX-License-Identifier: GPL-2.0 +/* Copyright(c) 2023 Advanced Micro Devices, Inc. */ + +#ifndef _CMDS_H_ +#define _CMDS_H_ + +struct pds_vfio_pci_device; + +int +pds_vfio_register_client_cmd(struct pds_vfio_pci_device *pds_vfio); +void +pds_vfio_unregister_client_cmd(struct pds_vfio_pci_device *pds_vfio); + +#endif /* _CMDS_H_ */ diff --git a/drivers/vfio/pci/pds/pci_drv.c b/drivers/vfio/pci/pds/pci_drv.c index 96e155598a50..3861a80c4706 100644 --- a/drivers/vfio/pci/pds/pci_drv.c +++ b/drivers/vfio/pci/pds/pci_drv.c @@ -11,6 +11,8 @@ #include #include "vfio_dev.h" +#include "aux_drv.h" +#include "pci_drv.h" #define PDS_VFIO_DRV_NAME "pds_vfio" #define PDS_VFIO_DRV_DESCRIPTION "AMD/Pensando VFIO Device Driver" @@ -67,9 +69,17 @@ pds_vfio_pci_driver = { .driver_managed_dma = true, }; +bool +pds_vfio_is_vfio_pci_driver(struct pci_dev *pdev) +{ + return (to_pci_driver(pdev->dev.driver) == &pds_vfio_pci_driver); +} + static void __exit pds_vfio_pci_cleanup(void) { + auxiliary_driver_unregister(pds_vfio_aux_driver_info()); + pci_unregister_driver(&pds_vfio_pci_driver); } module_exit(pds_vfio_pci_cleanup); @@ -85,6 +95,13 @@ pds_vfio_pci_init(void) return err; } + err = auxiliary_driver_register(pds_vfio_aux_driver_info()); + if (err) { + pr_err("aux driver register failed: %pe\n", ERR_PTR(err)); + pci_unregister_driver(&pds_vfio_pci_driver); + return err; + } + return 0; } module_init(pds_vfio_pci_init); diff --git a/drivers/vfio/pci/pds/pci_drv.h b/drivers/vfio/pci/pds/pci_drv.h new file mode 100644 index 000000000000..3394715bfe7b --- /dev/null +++ b/drivers/vfio/pci/pds/pci_drv.h @@ -0,0 +1,14 @@ +// SPDX-License-Identifier: GPL-2.0 +/* Copyright(c) 2023 Advanced Micro Devices, Inc. */ + +#ifndef _PCI_DRV_H +#define _PCI_DRV_H + +#include + +#define PDS_VFIO_DRV_NAME "pds_vfio" + +bool +pds_vfio_is_vfio_pci_driver(struct pci_dev *pdev); + +#endif /* _PCI_DRV_H */ diff --git a/drivers/vfio/pci/pds/vfio_dev.c b/drivers/vfio/pci/pds/vfio_dev.c index f1221f14e4f6..e882276f9788 100644 --- a/drivers/vfio/pci/pds/vfio_dev.c +++ b/drivers/vfio/pci/pds/vfio_dev.c @@ -5,6 +5,7 @@ #include #include "vfio_dev.h" +#include "aux_drv.h" struct pds_vfio_pci_device * pds_vfio_pci_drvdata(struct pci_dev *pdev) @@ -31,6 +32,11 @@ pds_vfio_init_device(struct vfio_device *vdev) pds_vfio->vf_id = pci_iov_vf_id(pdev); pds_vfio->pci_id = PCI_DEVID(pdev->bus->number, pdev->devfn); + dev_dbg(&pdev->dev, "%s: PF %#04x VF %#04x (%d) vf_id %d domain %d pds_vfio %p\n", + __func__, pci_dev_id(pdev->physfn), + pds_vfio->pci_id, pds_vfio->pci_id, pds_vfio->vf_id, + pci_domain_nr(pdev->bus), pds_vfio); + return 0; } diff --git a/drivers/vfio/pci/pds/vfio_dev.h b/drivers/vfio/pci/pds/vfio_dev.h index 4d497695c4e9..48083002d1ad 100644 --- a/drivers/vfio/pci/pds/vfio_dev.h +++ b/drivers/vfio/pci/pds/vfio_dev.h @@ -10,6 +10,7 @@ struct pds_vfio_pci_device { struct vfio_pci_core_device vfio_coredev; struct pci_dev *pdev; + struct pds_vfio_aux *vfio_aux; int vf_id; int pci_id; diff --git a/include/linux/pds/pds_lm.h b/include/linux/pds/pds_lm.h new file mode 100644 index 000000000000..fdaf2bf71d35 --- /dev/null +++ b/include/linux/pds/pds_lm.h @@ -0,0 +1,12 @@ +// SPDX-License-Identifier: GPL-2.0 +/* Copyright(c) 2022 Pensando Systems, Inc */ + +#ifndef _PDS_LM_H_ +#define _PDS_LM_H_ + +#include "pds_common.h" + +#define PDS_DEV_TYPE_LM_STR "LM" +#define PDS_LM_DEV_NAME PDS_CORE_DRV_NAME "." PDS_DEV_TYPE_LM_STR + +#endif /* _PDS_LM_H_ */ From patchwork Sun Feb 19 08:39:04 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brett Creeley X-Patchwork-Id: 13145816 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4286C05027 for ; Sun, 19 Feb 2023 08:40:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229743AbjBSIk0 (ORCPT ); Sun, 19 Feb 2023 03:40:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59014 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229735AbjBSIkY (ORCPT ); Sun, 19 Feb 2023 03:40:24 -0500 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2065.outbound.protection.outlook.com [40.107.92.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AE52110AAB; Sun, 19 Feb 2023 00:40:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LkcxjYrAG4KzSuspBatYEnQYjf2QSEfmy0WNvcRyYjrIRIGDPZAZdT+0adDIEM5c253g8kD7DgNSB4WTW7cVuN0aJosetK03zPRrD4R+rTwn/QnaHc06xajS+XzDKvnnREzuYC9d1bJPuPg1zpdU52UUFQqXhSm0W14hhlX3oY5+Ef1HW454ogjnUBjfmZ3Jz1AjtYkNLjXtdjVF1zChR0fNGnkZcP2fq7elCpxBWDstkQhQmUkmyzAin+TXTKNwGNKc5fIg6uB1rY+xvKDPjPuFdbCw7wBu0fywcAFa5lUfBis+UQ84vdMwMFyEAR6zPZnDsVnPo+xkA73o7LUHHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UfI9368Lc58NyvnWxe0HTKI5c5JalGFh2866TmwQC/Q=; b=j8xEdXmhSWkMkbZ10uY76YfznS4AkfyE9sU74DIKmDFNPRpEPMu7XX2er7t4Ex0nsZLHABjPX6Kai+Pz0ypfVS9+L7EQG0ew19Bl8BR5huqbKmrf4sR1x2oQMTJ3lrBXqx9VxSD0prXhFJD4bgXH9KulaVRsKvywd3nzjqNz5p+VDndIpuX5pZlDvylfSgPwnXB9KEQDyH8BHv1NfugJyt9dQedY2wbcjYxKAuKjihB6LDRDnwhcWGLcjvY337hJj0qXy422rh/l7crCPCDXWgpjgqS0yKf4CrZt3fhs8cpBNP9dsTfJ5yyha0f6CW+OnBiYptATWen/BRbz55a4Fg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UfI9368Lc58NyvnWxe0HTKI5c5JalGFh2866TmwQC/Q=; b=m9UYdAHXcROyU9jsf8jnKqXzBc7QNaC89FZs+SRph+j9UjHyVnp8OKX35p79BQnZBnpfMp9P/ta35JhGb77eRUGlnoswdy6kz/mMWX0ZzbklnuNOeAdaBOGgbXP+VaggaVuLgpza8YJCFQcF4nmhU6GDJQlSY+3jZrRllFUGVfI= Received: from MW4PR03CA0125.namprd03.prod.outlook.com (2603:10b6:303:8c::10) by DS0PR12MB6413.namprd12.prod.outlook.com (2603:10b6:8:ce::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.18; Sun, 19 Feb 2023 08:40:02 +0000 Received: from CO1NAM11FT114.eop-nam11.prod.protection.outlook.com (2603:10b6:303:8c:cafe::ec) by MW4PR03CA0125.outlook.office365.com (2603:10b6:303:8c::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.18 via Frontend Transport; Sun, 19 Feb 2023 08:40:01 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1NAM11FT114.mail.protection.outlook.com (10.13.174.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6111.18 via Frontend Transport; Sun, 19 Feb 2023 08:40:01 +0000 Received: from driver-dev1.pensando.io (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Sun, 19 Feb 2023 02:39:32 -0600 From: Brett Creeley To: , , , , , , , CC: , , Subject: [PATCH v3 3/7] vfio/pds: Add VFIO live migration support Date: Sun, 19 Feb 2023 00:39:04 -0800 Message-ID: <20230219083908.40013-4-brett.creeley@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230219083908.40013-1-brett.creeley@amd.com> References: <20230219083908.40013-1-brett.creeley@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT114:EE_|DS0PR12MB6413:EE_ X-MS-Office365-Filtering-Correlation-Id: 17affc57-dc14-49d8-84e2-08db1254e437 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: uxjW/nxvL4kVuhmuF9F4U61n6gOP7wFpa3qrB9lbP1yy9yz7+axpFEuosERSCVmO5m1MZ0CJOxd2UYwOOm/GCnlkr14ITY4oPTECRSl+fOn4Gvj4hoGnivUGUl54j+7JpU6KzrAO7tfUQ4U5nvRoyMLVbqTcxX6xTE6Y4vZdtMQCrE87QNF5a6E3M4jIKZDm9QITgyQE9Xot2Nm788R2B18W07k4sPP0arKGFd90S7E9zwDQ0pOSvFziCtXVwOLk4Mlxc7ZOjbb+BpJ5DB3Y5hL4dlwk/Uy07r0l04Q7RAJcjh1HS0FcndEq+2Yxtbzqa7yFSTWEx02gNQ4k4Ro9Ow4Zfl2BgQJxkdW2qgTcKzkBdRnHDCVCKb96rb/0QmLZav8xfrloSNPNRkjDhDUGox4zWnWeFBEh7EdlhrcUlOcv+solmR8W/E9k9YjVdqTtdo0h7SukqAktGQZ9iuewoqV9mqCldH7JIU3OOR/4RG9RXWrEMVREZU6opc+aVv/+3TBO08TtqlDTyBg7qsLHIZDnGytTo+qZpQ2auvDRQTZvzF9SaPmuLCdNTLk+NCwYbes+KgrQweSO4C1qap0KgBISWJmC70Ofoay1tbyt2NmIavd17SVvxcbKF/Xw4dtkslvJGpsrIJYwxayfNJ7LULsGzJaP1EpWAz8fO6FutC5XqMYVCz+YyNPkImgUJaUiqCJ99iOhzu7tNYq51IrGMAiIGYZg6gj3/fYFM9iKYBM= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230025)(4636009)(39860400002)(396003)(346002)(376002)(136003)(451199018)(36840700001)(40470700004)(46966006)(4326008)(8676002)(70586007)(70206006)(316002)(40480700001)(81166007)(83380400001)(41300700001)(5660300002)(36860700001)(47076005)(2616005)(336012)(426003)(86362001)(478600001)(54906003)(6666004)(26005)(186003)(16526019)(1076003)(110136005)(2906002)(356005)(36756003)(82740400003)(82310400005)(40460700003)(8936002)(44832011)(30864003)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Feb 2023 08:40:01.6891 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 17affc57-dc14-49d8-84e2-08db1254e437 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT114.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB6413 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Add live migration support via the VFIO subsystem. The migration implementation aligns with the definition from uapi/vfio.h and uses the auxiliary bus connection between pds_core/pds_vfio to communicate with the device. The ability to suspend, resume, and transfer VF device state data is included along with the required admin queue command structures and implementations. PDS_LM_CMD_SUSPEND and PDS_LM_CMD_SUSPEND_STATUS are added to support the VF device suspend operation. PDS_LM_CMD_RESUME is added to support the VF device resume operation. PDS_LM_CMD_STATUS is added to determine the exact size of the VF device state data. PDS_LM_CMD_SAVE is added to get the VF device state data. PDS_LM_CMD_RESTORE is added to restore the VF device with the previously saved data from PDS_LM_CMD_SAVE. PDS_LM_CMD_HOST_VF_STATUS is added to notify the device when a migration is in/not-in progress from the host's perspective. Signed-off-by: Brett Creeley Signed-off-by: Shannon Nelson --- drivers/vfio/pci/pds/Makefile | 1 + drivers/vfio/pci/pds/aux_drv.c | 1 + drivers/vfio/pci/pds/cmds.c | 312 ++++++++++++++++++++ drivers/vfio/pci/pds/cmds.h | 15 + drivers/vfio/pci/pds/lm.c | 491 ++++++++++++++++++++++++++++++++ drivers/vfio/pci/pds/lm.h | 43 +++ drivers/vfio/pci/pds/pci_drv.c | 15 + drivers/vfio/pci/pds/vfio_dev.c | 122 +++++++- drivers/vfio/pci/pds/vfio_dev.h | 12 + include/linux/pds/pds_lm.h | 206 ++++++++++++++ 10 files changed, 1217 insertions(+), 1 deletion(-) create mode 100644 drivers/vfio/pci/pds/lm.c create mode 100644 drivers/vfio/pci/pds/lm.h diff --git a/drivers/vfio/pci/pds/Makefile b/drivers/vfio/pci/pds/Makefile index 92cc392fd487..7d927c8fa1fd 100644 --- a/drivers/vfio/pci/pds/Makefile +++ b/drivers/vfio/pci/pds/Makefile @@ -6,5 +6,6 @@ obj-$(CONFIG_PDS_VFIO_PCI) += pds_vfio.o pds_vfio-y := \ aux_drv.o \ cmds.o \ + lm.o \ pci_drv.o \ vfio_dev.o diff --git a/drivers/vfio/pci/pds/aux_drv.c b/drivers/vfio/pci/pds/aux_drv.c index eda262e7d895..4b1f06f8aac9 100644 --- a/drivers/vfio/pci/pds/aux_drv.c +++ b/drivers/vfio/pci/pds/aux_drv.c @@ -77,6 +77,7 @@ pds_vfio_aux_probe(struct auxiliary_device *aux_dev, dev_dbg(dev, "%s: id %#04x busnr %#x devfn %#x bus %p pds_vfio %p\n", __func__, padev->id, busnr, devfn, bus, vfio_aux->pds_vfio); + vfio_aux->pds_vfio->coredev = aux_dev->dev.parent; vfio_aux->pds_vfio->vfio_aux = vfio_aux; vfio_aux->padrv.event_handler = pds_vfio_aux_notify_handler; diff --git a/drivers/vfio/pci/pds/cmds.c b/drivers/vfio/pci/pds/cmds.c index 6ac39703cb54..f6ae0885628a 100644 --- a/drivers/vfio/pci/pds/cmds.c +++ b/drivers/vfio/pci/pds/cmds.c @@ -3,9 +3,11 @@ #include #include +#include #include #include +#include #include #include "vfio_dev.h" @@ -28,3 +30,313 @@ pds_vfio_unregister_client_cmd(struct pds_vfio_pci_device *pds_vfio) padev->ops->unregister_client(padev); } + +#define SUSPEND_TIMEOUT_S 5 +#define SUSPEND_CHECK_INTERVAL_MS 1 + +static int +pds_vfio_suspend_wait_device_cmd(struct pds_vfio_pci_device *pds_vfio) +{ + struct pds_lm_suspend_status_cmd cmd = { + .opcode = PDS_LM_CMD_SUSPEND_STATUS, + .vf_id = cpu_to_le16(pds_vfio->vf_id), + }; + struct pci_dev *pdev = pds_vfio->pdev; + struct pds_lm_comp comp = { 0 }; + struct pds_auxiliary_dev *padev; + unsigned long time_limit; + unsigned long time_start; + unsigned long time_done; + int err; + + padev = pds_vfio->vfio_aux->padev; + + time_start = jiffies; + time_limit = time_start + HZ * SUSPEND_TIMEOUT_S; + do { + err = padev->ops->adminq_cmd(padev, + (union pds_core_adminq_cmd *)&cmd, + sizeof(cmd), + (union pds_core_adminq_comp *)&comp, + PDS_AQ_FLAG_FASTPOLL); + if (err != -EAGAIN) + break; + + msleep(SUSPEND_CHECK_INTERVAL_MS); + } while (time_before(jiffies, time_limit)); + + time_done = jiffies; + dev_dbg(&pdev->dev, "%s: vf%u: Suspend comp received in %d msecs\n", + __func__, pds_vfio->vf_id, + jiffies_to_msecs(time_done - time_start)); + + /* Check the results */ + if (time_after_eq(time_done, time_limit)) { + dev_err(&pdev->dev, "%s: vf%u: Suspend comp timeout\n", __func__, + pds_vfio->vf_id); + err = -ETIMEDOUT; + } + + return err; +} + +int +pds_vfio_suspend_device_cmd(struct pds_vfio_pci_device *pds_vfio) +{ + struct pds_lm_suspend_cmd cmd = { + .opcode = PDS_LM_CMD_SUSPEND, + .vf_id = cpu_to_le16(pds_vfio->vf_id), + }; + struct pds_lm_suspend_comp comp = {0}; + struct pci_dev *pdev = pds_vfio->pdev; + struct pds_auxiliary_dev *padev; + int err; + + dev_dbg(&pdev->dev, "vf%u: Suspend device\n", pds_vfio->vf_id); + + padev = pds_vfio->vfio_aux->padev; + err = padev->ops->adminq_cmd(padev, + (union pds_core_adminq_cmd *)&cmd, + sizeof(cmd), + (union pds_core_adminq_comp *)&comp, + PDS_AQ_FLAG_FASTPOLL); + if (err) { + dev_err(&pdev->dev, "vf%u: Suspend failed: %pe\n", + pds_vfio->vf_id, ERR_PTR(err)); + return err; + } + + return pds_vfio_suspend_wait_device_cmd(pds_vfio); +} + +int +pds_vfio_resume_device_cmd(struct pds_vfio_pci_device *pds_vfio) +{ + struct pds_lm_resume_cmd cmd = { + .opcode = PDS_LM_CMD_RESUME, + .vf_id = cpu_to_le16(pds_vfio->vf_id), + }; + struct pds_auxiliary_dev *padev; + struct pds_lm_comp comp = {0}; + + dev_dbg(&pds_vfio->pdev->dev, "vf%u: Resume device\n", pds_vfio->vf_id); + + padev = pds_vfio->vfio_aux->padev; + return padev->ops->adminq_cmd(padev, + (union pds_core_adminq_cmd *)&cmd, + sizeof(cmd), + (union pds_core_adminq_comp *)&comp, + 0); +} + +int +pds_vfio_get_lm_status_cmd(struct pds_vfio_pci_device *pds_vfio, u64 *size) +{ + struct pds_lm_status_cmd cmd = { + .opcode = PDS_LM_CMD_STATUS, + .vf_id = cpu_to_le16(pds_vfio->vf_id), + }; + struct pds_lm_status_comp comp = {0}; + struct pds_auxiliary_dev *padev; + int err = 0; + + dev_dbg(&pds_vfio->pdev->dev, "vf%u: Get migration status\n", + pds_vfio->vf_id); + + padev = pds_vfio->vfio_aux->padev; + err = padev->ops->adminq_cmd(padev, + (union pds_core_adminq_cmd *)&cmd, + sizeof(cmd), + (union pds_core_adminq_comp *)&comp, + 0); + if (err) + return err; + + *size = le64_to_cpu(comp.size); + return 0; +} + +static int +pds_vfio_dma_map_lm_file(struct device *dev, enum dma_data_direction dir, + struct pds_vfio_lm_file *lm_file) +{ + struct pds_lm_sg_elem *sgl, *sge; + struct scatterlist *sg; + int err = 0; + int i; + + if (!lm_file) + return -EINVAL; + + /* dma map file pages */ + err = dma_map_sgtable(dev, &lm_file->sg_table, dir, 0); + if (err) + goto err_dma_map_sg; + + lm_file->num_sge = lm_file->sg_table.nents; + + /* alloc sgl */ + sgl = dma_alloc_coherent(dev, lm_file->num_sge * + sizeof(struct pds_lm_sg_elem), + &lm_file->sgl_addr, GFP_KERNEL); + if (!sgl) { + err = -ENOMEM; + goto err_alloc_sgl; + } + + lm_file->sgl = sgl; + + /* fill sgl */ + sge = sgl; + for_each_sgtable_dma_sg(&lm_file->sg_table, sg, i) { + sge->addr = cpu_to_le64(sg_dma_address(sg)); + sge->len = cpu_to_le32(sg_dma_len(sg)); + dev_dbg(dev, "addr = %llx, len = %u\n", sge->addr, sge->len); + sge++; + } + + return 0; + +err_alloc_sgl: + dma_unmap_sgtable(dev, &lm_file->sg_table, dir, 0); +err_dma_map_sg: + return err; +} + +static void +pds_vfio_dma_unmap_lm_file(struct device *dev, enum dma_data_direction dir, + struct pds_vfio_lm_file *lm_file) +{ + if (!lm_file) + return; + + /* free sgl */ + if (lm_file->sgl) { + dma_free_coherent(dev, lm_file->num_sge * + sizeof(struct pds_lm_sg_elem), + lm_file->sgl, lm_file->sgl_addr); + lm_file->sgl = NULL; + lm_file->sgl_addr = DMA_MAPPING_ERROR; + lm_file->num_sge = 0; + } + + /* dma unmap file pages */ + dma_unmap_sgtable(dev, &lm_file->sg_table, dir, 0); +} + +int +pds_vfio_get_lm_state_cmd(struct pds_vfio_pci_device *pds_vfio) +{ + struct pds_lm_save_cmd cmd = { + .opcode = PDS_LM_CMD_SAVE, + .vf_id = cpu_to_le16(pds_vfio->vf_id), + }; + struct pci_dev *pdev = pds_vfio->pdev; + struct pds_vfio_lm_file *lm_file; + struct pds_auxiliary_dev *padev; + struct pds_lm_comp comp = {0}; + int err; + + dev_dbg(&pdev->dev, "vf%u: Get migration state\n", pds_vfio->vf_id); + + lm_file = pds_vfio->save_file; + + padev = pds_vfio->vfio_aux->padev; + err = pds_vfio_dma_map_lm_file(pds_vfio->coredev, DMA_FROM_DEVICE, lm_file); + if (err) { + dev_err(&pdev->dev, "failed to map save migration file: %pe\n", + ERR_PTR(err)); + return err; + } + + cmd.sgl_addr = cpu_to_le64(lm_file->sgl_addr); + cmd.num_sge = cpu_to_le32(lm_file->num_sge); + + err = padev->ops->adminq_cmd(padev, + (union pds_core_adminq_cmd *)&cmd, + sizeof(cmd), + (union pds_core_adminq_comp *)&comp, + 0); + if (err) + dev_err(&pdev->dev, "failed to get migration state: %pe\n", + ERR_PTR(err)); + + pds_vfio_dma_unmap_lm_file(pds_vfio->coredev, DMA_FROM_DEVICE, lm_file); + + return err; +} + +int +pds_vfio_set_lm_state_cmd(struct pds_vfio_pci_device *pds_vfio) +{ + struct pds_lm_restore_cmd cmd = { + .opcode = PDS_LM_CMD_RESTORE, + .vf_id = cpu_to_le16(pds_vfio->vf_id), + }; + struct pci_dev *pdev = pds_vfio->pdev; + struct pds_vfio_lm_file *lm_file; + struct pds_auxiliary_dev *padev; + struct pds_lm_comp comp = {0}; + int err; + + dev_dbg(&pdev->dev, "vf%u: Set migration state\n", pds_vfio->vf_id); + + lm_file = pds_vfio->restore_file; + + padev = pds_vfio->vfio_aux->padev; + err = pds_vfio_dma_map_lm_file(pds_vfio->coredev, DMA_TO_DEVICE, lm_file); + if (err) { + dev_err(&pdev->dev, "failed to map restore migration file: %pe\n", + ERR_PTR(err)); + return err; + } + + cmd.sgl_addr = cpu_to_le64(lm_file->sgl_addr); + cmd.num_sge = cpu_to_le32(lm_file->num_sge); + + err = padev->ops->adminq_cmd(padev, + (union pds_core_adminq_cmd *)&cmd, + sizeof(cmd), + (union pds_core_adminq_comp *)&comp, + 0); + if (err) + dev_err(&pdev->dev, "failed to set migration state: %pe\n", + ERR_PTR(err)); + + pds_vfio_dma_unmap_lm_file(pds_vfio->coredev, DMA_TO_DEVICE, lm_file); + + return err; +} + +void +pds_vfio_send_host_vf_lm_status_cmd(struct pds_vfio_pci_device *pds_vfio, + enum pds_lm_host_vf_status vf_status) +{ + struct pds_auxiliary_dev *padev = pds_vfio->vfio_aux->padev; + struct pds_lm_host_vf_status_cmd cmd = { + .opcode = PDS_LM_CMD_HOST_VF_STATUS, + .vf_id = cpu_to_le16(pds_vfio->vf_id), + .status = vf_status, + }; + struct pci_dev *pdev = pds_vfio->pdev; + struct pds_lm_comp comp = {0}; + int err; + + dev_dbg(&pdev->dev, "vf%u: Set host VF LM status: %u", + pds_vfio->vf_id, cmd.status); + if (vf_status != PDS_LM_STA_IN_PROGRESS && + vf_status != PDS_LM_STA_NONE) { + dev_warn(&pdev->dev, "Invalid host VF migration status, %d\n", + vf_status); + return; + } + + err = padev->ops->adminq_cmd(padev, + (union pds_core_adminq_cmd *)&cmd, + sizeof(cmd), + (union pds_core_adminq_comp *)&comp, + 0); + if (err) + dev_warn(&pdev->dev, "failed to send host VF migration status: %pe\n", + ERR_PTR(err)); +} diff --git a/drivers/vfio/pci/pds/cmds.h b/drivers/vfio/pci/pds/cmds.h index eb39a3ad5089..f12d41cf5423 100644 --- a/drivers/vfio/pci/pds/cmds.h +++ b/drivers/vfio/pci/pds/cmds.h @@ -4,11 +4,26 @@ #ifndef _CMDS_H_ #define _CMDS_H_ +#include + struct pds_vfio_pci_device; int pds_vfio_register_client_cmd(struct pds_vfio_pci_device *pds_vfio); void pds_vfio_unregister_client_cmd(struct pds_vfio_pci_device *pds_vfio); +int +pds_vfio_suspend_device_cmd(struct pds_vfio_pci_device *pds_vfio); +int +pds_vfio_resume_device_cmd(struct pds_vfio_pci_device *pds_vfio); +int +pds_vfio_get_lm_status_cmd(struct pds_vfio_pci_device *pds_vfio, u64 *size); +int +pds_vfio_get_lm_state_cmd(struct pds_vfio_pci_device *pds_vfio); +int +pds_vfio_set_lm_state_cmd(struct pds_vfio_pci_device *pds_vfio); +void +pds_vfio_send_host_vf_lm_status_cmd(struct pds_vfio_pci_device *pds_vfio, + enum pds_lm_host_vf_status vf_status); #endif /* _CMDS_H_ */ diff --git a/drivers/vfio/pci/pds/lm.c b/drivers/vfio/pci/pds/lm.c new file mode 100644 index 000000000000..cd3c3702bc23 --- /dev/null +++ b/drivers/vfio/pci/pds/lm.c @@ -0,0 +1,491 @@ +// SPDX-License-Identifier: GPL-2.0 +/* Copyright(c) 2023 Advanced Micro Devices, Inc. */ + +#include +#include +#include +#include +#include +#include + +#include "cmds.h" +#include "vfio_dev.h" + +#define PDS_VFIO_LM_FILENAME "pds_vfio_lm" + +const char * +pds_vfio_lm_state(enum vfio_device_mig_state state) +{ + switch (state) { + case VFIO_DEVICE_STATE_ERROR: + return "VFIO_DEVICE_STATE_ERROR"; + case VFIO_DEVICE_STATE_STOP: + return "VFIO_DEVICE_STATE_STOP"; + case VFIO_DEVICE_STATE_RUNNING: + return "VFIO_DEVICE_STATE_RUNNING"; + case VFIO_DEVICE_STATE_STOP_COPY: + return "VFIO_DEVICE_STATE_STOP_COPY"; + case VFIO_DEVICE_STATE_RESUMING: + return "VFIO_DEVICE_STATE_RESUMING"; + case VFIO_DEVICE_STATE_RUNNING_P2P: + return "VFIO_DEVICE_STATE_RUNNING_P2P"; + default: + return "VFIO_DEVICE_STATE_INVALID"; + } + + return "VFIO_DEVICE_STATE_INVALID"; +} + +static struct pds_vfio_lm_file * +pds_vfio_get_lm_file(const char *name, const struct file_operations *fops, + int flags, u64 size) +{ + struct pds_vfio_lm_file *lm_file = NULL; + unsigned long long npages; + unsigned long long i; + struct page **pages; + int err = 0; + + if (!size) + return NULL; + + /* Alloc file structure */ + lm_file = kzalloc(sizeof(*lm_file), GFP_KERNEL); + if (!lm_file) + return NULL; + + /* Create file */ + lm_file->filep = anon_inode_getfile(name, fops, lm_file, flags); + if (!lm_file->filep) + goto err_get_file; + + stream_open(lm_file->filep->f_inode, lm_file->filep); + mutex_init(&lm_file->lock); + + lm_file->size = size; + + /* Allocate memory for file pages */ + npages = DIV_ROUND_UP_ULL(lm_file->size, PAGE_SIZE); + + pages = kcalloc(npages, sizeof(*pages), GFP_KERNEL); + if (!pages) + goto err_alloc_pages; + + for (i = 0; i < npages; i++) { + pages[i] = alloc_page(GFP_KERNEL); + if (!pages[i]) + goto err_alloc_page; + } + + lm_file->pages = pages; + lm_file->npages = npages; + lm_file->alloc_size = npages * PAGE_SIZE; + + /* Create scatterlist of file pages to use for DMA mapping later */ + err = sg_alloc_table_from_pages(&lm_file->sg_table, pages, npages, + 0, size, GFP_KERNEL); + if (err) + goto err_alloc_sg_table; + + return lm_file; + +err_alloc_sg_table: +err_alloc_page: + /* free allocated pages */ + for (i = 0; i < npages && pages[i]; i++) + __free_page(pages[i]); + kfree(pages); +err_alloc_pages: + fput(lm_file->filep); + mutex_destroy(&lm_file->lock); +err_get_file: + kfree(lm_file); + + return NULL; +} + +static void +pds_vfio_put_lm_file(struct pds_vfio_lm_file *lm_file) +{ + unsigned long long i; + + mutex_lock(&lm_file->lock); + + lm_file->size = 0; + lm_file->alloc_size = 0; + + /* Free scatter list of file pages*/ + sg_free_table(&lm_file->sg_table); + + /* Free allocated file pages */ + for (i = 0; i < lm_file->npages && lm_file->pages[i]; i++) + __free_page(lm_file->pages[i]); + kfree(lm_file->pages); + lm_file->pages = NULL; + + /* Delete file */ + fput(lm_file->filep); + lm_file->filep = NULL; + + mutex_unlock(&lm_file->lock); + + mutex_destroy(&lm_file->lock); + + /* Free file structure */ + kfree(lm_file); +} + +void +pds_vfio_put_save_file(struct pds_vfio_pci_device *pds_vfio) +{ + if (!pds_vfio->save_file) + return; + + pds_vfio_put_lm_file(pds_vfio->save_file); + pds_vfio->save_file = NULL; +} + +void +pds_vfio_put_restore_file(struct pds_vfio_pci_device *pds_vfio) +{ + if (!pds_vfio->restore_file) + return; + + pds_vfio_put_lm_file(pds_vfio->restore_file); + pds_vfio->restore_file = NULL; +} + +static struct page * +pds_vfio_get_file_page(struct pds_vfio_lm_file *lm_file, + unsigned long offset) +{ + unsigned long cur_offset = 0; + struct scatterlist *sg; + unsigned int i; + + /* All accesses are sequential */ + if (offset < lm_file->last_offset || !lm_file->last_offset_sg) { + lm_file->last_offset = 0; + lm_file->last_offset_sg = lm_file->sg_table.sgl; + lm_file->sg_last_entry = 0; + } + + cur_offset = lm_file->last_offset; + + for_each_sg(lm_file->last_offset_sg, sg, + lm_file->sg_table.orig_nents - lm_file->sg_last_entry, + i) { + if (offset < sg->length + cur_offset) { + lm_file->last_offset_sg = sg; + lm_file->sg_last_entry += i; + lm_file->last_offset = cur_offset; + return nth_page(sg_page(sg), + (offset - cur_offset) / PAGE_SIZE); + } + cur_offset += sg->length; + } + + return NULL; +} + +static int +pds_vfio_release_file(struct inode *inode, struct file *filp) +{ + struct pds_vfio_lm_file *lm_file = filp->private_data; + + lm_file->size = 0; + + return 0; +} + +static ssize_t +pds_vfio_save_read(struct file *filp, char __user *buf, size_t len, loff_t *pos) +{ + struct pds_vfio_lm_file *lm_file = filp->private_data; + ssize_t done = 0; + + if (pos) + return -ESPIPE; + pos = &filp->f_pos; + + mutex_lock(&lm_file->lock); + if (*pos > lm_file->size) { + done = -EINVAL; + goto out_unlock; + } + + len = min_t(size_t, lm_file->size - *pos, len); + while (len) { + size_t page_offset; + struct page *page; + size_t page_len; + u8 *from_buff; + int err; + + page_offset = (*pos) % PAGE_SIZE; + page = pds_vfio_get_file_page(lm_file, *pos - page_offset); + if (!page) { + if (done == 0) + done = -EINVAL; + goto out_unlock; + } + + page_len = min_t(size_t, len, PAGE_SIZE - page_offset); + from_buff = kmap_local_page(page); + err = copy_to_user(buf, from_buff + page_offset, page_len); + kunmap_local(from_buff); + if (err) { + done = -EFAULT; + goto out_unlock; + } + *pos += page_len; + len -= page_len; + done += page_len; + buf += page_len; + } + +out_unlock: + mutex_unlock(&lm_file->lock); + return done; +} + +static const struct file_operations +pds_vfio_save_fops = { + .owner = THIS_MODULE, + .read = pds_vfio_save_read, + .release = pds_vfio_release_file, + .llseek = no_llseek, +}; + +static int +pds_vfio_get_save_file(struct pds_vfio_pci_device *pds_vfio) +{ + struct pci_dev *pdev = pds_vfio->pdev; + struct pds_vfio_lm_file *lm_file; + int err = 0; + u64 size; + + /* Get live migration state size in this state */ + err = pds_vfio_get_lm_status_cmd(pds_vfio, &size); + if (err) { + dev_err(&pdev->dev, "failed to get save status: %pe\n", + ERR_PTR(err)); + goto err_get_lm_status; + } + + dev_dbg(&pdev->dev, "save status, size = %lld\n", size); + + if (!size) { + err = -EIO; + dev_err(&pdev->dev, "invalid state size\n"); + goto err_get_lm_status; + } + + lm_file = pds_vfio_get_lm_file(PDS_VFIO_LM_FILENAME, + &pds_vfio_save_fops, + O_RDONLY, size); + if (!lm_file) { + err = -ENOENT; + dev_err(&pdev->dev, "failed to create save file\n"); + goto err_get_lm_file; + } + + dev_dbg(&pdev->dev, "size = %lld, alloc_size = %lld, npages = %lld\n", + lm_file->size, lm_file->alloc_size, lm_file->npages); + + pds_vfio->save_file = lm_file; + + return 0; + +err_get_lm_file: +err_get_lm_status: + return err; +} + +static ssize_t +pds_vfio_restore_write(struct file *filp, const char __user *buf, size_t len, loff_t *pos) +{ + struct pds_vfio_lm_file *lm_file = filp->private_data; + loff_t requested_length; + ssize_t done = 0; + + if (pos) + return -ESPIPE; + + pos = &filp->f_pos; + + if (*pos < 0 || + check_add_overflow((loff_t)len, *pos, &requested_length)) + return -EINVAL; + + mutex_lock(&lm_file->lock); + + while (len) { + size_t page_offset; + struct page *page; + size_t page_len; + u8 *to_buff; + int err; + + page_offset = (*pos) % PAGE_SIZE; + page = pds_vfio_get_file_page(lm_file, *pos - page_offset); + if (!page) { + if (done == 0) + done = -EINVAL; + goto out_unlock; + } + + page_len = min_t(size_t, len, PAGE_SIZE - page_offset); + to_buff = kmap_local_page(page); + err = copy_from_user(to_buff + page_offset, buf, page_len); + kunmap_local(to_buff); + if (err) { + done = -EFAULT; + goto out_unlock; + } + *pos += page_len; + len -= page_len; + done += page_len; + buf += page_len; + lm_file->size += page_len; + } +out_unlock: + mutex_unlock(&lm_file->lock); + return done; +} + +static const struct file_operations +pds_vfio_restore_fops = { + .owner = THIS_MODULE, + .write = pds_vfio_restore_write, + .release = pds_vfio_release_file, + .llseek = no_llseek, +}; + +static int +pds_vfio_get_restore_file(struct pds_vfio_pci_device *pds_vfio) +{ + struct pci_dev *pdev = pds_vfio->pdev; + struct pds_vfio_lm_file *lm_file; + int err = 0; + u64 size; + + size = sizeof(union pds_lm_dev_state); + + dev_dbg(&pdev->dev, "restore status, size = %lld\n", size); + + if (!size) { + err = -EIO; + dev_err(&pdev->dev, "invalid state size"); + goto err_get_lm_status; + } + + lm_file = pds_vfio_get_lm_file(PDS_VFIO_LM_FILENAME, + &pds_vfio_restore_fops, + O_WRONLY, size); + if (!lm_file) { + err = -ENOENT; + dev_err(&pdev->dev, "failed to create restore file"); + goto err_get_lm_file; + } + pds_vfio->restore_file = lm_file; + + return 0; + +err_get_lm_file: +err_get_lm_status: + return err; +} + +struct file * +pds_vfio_step_device_state_locked(struct pds_vfio_pci_device *pds_vfio, + enum vfio_device_mig_state next) +{ + enum vfio_device_mig_state cur = pds_vfio->state; + struct device *dev = &pds_vfio->pdev->dev; + int err = 0; + + dev_dbg(dev, "%s => %s\n", + pds_vfio_lm_state(cur), pds_vfio_lm_state(next)); + + if (cur == VFIO_DEVICE_STATE_STOP && next == VFIO_DEVICE_STATE_STOP_COPY) { + /* Device is already stopped + * create save device data file & get device state from firmware + */ + err = pds_vfio_get_save_file(pds_vfio); + if (err) + return ERR_PTR(err); + + /* Get device state */ + err = pds_vfio_get_lm_state_cmd(pds_vfio); + if (err) { + pds_vfio_put_save_file(pds_vfio); + return ERR_PTR(err); + } + + return pds_vfio->save_file->filep; + } + + if (cur == VFIO_DEVICE_STATE_STOP_COPY && next == VFIO_DEVICE_STATE_STOP) { + /* Device is already stopped + * delete the save device state file + */ + pds_vfio_put_save_file(pds_vfio); + pds_vfio_send_host_vf_lm_status_cmd(pds_vfio, + PDS_LM_STA_NONE); + return NULL; + } + + if (cur == VFIO_DEVICE_STATE_STOP && next == VFIO_DEVICE_STATE_RESUMING) { + /* create resume device data file */ + err = pds_vfio_get_restore_file(pds_vfio); + if (err) + return ERR_PTR(err); + + return pds_vfio->restore_file->filep; + } + + if (cur == VFIO_DEVICE_STATE_RESUMING && next == VFIO_DEVICE_STATE_STOP) { + /* Set device state */ + err = pds_vfio_set_lm_state_cmd(pds_vfio); + if (err) + return ERR_PTR(err); + + /* delete resume device data file */ + pds_vfio_put_restore_file(pds_vfio); + return NULL; + } + + if (cur == VFIO_DEVICE_STATE_RUNNING && next == VFIO_DEVICE_STATE_RUNNING_P2P) { + pds_vfio_send_host_vf_lm_status_cmd(pds_vfio, PDS_LM_STA_IN_PROGRESS); + /* Device should be stopped + * no interrupts, dma or change in internal state + */ + err = pds_vfio_suspend_device_cmd(pds_vfio); + if (err) + return ERR_PTR(err); + + return NULL; + } + + if (cur == VFIO_DEVICE_STATE_RUNNING_P2P && next == VFIO_DEVICE_STATE_RUNNING) { + /* Device should be functional + * interrupts, dma, mmio or changes to internal state is allowed + */ + err = pds_vfio_resume_device_cmd(pds_vfio); + if (err) + return ERR_PTR(err); + + pds_vfio_send_host_vf_lm_status_cmd(pds_vfio, + PDS_LM_STA_NONE); + return NULL; + } + + if (cur == VFIO_DEVICE_STATE_STOP && next == VFIO_DEVICE_STATE_RUNNING_P2P) + return NULL; + + if (cur == VFIO_DEVICE_STATE_RUNNING_P2P && next == VFIO_DEVICE_STATE_STOP) + return NULL; + + return ERR_PTR(-EINVAL); +} diff --git a/drivers/vfio/pci/pds/lm.h b/drivers/vfio/pci/pds/lm.h new file mode 100644 index 000000000000..08f49d259c40 --- /dev/null +++ b/drivers/vfio/pci/pds/lm.h @@ -0,0 +1,43 @@ +// SPDX-License-Identifier: GPL-2.0 +/* Copyright(c) 2023 Advanced Micro Devices, Inc. */ + +#ifndef _LM_H_ +#define _LM_H_ + +#include +#include +#include +#include +#include + +#include + +struct pds_vfio_lm_file { + struct file *filep; + struct mutex lock; /* protect live migration data file */ + u64 size; /* Size with valid data */ + u64 alloc_size; /* Total allocated size. Always >= len */ + struct page **pages; /* Backing pages for file */ + unsigned long long npages; + struct sg_table sg_table; /* SG table for backing pages */ + struct pds_lm_sg_elem *sgl; /* DMA mapping */ + dma_addr_t sgl_addr; + u16 num_sge; + struct scatterlist *last_offset_sg; /* Iterator */ + unsigned int sg_last_entry; + unsigned long last_offset; +}; + +struct pds_vfio_pci_device; + +struct file * +pds_vfio_step_device_state_locked(struct pds_vfio_pci_device *pds_vfio, + enum vfio_device_mig_state next); +const char * +pds_vfio_lm_state(enum vfio_device_mig_state state); +void +pds_vfio_put_save_file(struct pds_vfio_pci_device *pds_vfio); +void +pds_vfio_put_restore_file(struct pds_vfio_pci_device *pds_vfio); + +#endif /* _LM_H_ */ diff --git a/drivers/vfio/pci/pds/pci_drv.c b/drivers/vfio/pci/pds/pci_drv.c index 3861a80c4706..c69532420410 100644 --- a/drivers/vfio/pci/pds/pci_drv.c +++ b/drivers/vfio/pci/pds/pci_drv.c @@ -60,12 +60,27 @@ pds_vfio_pci_table[] = { }; MODULE_DEVICE_TABLE(pci, pds_vfio_pci_table); +static void +pds_vfio_pci_aer_reset_done(struct pci_dev *pdev) +{ + struct pds_vfio_pci_device *pds_vfio = pds_vfio_pci_drvdata(pdev); + + pds_vfio_reset(pds_vfio); +} + +static const struct +pci_error_handlers pds_vfio_pci_err_handlers = { + .reset_done = pds_vfio_pci_aer_reset_done, + .error_detected = vfio_pci_core_aer_err_detected, +}; + static struct pci_driver pds_vfio_pci_driver = { .name = PDS_VFIO_DRV_NAME, .id_table = pds_vfio_pci_table, .probe = pds_vfio_pci_probe, .remove = pds_vfio_pci_remove, + .err_handler = &pds_vfio_pci_err_handlers, .driver_managed_dma = true, }; diff --git a/drivers/vfio/pci/pds/vfio_dev.c b/drivers/vfio/pci/pds/vfio_dev.c index e882276f9788..4dfe32b07839 100644 --- a/drivers/vfio/pci/pds/vfio_dev.c +++ b/drivers/vfio/pci/pds/vfio_dev.c @@ -4,6 +4,7 @@ #include #include +#include "lm.h" #include "vfio_dev.h" #include "aux_drv.h" @@ -16,6 +17,106 @@ pds_vfio_pci_drvdata(struct pci_dev *pdev) vfio_coredev); } +static void +pds_vfio_state_mutex_unlock(struct pds_vfio_pci_device *pds_vfio) +{ +again: + spin_lock(&pds_vfio->reset_lock); + if (pds_vfio->deferred_reset) { + pds_vfio->deferred_reset = false; + if (pds_vfio->state == VFIO_DEVICE_STATE_ERROR) { + pds_vfio->state = VFIO_DEVICE_STATE_RUNNING; + pds_vfio_put_restore_file(pds_vfio); + pds_vfio_put_save_file(pds_vfio); + } + spin_unlock(&pds_vfio->reset_lock); + goto again; + } + mutex_unlock(&pds_vfio->state_mutex); + spin_unlock(&pds_vfio->reset_lock); +} + +void +pds_vfio_reset(struct pds_vfio_pci_device *pds_vfio) +{ + spin_lock(&pds_vfio->reset_lock); + pds_vfio->deferred_reset = true; + if (!mutex_trylock(&pds_vfio->state_mutex)) { + spin_unlock(&pds_vfio->reset_lock); + return; + } + spin_unlock(&pds_vfio->reset_lock); + pds_vfio_state_mutex_unlock(pds_vfio); +} + +static struct file * +pds_vfio_set_device_state(struct vfio_device *vdev, + enum vfio_device_mig_state new_state) +{ + struct pds_vfio_pci_device *pds_vfio = + container_of(vdev, struct pds_vfio_pci_device, + vfio_coredev.vdev); + struct file *res = NULL; + + if (!pds_vfio->vfio_aux) + return ERR_PTR(-ENODEV); + + mutex_lock(&pds_vfio->state_mutex); + while (new_state != pds_vfio->state) { + enum vfio_device_mig_state next_state; + + int err = vfio_mig_get_next_state(vdev, pds_vfio->state, + new_state, &next_state); + if (err) { + res = ERR_PTR(err); + break; + } + + res = pds_vfio_step_device_state_locked(pds_vfio, next_state); + if (IS_ERR(res)) + break; + + pds_vfio->state = next_state; + + if (WARN_ON(res && new_state != pds_vfio->state)) { + res = ERR_PTR(-EINVAL); + break; + } + } + pds_vfio_state_mutex_unlock(pds_vfio); + + return res; +} + +static int +pds_vfio_get_device_state(struct vfio_device *vdev, + enum vfio_device_mig_state *current_state) +{ + struct pds_vfio_pci_device *pds_vfio = + container_of(vdev, struct pds_vfio_pci_device, + vfio_coredev.vdev); + + mutex_lock(&pds_vfio->state_mutex); + *current_state = pds_vfio->state; + pds_vfio_state_mutex_unlock(pds_vfio); + return 0; +} + +static int +pds_vfio_get_device_state_size(struct vfio_device *vdev, + unsigned long *stop_copy_length) +{ + *stop_copy_length = PDS_LM_DEVICE_STATE_LENGTH; + return 0; +} + +static const struct vfio_migration_ops +pds_vfio_lm_ops = { + .migration_set_state = pds_vfio_set_device_state, + .migration_get_state = pds_vfio_get_device_state, + .migration_get_data_size = pds_vfio_get_device_state_size +}; + static int pds_vfio_init_device(struct vfio_device *vdev) { @@ -32,6 +133,9 @@ pds_vfio_init_device(struct vfio_device *vdev) pds_vfio->vf_id = pci_iov_vf_id(pdev); pds_vfio->pci_id = PCI_DEVID(pdev->bus->number, pdev->devfn); + vdev->migration_flags = VFIO_MIGRATION_STOP_COPY | VFIO_MIGRATION_P2P; + vdev->mig_ops = &pds_vfio_lm_ops; + dev_dbg(&pdev->dev, "%s: PF %#04x VF %#04x (%d) vf_id %d domain %d pds_vfio %p\n", __func__, pci_dev_id(pdev->physfn), pds_vfio->pci_id, pds_vfio->pci_id, pds_vfio->vf_id, @@ -52,18 +156,34 @@ pds_vfio_open_device(struct vfio_device *vdev) if (err) return err; + mutex_init(&pds_vfio->state_mutex); + dev_dbg(&pds_vfio->pdev->dev, "%s: %s => VFIO_DEVICE_STATE_RUNNING\n", + __func__, pds_vfio_lm_state(pds_vfio->state)); + pds_vfio->state = VFIO_DEVICE_STATE_RUNNING; + vfio_pci_core_finish_enable(&pds_vfio->vfio_coredev); return 0; } +static void +pds_vfio_close_device(struct vfio_device *vdev) +{ + struct pds_vfio_pci_device *pds_vfio = + container_of(vdev, struct pds_vfio_pci_device, + vfio_coredev.vdev); + + mutex_destroy(&pds_vfio->state_mutex); + vfio_pci_core_close_device(vdev); +} + static const struct vfio_device_ops pds_vfio_ops = { .name = "pds-vfio", .init = pds_vfio_init_device, .release = vfio_pci_core_release_dev, .open_device = pds_vfio_open_device, - .close_device = vfio_pci_core_close_device, + .close_device = pds_vfio_close_device, .ioctl = vfio_pci_core_ioctl, .device_feature = vfio_pci_core_ioctl_feature, .read = vfio_pci_core_read, diff --git a/drivers/vfio/pci/pds/vfio_dev.h b/drivers/vfio/pci/pds/vfio_dev.h index 48083002d1ad..61651d2d1c7b 100644 --- a/drivers/vfio/pci/pds/vfio_dev.h +++ b/drivers/vfio/pci/pds/vfio_dev.h @@ -7,10 +7,20 @@ #include #include +#include "lm.h" + struct pds_vfio_pci_device { struct vfio_pci_core_device vfio_coredev; struct pci_dev *pdev; struct pds_vfio_aux *vfio_aux; + struct device *coredev; + + struct pds_vfio_lm_file *save_file; + struct pds_vfio_lm_file *restore_file; + struct mutex state_mutex; /* protect migration state */ + enum vfio_device_mig_state state; + spinlock_t reset_lock; /* protect reset_done flow */ + u8 deferred_reset; int vf_id; int pci_id; @@ -20,5 +30,7 @@ const struct vfio_device_ops * pds_vfio_ops_info(void); struct pds_vfio_pci_device * pds_vfio_pci_drvdata(struct pci_dev *pdev); +void +pds_vfio_reset(struct pds_vfio_pci_device *pds_vfio); #endif /* _VFIO_DEV_H_ */ diff --git a/include/linux/pds/pds_lm.h b/include/linux/pds/pds_lm.h index fdaf2bf71d35..28ebd62f7583 100644 --- a/include/linux/pds/pds_lm.h +++ b/include/linux/pds/pds_lm.h @@ -8,5 +8,211 @@ #define PDS_DEV_TYPE_LM_STR "LM" #define PDS_LM_DEV_NAME PDS_CORE_DRV_NAME "." PDS_DEV_TYPE_LM_STR +#define PDS_LM_DEVICE_STATE_LENGTH 65536 +#define PDS_LM_CHECK_DEVICE_STATE_LENGTH(X) \ + PDS_CORE_SIZE_CHECK(union, PDS_LM_DEVICE_STATE_LENGTH, X) + +/* + * enum pds_lm_cmd_opcode - Live Migration Device commands + */ +enum pds_lm_cmd_opcode { + PDS_LM_CMD_HOST_VF_STATUS = 1, + + /* Device state commands */ + PDS_LM_CMD_STATUS = 16, + PDS_LM_CMD_SUSPEND = 18, + PDS_LM_CMD_SUSPEND_STATUS = 19, + PDS_LM_CMD_RESUME = 20, + PDS_LM_CMD_SAVE = 21, + PDS_LM_CMD_RESTORE = 22, +}; + +/** + * struct pds_lm_cmd - generic command + * @opcode: Opcode + * @rsvd: Word boundary padding + * @vf_id: VF id + * @rsvd2: Structure padding to 60 Bytes + */ +struct pds_lm_cmd { + u8 opcode; + u8 rsvd; + __le16 vf_id; + u8 rsvd2[56]; +}; + +/** + * struct pds_lm_comp - generic command completion + * @status: Status of the command (enum pds_core_status_code) + * @rsvd: Structure padding to 16 Bytes + */ +struct pds_lm_comp { + u8 status; + u8 rsvd[15]; +}; + +/** + * struct pds_lm_status_cmd - STATUS command + * @opcode: Opcode + * @rsvd: Word boundary padding + * @vf_id: VF id + */ +struct pds_lm_status_cmd { + u8 opcode; + u8 rsvd; + __le16 vf_id; +}; + +/** + * struct pds_lm_status_comp - STATUS command completion + * @status: Status of the command (enum pds_core_status_code) + * @rsvd: Word boundary padding + * @comp_index: Index in the desc ring for which this is the completion + * @size: Size of the device state + * @rsvd2: Word boundary padding + * @color: Color bit + */ +struct pds_lm_status_comp { + u8 status; + u8 rsvd; + __le16 comp_index; + union { + __le64 size; + u8 rsvd2[11]; + } __packed; + u8 color; +}; + +/** + * struct pds_lm_suspend_cmd - SUSPEND command + * @opcode: Opcode PDS_LM_CMD_SUSPEND + * @rsvd: Word boundary padding + * @vf_id: VF id + */ +struct pds_lm_suspend_cmd { + u8 opcode; + u8 rsvd; + __le16 vf_id; +}; + +/** + * struct pds_lm_suspend_comp - SUSPEND command completion + * @status: Status of the command (enum pds_core_status_code) + * @rsvd: Word boundary padding + * @comp_index: Index in the desc ring for which this is the completion + * @state_size: Size of the device state computed post suspend. + * @rsvd2: Word boundary padding + * @color: Color bit + */ +struct pds_lm_suspend_comp { + u8 status; + u8 rsvd; + __le16 comp_index; + union { + __le64 state_size; + u8 rsvd2[11]; + } __packed; + u8 color; +}; + +/** + * struct pds_lm_suspend_status_cmd - SUSPEND status command + * @opcode: Opcode PDS_AQ_CMD_LM_SUSPEND_STATUS + * @rsvd: Word boundary padding + * @vf_id: VF id + */ +struct pds_lm_suspend_status_cmd { + u8 opcode; + u8 rsvd; + __le16 vf_id; +}; + +/** + * struct pds_lm_resume_cmd - RESUME command + * @opcode: Opcode PDS_LM_CMD_RESUME + * @rsvd: Word boundary padding + * @vf_id: VF id + */ +struct pds_lm_resume_cmd { + u8 opcode; + u8 rsvd; + __le16 vf_id; +}; + +/** + * struct pds_lm_sg_elem - Transmit scatter-gather (SG) descriptor element + * @addr: DMA address of SG element data buffer + * @len: Length of SG element data buffer, in bytes + * @rsvd: Word boundary padding + */ +struct pds_lm_sg_elem { + __le64 addr; + __le32 len; + __le16 rsvd[2]; +}; + +/** + * struct pds_lm_save_cmd - SAVE command + * @opcode: Opcode PDS_LM_CMD_SAVE + * @rsvd: Word boundary padding + * @vf_id: VF id + * @rsvd2: Word boundary padding + * @sgl_addr: IOVA address of the SGL to dma the device state + * @num_sge: Total number of SG elements + */ +struct pds_lm_save_cmd { + u8 opcode; + u8 rsvd; + __le16 vf_id; + u8 rsvd2[4]; + __le64 sgl_addr; + __le32 num_sge; +} __packed; + +/** + * struct pds_lm_restore_cmd - RESTORE command + * @opcode: Opcode PDS_LM_CMD_RESTORE + * @rsvd: Word boundary padding + * @vf_id: VF id + * @rsvd2: Word boundary padding + * @sgl_addr: IOVA address of the SGL to dma the device state + * @num_sge: Total number of SG elements + */ +struct pds_lm_restore_cmd { + u8 opcode; + u8 rsvd; + __le16 vf_id; + u8 rsvd2[4]; + __le64 sgl_addr; + __le32 num_sge; +} __packed; + +/** + * union pds_lm_dev_state - device state information + * @words: Device state words + */ +union pds_lm_dev_state { + __le32 words[PDS_LM_DEVICE_STATE_LENGTH / sizeof(__le32)]; +}; + +enum pds_lm_host_vf_status { + PDS_LM_STA_NONE = 0, + PDS_LM_STA_IN_PROGRESS, + PDS_LM_STA_MAX, +}; + +/** + * struct pds_lm_host_vf_status_cmd - HOST_VF_STATUS command + * @opcode: Opcode PDS_LM_CMD_HOST_VF_STATUS + * @rsvd: Word boundary padding + * @vf_id: VF id + * @status: Current LM status of host VF driver (enum pds_lm_host_status) + */ +struct pds_lm_host_vf_status_cmd { + u8 opcode; + u8 rsvd; + __le16 vf_id; + u8 status; +}; #endif /* _PDS_LM_H_ */ From patchwork Sun Feb 19 08:39:05 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brett Creeley X-Patchwork-Id: 13145818 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B99FC677F1 for ; Sun, 19 Feb 2023 08:40:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229735AbjBSIk1 (ORCPT ); Sun, 19 Feb 2023 03:40:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59068 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229570AbjBSIk0 (ORCPT ); Sun, 19 Feb 2023 03:40:26 -0500 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam02on2084.outbound.protection.outlook.com [40.107.212.84]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BC6141040F; Sun, 19 Feb 2023 00:40:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oWgvTLw20tUkhdBNDzI18BBLzLvqNIJ8QX0k7zLC5toKFF9JA10NdTuG2ev9Q7yWoLSaZBlEAR4/NG6e/c/W4M8KFN47O2O+9krtkMf0+hfKtwE8nh560hbITREMMPamIpCkh3ZOKMGB5WqpjJmP28wYAuAb05f/bU7tpJaNT3B1ZcOKy5QAP3p1r2hXoIGi83KOufZm41Zhv7Or+E6X02YJQfLdYmbnDogebGRM9Rk71spkqBzGVV/rOR1v9Zb4D+xEVR0BDRXi/sY7aoF2GPK7rWUkixNalonXKbqhFgz+MiLdRQUCTFJftIJhlCvkDGKA62M9DylbIWtQMVjlyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tcC/oL1pvD96+MYJImLaZ9z2nfMC2DtREarjtefVVdA=; b=NJ5o8aDGyX5/HSEMKJxRWLuM5ZKQ6eKcIJguASjLzWK1g8b75I+vB+Edkl0c5NWuPzSQgL8nsaW2h5dVwl8FG3UnBjDTV/Bh8HfiDW2T4Rye/7N+SQABUBuXT4RxuJFo1yxEt/NwPMRZuKcLlGzPzBwN+0N0hvJlfnjo9+SWHmatX5gJI12BhKm+E/SU2zgT4KJlkTK15PV3BpPoCBdHm+/mQdvnmJQMHXDy+qTargzmuV1LWYWlHNj1AzSxVtKkoaA7xx8nRYs17BUawUBPEv8YaQRUAqc1djVg532HR3zbOIFe3vhD/lkPaXgepulpDMyHF2goKS5eRj8DjM+iCw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tcC/oL1pvD96+MYJImLaZ9z2nfMC2DtREarjtefVVdA=; b=yRzPUdWFjF33zv/7mSGpXXVUuw5J2N5tP1hFEvnBQwt5NntOM9q8a8c1nY9dyCn9qF0CiToSa/APD31U1GVBjOcTgP6q5BR8ldfRA//Us40LNqgBfc6Efm3c/BhSnmBkiE1woJ8qFLJBov7zb0dDDcV9Yyq4CiV/KLGIGqT/UGo= Received: from MW4PR03CA0142.namprd03.prod.outlook.com (2603:10b6:303:8c::27) by DM6PR12MB4529.namprd12.prod.outlook.com (2603:10b6:5:2ab::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.26; Sun, 19 Feb 2023 08:40:05 +0000 Received: from CO1NAM11FT114.eop-nam11.prod.protection.outlook.com (2603:10b6:303:8c:cafe::4e) by MW4PR03CA0142.outlook.office365.com (2603:10b6:303:8c::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.18 via Frontend Transport; Sun, 19 Feb 2023 08:40:05 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1NAM11FT114.mail.protection.outlook.com (10.13.174.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6111.18 via Frontend Transport; Sun, 19 Feb 2023 08:40:05 +0000 Received: from driver-dev1.pensando.io (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Sun, 19 Feb 2023 02:39:58 -0600 From: Brett Creeley To: , , , , , , , CC: , , Subject: [PATCH v3 4/7] vfio: Commonize combine_ranges for use in other VFIO drivers Date: Sun, 19 Feb 2023 00:39:05 -0800 Message-ID: <20230219083908.40013-5-brett.creeley@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230219083908.40013-1-brett.creeley@amd.com> References: <20230219083908.40013-1-brett.creeley@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT114:EE_|DM6PR12MB4529:EE_ X-MS-Office365-Filtering-Correlation-Id: e0778eea-f473-4e32-b1f2-08db1254e635 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: a8MkLRzNVdfO42rUCk6uSUEkA490ZaDcg4Qe2yrWY1/+kiCPiaACoYTV7M+8QuImEEEllYK8j+9x2IfH0zaJQ/IZw/PICmbiBqqDgOhtBMoOnG45M3K9c8zVAzIcQz8YxjVV1r78Bo3R6P45c83MH2UYqk35tsdGPDH53M+H2vWwtGTtlA0NiiDuhO4K31vPTgc7mMyg/joX2QG42MC6HGNJb7QMoq5+aUcyP5pzFkKQrDiHIL5J1YCRgQrKp+LUVYi4lorljqSb4zc149cSQiVDDKGny68oA1ikeaI/3W5VYwuoRgHsU8w1fQFp5CwEhnX8bqXcYkZcyPKpx0FbHefyjMiOYlRufayR0tUrD6TqDqMs/fZXGuzasxSW8ZPz8ojJvRFZVZNyEkmreN51u1aAzM/qxuAR8qoqdtexBMFiQDRxFKxSriScaj+oSCGNatOvvgVV+33PvPPQG0z957y/CIsyZzlpmCFc0rgm8C4DeUpnzOg1lAOihrsT+kdtHh1o0MuWx+D3XrRpmZn2LaOlmCbms9OImwiiTYhjVyYd7q0GVj4/JVGJujTU9wUO4NdGrc4CgFPxpf1rgcIhDUfeq4c9GNIncsfNZLbDGDDz85u1DyuLo3bc5bzbdvW1x3Dd64HcldbaSoJQS5V+PTvs0mUqqYQBgI51+sbCv+V2ELJIcWcBRfVBjAA6xjKIYmcoqHPaoQxPJnAyQeRU+dZP7atWd5QCMhFNoO2tWyM= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230025)(4636009)(376002)(346002)(39860400002)(396003)(136003)(451199018)(40470700004)(36840700001)(46966006)(44832011)(2616005)(316002)(47076005)(82740400003)(110136005)(54906003)(86362001)(36860700001)(8936002)(41300700001)(81166007)(4326008)(70586007)(83380400001)(8676002)(70206006)(40480700001)(426003)(336012)(40460700003)(5660300002)(36756003)(82310400005)(356005)(6666004)(1076003)(66899018)(478600001)(186003)(26005)(16526019)(2906002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Feb 2023 08:40:05.0326 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e0778eea-f473-4e32-b1f2-08db1254e635 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT114.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4529 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Currently only Mellanox uses the combine_ranges function. The new pds_vfio driver also needs this function. So, move it to a common location for other vendor drivers to use. Cc: Yishai Hadas Signed-off-by: Brett Creeley Signed-off-by: Shannon Nelson --- drivers/vfio/pci/mlx5/cmd.c | 48 +------------------------------------ drivers/vfio/vfio_main.c | 48 +++++++++++++++++++++++++++++++++++++ include/linux/vfio.h | 3 +++ 3 files changed, 52 insertions(+), 47 deletions(-) diff --git a/drivers/vfio/pci/mlx5/cmd.c b/drivers/vfio/pci/mlx5/cmd.c index 64e68d13cb98..97dcfd800047 100644 --- a/drivers/vfio/pci/mlx5/cmd.c +++ b/drivers/vfio/pci/mlx5/cmd.c @@ -692,52 +692,6 @@ void mlx5fv_cmd_clean_migf_resources(struct mlx5_vf_migration_file *migf) mlx5vf_cmd_dealloc_pd(migf); } -static void combine_ranges(struct rb_root_cached *root, u32 cur_nodes, - u32 req_nodes) -{ - struct interval_tree_node *prev, *curr, *comb_start, *comb_end; - unsigned long min_gap; - unsigned long curr_gap; - - /* Special shortcut when a single range is required */ - if (req_nodes == 1) { - unsigned long last; - - curr = comb_start = interval_tree_iter_first(root, 0, ULONG_MAX); - while (curr) { - last = curr->last; - prev = curr; - curr = interval_tree_iter_next(curr, 0, ULONG_MAX); - if (prev != comb_start) - interval_tree_remove(prev, root); - } - comb_start->last = last; - return; - } - - /* Combine ranges which have the smallest gap */ - while (cur_nodes > req_nodes) { - prev = NULL; - min_gap = ULONG_MAX; - curr = interval_tree_iter_first(root, 0, ULONG_MAX); - while (curr) { - if (prev) { - curr_gap = curr->start - prev->last; - if (curr_gap < min_gap) { - min_gap = curr_gap; - comb_start = prev; - comb_end = curr; - } - } - prev = curr; - curr = interval_tree_iter_next(curr, 0, ULONG_MAX); - } - comb_start->last = comb_end->last; - interval_tree_remove(comb_end, root); - cur_nodes--; - } -} - static int mlx5vf_create_tracker(struct mlx5_core_dev *mdev, struct mlx5vf_pci_core_device *mvdev, struct rb_root_cached *ranges, u32 nnodes) @@ -760,7 +714,7 @@ static int mlx5vf_create_tracker(struct mlx5_core_dev *mdev, int i; if (num_ranges > max_num_range) { - combine_ranges(ranges, nnodes, max_num_range); + vfio_combine_iova_ranges(ranges, nnodes, max_num_range); num_ranges = max_num_range; } diff --git a/drivers/vfio/vfio_main.c b/drivers/vfio/vfio_main.c index 5177bb061b17..3942551bdfa1 100644 --- a/drivers/vfio/vfio_main.c +++ b/drivers/vfio/vfio_main.c @@ -809,6 +809,54 @@ static int vfio_ioctl_device_feature_migration(struct vfio_device *device, return 0; } +void vfio_combine_iova_ranges(struct rb_root_cached *root, u32 cur_nodes, + u32 req_nodes) +{ + struct interval_tree_node *prev, *curr, *comb_start, *comb_end; + unsigned long min_gap; + unsigned long curr_gap; + + /* Special shortcut when a single range is required */ + if (req_nodes == 1) { + unsigned long last; + + comb_start = interval_tree_iter_first(root, 0, ULONG_MAX); + curr = comb_start; + while (curr) { + last = curr->last; + prev = curr; + curr = interval_tree_iter_next(curr, 0, ULONG_MAX); + if (prev != comb_start) + interval_tree_remove(prev, root); + } + comb_start->last = last; + return; + } + + /* Combine ranges which have the smallest gap */ + while (cur_nodes > req_nodes) { + prev = NULL; + min_gap = ULONG_MAX; + curr = interval_tree_iter_first(root, 0, ULONG_MAX); + while (curr) { + if (prev) { + curr_gap = curr->start - prev->last; + if (curr_gap < min_gap) { + min_gap = curr_gap; + comb_start = prev; + comb_end = curr; + } + } + prev = curr; + curr = interval_tree_iter_next(curr, 0, ULONG_MAX); + } + comb_start->last = comb_end->last; + interval_tree_remove(comb_end, root); + cur_nodes--; + } +} +EXPORT_SYMBOL_GPL(vfio_combine_iova_ranges); + /* Ranges should fit into a single kernel page */ #define LOG_MAX_RANGES \ (PAGE_SIZE / sizeof(struct vfio_device_feature_dma_logging_range)) diff --git a/include/linux/vfio.h b/include/linux/vfio.h index 35be78e9ae57..08d39d291b5f 100644 --- a/include/linux/vfio.h +++ b/include/linux/vfio.h @@ -237,6 +237,9 @@ int vfio_mig_get_next_state(struct vfio_device *device, enum vfio_device_mig_state new_fsm, enum vfio_device_mig_state *next_fsm); +void vfio_combine_iova_ranges(struct rb_root_cached *root, u32 cur_nodes, + u32 req_nodes); + /* * External user API */ From patchwork Sun Feb 19 08:39:06 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brett Creeley X-Patchwork-Id: 13145821 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3014C64ED6 for ; Sun, 19 Feb 2023 08:40:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229822AbjBSIkm (ORCPT ); Sun, 19 Feb 2023 03:40:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59822 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229776AbjBSIki (ORCPT ); Sun, 19 Feb 2023 03:40:38 -0500 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2076.outbound.protection.outlook.com [40.107.93.76]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 738CB11150; Sun, 19 Feb 2023 00:40:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XqliSkv9kbwLo4KES/aONIwl5dcC2tiHvL4/jvQfVTg8jFU+7RJL+lFrBjrh6ME6vxS0Fnc9bpaxNFkhxKGN6Bq4HcvIJXPgjG5GS/bbq2M0ygHub72jCpDjcQgRzKh7w5A3hRFCe6jPMYnu6Q1+Xh9kLyYb94T+8GsIKfkashvQtiKJmft4CANSjAjnYYli15dfrFQYe47RqridWUkJ3gNnf5TjJ3zpKz1WJ2SY/+a//FKKc4VUtDwNze8+jvXqaiCFjNV+NMr7McnmcAKSWXDjRs8hwDSs2vYTJcQXL9zgmCc2whq7R9QSrpaopRWre+2FSFQVDy/mnXz5LXfm0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ptOLbIX1pVxx8Bt1PJqEN08hNoeWGvTozg6pJYFUdZU=; b=K1ML6twLc79R27sdU5H8iJL2BWXqCbM25nMC8BT9Jb7dxpgD4c6nh0o250AM5kyt9JSetZ2gqzQnkFdTXsn0A5p1PcfwmvAZPzuQLBuZCuQO/PybkB58qJVRVmiJmHwijmK8c20aZhR85e0316I7C1UGZHLwGk3w4fxIbuvXQoR95M50zZMG7K4N6cp74s9HkvYHAXad1+E/xI6iDDxpViuWdOTONDW4e3r/1gIUFdELhVqHg3ylksHortpHBHzuTVDjo9lKA/Z7hl17YnbTuyC6tj32SjjBJ4WNJ7dOofxzI1+fbx+gnPhBLAHxMk3I9qsC/injdVeBfSXLOGVG3g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ptOLbIX1pVxx8Bt1PJqEN08hNoeWGvTozg6pJYFUdZU=; b=Wa2f5VMysEIOACmYMhcIQKWX/mUmlwm8csG2+0nKP9xYBjqyd/NJCONqIfvTAbVj+rb8JCQG2NpakvneQZ2CZHxtvjjBr1ffWrNY5TwL7nHCOT9/Bj0u84/uCgtd2qlRMf7hGcOrUdAaAGk//v3ZVt/RO1/zA0bw5aenDtLzMjE= Received: from MW4PR03CA0149.namprd03.prod.outlook.com (2603:10b6:303:8c::34) by CH3PR12MB8402.namprd12.prod.outlook.com (2603:10b6:610:132::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.19; Sun, 19 Feb 2023 08:40:06 +0000 Received: from CO1NAM11FT114.eop-nam11.prod.protection.outlook.com (2603:10b6:303:8c:cafe::70) by MW4PR03CA0149.outlook.office365.com (2603:10b6:303:8c::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.18 via Frontend Transport; Sun, 19 Feb 2023 08:40:05 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1NAM11FT114.mail.protection.outlook.com (10.13.174.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6111.18 via Frontend Transport; Sun, 19 Feb 2023 08:40:05 +0000 Received: from driver-dev1.pensando.io (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Sun, 19 Feb 2023 02:40:00 -0600 From: Brett Creeley To: , , , , , , , CC: , , Subject: [PATCH v3 5/7] vfio/pds: Add support for dirty page tracking Date: Sun, 19 Feb 2023 00:39:06 -0800 Message-ID: <20230219083908.40013-6-brett.creeley@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230219083908.40013-1-brett.creeley@amd.com> References: <20230219083908.40013-1-brett.creeley@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT114:EE_|CH3PR12MB8402:EE_ X-MS-Office365-Filtering-Correlation-Id: 1a8ea37b-1981-440d-e529-08db1254e6ac X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ETI8HS7bt15ohA0lrpQ3yC/Kvqym2gJZQ5ykPPuqGcspseKq2mj6pcpWfsTz3l+N4+TKdjfZf6UygnDjiNxDJ36C1u0bVgzyeKc4cmQGb54gmLfS7R7EJJ2w0F7mG/O3kT4ofMFpqeqn7oKxPklXfURO0PS0Y1q5KrA3hbfA/wO3/uL+dqGg6qWZ/aQbFJGZhooIGnJRoV19e7Ao25qT1qgDuJ+awzwfplkLQAYM0WjbjT1E9gQkyfLCCXeusGE/WHGUUEr3+ZfWgcErHEIEn2SF1WSak2YeE719fHmkxL0K07AAp1Ae/AcmCRmDdXJrSFXCmkZNSPc8mmgUZUVxnVl17+bIrz/d9IPoqgNNdoBe5OgmamgyeXteHkLyM1duBgrcDWqa7AC1BQW82qNBkJPmIOPZp5qZKqD2D1KBNpLQ9wbeBJLqytnmj83MMJS6G5Dd8Ou8YfG+/wJljMjdZAXH1LpPHriaGQqIi+LLJmV0erSh8QEPu96BfhtqtPuZrqRgJ0+HQkQb2C7H3Yvs1nB9GXN0x01aMuFas+DFCqVCXIC6HAVVXWWfCn4p8Rb0vo0KKPDg5MmsAUfgchV96JYWHPuTIYn7m3b280K7yosTAtUeODrzbo/GK457M6atSc4QHlqfM5pmGEJBv8IuMb6jJ0cl+UsKpmFVDiLkifIEhDQK9uUxbieG3bcd8d0ULq+7AEhtuEWz9Aem40lMx0Mvgp8F6cU9G1aAz/6UpWHbYbV1CQPXCNQZX6cYy7gh3ZiBb2A4frWnHimWJ2Exrg== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230025)(4636009)(346002)(136003)(39860400002)(396003)(376002)(451199018)(40470700004)(36840700001)(46966006)(16526019)(54906003)(316002)(110136005)(40460700003)(478600001)(1076003)(186003)(26005)(82740400003)(36860700001)(2906002)(36756003)(86362001)(356005)(82310400005)(81166007)(47076005)(70206006)(70586007)(40480700001)(426003)(336012)(2616005)(83380400001)(8936002)(30864003)(5660300002)(44832011)(4326008)(41300700001)(8676002)(14143004)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Feb 2023 08:40:05.7981 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1a8ea37b-1981-440d-e529-08db1254e6ac X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT114.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB8402 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org In order to support dirty page tracking, the driver has to implement the VFIO subsystem's vfio_log_ops. This includes log_start, log_stop, and log_read_and_clear. All of the tracker resources are allocated and dirty tracking on the device is started during log_start. The resources are cleaned up and dirty tracking on the device is stopped during log_stop. The dirty pages are determined and reported during log_read_and_clear. In order to support these callbacks admin queue commands are used. All of the adminq queue command structures and implementations are included as part of this patch. PDS_LM_CMD_DIRTY_STATUS is added to query the current status of dirty tracking on the device. This includes if it's enabled (i.e. number of regions being tracked from the device's perspective) and the maximum number of regions supported from the device's perspective. PDS_LM_CMD_DIRTY_ENABLE is added to enable dirty tracking on the specified number of regions and their iova ranges. PDS_LM_CMD_DIRTY_DISABLE is added to disable dirty tracking for all regions on the device. PDS_LM_CMD_READ_SEQ and PDS_LM_CMD_DIRTY_WRITE_ACK are added to support reading and acknowledging the currently dirtied pages. Signed-off-by: Brett Creeley Signed-off-by: Shannon Nelson --- drivers/vfio/pci/pds/Makefile | 1 + drivers/vfio/pci/pds/cmds.c | 143 +++++++++ drivers/vfio/pci/pds/cmds.h | 15 + drivers/vfio/pci/pds/dirty.c | 541 ++++++++++++++++++++++++++++++++ drivers/vfio/pci/pds/dirty.h | 48 +++ drivers/vfio/pci/pds/lm.h | 10 + drivers/vfio/pci/pds/vfio_dev.c | 9 + drivers/vfio/pci/pds/vfio_dev.h | 2 + include/linux/pds/pds_lm.h | 173 ++++++++++ 9 files changed, 942 insertions(+) create mode 100644 drivers/vfio/pci/pds/dirty.c create mode 100644 drivers/vfio/pci/pds/dirty.h diff --git a/drivers/vfio/pci/pds/Makefile b/drivers/vfio/pci/pds/Makefile index 7d927c8fa1fd..f2a388eebe86 100644 --- a/drivers/vfio/pci/pds/Makefile +++ b/drivers/vfio/pci/pds/Makefile @@ -6,6 +6,7 @@ obj-$(CONFIG_PDS_VFIO_PCI) += pds_vfio.o pds_vfio-y := \ aux_drv.o \ cmds.o \ + dirty.o \ lm.o \ pci_drv.o \ vfio_dev.o diff --git a/drivers/vfio/pci/pds/cmds.c b/drivers/vfio/pci/pds/cmds.c index f6ae0885628a..63189e6f3a88 100644 --- a/drivers/vfio/pci/pds/cmds.c +++ b/drivers/vfio/pci/pds/cmds.c @@ -340,3 +340,146 @@ pds_vfio_send_host_vf_lm_status_cmd(struct pds_vfio_pci_device *pds_vfio, dev_warn(&pdev->dev, "failed to send host VF migration status: %pe\n", ERR_PTR(err)); } + +int +pds_vfio_dirty_status_cmd(struct pds_vfio_pci_device *pds_vfio, + u64 regions_dma, u8 *max_regions, + u8 *num_regions) +{ + struct pds_auxiliary_dev *padev = pds_vfio->vfio_aux->padev; + struct pds_lm_dirty_status_cmd cmd = { + .opcode = PDS_LM_CMD_DIRTY_STATUS, + .vf_id = cpu_to_le16(pds_vfio->vf_id), + }; + struct pds_lm_dirty_status_comp comp = {0}; + struct pci_dev *pdev = pds_vfio->pdev; + int err; + + dev_dbg(&pdev->dev, "vf%u: Dirty status\n", pds_vfio->vf_id); + + cmd.regions_dma = cpu_to_le64(regions_dma); + cmd.max_regions = *max_regions; + + err = padev->ops->adminq_cmd(padev, + (union pds_core_adminq_cmd *)&cmd, + sizeof(cmd), + (union pds_core_adminq_comp *)&comp, + 0); + if (err) { + dev_err(&pdev->dev, "failed to get dirty status: %pe\n", + ERR_PTR(err)); + return err; + } + + /* only support seq_ack approach for now */ + if (!(le32_to_cpu(comp.bmp_type_mask) & + BIT(PDS_LM_DIRTY_BMP_TYPE_SEQ_ACK))) { + dev_err(&pdev->dev, "Dirty bitmap tracking SEQ_ACK not supported\n"); + return -EOPNOTSUPP; + } + + *num_regions = comp.num_regions; + *max_regions = comp.max_regions; + + dev_dbg(&pdev->dev, "Page Tracking Status command successful, max_regions: %d, num_regions: %d, bmp_type: %s\n", + *max_regions, *num_regions, "PDS_LM_DIRTY_BMP_TYPE_SEQ_ACK"); + + return 0; +} + +int +pds_vfio_dirty_enable_cmd(struct pds_vfio_pci_device *pds_vfio, + u64 regions_dma, u8 num_regions) +{ + struct pds_auxiliary_dev *padev = pds_vfio->vfio_aux->padev; + struct pds_lm_dirty_enable_cmd cmd = { + .opcode = PDS_LM_CMD_DIRTY_ENABLE, + .vf_id = cpu_to_le16(pds_vfio->vf_id), + }; + struct pds_lm_dirty_status_comp comp = {0}; + struct pci_dev *pdev = pds_vfio->pdev; + int err; + + cmd.regions_dma = cpu_to_le64(regions_dma); + cmd.bmp_type = PDS_LM_DIRTY_BMP_TYPE_SEQ_ACK; + cmd.num_regions = num_regions; + + err = padev->ops->adminq_cmd(padev, + (union pds_core_adminq_cmd *)&cmd, + sizeof(cmd), + (union pds_core_adminq_comp *)&comp, + 0); + if (err) { + dev_err(&pdev->dev, "failed dirty tracking enable: %pe\n", + ERR_PTR(err)); + return err; + } + + return 0; +} + +int +pds_vfio_dirty_disable_cmd(struct pds_vfio_pci_device *pds_vfio) +{ + struct pds_auxiliary_dev *padev = pds_vfio->vfio_aux->padev; + struct pds_lm_dirty_disable_cmd cmd = { + .opcode = PDS_LM_CMD_DIRTY_DISABLE, + .vf_id = cpu_to_le16(pds_vfio->vf_id), + }; + struct pds_lm_dirty_status_comp comp = {0}; + struct pci_dev *pdev = pds_vfio->pdev; + int err; + + err = padev->ops->adminq_cmd(padev, + (union pds_core_adminq_cmd *)&cmd, + sizeof(cmd), + (union pds_core_adminq_comp *)&comp, + 0); + if (err || comp.num_regions != 0) { + /* in case num_regions is still non-zero after disable */ + err = err ? err : -EIO; + dev_err(&pdev->dev, "failed dirty tracking disable: %pe, num_regions %d\n", + ERR_PTR(err), comp.num_regions); + return err; + } + + return 0; +} + +int +pds_vfio_dirty_seq_ack_cmd(struct pds_vfio_pci_device *pds_vfio, + u64 sgl_dma, u16 num_sge, u32 offset, + u32 total_len, bool read_seq) +{ + const char *cmd_type_str = read_seq ? "read_seq" : "write_ack"; + struct pds_auxiliary_dev *padev = pds_vfio->vfio_aux->padev; + struct pds_lm_dirty_seq_ack_cmd cmd = { + .vf_id = cpu_to_le16(pds_vfio->vf_id), + }; + struct pci_dev *pdev = pds_vfio->pdev; + struct pds_lm_comp comp = {0}; + int err; + + if (read_seq) + cmd.opcode = PDS_LM_CMD_DIRTY_READ_SEQ; + else + cmd.opcode = PDS_LM_CMD_DIRTY_WRITE_ACK; + + cmd.sgl_addr = cpu_to_le64(sgl_dma); + cmd.num_sge = cpu_to_le16(num_sge); + cmd.len_bytes = cpu_to_le32(total_len); + cmd.off_bytes = cpu_to_le32(offset); + + err = padev->ops->adminq_cmd(padev, + (union pds_core_adminq_cmd *)&cmd, + sizeof(cmd), + (union pds_core_adminq_comp *)&comp, + 0); + if (err) { + dev_err(&pdev->dev, "failed cmd Page Tracking %s: %pe\n", + cmd_type_str, ERR_PTR(err)); + return err; + } + + return 0; +} diff --git a/drivers/vfio/pci/pds/cmds.h b/drivers/vfio/pci/pds/cmds.h index f12d41cf5423..bca5e0348406 100644 --- a/drivers/vfio/pci/pds/cmds.h +++ b/drivers/vfio/pci/pds/cmds.h @@ -4,6 +4,8 @@ #ifndef _CMDS_H_ #define _CMDS_H_ +#include + #include struct pds_vfio_pci_device; @@ -25,5 +27,18 @@ pds_vfio_set_lm_state_cmd(struct pds_vfio_pci_device *pds_vfio); void pds_vfio_send_host_vf_lm_status_cmd(struct pds_vfio_pci_device *pds_vfio, enum pds_lm_host_vf_status vf_status); +int +pds_vfio_dirty_status_cmd(struct pds_vfio_pci_device *pds_vfio, + u64 regions_dma, u8 *max_regions, + u8 *num_regions); +int +pds_vfio_dirty_enable_cmd(struct pds_vfio_pci_device *pds_vfio, + u64 regions_dma, u8 num_regions); +int +pds_vfio_dirty_disable_cmd(struct pds_vfio_pci_device *pds_vfio); +int +pds_vfio_dirty_seq_ack_cmd(struct pds_vfio_pci_device *pds_vfio, + u64 sgl_dma, u16 num_sge, u32 offset, + u32 total_len, bool read_seq); #endif /* _CMDS_H_ */ diff --git a/drivers/vfio/pci/pds/dirty.c b/drivers/vfio/pci/pds/dirty.c new file mode 100644 index 000000000000..b6bba2001dff --- /dev/null +++ b/drivers/vfio/pci/pds/dirty.c @@ -0,0 +1,541 @@ +// SPDX-License-Identifier: GPL-2.0 +/* Copyright(c) 2023 Advanced Micro Devices, Inc. */ + +#include +#include +#include +#include +#include +#include + +#include +#include +#include +#include + +#include "cmds.h" +#include "dirty.h" +#include "vfio_dev.h" + +#define READ_SEQ true +#define WRITE_ACK false + +bool +pds_vfio_dirty_is_enabled(struct pds_vfio_pci_device *pds_vfio) +{ + return pds_vfio->dirty.is_enabled; +} + +void +pds_vfio_dirty_set_enabled(struct pds_vfio_pci_device *pds_vfio) +{ + pds_vfio->dirty.is_enabled = true; +} + +void +pds_vfio_dirty_set_disabled(struct pds_vfio_pci_device *pds_vfio) +{ + pds_vfio->dirty.is_enabled = false; +} + +static void +pds_vfio_print_guest_region_info(struct pds_vfio_pci_device *pds_vfio, + u8 max_regions) +{ + int len = max_regions * sizeof(struct pds_lm_dirty_region_info); + struct pds_lm_dirty_region_info *region_info; + struct pci_dev *pdev = pds_vfio->pdev; + dma_addr_t regions_dma; + u8 num_regions; + int err; + + region_info = kcalloc(max_regions, + sizeof(struct pds_lm_dirty_region_info), + GFP_KERNEL); + if (!region_info) + return; + + regions_dma = dma_map_single(pds_vfio->coredev, region_info, len, + DMA_FROM_DEVICE); + if (dma_mapping_error(pds_vfio->coredev, regions_dma)) { + kfree(region_info); + return; + } + + err = pds_vfio_dirty_status_cmd(pds_vfio, regions_dma, + &max_regions, &num_regions); + dma_unmap_single(pds_vfio->coredev, regions_dma, len, DMA_FROM_DEVICE); + + if (!err) { + int i; + + for (i = 0; i < num_regions; i++) + dev_dbg(&pdev->dev, "region_info[%d]: dma_base 0x%llx page_count %u page_size_log2 %u\n", + i, le64_to_cpu(region_info[i].dma_base), + le32_to_cpu(region_info[i].page_count), + region_info[i].page_size_log2); + } + + kfree(region_info); +} + +static int +pds_vfio_dirty_alloc_bitmaps(struct pds_vfio_dirty *dirty, + u32 nbits) +{ + unsigned long *host_seq_bmp, *host_ack_bmp; + + host_seq_bmp = bitmap_zalloc(nbits, GFP_KERNEL); + if (!host_seq_bmp) + return -ENOMEM; + + host_ack_bmp = bitmap_zalloc(nbits, GFP_KERNEL); + if (!host_ack_bmp) { + bitmap_free(host_seq_bmp); + return -ENOMEM; + } + + dirty->host_seq.bmp = host_seq_bmp; + dirty->host_ack.bmp = host_ack_bmp; + + return 0; +} + +static void +pds_vfio_dirty_free_bitmaps(struct pds_vfio_dirty *dirty) +{ + if (dirty->host_seq.bmp) + bitmap_free(dirty->host_seq.bmp); + if (dirty->host_ack.bmp) + bitmap_free(dirty->host_ack.bmp); + + dirty->host_seq.bmp = NULL; + dirty->host_ack.bmp = NULL; +} + +static void +__pds_vfio_dirty_free_sgl(struct pds_vfio_pci_device *pds_vfio, + struct pds_vfio_bmp_info *bmp_info) +{ + dma_free_coherent(pds_vfio->coredev, + bmp_info->num_sge * sizeof(*bmp_info->sgl), + bmp_info->sgl, bmp_info->sgl_addr); + + bmp_info->num_sge = 0; + bmp_info->sgl = NULL; + bmp_info->sgl_addr = 0; +} + +static void +pds_vfio_dirty_free_sgl(struct pds_vfio_pci_device *pds_vfio) +{ + if (pds_vfio->dirty.host_seq.sgl) + __pds_vfio_dirty_free_sgl(pds_vfio, + &pds_vfio->dirty.host_seq); + if (pds_vfio->dirty.host_ack.sgl) + __pds_vfio_dirty_free_sgl(pds_vfio, + &pds_vfio->dirty.host_ack); +} + +static int +__pds_vfio_dirty_alloc_sgl(struct pds_vfio_pci_device *pds_vfio, + struct pds_vfio_bmp_info *bmp_info, + u32 page_count) +{ + struct pds_lm_sg_elem *sgl; + dma_addr_t sgl_addr; + u32 max_sge; + + max_sge = DIV_ROUND_UP(page_count, PAGE_SIZE * 8); + + sgl = dma_alloc_coherent(pds_vfio->coredev, + max_sge * sizeof(*sgl), &sgl_addr, + GFP_KERNEL); + if (!sgl) + return -ENOMEM; + + bmp_info->sgl = sgl; + bmp_info->num_sge = max_sge; + bmp_info->sgl_addr = sgl_addr; + + return 0; +} + +static int +pds_vfio_dirty_alloc_sgl(struct pds_vfio_pci_device *pds_vfio, + u32 page_count) +{ + struct pds_vfio_dirty *dirty = &pds_vfio->dirty; + int err; + + err = __pds_vfio_dirty_alloc_sgl(pds_vfio, + &dirty->host_seq, + page_count); + if (err) + return err; + + err = __pds_vfio_dirty_alloc_sgl(pds_vfio, + &dirty->host_ack, + page_count); + if (err) { + __pds_vfio_dirty_free_sgl(pds_vfio, &dirty->host_seq); + return err; + } + + return 0; +} + +static int +pds_vfio_dirty_enable(struct pds_vfio_pci_device *pds_vfio, + struct rb_root_cached *ranges, u32 nnodes, + u64 *page_size) +{ + struct pds_vfio_dirty *dirty = &pds_vfio->dirty; + u64 region_start, region_size, region_page_size; + struct pds_lm_dirty_region_info *region_info; + struct interval_tree_node *node = NULL; + struct pci_dev *pdev = pds_vfio->pdev; + u8 max_regions = 0, num_regions; + dma_addr_t regions_dma = 0; + u32 num_ranges = nnodes; + u32 page_count; + u16 len; + int err; + + dev_dbg(&pdev->dev, "vf%u: Start dirty page tracking\n", pds_vfio->vf_id); + + if (pds_vfio_dirty_is_enabled(pds_vfio)) + return -EINVAL; + + pds_vfio_dirty_set_enabled(pds_vfio); + + /* find if dirty tracking is disabled, i.e. num_regions == 0 */ + err = pds_vfio_dirty_status_cmd(pds_vfio, 0, &max_regions, &num_regions); + if (num_regions) { + dev_err(&pdev->dev, "Dirty tracking already enabled for %d regions\n", + num_regions); + err = -EEXIST; + goto err_out; + } else if (!max_regions) { + dev_err(&pdev->dev, "Device doesn't support dirty tracking, max_regions %d\n", + max_regions); + err = -EOPNOTSUPP; + goto err_out; + } else if (err) { + dev_err(&pdev->dev, "Failed to get dirty status, err %pe\n", + ERR_PTR(err)); + goto err_out; + } + + /* Only support 1 region for now. If there are any large gaps in the + * VM's address regions, then this would be a waste of memory as we are + * generating 2 bitmaps (ack/seq) from the min address to the max + * address of the VM's address regions. In the future, if we support + * more than one region in the device/driver we can split the bitmaps + * on the largest address region gaps. We can do this split up to the + * max_regions times returned from the dirty_status command. + */ + max_regions = 1; + if (num_ranges > max_regions) { + vfio_combine_iova_ranges(ranges, nnodes, max_regions); + num_ranges = max_regions; + } + + node = interval_tree_iter_first(ranges, 0, ULONG_MAX); + if (!node) { + err = -EINVAL; + goto err_out; + } + + region_size = node->last - node->start + 1; + region_start = node->start; + region_page_size = *page_size; + + len = sizeof(*region_info); + region_info = kzalloc(len, GFP_KERNEL); + if (!region_info) { + err = -ENOMEM; + goto err_out; + } + + page_count = DIV_ROUND_UP(region_size, region_page_size); + + region_info->dma_base = cpu_to_le64(region_start); + region_info->page_count = cpu_to_le32(page_count); + region_info->page_size_log2 = ilog2(region_page_size); + + regions_dma = dma_map_single(pds_vfio->coredev, (void *)region_info, len, + DMA_BIDIRECTIONAL); + if (dma_mapping_error(pds_vfio->coredev, regions_dma)) { + err = -ENOMEM; + kfree(region_info); + goto err_out; + } + + err = pds_vfio_dirty_enable_cmd(pds_vfio, regions_dma, max_regions); + dma_unmap_single(pds_vfio->coredev, regions_dma, len, DMA_BIDIRECTIONAL); + /* page_count might be adjusted by the device, + * update it before freeing region_info DMA + */ + page_count = le32_to_cpu(region_info->page_count); + + dev_dbg(&pdev->dev, "region_info: regions_dma 0x%llx dma_base 0x%llx page_count %u page_size_log2 %u\n", + regions_dma, region_start, page_count, (u8)ilog2(region_page_size)); + + kfree(region_info); + if (err) + goto err_out; + + err = pds_vfio_dirty_alloc_bitmaps(dirty, page_count); + if (err) { + dev_err(&pdev->dev, "Failed to alloc dirty bitmaps: %pe\n", + ERR_PTR(err)); + goto err_out; + } + + err = pds_vfio_dirty_alloc_sgl(pds_vfio, page_count); + if (err) { + dev_err(&pdev->dev, "Failed to alloc dirty sg lists: %pe\n", + ERR_PTR(err)); + goto err_free_bitmaps; + } + + dirty->region_start = region_start; + dirty->region_size = region_size; + dirty->region_page_size = region_page_size; + + pds_vfio_print_guest_region_info(pds_vfio, max_regions); + + return 0; + +err_free_bitmaps: + pds_vfio_dirty_free_bitmaps(dirty); +err_out: + pds_vfio_dirty_set_disabled(pds_vfio); + return err; +} + +static int +pds_vfio_dirty_disable(struct pds_vfio_pci_device *pds_vfio) +{ + int err; + + if (!pds_vfio_dirty_is_enabled(pds_vfio)) + return 0; + + pds_vfio_dirty_set_disabled(pds_vfio); + err = pds_vfio_dirty_disable_cmd(pds_vfio); + pds_vfio_dirty_free_sgl(pds_vfio); + pds_vfio_dirty_free_bitmaps(&pds_vfio->dirty); + + return err; +} + +static int +pds_vfio_dirty_seq_ack(struct pds_vfio_pci_device *pds_vfio, + struct pds_vfio_bmp_info *bmp_info, + u32 offset, u32 bmp_bytes, + bool read_seq) +{ + const char *bmp_type_str = read_seq ? "read_seq" : "write_ack"; + struct pci_dev *pdev = pds_vfio->pdev; + int bytes_remaining; + dma_addr_t bmp_dma; + u8 dma_direction; + u16 num_sge = 0; + int err, i; + u64 *bmp; + + bmp = (u64 *)((u64)bmp_info->bmp + offset); + + dma_direction = read_seq ? DMA_FROM_DEVICE : DMA_TO_DEVICE; + bmp_dma = dma_map_single(pds_vfio->coredev, bmp, bmp_bytes, + dma_direction); + if (dma_mapping_error(pds_vfio->coredev, bmp_dma)) + return -EINVAL; + + bytes_remaining = bmp_bytes; + + for (i = 0; i < bmp_info->num_sge && bytes_remaining > 0; i++) { + struct pds_lm_sg_elem *sg_elem = &bmp_info->sgl[i]; + u32 len = (bytes_remaining > PAGE_SIZE) ? + PAGE_SIZE : bytes_remaining; + + sg_elem->addr = cpu_to_le64(bmp_dma + i * PAGE_SIZE); + sg_elem->len = cpu_to_le32(len); + + bytes_remaining -= len; + ++num_sge; + } + + err = pds_vfio_dirty_seq_ack_cmd(pds_vfio, bmp_info->sgl_addr, + num_sge, offset, bmp_bytes, read_seq); + if (err) + dev_err(&pdev->dev, "Dirty bitmap %s failed offset %u bmp_bytes %u num_sge %u DMA 0x%llx: %pe\n", + bmp_type_str, offset, bmp_bytes, num_sge, bmp_info->sgl_addr, ERR_PTR(err)); + + dma_unmap_single(pds_vfio->coredev, bmp_dma, bmp_bytes, dma_direction); + + return err; +} + +static int +pds_vfio_dirty_write_ack(struct pds_vfio_pci_device *pds_vfio, u32 offset, + u32 len) +{ + return pds_vfio_dirty_seq_ack(pds_vfio, + &pds_vfio->dirty.host_ack, offset, + len, WRITE_ACK); +} + +static int +pds_vfio_dirty_read_seq(struct pds_vfio_pci_device *pds_vfio, u32 offset, + u32 len) +{ + return pds_vfio_dirty_seq_ack(pds_vfio, + &pds_vfio->dirty.host_seq, offset, + len, READ_SEQ); +} + +static int +pds_vfio_dirty_process_bitmaps(struct pds_vfio_pci_device *pds_vfio, + struct iova_bitmap *dirty_bitmap, u32 bmp_offset, + u32 len_bytes) +{ + u64 page_size = pds_vfio->dirty.region_page_size; + u64 region_start = pds_vfio->dirty.region_start; + u32 bmp_offset_bit; + int dword_count, i; + __le64 *seq, *ack; + + dword_count = len_bytes / sizeof(u64); + seq = (__le64 *)((u64)pds_vfio->dirty.host_seq.bmp + bmp_offset); + ack = (__le64 *)((u64)pds_vfio->dirty.host_ack.bmp + bmp_offset); + bmp_offset_bit = bmp_offset * 8; + + for (i = 0; i < dword_count; i++) { + u64 xor = le64_to_cpu(seq[i]) ^ le64_to_cpu(ack[i]); + u8 bit_i; + + /* prepare for next write_ack call */ + ack[i] = seq[i]; + + for (bit_i = 0; bit_i < BITS_PER_TYPE(u64); ++bit_i) { + if (xor & BIT(bit_i)) { + u64 abs_bit_i = bmp_offset_bit + i * + BITS_PER_TYPE(u64) + bit_i; + u64 addr = abs_bit_i * page_size + region_start; + + iova_bitmap_set(dirty_bitmap, addr, page_size); + } + } + } + + return 0; +} + +static int +pds_vfio_dirty_sync(struct pds_vfio_pci_device *pds_vfio, + struct iova_bitmap *dirty_bitmap, + unsigned long iova, unsigned long length) +{ + struct pds_vfio_dirty *dirty = &pds_vfio->dirty; + struct pci_dev *pdev = pds_vfio->pdev; + u64 bmp_offset, bmp_bytes; + u64 bitmap_size, pages; + int err; + + dev_dbg(&pdev->dev, "vf%u: Get dirty page bitmap\n", pds_vfio->vf_id); + + if (!pds_vfio_dirty_is_enabled(pds_vfio)) { + dev_err(&pdev->dev, "vf%u: Sync failed, dirty tracking is disabled\n", + pds_vfio->vf_id); + return -EINVAL; + } + + pages = DIV_ROUND_UP(length, pds_vfio->dirty.region_page_size); + bitmap_size = round_up(pages, sizeof(u64) * BITS_PER_BYTE) / + BITS_PER_BYTE; + + dev_dbg(&pdev->dev, "vf%u: iova 0x%lx length %lu page_size %llu pages %llu bitmap_size %llu\n", + pds_vfio->vf_id, iova, length, + pds_vfio->dirty.region_page_size, pages, bitmap_size); + + if (!length || + ((dirty->region_start + iova + length) > + (dirty->region_start + dirty->region_size))) { + dev_err(&pdev->dev, "Invalid iova 0x%lx and/or length 0x%lx to sync\n", + iova, length); + return -EINVAL; + } + + /* bitmap is modified in 64 bit chunks */ + bmp_bytes = ALIGN(DIV_ROUND_UP(length / dirty->region_page_size, + sizeof(u64)), sizeof(u64)); + if (bmp_bytes != bitmap_size) { + dev_err(&pdev->dev, "Calculated bitmap bytes %llu not equal to bitmap size %llu\n", + bmp_bytes, bitmap_size); + return -EINVAL; + } + + bmp_offset = DIV_ROUND_UP(iova / dirty->region_page_size, sizeof(u64)); + + dev_dbg(&pdev->dev, "Syncing dirty bitmap, iova 0x%lx length 0x%lx, bmp_offset %llu bmp_bytes %llu\n", + iova, length, bmp_offset, bmp_bytes); + + err = pds_vfio_dirty_read_seq(pds_vfio, bmp_offset, bmp_bytes); + if (err) + return err; + + err = pds_vfio_dirty_process_bitmaps(pds_vfio, dirty_bitmap, + bmp_offset, bmp_bytes); + if (err) + return err; + + err = pds_vfio_dirty_write_ack(pds_vfio, bmp_offset, bmp_bytes); + if (err) + return err; + + return 0; +} + +int +pds_vfio_dma_logging_report(struct vfio_device *vdev, unsigned long iova, + unsigned long length, + struct iova_bitmap *dirty) +{ + struct pds_vfio_pci_device *pds_vfio = + container_of(vdev, struct pds_vfio_pci_device, + vfio_coredev.vdev); + + return pds_vfio_dirty_sync(pds_vfio, dirty, iova, length); +} + +int +pds_vfio_dma_logging_start(struct vfio_device *vdev, + struct rb_root_cached *ranges, u32 nnodes, + u64 *page_size) +{ + struct pds_vfio_pci_device *pds_vfio = + container_of(vdev, struct pds_vfio_pci_device, + vfio_coredev.vdev); + int err; + + pds_vfio_send_host_vf_lm_status_cmd(pds_vfio, PDS_LM_STA_IN_PROGRESS); + + err = pds_vfio_dirty_enable(pds_vfio, ranges, nnodes, page_size); + if (err) + return err; + + return 0; +} + +int +pds_vfio_dma_logging_stop(struct vfio_device *vdev) +{ + struct pds_vfio_pci_device *pds_vfio = + container_of(vdev, struct pds_vfio_pci_device, + vfio_coredev.vdev); + + return pds_vfio_dirty_disable(pds_vfio); +} diff --git a/drivers/vfio/pci/pds/dirty.h b/drivers/vfio/pci/pds/dirty.h new file mode 100644 index 000000000000..75849ec44482 --- /dev/null +++ b/drivers/vfio/pci/pds/dirty.h @@ -0,0 +1,48 @@ +// SPDX-License-Identifier: GPL-2.0 +/* Copyright(c) 2023 Advanced Micro Devices, Inc. */ + +#ifndef _DIRTY_H_ +#define _DIRTY_H_ + +#include +#include + +#include + +struct pds_vfio_bmp_info { + unsigned long *bmp; + u32 bmp_bytes; + struct pds_lm_sg_elem *sgl; + dma_addr_t sgl_addr; + u16 num_sge; +}; + +struct pds_vfio_dirty { + struct pds_vfio_bmp_info host_seq; + struct pds_vfio_bmp_info host_ack; + u64 region_size; + u64 region_start; + u64 region_page_size; + bool is_enabled; +}; + +struct pds_vfio_pci_device; + +bool +pds_vfio_dirty_is_enabled(struct pds_vfio_pci_device *pds_vfio); +void +pds_vfio_dirty_set_enabled(struct pds_vfio_pci_device *pds_vfio); +void +pds_vfio_dirty_set_disabled(struct pds_vfio_pci_device *pds_vfio); + +int +pds_vfio_dma_logging_report(struct vfio_device *vdev, unsigned long iova, + unsigned long length, + struct iova_bitmap *dirty); +int +pds_vfio_dma_logging_start(struct vfio_device *vdev, + struct rb_root_cached *ranges, u32 nnodes, + u64 *page_size); +int +pds_vfio_dma_logging_stop(struct vfio_device *vdev); +#endif /* _DIRTY_H_ */ diff --git a/drivers/vfio/pci/pds/lm.h b/drivers/vfio/pci/pds/lm.h index 08f49d259c40..f46345db9a90 100644 --- a/drivers/vfio/pci/pds/lm.h +++ b/drivers/vfio/pci/pds/lm.h @@ -33,6 +33,16 @@ struct pds_vfio_pci_device; struct file * pds_vfio_step_device_state_locked(struct pds_vfio_pci_device *pds_vfio, enum vfio_device_mig_state next); +int +pds_vfio_dma_logging_report(struct vfio_device *vdev, unsigned long iova, + unsigned long length, + struct iova_bitmap *dirty); +int +pds_vfio_dma_logging_start(struct vfio_device *vdev, + struct rb_root_cached *ranges, u32 nnodes, + u64 *page_size); +int +pds_vfio_dma_logging_stop(struct vfio_device *vdev); const char * pds_vfio_lm_state(enum vfio_device_mig_state state); void diff --git a/drivers/vfio/pci/pds/vfio_dev.c b/drivers/vfio/pci/pds/vfio_dev.c index 4dfe32b07839..8d32b2a543c9 100644 --- a/drivers/vfio/pci/pds/vfio_dev.c +++ b/drivers/vfio/pci/pds/vfio_dev.c @@ -5,6 +5,7 @@ #include #include "lm.h" +#include "dirty.h" #include "vfio_dev.h" #include "aux_drv.h" @@ -117,6 +118,13 @@ pds_vfio_lm_ops = { .migration_get_data_size = pds_vfio_get_device_state_size }; +static const struct vfio_log_ops +pds_vfio_log_ops = { + .log_start = pds_vfio_dma_logging_start, + .log_stop = pds_vfio_dma_logging_stop, + .log_read_and_clear = pds_vfio_dma_logging_report, +}; + static int pds_vfio_init_device(struct vfio_device *vdev) { @@ -135,6 +143,7 @@ pds_vfio_init_device(struct vfio_device *vdev) vdev->migration_flags = VFIO_MIGRATION_STOP_COPY | VFIO_MIGRATION_P2P; vdev->mig_ops = &pds_vfio_lm_ops; + vdev->log_ops = &pds_vfio_log_ops; dev_dbg(&pdev->dev, "%s: PF %#04x VF %#04x (%d) vf_id %d domain %d pds_vfio %p\n", __func__, pci_dev_id(pdev->physfn), diff --git a/drivers/vfio/pci/pds/vfio_dev.h b/drivers/vfio/pci/pds/vfio_dev.h index 61651d2d1c7b..6abb52814ef0 100644 --- a/drivers/vfio/pci/pds/vfio_dev.h +++ b/drivers/vfio/pci/pds/vfio_dev.h @@ -7,6 +7,7 @@ #include #include +#include "dirty.h" #include "lm.h" struct pds_vfio_pci_device { @@ -17,6 +18,7 @@ struct pds_vfio_pci_device { struct pds_vfio_lm_file *save_file; struct pds_vfio_lm_file *restore_file; + struct pds_vfio_dirty dirty; struct mutex state_mutex; /* protect migration state */ enum vfio_device_mig_state state; spinlock_t reset_lock; /* protect reset_done flow */ diff --git a/include/linux/pds/pds_lm.h b/include/linux/pds/pds_lm.h index 28ebd62f7583..c7e83932f2fb 100644 --- a/include/linux/pds/pds_lm.h +++ b/include/linux/pds/pds_lm.h @@ -25,6 +25,13 @@ enum pds_lm_cmd_opcode { PDS_LM_CMD_RESUME = 20, PDS_LM_CMD_SAVE = 21, PDS_LM_CMD_RESTORE = 22, + + /* Dirty page tracking commands */ + PDS_LM_CMD_DIRTY_STATUS = 32, + PDS_LM_CMD_DIRTY_ENABLE = 33, + PDS_LM_CMD_DIRTY_DISABLE = 34, + PDS_LM_CMD_DIRTY_READ_SEQ = 35, + PDS_LM_CMD_DIRTY_WRITE_ACK = 36, }; /** @@ -215,4 +222,170 @@ struct pds_lm_host_vf_status_cmd { u8 status; }; +/** + * struct pds_lm_dirty_region_info - Memory region info for STATUS and ENABLE + * @dma_base: Base address of the DMA-contiguous memory region + * @page_count: Number of pages in the memory region + * @page_size_log2: Log2 page size in the memory region + * @rsvd: Word boundary padding + */ +struct pds_lm_dirty_region_info { + __le64 dma_base; + __le32 page_count; + u8 page_size_log2; + u8 rsvd[3]; +}; + +/** + * struct pds_lm_dirty_status_cmd - DIRTY_STATUS command + * @opcode: Opcode PDS_LM_CMD_DIRTY_STATUS + * @rsvd: Word boundary padding + * @vf_id: VF id + * @max_regions: Capacity of the region info buffer + * @rsvd2: Word boundary padding + * @regions_dma: DMA address of the region info buffer + * + * The minimum of max_regions (from the command) and num_regions (from the + * completion) of struct pds_lm_dirty_region_info will be written to + * regions_dma. + * + * The max_regions may be zero, in which case regions_dma is ignored. In that + * case, the completion will only report the maximum number of regions + * supported by the device, and the number of regions currently enabled. + */ +struct pds_lm_dirty_status_cmd { + u8 opcode; + u8 rsvd; + __le16 vf_id; + u8 max_regions; + u8 rsvd2[3]; + __le64 regions_dma; +} __packed; + +/** + * enum pds_lm_dirty_bmp_type - Type of dirty page bitmap + * @PDS_LM_DIRTY_BMP_TYPE_NONE: No bitmap / disabled + * @PDS_LM_DIRTY_BMP_TYPE_SEQ_ACK: Seq/Ack bitmap representation + */ +enum pds_lm_dirty_bmp_type { + PDS_LM_DIRTY_BMP_TYPE_NONE = 0, + PDS_LM_DIRTY_BMP_TYPE_SEQ_ACK = 1, +}; + +/** + * struct pds_lm_dirty_status_comp - STATUS command completion + * @status: Status of the command (enum pds_core_status_code) + * @rsvd: Word boundary padding + * @comp_index: Index in the desc ring for which this is the completion + * @max_regions: Maximum number of regions supported by the device + * @num_regions: Number of regions currently enabled + * @bmp_type: Type of dirty bitmap representation + * @rsvd2: Word boundary padding + * @bmp_type_mask: Mask of supported bitmap types, bit index per type + * @rsvd3: Word boundary padding + * @color: Color bit + * + * This completion descriptor is used for STATUS, ENABLE, and DISABLE. + */ +struct pds_lm_dirty_status_comp { + u8 status; + u8 rsvd; + __le16 comp_index; + u8 max_regions; + u8 num_regions; + u8 bmp_type; + u8 rsvd2; + __le32 bmp_type_mask; + u8 rsvd3[3]; + u8 color; +}; + +/** + * struct pds_lm_dirty_enable_cmd - DIRTY_ENABLE command + * @opcode: Opcode PDS_LM_CMD_DIRTY_ENABLE + * @rsvd: Word boundary padding + * @vf_id: VF id + * @bmp_type: Type of dirty bitmap representation + * @num_regions: Number of entries in the region info buffer + * @rsvd2: Word boundary padding + * @regions_dma: DMA address of the region info buffer + * + * The num_regions must be nonzero, and less than or equal to the maximum + * number of regions supported by the device. + * + * The memory regions should not overlap. + * + * The information should be initialized by the driver. The device may modify + * the information on successful completion, such as by size-aligning the + * number of pages in a region. + * + * The modified number of pages will be greater than or equal to the page count + * given in the enable command, and at least as coarsly aligned as the given + * value. For example, the count might be aligned to a multiple of 64, but + * if the value is already a multiple of 128 or higher, it will not change. + * If the driver requires its own minimum alignment of the number of pages, the + * driver should account for that already in the region info of this command. + * + * This command uses struct pds_lm_dirty_status_comp for its completion. + */ +struct pds_lm_dirty_enable_cmd { + u8 opcode; + u8 rsvd; + __le16 vf_id; + u8 bmp_type; + u8 num_regions; + u8 rsvd2[2]; + __le64 regions_dma; +} __packed; + +/** + * struct pds_lm_dirty_disable_cmd - DIRTY_DISABLE command + * @opcode: Opcode PDS_LM_CMD_DIRTY_DISABLE + * @rsvd: Word boundary padding + * @vf_id: VF id + * + * Dirty page tracking will be disabled. This may be called in any state, as + * long as dirty page tracking is supported by the device, to ensure that dirty + * page tracking is disabled. + * + * This command uses struct pds_lm_dirty_status_comp for its completion. On + * success, num_regions will be zero. + */ +struct pds_lm_dirty_disable_cmd { + u8 opcode; + u8 rsvd; + __le16 vf_id; +}; + +/** + * struct pds_lm_dirty_seq_ack_cmd - DIRTY_READ_SEQ or _WRITE_ACK command + * @opcode: Opcode PDS_LM_CMD_DIRTY_[READ_SEQ|WRITE_ACK] + * @rsvd: Word boundary padding + * @vf_id: VF id + * @off_bytes: Byte offset in the bitmap + * @len_bytes: Number of bytes to transfer + * @num_sge: Number of DMA scatter gather elements + * @rsvd2: Word boundary padding + * @sgl_addr: DMA address of scatter gather list + * + * Read bytes from the SEQ bitmap, or write bytes into the ACK bitmap. + * + * This command treats the entire bitmap as a byte buffer. It does not + * distinguish between guest memory regions. The driver should refer to the + * number of pages in each region, according to PDS_LM_CMD_DIRTY_STATUS, to + * determine the region boundaries in the bitmap. Each region will be + * represented by exactly the number of bits as the page count for that region, + * immediately following the last bit of the previous region. + */ +struct pds_lm_dirty_seq_ack_cmd { + u8 opcode; + u8 rsvd; + __le16 vf_id; + __le32 off_bytes; + __le32 len_bytes; + __le16 num_sge; + u8 rsvd2[2]; + __le64 sgl_addr; +} __packed; + #endif /* _PDS_LM_H_ */ From patchwork Sun Feb 19 08:39:07 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brett Creeley X-Patchwork-Id: 13145819 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03CEBC6379F for ; Sun, 19 Feb 2023 08:40:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229798AbjBSIkj (ORCPT ); Sun, 19 Feb 2023 03:40:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59516 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229570AbjBSIk3 (ORCPT ); Sun, 19 Feb 2023 03:40:29 -0500 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2070.outbound.protection.outlook.com [40.107.243.70]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 19AC5FF3D; Sun, 19 Feb 2023 00:40:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nAmqciNOymFSj54MWCmeK8RcW4kOc/OQ2IEb/JWc8wUS8H2Zl4mooeBeskoWhvIHp5EAYiZdD+q5zGDr782rO0q0Ap+edXLnU2++V4f0xNAwgjWHrX+c5vyVuXHCwCl3ysJ3GD+akANd8lzCWPCtrcRfjC3beaIxt2Oy7BleNvE38Z3jn3yWk/ZRlYNaiZCp+j9y6K8J/1c4T9Qb3LmLKPipzhDWW7D2mcCj8Zb15Wl4Y5ENvWoqsUTvTXXBTYGvH4L78WEgbe0WbUqL8pntkJVzLC8YmivmsLRzqQk2p1JOU5pbmSDEeeqTJkMxlNkSC5aXQBdcTWtHJdNE+bkJBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vtrMvI0DuHif4UOFQ8Gq5vULGnkoQ1ASNHsJzY7/fAE=; b=gINbm4zaSTKQPSYjfetZJLB+0KULJbQenRoLtLArWEG0mY8JJkJvNxQUfHYhMTeMYF5nH/7BN/ZfEIVSjfRIZp1jMgcT5hAFFSXv6Z2gBjhdlYYDfWirWxyGz3L93NNnXKV1Wa5Irf5AJCWJlFkfEQvw/Q7j4f5othpBmp9ueAzNMubcTaUWlpAECZv8bQp/RPUCw+bN+UgHPHL2yxXlqz8S2omkkWmiYr96mk3HB3r9bK5NX676CNPb2hgSSHZkDsvuhz0TO5HHRW5WbtOMkZO9olRoCYC7Aktdklp8APxPXOPvLyk5mWnNUxChDEeDGWhk053HsUKU6GCtRw3iLA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vtrMvI0DuHif4UOFQ8Gq5vULGnkoQ1ASNHsJzY7/fAE=; b=wLBzlVVRaL+GXAIUQS+vw0ekXbaJjI5k8wVjt18+auCsrkr8fyffSRCOdplg6oxTq9OArJXX2rQgmi0dCKD3IcNJj3z3N/qrxocS81ENcEKZ6C4o9tu/nLiQ5lGLbnPTn8Kf2zmm+snW9yi82aG5ey2eHO2e10mMfsBPjpNXLWY= Received: from MW4PR03CA0130.namprd03.prod.outlook.com (2603:10b6:303:8c::15) by SN7PR12MB8170.namprd12.prod.outlook.com (2603:10b6:806:32c::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.18; Sun, 19 Feb 2023 08:40:08 +0000 Received: from CO1NAM11FT114.eop-nam11.prod.protection.outlook.com (2603:10b6:303:8c:cafe::d6) by MW4PR03CA0130.outlook.office365.com (2603:10b6:303:8c::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.18 via Frontend Transport; Sun, 19 Feb 2023 08:40:08 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1NAM11FT114.mail.protection.outlook.com (10.13.174.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6111.18 via Frontend Transport; Sun, 19 Feb 2023 08:40:08 +0000 Received: from driver-dev1.pensando.io (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Sun, 19 Feb 2023 02:40:04 -0600 From: Brett Creeley To: , , , , , , , CC: , , Subject: [PATCH v3 6/7] vfio/pds: Add support for firmware recovery Date: Sun, 19 Feb 2023 00:39:07 -0800 Message-ID: <20230219083908.40013-7-brett.creeley@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230219083908.40013-1-brett.creeley@amd.com> References: <20230219083908.40013-1-brett.creeley@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT114:EE_|SN7PR12MB8170:EE_ X-MS-Office365-Filtering-Correlation-Id: c960a44d-277a-4dfd-f58c-08db1254e808 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: To+cpii2ZSALETcr1AJgLdPeFNKV3uonB+aTVQctquwNo6SsAzxb+OLl0EAqEu+b4MTvBRgUnggFgIzVr7dd5w0az12RVAnV3rDv9OH18oiIRWjZcEitx32KbVVmsbla3Ek7ZgTNKeJB3hBgKfaaKgJYkMQykXyzbeZEvWGL4XgdnjfFszLPtpZPdfvsxL2QdY3K1fZ/h55I2rBbCHFV+mwC63VpqmWqm+bHFL1IKYywI/TWegUY5FjXr0WYlMLqhMyv7pimbsFgt7sS+1JkTcTcdJ2YJKF/k7blBdPZyF1/18kzUqaOt3LtAH2uHsTEpZv1bTwR8fOjXmGifuLQjKczTHXf6XZloE+831PyIkIp23rMtr72zcUYMqBf42KPzPi2ciBreijC+zs3xAWOtLTClHL0FPjp/LTivZVsVt4GCFwJ0Z90E5CfC1Qgj53a4iD+BWX5Lxx7y0Qx9XTKWc0GtIeP1iW+ac+sbJnfwCPwGCEMrNSg7WeYVec5HnZ0bJ+pTQ5hRUSLmvOjPUC0tuuJKUE67caq/mSe8Q7KnHpa3aNPhcbu8nSEq8YQzorsMTdPlTZ6l4tK+KADuguIHF44505Vo9DAQ9Q7C/jxV7v21WjdvRixUCnuMNYzdUIXr3VVoyr03247HgL/6fFYzd+YnfIv7rbZyn7VyMfFT5xL4zkwq49LkQYIkqsZUW4sgFvGFC4JoeufF6J/K7Nb/s7ueyZ4hbG3EdKH4Lp78xw= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230025)(4636009)(39860400002)(376002)(346002)(136003)(396003)(451199018)(36840700001)(40470700004)(46966006)(44832011)(5660300002)(26005)(16526019)(186003)(40480700001)(1076003)(426003)(86362001)(47076005)(2616005)(336012)(83380400001)(478600001)(356005)(36756003)(2906002)(36860700001)(8676002)(82740400003)(316002)(41300700001)(4326008)(70206006)(70586007)(81166007)(110136005)(40460700003)(54906003)(8936002)(82310400005)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Feb 2023 08:40:08.0948 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c960a44d-277a-4dfd-f58c-08db1254e808 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT114.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB8170 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org It's possible that the device firmware crashes and is able to recover due to some configuration and/or other issue. If a live migration is in progress while the firmware crashes, the live migration will fail. However, the VF PCI device should still be functional post crash recovery and subsequent migrations should go through as expected. When the pds_core device notices that firmware crashes it sends an event to all its client drivers over auxiliary bus. When the pds_vfio driver receives this event while migration is in progress it will request a deferred reset on the next migration state transition. This state transition will report failure as well as any subsequent state transition requests from the VMM/VFIO. Based on uapi/vfio.h the only way out of VFIO_DEVICE_STATE_ERROR is by issuing VFIO_DEVICE_RESET. Once this reset is done, the migration state will be reset to VFIO_DEVICE_STATE_RUNNING and migration can be performed. If the event is received while no migration is in progress (i.e. the VM is in normal operating mode), then no actions are taken and the migration state remains VFIO_DEVICE_STATE_RUNNING. Signed-off-by: Brett Creeley Signed-off-by: Shannon Nelson --- drivers/vfio/pci/pds/aux_drv.c | 61 +++++++++++++++++++++++++++++++++ drivers/vfio/pci/pds/aux_drv.h | 1 + drivers/vfio/pci/pds/vfio_dev.c | 34 ++++++++++++++++-- drivers/vfio/pci/pds/vfio_dev.h | 4 +++ 4 files changed, 98 insertions(+), 2 deletions(-) diff --git a/drivers/vfio/pci/pds/aux_drv.c b/drivers/vfio/pci/pds/aux_drv.c index 4b1f06f8aac9..2d5a3225c786 100644 --- a/drivers/vfio/pci/pds/aux_drv.c +++ b/drivers/vfio/pci/pds/aux_drv.c @@ -21,6 +21,46 @@ struct auxiliary_device_id pds_vfio_aux_id_table[] = { {}, }; +static void +pds_vfio_recovery_work(struct work_struct *work) +{ + struct pds_vfio_aux *vfio_aux = + container_of(work, struct pds_vfio_aux, work); + struct pds_vfio_pci_device *pds_vfio = vfio_aux->pds_vfio; + bool deferred_reset_needed = false; + + /* Documentation states that the kernel migration driver must not + * generate asynchronous device state transitions outside of + * manipulation by the user or the VFIO_DEVICE_RESET ioctl. + * + * Since recovery is an asynchronous event received from the device, + * initiate a deferred reset. Only issue the deferred reset if a + * migration is in progress, which will cause the next step of the + * migration to fail. Also, if the device is in a state that will + * be set to VFIO_DEVICE_STATE_RUNNING on the next action (i.e. VM is + * shutdown and device is in VFIO_DEVICE_STATE_STOP) as that will clear + * the VFIO_DEVICE_STATE_ERROR when the VM starts back up. + */ + mutex_lock(&pds_vfio->state_mutex); + if ((pds_vfio->state != VFIO_DEVICE_STATE_RUNNING && + pds_vfio->state != VFIO_DEVICE_STATE_ERROR) || + (pds_vfio->state == VFIO_DEVICE_STATE_RUNNING && + pds_vfio_dirty_is_enabled(pds_vfio))) + deferred_reset_needed = true; + mutex_unlock(&pds_vfio->state_mutex); + + /* On the next user initiated state transition, the device will + * transition to the VFIO_DEVICE_STATE_ERROR. At this point it's the user's + * responsibility to reset the device. + * + * If a VFIO_DEVICE_RESET is requested post recovery and before the next + * state transition, then the deferred reset state will be set to + * VFIO_DEVICE_STATE_RUNNING. + */ + if (deferred_reset_needed) + pds_vfio_deferred_reset(pds_vfio, VFIO_DEVICE_STATE_ERROR); +} + static void pds_vfio_aux_notify_handler(struct pds_auxiliary_dev *padev, union pds_core_notifyq_comp *event) @@ -29,6 +69,23 @@ pds_vfio_aux_notify_handler(struct pds_auxiliary_dev *padev, u16 ecode = le16_to_cpu(event->ecode); dev_dbg(dev, "%s: event code %d\n", __func__, ecode); + + /* We don't need to do anything for RESET state==0 as there is no notify + * or feedback mechanism available, and it is possible that we won't + * even see a state==0 event. + * + * Any requests from VFIO while state==0 will fail, which will return + * error and may cause migration to fail. + */ + if (ecode == PDS_EVENT_RESET) { + dev_info(dev, "%s: PDS_EVENT_RESET event received, state==%d\n", + __func__, event->reset.state); + if (event->reset.state == 1) { + struct pds_vfio_aux *vfio_aux = auxiliary_get_drvdata(&padev->aux_dev); + + schedule_work(&vfio_aux->work); + } + } } static int @@ -88,6 +145,8 @@ pds_vfio_aux_probe(struct auxiliary_device *aux_dev, goto err_out; } + INIT_WORK(&vfio_aux->work, pds_vfio_recovery_work); + return 0; err_out: @@ -103,6 +162,8 @@ pds_vfio_aux_remove(struct auxiliary_device *aux_dev) struct pds_vfio_aux *vfio_aux = auxiliary_get_drvdata(aux_dev); struct pds_vfio_pci_device *pds_vfio = vfio_aux->pds_vfio; + cancel_work_sync(&vfio_aux->work); + if (pds_vfio) { pds_vfio_unregister_client_cmd(pds_vfio); vfio_aux->pds_vfio->vfio_aux = NULL; diff --git a/drivers/vfio/pci/pds/aux_drv.h b/drivers/vfio/pci/pds/aux_drv.h index be5948575a0c..ffad35a5b1e4 100644 --- a/drivers/vfio/pci/pds/aux_drv.h +++ b/drivers/vfio/pci/pds/aux_drv.h @@ -17,6 +17,7 @@ struct pds_vfio_aux { struct pds_auxiliary_dev *padev; struct pds_auxiliary_drv padrv; struct pds_vfio_pci_device *pds_vfio; + struct work_struct work; }; struct auxiliary_driver * diff --git a/drivers/vfio/pci/pds/vfio_dev.c b/drivers/vfio/pci/pds/vfio_dev.c index 8d32b2a543c9..5fbf434d9696 100644 --- a/drivers/vfio/pci/pds/vfio_dev.c +++ b/drivers/vfio/pci/pds/vfio_dev.c @@ -26,10 +26,17 @@ pds_vfio_state_mutex_unlock(struct pds_vfio_pci_device *pds_vfio) if (pds_vfio->deferred_reset) { pds_vfio->deferred_reset = false; if (pds_vfio->state == VFIO_DEVICE_STATE_ERROR) { - pds_vfio->state = VFIO_DEVICE_STATE_RUNNING; + dev_dbg(&pds_vfio->pdev->dev, "Transitioning from VFIO_DEVICE_STATE_ERROR to %s\n", + pds_vfio_lm_state(pds_vfio->deferred_reset_state)); + pds_vfio->state = pds_vfio->deferred_reset_state; pds_vfio_put_restore_file(pds_vfio); pds_vfio_put_save_file(pds_vfio); + } else if (pds_vfio->deferred_reset_state == VFIO_DEVICE_STATE_ERROR) { + dev_dbg(&pds_vfio->pdev->dev, "Transitioning from %s to VFIO_DEVICE_STATE_ERROR based on deferred_reset request\n", + pds_vfio_lm_state(pds_vfio->state)); + pds_vfio->state = VFIO_DEVICE_STATE_ERROR; } + pds_vfio->deferred_reset_state = VFIO_DEVICE_STATE_RUNNING; spin_unlock(&pds_vfio->reset_lock); goto again; } @@ -42,6 +49,7 @@ pds_vfio_reset(struct pds_vfio_pci_device *pds_vfio) { spin_lock(&pds_vfio->reset_lock); pds_vfio->deferred_reset = true; + pds_vfio->deferred_reset_state = VFIO_DEVICE_STATE_RUNNING; if (!mutex_trylock(&pds_vfio->state_mutex)) { spin_unlock(&pds_vfio->reset_lock); return; @@ -50,6 +58,18 @@ pds_vfio_reset(struct pds_vfio_pci_device *pds_vfio) pds_vfio_state_mutex_unlock(pds_vfio); } +void +pds_vfio_deferred_reset(struct pds_vfio_pci_device *pds_vfio, + enum vfio_device_mig_state reset_state) +{ + dev_info(&pds_vfio->pdev->dev, "Requesting deferred_reset to state %s\n", + pds_vfio_lm_state(reset_state)); + spin_lock(&pds_vfio->reset_lock); + pds_vfio->deferred_reset = true; + pds_vfio->deferred_reset_state = reset_state; + spin_unlock(&pds_vfio->reset_lock); +} + static struct file * pds_vfio_set_device_state(struct vfio_device *vdev, enum vfio_device_mig_state new_state) @@ -63,7 +83,13 @@ pds_vfio_set_device_state(struct vfio_device *vdev, return ERR_PTR(-ENODEV); mutex_lock(&pds_vfio->state_mutex); - while (new_state != pds_vfio->state) { + /* only way to transition out of VFIO_DEVICE_STATE_ERROR is via + * VFIO_DEVICE_RESET, so prevent the state machine from running since + * vfio_mig_get_next_state() will throw a WARN_ON() when transitioning + * from VFIO_DEVICE_STATE_ERROR to any other state + */ + while (pds_vfio->state != VFIO_DEVICE_STATE_ERROR && + new_state != pds_vfio->state) { enum vfio_device_mig_state next_state; int err = vfio_mig_get_next_state(vdev, pds_vfio->state, @@ -85,6 +111,9 @@ pds_vfio_set_device_state(struct vfio_device *vdev, } } pds_vfio_state_mutex_unlock(pds_vfio); + /* still waiting on a deferred_reset */ + if (pds_vfio->state == VFIO_DEVICE_STATE_ERROR) + res = ERR_PTR(-EIO); return res; } @@ -169,6 +198,7 @@ pds_vfio_open_device(struct vfio_device *vdev) dev_dbg(&pds_vfio->pdev->dev, "%s: %s => VFIO_DEVICE_STATE_RUNNING\n", __func__, pds_vfio_lm_state(pds_vfio->state)); pds_vfio->state = VFIO_DEVICE_STATE_RUNNING; + pds_vfio->deferred_reset_state = VFIO_DEVICE_STATE_RUNNING; vfio_pci_core_finish_enable(&pds_vfio->vfio_coredev); diff --git a/drivers/vfio/pci/pds/vfio_dev.h b/drivers/vfio/pci/pds/vfio_dev.h index 6abb52814ef0..c93e9d033b7a 100644 --- a/drivers/vfio/pci/pds/vfio_dev.h +++ b/drivers/vfio/pci/pds/vfio_dev.h @@ -23,6 +23,7 @@ struct pds_vfio_pci_device { enum vfio_device_mig_state state; spinlock_t reset_lock; /* protect reset_done flow */ u8 deferred_reset; + enum vfio_device_mig_state deferred_reset_state; int vf_id; int pci_id; @@ -34,5 +35,8 @@ struct pds_vfio_pci_device * pds_vfio_pci_drvdata(struct pci_dev *pdev); void pds_vfio_reset(struct pds_vfio_pci_device *pds_vfio); +void +pds_vfio_deferred_reset(struct pds_vfio_pci_device *pds_vfio, + enum vfio_device_mig_state reset_state); #endif /* _VFIO_DEV_H_ */ From patchwork Sun Feb 19 08:39:08 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brett Creeley X-Patchwork-Id: 13145820 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10868C6379F for ; Sun, 19 Feb 2023 08:40:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229812AbjBSIkk (ORCPT ); Sun, 19 Feb 2023 03:40:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59802 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229769AbjBSIki (ORCPT ); Sun, 19 Feb 2023 03:40:38 -0500 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on20609.outbound.protection.outlook.com [IPv6:2a01:111:f400:7e8a::609]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 94CA710AA3; Sun, 19 Feb 2023 00:40:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nJ071Vu7QDoyRFpIDV6UBkOoAdTgmssJKz3NVtk+icdIvjs0RpvFiet/eKl2DnZGb4p+L3lKDnZDPhEhmwqmGUMeSVqHP61NxkmE6C+zTGxFtGW8Hgye5KM5EqW8/vHh8XU+rlQX23rMT3wd9qLR2Y38Mj06iBLjKbekJ/ldY0iQtmRwUOmYXlSm7nopkcOQPsnaZObYZonB0FofST45yrJOo+iXQSylmPJ8L46xzjAytgHf6wbhqwe60e4YAKyvgtML15X7PjtJE/KIdI8vylyTI56zb55glTywqyLIQ+UAVr5WTYBm3fUp1aW+JaWytqkgQ6H+ZT4q88J+N3XVGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=W/2XftHJaQhgBedb+chQEwyW7ta+q9uXFw4v/KhfvvY=; b=hRIJjIgkOE4iTFaN3pZ/1csxM3NPmiW/fuCNcwPT8IPGPnqSZMTKGx0pTdVdcydh8cLOa/bYpedzS5SXQYnKDMZCdnClda5MhQ1eYkZs6PMH1br20r0d36W/CvlwZv3nSSnIMIqCotUkteWUAc/L6+bfblDiXdFPbPJHI1wOvs8mGVEg7UUtT5XVCUt0vlNpHPz00uSLViz2ulWFBxSbTBp6F9dX7oHO3DpV8iwA3Un+Oh1xZYhh0qYuaEhB4E6AGd3PjVIk7VsKyzyymvbrFxqFUpmh1NPRRHw6jx1YePfuXhlJpMIX1gSl9QdEoZ5bAqsCN5N5vZGD/GhQ5UWMpw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=W/2XftHJaQhgBedb+chQEwyW7ta+q9uXFw4v/KhfvvY=; b=XZzta+za3s9DpWPv27V18nnFcr6oCZnNLkCh5WSnwiOveH0hEI7RjNa0bTv1py36dQ1YOYR/8b6FhkIW/o9LjyATvJg5+BS6xJ/SmhpufJJh9ktqSyVYGPe2crPIhOmA/zMd77eIAxSlfqVl4fb5jYyiQ8Et9e6uDJeBmYXJjc8= Received: from MWH0EPF00056D04.namprd21.prod.outlook.com (2603:10b6:30f:fff2:0:1:0:c) by CH3PR12MB8583.namprd12.prod.outlook.com (2603:10b6:610:15f::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.13; Sun, 19 Feb 2023 08:40:10 +0000 Received: from CO1NAM11FT089.eop-nam11.prod.protection.outlook.com (2a01:111:f400:7eab::206) by MWH0EPF00056D04.outlook.office365.com (2603:1036:d20::b) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.5 via Frontend Transport; Sun, 19 Feb 2023 08:40:09 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1NAM11FT089.mail.protection.outlook.com (10.13.175.179) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6111.18 via Frontend Transport; Sun, 19 Feb 2023 08:40:09 +0000 Received: from driver-dev1.pensando.io (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Sun, 19 Feb 2023 02:40:07 -0600 From: Brett Creeley To: , , , , , , , CC: , , Subject: [PATCH v3 7/7] vfio/pds: Add Kconfig and documentation Date: Sun, 19 Feb 2023 00:39:08 -0800 Message-ID: <20230219083908.40013-8-brett.creeley@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230219083908.40013-1-brett.creeley@amd.com> References: <20230219083908.40013-1-brett.creeley@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT089:EE_|CH3PR12MB8583:EE_ X-MS-Office365-Filtering-Correlation-Id: 6638fbf0-dd89-42ec-fc7c-08db1254e8ae X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: V9C12e2i91NZP7PgIdMsLNi4lt8sv8He7HyO/KOSk4ZYuwMcBy7leDem1HWWXEm83V/wixow8z5qyrfupUhWO3UQ+qaG944fhdxMNTjACv8SyUoQwX2Jzd0ZE5uQUzYm3+SW/ZN38tPpKiJ8lJ0ng875BA2ihCPLvFn0TUQOOYiDHLyQTaJIpeOfQeir1S9Rz2rE0mLOgzrhm0Dc6GBFrpBa28vSb0Z/M2QT6JLs+gBl4aoSuj+y0/a41jT8MYFhJ2IJ7l0Rg3gXc6IG2OhXsmzK2YmHE8UcOxH5bMNLI9g6sCKUh/bpW+BNGACoa/RUFqw3o0LGC3PG9vAxn+gb580hFlDz5U0Tj4sCditB4wo3ZMM8EV8QyRTbmVk1XPduNW2p2HEjXrSvHAC6ptyKrwuhhhgASw6m+KD80z8D981qEqDzgMpQxc89YYg/4Ql6bz9g0n49e43BiEeMc/yMg7tIZxun3zU+5+2r5bKKLC8ZGl4uyo7L9mYWLlsZ2sSpuEOIH7p49/A8DkpglyWPoLso1hO3xAQy3aBnu6iATJ14OFFn0EIS/OSif3wNLH5+/ZprmhJlc7Spc+JcRbq7q0LZzlzakLu7WOQeJvK8WHjtiKqXG1A/fOKANJnsB88qRmeq0NJ8RG1a7i7tVwaW639Yn0X7zMnZ95/M6r7iUy5I15Geaa19y65mMyhLbMPK/scutAu6swdtuDKAeXnBx0y3pabr39/wr4oHVDJv9kE= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230025)(4636009)(376002)(346002)(39860400002)(396003)(136003)(451199018)(40470700004)(36840700001)(46966006)(70586007)(2906002)(8676002)(8936002)(4326008)(44832011)(70206006)(5660300002)(1076003)(81166007)(356005)(36860700001)(82740400003)(86362001)(36756003)(478600001)(40480700001)(54906003)(110136005)(316002)(41300700001)(26005)(2616005)(82310400005)(47076005)(83380400001)(426003)(40460700003)(336012)(16526019)(186003)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Feb 2023 08:40:09.1829 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6638fbf0-dd89-42ec-fc7c-08db1254e8ae X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT089.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB8583 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org Add Kconfig entries and pds_vfio.rst. Also, add an entry in the MAINTAINERS file for this new driver. It's not clear where documentation for vendor specific VFIO drivers should live, so just re-use the current amd ethernet location. Signed-off-by: Brett Creeley Signed-off-by: Shannon Nelson --- .../device_drivers/ethernet/amd/pds_vfio.rst | 88 +++++++++++++++++++ .../device_drivers/ethernet/index.rst | 1 + MAINTAINERS | 7 ++ drivers/vfio/pci/Kconfig | 2 + drivers/vfio/pci/Makefile | 2 + drivers/vfio/pci/pds/Kconfig | 19 ++++ 6 files changed, 119 insertions(+) create mode 100644 Documentation/networking/device_drivers/ethernet/amd/pds_vfio.rst create mode 100644 drivers/vfio/pci/pds/Kconfig diff --git a/Documentation/networking/device_drivers/ethernet/amd/pds_vfio.rst b/Documentation/networking/device_drivers/ethernet/amd/pds_vfio.rst new file mode 100644 index 000000000000..fe95c53098e0 --- /dev/null +++ b/Documentation/networking/device_drivers/ethernet/amd/pds_vfio.rst @@ -0,0 +1,88 @@ +.. SPDX-License-Identifier: GPL-2.0+ +.. note: can be edited and viewed with /usr/bin/formiko-vim + +========================================================== +PCI VFIO driver for the AMD/Pensando(R) DSC adapter family +========================================================== + +AMD/Pensando Linux VFIO PCI Device Driver +Copyright(c) 2023 Advanced Micro Devices, Inc. + +Overview +======== + +The ``pds_vfio`` driver is both a PCI and auxiliary bus driver. The +PCI driver supports Live Migration capable Virtual Function (VF) +devices and the auxiliary driver is used to communicate with the +``pds_core`` driver and hardware. + +Using the device +================ + +The pds_vfio device is enabled via multiple configuration steps and +depends on the ``pds_core`` driver to create and enable SR-IOV Virtual +Function devices. + +Shown below are the steps to bind the driver to a VF and also to the +associated auxiliary device created by the ``pds_core`` driver. This +example assumes the pds_core and pds_vfio modules are already +loaded. + +.. code-block:: bash + :name: example-setup-script + + #!/bin/bash + + PF_BUS="0000:60" + PF_BDF="0000:60:00.0" + VF_BDF="0000:60:00.1" + + # Enable live migration VF auxiliary device(s) + devlink dev param set pci/$PF_BDF name enable_migration value true cmode runtime + + # Prevent non-vfio VF driver from probing the VF device + echo 0 > /sys/class/pci_bus/$PF_BUS/device/$PF_BDF/sriov_drivers_autoprobe + + # Create single VF for Live Migration via VFIO + echo 1 > /sys/bus/pci/drivers/pds_core/$PF_BDF/sriov_numvfs + + # Allow the VF to be bound to the pds_vfio driver + echo "pds_vfio" > /sys/class/pci_bus/$PF_BUS/device/$VF_BDF/driver_override + + # Bind the VF to the pds_vfio driver + echo "$VF_BDF" > /sys/bus/pci/drivers/pds_vfio/bind + +After performing the steps above the pds_vfio driver's PCI probe should +have been called, the pds_vfio driver's auxiliary probe should have +been called, and a file in /dev/vfio/ should have been created. +There will also be an entry in /sys/bus/auxiliary/device/pds_core.LM. +for the VF's auxiliary device and the associated driver registered by the +pds_vfio module will be at /sys/bus/auxiliary/drivers/pds_vfio.LM. + + +Enabling the driver +=================== + +The driver is enabled via the standard kernel configuration system, +using the make command:: + + make oldconfig/menuconfig/etc. + +The driver is located in the menu structure at: + + -> Device Drivers + -> VFIO Non-Privileged userspace driver framework + -> VFIO support for PDS PCI devices + +Support +======= + +For general Linux networking support, please use the netdev mailing +list, which is monitored by Pensando personnel:: + + netdev@vger.kernel.org + +For more specific support needs, please use the Pensando driver support +email:: + + drivers@pensando.io diff --git a/Documentation/networking/device_drivers/ethernet/index.rst b/Documentation/networking/device_drivers/ethernet/index.rst index aae0955eb26b..0011fde1a36a 100644 --- a/Documentation/networking/device_drivers/ethernet/index.rst +++ b/Documentation/networking/device_drivers/ethernet/index.rst @@ -14,6 +14,7 @@ Contents: 3com/vortex amazon/ena amd/pds_core + amd/pds_vfio altera/altera_tse aquantia/atlantic chelsio/cxgb diff --git a/MAINTAINERS b/MAINTAINERS index f2bd469ffae5..b94bcd011531 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -21929,6 +21929,13 @@ S: Maintained P: Documentation/driver-api/vfio-pci-device-specific-driver-acceptance.rst F: drivers/vfio/pci/*/ +VFIO PDS PCI DRIVER +M: Brett Creeley +L: kvm@vger.kernel.org +S: Maintained +F: Documentation/networking/device_drivers/ethernet/amd/pds_vfio.rst +F: drivers/vfio/pci/pds/ + VFIO PLATFORM DRIVER M: Eric Auger L: kvm@vger.kernel.org diff --git a/drivers/vfio/pci/Kconfig b/drivers/vfio/pci/Kconfig index f9d0c908e738..2c3831dd60ef 100644 --- a/drivers/vfio/pci/Kconfig +++ b/drivers/vfio/pci/Kconfig @@ -59,4 +59,6 @@ source "drivers/vfio/pci/mlx5/Kconfig" source "drivers/vfio/pci/hisilicon/Kconfig" +source "drivers/vfio/pci/pds/Kconfig" + endif diff --git a/drivers/vfio/pci/Makefile b/drivers/vfio/pci/Makefile index 24c524224da5..45167be462d8 100644 --- a/drivers/vfio/pci/Makefile +++ b/drivers/vfio/pci/Makefile @@ -11,3 +11,5 @@ obj-$(CONFIG_VFIO_PCI) += vfio-pci.o obj-$(CONFIG_MLX5_VFIO_PCI) += mlx5/ obj-$(CONFIG_HISI_ACC_VFIO_PCI) += hisilicon/ + +obj-$(CONFIG_PDS_VFIO_PCI) += pds/ diff --git a/drivers/vfio/pci/pds/Kconfig b/drivers/vfio/pci/pds/Kconfig new file mode 100644 index 000000000000..88422c5f36ec --- /dev/null +++ b/drivers/vfio/pci/pds/Kconfig @@ -0,0 +1,19 @@ +# SPDX-License-Identifier: GPL-2.0 +# Copyright (c) 2023 Advanced Micro Devices, Inc. + +config PDS_VFIO_PCI + tristate "VFIO support for PDS PCI devices" + depends on PDS_CORE + depends on VFIO_PCI_CORE + help + This provides generic PCI support for PDS devices using the VFIO + framework. + + More specific information on this driver can be + found in + . + + To compile this driver as a module, choose M here. The module + will be called pds_vfio. + + If you don't know what to do here, say N.