From patchwork Wed Feb 22 15:56:49 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Rix X-Patchwork-Id: 13149323 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3F9DC636D6 for ; Wed, 22 Feb 2023 15:57:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232696AbjBVP5w (ORCPT ); Wed, 22 Feb 2023 10:57:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48422 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231263AbjBVP5s (ORCPT ); Wed, 22 Feb 2023 10:57:48 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3CB8F3BDA1 for ; Wed, 22 Feb 2023 07:56:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677081418; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=GScpUkVmR1trk5NKo/KgCoCbwLxTQg040xij2n32R0k=; b=HyhSGnircdImN9PIP7NHmo0XSpWLvwccFI+a9ucaSl5Jmx6Igibb60hruPwzgPDZoW6BEl fbtMjOOu9u8bRCRHktxN39QQPh2XEAO6D+Lz7jEjZ72697DtybcznfoKrPAgNOypt3BD4l xpvkpb6u6MU7lnnSpv80N+jZt5dSygE= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-583-CxF4pknmMK6oJMgeOtcPsg-1; Wed, 22 Feb 2023 10:56:57 -0500 X-MC-Unique: CxF4pknmMK6oJMgeOtcPsg-1 Received: by mail-qk1-f200.google.com with SMTP id z23-20020a05620a101700b0073b328e7d17so3886918qkj.9 for ; Wed, 22 Feb 2023 07:56:57 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=GScpUkVmR1trk5NKo/KgCoCbwLxTQg040xij2n32R0k=; b=Y8DDzRkAMDB+LCvevOnWPDaBGrBMaTMP/eLJWQ2R+CqoBNOZnpqKC5ReOC4C9GV/9P YBbTJyuNvEzn6wUa3V3OY0U63ZtGTjKLkCbLYIC0ykAsiTs78YcXNQZOg2e4+WLKl/7n WXDXZqtdVhCUlFyecGE3vthy34b/TK4V9Xmd2Mfyu1RtulnpY/fTvXqijR9Gmqvz+JkA vj4e2tyCUjhQUoxqLDKK293evWKmZy+VoxYKTRoNtTweSlo4GIkB4YvfLBIvbLKdjG9G S01YuEm4Mo+mjrZMWC3jVKlcLnaCoYQ1yvBowQyU+4Y3wxqB4QVmqOLMHpizME5JaY2V 8elg== X-Gm-Message-State: AO0yUKUHFkNjcJzLsulpYOVdepb6hLdgkYq7pc9Rz9CouLJKM/A07yJT vAY3Dl5RhY7mE0kzlh3BPJgkOwe47QUT17nz3F+2zCNK9+QXLiATyLBfuYZ6JxK8hCsdtBkHdT0 wQ3iJpwzQjlbetMlKJOtweD1cYg== X-Received: by 2002:ad4:5aa7:0:b0:53c:9354:9721 with SMTP id u7-20020ad45aa7000000b0053c93549721mr17269898qvg.21.1677081416445; Wed, 22 Feb 2023 07:56:56 -0800 (PST) X-Google-Smtp-Source: AK7set+9amRNsc788f8Ah1EHOFjNZAoWEKdId2TpDxnPM1JRKz/kP2UH4h79UWQqmJg4CwTyIG4HZA== X-Received: by 2002:ad4:5aa7:0:b0:53c:9354:9721 with SMTP id u7-20020ad45aa7000000b0053c93549721mr17269856qvg.21.1677081416191; Wed, 22 Feb 2023 07:56:56 -0800 (PST) Received: from dell-per740-01.7a2m.lab.eng.bos.redhat.com (nat-pool-bos-t.redhat.com. [66.187.233.206]) by smtp.gmail.com with ESMTPSA id t78-20020a37aa51000000b006f9f3c0c63csm589967qke.32.2023.02.22.07.56.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Feb 2023 07:56:55 -0800 (PST) From: Tom Rix To: robdclark@gmail.com, quic_abhinavk@quicinc.com, dmitry.baryshkov@linaro.org, sean@poorly.run, airlied@gmail.com, daniel@ffwll.ch, nathan@kernel.org, ndesaulniers@google.com, tzimmermann@suse.de, javierm@redhat.com Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, Tom Rix Subject: [PATCH] drm/msm: return early when allocating fbdev fails Date: Wed, 22 Feb 2023 10:56:49 -0500 Message-Id: <20230222155649.2001467-1-trix@redhat.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org building with clang and W=1 reports drivers/gpu/drm/msm/msm_fbdev.c:144:6: error: variable 'helper' is used uninitialized whenever 'if' condition is true [-Werror,-Wsometimes-uninitialized] if (!fbdev) ^~~~~~ helper is only initialized after fbdev succeeds, so is in a garbage state at the fail: label. There is nothing to unwinded if fbdev alloaction fails, return NULL. Fixes: 3fb1f62f80a1 ("drm/fb-helper: Remove drm_fb_helper_unprepare() from drm_fb_helper_fini()") Signed-off-by: Tom Rix --- drivers/gpu/drm/msm/msm_fbdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/msm_fbdev.c b/drivers/gpu/drm/msm/msm_fbdev.c index c804e5ba682a..c1356aff87da 100644 --- a/drivers/gpu/drm/msm/msm_fbdev.c +++ b/drivers/gpu/drm/msm/msm_fbdev.c @@ -142,7 +142,7 @@ struct drm_fb_helper *msm_fbdev_init(struct drm_device *dev) fbdev = kzalloc(sizeof(*fbdev), GFP_KERNEL); if (!fbdev) - goto fail; + return NULL; helper = &fbdev->base;