From patchwork Tue Mar 7 11:58:30 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13163339 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A6855C678D4 for ; Tue, 7 Mar 2023 12:01:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ElX93xsZg4TYe5zwJHNZuJLHVdrLOyDmtzKNTUT4HAM=; b=k2xIcspMBZaSr6 OEke5JXU0TzCvt/5abaqNPrwZfT3z40HRiSaobWVjvulHshJqbeYxUdU1O5hS9P5I4JwtkFGxfT10 CyUobeZj19IvmT//IKfePiMpH4QocGvyNbnb71RymD8ijCHb4PQ24VhrBvG2IAnjiq1BLomcfsuLm ineA5XXz4SxTkttxWmELOF5xtazvql9H6tokmCHDV1nI0JwhuATAgOF1vkcCIySJ0GeyZU+xP5+ey 8WUlvXmcEfabtIxY+qENJ8h3ks/ymP/yOhSt11NgehdhqefOOwwWWF+lS598Chwk4iOHUg+b56n4t zs7OFIm8ACSLicxaSafg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pZVzN-00HZbb-He; Tue, 07 Mar 2023 12:00:17 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pZVyb-00HZ8j-QB for linux-arm-kernel@lists.infradead.org; Tue, 07 Mar 2023 11:59:32 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pZVyI-0006T5-3W; Tue, 07 Mar 2023 12:59:10 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pZVyE-002TES-Vg; Tue, 07 Mar 2023 12:59:06 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pZVyE-002yij-Bb; Tue, 07 Mar 2023 12:59:06 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Vinod Koul , Kishon Vijay Abraham I , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Andre Przywara , Wolfram Sang , Icenowy Zheng Cc: linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, kernel@pengutronix.de Subject: [PATCH 01/31] phy: allwinner: phy-sun4i-usb: Convert to platform remove callback returning void Date: Tue, 7 Mar 2023 12:58:30 +0100 Message-Id: <20230307115900.2293120-2-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230307115900.2293120-1-u.kleine-koenig@pengutronix.de> References: <20230307115900.2293120-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1919; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=A5l2lPoT4HwDDiKEGOetfLehy9xFEfoPwry6wSlMEIE=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBkByZ+ndr34KC6+DU92fWTYCRBx4D/esBgsXBP8 fUFnd0kDF2JATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCZAcmfgAKCRDB/BR4rcrs Cd8FB/4sVyrd21Uvk3d9LFOA2z189btbrMjnjrgUaePBHfcLUhL4vOXbmh+Hm3zHVUXOPC5m4yd jvMxSaA2GokI/ztFBvHqe/3g6A2f4MsZktdk/T8OdYbnkm9b2aCeRmGKATFJcwTDz0DtWugU1QY RUxpwCRvXpBDxH+tkajVez4tK+ohcLarFEnQu+PjVZEvdOUobkPjgLxPuL1CwBnKj3xK04xpngu zBe6pG6tGfclP6hDb9j02r40kb6Ozk9jpCMz41gW0r7WP6mtBxGsPRVPnIaBNUdH+grYMZoTvoo WrVr7zHRDhP96xKjTwk/3OMViaZHUio00HXlgMtvddUi756R X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230307_035929_907894_F2A4864D X-CRM114-Status: GOOD ( 18.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König Acked-by: Jernej Skrabec --- drivers/phy/allwinner/phy-sun4i-usb.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/phy/allwinner/phy-sun4i-usb.c b/drivers/phy/allwinner/phy-sun4i-usb.c index fbcd7014ab43..6a74e5ce180a 100644 --- a/drivers/phy/allwinner/phy-sun4i-usb.c +++ b/drivers/phy/allwinner/phy-sun4i-usb.c @@ -698,7 +698,7 @@ static struct phy *sun4i_usb_phy_xlate(struct device *dev, return data->phys[args->args[0]].phy; } -static int sun4i_usb_phy_remove(struct platform_device *pdev) +static void sun4i_usb_phy_remove(struct platform_device *pdev) { struct device *dev = &pdev->dev; struct sun4i_usb_phy_data *data = dev_get_drvdata(dev); @@ -711,8 +711,6 @@ static int sun4i_usb_phy_remove(struct platform_device *pdev) devm_free_irq(dev, data->vbus_det_irq, data); cancel_delayed_work_sync(&data->detect); - - return 0; } static const unsigned int sun4i_usb_phy0_cable[] = { @@ -1054,7 +1052,7 @@ MODULE_DEVICE_TABLE(of, sun4i_usb_phy_of_match); static struct platform_driver sun4i_usb_phy_driver = { .probe = sun4i_usb_phy_probe, - .remove = sun4i_usb_phy_remove, + .remove_new = sun4i_usb_phy_remove, .driver = { .of_match_table = sun4i_usb_phy_of_match, .name = "sun4i-usb-phy", From patchwork Tue Mar 7 11:58:35 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13163340 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DBD2CC678D5 for ; Tue, 7 Mar 2023 12:01:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=BNWf738lHV5pWS35njIvx75kcJ4ZV/ndPyztqKh5WGY=; b=0BIjWFiHOPmbWh AS96Hv3ztZuOzWdZfGLGckzi2V8+d/3gyxPWXds3fMn4WnicqejfnjA7OS2PEWdd5dB7/BFUEOuzw GkXfsJ9vs8wlt8gHR3701cF7XtYGJhuSQ0Nk6ac2OgrjJ7IEqO3USrEMYMkpCeLlzAM6IM44FuGga RyQlE1YQ4bDTWBHrySwB3nVHvzS+0ehPNNlJVETP4eYaY8+fSKOY4gHW/bOTCoUFskhl/7iPmJxBR v91aY/kiSj6cFYHqVMygF7qlv7mPjjkqF8DxkShINupNwFbmqUdkFI/zmjF4hM0PAK00MIbK1HIT0 4NyXs86/ecfDH/UEpVzQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pZVzg-00HZnm-3Q; Tue, 07 Mar 2023 12:00:36 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pZVyh-00HZCR-MA for linux-arm-kernel@bombadil.infradead.org; Tue, 07 Mar 2023 11:59:35 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Sender:Reply-To:Content-ID:Content-Description; bh=pv1Kzd5+N+jA6CZ98VqCMtJ36LJsWXt0hzxwgSM3DZg=; b=UiXf5fYHEWKqMPNz4Z+HWuPV7o OPsxx6efI7gjmuSJXKSVl0Oo/tTIJDu2jUbB/+U3i02qVWmBX6peEBQxWAt3iN1ygne5N4jWXw8Z4 5c1/g8p4em1TLHLbNAfS+j80Edc0SmL6WbpHxbSVBHNk9fB1FYAYi2GewFpQA0H9As0ddTm1mLfL+ eC54CHLSJK3euRVY/sf+6+ppqICm4szNagpf61vhKPPwKW5fl2t4iZwbmJ0G5nJ+a1b1Ypx2YmT4Z vXO4kMWQbmUMFThSRJ5kG/dOog0bTAU6KrvKzNosEec1xGAW0gi61Bnwsd1Sja+W8EHu0+eexlpsj XNfzgPlg==; Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by desiato.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pZVyb-00H2AC-1E for linux-arm-kernel@lists.infradead.org; Tue, 07 Mar 2023 11:59:34 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pZVyI-0006Ts-J7; Tue, 07 Mar 2023 12:59:10 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pZVyH-002TF7-Nd; Tue, 07 Mar 2023 12:59:09 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pZVyF-002yiz-9t; Tue, 07 Mar 2023 12:59:07 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Vinod Koul , Kishon Vijay Abraham I , Shawn Guo , Sascha Hauer , Liu Ying Cc: Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 06/31] phy: freescale: phy-fsl-imx8qm-lvds-phy: Convert to platform remove callback returning void Date: Tue, 7 Mar 2023 12:58:35 +0100 Message-Id: <20230307115900.2293120-7-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230307115900.2293120-1-u.kleine-koenig@pengutronix.de> References: <20230307115900.2293120-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1724; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=9gpHIEckggYTyZ3HIlCaCJikgQAfbCSp+a63y0MDM4Y=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBkByaTAkC2kNUdjAdrmyObSMkjKoxMDh66rcgMA bw14mHjebSJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCZAcmkwAKCRDB/BR4rcrs Cb0OB/wJwSxUlUSpn3/T4nIet5SaQGCH0dLdgUpAW6AZMoVY+j56u0cwQXr5Ue49CMVwK4LJyeA UDS35Sw9KxsXcaMeH/UW8BkZRYtkWvFYgqCrEZj4SABoIgaRyezaOphHK52HInzGQhXauoufqkO YSl9500uH1FdnbqWH3aXlfHocGZ6gIGeUDRM/5Ptfa+Y242jJVx7EjOm6Zkrjp8RZ2QOb2pF1yW PeFXUq/e5Kc1FfRFioMtTE0hsnMyR6M+esB66Qm6kAFAIk6dGXOjTiKkYzPSqvWvlXb8firVMwf uoEszAA4QtjXQRwq+dKIYzrCOccPZLQ9GJYstbFusqh1IeNX X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230307_115929_939078_4655073D X-CRM114-Status: GOOD ( 15.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/phy/freescale/phy-fsl-imx8qm-lvds-phy.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/phy/freescale/phy-fsl-imx8qm-lvds-phy.c b/drivers/phy/freescale/phy-fsl-imx8qm-lvds-phy.c index e514b64bfdab..0ae052df3765 100644 --- a/drivers/phy/freescale/phy-fsl-imx8qm-lvds-phy.c +++ b/drivers/phy/freescale/phy-fsl-imx8qm-lvds-phy.c @@ -391,11 +391,9 @@ static int mixel_lvds_phy_probe(struct platform_device *pdev) return ret; } -static int mixel_lvds_phy_remove(struct platform_device *pdev) +static void mixel_lvds_phy_remove(struct platform_device *pdev) { pm_runtime_disable(&pdev->dev); - - return 0; } static int __maybe_unused mixel_lvds_phy_runtime_suspend(struct device *dev) @@ -436,7 +434,7 @@ MODULE_DEVICE_TABLE(of, mixel_lvds_phy_of_match); static struct platform_driver mixel_lvds_phy_driver = { .probe = mixel_lvds_phy_probe, - .remove = mixel_lvds_phy_remove, + .remove_new = mixel_lvds_phy_remove, .driver = { .pm = &mixel_lvds_phy_pm_ops, .name = "mixel-lvds-phy", From patchwork Tue Mar 7 11:58:37 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13163341 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6BB37C678D5 for ; Tue, 7 Mar 2023 12:02:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=lU5Mg8Y9yE4XOw/R2GM7A1vreZdJarEIwByk5R6+beY=; b=bpyMI38LHU0usM DgeFu/vAQSoRB0HTWmajRWCEV6s4LX5sZO3l62wqd2+j71vHE3sndtempOHdJI1u3S5BCnwMGT/bE ToZ/DhUXX9WRv6oVHxFrcnw5ihEYvVXY9vcqM2wB/vEmPr22S1CVysY3yrWlS2XXPWUnA1NJR1AzT Z91MP+UmoAVAbmNK7urTHvCQdOihi1v1vEMTpshazoP+DGkO2rlpJAZKAc5YwK+qD7i0RWrJtQOLm C8HvYwRHp55Uh+qujUyY8Hus4cFZ1tDR/PPk1iUKXSAcWHkXA3EKzR07JvEUYOhhcMam56aAMwbhG uRCjmzEuJcEG7Wl9r7lw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pZVzy-00HZzM-U0; Tue, 07 Mar 2023 12:00:55 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pZVyj-00HZDB-Fk for linux-arm-kernel@bombadil.infradead.org; Tue, 07 Mar 2023 11:59:37 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Sender:Reply-To:Content-ID:Content-Description; bh=o3JcZZBc7GuPqnEJrNQcrbIrqMYPTnYvyRytAwwycKA=; b=RxUi4THflpmE5LxXf7buDxK9OT dpShl7YpMZ+tBt1AkKTyfv2vykpsW1kIljLw4OnYhEWzMBw9VNruAjnZ0RLc7+wT5ElnI6BjdohOO brAp9j6mBg0p+exijqcLahW1eUn5uXQXwDMLYMKmqILOjemwS7/KS+gaOra7gBfWBJuuDu7raUIgj XRTwuO9/+fYrBzMDMaiwK77KuOhgwMw3AJe5NLiRXAcTOIZRD1IDzQg1l7AFqTG97xJybBJlUySdk Y1gfLUP2qhc6WvK3gGFeEoxTqnDPXhm/QngMRvDrnRhZLxMrQWyywAurfKrgaWnHaa1NVlXxnkRUQ o3nRrjKA==; Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by desiato.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pZVyc-00H2AI-0R for linux-arm-kernel@lists.infradead.org; Tue, 07 Mar 2023 11:59:36 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pZVyJ-0006TP-A5; Tue, 07 Mar 2023 12:59:11 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pZVyG-002TEq-KL; Tue, 07 Mar 2023 12:59:08 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pZVyF-002yj7-KN; Tue, 07 Mar 2023 12:59:07 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Chun-Kuang Hu , Philipp Zabel , Chunfeng Yun , Vinod Koul , Kishon Vijay Abraham I , Matthias Brugger Cc: AngeloGioacchino Del Regno , dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-phy@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 08/31] phy: mediatek: phy-mtk-mipi-dsi: Convert to platform remove callback returning void Date: Tue, 7 Mar 2023 12:58:37 +0100 Message-Id: <20230307115900.2293120-9-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230307115900.2293120-1-u.kleine-koenig@pengutronix.de> References: <20230307115900.2293120-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1659; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=OaSKTY4uqDyE/b4P9Kpjn5LpWgMlD/CRSWsvB/MD7Nw=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBkByacJQfciNykwOUJrVNhGA5Nxd2zTC7TCkwZQ 4c8QctKW9SJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCZAcmnAAKCRDB/BR4rcrs CSVVCACQo1k2/vqezM/4H1xRWVHIdvVsDLdfoHThYAyWII3ivZoIokEktT25evY1Znhmyu0nuhw uwLCJgEkYRjZszqxZQhA/fe0I12lZhSesE7LbSnIY6KrtAhkkah6WX3dIe3h0jo9a9NQyn/X9qy vJ84H9UfFtjkQPehl4G/LD5yKO/fq1BBmA4KUM1bIx5HZ0qE4dDZvyf4BbOT1sk1nHEuF9ZquKk m22ixqZB+EqEelFK8wKKBX+IPTa9hVnLK7xXNqVPizdhQNnQR/7zEvsPmtowJNhcfz7PjY2DQz+ b55i6avd4ukF7PdeLPGi92kGTgKYoqzzcOB1rqVzV1uu6BF0 X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230307_115931_419051_59F199DD X-CRM114-Status: GOOD ( 17.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/phy/mediatek/phy-mtk-mipi-dsi.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/phy/mediatek/phy-mtk-mipi-dsi.c b/drivers/phy/mediatek/phy-mtk-mipi-dsi.c index cf9c386385bb..526c05a4af5e 100644 --- a/drivers/phy/mediatek/phy-mtk-mipi-dsi.c +++ b/drivers/phy/mediatek/phy-mtk-mipi-dsi.c @@ -180,10 +180,9 @@ static int mtk_mipi_tx_probe(struct platform_device *pdev) mipi_tx->pll); } -static int mtk_mipi_tx_remove(struct platform_device *pdev) +static void mtk_mipi_tx_remove(struct platform_device *pdev) { of_clk_del_provider(pdev->dev.of_node); - return 0; } static const struct of_device_id mtk_mipi_tx_match[] = { @@ -199,7 +198,7 @@ MODULE_DEVICE_TABLE(of, mtk_mipi_tx_match); static struct platform_driver mtk_mipi_tx_driver = { .probe = mtk_mipi_tx_probe, - .remove = mtk_mipi_tx_remove, + .remove_new = mtk_mipi_tx_remove, .driver = { .name = "mediatek-mipi-tx", .of_match_table = mtk_mipi_tx_match, From patchwork Tue Mar 7 11:58:48 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13163335 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4BDBCC678D4 for ; Tue, 7 Mar 2023 12:00:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=R3JxasRUad9lLOj92Zjvvdx0wFRSjOoeA6stxMOuZIg=; b=Rsl0NmAfSKnGYJ KW5QFjLQrT2ZZhOc3NhakijH6meT5tXQe1f4HOX9v6/0fRV6uEwKk0yiYX32nV+lVIPWDWgeKFRBp XR8K+nLWbtzsOBOcNf7gUU7wKvssOYLyQHBlWlYbxpaZjk+FCO0yqMbapySUqV88YWvJYhsp70INH GHCs4eKOM1RlQaC1El+vYFzWp/7s2B3BEo5jfnflsHMLPvT0gK+2DM9nioFlRzVgKee3laBp/ldRZ LchnRGx2RjM+hmft3hcTqGV6SEajln9zeFy8mDfAjcrZ/ZmMsBz4Jwew8n1KNANq784GsCmki+VO+ 5AwCQdtPYYR+Bf/fJGPA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pZVyY-00HZ5m-Uk; Tue, 07 Mar 2023 11:59:27 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pZVyU-00HZ18-0n for linux-arm-kernel@lists.infradead.org; Tue, 07 Mar 2023 11:59:23 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pZVyK-0006Xr-A1; Tue, 07 Mar 2023 12:59:12 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pZVyJ-002TFt-Bn; Tue, 07 Mar 2023 12:59:11 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pZVyI-002yjl-0C; Tue, 07 Mar 2023 12:59:10 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Vinod Koul , Kishon Vijay Abraham I , Heiko Stuebner Cc: linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 19/31] phy: rockchip: phy-rockchip-inno-csidphy: Convert to platform remove callback returning void Date: Tue, 7 Mar 2023 12:58:48 +0100 Message-Id: <20230307115900.2293120-20-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230307115900.2293120-1-u.kleine-koenig@pengutronix.de> References: <20230307115900.2293120-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1823; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=rKB6vQSyEOcEB6Yn09C9wyfvQ7PzuQTyGnWZzQK5XLU=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBkBybNVprDdkO8rBIC9F9dBj8xmmgLxeNLSySC1 guLTVnTEQmJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCZAcmzQAKCRDB/BR4rcrs CUhmCACPB/d3JbmiA0MSXVBX8o7WtNePiXmVM4dNzpOw2CpLnzx9O7YgLKntZ88orU6AZcfJcKH U163C93zc3dgj3AYyNDH9OT3WQUffx/9qdIUBlfVa7A7qtl4LQfPmzhjvObuGyFwqd2zWQUaxkt JbScAyliEQNn7+oqIuqw0//piqCv0taM9giuMh7oSQHOSju2Cc01TKjb/9wbqNRX4+XCTnA68wP rqfwh1i9GF5mrzcVN0zw8Sfv3UayGPJFibOZYrxE1ZLj+L3KDgNnCeuZwLvxWutgIGuZcnUUrRA k3z7iA9Q76ztl3IncymOw2g1lGHYxEKUGaWYhZCwGdXW2do0 X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230307_035922_110523_E2A672BA X-CRM114-Status: GOOD ( 16.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König Reviewed-by: Heiko Stuebner --- drivers/phy/rockchip/phy-rockchip-inno-csidphy.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/phy/rockchip/phy-rockchip-inno-csidphy.c b/drivers/phy/rockchip/phy-rockchip-inno-csidphy.c index 75f948bdea6a..98c92d6c482f 100644 --- a/drivers/phy/rockchip/phy-rockchip-inno-csidphy.c +++ b/drivers/phy/rockchip/phy-rockchip-inno-csidphy.c @@ -459,13 +459,11 @@ static int rockchip_inno_csidphy_probe(struct platform_device *pdev) return 0; } -static int rockchip_inno_csidphy_remove(struct platform_device *pdev) +static void rockchip_inno_csidphy_remove(struct platform_device *pdev) { struct rockchip_inno_csidphy *priv = platform_get_drvdata(pdev); pm_runtime_disable(priv->dev); - - return 0; } static struct platform_driver rockchip_inno_csidphy_driver = { @@ -474,7 +472,7 @@ static struct platform_driver rockchip_inno_csidphy_driver = { .of_match_table = rockchip_inno_csidphy_match_id, }, .probe = rockchip_inno_csidphy_probe, - .remove = rockchip_inno_csidphy_remove, + .remove_new = rockchip_inno_csidphy_remove, }; module_platform_driver(rockchip_inno_csidphy_driver); From patchwork Tue Mar 7 11:58:49 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13163338 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E09DBC678D4 for ; Tue, 7 Mar 2023 12:01:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YmAoYRTURsfNxSSbIluBD5xarCDdFKvGrC2gau1iqiE=; b=xym389wXGrEGhR e/5sAcUSGWjfnmH4+cXhi1OomzuZB3k2A3/XG0CGRrBjTD46LlPQuuTD//hFspN+iuRmMT7bBHG77 w2d7PomBZdtCK5WRfSjCmYxMOaG8XSsmr1cXD5FB7Qx2tNkD16n6AiTtK6mxqkFRUKkhi12vCy3ZF dYDh/SfVCLHFpm3tRh5EThguNMNciOQ21GFMuSmjH0PxfoQ/NWwAI3e9ah5oLQRwGt/Kvy9pcVj/i QtIZ5b0rfgO4VsnnvAlJ/2kd3JJMs+jizAA+EByXayl3up5POvkF7wvHeQO1cSlF6qj/iDVQtZNN3 Gan/lvMynE0Z87iJSrjw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pZVzA-00HZTA-5R; Tue, 07 Mar 2023 12:00:04 +0000 Received: from metis.ext.pengutronix.de ([85.220.165.71]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pZVyZ-00HZ59-6t for linux-arm-kernel@lists.infradead.org; Tue, 07 Mar 2023 11:59:31 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pZVyK-0006XQ-9l; Tue, 07 Mar 2023 12:59:12 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pZVyJ-002TFm-6X; Tue, 07 Mar 2023 12:59:11 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pZVyI-002yjo-6I; Tue, 07 Mar 2023 12:59:10 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Vinod Koul , Kishon Vijay Abraham I , Heiko Stuebner Cc: linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 20/31] phy: rockchip: phy-rockchip-inno-dsidphy: Convert to platform remove callback returning void Date: Tue, 7 Mar 2023 12:58:49 +0100 Message-Id: <20230307115900.2293120-21-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230307115900.2293120-1-u.kleine-koenig@pengutronix.de> References: <20230307115900.2293120-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1745; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=lehOlgnny9s9YCry74LCGOZ0ZUh8mvbpw5s20/s1D2E=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBkBybRLBReKv+70Ss8u3GHrR3lrh0qQpW+itAX6 fM01umsxBWJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCZAcm0QAKCRDB/BR4rcrs Ca6RCACDNdLE05biV9TVjBa1dw1Ho9bE39CgUqssJyw3KsPPTc/ieVj9irScI+gV4ZCrnG2VA1C PnOsgncF1VGtyqrpDGJ5qody35ck8N2hwL7skAm3UhcGk0RQEVZETeKPXKmbYx0YNgHCsgRoxCY MU7pFmXtlXL545NtYaqX0UymSo1MpUCcG8ImDRxRp1rXL6jpPpYbccpJHLJZ0dkWJ7dOHIqBnts CsZeH7L1nTqVabd3DP12ZuEUcOwo0ibzhzSi2ANKyWvQpzVFKxtLWLlvWEC7ERS9Qf+DGFPs/XE B9vz6+mUnWYCreFafvt6imG75rIrQtQz7F4QI1F9066t4rJK X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230307_035927_370185_00421898 X-CRM114-Status: GOOD ( 16.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König Reviewed-by: Heiko Stuebner --- drivers/phy/rockchip/phy-rockchip-inno-dsidphy.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/phy/rockchip/phy-rockchip-inno-dsidphy.c b/drivers/phy/rockchip/phy-rockchip-inno-dsidphy.c index 2c5847faff63..726928ff1273 100644 --- a/drivers/phy/rockchip/phy-rockchip-inno-dsidphy.c +++ b/drivers/phy/rockchip/phy-rockchip-inno-dsidphy.c @@ -755,13 +755,11 @@ static int inno_dsidphy_probe(struct platform_device *pdev) return 0; } -static int inno_dsidphy_remove(struct platform_device *pdev) +static void inno_dsidphy_remove(struct platform_device *pdev) { struct inno_dsidphy *inno = platform_get_drvdata(pdev); pm_runtime_disable(inno->dev); - - return 0; } static const struct of_device_id inno_dsidphy_of_match[] = { @@ -788,7 +786,7 @@ static struct platform_driver inno_dsidphy_driver = { .of_match_table = of_match_ptr(inno_dsidphy_of_match), }, .probe = inno_dsidphy_probe, - .remove = inno_dsidphy_remove, + .remove_new = inno_dsidphy_remove, }; module_platform_driver(inno_dsidphy_driver); From patchwork Tue Mar 7 11:58:50 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13163342 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 66450C678D4 for ; Tue, 7 Mar 2023 12:02:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=pcwvpPRy1OZD1S+Jd286ybopxO9fxx6aEaDgWiuEKGU=; b=mHnumBfT1VhqpJ INiTnwHlV1YLEYzBEVVDsLLeHY51cgblLdz2k8d5AgHNnyAlsU+EoVsvzefurT5ZEzhteKhVpSs7N v/TQJCl3WzmGNh3ciRX07BZXrRvj3o4sWEhgQO88/P9nSPfS5NEyLXGC43pCj7bKIELIjFXvrr4Ha f3rN7njfCyMeQdQI+KTp4gJDnKgX5Qq2nrefxZxb0v3v5u6z+FCVotdIVT80sRugRxcOCDfvHKrvu HAfzsezdYS6zGGD6nei2C0NQU/xA7a+zn6hYPrCLuzLvkCnxizI5E/wkwWB6HIlQBu9TT0CE9r0uz uSwxE8LFb5RtgdNw8DBQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pZW0c-00HaSH-Pm; Tue, 07 Mar 2023 12:01:34 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pZW04-00Ha4E-I2 for linux-arm-kernel@bombadil.infradead.org; Tue, 07 Mar 2023 12:01:00 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Sender:Reply-To:Content-ID:Content-Description; bh=onb1JSlRGVBMi1lyM26mvVKI+STrAZUksnVmp3nLwcc=; b=HXkStfdbuiTBiNo7RWR7JQTXBk RWp5b5aUIp0/AYSaRDbLym9WFNHHsJjx6QhM39z1nxSR6nx1Ivi8Q5615Yj5oWsB4/OIhYEoGZwgs WsUcKKA7Tvo7EOJDmeadfW0gEryAWgyEpt3mBQpiW3GmcKC5d59uGYv5/IHPVaRlqB8SBBLE1EXmS 9N95ncpmh0ujpdtHXFM0xw5sPZ6OJ8F7XIZ6eASjGE/6bglxMcgavQejUN2+wK2U2wSRv8iQC7h0k 0YBacgH1e9nrUea8KjTqFL8zkcpmz0OU0CPSv70OLPd0NHGDYvqbCKXywsFsN/A3qq0tBJtx8zzjU RigKS27g==; Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by desiato.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pZVyZ-00H2A6-2w for linux-arm-kernel@lists.infradead.org; Tue, 07 Mar 2023 12:00:59 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pZVyK-0006Zc-Hn; Tue, 07 Mar 2023 12:59:12 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pZVyJ-002TG5-Qk; Tue, 07 Mar 2023 12:59:11 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pZVyI-002yjt-D5; Tue, 07 Mar 2023 12:59:10 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Vinod Koul , Kishon Vijay Abraham I , Heiko Stuebner Cc: linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 21/31] phy: rockchip: phy-rockchip-inno-hdmi: Convert to platform remove callback returning void Date: Tue, 7 Mar 2023 12:58:50 +0100 Message-Id: <20230307115900.2293120-22-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230307115900.2293120-1-u.kleine-koenig@pengutronix.de> References: <20230307115900.2293120-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1741; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=aTRs7YiQ1a+7kK0P1WOZZiXEEjnBAy1vmBRa+WG7UPE=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBkBybV3L1Dd9AGvegJYwUQZ5NxkwVVEGm6pZSsb LzqF38wCSiJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCZAcm1QAKCRDB/BR4rcrs CWIxCACcWZnkd/l9nWEAp/E6XOnXQklrsB5Szy/o/BxNY+Jmd1pDG5nsSsCq5zcLd8//GsGZpqV YpBlpqd+sq4BecUPOFSp/UfxqrJoa6GbgtiNnssv5vF5pE6MJp6Iu/qbAP4u1oJ5yeuouW8FODv 1HJlz6AAkdakrQB+llwS7QF9OtCtaY9PhjHVYv9thSK0EdXZDB5abHZERQVy/xRaFwln1Ikji6/ sSK7bSIGYfhnZZJSKnfypGFYkhxysYcKt2YunaPbME1EW/kbr+I0UddaIYhqSjMmXIlHfYGfo2K mjUrvgga7sk0qzjo0VpZJ6iO2BiQJ8InJJPsfRdNhUVHp6aI X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230307_115928_463897_152B9B13 X-CRM114-Status: GOOD ( 16.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König Reviewed-by: Heiko Stuebner --- drivers/phy/rockchip/phy-rockchip-inno-hdmi.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/phy/rockchip/phy-rockchip-inno-hdmi.c b/drivers/phy/rockchip/phy-rockchip-inno-hdmi.c index 80acca4e9e14..1e1563f5fffc 100644 --- a/drivers/phy/rockchip/phy-rockchip-inno-hdmi.c +++ b/drivers/phy/rockchip/phy-rockchip-inno-hdmi.c @@ -1246,11 +1246,9 @@ static int inno_hdmi_phy_probe(struct platform_device *pdev) return PTR_ERR_OR_ZERO(phy_provider); } -static int inno_hdmi_phy_remove(struct platform_device *pdev) +static void inno_hdmi_phy_remove(struct platform_device *pdev) { of_clk_del_provider(pdev->dev.of_node); - - return 0; } static const struct of_device_id inno_hdmi_phy_of_match[] = { @@ -1266,7 +1264,7 @@ MODULE_DEVICE_TABLE(of, inno_hdmi_phy_of_match); static struct platform_driver inno_hdmi_phy_driver = { .probe = inno_hdmi_phy_probe, - .remove = inno_hdmi_phy_remove, + .remove_new = inno_hdmi_phy_remove, .driver = { .name = "inno-hdmi-phy", .of_match_table = inno_hdmi_phy_of_match, From patchwork Tue Mar 7 11:58:51 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13163336 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A31CFC678D5 for ; Tue, 7 Mar 2023 12:00:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tvnWMEBYy2qert2MUuvQ/bKslOVWOHfAOnvYQ4s7tcc=; b=yUoli4matHebEI YUIjqFRz77Q7jOy8ocJf9Z/9j2kLeuguRyBKiKVgXNjrbmTDPQHsAYDSYypDRWCwJNLgGB1AIuT9+ 5Mbgj/OLTydBYTYf5tVeaMkMT1hKBO4Q8rdCHBMWJbq0c6ZZjnrsTtw+3o39m30fClHaRcCCfMTfb sOVh4sLHoo/RTuEPElSmANeObySSSj6qUVQxmwGyBhGfyPHMWpD0lUr+f+d7QpzsmDw6q7tqa7hme TmWJuP7loV1IVw9cRbewHVahdME3PHOrLSjDQdC9l9x6ajFfXPs1Ca6308Dd1wY5kNqi+5XQIaU8I N4RvhVGC1VrNGdLDyhVg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pZVyq-00HZHr-Kk; Tue, 07 Mar 2023 11:59:44 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pZVyV-00HZ0x-N2 for linux-arm-kernel@lists.infradead.org; Tue, 07 Mar 2023 11:59:28 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pZVyK-0006Ze-IP; Tue, 07 Mar 2023 12:59:12 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pZVyJ-002TG6-RJ; Tue, 07 Mar 2023 12:59:11 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pZVyI-002yjy-JL; Tue, 07 Mar 2023 12:59:10 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Vinod Koul , Kishon Vijay Abraham I , Heiko Stuebner Cc: linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 22/31] phy: rockchip: phy-rockchip-typec: Convert to platform remove callback returning void Date: Tue, 7 Mar 2023 12:58:51 +0100 Message-Id: <20230307115900.2293120-23-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230307115900.2293120-1-u.kleine-koenig@pengutronix.de> References: <20230307115900.2293120-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1736; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=0SUGPfok3tQB4A0ITBzAkq4+prG7Ts411Ut+16Tw0IY=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBkBybZ3YLBj5r2BWZEkEDfzAu3GR/hqL/rVcKar qszkPo4OieJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCZAcm2QAKCRDB/BR4rcrs CVYRB/9Y6kEMwwc/lyj4lQFyg9u4AFHjGIytRfG/uKS97fyy268AEkXOwu3jdYyJOd098l83jlC dP27PQ/qan4BjOFD6aoE72dEM7RHOxGOCpDE/diW8jWXzaAKXcvQAOznfeLhkCua8X9vpq+krTz zFAAC1Z9+Rcy1fLoCLECi9GEyhFGSzEUEt7MVRLf51HZIECkQ3SM0qHOZCx1wMsLgQlHjJrLJJ1 SMayPApQxFYNy+j8mZpZu4jrBYQ30yKOW7VLn0DsNDwEE0tLsYzxLkWDHInKol8+0ylg/yz3fzd 2qAK2ITRskiLBgXAJFi4RZA43O0N2q7+vAaerwdu8CgQiwEb X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230307_035923_775214_C870F79C X-CRM114-Status: GOOD ( 16.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König Reviewed-by: Heiko Stuebner --- drivers/phy/rockchip/phy-rockchip-typec.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/phy/rockchip/phy-rockchip-typec.c b/drivers/phy/rockchip/phy-rockchip-typec.c index 39db8acde61a..8b1667be4915 100644 --- a/drivers/phy/rockchip/phy-rockchip-typec.c +++ b/drivers/phy/rockchip/phy-rockchip-typec.c @@ -1194,11 +1194,9 @@ static int rockchip_typec_phy_probe(struct platform_device *pdev) return 0; } -static int rockchip_typec_phy_remove(struct platform_device *pdev) +static void rockchip_typec_phy_remove(struct platform_device *pdev) { pm_runtime_disable(&pdev->dev); - - return 0; } static const struct of_device_id rockchip_typec_phy_dt_ids[] = { @@ -1213,7 +1211,7 @@ MODULE_DEVICE_TABLE(of, rockchip_typec_phy_dt_ids); static struct platform_driver rockchip_typec_phy_driver = { .probe = rockchip_typec_phy_probe, - .remove = rockchip_typec_phy_remove, + .remove_new = rockchip_typec_phy_remove, .driver = { .name = "rockchip-typec-phy", .of_match_table = rockchip_typec_phy_dt_ids, From patchwork Tue Mar 7 11:58:52 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13163337 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 115FAC678D4 for ; Tue, 7 Mar 2023 12:00:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=sElf/1igCHcOqqN3fU8ajH5XSpgL/hcXSAsKzrVGWvc=; b=vpp3j+JEVq/SIt 740arqKlYzGUkPWqAmc/CesQ22P7j+dwe1+u+05zxOtS0brY18rWihrtdLe06ONtP5gUCyub0bdQo JlsgY2Ocwe+uxKdIBXIOJxhUZ1z1IDVJM7BE0IZmdmfwq7pA/gKNt+upPZKBauRIuiXR6MF0+2OUw p8KyKx4qUcY4FTXfDnXJag9tPrlM4jw/4yCdKZF7CZnmz2YTtW87tWSF0c5w82oF1hr07TdyRVjrb q+9Xlgn+cd/tGyRjlJJCF6zXF80U5dG7hI/yc9VdR/9qgfkmcUr9vhD/F7nMrSTWsj4FamxH01Dvq hoe0kBmGEvH5ErOR29Hw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pZVz0-00HZNc-CG; Tue, 07 Mar 2023 11:59:54 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pZVyY-00HZ5u-KY for linux-arm-kernel@lists.infradead.org; Tue, 07 Mar 2023 11:59:29 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pZVyL-0006Zh-9v; Tue, 07 Mar 2023 12:59:13 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pZVyJ-002TG9-T3; Tue, 07 Mar 2023 12:59:11 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pZVyI-002yk2-QP; Tue, 07 Mar 2023 12:59:10 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Vinod Koul , Kishon Vijay Abraham I , Maxime Coquelin , Alexandre Torgue , Amelie Delaunay , Dan Carpenter , Fabrice Gasnier Cc: linux-phy@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 23/31] phy: st: phy-stm32-usbphyc: Convert to platform remove callback returning void Date: Tue, 7 Mar 2023 12:58:52 +0100 Message-Id: <20230307115900.2293120-24-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230307115900.2293120-1-u.kleine-koenig@pengutronix.de> References: <20230307115900.2293120-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1863; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=nLjrzhFMDWv8vjI/TpGtzSepyHgqVbB8jO7N9V2rgSw=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBkBybdOJzEP8Mob8O1vUcByQ02bBPElIp2nyn3N cOH8KuWARqJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCZAcm3QAKCRDB/BR4rcrs CSImB/0QNjaVQMfaMmv9zoXO2BF5RJ3RtN4ps6lvW09LJnzFzRScIA1pFNDkn2wLqVhrjPTw4IG 7C7uLxIgU1BMy6fWqpkzjRR8ztgrR/+4885Xngv6Yin0x4mAZcI51zgj7mUz4WvI0FNOvWtyg2i 8aMlJ9VIVEL+R8V3GSGZtTvp3V2IWr5peSxD5iYBlnO0MKww2BjLi3PJqyhIZatKMRZH1sZkM1i KAIku6iysvLYWW5wmdt7fwol1ypU9gWEljfdc8u4tsMtvxB0Rz53bLPNf1Vx/3QIv66bVlx8m39 lehCOOGjr+SF1YsUORJO+CwfDq04HMMLZFKVw/sPPBT96XgM X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230307_035926_709151_49C7C60A X-CRM114-Status: GOOD ( 16.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/phy/st/phy-stm32-usbphyc.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/phy/st/phy-stm32-usbphyc.c b/drivers/phy/st/phy-stm32-usbphyc.c index 5bb9647b078f..1add3b75f92f 100644 --- a/drivers/phy/st/phy-stm32-usbphyc.c +++ b/drivers/phy/st/phy-stm32-usbphyc.c @@ -766,7 +766,7 @@ static int stm32_usbphyc_probe(struct platform_device *pdev) return ret; } -static int stm32_usbphyc_remove(struct platform_device *pdev) +static void stm32_usbphyc_remove(struct platform_device *pdev) { struct stm32_usbphyc *usbphyc = dev_get_drvdata(&pdev->dev); int port; @@ -779,8 +779,6 @@ static int stm32_usbphyc_remove(struct platform_device *pdev) stm32_usbphyc_clk48_unregister(usbphyc); clk_disable_unprepare(usbphyc->clk); - - return 0; } static int __maybe_unused stm32_usbphyc_resume(struct device *dev) @@ -810,7 +808,7 @@ MODULE_DEVICE_TABLE(of, stm32_usbphyc_of_match); static struct platform_driver stm32_usbphyc_driver = { .probe = stm32_usbphyc_probe, - .remove = stm32_usbphyc_remove, + .remove_new = stm32_usbphyc_remove, .driver = { .of_match_table = stm32_usbphyc_of_match, .name = "stm32-usbphyc",