From patchwork Tue Mar 7 18:19:12 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Helgaas X-Patchwork-Id: 13164430 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D3A0C678D5 for ; Tue, 7 Mar 2023 18:24:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231857AbjCGSY5 (ORCPT ); Tue, 7 Mar 2023 13:24:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47054 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232792AbjCGSYU (ORCPT ); Tue, 7 Mar 2023 13:24:20 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B6C639CBF7; Tue, 7 Mar 2023 10:19:59 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4EFAD6150F; Tue, 7 Mar 2023 18:19:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 72D34C433EF; Tue, 7 Mar 2023 18:19:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678213198; bh=5kyhbiBEtsJwMz5HCmxLv5VbTa4UdxUccaqPgY32uh8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=cS8ss2GpmOsDF5I8H1FALF4fgvR6vvWwMqBHwvoV3rPKwozyXYj68u9hukliqEYYf 5jliPnkvObXjJfS9jAbwiRZjSo4uSmwl51bZ/MscD5jUX2OfIO8ZHO5oiycrusfGas 8LKp++6SWDThELLs28W4YQzIGNrONDflbIdpmjGHzgshsK+3W+xLQXtAu6mGTr7A4t uHlbk0k5/nkXIo2TBpUQCp8bWwVSV2xaBjoX1OjXzCiky4nA2m1zO/T7XCmnSyvnaM RfeBDqkSsq4v/LKL5eUXGNKXXUdUMnfZhQEPQcqcYOyEGEOdMoK1yWGAzpKgAGcWW2 FpzmLQ4AyAT4w== From: Bjorn Helgaas To: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Helgaas , Chris Snook Subject: [PATCH 01/28] alx: Drop redundant pci_enable_pcie_error_reporting() Date: Tue, 7 Mar 2023 12:19:12 -0600 Message-Id: <20230307181940.868828-2-helgaas@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230307181940.868828-1-helgaas@kernel.org> References: <20230307181940.868828-1-helgaas@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org From: Bjorn Helgaas pci_enable_pcie_error_reporting() enables the device to send ERR_* Messages. Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is native"), the PCI core does this for all devices during enumeration, so the driver doesn't need to do it itself. Remove the redundant pci_enable_pcie_error_reporting() call from the driver. Also remove the corresponding pci_disable_pcie_error_reporting() from the driver .remove() path. Note that this only controls ERR_* Messages from the device. An ERR_* Message may cause the Root Port to generate an interrupt, depending on the AER Root Error Command register managed by the AER service driver. Signed-off-by: Bjorn Helgaas Cc: Chris Snook --- drivers/net/ethernet/atheros/alx/main.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/net/ethernet/atheros/alx/main.c b/drivers/net/ethernet/atheros/alx/main.c index 306393f8eeca..49bb9a8f00e6 100644 --- a/drivers/net/ethernet/atheros/alx/main.c +++ b/drivers/net/ethernet/atheros/alx/main.c @@ -39,7 +39,6 @@ #include #include #include -#include #include #include #include @@ -1745,7 +1744,6 @@ static int alx_probe(struct pci_dev *pdev, const struct pci_device_id *ent) goto out_pci_disable; } - pci_enable_pcie_error_reporting(pdev); pci_set_master(pdev); if (!pdev->pm_cap) { @@ -1879,7 +1877,6 @@ static int alx_probe(struct pci_dev *pdev, const struct pci_device_id *ent) free_netdev(netdev); out_pci_release: pci_release_mem_regions(pdev); - pci_disable_pcie_error_reporting(pdev); out_pci_disable: pci_disable_device(pdev); return err; @@ -1897,7 +1894,6 @@ static void alx_remove(struct pci_dev *pdev) iounmap(hw->hw_addr); pci_release_mem_regions(pdev); - pci_disable_pcie_error_reporting(pdev); pci_disable_device(pdev); mutex_destroy(&alx->mtx); From patchwork Tue Mar 7 18:19:13 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Helgaas X-Patchwork-Id: 13164431 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6896EC6FD1A for ; Tue, 7 Mar 2023 18:25:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232764AbjCGSY7 (ORCPT ); Tue, 7 Mar 2023 13:24:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47100 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232701AbjCGSY3 (ORCPT ); Tue, 7 Mar 2023 13:24:29 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 62D219F22D; Tue, 7 Mar 2023 10:20:03 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 0B39EB819C8; Tue, 7 Mar 2023 18:20:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7B0A3C433EF; Tue, 7 Mar 2023 18:20:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678213200; bh=uTSSQxN9Ng89FUpnr+qHDi5OyXYmSr64uBuRSG1WJSY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=SbpnB4++dC2O5b7l/RR11xhePxpzE7uV9WOux3IBs5PRDdEqsIcBIpPzAlMjXEmh7 bt+R34c2CM4D0fLxRhk5mhqxWOH3CW5rL3Zcrl/8okxDnZEztLGOUACTmX+3cBgc7c s3/QXb2hOWYjmHvnFpRRg6g+1IpTKItbJ+DImYpou7I++PYWNlFKKodlpFAoe4Sqjl s0h1sg0p1VaZZlSv8KMKs204F9qp98dcbK1gyKNtPjeDY+yqDtbD/K29TDnbd3AvtX +xIwxrE6riRQVGm+EtwRsfzR3dE/6eXKcOcFtY6ULL8e7Q0v70ZsOjLy/C5ULg1aNX CmbNtwUaAcPBw== From: Bjorn Helgaas To: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Helgaas , Ajit Khaparde , Sriharsha Basavapatna , Somnath Kotur Subject: [PATCH 02/28] be2net: Drop redundant pci_enable_pcie_error_reporting() Date: Tue, 7 Mar 2023 12:19:13 -0600 Message-Id: <20230307181940.868828-3-helgaas@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230307181940.868828-1-helgaas@kernel.org> References: <20230307181940.868828-1-helgaas@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org From: Bjorn Helgaas pci_enable_pcie_error_reporting() enables the device to send ERR_* Messages. Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is native"), the PCI core does this for all devices during enumeration, so the driver doesn't need to do it itself. Remove the redundant pci_enable_pcie_error_reporting() call from the driver. Also remove the corresponding pci_disable_pcie_error_reporting() from the driver .remove() path. Note that this only controls ERR_* Messages from the device. An ERR_* Message may cause the Root Port to generate an interrupt, depending on the AER Root Error Command register managed by the AER service driver. Signed-off-by: Bjorn Helgaas Cc: Ajit Khaparde Cc: Sriharsha Basavapatna Cc: Somnath Kotur --- drivers/net/ethernet/emulex/benet/be_main.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/drivers/net/ethernet/emulex/benet/be_main.c b/drivers/net/ethernet/emulex/benet/be_main.c index 46fe3d74e2e9..aed1b622f51f 100644 --- a/drivers/net/ethernet/emulex/benet/be_main.c +++ b/drivers/net/ethernet/emulex/benet/be_main.c @@ -16,7 +16,6 @@ #include "be.h" #include "be_cmds.h" #include -#include #include #include #include @@ -5726,8 +5725,6 @@ static void be_remove(struct pci_dev *pdev) be_unmap_pci_bars(adapter); be_drv_cleanup(adapter); - pci_disable_pcie_error_reporting(pdev); - pci_release_regions(pdev); pci_disable_device(pdev); @@ -5845,10 +5842,6 @@ static int be_probe(struct pci_dev *pdev, const struct pci_device_id *pdev_id) goto free_netdev; } - status = pci_enable_pcie_error_reporting(pdev); - if (!status) - dev_info(&pdev->dev, "PCIe error reporting enabled\n"); - status = be_map_pci_bars(adapter); if (status) goto free_netdev; @@ -5893,7 +5886,6 @@ static int be_probe(struct pci_dev *pdev, const struct pci_device_id *pdev_id) unmap_bars: be_unmap_pci_bars(adapter); free_netdev: - pci_disable_pcie_error_reporting(pdev); free_netdev(netdev); rel_reg: pci_release_regions(pdev); From patchwork Tue Mar 7 18:19:14 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Helgaas X-Patchwork-Id: 13164433 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7DA5C678DB for ; Tue, 7 Mar 2023 18:25:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232509AbjCGSZC (ORCPT ); Tue, 7 Mar 2023 13:25:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47474 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232430AbjCGSYb (ORCPT ); Tue, 7 Mar 2023 13:24:31 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9DCE39F230; Tue, 7 Mar 2023 10:20:03 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2546B61501; Tue, 7 Mar 2023 18:20:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5F9F9C4339B; Tue, 7 Mar 2023 18:20:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678213202; bh=gyAIiE+ZKIR9obu+1KTy/40lPs3yvZTMSEbedscpsvs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=RKSnXDxrYqcm+9W1g2vCqvRqRSNH1I2Rw2s/rXg/QlZTV197yJLGV9jB3m96UNT9V ii7nhEChM/lBK4ZpvoZygFd8qW89tkLA/FSJVw0xekI7Ayh6ynfUSYX2app24FjcBb ksVnOUWMc4Sc7GUwMJktiqams1nI956RCbcfyk9L3TbVg3HTKqSweLa3StBA2MuRwl tSnZMvKjkHT41b6Lq75JE/5lnVkvvRJFeUZL/Ec2mOKVLb0w3cJZicvrzbFgiVrF/m M8iHkYt99ckHEnZHcoCHtI858pdhcYuV6UpzOLWhzJTxOHn6TA0Ci9MBN9BL/u4SyX N9oK60FRDOybw== From: Bjorn Helgaas To: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Helgaas , Rasesh Mody , GR-Linux-NIC-Dev@marvell.com, Michael Chan Subject: [PATCH 03/28] bnx2: Drop redundant pci_enable_pcie_error_reporting() Date: Tue, 7 Mar 2023 12:19:14 -0600 Message-Id: <20230307181940.868828-4-helgaas@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230307181940.868828-1-helgaas@kernel.org> References: <20230307181940.868828-1-helgaas@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org From: Bjorn Helgaas pci_enable_pcie_error_reporting() enables the device to send ERR_* Messages. Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is native"), the PCI core does this for all devices during enumeration, so the driver doesn't need to do it itself. Remove the redundant pci_enable_pcie_error_reporting() call from the driver. Also remove the corresponding pci_disable_pcie_error_reporting() from the driver .remove() path. Note that this only controls ERR_* Messages from the device. An ERR_* Message may cause the Root Port to generate an interrupt, depending on the AER Root Error Command register managed by the AER service driver. cd709aa90648 ("bnx2: Add PCI Advanced Error Reporting support.") added pci_enable_pcie_error_reporting() for all devices, and c239f279e571 ("bnx2: Enable AER on PCIE devices only") restricted it to BNX2_CHIP_5709 devices to avoid an error message when it failed on non-PCIe devices. The PCI core only enables PCIe error reporting on PCIe devices, which I assume means BNX2_CHIP_5709. Signed-off-by: Bjorn Helgaas Cc: Rasesh Mody Cc: GR-Linux-NIC-Dev@marvell.com Cc: Michael Chan Reviewed-by: Michael Chan --- drivers/net/ethernet/broadcom/bnx2.c | 21 --------------------- drivers/net/ethernet/broadcom/bnx2.h | 1 - 2 files changed, 22 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnx2.c b/drivers/net/ethernet/broadcom/bnx2.c index 9f473854b0f4..a66137b8d1a6 100644 --- a/drivers/net/ethernet/broadcom/bnx2.c +++ b/drivers/net/ethernet/broadcom/bnx2.c @@ -48,7 +48,6 @@ #include #include #include -#include #include #if IS_ENABLED(CONFIG_CNIC) @@ -8093,7 +8092,6 @@ bnx2_init_board(struct pci_dev *pdev, struct net_device *dev) int rc, i, j; u32 reg; u64 dma_mask, persist_dma_mask; - int err; SET_NETDEV_DEV(dev, &pdev->dev); bp = netdev_priv(dev); @@ -8176,12 +8174,6 @@ bnx2_init_board(struct pci_dev *pdev, struct net_device *dev) bp->flags |= BNX2_FLAG_PCIE; if (BNX2_CHIP_REV(bp) == BNX2_CHIP_REV_Ax) bp->flags |= BNX2_FLAG_JUMBO_BROKEN; - - /* AER (Advanced Error Reporting) hooks */ - err = pci_enable_pcie_error_reporting(pdev); - if (!err) - bp->flags |= BNX2_FLAG_AER_ENABLED; - } else { bp->pcix_cap = pci_find_capability(pdev, PCI_CAP_ID_PCIX); if (bp->pcix_cap == 0) { @@ -8460,11 +8452,6 @@ bnx2_init_board(struct pci_dev *pdev, struct net_device *dev) return 0; err_out_unmap: - if (bp->flags & BNX2_FLAG_AER_ENABLED) { - pci_disable_pcie_error_reporting(pdev); - bp->flags &= ~BNX2_FLAG_AER_ENABLED; - } - pci_iounmap(pdev, bp->regview); bp->regview = NULL; @@ -8638,11 +8625,6 @@ bnx2_remove_one(struct pci_dev *pdev) bnx2_free_stats_blk(dev); kfree(bp->temp_stats_blk); - if (bp->flags & BNX2_FLAG_AER_ENABLED) { - pci_disable_pcie_error_reporting(pdev); - bp->flags &= ~BNX2_FLAG_AER_ENABLED; - } - bnx2_release_firmware(bp); free_netdev(dev); @@ -8766,9 +8748,6 @@ static pci_ers_result_t bnx2_io_slot_reset(struct pci_dev *pdev) } rtnl_unlock(); - if (!(bp->flags & BNX2_FLAG_AER_ENABLED)) - return result; - return result; } diff --git a/drivers/net/ethernet/broadcom/bnx2.h b/drivers/net/ethernet/broadcom/bnx2.h index a09ec47461c9..315b08c64edd 100644 --- a/drivers/net/ethernet/broadcom/bnx2.h +++ b/drivers/net/ethernet/broadcom/bnx2.h @@ -6808,7 +6808,6 @@ struct bnx2 { #define BNX2_FLAG_JUMBO_BROKEN 0x00000800 #define BNX2_FLAG_CAN_KEEP_VLAN 0x00001000 #define BNX2_FLAG_BROKEN_STATS 0x00002000 -#define BNX2_FLAG_AER_ENABLED 0x00004000 struct bnx2_napi bnx2_napi[BNX2_MAX_MSIX_VEC]; From patchwork Tue Mar 7 18:19:15 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Helgaas X-Patchwork-Id: 13164434 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63C80C6FD1E for ; Tue, 7 Mar 2023 18:25:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232756AbjCGSZD (ORCPT ); Tue, 7 Mar 2023 13:25:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49694 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232539AbjCGSYc (ORCPT ); Tue, 7 Mar 2023 13:24:32 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 733F4960A4; Tue, 7 Mar 2023 10:20:05 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 030C56153E; Tue, 7 Mar 2023 18:20:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 383BBC433D2; Tue, 7 Mar 2023 18:20:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678213204; bh=GFoO0oJn14FI99xGEuLIehsG9zk7o7c2DkNHWJzWB+Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=S/3da3zWVpPbxUf6yK383AW4n7voT7UkVrzUBG1yePxcG71xF+bZWqbxVYKFa/zER co4JB2E6RO7gucVXCoz7RX+3jS5rjC6yCEql6bEMYs2och0iCRje1SXAOXbfOFoCbN KlEpJIrisGullr47AMhNaa4D17cChRSmJ2bbTRcsvwTlUIWBTgKY+VNEPpl0/Z4sQG HgDy5agjCxq0oFAbQ0NNJUvtKVLAACl2frduZg30qoz65225gzDQk2a8x14Q6pA1JB x+z7oZohHNX4qRK041xosrZWP7+xqg3eANx3QUloouXwchHy9cUwNlGHh298qQdtam j29u4lgi4qmiA== From: Bjorn Helgaas To: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Helgaas , Ariel Elior , Sudarsana Kalluru , Manish Chopra Subject: [PATCH 04/28] bnx2x: Drop redundant pci_enable_pcie_error_reporting() Date: Tue, 7 Mar 2023 12:19:15 -0600 Message-Id: <20230307181940.868828-5-helgaas@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230307181940.868828-1-helgaas@kernel.org> References: <20230307181940.868828-1-helgaas@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org From: Bjorn Helgaas pci_enable_pcie_error_reporting() enables the device to send ERR_* Messages. Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is native"), the PCI core does this for all devices during enumeration, so the driver doesn't need to do it itself. Remove the redundant pci_enable_pcie_error_reporting() call from the driver. Also remove the corresponding pci_disable_pcie_error_reporting() from the driver .remove() path. Note that this only controls ERR_* Messages from the device. An ERR_* Message may cause the Root Port to generate an interrupt, depending on the AER Root Error Command register managed by the AER service driver. Signed-off-by: Bjorn Helgaas Cc: Ariel Elior Cc: Sudarsana Kalluru Cc: Manish Chopra --- drivers/net/ethernet/broadcom/bnx2x/bnx2x.h | 1 - .../net/ethernet/broadcom/bnx2x/bnx2x_main.c | 19 ------------------- 2 files changed, 20 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x.h b/drivers/net/ethernet/broadcom/bnx2x/bnx2x.h index dd5945c4bfec..8bcde0a6e011 100644 --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x.h +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x.h @@ -1486,7 +1486,6 @@ struct bnx2x { #define IS_VF_FLAG (1 << 22) #define BC_SUPPORTS_RMMOD_CMD (1 << 23) #define HAS_PHYS_PORT_ID (1 << 24) -#define AER_ENABLED (1 << 25) #define PTP_SUPPORTED (1 << 26) #define TX_TIMESTAMPING_EN (1 << 27) diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c index 5d1e4fe335aa..3bb5ea570c87 100644 --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c @@ -29,7 +29,6 @@ #include #include #include -#include #include #include #include @@ -13037,14 +13036,6 @@ static const struct net_device_ops bnx2x_netdev_ops = { .ndo_features_check = bnx2x_features_check, }; -static void bnx2x_disable_pcie_error_reporting(struct bnx2x *bp) -{ - if (bp->flags & AER_ENABLED) { - pci_disable_pcie_error_reporting(bp->pdev); - bp->flags &= ~AER_ENABLED; - } -} - static int bnx2x_init_dev(struct bnx2x *bp, struct pci_dev *pdev, struct net_device *dev, unsigned long board_type) { @@ -13157,13 +13148,6 @@ static int bnx2x_init_dev(struct bnx2x *bp, struct pci_dev *pdev, /* Set PCIe reset type to fundamental for EEH recovery */ pdev->needs_freset = 1; - /* AER (Advanced Error reporting) configuration */ - rc = pci_enable_pcie_error_reporting(pdev); - if (!rc) - bp->flags |= AER_ENABLED; - else - BNX2X_DEV_INFO("Failed To configure PCIe AER [%d]\n", rc); - /* * Clean the following indirect addresses for all functions since it * is not used by the driver. @@ -14020,8 +14004,6 @@ static int bnx2x_init_one(struct pci_dev *pdev, bnx2x_free_mem_bp(bp); init_one_exit: - bnx2x_disable_pcie_error_reporting(bp); - if (bp->regview) iounmap(bp->regview); @@ -14102,7 +14084,6 @@ static void __bnx2x_remove(struct pci_dev *pdev, pci_set_power_state(pdev, PCI_D3hot); } - bnx2x_disable_pcie_error_reporting(bp); if (remove_netdev) { if (bp->regview) iounmap(bp->regview); From patchwork Tue Mar 7 18:19:16 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Helgaas X-Patchwork-Id: 13164435 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B134C678D4 for ; Tue, 7 Mar 2023 18:25:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232876AbjCGSZH (ORCPT ); Tue, 7 Mar 2023 13:25:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48618 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232802AbjCGSYd (ORCPT ); Tue, 7 Mar 2023 13:24:33 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B32F59FE4F; Tue, 7 Mar 2023 10:20:08 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 6F368B819C2; Tue, 7 Mar 2023 18:20:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 03A1DC4339C; Tue, 7 Mar 2023 18:20:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678213206; bh=s4Z5SneGnLA3UHvVIg+sNkMWzINirxbbbRYKROhaFH4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=pjGP5Jg36iyH9IhbzJWBKbfbXiU8B9+cX9V081gQ8GNKQcA/rBHOculzG3oa1Le2z Hjurwn2jwQhwbTcU7a5DzP9VhFblvGKOzEBZBdMkNobvrUF1PgL9Mq0p8jsqfIYL8L H7ufXLnqZqO3nNnTQhQpZ2w8enoH6ZTKiZ4sOFrvx6qE0qtUW5IYZ7/RQiWC3d+OQZ hr0HZ3xsxSg8AKBjsZhBmOI0ve/gva2rh7c5j+BZ1TOXMjQl+00ilKfqe0gb2kY3U9 E5ZnBsoKpzMbxMjG4ETwOqEAnEhAOhqTxm1GUl9HTa9hvbX8CRVDOBnt9fHTGMlurW 3Db4aSDT9eEfA== From: Bjorn Helgaas To: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Helgaas , Michael Chan Subject: [PATCH 05/28] bnxt: Drop redundant pci_enable_pcie_error_reporting() Date: Tue, 7 Mar 2023 12:19:16 -0600 Message-Id: <20230307181940.868828-6-helgaas@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230307181940.868828-1-helgaas@kernel.org> References: <20230307181940.868828-1-helgaas@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org From: Bjorn Helgaas pci_enable_pcie_error_reporting() enables the device to send ERR_* Messages. Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is native"), the PCI core does this for all devices during enumeration. Remove the redundant pci_enable_pcie_error_reporting() call from the driver. Also remove the corresponding pci_disable_pcie_error_reporting() from the driver .remove() path. Note that this only controls ERR_* Messages from the device. An ERR_* Message may cause the Root Port to generate an interrupt, depending on the AER Root Error Command register managed by the AER service driver. Signed-off-by: Bjorn Helgaas Cc: Michael Chan Reviewed-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c index 5d4b1f2ebeac..7245fee13ad0 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c @@ -48,7 +48,6 @@ #include #include #include -#include #include #include #include @@ -12706,8 +12705,6 @@ static int bnxt_init_board(struct pci_dev *pdev, struct net_device *dev) goto init_err_release; } - pci_enable_pcie_error_reporting(pdev); - INIT_WORK(&bp->sp_task, bnxt_sp_task); INIT_DELAYED_WORK(&bp->fw_reset_task, bnxt_fw_reset_task); @@ -13187,7 +13184,6 @@ static void bnxt_remove_one(struct pci_dev *pdev) bnxt_rdma_aux_device_uninit(bp); bnxt_ptp_clear(bp); - pci_disable_pcie_error_reporting(pdev); unregister_netdev(dev); clear_bit(BNXT_STATE_IN_FW_RESET, &bp->state); /* Flush any pending tasks */ From patchwork Tue Mar 7 18:19:17 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Helgaas X-Patchwork-Id: 13164436 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C37F1C678D4 for ; Tue, 7 Mar 2023 18:25:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232884AbjCGSZQ (ORCPT ); Tue, 7 Mar 2023 13:25:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48730 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231354AbjCGSYe (ORCPT ); Tue, 7 Mar 2023 13:24:34 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 24BF59FE51; Tue, 7 Mar 2023 10:20:09 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8C14F61546; Tue, 7 Mar 2023 18:20:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C4513C4339C; Tue, 7 Mar 2023 18:20:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678213208; bh=pFPJ8Gf/UKoAjq3MFpPQ7R9lpnJErmcP6SLaIvSooH0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=iURIuRfsXJMsXQrZ4QCQUds072j/cgGQfquLTdhMQstz7xlhx2Zide0H8KZmYc6ub k+lwuRDfJ97HKLzcWEMRt8a20On+a2FOUPBBMTNx4h8wlZOjpP+Dc+N9Pt6qxIFdck 2m80egoZjIif/CC9ZMNGsXnE7oq33ST4hz9CYj+NsE/KK/TzdZ9+ZW+zszzv/1fIpP N+yC75cd9xY8iQLEKiN62Yom0AsoRNpMijy1CNgvYeXkbHi8v1rrkrSQfeofMbxlOF znLThsDmQOryFf/GGPIbcW139M51iH1OLFGqk/gn4lv7/q2dUuFnONGTXHAz53MsV4 Qzjl0qJfPGFNg== From: Bjorn Helgaas To: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Helgaas , Raju Rangoju Subject: [PATCH 06/28] cxgb4: Drop redundant pci_enable_pcie_error_reporting() Date: Tue, 7 Mar 2023 12:19:17 -0600 Message-Id: <20230307181940.868828-7-helgaas@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230307181940.868828-1-helgaas@kernel.org> References: <20230307181940.868828-1-helgaas@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org From: Bjorn Helgaas pci_enable_pcie_error_reporting() enables the device to send ERR_* Messages. Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is native"), the PCI core does this for all devices during enumeration, so the driver doesn't need to do it itself. Remove the redundant pci_enable_pcie_error_reporting() call from the driver. Also remove the corresponding pci_disable_pcie_error_reporting() from the driver .remove() path. Note that this only controls ERR_* Messages from the device. An ERR_* Message may cause the Root Port to generate an interrupt, depending on the AER Root Error Command register managed by the AER service driver. Signed-off-by: Bjorn Helgaas Cc: Raju Rangoju --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c index 7db2403c4c9c..f0bc7396ce2b 100644 --- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c +++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c @@ -51,7 +51,6 @@ #include #include #include -#include #include #include #include @@ -6687,7 +6686,6 @@ static int init_one(struct pci_dev *pdev, const struct pci_device_id *ent) goto out_free_adapter; } - pci_enable_pcie_error_reporting(pdev); pci_set_master(pdev); pci_save_state(pdev); adap_idx++; @@ -7092,7 +7090,6 @@ static int init_one(struct pci_dev *pdev, const struct pci_device_id *ent) out_unmap_bar0: iounmap(regs); out_disable_device: - pci_disable_pcie_error_reporting(pdev); pci_disable_device(pdev); out_release_regions: pci_release_regions(pdev); @@ -7171,7 +7168,6 @@ static void remove_one(struct pci_dev *pdev) } #endif iounmap(adapter->regs); - pci_disable_pcie_error_reporting(pdev); if ((adapter->flags & CXGB4_DEV_ENABLED)) { pci_disable_device(pdev); adapter->flags &= ~CXGB4_DEV_ENABLED; From patchwork Tue Mar 7 18:19:18 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Helgaas X-Patchwork-Id: 13164437 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 325E4C6FD20 for ; Tue, 7 Mar 2023 18:26:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232897AbjCGS0B (ORCPT ); Tue, 7 Mar 2023 13:26:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46964 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232812AbjCGSYj (ORCPT ); Tue, 7 Mar 2023 13:24:39 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C24BBA4023; Tue, 7 Mar 2023 10:20:10 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 521C06154C; Tue, 7 Mar 2023 18:20:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8F4B7C4339C; Tue, 7 Mar 2023 18:20:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678213209; bh=LbCwYJ20y8eWkgkIiA04QacuVyTv59uOi6c3cF4SrJU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kyNeenARGKJlqG3HD8EnysYP8c51Ld33M6PWizLGt8ypsiCtcUuossg80YghysKLN zBdbdOiz1ORJt8/CRSnBHrJIM52Hdgs9cQmDfZz4g8g7rmRwplEYzB1WV8QyZSpfkr 9yZD0xNCw032IjlfyIJiaKpBc0H4zN4b7AvrG0NipBsXlxcHnIUQMoi6G5OFw09WrO sebTljQ4yfzf14ka11TlzF7JjLHnaCuV6FM68ybWPUgKKhCoYjm6qT3XT2Mjw2IwyH 0GFegLnlSQ9xenDfva7lMyNmCMWTT3gnrdDrMWFvYR9ZIfUB0BjYp+++8yb+4h0Ap0 fe0JN2OjYrflQ== From: Bjorn Helgaas To: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Helgaas , Dimitris Michailidis Subject: [PATCH 07/28] net/fungible: Drop redundant pci_enable_pcie_error_reporting() Date: Tue, 7 Mar 2023 12:19:18 -0600 Message-Id: <20230307181940.868828-8-helgaas@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230307181940.868828-1-helgaas@kernel.org> References: <20230307181940.868828-1-helgaas@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org From: Bjorn Helgaas pci_enable_pcie_error_reporting() enables the device to send ERR_* Messages. Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is native"), the PCI core does this for all devices during enumeration, so the driver doesn't need to do it itself. Remove the redundant pci_enable_pcie_error_reporting() call from the driver. Also remove the corresponding pci_disable_pcie_error_reporting() from the driver .remove() path. Note that this only controls ERR_* Messages from the device. An ERR_* Message may cause the Root Port to generate an interrupt, depending on the AER Root Error Command register managed by the AER service driver. Signed-off-by: Bjorn Helgaas Cc: Dimitris Michailidis Acked-by: Dimitris Michailidis --- drivers/net/ethernet/fungible/funcore/fun_dev.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/net/ethernet/fungible/funcore/fun_dev.c b/drivers/net/ethernet/fungible/funcore/fun_dev.c index fb5120d90f26..3680f83feba2 100644 --- a/drivers/net/ethernet/fungible/funcore/fun_dev.c +++ b/drivers/net/ethernet/fungible/funcore/fun_dev.c @@ -1,6 +1,5 @@ // SPDX-License-Identifier: (GPL-2.0-only OR BSD-3-Clause) -#include #include #include #include @@ -748,7 +747,6 @@ void fun_dev_disable(struct fun_dev *fdev) pci_free_irq_vectors(pdev); pci_clear_master(pdev); - pci_disable_pcie_error_reporting(pdev); pci_disable_device(pdev); fun_unmap_bars(fdev); @@ -781,8 +779,6 @@ int fun_dev_enable(struct fun_dev *fdev, struct pci_dev *pdev, goto unmap; } - pci_enable_pcie_error_reporting(pdev); - rc = sanitize_dev(fdev); if (rc) goto disable_dev; @@ -830,7 +826,6 @@ int fun_dev_enable(struct fun_dev *fdev, struct pci_dev *pdev, free_irqs: pci_free_irq_vectors(pdev); disable_dev: - pci_disable_pcie_error_reporting(pdev); pci_disable_device(pdev); unmap: fun_unmap_bars(fdev); From patchwork Tue Mar 7 18:19:19 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Helgaas X-Patchwork-Id: 13164439 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3BE70C678D4 for ; Tue, 7 Mar 2023 18:26:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232834AbjCGS0K (ORCPT ); Tue, 7 Mar 2023 13:26:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49290 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232844AbjCGSYw (ORCPT ); Tue, 7 Mar 2023 13:24:52 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 21FEFA17CE; Tue, 7 Mar 2023 10:20:14 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id C637BB819C8; Tue, 7 Mar 2023 18:20:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5DBE9C4339B; Tue, 7 Mar 2023 18:20:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678213211; bh=0ernidC3WHANesMpJRzZFG2rHwt5UJnwsTY6wU8GmKc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=WKh3ilgEITf4V+9GPFzQj6/xSj6dY9x1MvbUYNhnBVd0A9JY2ZisIIJSvGxAUGr+H duzfDn1CuzTKFZdAtBX1QIQWUWdv9ql0vqeY1eFFTdN8Fo0Xz8mfgW1FLbgk8bAeNj 46ISxexD/Gr0l0RQNr0yv1wgc49iajLCDYDOYJHWfO7t+Y/ebj8EnJmXjFUH8ZI6Vv UJ/pb5NIzRG/LT3P7GwAwoM09ehRQQgap4cHFrEZMXmbnYI5kXzynp+OV3+1Fu84ww LvFouxSEAofZj16nsx/+irNXDEtZOGiwEADrli5MLVH4qnQHuQT3X4kbrRmi/5roR4 +x8zQB2X2+fhw== From: Bjorn Helgaas To: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Helgaas , Yisen Zhuang , Salil Mehta Subject: [PATCH 08/28] net: hns3: remove unnecessary aer.h include Date: Tue, 7 Mar 2023 12:19:19 -0600 Message-Id: <20230307181940.868828-9-helgaas@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230307181940.868828-1-helgaas@kernel.org> References: <20230307181940.868828-1-helgaas@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org From: Bjorn Helgaas is unused, so remove it. Signed-off-by: Bjorn Helgaas Cc: Yisen Zhuang Cc: Salil Mehta --- drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c index 25be7f8ac7cd..5caea154362f 100644 --- a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c +++ b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c @@ -13,7 +13,6 @@ #include #include #include -#include #include #include #include From patchwork Tue Mar 7 18:19:20 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Helgaas X-Patchwork-Id: 13164438 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 484D8C6FD1A for ; Tue, 7 Mar 2023 18:26:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232842AbjCGS0H (ORCPT ); Tue, 7 Mar 2023 13:26:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47028 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232850AbjCGSYx (ORCPT ); Tue, 7 Mar 2023 13:24:53 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ABE37A80C4; Tue, 7 Mar 2023 10:20:14 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 16E2661501; Tue, 7 Mar 2023 18:20:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4C344C433EF; Tue, 7 Mar 2023 18:20:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678213213; bh=f2vDXDF6d70nczotU5xFMm8fkVvPCcrdAaiTn10Iyl0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=tRnUrsPuNk+5S46oLbNEqQe9aTovqlD45J+8hXGeZDlNrPkHEsr/i6cBUHzO/A+yp CpboaFpgpThprgVtfS970fS7spbUwedUzYIW+MdqLwNCGa7gUShcfuZo+VzcCM7siz fL3bFEvFjDN6bKah7zK1qrXXgXZG/zbpAwQPr1Jz/5ZYcnKc13So5WRVO33OnjFlxr 6IgFl1Ov1Q94ls+5blZ7VetzcaFyHcISVsNwKV86KGAljoFfUnRUycAHPZDB0RCd2Y eeqnzI04lr7XL0l1vwMRKiUEj7Ijp+CelZuTwsSvRARqUPplZBxNGiQKNrLwPeGDhq oiZRzU7O9O72g== From: Bjorn Helgaas To: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Helgaas , Manish Chopra , Rahul Verma , GR-Linux-NIC-Dev@marvell.com Subject: [PATCH 09/28] netxen_nic: Drop redundant pci_enable_pcie_error_reporting() Date: Tue, 7 Mar 2023 12:19:20 -0600 Message-Id: <20230307181940.868828-10-helgaas@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230307181940.868828-1-helgaas@kernel.org> References: <20230307181940.868828-1-helgaas@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org From: Bjorn Helgaas pci_enable_pcie_error_reporting() enables the device to send ERR_* Messages. Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is native"), the PCI core does this for all devices during enumeration, so the driver doesn't need to do it itself. Remove the redundant pci_enable_pcie_error_reporting() call from the driver. Also remove the corresponding pci_disable_pcie_error_reporting() from the driver .remove() path. Note that this only controls ERR_* Messages from the device. An ERR_* Message may cause the Root Port to generate an interrupt, depending on the AER Root Error Command register managed by the AER service driver. Also note that the driver only called these for NX_IS_REVISION_P3 devices, so since f26e58bf6f54, error reporting has been enabled for devices other than NX_IS_REVISION_P3. Signed-off-by: Bjorn Helgaas Cc: Manish Chopra Cc: Rahul Verma Cc: GR-Linux-NIC-Dev@marvell.com --- drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c b/drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c index de8d54b23f73..59d0dd862fd1 100644 --- a/drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c +++ b/drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c @@ -18,7 +18,6 @@ #include #include #include -#include MODULE_DESCRIPTION("QLogic/NetXen (1/10) GbE Intelligent Ethernet Driver"); MODULE_LICENSE("GPL"); @@ -1464,9 +1463,6 @@ netxen_nic_probe(struct pci_dev *pdev, const struct pci_device_id *ent) if ((err = pci_request_regions(pdev, netxen_nic_driver_name))) goto err_out_disable_pdev; - if (NX_IS_REVISION_P3(pdev->revision)) - pci_enable_pcie_error_reporting(pdev); - pci_set_master(pdev); netdev = alloc_etherdev(sizeof(struct netxen_adapter)); @@ -1603,8 +1599,6 @@ netxen_nic_probe(struct pci_dev *pdev, const struct pci_device_id *ent) free_netdev(netdev); err_out_free_res: - if (NX_IS_REVISION_P3(pdev->revision)) - pci_disable_pcie_error_reporting(pdev); pci_release_regions(pdev); err_out_disable_pdev: @@ -1659,10 +1653,8 @@ static void netxen_nic_remove(struct pci_dev *pdev) netxen_release_firmware(adapter); - if (NX_IS_REVISION_P3(pdev->revision)) { + if (NX_IS_REVISION_P3(pdev->revision)) netxen_cleanup_minidump(adapter); - pci_disable_pcie_error_reporting(pdev); - } pci_release_regions(pdev); pci_disable_device(pdev); From patchwork Tue Mar 7 18:19:21 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Helgaas X-Patchwork-Id: 13164440 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF529C678D4 for ; Tue, 7 Mar 2023 18:26:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232919AbjCGS0l (ORCPT ); Tue, 7 Mar 2023 13:26:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46322 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232674AbjCGSY6 (ORCPT ); Tue, 7 Mar 2023 13:24:58 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0124B9E07F; Tue, 7 Mar 2023 10:20:17 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id A3189B819CA; Tue, 7 Mar 2023 18:20:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3DA27C4339B; Tue, 7 Mar 2023 18:20:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678213215; bh=93zuo2kl6zHOilprDZc5m0GhVopCd4gNUJYuchTiEY4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ko+uUQc94uPwcEVpwuRsVJiAbkjor+5PSV+nzZXkf3hxd9/IZOQcAlg8MTrFnC5yj aR07D0LlmHcMbENz1E9G3tMu3T2wwVAlqiyOE6UXiaXQrsKcsqeo4O1wtRK6UBhxav 8IA6KOPQ4sgDctnHyKQbx0f7KAOm9sA+iE0LlyQYjn3Ne7n8suhLI6QKb81DZxFFmV qsjxjhlbiEb6BeFBPPbAhTItlq3vgkh44cKDbmkekcTlQ6+sVoYd0GLow1xfNwch8K nTd7UQywXajTfcubGcLM85HEBX2EKQ91T1i51N/5fyLAJ72x3GQmAJka/uwqU6h/Yy 6E9XDYSrpiOtA== From: Bjorn Helgaas To: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Helgaas , Veerasenareddy Burru , Abhijit Ayarekar Subject: [PATCH 10/28] octeon_ep: Drop redundant pci_enable_pcie_error_reporting() Date: Tue, 7 Mar 2023 12:19:21 -0600 Message-Id: <20230307181940.868828-11-helgaas@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230307181940.868828-1-helgaas@kernel.org> References: <20230307181940.868828-1-helgaas@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org From: Bjorn Helgaas pci_enable_pcie_error_reporting() enables the device to send ERR_* Messages. Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is native"), the PCI core does this for all devices during enumeration, so the driver doesn't need to do it itself. Remove the redundant pci_enable_pcie_error_reporting() call from the driver. Also remove the corresponding pci_disable_pcie_error_reporting() from the driver .remove() path. Note that this only controls ERR_* Messages from the device. An ERR_* Message may cause the Root Port to generate an interrupt, depending on the AER Root Error Command register managed by the AER service driver. Signed-off-by: Bjorn Helgaas Cc: Veerasenareddy Burru Cc: Abhijit Ayarekar --- drivers/net/ethernet/marvell/octeon_ep/octep_main.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/net/ethernet/marvell/octeon_ep/octep_main.c b/drivers/net/ethernet/marvell/octeon_ep/octep_main.c index 5a898fb88e37..fdce78ceea87 100644 --- a/drivers/net/ethernet/marvell/octeon_ep/octep_main.c +++ b/drivers/net/ethernet/marvell/octeon_ep/octep_main.c @@ -8,7 +8,6 @@ #include #include #include -#include #include #include #include @@ -1050,7 +1049,6 @@ static int octep_probe(struct pci_dev *pdev, const struct pci_device_id *ent) goto err_pci_regions; } - pci_enable_pcie_error_reporting(pdev); pci_set_master(pdev); netdev = alloc_etherdev_mq(sizeof(struct octep_device), @@ -1106,7 +1104,6 @@ static int octep_probe(struct pci_dev *pdev, const struct pci_device_id *ent) err_octep_config: free_netdev(netdev); err_alloc_netdev: - pci_disable_pcie_error_reporting(pdev); pci_release_mem_regions(pdev); err_pci_regions: err_dma_mask: @@ -1139,7 +1136,6 @@ static void octep_remove(struct pci_dev *pdev) octep_device_cleanup(oct); pci_release_mem_regions(pdev); free_netdev(netdev); - pci_disable_pcie_error_reporting(pdev); pci_disable_device(pdev); } From patchwork Tue Mar 7 18:19:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Helgaas X-Patchwork-Id: 13164441 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69592C6FD1A for ; Tue, 7 Mar 2023 18:26:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232798AbjCGS0p (ORCPT ); Tue, 7 Mar 2023 13:26:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52410 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232753AbjCGSZC (ORCPT ); Tue, 7 Mar 2023 13:25:02 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D0BC19F222; Tue, 7 Mar 2023 10:20:19 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 8BBA2B819BC; Tue, 7 Mar 2023 18:20:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 11B48C4339B; Tue, 7 Mar 2023 18:20:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678213217; bh=tD/0BL32SiQcpNBmJHR6772uCW+5TraI1VbasTgz7rU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=tbVVdSNDnyNV49AyShaP6RIuX1dc5dxxhIePy1arx73pACarVWRbwCfM1jfpqnXQu 160kKUUktsg7XBwBwusGMhIyVMTuBc4j5yq8pknrVfUG7/g6+WzDlulcM56zHr1Fdd BZmfK0IGTd2iiQTrmZJZRxNI12ecHDoKgWt03lqBelb3xw0FZQRiwNAsJKGkrTbssp opCb+2SGJ2a5M/my0pxbUbT9Ln+2xNJffl0yj7MKKnSYnIF9p5rlxWol3NUNZc8isl D/tr/imA2CMJu2WJRxn7pHLTFvPeQ2TQAr0CfXZPXhKDCNxgliFqSbfC9Eeb8e/eFA gBfquTrK3fw5w== From: Bjorn Helgaas To: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Helgaas , Ariel Elior , Manish Chopra Subject: [PATCH 11/28] qed: Drop redundant pci_enable_pcie_error_reporting() Date: Tue, 7 Mar 2023 12:19:22 -0600 Message-Id: <20230307181940.868828-12-helgaas@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230307181940.868828-1-helgaas@kernel.org> References: <20230307181940.868828-1-helgaas@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org From: Bjorn Helgaas pci_enable_pcie_error_reporting() enables the device to send ERR_* Messages. Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is native"), the PCI core does this for all devices during enumeration, so the driver doesn't need to do it itself. Remove the redundant pci_enable_pcie_error_reporting() call from the driver. Also remove the corresponding pci_disable_pcie_error_reporting() from the driver .remove() path. Note that this only controls ERR_* Messages from the device. An ERR_* Message may cause the Root Port to generate an interrupt, depending on the AER Root Error Command register managed by the AER service driver. Signed-off-by: Bjorn Helgaas Cc: Ariel Elior Cc: Manish Chopra --- drivers/net/ethernet/qlogic/qed/qed_main.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/drivers/net/ethernet/qlogic/qed/qed_main.c b/drivers/net/ethernet/qlogic/qed/qed_main.c index c91898be7c03..f5af83342856 100644 --- a/drivers/net/ethernet/qlogic/qed/qed_main.c +++ b/drivers/net/ethernet/qlogic/qed/qed_main.c @@ -23,7 +23,6 @@ #include #include #include -#include #include #include "qed.h" @@ -259,8 +258,6 @@ static void qed_free_pci(struct qed_dev *cdev) { struct pci_dev *pdev = cdev->pdev; - pci_disable_pcie_error_reporting(pdev); - if (cdev->doorbells && cdev->db_size) iounmap(cdev->doorbells); if (cdev->regview) @@ -366,12 +363,6 @@ static int qed_init_pci(struct qed_dev *cdev, struct pci_dev *pdev) return -ENOMEM; } - /* AER (Advanced Error reporting) configuration */ - rc = pci_enable_pcie_error_reporting(pdev); - if (rc) - DP_VERBOSE(cdev, NETIF_MSG_DRV, - "Failed to configure PCIe AER [%d]\n", rc); - return 0; err2: From patchwork Tue Mar 7 18:19:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Helgaas X-Patchwork-Id: 13164442 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91D7DC6FD1B for ; Tue, 7 Mar 2023 18:26:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231401AbjCGS0q (ORCPT ); Tue, 7 Mar 2023 13:26:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48614 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232796AbjCGSZD (ORCPT ); Tue, 7 Mar 2023 13:25:03 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 166719E06E; Tue, 7 Mar 2023 10:20:20 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A6A4B61547; Tue, 7 Mar 2023 18:20:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E6101C433D2; Tue, 7 Mar 2023 18:20:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678213219; bh=3XOqJB30BJgwfczGzN1h2VGhOkqWll+o8F8lUQkfxtU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=MiduEHmuL9TPEds9Mi8QibiWXzCXEUKMMF9zyTW3XO3CfudMIl54AZZU0VhAT+ISb TWj5afUVPz02pDsz+D0SAKkfL0RGJiTUFFiuwIPp/HiL00X3VaZwEWO27gLWg3Mk1w cnNDPGkNhTjqSgZwYnr1aQDZZnrn0m8vS8zeZgJyidDryghzga9r74FLRywivZjnBy UzCJi8B+yo3A2XGnurGSF/CL+sNl7I2qIv0X18ruED+rBCBS1D7T9cofuiNC4nZYsa Gnv5pLvyOFr85+42aoiHLAWb8EgISKifXwWQYw0CIrZADMa5fX1s/Bazh7X3cM6Bi0 4xvfLxeEaiikA== From: Bjorn Helgaas To: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Helgaas , Ariel Elior , Manish Chopra Subject: [PATCH 12/28] net: qede: Remove unnecessary aer.h include Date: Tue, 7 Mar 2023 12:19:23 -0600 Message-Id: <20230307181940.868828-13-helgaas@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230307181940.868828-1-helgaas@kernel.org> References: <20230307181940.868828-1-helgaas@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org From: Bjorn Helgaas is unused, so remove it. Signed-off-by: Bjorn Helgaas Cc: Ariel Elior Cc: Manish Chopra --- drivers/net/ethernet/qlogic/qede/qede_main.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/qlogic/qede/qede_main.c b/drivers/net/ethernet/qlogic/qede/qede_main.c index 261f982ca40d..4c6c685820e3 100644 --- a/drivers/net/ethernet/qlogic/qede/qede_main.c +++ b/drivers/net/ethernet/qlogic/qede/qede_main.c @@ -35,7 +35,6 @@ #include #include #include -#include #include "qede.h" #include "qede_ptp.h" From patchwork Tue Mar 7 18:19:24 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Helgaas X-Patchwork-Id: 13164444 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BECDC678D4 for ; Tue, 7 Mar 2023 18:26:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232807AbjCGS0w (ORCPT ); Tue, 7 Mar 2023 13:26:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48860 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230013AbjCGSZo (ORCPT ); Tue, 7 Mar 2023 13:25:44 -0500 Received: from sin.source.kernel.org (sin.source.kernel.org [IPv6:2604:1380:40e1:4800::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 642419FBE2; Tue, 7 Mar 2023 10:20:24 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id C64ECCE1C83; Tue, 7 Mar 2023 18:20:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BCD57C433D2; Tue, 7 Mar 2023 18:20:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678213221; bh=L40C2NsmiT5sjeEnSWj72p21BipE9CnM7NZNqckWFdI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=NotFv3R6nlW7TCPqWDdY++YMdVT5NNa6K3LpUqhjc9F15D09eae85fK2IH7rxRvOF EoIEWTJdKaQ1sD/+c9bz90rBjuM5AURrPtAM1s3eGbg0zWJyan4JLJR+k6Ds576KwR eTW1Qn5CFfp8cICZ9up6ubCga1a2/wAOs1TYYnrLM2lWxGHAAVtD0C/01BtTR1bH5H do5sH5r1gzpIFPT6N2YUFIIJAQkWfU9ZThVYwmWmjvdneE7blwmHfsLdRcLMkFqQF4 WvrdReCZOFIftgVA+q1Ud/VrX+U38z4VAUSFS+GDejUSLKUBlePDNS/1RW+WVqjsOL KfC6hziMqAr/w== From: Bjorn Helgaas To: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Helgaas , Shahed Shaikh , Manish Chopra , GR-Linux-NIC-Dev@marvell.com Subject: [PATCH 13/28] qlcnic: Drop redundant pci_enable_pcie_error_reporting() Date: Tue, 7 Mar 2023 12:19:24 -0600 Message-Id: <20230307181940.868828-14-helgaas@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230307181940.868828-1-helgaas@kernel.org> References: <20230307181940.868828-1-helgaas@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org From: Bjorn Helgaas pci_enable_pcie_error_reporting() enables the device to send ERR_* Messages. Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is native"), the PCI core does this for all devices during enumeration, so the driver doesn't need to do it itself. Remove the redundant pci_enable_pcie_error_reporting() call from the driver. Also remove the corresponding pci_disable_pcie_error_reporting() from the driver .remove() path. Note that this only controls ERR_* Messages from the device. An ERR_* Message may cause the Root Port to generate an interrupt, depending on the AER Root Error Command register managed by the AER service driver. Signed-off-by: Bjorn Helgaas Cc: Shahed Shaikh Cc: Manish Chopra Cc: GR-Linux-NIC-Dev@marvell.com --- drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c | 4 ---- drivers/net/ethernet/qlogic/qlcnic/qlcnic_sysfs.c | 1 - 2 files changed, 5 deletions(-) diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c index 44dac3c0908e..90df4a0909fa 100644 --- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c +++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c @@ -12,7 +12,6 @@ #include #include #include -#include #include #include #include @@ -2445,7 +2444,6 @@ qlcnic_probe(struct pci_dev *pdev, const struct pci_device_id *ent) goto err_out_disable_pdev; pci_set_master(pdev); - pci_enable_pcie_error_reporting(pdev); ahw = kzalloc(sizeof(struct qlcnic_hardware_context), GFP_KERNEL); if (!ahw) { @@ -2675,7 +2673,6 @@ qlcnic_probe(struct pci_dev *pdev, const struct pci_device_id *ent) kfree(ahw); err_out_free_res: - pci_disable_pcie_error_reporting(pdev); pci_release_regions(pdev); err_out_disable_pdev: @@ -2757,7 +2754,6 @@ static void qlcnic_remove(struct pci_dev *pdev) qlcnic_release_firmware(adapter); - pci_disable_pcie_error_reporting(pdev); pci_release_regions(pdev); pci_disable_device(pdev); diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_sysfs.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_sysfs.c index 5c2edb715d3e..74125188beb8 100644 --- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_sysfs.c +++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_sysfs.c @@ -12,7 +12,6 @@ #include #include #include -#include #include #ifdef CONFIG_QLCNIC_HWMON #include From patchwork Tue Mar 7 18:19:25 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Helgaas X-Patchwork-Id: 13164443 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C148C678DB for ; Tue, 7 Mar 2023 18:26:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232938AbjCGS0s (ORCPT ); Tue, 7 Mar 2023 13:26:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48774 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232802AbjCGSZT (ORCPT ); Tue, 7 Mar 2023 13:25:19 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D1534AB887; Tue, 7 Mar 2023 10:20:23 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5C329614E8; Tue, 7 Mar 2023 18:20:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 98D86C433EF; Tue, 7 Mar 2023 18:20:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678213222; bh=QMLEgpaw8nuZ6gGVRznNtZSpSJ+P4AUFwKxnyhEIEx0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JV20MAJx1+Mp0pF7KL5BlWv1VBpcsNNpK+9ewQz9hnI1Zn5ZLJxQ2zDgEdN88HKjR OitjgHN44LH/rYijVX21kHE1BU7qFGNn5nSubeZrCAEkbvvyx/T2lrkmWJiap4Y+qg Gt7ei5QGLGmfDvCCaPnwZE7kOeH+cRWkhltyGJf8WZdhgGe9bk8VfoE3S8lCPXBFmx XMNdgLABg9ivWoB50njnROAY6hmg+GgitTIcLp6XMOO5zQjuNMwxLLTLY4LByp/C0u uC+ipSjJvDXp5bpfky1Ggbu3Kx761rC2wS45eXtNjVsn/WPRsmMhfjfj56KxTWd72o LRAn/dAytZ1YA== From: Bjorn Helgaas To: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Helgaas , Shahed Shaikh , Manish Chopra , GR-Linux-NIC-Dev@marvell.com Subject: [PATCH 14/28] qlcnic: Remove unnecessary aer.h include Date: Tue, 7 Mar 2023 12:19:25 -0600 Message-Id: <20230307181940.868828-15-helgaas@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230307181940.868828-1-helgaas@kernel.org> References: <20230307181940.868828-1-helgaas@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org From: Bjorn Helgaas is unused, so remove it. Signed-off-by: Bjorn Helgaas Cc: Shahed Shaikh Cc: Manish Chopra Cc: GR-Linux-NIC-Dev@marvell.com --- drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c index 2fd5c6fdb500..bcef8ab715bf 100644 --- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c +++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c @@ -8,7 +8,6 @@ #include #include #include -#include #include "qlcnic.h" #include "qlcnic_sriov.h" From patchwork Tue Mar 7 18:19:26 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Helgaas X-Patchwork-Id: 13164445 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D771C678D5 for ; Tue, 7 Mar 2023 18:27:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232963AbjCGS1X (ORCPT ); Tue, 7 Mar 2023 13:27:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46118 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232759AbjCGSZ7 (ORCPT ); Tue, 7 Mar 2023 13:25:59 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 42F93A92ED; Tue, 7 Mar 2023 10:20:27 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id E7C27B819C8; Tue, 7 Mar 2023 18:20:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 64066C433EF; Tue, 7 Mar 2023 18:20:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678213224; bh=R3qhJIRBpujHIxRFlynDnmucTd3u0pBuUk2cqVlrcQY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JQdBO/VodaUeYxo9roFtmtJ//orvmW8XFYRtfFtrYAh4dq05C9J9VWZ/NKLbQAEU5 2fNXtH9thudx4KsqU+3+Ry0Vt/fHx6r5GJzLRg6vqxeNJ/NH4Y0htjfEwVAbKwcO40 MbyevcC2iw80VCIXqVarhgTxPuKPjxiOHcPcWWsrXQ6PjLK3Ce1dKzjK0a9KDgXxTz rExNzLW8lLrZuNUPpnyJG8s0NC7nrW24ubAef0PiEpCTKiicbsa+dE8gR2MW8vJ6Q6 Q96N4xCmovWntbI1A/X7jOg/25Z/ODNB3Y0Vs6eWEwuQIG2fAhKgrHtEBr/KO0HRY3 g8nyZdqMwIHHw== From: Bjorn Helgaas To: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Helgaas , Edward Cree , Martin Habets Subject: [PATCH 15/28] sfc: Drop redundant pci_enable_pcie_error_reporting() Date: Tue, 7 Mar 2023 12:19:26 -0600 Message-Id: <20230307181940.868828-16-helgaas@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230307181940.868828-1-helgaas@kernel.org> References: <20230307181940.868828-1-helgaas@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org From: Bjorn Helgaas pci_enable_pcie_error_reporting() enables the device to send ERR_* Messages. Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is native"), the PCI core does this for all devices during enumeration, so the driver doesn't need to do it itself. Remove the redundant pci_enable_pcie_error_reporting() call from the driver. Also remove the corresponding pci_disable_pcie_error_reporting() from the driver .remove() path. Note that this only controls ERR_* Messages from the device. An ERR_* Message may cause the Root Port to generate an interrupt, depending on the AER Root Error Command register managed by the AER service driver. Signed-off-by: Bjorn Helgaas Cc: Edward Cree Cc: Martin Habets Acked-by: Edward Cree --- drivers/net/ethernet/sfc/efx.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/net/ethernet/sfc/efx.c b/drivers/net/ethernet/sfc/efx.c index 02c2adeb0a12..92c390ec4735 100644 --- a/drivers/net/ethernet/sfc/efx.c +++ b/drivers/net/ethernet/sfc/efx.c @@ -18,7 +18,6 @@ #include #include #include -#include #include #include "net_driver.h" #include @@ -892,8 +891,6 @@ static void efx_pci_remove(struct pci_dev *pci_dev) free_netdev(efx->net_dev); probe_data = container_of(efx, struct efx_probe_data, efx); kfree(probe_data); - - pci_disable_pcie_error_reporting(pci_dev); }; /* NIC VPD information @@ -1126,8 +1123,6 @@ static int efx_pci_probe(struct pci_dev *pci_dev, netif_warn(efx, probe, efx->net_dev, "failed to create MTDs (%d)\n", rc); - (void)pci_enable_pcie_error_reporting(pci_dev); - if (efx->type->udp_tnl_push_ports) efx->type->udp_tnl_push_ports(efx); From patchwork Tue Mar 7 18:19:27 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Helgaas X-Patchwork-Id: 13164446 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F4E1C678D4 for ; Tue, 7 Mar 2023 18:27:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232972AbjCGS1e (ORCPT ); Tue, 7 Mar 2023 13:27:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46178 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232823AbjCGS0B (ORCPT ); Tue, 7 Mar 2023 13:26:01 -0500 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 70252ACE37; Tue, 7 Mar 2023 10:20:29 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 14678CE1C84; Tue, 7 Mar 2023 18:20:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 38645C433D2; Tue, 7 Mar 2023 18:20:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678213226; bh=ZhMyDhUa2wqpQV2qFzBJe9Bn0s90CRl6l0idvIIy614=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=U/iNN/MEM38r3TpbO3a32aOojVUyAcscuHqhahJvXh71+RHJpwweWGVD6q3Mg+o2F Z9wcvNU9fqx+RTValM70vDw5VNi8ne/7TEQJouBFnInEI4hJ1wTrEGlZJomfWYFNGV FyYO6TRnZTxA21V6nVdVNsXF3RRMBWEhzhJPb/V9EMMguj5xcp5RXTvQeH0BB77ASV 9VHzI0VkN3omP/++/0W7ZT/KDCO+9ilYihy6IK79Up/8mAgXRH4mGLR7qkwgPkALX7 SwE+641OrY4irDI3OXyMtWJX91xbtUGUUL60KGtDdXy4hQ3JkeAqOL1CmiO5EyY9K1 sG/apuFGQmhdA== From: Bjorn Helgaas To: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Helgaas , Edward Cree , Martin Habets Subject: [PATCH 16/28] sfc: falcon: Drop redundant pci_enable_pcie_error_reporting() Date: Tue, 7 Mar 2023 12:19:27 -0600 Message-Id: <20230307181940.868828-17-helgaas@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230307181940.868828-1-helgaas@kernel.org> References: <20230307181940.868828-1-helgaas@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org From: Bjorn Helgaas pci_enable_pcie_error_reporting() enables the device to send ERR_* Messages. Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is native"), the PCI core does this for all devices during enumeration, so the driver doesn't need to do it itself. Remove the redundant pci_enable_pcie_error_reporting() call from the driver. Also remove the corresponding pci_disable_pcie_error_reporting() from the driver .remove() path. Note that this only controls ERR_* Messages from the device. An ERR_* Message may cause the Root Port to generate an interrupt, depending on the AER Root Error Command register managed by the AER service driver. Signed-off-by: Bjorn Helgaas Cc: Edward Cree Cc: Martin Habets Acked-by: Edward Cree --- drivers/net/ethernet/sfc/falcon/efx.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/drivers/net/ethernet/sfc/falcon/efx.c b/drivers/net/ethernet/sfc/falcon/efx.c index e151b0957751..e001f27085c6 100644 --- a/drivers/net/ethernet/sfc/falcon/efx.c +++ b/drivers/net/ethernet/sfc/falcon/efx.c @@ -17,7 +17,6 @@ #include #include #include -#include #include #include "net_driver.h" #include "efx.h" @@ -2765,8 +2764,6 @@ static void ef4_pci_remove(struct pci_dev *pci_dev) ef4_fini_struct(efx); free_netdev(efx->net_dev); - - pci_disable_pcie_error_reporting(pci_dev); }; /* NIC VPD information @@ -2927,12 +2924,6 @@ static int ef4_pci_probe(struct pci_dev *pci_dev, netif_warn(efx, probe, efx->net_dev, "failed to create MTDs (%d)\n", rc); - rc = pci_enable_pcie_error_reporting(pci_dev); - if (rc && rc != -EINVAL) - netif_notice(efx, probe, efx->net_dev, - "PCIE error reporting unavailable (%d).\n", - rc); - return 0; fail4: From patchwork Tue Mar 7 18:19:28 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Helgaas X-Patchwork-Id: 13164447 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFFF6C76186 for ; Tue, 7 Mar 2023 18:27:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232981AbjCGS1g (ORCPT ); Tue, 7 Mar 2023 13:27:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49220 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232900AbjCGS0B (ORCPT ); Tue, 7 Mar 2023 13:26:01 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F2F1DA92EF; Tue, 7 Mar 2023 10:20:30 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 875A6B819C5; Tue, 7 Mar 2023 18:20:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 19035C4339E; Tue, 7 Mar 2023 18:20:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678213228; bh=PO6YJGQP/E2abwSNE1uA5K3WGNLi+m5nTKH5md2eNqI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=qCkGvFlev3wtOuj6vmcxP/ryEytiA8D4qpywAn0hCDzUoVADw7OotaO+NXtxiuJoO 6Hc/0Cq2RAU+xrZ3KyB2mA+/zUQ9SIiPUNC24KU7xjXTQYMmnbeK3S25uw5vO8DnZC paJ3+7y2igLXwYlRYNtTLwbOMYdNLtwgbwABxekov0F+JSaB4BjqjRYRZ0iOhaIAQm lv10wxYE3C18AG8C+v6kaE13zqvozBT7riwL8lSyY5dVOe+BLHnWQFR5/qq4ojwhv4 zsthNfxMqY7/dyU3O1MYPosqjqjihO3Wn70d3CzPGJHpgWGbi4pWgMGs3oJh+1cMWE zQVXpTayVzqyQ== From: Bjorn Helgaas To: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Helgaas , Edward Cree , Martin Habets Subject: [PATCH 17/28] sfc/siena: Drop redundant pci_enable_pcie_error_reporting() Date: Tue, 7 Mar 2023 12:19:28 -0600 Message-Id: <20230307181940.868828-18-helgaas@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230307181940.868828-1-helgaas@kernel.org> References: <20230307181940.868828-1-helgaas@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org From: Bjorn Helgaas pci_enable_pcie_error_reporting() enables the device to send ERR_* Messages. Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is native"), the PCI core does this for all devices during enumeration, so the driver doesn't need to do it itself. Remove the redundant pci_enable_pcie_error_reporting() call from the driver. Also remove the corresponding pci_disable_pcie_error_reporting() from the driver .remove() path. Note that this only controls ERR_* Messages from the device. An ERR_* Message may cause the Root Port to generate an interrupt, depending on the AER Root Error Command register managed by the AER service driver. Signed-off-by: Bjorn Helgaas Cc: Edward Cree Cc: Martin Habets Acked-by: Edward Cree --- drivers/net/ethernet/sfc/siena/efx.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/net/ethernet/sfc/siena/efx.c b/drivers/net/ethernet/sfc/siena/efx.c index ef52ec71d197..8c557f6a183c 100644 --- a/drivers/net/ethernet/sfc/siena/efx.c +++ b/drivers/net/ethernet/sfc/siena/efx.c @@ -18,7 +18,6 @@ #include #include #include -#include #include #include "net_driver.h" #include @@ -874,8 +873,6 @@ static void efx_pci_remove(struct pci_dev *pci_dev) efx_siena_fini_struct(efx); free_netdev(efx->net_dev); - - pci_disable_pcie_error_reporting(pci_dev); }; /* NIC VPD information @@ -1094,8 +1091,6 @@ static int efx_pci_probe(struct pci_dev *pci_dev, netif_warn(efx, probe, efx->net_dev, "failed to create MTDs (%d)\n", rc); - (void)pci_enable_pcie_error_reporting(pci_dev); - if (efx->type->udp_tnl_push_ports) efx->type->udp_tnl_push_ports(efx); From patchwork Tue Mar 7 18:19:29 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Helgaas X-Patchwork-Id: 13164450 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E193BC6FD20 for ; Tue, 7 Mar 2023 18:27:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232910AbjCGS1j (ORCPT ); Tue, 7 Mar 2023 13:27:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53104 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232831AbjCGS0D (ORCPT ); Tue, 7 Mar 2023 13:26:03 -0500 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2F67FA92FF; Tue, 7 Mar 2023 10:20:33 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id A452FCE1C81; Tue, 7 Mar 2023 18:20:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E9034C433D2; Tue, 7 Mar 2023 18:20:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678213230; bh=nZWihkCB3+64Nvms7t3o5MvdKzSCnCMWUPwklzyFewQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kQYvDfn3TwVSoLlYr0Fli6KVLssSRynOqK7WfDIh1Fjs7cmSNir8VTvzfVL8rbwx6 KGwz3Ue5obr5LHMOYcAMhNuC8xTiXTNg/cGZI3tGQUO/F4q1IrAIpKxnCJEgugJXdM 5uAVhnruzYqFo4qLg1cjdmuctc/itLePLhZ34VcvZbCplgXAo7w9sXRt4Eq9Kvoqdt QoCIlKmG54H8SC2FvbtBcOqG++V2HZls0hUlW/pLIquLRRXW5dZ/7hNDyjx7GoxxCo dfnkLg9FvZO6lMy3mb6/QcE95iouWRbBS8R8OV0DzC/WRHkFqgj6W1jsZxc3StZwH7 lFD1zplDLQ8xQ== From: Bjorn Helgaas To: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Helgaas , Edward Cree , Martin Habets Subject: [PATCH 18/28] sfc_ef100: Drop redundant pci_disable_pcie_error_reporting() Date: Tue, 7 Mar 2023 12:19:29 -0600 Message-Id: <20230307181940.868828-19-helgaas@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230307181940.868828-1-helgaas@kernel.org> References: <20230307181940.868828-1-helgaas@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org From: Bjorn Helgaas 51b35a454efd ("sfc: skeleton EF100 PF driver") added a call to pci_disable_pcie_error_reporting() in ef100_pci_remove(). Remove this call since there's no apparent reason to disable error reporting when it was not previously enabled. Note that since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is native"), the PCI core enables PCIe error reporting for all devices during enumeration, so the driver doesn't need to do it itself. Signed-off-by: Bjorn Helgaas Cc: Edward Cree Cc: Martin Habets Acked-by: Edward Cree --- drivers/net/ethernet/sfc/ef100.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/ethernet/sfc/ef100.c b/drivers/net/ethernet/sfc/ef100.c index 71aab3d0480f..6334992b0af4 100644 --- a/drivers/net/ethernet/sfc/ef100.c +++ b/drivers/net/ethernet/sfc/ef100.c @@ -11,7 +11,6 @@ #include "net_driver.h" #include -#include #include "efx_common.h" #include "efx_channels.h" #include "io.h" @@ -440,8 +439,6 @@ static void ef100_pci_remove(struct pci_dev *pci_dev) pci_dbg(pci_dev, "shutdown successful\n"); - pci_disable_pcie_error_reporting(pci_dev); - pci_set_drvdata(pci_dev, NULL); efx_fini_struct(efx); kfree(probe_data); From patchwork Tue Mar 7 18:19:30 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Helgaas X-Patchwork-Id: 13164448 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65BBBC678D5 for ; Tue, 7 Mar 2023 18:27:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232823AbjCGS1h (ORCPT ); Tue, 7 Mar 2023 13:27:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46836 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232908AbjCGS0C (ORCPT ); Tue, 7 Mar 2023 13:26:02 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0B44EA92F4; Tue, 7 Mar 2023 10:20:33 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8F1386154C; Tue, 7 Mar 2023 18:20:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CBA61C4339C; Tue, 7 Mar 2023 18:20:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678213232; bh=rAktUskhPO1ybz9A1n3ZxmMrMb2ek7EimkMYj7ZSxHA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fhQzKHoZbVHMkFOXq35GSopr3Xw6Ebqdt2NFeKsF0uGBvJ0hUziTwRIJ6nGujaiKr gvTSyF1x4v3NboSWZsHM0WKjfHoiz0eBzO8NHRoAPV7ZIPjI2kxnBMHhBit0sgiNN7 UH2ElbegdHpdtMoghcTN0m7bPDoq/7unJ8PqK+j77YC7pg8YR30O0jJFzdQECzdBu7 i0q0XMxxrZtrDjsHQzAA7HVpN+T8NsPuTfbk6ZfX6lZ1Rd+5hZmrTm+s+zbUkCKbFD IZ/FUTLLMHAdvhIdh71n0By9jT6FjNCfSdJizy2/ZUhrk3ZYehMxkbe+PRmNbAfpUe gqfxJ0lCugAtw== From: Bjorn Helgaas To: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Helgaas , Jiawen Wu , Mengyuan Lou Subject: [PATCH 19/28] net: ngbe: Drop redundant pci_enable_pcie_error_reporting() Date: Tue, 7 Mar 2023 12:19:30 -0600 Message-Id: <20230307181940.868828-20-helgaas@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230307181940.868828-1-helgaas@kernel.org> References: <20230307181940.868828-1-helgaas@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org From: Bjorn Helgaas pci_enable_pcie_error_reporting() enables the device to send ERR_* Messages. Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is native"), the PCI core does this for all devices during enumeration, so the driver doesn't need to do it itself. Remove the redundant pci_enable_pcie_error_reporting() call from the driver. Also remove the corresponding pci_disable_pcie_error_reporting() from the driver .remove() path. Note that this only controls ERR_* Messages from the device. An ERR_* Message may cause the Root Port to generate an interrupt, depending on the AER Root Error Command register managed by the AER service driver. Signed-off-by: Bjorn Helgaas Cc: Jiawen Wu Cc: Mengyuan Lou --- drivers/net/ethernet/wangxun/ngbe/ngbe_main.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/net/ethernet/wangxun/ngbe/ngbe_main.c b/drivers/net/ethernet/wangxun/ngbe/ngbe_main.c index 5b564d348c09..0e4163e1106f 100644 --- a/drivers/net/ethernet/wangxun/ngbe/ngbe_main.c +++ b/drivers/net/ethernet/wangxun/ngbe/ngbe_main.c @@ -6,7 +6,6 @@ #include #include #include -#include #include #include #include @@ -520,7 +519,6 @@ static int ngbe_probe(struct pci_dev *pdev, goto err_pci_disable_dev; } - pci_enable_pcie_error_reporting(pdev); pci_set_master(pdev); netdev = devm_alloc_etherdev_mqs(&pdev->dev, @@ -669,7 +667,6 @@ static int ngbe_probe(struct pci_dev *pdev, err_free_mac_table: kfree(wx->mac_table); err_pci_release_regions: - pci_disable_pcie_error_reporting(pdev); pci_release_selected_regions(pdev, pci_select_bars(pdev, IORESOURCE_MEM)); err_pci_disable_dev: @@ -698,7 +695,6 @@ static void ngbe_remove(struct pci_dev *pdev) kfree(wx->mac_table); wx_clear_interrupt_scheme(wx); - pci_disable_pcie_error_reporting(pdev); pci_disable_device(pdev); } From patchwork Tue Mar 7 18:19:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Helgaas X-Patchwork-Id: 13164451 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF733C76186 for ; Tue, 7 Mar 2023 18:27:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232698AbjCGS1n (ORCPT ); Tue, 7 Mar 2023 13:27:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53132 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232613AbjCGS0E (ORCPT ); Tue, 7 Mar 2023 13:26:04 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EDA2DACBB2; Tue, 7 Mar 2023 10:20:34 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7904F6154D; Tue, 7 Mar 2023 18:20:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AE61DC433D2; Tue, 7 Mar 2023 18:20:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678213233; bh=MunmSilf1uIvYwkUne62rZ2OB+MTJPaCa6o/fBaY2ww=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=OL7VNPNRmW497PB7a+2AZN+2qDuYEp2t6VwUwfrSnPlxUH9CH8RIfXh3QIn1tFtsc 4IXPWVzGdx0Q4cw84ny1sEEgnA734DOVvoxC99FDPZ4hz21SYxobqRORsY131PUaGS Mx4a2gOJ1zFs6UiR3c9RXP6WWw5hKso9cKjTawtZobVlHLGiTUcnrJMRq9UJ+wgcb7 7MSvm87neFbyoQwvOZXFfxSWTgirSoERrJ+vtPqwq/iiyfrvsQMUMeJmZ7YgJa08kF kxg5D3zHX4+Jxjh+3OscgiXT+h/pCvQLda3Jl/p/4S62PcEc80eyfX7BOpDQP+aUmr +EGoDvfy/avJA== From: Bjorn Helgaas To: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Helgaas , Jiawen Wu , Mengyuan Lou Subject: [PATCH 20/28] net: txgbe: Drop redundant pci_enable_pcie_error_reporting() Date: Tue, 7 Mar 2023 12:19:31 -0600 Message-Id: <20230307181940.868828-21-helgaas@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230307181940.868828-1-helgaas@kernel.org> References: <20230307181940.868828-1-helgaas@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org From: Bjorn Helgaas pci_enable_pcie_error_reporting() enables the device to send ERR_* Messages. Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is native"), the PCI core does this for all devices during enumeration, so the driver doesn't need to do it itself. Remove the redundant pci_enable_pcie_error_reporting() call from the driver. Also remove the corresponding pci_disable_pcie_error_reporting() from the driver .remove() path. Note that this only controls ERR_* Messages from the device. An ERR_* Message may cause the Root Port to generate an interrupt, depending on the AER Root Error Command register managed by the AER service driver. Signed-off-by: Bjorn Helgaas Cc: Jiawen Wu Cc: Mengyuan Lou --- drivers/net/ethernet/wangxun/txgbe/txgbe_main.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/net/ethernet/wangxun/txgbe/txgbe_main.c b/drivers/net/ethernet/wangxun/txgbe/txgbe_main.c index 6c0a98230557..859feaafd350 100644 --- a/drivers/net/ethernet/wangxun/txgbe/txgbe_main.c +++ b/drivers/net/ethernet/wangxun/txgbe/txgbe_main.c @@ -6,7 +6,6 @@ #include #include #include -#include #include #include @@ -538,7 +537,6 @@ static int txgbe_probe(struct pci_dev *pdev, goto err_pci_disable_dev; } - pci_enable_pcie_error_reporting(pdev); pci_set_master(pdev); netdev = devm_alloc_etherdev_mqs(&pdev->dev, @@ -698,7 +696,6 @@ static int txgbe_probe(struct pci_dev *pdev, err_free_mac_table: kfree(wx->mac_table); err_pci_release_regions: - pci_disable_pcie_error_reporting(pdev); pci_release_selected_regions(pdev, pci_select_bars(pdev, IORESOURCE_MEM)); err_pci_disable_dev: @@ -729,8 +726,6 @@ static void txgbe_remove(struct pci_dev *pdev) kfree(wx->mac_table); wx_clear_interrupt_scheme(wx); - pci_disable_pcie_error_reporting(pdev); - pci_disable_device(pdev); } From patchwork Tue Mar 7 18:19:32 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Helgaas X-Patchwork-Id: 13164449 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88281C6FD1A for ; Tue, 7 Mar 2023 18:27:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232999AbjCGS1k (ORCPT ); Tue, 7 Mar 2023 13:27:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47058 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232861AbjCGS0F (ORCPT ); Tue, 7 Mar 2023 13:26:05 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AB56B9EF56; Tue, 7 Mar 2023 10:20:36 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4782061501; Tue, 7 Mar 2023 18:20:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7F9C8C4339B; Tue, 7 Mar 2023 18:20:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678213235; bh=+SVjmFeoitwY56tf4BRMZdfwmTz2I/jifxLbrlbtKKI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=oWtSEFrhzjXt8a/O6k9UqI2r94s4dtqMqsGeDqcDGF6HDuPRhrT7Ue8KM8CmZkcDI oV0qhrG0+bs+IVbsU41k8j+IFyOk08/SIu6F7CKfRtQ4CAwmz73uzBnuiVNeRNPWTL 6gu8q1A/uyZYW4YAs9E0+fh0OxArW0VUdR7AZAeBZ/VRAfJmavh8t59IvSsHHtcTnC lcamH9SIsLJS1PcnmWThfdwWj2Oli9qGdyimJjb/Cg97kIuUauyyxRz2jxOmicwxaa 6Je6hdFkLnEClEDU1O9thFDxKPYn3OGMVXsv4y0CDPSPdqshl1/CRmkJOMltz2Y33C Qb8QsU919Vt3A== From: Bjorn Helgaas To: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Helgaas , Jesse Brandeburg , Tony Nguyen , intel-wired-lan@lists.osuosl.org Subject: [PATCH 21/28] e1000e: Remove unnecessary aer.h include Date: Tue, 7 Mar 2023 12:19:32 -0600 Message-Id: <20230307181940.868828-22-helgaas@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230307181940.868828-1-helgaas@kernel.org> References: <20230307181940.868828-1-helgaas@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org From: Bjorn Helgaas is unused, so remove it. Signed-off-by: Bjorn Helgaas Cc: Jesse Brandeburg Cc: Tony Nguyen Cc: intel-wired-lan@lists.osuosl.org Tested-by: Naama Meir --- drivers/net/ethernet/intel/e1000e/netdev.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c index e1eb1de88bf9..6f5c16aebcbf 100644 --- a/drivers/net/ethernet/intel/e1000e/netdev.c +++ b/drivers/net/ethernet/intel/e1000e/netdev.c @@ -23,7 +23,6 @@ #include #include #include -#include #include #include From patchwork Tue Mar 7 18:19:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Helgaas X-Patchwork-Id: 13164452 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2AA3C7618D for ; Tue, 7 Mar 2023 18:27:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233008AbjCGS1q (ORCPT ); Tue, 7 Mar 2023 13:27:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47110 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231965AbjCGS0c (ORCPT ); Tue, 7 Mar 2023 13:26:32 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 868F59DE15; Tue, 7 Mar 2023 10:20:38 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2601B6154E; Tue, 7 Mar 2023 18:20:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 61E8BC4339B; Tue, 7 Mar 2023 18:20:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678213237; bh=xZeCbayYrVhu8ichVDtPhdqLO81L+GFGIOk8oMP+2DE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=XUo/07cFEWvAjxyWxduBiLutX3WEM4TKC2hVQDuBmJePgKmBfdMI8tkKWewBZuIGN anG+98OsZI0huduLILIowWc//50OUGkWqUhZUHQaRVeZh4Cv0l1Ses70zeew7h2auw B/wHXbS+hQy8H6N6ieywODw6aef4cZgvhkJTbqXy0BFLzQIo3B3VOxrZT1b2Ub18X8 zygEfI91JelgNMj5PkTV6tlr4BwxBhhj7ESM24977mVptkIN4D3uo8Dbc0nrQ4hcKF F+VLulD5nlze/YwSuktn+3h/wmbSxDlFOieVW2j9eznpcFOFp8CHAcwAXSY5JHlqGs VGzTTDmlhNYHw== From: Bjorn Helgaas To: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Helgaas , Jesse Brandeburg , Tony Nguyen Subject: [PATCH 22/28] fm10k: Remove unnecessary aer.h include Date: Tue, 7 Mar 2023 12:19:33 -0600 Message-Id: <20230307181940.868828-23-helgaas@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230307181940.868828-1-helgaas@kernel.org> References: <20230307181940.868828-1-helgaas@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org From: Bjorn Helgaas is unused, so remove it. Signed-off-by: Bjorn Helgaas Cc: Jesse Brandeburg Cc: Tony Nguyen --- drivers/net/ethernet/intel/fm10k/fm10k_pci.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_pci.c b/drivers/net/ethernet/intel/fm10k/fm10k_pci.c index 027d721feb18..d748b98274e7 100644 --- a/drivers/net/ethernet/intel/fm10k/fm10k_pci.c +++ b/drivers/net/ethernet/intel/fm10k/fm10k_pci.c @@ -3,7 +3,6 @@ #include #include -#include #include "fm10k.h" From patchwork Tue Mar 7 18:19:34 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Helgaas X-Patchwork-Id: 13164453 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98455C6FD1A for ; Tue, 7 Mar 2023 18:27:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233016AbjCGS1u (ORCPT ); Tue, 7 Mar 2023 13:27:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46888 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231384AbjCGS0j (ORCPT ); Tue, 7 Mar 2023 13:26:39 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1A91D8C805; Tue, 7 Mar 2023 10:20:42 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id C53C0B819D2; Tue, 7 Mar 2023 18:20:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4597FC4339B; Tue, 7 Mar 2023 18:20:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678213239; bh=TljbBfxVOqKVnxlRPxJh7wfvgBgvno87gbT8Pk/fdoM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=nLJa18E5GfrF6pP384PHVfh8oe+OOxkwbv+32yIGw0SQjqXmUtY6jt3VvN1GPSKMV H7lgOgmYuPktGtKoUMzG6lzjdihCOWzuihwAJ5Onu5pJ1upxPPtqzjSay+S47T/jdM lMLmT9tqCwzi0/LEbReV2XQr0yEu83MVQDwHIm0+6WwJHnGA8vMZlCO6F+JQaTgnBi zvkdMHD7XQZIe+C/3xdc3b7UUlx6w/RNA6mUBEYf84GscKPjhiAL6/6qOilHDDihEO aySfDTZ/MQN3ddWiLBNWYB7FBS9OV2SWK6O9DiqTGke9Dtt1kSfaK2UjDHRqM51kAw Z4lr9A/4VEpAA== From: Bjorn Helgaas To: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Helgaas , Jesse Brandeburg , Tony Nguyen Subject: [PATCH 23/28] i40e: Remove unnecessary aer.h include Date: Tue, 7 Mar 2023 12:19:34 -0600 Message-Id: <20230307181940.868828-24-helgaas@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230307181940.868828-1-helgaas@kernel.org> References: <20230307181940.868828-1-helgaas@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org From: Bjorn Helgaas is unused, so remove it. Signed-off-by: Bjorn Helgaas Cc: Jesse Brandeburg Cc: Tony Nguyen --- drivers/net/ethernet/intel/i40e/i40e.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/intel/i40e/i40e.h b/drivers/net/ethernet/intel/i40e/i40e.h index 60ce4d15d82a..6e310a539467 100644 --- a/drivers/net/ethernet/intel/i40e/i40e.h +++ b/drivers/net/ethernet/intel/i40e/i40e.h @@ -10,7 +10,6 @@ #include #include #include -#include #include #include #include From patchwork Tue Mar 7 18:19:35 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Helgaas X-Patchwork-Id: 13164454 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46419C678D4 for ; Tue, 7 Mar 2023 18:28:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232917AbjCGS2A (ORCPT ); Tue, 7 Mar 2023 13:28:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47140 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232871AbjCGS0l (ORCPT ); Tue, 7 Mar 2023 13:26:41 -0500 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 830F6ADC04; Tue, 7 Mar 2023 10:20:44 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id EEBAACE1C79; Tue, 7 Mar 2023 18:20:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1DB87C4339C; Tue, 7 Mar 2023 18:20:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678213241; bh=DE92hw8t8/0nODEhiHkEnnlsRI/SWQU/hTMJS+17V8U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Utqngn8FnD1QnkNMyz105aMZWZvoOdgvgFmcIVsgKcD5AdXJc2DStIs/ktxW+sLe+ r/VsowUTdpMcIUhzozJxqJmvvZV+zh8rtUNF/4/LdpWjfFp5+jSK23u7xq6CJRMD0H FyIj9XEzXItwjHZGittnP0uzi/r1ZeJ5OzhoKNj56q95QC5wR5RxKQPTNtbI2Dtvmh CUgdJT7jpQ+Q5wLpCZITVc53nN8ZOIMlAQmzc2PE6jiKY4fUPz5A1g0qJNB6JHwE5D JG9uzdfgLZz30yrSRglBnn+BWsrsyKi8Zq+Tz/1Iy/fzK84RJXv+EbRcZW4OmvOd2r 2WwWZo5zchL8w== From: Bjorn Helgaas To: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Helgaas , Jesse Brandeburg , Tony Nguyen Subject: [PATCH 24/28] iavf: Remove unnecessary aer.h include Date: Tue, 7 Mar 2023 12:19:35 -0600 Message-Id: <20230307181940.868828-25-helgaas@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230307181940.868828-1-helgaas@kernel.org> References: <20230307181940.868828-1-helgaas@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org From: Bjorn Helgaas is unused, so remove it. Signed-off-by: Bjorn Helgaas Cc: Jesse Brandeburg Cc: Tony Nguyen --- drivers/net/ethernet/intel/iavf/iavf.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/intel/iavf/iavf.h b/drivers/net/ethernet/intel/iavf/iavf.h index 232bc61d9eee..2cdce251472c 100644 --- a/drivers/net/ethernet/intel/iavf/iavf.h +++ b/drivers/net/ethernet/intel/iavf/iavf.h @@ -6,7 +6,6 @@ #include #include -#include #include #include #include From patchwork Tue Mar 7 18:19:36 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Helgaas X-Patchwork-Id: 13164455 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E169FC678D5 for ; Tue, 7 Mar 2023 18:28:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233036AbjCGS2C (ORCPT ); Tue, 7 Mar 2023 13:28:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55912 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232918AbjCGS0l (ORCPT ); Tue, 7 Mar 2023 13:26:41 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0ED3B9FE75; Tue, 7 Mar 2023 10:20:44 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9EDC5614E8; Tue, 7 Mar 2023 18:20:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DCAE3C4339B; Tue, 7 Mar 2023 18:20:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678213243; bh=9iCFzc2QqDeX+XEzEK67hx5JvvMn4Tky3ek230eHt58=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=C1fCVlZuEjlME/3MHfneKNMrZpZPMBpAR54NxEVX9f9z9SBbJY5ThjOaSsZtd0hjm 7ABLWkyDbB5p5gU+wEYQBijE7HsIxdm12esRd2gAbMz63Mqr+BEIuf52d0VjJRCvO/ /soT7vjH7mBIxwxXk5SHQDldKVKGmOBKzoLHBku0ePxEX2fnvhi+CKJxYFdFPf+p13 6PXBzT2iYQ50VyeiHY6xOTNhLFNujTcbS7bIEHplIEtyd9vr8yAMaI5OXUjtHDszZN LVMrHo/+924GJVNvM2+DOwlyefYAWk9HR5po9rHlhcfSUxQhLzqYz73fL+aoFwNgqp IosK++mBocb0Q== From: Bjorn Helgaas To: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Helgaas , Jesse Brandeburg , Tony Nguyen Subject: [PATCH 25/28] ice: Remove unnecessary aer.h include Date: Tue, 7 Mar 2023 12:19:36 -0600 Message-Id: <20230307181940.868828-26-helgaas@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230307181940.868828-1-helgaas@kernel.org> References: <20230307181940.868828-1-helgaas@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org From: Bjorn Helgaas is unused, so remove it. Signed-off-by: Bjorn Helgaas Cc: Jesse Brandeburg Cc: Tony Nguyen --- drivers/net/ethernet/intel/ice/ice.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/intel/ice/ice.h b/drivers/net/ethernet/intel/ice/ice.h index b0e29e342401..d79a48d27f1a 100644 --- a/drivers/net/ethernet/intel/ice/ice.h +++ b/drivers/net/ethernet/intel/ice/ice.h @@ -20,7 +20,6 @@ #include #include #include -#include #include #include #include From patchwork Tue Mar 7 18:19:37 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Helgaas X-Patchwork-Id: 13164456 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 992FFC6FD1A for ; Tue, 7 Mar 2023 18:28:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231965AbjCGS2C (ORCPT ); Tue, 7 Mar 2023 13:28:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49636 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232921AbjCGS0m (ORCPT ); Tue, 7 Mar 2023 13:26:42 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 83ABD9FE7E; Tue, 7 Mar 2023 10:20:45 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6297C61549; Tue, 7 Mar 2023 18:20:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A189DC4339B; Tue, 7 Mar 2023 18:20:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678213244; bh=B4VcwYAM8bIrgPqF9a1HoFkWWXvHnK9JzfKrJBVVkrk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=AREF4cEThPeBwKNSseOGHlvfxoR0rEQndHAbN2MwMZ8bbR/lhvFWmNTuP2wRwW4nn wGP+QacNy3JQNFgZHbnYV+d/1rn6UqxuoOwGEF+vkddmqrPrps/dEI/hpM2r1w9YMm q5tASJwLRdTaOp6LLLP4ivtmY0Yps7xheOQVlET0cSCszuRieZcEHl4opod7Ys/fiA rRXm+EI8yamLqOBdjAXsh5bFJb74OeFLUsR7tP0t/iK7hXki7jFr0uTAKw9WADFPFf sZGfkntTOtdpLWPO361RNNrxbNdB78dtrQzoEf75REJbJuF1sZgH2m6vPQ7z7xeq/Y VUelKPnwgl4iA== From: Bjorn Helgaas To: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Helgaas , Jesse Brandeburg , Tony Nguyen Subject: [PATCH 26/28] igb: Remove unnecessary aer.h include Date: Tue, 7 Mar 2023 12:19:37 -0600 Message-Id: <20230307181940.868828-27-helgaas@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230307181940.868828-1-helgaas@kernel.org> References: <20230307181940.868828-1-helgaas@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org From: Bjorn Helgaas is unused, so remove it. Signed-off-by: Bjorn Helgaas Cc: Jesse Brandeburg Cc: Tony Nguyen --- drivers/net/ethernet/intel/igb/igb_main.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c index 03bc1e8af575..a2914298dd69 100644 --- a/drivers/net/ethernet/intel/igb/igb_main.c +++ b/drivers/net/ethernet/intel/igb/igb_main.c @@ -28,7 +28,6 @@ #include #include #include -#include #include #include #include From patchwork Tue Mar 7 18:19:38 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Helgaas X-Patchwork-Id: 13164457 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6B61C678DB for ; Tue, 7 Mar 2023 18:28:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232555AbjCGS2K (ORCPT ); Tue, 7 Mar 2023 13:28:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48616 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232927AbjCGS0n (ORCPT ); Tue, 7 Mar 2023 13:26:43 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8245BA2F0D; Tue, 7 Mar 2023 10:20:47 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 506586154A; Tue, 7 Mar 2023 18:20:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 84A4FC433A7; Tue, 7 Mar 2023 18:20:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678213246; bh=5kvX7HRO05Aqml11yDkUPLOoDba6HFrNQVxp5lmDDUQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=FK4V3NNMm3OmmicVSOfFo5G7t1hG8HSWU2y2l8IZBlHXe54s9gGhWvdB9z0BiisX4 oxArsMFWaWeWzsBJQ2JRgSTNNi5GW9DM/DgGWesgfBDn703ldoyna4auED7QRfPICM qe47K41avRIjFxUZJ1xp8Ks6aMf2V+nGmngAP8tEsVlFESKaY/7R5wLo0Uni1pR+AU 6WZtQfJEqeqIc7OOcsasLTkXlaokiYjAbDXVtv380HMwi4dKLucxqN55gLa4f0Pv6Y XaOfbJoHAml01pQB9x242M+QP2bYqTOlsiPpVkfSrUCEOtxZnbnmclxsAexaLR13O9 iPbSeGpBsFgzQ== From: Bjorn Helgaas To: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Helgaas , Jesse Brandeburg , Tony Nguyen Subject: [PATCH 27/28] igc: Remove unnecessary aer.h include Date: Tue, 7 Mar 2023 12:19:38 -0600 Message-Id: <20230307181940.868828-28-helgaas@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230307181940.868828-1-helgaas@kernel.org> References: <20230307181940.868828-1-helgaas@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org From: Bjorn Helgaas is unused, so remove it. Signed-off-by: Bjorn Helgaas Cc: Jesse Brandeburg Cc: Tony Nguyen --- drivers/net/ethernet/intel/igc/igc_main.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/intel/igc/igc_main.c b/drivers/net/ethernet/intel/igc/igc_main.c index 2928a6c73692..d7ee06d28b50 100644 --- a/drivers/net/ethernet/intel/igc/igc_main.c +++ b/drivers/net/ethernet/intel/igc/igc_main.c @@ -4,7 +4,6 @@ #include #include #include -#include #include #include #include From patchwork Tue Mar 7 18:19:39 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Helgaas X-Patchwork-Id: 13164458 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B021C6FD1B for ; Tue, 7 Mar 2023 18:28:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232879AbjCGS2S (ORCPT ); Tue, 7 Mar 2023 13:28:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48900 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231942AbjCGS04 (ORCPT ); Tue, 7 Mar 2023 13:26:56 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 328EEB06E1; Tue, 7 Mar 2023 10:20:51 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id BFB81B819C5; Tue, 7 Mar 2023 18:20:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 58D7EC433D2; Tue, 7 Mar 2023 18:20:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678213248; bh=+/3xSbuw/CpH0rA4rIXLVesO5yLlQvOJu29BU7PVVoc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=aAnO2XEy5qZvJxmDdRFRtFW4oc5onWVDPLMtG2u/zbdf9AS+1k5d8FRe1IVYemhJH CrtZU3AizKsrYNKmer+v86N0ejAkseLmfChJJa0NkJCg6PfmVN+t8IRzNGXupdkcNq g28NWJ4I5mDDwWIwkoqzalvfH/WTBJc20FqKd/YsWHOLFjugygkaql6exqSU9dekhX lH/+XJk+ognGipPn9IWB8imwUqMhdRTgarzzJ70RD2hITCOeza3+aju6izuyIT7n8S ktL2Z9XTAd/6BDdlewRzvOQhxzwRHSxXb6jgFDQPftTTMeN1/wziRB/6COeBxXSogE l4kYlvA/XmXig== From: Bjorn Helgaas To: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Helgaas , Jesse Brandeburg , Tony Nguyen Subject: [PATCH 28/28] ixgbe: Remove unnecessary aer.h include Date: Tue, 7 Mar 2023 12:19:39 -0600 Message-Id: <20230307181940.868828-29-helgaas@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230307181940.868828-1-helgaas@kernel.org> References: <20230307181940.868828-1-helgaas@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org From: Bjorn Helgaas is unused, so remove it. Signed-off-by: Bjorn Helgaas Cc: Jesse Brandeburg Cc: Tony Nguyen --- drivers/net/ethernet/intel/ixgbe/ixgbe.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe.h b/drivers/net/ethernet/intel/ixgbe/ixgbe.h index 8736ca4b2628..63d4e32df029 100644 --- a/drivers/net/ethernet/intel/ixgbe/ixgbe.h +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe.h @@ -9,7 +9,6 @@ #include #include #include -#include #include #include #include