From patchwork Thu Mar 9 09:45:59 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiri Pirko X-Patchwork-Id: 13167144 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F03AC61DA4 for ; Thu, 9 Mar 2023 09:47:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230056AbjCIJrZ (ORCPT ); Thu, 9 Mar 2023 04:47:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33884 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230100AbjCIJrG (ORCPT ); Thu, 9 Mar 2023 04:47:06 -0500 Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 63AF3E38A8 for ; Thu, 9 Mar 2023 01:46:03 -0800 (PST) Received: by mail-wm1-x32d.google.com with SMTP id l7-20020a05600c1d0700b003eb5e6d906bso788181wms.5 for ; Thu, 09 Mar 2023 01:46:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20210112.gappssmtp.com; s=20210112; t=1678355162; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=7ByKEWC2al4eO3WGl73gO3Qu6gf7BRWv6Uu6cBRRz4Q=; b=SHp7EWFOp+RCs04Sq0K3DdZkvjuxmSl219/U67X2zF2O+BIkhR+F6dYilwFXN216Gf yPQcx61pmaNLI1B93ZCa9iL4xy0993dqSAxIBJNgm01LcGxf1PSWR1wEy6qa36WB1RD1 yT3vY2+tVK+k/VwG+r3L/7xLjNrjOs2ACUZFACq/oq0dtSi5Kasx+AJA1lZwYFvNFDKZ 3kQSEr+FQFwj56xwhKkWl+hRKx1bGJd5r50vA7XdXh53rI23b0gEfxc6LNwrjm+sbias GqRAtnDDbUcxO/GgpttDmiQF2GLZ976nkAfKtxtvAE6/uij6duviLVeVFrqpu5O+WkRp B2cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678355162; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=7ByKEWC2al4eO3WGl73gO3Qu6gf7BRWv6Uu6cBRRz4Q=; b=c+Lfm40q/SMIxqFbAhGM6srjpQmO1+qTgEvZwZnNonDNzYBIRgzaWG87shAVP+ccye qDD6dCpAhpbwRHAtT82N10jxCDSlUi67NiXb82iivjVGiwW+bJdNz6vkpwWFZQ2OkXNN NEIJ4Ef+olUtm1FA+nY4rLltbrvIQLyaUbXhhCkjrbO/XV/1gS9LWKFn9KkaIrbYC2fo zs0K0aOG+k+dzD2CrnMy9iPaXLbkt1t+gbRvuMR3gKX0wXeTyWMcvzJ4VmScqjvpMlrm f+QT3unPpjGTXJZc9xWqwYLbNCcp04xFS/0+gzRd/PhzJ3bmmYxvHa1jAzWoSqP+z0Gv uOJw== X-Gm-Message-State: AO0yUKU3rX89rvHgOVuYs29U26S3qCtDEYpEVopqtmg2nLzWHQcd/iB1 hx6Z4zjAPWEp00KIliz1HMRSQ6AVXo5bi7pzSqg= X-Google-Smtp-Source: AK7set8nKKC49FrVDccv+YmIlOYV+yfiCeCYeWkacvZgL8H/czWgD+J2n66tqM33cG9WVnfYPXqUqg== X-Received: by 2002:a05:600c:a08:b0:3eb:2e32:72b4 with SMTP id z8-20020a05600c0a0800b003eb2e3272b4mr18729981wmp.15.1678355161838; Thu, 09 Mar 2023 01:46:01 -0800 (PST) Received: from localhost (host-213-179-129-39.customer.m-online.net. [213.179.129.39]) by smtp.gmail.com with ESMTPSA id o8-20020a05600c510800b003e215a796fasm2287099wms.34.2023.03.09.01.46.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Mar 2023 01:46:01 -0800 (PST) From: Jiri Pirko To: netdev@vger.kernel.org Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, edumazet@google.com, mst@redhat.com, jasowang@redhat.com, virtualization@lists.linux-foundation.org, alvaro.karsz@solid-run.com, vmireyno@marvell.com, parav@nvidia.com, willemdebruijn.kernel@gmail.com Subject: [patch net-next v4] net: virtio_net: implement exact header length guest feature Date: Thu, 9 Mar 2023 10:45:59 +0100 Message-Id: <20230309094559.917857-1-jiri@resnulli.us> X-Mailer: git-send-email 2.39.0 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org From: Jiri Pirko Virtio spec introduced a feature VIRTIO_NET_F_GUEST_HDRLEN which when set implicates that device benefits from knowing the exact size of the header. For compatibility, to signal to the device that the header is reliable driver also needs to set this feature. Without this feature set by driver, device has to figure out the header size itself. Quoting the original virtio spec: "hdr_len is a hint to the device as to how much of the header needs to be kept to copy into each packet" "a hint" might not be clear for the reader what does it mean, if it is "maybe like that" of "exactly like that". This feature just makes it crystal clear and let the device count on the hdr_len being filled up by the exact length of header. Also note the spec already has following note about hdr_len: "Due to various bugs in implementations, this field is not useful as a guarantee of the transport header size." Without this feature the device needs to parse the header in core data path handling. Accurate information helps the device to eliminate such header parsing and directly use the hardware accelerators for GSO operation. virtio_net_hdr_from_skb() fills up hdr_len to skb_headlen(skb). The driver already complies to fill the correct value. Introduce the feature and advertise it. Note that virtio spec also includes following note for device implementation: "Caution should be taken by the implementation so as to prevent a malicious driver from attacking the device by setting an incorrect hdr_len." There is a plan to support this feature in our emulated device. A device of SolidRun offers this feature bit. They claim this feature will save the device a few cycles for every GSO packet. Link: https://docs.oasis-open.org/virtio/virtio/v1.2/cs01/virtio-v1.2-cs01.html#x1-230006x3 Signed-off-by: Jiri Pirko Reviewed-by: Parav Pandit Reviewed-by: Alvaro Karsz Acked-by: Michael S. Tsirkin Acked-by: Willem de Bruijn --- v3->v4: - fixed double "which when" v2->v3: - changed the first paragraph in patch description according to Michael's suggestion - added Link tag with link to the spec v1->v2: - extended patch description --- drivers/net/virtio_net.c | 6 ++++-- include/uapi/linux/virtio_net.h | 1 + 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index fb5e68ed3ec2..e85b03988733 100644 --- a/drivers/net/virtio_net.c +++ b/drivers/net/virtio_net.c @@ -62,7 +62,8 @@ static const unsigned long guest_offloads[] = { VIRTIO_NET_F_GUEST_UFO, VIRTIO_NET_F_GUEST_CSUM, VIRTIO_NET_F_GUEST_USO4, - VIRTIO_NET_F_GUEST_USO6 + VIRTIO_NET_F_GUEST_USO6, + VIRTIO_NET_F_GUEST_HDRLEN }; #define GUEST_OFFLOAD_GRO_HW_MASK ((1ULL << VIRTIO_NET_F_GUEST_TSO4) | \ @@ -4213,7 +4214,8 @@ static struct virtio_device_id id_table[] = { VIRTIO_NET_F_CTRL_MAC_ADDR, \ VIRTIO_NET_F_MTU, VIRTIO_NET_F_CTRL_GUEST_OFFLOADS, \ VIRTIO_NET_F_SPEED_DUPLEX, VIRTIO_NET_F_STANDBY, \ - VIRTIO_NET_F_RSS, VIRTIO_NET_F_HASH_REPORT, VIRTIO_NET_F_NOTF_COAL + VIRTIO_NET_F_RSS, VIRTIO_NET_F_HASH_REPORT, VIRTIO_NET_F_NOTF_COAL, \ + VIRTIO_NET_F_GUEST_HDRLEN static unsigned int features[] = { VIRTNET_FEATURES, diff --git a/include/uapi/linux/virtio_net.h b/include/uapi/linux/virtio_net.h index b4062bed186a..12c1c9699935 100644 --- a/include/uapi/linux/virtio_net.h +++ b/include/uapi/linux/virtio_net.h @@ -61,6 +61,7 @@ #define VIRTIO_NET_F_GUEST_USO6 55 /* Guest can handle USOv6 in. */ #define VIRTIO_NET_F_HOST_USO 56 /* Host can handle USO in. */ #define VIRTIO_NET_F_HASH_REPORT 57 /* Supports hash report */ +#define VIRTIO_NET_F_GUEST_HDRLEN 59 /* Guest provides the exact hdr_len value. */ #define VIRTIO_NET_F_RSS 60 /* Supports RSS RX steering */ #define VIRTIO_NET_F_RSC_EXT 61 /* extended coalescing info */ #define VIRTIO_NET_F_STANDBY 62 /* Act as standby for another device