From patchwork Wed Mar 15 07:24:20 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 13175454 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AA4A8C61DA4 for ; Wed, 15 Mar 2023 07:24:50 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.509915.786654 (Exim 4.92) (envelope-from ) id 1pcLUq-0007fv-6K; Wed, 15 Mar 2023 07:24:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 509915.786654; Wed, 15 Mar 2023 07:24:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pcLUq-0007fo-3R; Wed, 15 Mar 2023 07:24:28 +0000 Received: by outflank-mailman (input) for mailman id 509915; Wed, 15 Mar 2023 07:24:26 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pcLUo-0007fe-O8 for xen-devel@lists.xenproject.org; Wed, 15 Mar 2023 07:24:26 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0610.outbound.protection.outlook.com [2a01:111:f400:fe1f::610]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 69ac9713-c302-11ed-87f5-c1b5be75604c; Wed, 15 Mar 2023 08:24:25 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB7573.eurprd04.prod.outlook.com (2603:10a6:20b:29e::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.26; Wed, 15 Mar 2023 07:24:23 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%5]) with mapi id 15.20.6178.026; Wed, 15 Mar 2023 07:24:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 69ac9713-c302-11ed-87f5-c1b5be75604c ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CNaNuoY4VM8ewDmseUKih7nXLwWLmmGS1BLb/6rL09JRY+OGWyXd/kVgoOwx5z0ABqYb7VgFXxu3c+eLxMfntZAbzsz0NwXg3XQtxr6/fbdtOBAiGFOE5LLJjRLi/YUmHXmwfZRTIdP7h5EUVSBq9U+Bzd1xy0m+gaYHWnevj1w8gBGe5WMrK/LJSYpjmesCULsEPex64ZgRJUWlE1y+JU9iHUY7cyZnfWnJw7fRTxZ/57V05Yfg/bnwpAUtudaM73/PoNxs1zvSJ0mlg/EeAtLw0Ld6Bv5eAzww8usmQY/eliXlLus/dZ+QETYmAjTugwEq6brFQuERMo5pvGn6dA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zy43YTDBLchV6lc1Ez9wzpmHlHRHzwz/MU0HLqd7/t4=; b=HNhrZ6F9+bYF7eITvxpawp8bYSmzrKj1YTOQS1LUZxlEgeoFvZGtaRejC6ssZlakvPL6TljwOHPDm0XFe+QTp+NT6z6vv/NuR/P2SvhrKhtMx5gazNVX/e+TCn0qqo6lT9YB4mOYpcO2m1KBddUnntZg9Fbk++SxQ3peg+p1zZr6TnSl8dfxRCXvl5zR/DEsNq21ph/r+fpm+oDplWqWWXGpSoM1UbvLhgvTppmy7RjOHxtRJfKOVxzjlpif7Sn6RW+/oSjXUdHd9W+IhT+iIQetU+xwyrhgwFPpSWuze3woCWFG6YnWCW1NasC6n/PzXJ/edKR/C/iCaoqDWUNaQw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zy43YTDBLchV6lc1Ez9wzpmHlHRHzwz/MU0HLqd7/t4=; b=P3G9VoHWW2nSBubaySN+OeKiMne756Bnx5PzeYwMLcAPvVUEKxjvm3++QR6kE10a0qrEzdNSdLYN8tHvz82Du5Kql3y/ZUTjRKUeR78yFQG475mF/vwEJHJQVO+7UM5Xc69msaMSdDT6xx2gEt54kygQKr4ARK6C/JnQUq4G4xkGdA5f4QFLZMc4+c4JBD3fEkA7l0ExVNlAYYftojY5UJoIXLEFN0R0yCkVTXsbAiM0tn7W8cI7Gn944PZusI/tqw9keWGZ2rkDnLFcsEcOugaWFNxlGLOleKwcjYQrI31kwv/CgJ5+p/B0qkVZgo8GADdCDSaLVnYIgF6fb/Ohbg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 15 Mar 2023 08:24:20 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu From: Jan Beulich Subject: [PATCH] console: use more appropriate domain RCU-locking function X-ClientProxiedBy: FR0P281CA0145.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:96::18) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB7573:EE_ X-MS-Office365-Filtering-Correlation-Id: dceabed2-55a0-4f4b-b3b9-08db25264cdc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: D0uaYYemXMCVOsaY2DQwlitx7oQJjUMKksS7oWBhhtGaue64spvJMPVuKgLRgletmcuaP0yMNeKovom2nSZANwRnNIi48pShF9FGrxbplgvOZpkNeRiv/yEP0xsVYAuBiPvloakCFdyiCIqT0/4c6VRxjsJz1TTXE6ZPFclzWcTuqXZ0IMajvgL2kESkiEoOgOcF1nHgk+wlW0EDDAqgRuhdwwh0t11HIIHdn1DRoCmZ3DQE0AB7RPgPtzfjsJQlHaxSJFSSrRjelZJS8DHwCNjCujRItNMR19gq0YLms6wnf1XkiG8NKwS2/iDkACdBogzpLql9Vpu54m1Es3bwtPuTLM0njCPdRqLLp0/K81w7FSnEMJQOcYHLhMbNqNuobZlCrMU7p2St4/hbEFLKwtNBYEDSUpnnESX44WX+kD0PT4UpXZ4SViVs4lMqYsSdBwYuwACLIeIuEQs3M8Ft/2VhYMzAtkj960kpTmzOcTg7DIDqp9y5LxOcnA+TdPtTDjp0UqDIU/fo9c6Mbp6qlsLUi4RNDckrza+vz/hTexm/vJ4CpNi+wAmE6g9dEsmsYQyDVoUNdqjGKzDINRZ1rhF07szhNHgh4IIuJXDIppD+rTc5TnX7u66fe/QZ9YSTkf0G5y6xjNaWr/iN2P2E8aGOmJhpAK/PnfDH9TnMYYp1oop0ydgfA9a6eRhoq6jBqCprp1oGxP97/7yHcFTurX7BMWgS4CfPC4ho/66epvk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(366004)(376002)(396003)(39860400002)(346002)(136003)(451199018)(36756003)(4744005)(5660300002)(83380400001)(478600001)(186003)(6506007)(6512007)(6486002)(26005)(2616005)(316002)(54906003)(66476007)(66556008)(6916009)(66946007)(8936002)(31696002)(4326008)(41300700001)(8676002)(38100700002)(86362001)(31686004)(2906002)(66899018)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?g9u34+gxXKIQEVqIiFVlLD/ksIsk?= =?utf-8?q?0FVjtN7Qhet2x7Xb1rkqtL225YCs2WR6vT56Gcd6Z3l88AZaJ5+IJJhmEBinZHE4K?= =?utf-8?q?e7xwPNfF5kNSfgkeM/spr12QjrP7LQFoaTwqEdCjTJdD8Y0ExbQQ+wxp9LaKbJNi0?= =?utf-8?q?t6olygLm4vFMXLVhCJGEL1HAicBgxg1X9UjfKCur4FELDFZYhMLZ84IqwvoPHn8BH?= =?utf-8?q?BCfBX6Wa6qNGT6BQsXv/BRySrN3tRJGphM5IbKiHO+7gqXsNlAudWGg+WD9o242ux?= =?utf-8?q?7FZVe8TdPZYPC96KQD/U1R6P5Kl3FfpDH7WiORGt/IOKaMaMXwiFCvda2lc5Or3VV?= =?utf-8?q?IfvADXbvDKHm1B3flWM+jXhe3Y7N+sv7rldmapvPZaTOdgHXrQ+FfKZBTh7Pa7LPh?= =?utf-8?q?kH9vqAUY93VOyHbU1fW9N4ZH7rV/0Dlnc+lUISYNo1JLSDe9ZpwMB1+5anc6togfm?= =?utf-8?q?VKm+mC+l9Hvv4acxVM8LCsUvhYcPeZEx8Ts8zV8UsQ0xyJeUClST8gK4dL+C2uwfw?= =?utf-8?q?4+rRVyA+U1ZgqLm34X5n7O3KN69f1zT0wjh0QOSkwCAVYFDrFYSfAfEtdD0QaX7vh?= =?utf-8?q?HekjYhPzj6YFfMIF9zrGRUz++8cRtxHYSIMxD0Y0VuXlsJYF1VinE9kvTBibW+0mm?= =?utf-8?q?YrRULdZ59hIERGC5e4TCd2MHlZZBf6/ei1tB3Wjer4K+lXA8uT3ELvmlxaaY7xmqp?= =?utf-8?q?dLqZylTUPscwGeh0kt9AqNcy9KXon0bIdOFV1SM4dWXrdjBtRSrd7yh9n4PnvJucS?= =?utf-8?q?sjyZ/0ElPSkfy5dCjnM1xTVssf0PNJxyva2nJW7dmWbhRS/GldPGcILKDaoPdrkWz?= =?utf-8?q?RmoOw2l/mjrRka4+wM+N62jIdWLefx1ao7MdcCaYMWgY3A93yqXiyLoEhO99DkiQ4?= =?utf-8?q?a8SlEoXI56/PTWboyJOjpCleFDIxCxSbL/fTKxlWdr+A8JtFQJAJOfmuJRD9jaYHA?= =?utf-8?q?LXHfFO5JiXIlsLH0X63QoXwLJD+3pJ0LtW/4DL8rsXZ2p2c8UwKdCLkh8YIVh2dZ9?= =?utf-8?q?PDk6BhCQvbiDUwdZ8Ihx9sEeO7JIXRD/3HxPVPF9Sbx9z8VP96bKpivh7QfiVaEEm?= =?utf-8?q?/mlElXsrAJahAuSAi9ZkemD/wlLuJbO7m98aOOaxa3RITITv5BVuedK3wn9Z8k0ht?= =?utf-8?q?5/O1TEcjLjV2Odn7YsfccVZtCSEEI6pjHEJps1yflVj8BKorZZZuE0AfYAZADHdG3?= =?utf-8?q?8Zo0ATkm+zSkUAZCjQLnCgGeTEMIFx11lq4jH4XDP6DLXw5xfYVhp2vCoBoABJxIT?= =?utf-8?q?Ci3IhaKI5BEmIaXgGvHB7X7pu6ZOxRC68afr08IVGo295XhxKxg1CE4mMzK9tDM2U?= =?utf-8?q?+HcnPhCIKvwBM6Fq5uvyGqkNPywkCenLUBmfYobDCD7OZo/T8T7HbYx/WwvA90jrS?= =?utf-8?q?L6+cG8VGFu3W/2hpYtBycFFoqMuBqPjr56nPuYtEAurZ+R+HG5yI3QYtGD6a5U6yz?= =?utf-8?q?pYMDm+yhAya1hvumdGiTofDY8tDOKsrpLVPZh9bnHIlVgAWtr1oQt38S2p4harn0o?= =?utf-8?q?zvMAYVCKMoRC?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: dceabed2-55a0-4f4b-b3b9-08db25264cdc X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Mar 2023 07:24:23.2824 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: mahzIxcqnMqwYo3vF5vWWohDdRpWv+9aYkFc7IuzLjKSDFwUD4FFSg+aAhM7BXwCRy2DguFJP1w+ID2pyXEVtg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7573 While both 19afff14b4cb ("xen: support console_switching between Dom0 and DomUs on ARM") and 1ee1e4b0d1ff ("xen/arm: Allow vpl011 to be used by DomU") were part of the same series (iirc), the latter correctly used rcu_lock_domain_by_id() in console_input_domain(), whereas the former for some reason used rcu_lock_domain_by_any_id() instead, despite that code only kind of open-coding console_input_domain(). There's no point here to deal with DOMID_SELF, which is the sole difference between the two functions. Signed-off-by: Jan Beulich Acked-by: Andrew Cooper --- a/xen/drivers/char/console.c +++ b/xen/drivers/char/console.c @@ -525,7 +525,7 @@ static void __serial_rx(char c, struct c #ifdef CONFIG_SBSA_VUART_CONSOLE default: { - struct domain *d = rcu_lock_domain_by_any_id(console_rx - 1); + struct domain *d = rcu_lock_domain_by_id(console_rx - 1); /* * If we have a properly initialized vpl011 console for the