From patchwork Tue Mar 21 12:38:35 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Katakam, Harini" X-Patchwork-Id: 13182706 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 20684C761A6 for ; Tue, 21 Mar 2023 12:39:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=E9Pf7uhOFSMKaTwNp7bqbW2aFL4c7INujhTGRZ7snNU=; b=WrzUZqE3PlkSaW dHk9V+tcdy/x9pexz5gXRs8VmuKddR0a8zHKF0fg6zTl2vBb/s4kCl4XTL6coXL+r5n19DFQ7RGli nl5+M1JDRrijhw1kNagkRuCCpvCyOOs/mwH8D6yTSiStnIUbxE4uLOv8C8zDvy/5WQUGxFj5owZ2k ynhegN3g3/+1fZjAQcO+CwDr+oUOHssrPTTkS9E1NFdEGrShn3l7N2A/Ye7SDIMNBxGar2hZCIt0I Hi7mc0DNLMTIQYrh+1q0g842tU3gwa+b04dn9IT+80MEVVdyBFj8OSthBZpui2MDz9DXcoC35lFwm Tj9F/Jcx8EV8/Imqlcaw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pebGa-00CM8N-2t; Tue, 21 Mar 2023 12:39:04 +0000 Received: from mail-bn7nam10on20620.outbound.protection.outlook.com ([2a01:111:f400:7e8a::620] helo=NAM10-BN7-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pebGQ-00CM4q-2L for linux-arm-kernel@lists.infradead.org; Tue, 21 Mar 2023 12:38:56 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Dmfg2EDBRoPvyOPyEo4JsZ5h+R2Fp8KWUEiNRSsQJfiVCZKYlOpoCd8oMvLSHl0iprNaK1jnYPj0/mtiK0R2r6zVtnhh2wv4bapmx/5H/hFFZqEUuAVSKpsLEi8vfSa4hJ92CKf9TQ7Hgq6+CfacZECjkzc/p7QtfsLyfKEKnq+W4PTmm8uiwzwzq64R0ufuNA4LHmA4XVScLFXm7m6XjQPsa0XbMCQj5CkKgDGXqXlA7VhROZ9+AcnQrWeXE70CPysBC9xcwXYzr6Tzj/VVjU2CZe1IetzGeJHvAvtrzAB8xeIcg92AxMv38EG7pwriGKMGHmv39tIZJ1qm5OL6KQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Gi05toNJXz/rs0Dvqoiewl4UTdYJxCp8LhCVrGszmM0=; b=O2tDMVtP/I2uo0N9ySKFMTG2N9oZR2Q+OY7tB3CmMzcjhT5c942eVjrz1kjHCA8cHP2zHTo/3kl6BZd915QbQe8H9Irf4GL4rZXrsXgeKR6W+kvLBT/lF92SkN6U8S9bPKZM7Ag2wLGCtcxqHc163LtRfjT6ZXFmkzX75lSA74THV2MvXRNsz1LXs8DymIoE0HvnRJM1iLEgiqiJyNIyyKYx6BRjxeGantancj92yOmHraKBzFJjwQh6IhDeNPD+gMR05s/FFRSh/6Ws1K+lXugNLvLNGPVcJN7WBj8+p+X+nuvBVMYH+ZMZXB/LHuUHljystpk9xzSBeEBKKrStyQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=fail (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=xilinx.com; dmarc=fail (p=quarantine sp=quarantine pct=100) action=quarantine header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Gi05toNJXz/rs0Dvqoiewl4UTdYJxCp8LhCVrGszmM0=; b=2to/w2NTgt5UB2WJD6t8OBf2TP3HSqo35rBrXIHeR0cKlzEsilzaQGXX5LRRk/Zuo6Y2APVtuc9p9ETQORPHMz92gnDbb3XcdITsaFkeawiFmEz2O2c0OMcxw6ThwnvMTTZ2wuqyOxGe+q9yDQj5fsiDQi57xzrEp/ygZCAwdn4= Received: from MW2PR16CA0063.namprd16.prod.outlook.com (2603:10b6:907:1::40) by DM4PR12MB5795.namprd12.prod.outlook.com (2603:10b6:8:62::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.37; Tue, 21 Mar 2023 12:38:47 +0000 Received: from CO1NAM11FT108.eop-nam11.prod.protection.outlook.com (2603:10b6:907:1:cafe::38) by MW2PR16CA0063.outlook.office365.com (2603:10b6:907:1::40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.37 via Frontend Transport; Tue, 21 Mar 2023 12:38:47 +0000 X-MS-Exchange-Authentication-Results: spf=fail (sender IP is 165.204.84.17) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=fail action=quarantine header.from=amd.com; Received-SPF: Fail (protection.outlook.com: domain of xilinx.com does not designate 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1NAM11FT108.mail.protection.outlook.com (10.13.175.226) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6222.16 via Frontend Transport; Tue, 21 Mar 2023 12:38:46 +0000 Received: from SATLEXMB08.amd.com (10.181.40.132) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 21 Mar 2023 07:38:46 -0500 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB08.amd.com (10.181.40.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 21 Mar 2023 05:38:45 -0700 Received: from xhdharinik40.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Tue, 21 Mar 2023 07:38:41 -0500 From: Harini Katakam To: , , , , , , , , , , CC: , , , , , Subject: [PATCH net-next v2 1/2] net: macb: Enable PTP unicast Date: Tue, 21 Mar 2023 18:08:35 +0530 Message-ID: <20230321123836.6906-2-harini.katakam@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230321123836.6906-1-harini.katakam@amd.com> References: <20230321123836.6906-1-harini.katakam@amd.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT108:EE_|DM4PR12MB5795:EE_ X-MS-Office365-Filtering-Correlation-Id: 2fb57b0c-dea9-4613-d678-08db2a093728 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: amHUDj2H7AeQ1rA1yw9cNXuRUYqXJRhlJgrxtIvV4CV+jkCxIg75++RFbhqOwg8QabcLpUSpxnSz4Cat03cwUUVG9mvd7hJ2brvQn4l//2yFmgkUczJX/64FGBKDuODWoARyNKXKm+ao3+PnU5VWcpkXxJ0J/YYeP0sQl0kKHt8miBO2KX4l5nx4XCg77nfBPlekzOe0eP7PVn+7HENj23jijio4JmOAVLO4lkDYUgApQgA4o0RgNxUqM8QR/42uZg6X1IT95tYpuOA+bLDQNLo7oDDbiC7gvjjqZxPkylJWYM9JxoDIEgwmIfAuPUaEHtgwk74rMInFGBwr55YOW90C11+LFJ5FA20kGyB/1YE0Wd0dmXCKW+pci9eX5U7RSphGsM+3F5VmslJHUgJS+QLi8DTBEurA7NwSdsjpA0fgEbn/R/76jpSYxmks746MKtIW9mix1vjuTAOSklxeZFo8UVCm/ocnP3IcgkeaZoz8v2KIurivfwQ9IDsIvfcTEpWKiclMt8sCKMF35GMgQ3WNRBStLv1DvQ4IEQ7r0lTKayGzQmjR57DQ/eFWDn7+7mr/jc5v1ECXkz+xybiDfFNoRmJr40ihFj1D1DToGFBI4k2aNgqYkYVetLAU3fWpzy2ZYrqF8YNZCop+gLqT9DTEtVZFe+JkTX+R2u+YTWd4G8H6xa6GIdwZQz/fHGHaSrpnaCJc90j8GMNjJqSaFtesPmBtNjzjcbKkrxCVCeI= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230025)(4636009)(396003)(136003)(346002)(39860400002)(376002)(451199018)(46966006)(40470700004)(82310400005)(40460700003)(36756003)(40480700001)(35950700001)(83380400001)(316002)(4326008)(70206006)(498600001)(70586007)(8676002)(54906003)(26005)(336012)(2616005)(110136005)(42882007)(47076005)(921005)(426003)(6666004)(1076003)(356005)(83170400001)(8936002)(7416002)(44832011)(5660300002)(41300700001)(82740400003)(81166007)(2906002);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Mar 2023 12:38:46.9990 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2fb57b0c-dea9-4613-d678-08db2a093728 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT108.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5795 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230321_053854_769611_62C73703 X-CRM114-Status: GOOD ( 12.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Harini Katakam Enable transmission and reception of PTP unicast packets by updating PTP unicast config bit and setting current HW mac address as allowed address in PTP unicast filter registers. Signed-off-by: Harini Katakam Signed-off-by: Michal Simek Signed-off-by: Radhey Shyam Pandey --- v2: Handle operation using a single write as suggested by Cladiu drivers/net/ethernet/cadence/macb.h | 4 ++++ drivers/net/ethernet/cadence/macb_main.c | 15 +++++++++++++-- 2 files changed, 17 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/cadence/macb.h b/drivers/net/ethernet/cadence/macb.h index 9c410f93a103..1aa578c1ca4a 100644 --- a/drivers/net/ethernet/cadence/macb.h +++ b/drivers/net/ethernet/cadence/macb.h @@ -95,6 +95,8 @@ #define GEM_SA4B 0x00A0 /* Specific4 Bottom */ #define GEM_SA4T 0x00A4 /* Specific4 Top */ #define GEM_WOL 0x00b8 /* Wake on LAN */ +#define GEM_RXPTPUNI 0x00D4 /* PTP RX Unicast address */ +#define GEM_TXPTPUNI 0x00D8 /* PTP TX Unicast address */ #define GEM_EFTSH 0x00e8 /* PTP Event Frame Transmitted Seconds Register 47:32 */ #define GEM_EFRSH 0x00ec /* PTP Event Frame Received Seconds Register 47:32 */ #define GEM_PEFTSH 0x00f0 /* PTP Peer Event Frame Transmitted Seconds Register 47:32 */ @@ -245,6 +247,8 @@ #define MACB_TZQ_OFFSET 12 /* Transmit zero quantum pause frame */ #define MACB_TZQ_SIZE 1 #define MACB_SRTSM_OFFSET 15 /* Store Receive Timestamp to Memory */ +#define MACB_PTPUNI_OFFSET 20 /* PTP Unicast packet enable */ +#define MACB_PTPUNI_SIZE 1 #define MACB_OSSMODE_OFFSET 24 /* Enable One Step Synchro Mode */ #define MACB_OSSMODE_SIZE 1 #define MACB_MIIONRGMII_OFFSET 28 /* MII Usage on RGMII Interface */ diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c index 51c9fd6f68a4..4c2c82573399 100644 --- a/drivers/net/ethernet/cadence/macb_main.c +++ b/drivers/net/ethernet/cadence/macb_main.c @@ -288,6 +288,13 @@ static void macb_set_hwaddr(struct macb *bp) top = cpu_to_le16(*((u16 *)(bp->dev->dev_addr + 4))); macb_or_gem_writel(bp, SA1T, top); +#ifdef CONFIG_MACB_USE_HWSTAMP + if (gem_has_ptp(bp)) { + gem_writel(bp, RXPTPUNI, bottom); + gem_writel(bp, TXPTPUNI, bottom); + } +#endif + /* Clear unused address register sets */ macb_or_gem_writel(bp, SA2B, 0); macb_or_gem_writel(bp, SA2T, 0); @@ -721,8 +728,12 @@ static void macb_mac_link_up(struct phylink_config *config, spin_unlock_irqrestore(&bp->lock, flags); - /* Enable Rx and Tx */ - macb_writel(bp, NCR, macb_readl(bp, NCR) | MACB_BIT(RE) | MACB_BIT(TE)); + /* Enable Rx and Tx; Enable PTP unicast */ + ctrl = macb_readl(bp, NCR); + if (IS_ENABLED(CONFIG_MACB_USE_HWSTAMP) && gem_has_ptp(bp)) + ctrl |= MACB_BIT(PTPUNI); + + macb_writel(bp, NCR, ctrl | MACB_BIT(RE) | MACB_BIT(TE)); netif_tx_wake_all_queues(ndev); } From patchwork Tue Mar 21 12:38:36 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Katakam, Harini" X-Patchwork-Id: 13182705 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 170BBC76195 for ; Tue, 21 Mar 2023 12:39:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=P3GzRHUw11mybLOxZLueMOwPvIbQOP5nlVVCMGOM5Yo=; b=IdBNVYvKai4jUu pzvhXdjg8IQFH7jskm30P9KwPrqSSAX6oCDU8emir8NcotgghlYPj65uyoH0YE/Ja0wMx/RC/b4Zl k4/pxQ5cHoylgHuzD543BdAUZFQa5IEsHtoCwzf8DOIGPGj+tvSurwEPlqHH4QQeMpquk5HcxA+E3 G5i+/dTerWx3t5UuY4TGtS40p7J3V+VmwfGa1F8HHGv8V+JTkLd72XqYOKJYrV9sOHxt05Nc3+tRA IsAQ3IqQAdIZlp/4AHrL4N8sVbymEQ2G4N1QbBpucb7DptuWNQVCRbQDNl0jS2uS16HDlNEJuZCC1 RAysfCWib3iAmI9KX3YA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pebGc-00CM8n-0r; Tue, 21 Mar 2023 12:39:06 +0000 Received: from mail-dm6nam10on20628.outbound.protection.outlook.com ([2a01:111:f400:7e88::628] helo=NAM10-DM6-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pebGU-00CM5g-0D for linux-arm-kernel@lists.infradead.org; Tue, 21 Mar 2023 12:38:59 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KEnKPOGcw6FNUD3t7rff2tCWtc8oDQEUG7+1vTZKstTmDRGb/rZFsx9BvmVBwb5WUQgzSSBuBvlz6hWHvZJFNw+vAjI0rjX4/ncqQj5fMfaxz3GwijATdP5c43t3HBooMBmjgzK85I0uIwgXsSO8UPjgj/Rd7Solyfuu9JggHSc+4A5tNGf04xRQn47aic7+3pNYdlZGwY5e7d+Q2jQ0MTn5lxYdzVO8Ocu+xBKsjpns+tiP7hHHV7oReaccP+50j1VAC4ntCNlVXjyU93xpqB21U7InDbCckiLeQOecchmcVl/ItB0B10IzTOOujK65E1Kr4A6eHtHV2vSzNkDXvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6WEEhg49v3+3iROgDmHgjFTD2ZPMS3r+TroKLngfkCs=; b=Lh7PI18Vj7yJjeQz9gYbBr9nS0AJkJiXXToLxz/V0K/LMq1RrRgyeBmOWPcpCTSLhOThDHV5/aTWjBRQZmNDIFcrfrvFl1HtPu36zzDrqhjdkdoVkAPiYZ34StO13tkaTZkx0fHO5Sosymrz9Cy0+N81tDL9AAnALbHS2uf2lerGe8+J/sZ/8Q9N0rgEAW+whBy8dcLyRdDllaotoG0k+DD/vAct7xUnmKPFbyerJismBEvZKTWY9iqmSa8fveJpsnP5AfjLoq4LAzo438FeNJjb2QIFn6t8rYunl5URxcD9onfqnBq/5OrDXJZloCBXN9KNDKMfiNzRM0Q9wV/vPA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=fail (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=xilinx.com; dmarc=fail (p=quarantine sp=quarantine pct=100) action=quarantine header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6WEEhg49v3+3iROgDmHgjFTD2ZPMS3r+TroKLngfkCs=; b=E7VpHyKjdcGpbn0rwl2Cdkh0gAk8oSkE1KTxSo29Sw/hhaRd2uGfXw/iULNbVjNmGzN0YDS7Rk4s/XMyTjMPRwJPSohICYZ8WO8oCfIcMBI/jsuX/EQtgD76Fk/XGe2yGMKfkTlSUv1AMmLrXw4V0Ez2AGLXH6E2t8duL6H+PyM= Received: from CY5PR15CA0256.namprd15.prod.outlook.com (2603:10b6:930:66::27) by CH3PR12MB8403.namprd12.prod.outlook.com (2603:10b6:610:133::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.37; Tue, 21 Mar 2023 12:38:51 +0000 Received: from CY4PEPF0000C97D.namprd02.prod.outlook.com (2603:10b6:930:66:cafe::85) by CY5PR15CA0256.outlook.office365.com (2603:10b6:930:66::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.37 via Frontend Transport; Tue, 21 Mar 2023 12:38:51 +0000 X-MS-Exchange-Authentication-Results: spf=fail (sender IP is 165.204.84.17) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=fail action=quarantine header.from=amd.com; Received-SPF: Fail (protection.outlook.com: domain of xilinx.com does not designate 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; Received: from SATLEXMB03.amd.com (165.204.84.17) by CY4PEPF0000C97D.mail.protection.outlook.com (10.167.241.136) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6178.30 via Frontend Transport; Tue, 21 Mar 2023 12:38:51 +0000 Received: from SATLEXMB08.amd.com (10.181.40.132) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 21 Mar 2023 07:38:50 -0500 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB08.amd.com (10.181.40.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 21 Mar 2023 05:38:50 -0700 Received: from xhdharinik40.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Tue, 21 Mar 2023 07:38:46 -0500 From: Harini Katakam To: , , , , , , , , , , CC: , , , , , Subject: [PATCH net-next v2 2/2] net: macb: Optimize reading HW timestamp Date: Tue, 21 Mar 2023 18:08:36 +0530 Message-ID: <20230321123836.6906-3-harini.katakam@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230321123836.6906-1-harini.katakam@amd.com> References: <20230321123836.6906-1-harini.katakam@amd.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000C97D:EE_|CH3PR12MB8403:EE_ X-MS-Office365-Filtering-Correlation-Id: 0aa76614-85d6-4507-6f8f-08db2a0939c0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6vtQ0LfyHWAGEn7l91Pt+pnuIbIV3IMtRX1dgGC9trcjHuOV7q3QgX3zKznmydnSvzyqNvzylfU7/wSqXRt12YbuJa701G3ie9pLKIGnSx97Gugq9FpY50dAkGZN4/BEb51T7MdP3z6MoSa/NuYXbDOpD50Ym2dkUJY3JSASwdsaZxz6sVN+5I1tcgY6RQ7/2QbQvbfWm6l5E9TegHfj+jsTR7KjiCVsrm3whwms5taE9oN+1Ns1l3O5zk7eZriJV3pbz8tq44I57fOQu/P4pe3KAbwrhGhmbSl6MGGJEXKUnGPrTefD5cBaZ4Gfk5swnvu/j+dRTpcQPJJVbJR0jWxfybWubK83dNCSXKzmgDrwsK93yTMdtpk02egTRXmzFssTtFqm9QrzeZhHxg6/Ltp8IcQJJn465u/2QxDRpZzGgAdfyL9C1/bB1yAUHnQOiBYKVhRjHwy6E1JzWr4fV7t4tOuZm2WTUqnu7udBl6G7AHCSIba9U9ekJUgV/PfqlcrE6qeixh1dAGRM6dCjNlhpfltA7PL0wapFtATc2ZlU/RFL3Gg4CokpD4sRn5BP+Wsk9QrRH/Jvk2t4Dug/HSBqMkdw1+8JNuachGDlPvSft3vMQXwNbnv3zI1INRA/5LjOGs+pACJMm/ru/aEAjrjcmscL1QN8onFuORRfeecSqTwaQ5V5wBd1V8wwArWHc9uo5VvMG9AVDqC4Ykp3bRsaadsuF0pKtJ6OuXeMpUI= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230025)(4636009)(396003)(136003)(346002)(376002)(39860400002)(451199018)(40470700004)(46966006)(82310400005)(47076005)(35950700001)(83380400001)(426003)(2616005)(42882007)(336012)(81166007)(82740400003)(921005)(83170400001)(110136005)(40460700003)(356005)(36756003)(8676002)(8936002)(4326008)(2906002)(44832011)(70206006)(70586007)(41300700001)(40480700001)(26005)(5660300002)(54906003)(1076003)(7416002)(6666004)(498600001)(316002);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Mar 2023 12:38:51.4104 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0aa76614-85d6-4507-6f8f-08db2a0939c0 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000C97D.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB8403 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230321_053858_292385_3FD8858B X-CRM114-Status: GOOD ( 12.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Harini Katakam The seconds input from BD (6 bits) just needs to be ORed with the upper bits from timer in this function. Avoid addition operation every single time. Seconds rollover handling is left untouched. Signed-off-by: Harini Katakam Signed-off-by: Michal Simek Signed-off-by: Radhey Shyam Pandey --- v2: - Update HW timestamp logic to remove sec_rollover variable as per Cladiu's comment - Remove Richard Cochran's ACK on original patch as the patch changed drivers/net/ethernet/cadence/macb_ptp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/cadence/macb_ptp.c b/drivers/net/ethernet/cadence/macb_ptp.c index e6cb20aaa76a..f9db4501b995 100644 --- a/drivers/net/ethernet/cadence/macb_ptp.c +++ b/drivers/net/ethernet/cadence/macb_ptp.c @@ -258,6 +258,8 @@ static int gem_hw_timestamp(struct macb *bp, u32 dma_desc_ts_1, */ gem_tsu_get_time(&bp->ptp_clock_info, &tsu, NULL); + ts->tv_sec |= ((~GEM_DMA_SEC_MASK) & tsu.tv_sec); + /* If the top bit is set in the timestamp, * but not in 1588 timer, it has rolled over, * so subtract max size @@ -266,8 +268,6 @@ static int gem_hw_timestamp(struct macb *bp, u32 dma_desc_ts_1, !(tsu.tv_sec & (GEM_DMA_SEC_TOP >> 1))) ts->tv_sec -= GEM_DMA_SEC_TOP; - ts->tv_sec += ((~GEM_DMA_SEC_MASK) & tsu.tv_sec); - return 0; }