From patchwork Sun Mar 26 14:31:09 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13188122 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FBD6C77B6C for ; Sun, 26 Mar 2023 14:32:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232488AbjCZOcy (ORCPT ); Sun, 26 Mar 2023 10:32:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60348 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232464AbjCZOcv (ORCPT ); Sun, 26 Mar 2023 10:32:51 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B26BE7D93 for ; Sun, 26 Mar 2023 07:32:49 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pgRQD-000883-CG; Sun, 26 Mar 2023 16:32:37 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pgRQB-006rbt-9w; Sun, 26 Mar 2023 16:32:35 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pgRQA-0088WT-JO; Sun, 26 Mar 2023 16:32:34 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Robert Foss , Todor Tomov , Andy Gross , Bjorn Andersson , Mauro Carvalho Chehab Cc: Konrad Dybcio , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH 042/117] media: camss: Convert to platform remove callback returning void Date: Sun, 26 Mar 2023 16:31:09 +0200 Message-Id: <20230326143224.572654-45-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230326143224.572654-1-u.kleine-koenig@pengutronix.de> References: <20230326143224.572654-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1782; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=5+233wKbFI0nY/Rw2BqkK/JcpAndlkw8WmqScaqNEvo=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBkIFa56BHcFMWxG95LEaTIhTYmvbipS2cJOM4tq h+jmB4Rj8OJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZCBWuQAKCRCPgPtYfRL+ To2hB/4/HaXTqiAE/6bJk3JeUAywJ/RKf9KuKjMFtM/8Sq1SnaC3aWMOdvrXpbOXzF5vV+68C+7 +3a8dPSkwHIbD5CRuguN+B/zPVElF1R/6BUaJX5OdM09nKH/wPLnXxFHXDPdxWzSWAdf9Dv3MWZ 1M8jXEGgP8/tVFayO8n6THkb1Z8scZMMpdAkkAgaPE7CLb+WCkAIXunQ75W7A5oLrz14A03DUky 59beUId/6lXathw/yvh1z3gPQcCgt4Qc2TnyQttmfnDA6rsPDD3L+hy7zoMfIX9iE156EZfonum V0/qlf5bjYtfyJJ7RsbrIWsOpyfv5pUjh3beswHt7296btM8 X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-msm@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König Reviewed-by: Konrad Dybcio --- drivers/media/platform/qcom/camss/camss.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/media/platform/qcom/camss/camss.c b/drivers/media/platform/qcom/camss/camss.c index 9cda284f1e71..df8a507ce8ac 100644 --- a/drivers/media/platform/qcom/camss/camss.c +++ b/drivers/media/platform/qcom/camss/camss.c @@ -1725,7 +1725,7 @@ void camss_delete(struct camss *camss) * * Always returns 0. */ -static int camss_remove(struct platform_device *pdev) +static void camss_remove(struct platform_device *pdev) { struct camss *camss = platform_get_drvdata(pdev); @@ -1735,8 +1735,6 @@ static int camss_remove(struct platform_device *pdev) if (atomic_read(&camss->ref_count) == 0) camss_delete(camss); - - return 0; } static const struct of_device_id camss_dt_match[] = { @@ -1798,7 +1796,7 @@ static const struct dev_pm_ops camss_pm_ops = { static struct platform_driver qcom_camss_driver = { .probe = camss_probe, - .remove = camss_remove, + .remove_new = camss_remove, .driver = { .name = "qcom-camss", .of_match_table = camss_dt_match, From patchwork Sun Mar 26 14:31:10 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13188126 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6479C6FD1C for ; Sun, 26 Mar 2023 14:33:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232530AbjCZOdA (ORCPT ); Sun, 26 Mar 2023 10:33:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60998 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232474AbjCZOcz (ORCPT ); Sun, 26 Mar 2023 10:32:55 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7EA2A7EDC for ; Sun, 26 Mar 2023 07:32:53 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pgRQF-0008DU-0f; Sun, 26 Mar 2023 16:32:39 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pgRQC-006rcB-FA; Sun, 26 Mar 2023 16:32:36 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pgRQA-0088WY-RK; Sun, 26 Mar 2023 16:32:34 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Stanimir Varbanov , Vikash Garodia , Andy Gross , Bjorn Andersson , Mauro Carvalho Chehab Cc: Konrad Dybcio , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH 043/117] media: venus: Warn only once about problems in .remove() Date: Sun, 26 Mar 2023 16:31:10 +0200 Message-Id: <20230326143224.572654-46-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230326143224.572654-1-u.kleine-koenig@pengutronix.de> References: <20230326143224.572654-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=933; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=IHYTjjRoO1Dj9jBho/XeAemeh3UuJlqKxsJQQ74d7gg=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBkIFa60NwlkPOoWfthIuMks/fTpIeXdYABrvbzv 0ohELhRjkGJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZCBWugAKCRCPgPtYfRL+ TiuJB/425F906SreRIHRCM/qH2XlnDEOKiPIoNFmdWBORbu2QLMvd3WZPem2kI1brt+ufUGfInd Tit+xK3PZ6oblLDvYo+jIalJHmyfOliin+6YQ6jAXvd0vcxnEEdA8V53tUAa6eqt7wa3W42kRs5 K2p2NHxV/1Fy3ev7X94EQELQGUm4iDjn9gIneo2fcXuYVFAa/wQSTIDX41PE8UqjB8nna8l0sYM oBGBRXI+0OxtdyRHtj1iKez+YnsdluUM0vMQ72xV8kxvzPLct5SiQNx8Ccb3bTdtrJ7TKNaw3XO IKfh+SVHt3RQhtu1PGeScp65LcTF1uE0I1AmSJChdC20UK15 X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-msm@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org The only effect of returning an error code in a remove callback is that the driver core emits a warning. The device is unbound anyhow. As the remove callback already emits a (quite verbose) warning when ret is non-zero, return zero to suppress the additional warning. Signed-off-by: Uwe Kleine-König Reviewed-by: Konrad Dybcio --- drivers/media/platform/qcom/venus/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/qcom/venus/core.c b/drivers/media/platform/qcom/venus/core.c index 990a1519f968..403ffb92af60 100644 --- a/drivers/media/platform/qcom/venus/core.c +++ b/drivers/media/platform/qcom/venus/core.c @@ -448,7 +448,7 @@ static int venus_remove(struct platform_device *pdev) mutex_destroy(&core->lock); venus_dbgfs_deinit(core); - return ret; + return 0; } static void venus_core_shutdown(struct platform_device *pdev) From patchwork Sun Mar 26 14:31:11 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13188125 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD057C761AF for ; Sun, 26 Mar 2023 14:32:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232382AbjCZOc5 (ORCPT ); Sun, 26 Mar 2023 10:32:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60630 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232480AbjCZOcx (ORCPT ); Sun, 26 Mar 2023 10:32:53 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5AB6F7D9D for ; Sun, 26 Mar 2023 07:32:52 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pgRQF-0008Dd-2a; Sun, 26 Mar 2023 16:32:39 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pgRQC-006rcC-Fn; Sun, 26 Mar 2023 16:32:36 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pgRQB-0088Wb-1t; Sun, 26 Mar 2023 16:32:35 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Stanimir Varbanov , Vikash Garodia , Andy Gross , Bjorn Andersson , Mauro Carvalho Chehab Cc: Konrad Dybcio , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH 044/117] media: venus: Convert to platform remove callback returning void Date: Sun, 26 Mar 2023 16:31:11 +0200 Message-Id: <20230326143224.572654-47-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230326143224.572654-1-u.kleine-koenig@pengutronix.de> References: <20230326143224.572654-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1850; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=ph85ZOcYCUw+0oWI/YAseTqjEMO65pC6gI1xrpySm34=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBkIFa7N46eaarZ3UptCgyg1IH71NGjTddZ/Ym33 mQjZkAomuiJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZCBWuwAKCRCPgPtYfRL+ TrqdB/90HeO+NrGMq7e7pJASH/PaCtSF9yl01fhDhApdEbmpfvg9h7x2Zq1x1JI6l7MfedvnfAW 9niCmVe0MAs9c1IyA+yELIqyPimvZEft+LGfFA8va3v0LE4PIMhCOcDD2YcaRgiBvwovas6CbVf LrApHDY7Mf0JlnTRiPx4VYWdWbCqmodT3lPv/MFQ0JTwE0TdEyQXwyO+LU4TJZSmRS6V3G76Kd9 KfzyN4K7w2KuqaJG4WTY8sSimVMl8qXXBRwMCDVTc8qpUV7ifvS1wMRk+zT+xQJh5uVCNQPbx9U fcisV5sFjCm8Qv5drmREJ1ixRWNOdUIwz0wliuRdO9PIAyby X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-msm@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König Reviewed-by: Konrad Dybcio --- drivers/media/platform/qcom/venus/core.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/media/platform/qcom/venus/core.c b/drivers/media/platform/qcom/venus/core.c index 403ffb92af60..2ae867cb4c48 100644 --- a/drivers/media/platform/qcom/venus/core.c +++ b/drivers/media/platform/qcom/venus/core.c @@ -416,7 +416,7 @@ static int venus_probe(struct platform_device *pdev) return ret; } -static int venus_remove(struct platform_device *pdev) +static void venus_remove(struct platform_device *pdev) { struct venus_core *core = platform_get_drvdata(pdev); const struct venus_pm_ops *pm_ops = core->pm_ops; @@ -447,8 +447,6 @@ static int venus_remove(struct platform_device *pdev) mutex_destroy(&core->pm_lock); mutex_destroy(&core->lock); venus_dbgfs_deinit(core); - - return 0; } static void venus_core_shutdown(struct platform_device *pdev) @@ -891,7 +889,7 @@ MODULE_DEVICE_TABLE(of, venus_dt_match); static struct platform_driver qcom_venus_driver = { .probe = venus_probe, - .remove = venus_remove, + .remove_new = venus_remove, .driver = { .name = "qcom-venus", .of_match_table = venus_dt_match, From patchwork Sun Mar 26 14:31:12 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13188124 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CE27C77B71 for ; Sun, 26 Mar 2023 14:32:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232509AbjCZOc4 (ORCPT ); Sun, 26 Mar 2023 10:32:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60368 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232271AbjCZOcx (ORCPT ); Sun, 26 Mar 2023 10:32:53 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BE43759DB for ; Sun, 26 Mar 2023 07:32:51 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pgRQE-0008Dj-MD; Sun, 26 Mar 2023 16:32:38 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pgRQC-006rcF-HN; Sun, 26 Mar 2023 16:32:36 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pgRQB-0088We-96; Sun, 26 Mar 2023 16:32:35 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Stanimir Varbanov , Vikash Garodia , Andy Gross , Bjorn Andersson , Mauro Carvalho Chehab Cc: Konrad Dybcio , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH 045/117] media: vdec: Convert to platform remove callback returning void Date: Sun, 26 Mar 2023 16:31:12 +0200 Message-Id: <20230326143224.572654-48-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230326143224.572654-1-u.kleine-koenig@pengutronix.de> References: <20230326143224.572654-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1804; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=pJNzgnJ30EHiUzc/rqyhfA+TC1iTYhBrR+DTa0bHg48=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBkIFa9C9koq5OLF/ESdALEl/zRMwoCX5ePT1HQs P4j36rGXJCJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZCBWvQAKCRCPgPtYfRL+ TtpNCACp/23FthUg0CFYOG+R1MILQ0ULtf3l8oU9zVXkA9P90j5pnQpgW8JNDRLKtUcgRgqbPw4 F+2onLhRvmVC41rnMZ0Wdf+XpT83zSEzYVNYstQ4HWa3KHBd9BY3X5/+vRtfw4JTBjjKr9XdbiX 1sabflqFczhSdtl//kozaICMzcyYa4Xg67+rllu3JZ+7qGwGzvpu662d52BYgaUbOdfc/Ee0ezg kbhPlVs8LbQHbC8y3lc/Me8NmcVZfiATRcUF8mVr8QrOr9eHBr+5q6QPzbT3QdhCWeo1nYsTVvL y4UcykqByy8zp8C/ESAjxK5b0FWvpvcVkMcSyYKZFD/T4MBX X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-msm@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König Reviewed-by: Konrad Dybcio --- drivers/media/platform/qcom/venus/vdec.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/media/platform/qcom/venus/vdec.c b/drivers/media/platform/qcom/venus/vdec.c index 4ceaba37e2e5..d47c22015770 100644 --- a/drivers/media/platform/qcom/venus/vdec.c +++ b/drivers/media/platform/qcom/venus/vdec.c @@ -1774,7 +1774,7 @@ static int vdec_probe(struct platform_device *pdev) return ret; } -static int vdec_remove(struct platform_device *pdev) +static void vdec_remove(struct platform_device *pdev) { struct venus_core *core = dev_get_drvdata(pdev->dev.parent); @@ -1783,8 +1783,6 @@ static int vdec_remove(struct platform_device *pdev) if (core->pm_ops->vdec_put) core->pm_ops->vdec_put(core->dev_dec); - - return 0; } static __maybe_unused int vdec_runtime_suspend(struct device *dev) @@ -1825,7 +1823,7 @@ MODULE_DEVICE_TABLE(of, vdec_dt_match); static struct platform_driver qcom_venus_dec_driver = { .probe = vdec_probe, - .remove = vdec_remove, + .remove_new = vdec_remove, .driver = { .name = "qcom-venus-decoder", .of_match_table = vdec_dt_match, From patchwork Sun Mar 26 14:31:13 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13188123 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C5EEC74A5B for ; Sun, 26 Mar 2023 14:32:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232502AbjCZOcz (ORCPT ); Sun, 26 Mar 2023 10:32:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60998 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232377AbjCZOcx (ORCPT ); Sun, 26 Mar 2023 10:32:53 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7C9966A69 for ; Sun, 26 Mar 2023 07:32:51 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pgRQF-0008Ds-2t; Sun, 26 Mar 2023 16:32:39 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pgRQC-006rcG-I2; Sun, 26 Mar 2023 16:32:36 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pgRQB-0088Wk-F3; Sun, 26 Mar 2023 16:32:35 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Stanimir Varbanov , Vikash Garodia , Andy Gross , Bjorn Andersson , Mauro Carvalho Chehab Cc: Konrad Dybcio , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH 046/117] media: venc: Convert to platform remove callback returning void Date: Sun, 26 Mar 2023 16:31:13 +0200 Message-Id: <20230326143224.572654-49-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230326143224.572654-1-u.kleine-koenig@pengutronix.de> References: <20230326143224.572654-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1804; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=hwSaE/8xK5uDZSiLTTtZlCVtdlhltZuM7HPsqGQ9Uf4=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBkIFa+uxorUIQpjqZN3S9rqhNDmr3xDFDC5H+f4 J9shvHrsPWJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZCBWvgAKCRCPgPtYfRL+ Tn+yCACq2oQqKASPlvz22ANabMKMAXSr7B65CS1U9LTwKXjTBq79XIZEXvC8VR4Djdon1bBVxax 4WCWGLplC9aLPujPNVeqMa1UdqBbmbNUzL9DzbmQE43Ij0SiFFlc5YH2ZnSH6QXyUFWfQlnvH7Z oQeUbi4r4MppzYy2XOjcpsHVIT9u3hgFQqAnzjpyWmR/pluqblYPu8DUw2yCpSFiasn5WWg310K i7R0naRJwQ6+n6Dtk39ah1nmc9NDyjrI75RskO9MQoy7aRPkSSYlxP/BSRFf+gsfG7j/VCBtGu8 9KN3yQscinsL3cAXqYeFk7MX2puW2VpCE7wg+kya1yP36dHP X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-msm@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König Reviewed-by: Konrad Dybcio --- drivers/media/platform/qcom/venus/venc.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/media/platform/qcom/venus/venc.c b/drivers/media/platform/qcom/venus/venc.c index cdb12546c4fa..6d61614656a5 100644 --- a/drivers/media/platform/qcom/venus/venc.c +++ b/drivers/media/platform/qcom/venus/venc.c @@ -1492,7 +1492,7 @@ static int venc_probe(struct platform_device *pdev) return ret; } -static int venc_remove(struct platform_device *pdev) +static void venc_remove(struct platform_device *pdev) { struct venus_core *core = dev_get_drvdata(pdev->dev.parent); @@ -1501,8 +1501,6 @@ static int venc_remove(struct platform_device *pdev) if (core->pm_ops->venc_put) core->pm_ops->venc_put(core->dev_enc); - - return 0; } static __maybe_unused int venc_runtime_suspend(struct device *dev) @@ -1543,7 +1541,7 @@ MODULE_DEVICE_TABLE(of, venc_dt_match); static struct platform_driver qcom_venus_enc_driver = { .probe = venc_probe, - .remove = venc_remove, + .remove_new = venc_remove, .driver = { .name = "qcom-venus-encoder", .of_match_table = venc_dt_match,