From patchwork Mon Mar 27 23:33:42 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Caio Novais X-Patchwork-Id: 13190252 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3BE76C76195 for ; Mon, 27 Mar 2023 23:34:23 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 35BDB10E54F; Mon, 27 Mar 2023 23:34:22 +0000 (UTC) Received: from mail-oi1-x233.google.com (mail-oi1-x233.google.com [IPv6:2607:f8b0:4864:20::233]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4E7F110E54F for ; Mon, 27 Mar 2023 23:34:20 +0000 (UTC) Received: by mail-oi1-x233.google.com with SMTP id bm2so7704670oib.4 for ; Mon, 27 Mar 2023 16:34:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=usp.br; s=usp-google; t=1679960059; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ATSF4wL+BzdBMa6MQ9WEbv1t9xTPovSyTP8ALVjMP/g=; b=jjeTndIjow57RXIs03XG4zTCjcQS7/ijT5BWQdjbh4qY+GsQ5sYgm1M7PfuUXOSubb RrcSC2LSZIQfp0531wAMUZRsj1uVKqOISsBGGNSY5U6pNoa1kNuv43aD/NYjC6A0KQAw NT3ZDNcHFzDJJVeOAgZLF9F0vKbnjWCpGSlH6vBP4QDYysI59nc8P7J+kUnT8x4lBZJp FYbdsN9mU0vDTXG1HHo3ScuOB+bDR2fxQyorBOuoG76lU68szVA2oeX+KQjILaM4guk7 /vn8xua0wWVLPjP/ShDuq9R6Lij2bknq4mBHwqNGQM7y9Z7y1F/u1tIdneevves42NeF BK+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679960059; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ATSF4wL+BzdBMa6MQ9WEbv1t9xTPovSyTP8ALVjMP/g=; b=UzAFNtKDHKhMHR/JZrqvS1qP+mS7zKt2XKCopr8ungWNmhpNuBWEu8g2js5Yc0LG2z tgItEpJKGNL2kk+Xvbo2eE7yb8u9qWhMxssvqx9Ep1D+MbK0PbkNR4wsWlouyu85JxvA R30T+zKXEStbSsmyGELQ2a/r/2GhzLv8F6RmgFrLsS2RV/6ADWjMCtzdQ80tqprHrY/u WXdFR0hmjUn56eJny2uOXzDxqkX2BOmrBpjLseeh1i22W3NOr/6jPWunfIQEN+IOnv1S JZeJKZW/BEafCZVWDDvs7PmnaNIhWd6Sl9BguxXI0kD84S8LeRwk6QhOiK0SfQgsY7ZN YrmA== X-Gm-Message-State: AO0yUKUwYAvz1X0slqB0g4q121dnOrLmV5ov+e2HadTw4f1aks3q8GY4 ge2przV43MkKvCccVX7Iicbj4A== X-Google-Smtp-Source: AK7set9DW5uNG3ER+wZDWGxBetFSD6HDWjyxXA+KWrXZQuX9MkweyGj2xhoBwNRWBg7ILEXEH0kkjQ== X-Received: by 2002:a05:6808:b22:b0:383:f572:2646 with SMTP id t2-20020a0568080b2200b00383f5722646mr4940712oij.5.1679960059520; Mon, 27 Mar 2023 16:34:19 -0700 (PDT) Received: from ARCHaio.localdomain ([2804:1b3:a2c0:c911:919f:bd20:4f2a:8383]) by smtp.gmail.com with ESMTPSA id b186-20020aca34c3000000b00389295e8424sm1643409oia.45.2023.03.27.16.34.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Mar 2023 16:34:19 -0700 (PDT) From: Caio Novais To: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH 01/12] drm/amd: Remove unused variable 'r' Date: Mon, 27 Mar 2023 20:33:42 -0300 Message-Id: <20230327233353.64081-2-caionovais@usp.br> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230327233353.64081-1-caionovais@usp.br> References: <20230327233353.64081-1-caionovais@usp.br> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Felipe Clark , Wenjing Liu , =?utf-8?q?Ma=C3=ADra_Canal?= , Mario Limonciello , Jun Lei , Charlene Liu , Gabe Teeger , Rodrigo Siqueira , Taimur Hassan , Aurabindo Pillai , Alvin Lee , George Shen , Hamza Mahfooz , Chaitanya Dhere , Alan Liu , Mukul Joshi , =?utf-8?q?Andr=C3=A9_Almeida?= , Jingwen Zhu , Guo Zhengkui , Leo Li , Melissa Wen , Le Ma , Jiapeng Chong , Caio Novais , Martin Leung , Ryan Lin , Brian Chang , Sung Joon Kim , Yifan Zhang , Jack Xiao , Dillon Varone , Tom Chung , Wesley Chalmers , Qingqing Zhuo , "Pan, Xinhui" , Zhan Liu , Roman Li , =?utf-8?q?Christi?= =?utf-8?q?an_K=C3=B6nig?= , Wayne Lin , Alex Deucher , Ethan Wellenreiter , Nicholas Kazlauskas , Joshua Ashton , Hawking Zhang Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Compiling AMD GPU drivers displays a warning: drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c: In function ‘amdgpu_mes_ctx_alloc_meta_data’: drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c:1099:13: warning: variable ‘r’ set but not used [-Wunused-but-set-variable] Get rid of it by removing the variable. Signed-off-by: Caio Novais --- drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c index 82e27bd4f038..e0130536f778 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c @@ -1096,14 +1096,6 @@ uint32_t amdgpu_mes_get_aggregated_doorbell_index(struct amdgpu_device *adev, int amdgpu_mes_ctx_alloc_meta_data(struct amdgpu_device *adev, struct amdgpu_mes_ctx_data *ctx_data) { - int r; - - r = amdgpu_bo_create_kernel(adev, - sizeof(struct amdgpu_mes_ctx_meta_data), - PAGE_SIZE, AMDGPU_GEM_DOMAIN_GTT, - &ctx_data->meta_data_obj, - &ctx_data->meta_data_mc_addr, - &ctx_data->meta_data_ptr); if (!ctx_data->meta_data_obj) return -ENOMEM; From patchwork Mon Mar 27 23:33:43 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Caio Novais X-Patchwork-Id: 13190253 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E135CC6FD1D for ; Mon, 27 Mar 2023 23:34:33 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 21AE810E7B0; Mon, 27 Mar 2023 23:34:33 +0000 (UTC) Received: from mail-oi1-x22d.google.com (mail-oi1-x22d.google.com [IPv6:2607:f8b0:4864:20::22d]) by gabe.freedesktop.org (Postfix) with ESMTPS id C9F5A10E7B0 for ; Mon, 27 Mar 2023 23:34:31 +0000 (UTC) Received: by mail-oi1-x22d.google.com with SMTP id q27so6957805oiw.0 for ; Mon, 27 Mar 2023 16:34:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=usp.br; s=usp-google; t=1679960071; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=rCjnRFQPvAGnNx5L3qglgkfLmLwG3nPN+a/hM9CacEs=; b=GtnEi/KsBIrFkxShd3lvYGNJ9gUrQ2buWtvBFztcLMpjZHYnpfC2btTyNI2wDsx8gP PDOwtTF/TcTUNyeDxR4+oqyXUYAWrwKZvEptBJqEajGlOvHQG/N2hgJNqoRivII1xx51 srSRUFm+TSmPWghIrj0BJh5li74VwsAaLfH1KqwWeaR6TO4B41nDX8EIySGgAXFLkN8F YdwEqm/wd8FQ3RikiVit9f33f8/yakAEXCIUHf2m4mD8ZPr83k/J/9pPD+iRpgpI1jss eOoS5rgPZHuaXhSaw/dfu9zrMhREgjPL3L5P57orkSVqAnny3ybOMPodpqyInQTfYtTE TpRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679960071; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rCjnRFQPvAGnNx5L3qglgkfLmLwG3nPN+a/hM9CacEs=; b=XWy9Rs0mlgHEdDZp/vTulxmA56rQNY9d18mYMAZ1HHrBOnU4zpwZE3rnnMWNxdPuEA mBlouur+OrNRJKgo0MF6HWkkNhqiCEF6telgD1t2n1TwdtO8TqrRR2heLk93CW3eApdU 9NLQVFb3z2H4IYgkmNS8oyUshbC5yPGvoXVRFzKE6LsPg8ZqThVrjZNBFU1hC6j5FSY1 68qzMiQKVoiY5ahpUx8N0QS+iIiRt//ffACcTsi51Yf2JPLq6JtnRiHb22e87tt/g6I/ 9eg2riWI55Ci+AeLhuFPfoCTJCoId2Bj8ROdiW544wqs17kVsQuYuZ04bbWJtF7i6F8s LuYw== X-Gm-Message-State: AO0yUKXoFa/g1irLGZCaQe3oUs4CUaDsCfivf0dZgKAcvXsaNrVPnheO esyztUVakoAAyqx+ZTl784LOfA== X-Google-Smtp-Source: AK7set8rDxFHQB6rrg/v8At+R+vD2rhk2qXsj5IgrUWpiFpg9BehvyB3jSFGPbGLp8x0w8YllHWLbA== X-Received: by 2002:a05:6808:2d3:b0:386:ca6d:b602 with SMTP id a19-20020a05680802d300b00386ca6db602mr3723586oid.41.1679960069565; Mon, 27 Mar 2023 16:34:29 -0700 (PDT) Received: from ARCHaio.localdomain ([2804:1b3:a2c0:c911:919f:bd20:4f2a:8383]) by smtp.gmail.com with ESMTPSA id b186-20020aca34c3000000b00389295e8424sm1643409oia.45.2023.03.27.16.34.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Mar 2023 16:34:29 -0700 (PDT) From: Caio Novais To: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH 02/12] drm/amd: Remove unused variable 'value0' Date: Mon, 27 Mar 2023 20:33:43 -0300 Message-Id: <20230327233353.64081-3-caionovais@usp.br> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230327233353.64081-1-caionovais@usp.br> References: <20230327233353.64081-1-caionovais@usp.br> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Felipe Clark , Wenjing Liu , =?utf-8?q?Ma=C3=ADra_Canal?= , Mario Limonciello , Jun Lei , Charlene Liu , Gabe Teeger , Rodrigo Siqueira , Taimur Hassan , Aurabindo Pillai , Alvin Lee , George Shen , Hamza Mahfooz , Chaitanya Dhere , Alan Liu , Mukul Joshi , =?utf-8?q?Andr=C3=A9_Almeida?= , Jingwen Zhu , Guo Zhengkui , Leo Li , Melissa Wen , Le Ma , Jiapeng Chong , Caio Novais , Martin Leung , Ryan Lin , Brian Chang , Sung Joon Kim , Yifan Zhang , Jack Xiao , Dillon Varone , Tom Chung , Wesley Chalmers , Qingqing Zhuo , "Pan, Xinhui" , Zhan Liu , Roman Li , =?utf-8?q?Christi?= =?utf-8?q?an_K=C3=B6nig?= , Wayne Lin , Alex Deucher , Ethan Wellenreiter , Nicholas Kazlauskas , Joshua Ashton , Hawking Zhang Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Compiling AMD GPU drivers displays a warning: drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_link_encoder.c: In function ‘dcn10_link_encoder_update_mst_stream_allocation_table’: drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_link_encoder.c:1222:18: warning: variable ‘value0’ set but not used [-Wunused-but-set-variable] Get rid of it by removing the variable. Signed-off-by: Caio Novais --- drivers/gpu/drm/amd/display/dc/dcn10/dcn10_link_encoder.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_link_encoder.c b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_link_encoder.c index c4287147b853..81aa1631945a 100644 --- a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_link_encoder.c +++ b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_link_encoder.c @@ -1219,7 +1219,6 @@ void dcn10_link_encoder_update_mst_stream_allocation_table( const struct link_mst_stream_allocation_table *table) { struct dcn10_link_encoder *enc10 = TO_DCN10_LINK_ENC(enc); - uint32_t value0 = 0; uint32_t value1 = 0; uint32_t value2 = 0; uint32_t slots = 0; @@ -1321,8 +1320,6 @@ void dcn10_link_encoder_update_mst_stream_allocation_table( do { udelay(10); - value0 = REG_READ(DP_MSE_SAT_UPDATE); - REG_GET(DP_MSE_SAT_UPDATE, DP_MSE_SAT_UPDATE, &value1); From patchwork Mon Mar 27 23:33:44 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Caio Novais X-Patchwork-Id: 13190254 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9C0F2C76195 for ; Mon, 27 Mar 2023 23:34:45 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 774F310E7BA; Mon, 27 Mar 2023 23:34:44 +0000 (UTC) Received: from mail-oi1-x229.google.com (mail-oi1-x229.google.com [IPv6:2607:f8b0:4864:20::229]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5A74010E7B7 for ; Mon, 27 Mar 2023 23:34:41 +0000 (UTC) Received: by mail-oi1-x229.google.com with SMTP id s8so7715266ois.2 for ; Mon, 27 Mar 2023 16:34:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=usp.br; s=usp-google; t=1679960081; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1IwF6Kj9QYhpJPxCrtGOCcjZaHDRHTEbDHEOQ0Q0o5c=; b=jfYnm0x5boN6VyBUnMWPRzz97xGu/bVZkk8ot1nSNhbtqM525wpnumuPPxj2g6SBmt iqmmB2Tb3gG2gIqDlHDVBtcb5bLSyxASg2JlHy4W5rzyjFd0wER0kSIGXZ7mUjS5562+ 4imgqjAZwoauhGi0X9/tsjF17nKL8f44lyAP2Z9q8WVM+VVX4Mrf8rvcYLk8k6Yypltz 55syccSk7F6t6/C4ZpQlbrqQ+AQDGC3FjX9vijwQatYhvkvfGErtohIi3PnBdcogv/Fr i1LAISm1WjJdeH7GRdOWbnkEjnvTOG2OW2321C8y6x5FfqRTcO49qcGEIHuN8EzxTkpx KDtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679960081; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1IwF6Kj9QYhpJPxCrtGOCcjZaHDRHTEbDHEOQ0Q0o5c=; b=00G/TeHRl305oqc9cTFhnEkQzEOLmDUVFCmEVpSH693ZeD/+zaXeuthtbHSfLaMBn1 1txs9KQPeLiDto5xFI0vu0vy2djZ7JxsxPkwrtpqQW5AUlAWFMKC4cIltvLRm3oKPjUv RfDrEo7pdYylEOF2UJrsKB6AqYWMHaBUg02I+qgF/aCxVxuKiZeIS4+N3nC1hU9o4zJS IjYo5tzWSrlRFWMl3Qtt7C8ip6onJ/SQIttHb8FcYBG4bkH41VVKzCyth6F092ozyxM5 HwawTdy4kyRYgUGlhBu6d5bwLW+TknfBeIfJeciCuukdcv7AG7NTh3s5swtq8sbvgI/C W3Xw== X-Gm-Message-State: AAQBX9e2ZCHu0NUHI3jepDmVpVREOg4I6hYTXM7CUc3erl3PaXlDd9EO uWAWzpjg6DZyW0+IpCCcc8iGhg== X-Google-Smtp-Source: AKy350amlW4hmJ5oi6zfnFlDhNs8qcwQpjdMENIe7wdz31yjBqJqQIgig25+IFqaAxHNxlomgZLO+Q== X-Received: by 2002:aca:2b09:0:b0:389:4f27:9e0 with SMTP id i9-20020aca2b09000000b003894f2709e0mr676851oik.26.1679960079586; Mon, 27 Mar 2023 16:34:39 -0700 (PDT) Received: from ARCHaio.localdomain ([2804:1b3:a2c0:c911:919f:bd20:4f2a:8383]) by smtp.gmail.com with ESMTPSA id b186-20020aca34c3000000b00389295e8424sm1643409oia.45.2023.03.27.16.34.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Mar 2023 16:34:39 -0700 (PDT) From: Caio Novais To: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH 03/12] drm/amd/display: Remove unused variable 'pixel_width' Date: Mon, 27 Mar 2023 20:33:44 -0300 Message-Id: <20230327233353.64081-4-caionovais@usp.br> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230327233353.64081-1-caionovais@usp.br> References: <20230327233353.64081-1-caionovais@usp.br> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Felipe Clark , Wenjing Liu , =?utf-8?q?Ma=C3=ADra_Canal?= , Mario Limonciello , Jun Lei , Charlene Liu , Gabe Teeger , Rodrigo Siqueira , Taimur Hassan , Aurabindo Pillai , Alvin Lee , George Shen , Hamza Mahfooz , Chaitanya Dhere , Alan Liu , Mukul Joshi , =?utf-8?q?Andr=C3=A9_Almeida?= , Jingwen Zhu , Guo Zhengkui , Leo Li , Melissa Wen , Le Ma , Jiapeng Chong , Caio Novais , Martin Leung , Ryan Lin , Brian Chang , Sung Joon Kim , Yifan Zhang , Jack Xiao , Dillon Varone , Tom Chung , Wesley Chalmers , Qingqing Zhuo , "Pan, Xinhui" , Zhan Liu , Roman Li , =?utf-8?q?Christi?= =?utf-8?q?an_K=C3=B6nig?= , Wayne Lin , Alex Deucher , Ethan Wellenreiter , Nicholas Kazlauskas , Joshua Ashton , Hawking Zhang Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Compiling AMD GPU drivers displays a warning: drivers/gpu/drm/amd/amdgpu/../display/dc/dcn201/dcn201_dpp.c: In function ‘dpp201_get_optimal_number_of_taps’: drivers/gpu/drm/amd/amdgpu/../display/dc/dcn201/dcn201_dpp.c:188:18: warning: variable ‘pixel_width’ set but not used [-Wunused-but-set-variable] Get rid of it by removing the variable. Signed-off-by: Caio Novais --- drivers/gpu/drm/amd/display/dc/dcn201/dcn201_dpp.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/dcn201/dcn201_dpp.c b/drivers/gpu/drm/amd/display/dc/dcn201/dcn201_dpp.c index f50ab961bc17..f8ffc06593b2 100644 --- a/drivers/gpu/drm/amd/display/dc/dcn201/dcn201_dpp.c +++ b/drivers/gpu/drm/amd/display/dc/dcn201/dcn201_dpp.c @@ -185,12 +185,6 @@ static bool dpp201_get_optimal_number_of_taps( struct scaler_data *scl_data, const struct scaling_taps *in_taps) { - uint32_t pixel_width; - - if (scl_data->viewport.width > scl_data->recout.width) - pixel_width = scl_data->recout.width; - else - pixel_width = scl_data->viewport.width; if (scl_data->viewport.width != scl_data->h_active && scl_data->viewport.height != scl_data->v_active && From patchwork Mon Mar 27 23:33:45 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Caio Novais X-Patchwork-Id: 13190255 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E4237C761A6 for ; Mon, 27 Mar 2023 23:34:54 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id F0C1F10E7B8; Mon, 27 Mar 2023 23:34:53 +0000 (UTC) Received: from mail-oi1-x236.google.com (mail-oi1-x236.google.com [IPv6:2607:f8b0:4864:20::236]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5BFD810E7B8 for ; Mon, 27 Mar 2023 23:34:50 +0000 (UTC) Received: by mail-oi1-x236.google.com with SMTP id bj20so7705507oib.3 for ; Mon, 27 Mar 2023 16:34:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=usp.br; s=usp-google; t=1679960089; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8QsHyz7gKUkQwkVhf5pyg1KknFMPIvy4LcmMgDotpCM=; b=sx01gakuWa2Q5P6dcI4aIQRwIo9i+t9MKVEV2yp/xxLG+XXh5L4SKodd8Ib0rthkhM d229sHbxpl6ezpNSYIuE8NQG3fv4OcWLeqiVpughUBDCD6HoXLYQkjPeeOcHA6UVU8G5 /J+jdLdjufxFxv955wirCwSmbuLxHyCqXYk0my/ciyXJCElao7c90x1rIa/Yh0yTCp3W s7+bZXZt1V3nUO4Bba4bODojyT+ct9iMtEBxRi58GmbNQ7mDBbPk1ey70ybCkLX6rMhK 2vB49cK9mzSLuo9e7QPRVLEHJHwT0WQ6eKElBGY/NK8HFvBSQE8kDrnuupww2QfLMRTD Y6EA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679960089; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8QsHyz7gKUkQwkVhf5pyg1KknFMPIvy4LcmMgDotpCM=; b=cZEqM2aGmBJWG4gZgOvG4G9SkjS7iRu7AXl7ooqO5Z/aagGVSwlvJkwas5PQEgD4Mf HJMKvg7o8cKl2x8XkT6kuqVjPE7jftcWsZkKVObUURYabYV7eKFatsIp2AZuYwOTA6Sy LrUZDnpHNu8bHTfsF6E2Tq7Qsr463x5tgdsRxD1AhDMJtXGYleHCLjaagXNFCoD+0T5I tMwG1yQURKZa3++wtODXq7xrH8BypJQLL/KR89W5qZ7QL7sOOKgDzxIMZC1LfO/hxM1z zgdVSPjgboWkxZVdCGqeGf5U5uyUDOzev3Df4oqFXjGDtcoluD+eos6qPluMGhjkNuBI SNBA== X-Gm-Message-State: AAQBX9fSTxoQOAccQfr5wL4tyHpL379TECiL8dTplIidS97vMusyQZww 2V9O2r+O8n5aFs58mKHWU4+Nn/ysO1gKbo18Ftwj7Q== X-Google-Smtp-Source: AKy350Zf7TAyCj72D7dBxB05x85USmeaRH3Aok5R7Th4M199ri5mIqKovxSmqM4aYnXWp8ALjUMQfA== X-Received: by 2002:aca:d0f:0:b0:389:f4a:93ec with SMTP id 15-20020aca0d0f000000b003890f4a93ecmr2974502oin.28.1679960089575; Mon, 27 Mar 2023 16:34:49 -0700 (PDT) Received: from ARCHaio.localdomain ([2804:1b3:a2c0:c911:919f:bd20:4f2a:8383]) by smtp.gmail.com with ESMTPSA id b186-20020aca34c3000000b00389295e8424sm1643409oia.45.2023.03.27.16.34.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Mar 2023 16:34:49 -0700 (PDT) From: Caio Novais To: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH 04/12] drm/amd/display: Remove unused variable 'hubp' Date: Mon, 27 Mar 2023 20:33:45 -0300 Message-Id: <20230327233353.64081-5-caionovais@usp.br> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230327233353.64081-1-caionovais@usp.br> References: <20230327233353.64081-1-caionovais@usp.br> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Felipe Clark , Wenjing Liu , =?utf-8?q?Ma=C3=ADra_Canal?= , Mario Limonciello , Jun Lei , Charlene Liu , Gabe Teeger , Rodrigo Siqueira , Taimur Hassan , Aurabindo Pillai , Alvin Lee , George Shen , Hamza Mahfooz , Chaitanya Dhere , Alan Liu , Mukul Joshi , =?utf-8?q?Andr=C3=A9_Almeida?= , Jingwen Zhu , Guo Zhengkui , Leo Li , Melissa Wen , Le Ma , Jiapeng Chong , Caio Novais , Martin Leung , Ryan Lin , Brian Chang , Sung Joon Kim , Yifan Zhang , Jack Xiao , Dillon Varone , Tom Chung , Wesley Chalmers , Qingqing Zhuo , "Pan, Xinhui" , Zhan Liu , Roman Li , =?utf-8?q?Christi?= =?utf-8?q?an_K=C3=B6nig?= , Wayne Lin , Alex Deucher , Ethan Wellenreiter , Nicholas Kazlauskas , Joshua Ashton , Hawking Zhang Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Compiling AMD GPU drivers displays a warning: drivers/gpu/drm/amd/amdgpu/../display/dc/dcn201/dcn201_hwseq.c: In function ‘dcn201_pipe_control_lock’: drivers/gpu/drm/amd/amdgpu/../display/dc/dcn201/dcn201_hwseq.c:544:22: warning: variable ‘hubp’ set but not used [-Wunused-but-set-variable] Get rid of it by removing the variable. Signed-off-by: Caio Novais --- drivers/gpu/drm/amd/display/dc/dcn201/dcn201_hwseq.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/dcn201/dcn201_hwseq.c b/drivers/gpu/drm/amd/display/dc/dcn201/dcn201_hwseq.c index 61bcfa03c4e7..1aeb04fbd89d 100644 --- a/drivers/gpu/drm/amd/display/dc/dcn201/dcn201_hwseq.c +++ b/drivers/gpu/drm/amd/display/dc/dcn201/dcn201_hwseq.c @@ -541,8 +541,6 @@ void dcn201_pipe_control_lock( bool lock) { struct dce_hwseq *hws = dc->hwseq; - struct hubp *hubp = NULL; - hubp = dc->res_pool->hubps[pipe->pipe_idx]; /* use TG master update lock to lock everything on the TG * therefore only top pipe need to lock */ From patchwork Mon Mar 27 23:33:46 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Caio Novais X-Patchwork-Id: 13190256 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9BC22C76195 for ; Mon, 27 Mar 2023 23:35:03 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B1BBC10E7BF; Mon, 27 Mar 2023 23:35:02 +0000 (UTC) Received: from mail-oi1-x231.google.com (mail-oi1-x231.google.com [IPv6:2607:f8b0:4864:20::231]) by gabe.freedesktop.org (Postfix) with ESMTPS id 66F3C10E7BF for ; Mon, 27 Mar 2023 23:35:00 +0000 (UTC) Received: by mail-oi1-x231.google.com with SMTP id bm2so7705495oib.4 for ; Mon, 27 Mar 2023 16:35:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=usp.br; s=usp-google; t=1679960099; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=UZvChWzT9y/5zLeIHf5uAQzD/BtvkDRJ3FwyLW2ZaHk=; b=wm7ahbRIhc9RvuZcZDoeymhlv3zgD7q8vtlddoiFgyPuYrCF2UQHw1qVFatPY38lbk L2MDcqf4eFfFC9CD4fkQf+dipCiiaXWG8ig6gj/1+WLjtVv9dPoPoWUW0OdVyljtevBj P1tAYeCjhmjGlaaJoO3h1AsREJwGADm4oAyEWnyxhNQmZEp/yuGqEhppic9GwJ497+6m cdfMze0NchXZo6iFtJ+LC4Uj2Wt37hP+m0Yhw2h11qHaiAf+GKNcfNcWz6Vr8UPFQ20/ qqdrotLRu9N+cgoUH8F8M74KXSdu7eKJD2CI9iaISd9WZdaUnoQcd733g9l1a2Q1kQib AJ2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679960099; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UZvChWzT9y/5zLeIHf5uAQzD/BtvkDRJ3FwyLW2ZaHk=; b=S2DbELcXT/qS1IoipzQuG70VtsZs+NVBXIg5gDmQnjNpKaDWVaFyN6F3mIg5cJpqWo oH9B9oIN1eklGB9QEMqZJuDYryAf8+SYD5QmCN0waDjgY3nehuModElplHzC1hTBAgD9 ELARkiTRgqmR70ReqbLBMGmgGpdbjqNyoYeukyF1xRvlOGmVZftYWCqgDFhsanLk6Ccp DRT/X7o54KaNzduiPlyspwsfI6d15U3jlczQKQp0ElzPJxDaiIILTuRu4EqHchPnXFGe g6emZAxxXrRSQy66qZDbrZcPChIFgnHs4LtGdwxBbNUmN/TD+xqKcGjyBm8DNx7jx/qZ hZmg== X-Gm-Message-State: AO0yUKWBfOuAKQxGoAXmuz0fVSmkmywqWUliKnUy9Z+RPZFEvjm/Y3hD X+8Np+ej37DNthWG6z6vrrKLkA== X-Google-Smtp-Source: AK7set/8tjEH59vf8bLWrjpQFwfi5OJxvuo18LnQL3tRmSwfL7lkONT3v+KQNmF/JKJ6LyaDvpfYzA== X-Received: by 2002:aca:220a:0:b0:387:3a49:4733 with SMTP id b10-20020aca220a000000b003873a494733mr5203770oic.59.1679960099653; Mon, 27 Mar 2023 16:34:59 -0700 (PDT) Received: from ARCHaio.localdomain ([2804:1b3:a2c0:c911:919f:bd20:4f2a:8383]) by smtp.gmail.com with ESMTPSA id b186-20020aca34c3000000b00389295e8424sm1643409oia.45.2023.03.27.16.34.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Mar 2023 16:34:59 -0700 (PDT) From: Caio Novais To: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH 05/12] drm/amd/display: Remove unused variable 'speakers' Date: Mon, 27 Mar 2023 20:33:46 -0300 Message-Id: <20230327233353.64081-6-caionovais@usp.br> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230327233353.64081-1-caionovais@usp.br> References: <20230327233353.64081-1-caionovais@usp.br> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Felipe Clark , Wenjing Liu , =?utf-8?q?Ma=C3=ADra_Canal?= , Mario Limonciello , Jun Lei , Charlene Liu , Gabe Teeger , Rodrigo Siqueira , Taimur Hassan , Aurabindo Pillai , Alvin Lee , George Shen , Hamza Mahfooz , Chaitanya Dhere , Alan Liu , Mukul Joshi , =?utf-8?q?Andr=C3=A9_Almeida?= , Jingwen Zhu , Guo Zhengkui , Leo Li , Melissa Wen , Le Ma , Jiapeng Chong , Caio Novais , Martin Leung , Ryan Lin , Brian Chang , Sung Joon Kim , Yifan Zhang , Jack Xiao , Dillon Varone , Tom Chung , Wesley Chalmers , Qingqing Zhuo , "Pan, Xinhui" , Zhan Liu , Roman Li , =?utf-8?q?Christi?= =?utf-8?q?an_K=C3=B6nig?= , Wayne Lin , Alex Deucher , Ethan Wellenreiter , Nicholas Kazlauskas , Joshua Ashton , Hawking Zhang Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Compiling AMD GPU drivers displays a warning: drivers/gpu/drm/amd/amdgpu/../display/dc/dcn30/dcn30_afmt.c: In function ‘afmt3_se_audio_setup’: drivers/gpu/drm/amd/amdgpu/../display/dc/dcn30/dcn30_afmt.c:126:18: warning: variable ‘speakers’ set but not used [-Wunused-but-set-variable] Get rid of it by removing the variable. Signed-off-by: Caio Novais --- drivers/gpu/drm/amd/display/dc/dcn30/dcn30_afmt.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/dcn30/dcn30_afmt.c b/drivers/gpu/drm/amd/display/dc/dcn30/dcn30_afmt.c index 95528e5ef89e..55e388c4c98b 100644 --- a/drivers/gpu/drm/amd/display/dc/dcn30/dcn30_afmt.c +++ b/drivers/gpu/drm/amd/display/dc/dcn30/dcn30_afmt.c @@ -123,7 +123,6 @@ void afmt3_se_audio_setup( { struct dcn30_afmt *afmt3 = DCN30_AFMT_FROM_AFMT(afmt); - uint32_t speakers = 0; uint32_t channels = 0; ASSERT(audio_info); @@ -131,7 +130,6 @@ void afmt3_se_audio_setup( if (audio_info == NULL) return; - speakers = audio_info->flags.info.ALLSPEAKERS; channels = speakers_to_channels(audio_info->flags.speaker_flags).all; /* setup the audio stream source select (audio -> dig mapping) */ From patchwork Mon Mar 27 23:33:47 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Caio Novais X-Patchwork-Id: 13190257 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E65CEC6FD1D for ; Mon, 27 Mar 2023 23:35:13 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 42D8A10E7C3; Mon, 27 Mar 2023 23:35:13 +0000 (UTC) Received: from mail-oi1-x235.google.com (mail-oi1-x235.google.com [IPv6:2607:f8b0:4864:20::235]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7835F10E7C1 for ; Mon, 27 Mar 2023 23:35:10 +0000 (UTC) Received: by mail-oi1-x235.google.com with SMTP id bi31so7682908oib.9 for ; Mon, 27 Mar 2023 16:35:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=usp.br; s=usp-google; t=1679960109; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=yAF560UdJX0GEGh8pB1EAaLbRBoRHEw96H0zayNQKjc=; b=s5BGJnAq7jaEqaXyIrghhFPGN9hy259iqKpXXpXaLj6L2JgntWwWRT6UwzgFlL+a6W br0qVZmkEWUZydrOQC4RCcT08aprE/usdIisKmADVQTJWZ9gkn3qOoRxa6xH/VwZdZYd H6xJ8snIaCAxI8OR/2rpEpjvQxq4fo8hn1T+N4L/9gP+EFRzPFNqq40G34MBOLW5+ltB xJiKW4lWmTocpeyGW60GYjyY67U9OI3/VgY814ZUnRKxgLIgyQ9UbU9XRVQF4vEaidER SQpbiRtTQMZRqidHy2/13vqKJSjrBZDDVKUU5qEqOj/9JRRRZkVpXovfI+KwpabwKJ9B yg2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679960109; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yAF560UdJX0GEGh8pB1EAaLbRBoRHEw96H0zayNQKjc=; b=vHkZBzv9bFCEwh1zCq5IgWXwa/fs2UtZZjXNYHdq+tDU1e4niG5G5HZ+VILZpnIUAi tCaKOF81OOqDC9HMS19EEKk2Gc++R1gXNxF/yb2aW1NQT8aw1AqjgAVMWK6yKJayTOy5 bI0nFgpztG1hY6dUyam1n3b3q4j/7Fp832gZCknVJEpXPiJG+7xh063U7nHV1AAy9Muz k12a4GhpTTxXhFwVo3zHrKUgj9DHu1aXxp7ssUTt3Bc7l/FNYBBYLewUobiZ11+L871G 6AmklxENZflsoldoqv0wXxpNKdXqk9gxVFBlFPswwlH2Eu5kF2U5VJHVahIXxiTXMU5I otkw== X-Gm-Message-State: AAQBX9f9+F6lWGZqjRlUX6pKn1eVj3/PB3PpdAu+TIjgE2Iq5IBAUoWO zBmK/1y2vXZsz6nLm7Bi5620+g== X-Google-Smtp-Source: AKy350aHN1ssxfd7wdlDmSEKxo8G+lYPHr4FVFNdyq/GmsDYlksjWmJHcmWgoxbY/wLtygfAH8HgwA== X-Received: by 2002:a05:6808:9b3:b0:389:545c:a95f with SMTP id e19-20020a05680809b300b00389545ca95fmr5474oig.42.1679960109737; Mon, 27 Mar 2023 16:35:09 -0700 (PDT) Received: from ARCHaio.localdomain ([2804:1b3:a2c0:c911:919f:bd20:4f2a:8383]) by smtp.gmail.com with ESMTPSA id b186-20020aca34c3000000b00389295e8424sm1643409oia.45.2023.03.27.16.34.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Mar 2023 16:35:09 -0700 (PDT) From: Caio Novais To: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH 06/12] drm/amd/display: Remove unused variable 'mc_vm_apt_default' Date: Mon, 27 Mar 2023 20:33:47 -0300 Message-Id: <20230327233353.64081-7-caionovais@usp.br> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230327233353.64081-1-caionovais@usp.br> References: <20230327233353.64081-1-caionovais@usp.br> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Felipe Clark , Wenjing Liu , =?utf-8?q?Ma=C3=ADra_Canal?= , Mario Limonciello , Jun Lei , Charlene Liu , Gabe Teeger , Rodrigo Siqueira , Taimur Hassan , Aurabindo Pillai , Alvin Lee , George Shen , Hamza Mahfooz , Chaitanya Dhere , Alan Liu , Mukul Joshi , =?utf-8?q?Andr=C3=A9_Almeida?= , Jingwen Zhu , Guo Zhengkui , Leo Li , Melissa Wen , Le Ma , Jiapeng Chong , Caio Novais , Martin Leung , Ryan Lin , Brian Chang , Sung Joon Kim , Yifan Zhang , Jack Xiao , Dillon Varone , Tom Chung , Wesley Chalmers , Qingqing Zhuo , "Pan, Xinhui" , Zhan Liu , Roman Li , =?utf-8?q?Christi?= =?utf-8?q?an_K=C3=B6nig?= , Wayne Lin , Alex Deucher , Ethan Wellenreiter , Nicholas Kazlauskas , Joshua Ashton , Hawking Zhang Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Compiling AMD GPU drivers displays a warning: drivers/gpu/drm/amd/amdgpu/../display/dc/dcn30/dcn30_hubp.c: In function ‘hubp3_set_vm_system_aperture_settings’: drivers/gpu/drm/amd/amdgpu/../display/dc/dcn30/dcn30_hubp.c:50:30: warning: variable ‘mc_vm_apt_default’ set but not used [-Wunused-but-set-variable] Get rid of it by removing the variable. Signed-off-by: Caio Novais --- drivers/gpu/drm/amd/display/dc/dcn30/dcn30_hubp.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/dcn30/dcn30_hubp.c b/drivers/gpu/drm/amd/display/dc/dcn30/dcn30_hubp.c index dc3e8df706b3..e46bbe7ddcc9 100644 --- a/drivers/gpu/drm/amd/display/dc/dcn30/dcn30_hubp.c +++ b/drivers/gpu/drm/amd/display/dc/dcn30/dcn30_hubp.c @@ -47,13 +47,9 @@ void hubp3_set_vm_system_aperture_settings(struct hubp *hubp, { struct dcn20_hubp *hubp2 = TO_DCN20_HUBP(hubp); - PHYSICAL_ADDRESS_LOC mc_vm_apt_default; PHYSICAL_ADDRESS_LOC mc_vm_apt_low; PHYSICAL_ADDRESS_LOC mc_vm_apt_high; - // The format of default addr is 48:12 of the 48 bit addr - mc_vm_apt_default.quad_part = apt->sys_default.quad_part >> 12; - // The format of high/low are 48:18 of the 48 bit addr mc_vm_apt_low.quad_part = apt->sys_low.quad_part >> 18; mc_vm_apt_high.quad_part = apt->sys_high.quad_part >> 18; From patchwork Mon Mar 27 23:33:48 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Caio Novais X-Patchwork-Id: 13190258 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A8D2AC6FD1D for ; Mon, 27 Mar 2023 23:35:23 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E145B10E7B6; Mon, 27 Mar 2023 23:35:22 +0000 (UTC) Received: from mail-oi1-x22c.google.com (mail-oi1-x22c.google.com [IPv6:2607:f8b0:4864:20::22c]) by gabe.freedesktop.org (Postfix) with ESMTPS id 24CF510E7B4 for ; Mon, 27 Mar 2023 23:35:20 +0000 (UTC) Received: by mail-oi1-x22c.google.com with SMTP id r16so7610897oij.5 for ; Mon, 27 Mar 2023 16:35:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=usp.br; s=usp-google; t=1679960120; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=DIwazwlkbXfr/mhs4ygPSCHkxMgXqhz2v9oIbK7e01k=; b=TTy7nMwv8iMo9KYVcMt30TmODMyElVifkej9lEeLYbHgK0TUC3YmQlbcg+Xo46YJmz PYiDPL6xk4c/s7E6SmIBKoazamO9F5A6s5w8jMtY+oTyZhW3eEnO100xmx22j7SDJZtP 6VsCIUno/jksYrlZ4XP3qSFj9Rm6alVqr8qpzlU9CFbwS4sL9mfnoIPXpCJolwmgjbec FqTmiiFznHEg0Ddqp6e4A3sJMsba+tXsBaNtiwGKtPEAF0nk1OARrZNSGtGNt0fS4gbn 9S1YXKcidghXj5K610oyihoMZCyGAk9I/eY8AXEE+1iuCHHW2VWqcqvzcS54KAC10+rI MiEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679960120; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DIwazwlkbXfr/mhs4ygPSCHkxMgXqhz2v9oIbK7e01k=; b=5xeQjuy/pais8JTYoyFsVxK34UJ4GELfxzX9MKCdgI8xHxu68SDE5RpBzGjlBtZRu8 rXWlaRd9v0GLOUZn/eAw+LPDeqXhzEwpHYMKYnfFUbi/NnWO13LjW7mfc5TIL5WSwJo6 aJygwcxTKFqirzxHEICI9wo08tLg3fd2eqppjFmu+x4eiFCX9oqG5xm/dtcloUK7TiPh 53f2yDYyZTW6nldhuFuNgEa1wMKYh31wiUMbddA2ONT4q7xNzlJxlgLOVdZ/xsIb/oda 07t972AN/R2OWB/4d7LwTCbDjdCipra+4JNqLlrWWFh3E6toTA2SXOTo0zQKFuNfof3z Q+HQ== X-Gm-Message-State: AAQBX9fazoABaLySTvMOtYYsjkZ39m1OoxmC4uz3FtuB72Oheb2lJ4GB iEdF/CvLuh67FrOLsi+xCi7yUg== X-Google-Smtp-Source: AKy350aybt0Fe2KHw7h4hdkKAaCWXQkSMi8faLZ2/V9VaQBsYk7eWBNPEMr15jlKWRpkhkGERzjJYw== X-Received: by 2002:a05:6808:21a0:b0:388:edc5:3373 with SMTP id be32-20020a05680821a000b00388edc53373mr5891957oib.14.1679960119763; Mon, 27 Mar 2023 16:35:19 -0700 (PDT) Received: from ARCHaio.localdomain ([2804:1b3:a2c0:c911:919f:bd20:4f2a:8383]) by smtp.gmail.com with ESMTPSA id b186-20020aca34c3000000b00389295e8424sm1643409oia.45.2023.03.27.16.35.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Mar 2023 16:35:19 -0700 (PDT) From: Caio Novais To: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH 07/12] drm/amd/display: Remove unused variable 'optc' Date: Mon, 27 Mar 2023 20:33:48 -0300 Message-Id: <20230327233353.64081-8-caionovais@usp.br> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230327233353.64081-1-caionovais@usp.br> References: <20230327233353.64081-1-caionovais@usp.br> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Felipe Clark , Wenjing Liu , =?utf-8?q?Ma=C3=ADra_Canal?= , Mario Limonciello , Jun Lei , Charlene Liu , Gabe Teeger , Rodrigo Siqueira , Taimur Hassan , Aurabindo Pillai , Alvin Lee , George Shen , Hamza Mahfooz , Chaitanya Dhere , Alan Liu , Mukul Joshi , =?utf-8?q?Andr=C3=A9_Almeida?= , Jingwen Zhu , Guo Zhengkui , Leo Li , Melissa Wen , Le Ma , Jiapeng Chong , Caio Novais , Martin Leung , Ryan Lin , Brian Chang , Sung Joon Kim , Yifan Zhang , Jack Xiao , Dillon Varone , Tom Chung , Wesley Chalmers , Qingqing Zhuo , "Pan, Xinhui" , Zhan Liu , Roman Li , =?utf-8?q?Christi?= =?utf-8?q?an_K=C3=B6nig?= , Wayne Lin , Alex Deucher , Ethan Wellenreiter , Nicholas Kazlauskas , Joshua Ashton , Hawking Zhang Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Compiling AMD GPU drivers displays a warning: drivers/gpu/drm/amd/amdgpu/../display/dc/dcn30/dcn30_hwseq.c: In function ‘dcn30_enable_writeback’: drivers/gpu/drm/amd/amdgpu/../display/dc/dcn30/dcn30_hwseq.c:326:34: warning: variable ‘optc’ set but not used [-Wunused-but-set-variable] Get rid of it by removing the variable. Signed-off-by: Caio Novais --- drivers/gpu/drm/amd/display/dc/dcn30/dcn30_hwseq.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/dcn30/dcn30_hwseq.c b/drivers/gpu/drm/amd/display/dc/dcn30/dcn30_hwseq.c index 3b4d4d68359b..6ef85e71380c 100644 --- a/drivers/gpu/drm/amd/display/dc/dcn30/dcn30_hwseq.c +++ b/drivers/gpu/drm/amd/display/dc/dcn30/dcn30_hwseq.c @@ -323,13 +323,10 @@ void dcn30_enable_writeback( { struct dwbc *dwb; struct mcif_wb *mcif_wb; - struct timing_generator *optc; dwb = dc->res_pool->dwbc[wb_info->dwb_pipe_inst]; mcif_wb = dc->res_pool->mcif_wb[wb_info->dwb_pipe_inst]; - /* set the OPTC source mux */ - optc = dc->res_pool->timing_generators[dwb->otg_inst]; DC_LOG_DWB("%s dwb_pipe_inst = %d, mpcc_inst = %d",\ __func__, wb_info->dwb_pipe_inst,\ wb_info->mpcc_inst); From patchwork Mon Mar 27 23:33:49 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Caio Novais X-Patchwork-Id: 13190259 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 12EBCC6FD1D for ; Mon, 27 Mar 2023 23:35:34 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4C38D10E7C9; Mon, 27 Mar 2023 23:35:33 +0000 (UTC) Received: from mail-oi1-x22c.google.com (mail-oi1-x22c.google.com [IPv6:2607:f8b0:4864:20::22c]) by gabe.freedesktop.org (Postfix) with ESMTPS id B7D4310E7CB for ; Mon, 27 Mar 2023 23:35:30 +0000 (UTC) Received: by mail-oi1-x22c.google.com with SMTP id y184so7698811oiy.8 for ; Mon, 27 Mar 2023 16:35:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=usp.br; s=usp-google; t=1679960130; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=rUkta+0S5SLkoZECV+gOZOOKUmxnKipm+UrOigNAFFk=; b=swJb8KVfeXLvtuIhEIeBE9NbxPQxoD9VVnzPlKqChCd6u3oKt2nYGhQip4wsSdXnlJ jy4oScaGOmGE/uhRqfkOwL/RWknbsB9S60gJG298OwojfzpZLrOsoRlH61rPhFFJiuta dWDWYo+kOd572NhZl5aYIYYGL+W6RhDlZ35j906H/+Z9GMS7nlX0Pp4ZekMwTH243tt4 qNZJ81RkxI5g0r/vzzlr5AyIQBJPAaKi6tl4vRxYEsirvujARmH8IpruV76ntFA4ulpd xGjd2XZWA6to4BdtnP5AQ7pR6fKMoFnmiF6PkqqmB5flk0x1JZ0JvTSnf2XLJamsuZBL hhUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679960130; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rUkta+0S5SLkoZECV+gOZOOKUmxnKipm+UrOigNAFFk=; b=HQWEYdTy7jmmXHdQ1ZH+ZGUUtRnsKmCxKJct0f++q2vHFtMSSztwCj34oYVnL9MHty O0qmVXR0a7eZltLnudCZ/A4iYehhoHud8decFnhLwKrTIVjZUYnm6L9Fji1vrRMZGnys kJDoiDSQcSTMW/C0K12dlgfSCljDzVUwomo8uP1oI3/lf1SNOnW46b4ofceRLcyK1Iju oFnGpaz+GcoefQhRxqI0D+h1HGYvjIal2KQIwZ7yaqUO2bvMsW1BPjKAi4yo9zGcVCvl 6zoFMLdHWC4meD4yhroyC4T27NpJCclZGPZ/OmZnp3glTFlNPRZqwAjUmUxddKTE4Q+e +vlw== X-Gm-Message-State: AO0yUKWXCtFpWVtlj+y/eFjuaTNbDi20SBzc+gF2nIJu/QeLu6TDFKPq XuKRM92XyR9EWkj10rP06nivbQ== X-Google-Smtp-Source: AK7set+QyePXkuvYL4djaRZGrEn+bFJpxBVjzKR7R2A7NNFYEfpsX+JwGBSrTo3Ckjv7Q5X9M18xqQ== X-Received: by 2002:a05:6808:634a:b0:383:febf:2a97 with SMTP id eb10-20020a056808634a00b00383febf2a97mr5828896oib.11.1679960129822; Mon, 27 Mar 2023 16:35:29 -0700 (PDT) Received: from ARCHaio.localdomain ([2804:1b3:a2c0:c911:919f:bd20:4f2a:8383]) by smtp.gmail.com with ESMTPSA id b186-20020aca34c3000000b00389295e8424sm1643409oia.45.2023.03.27.16.35.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Mar 2023 16:35:29 -0700 (PDT) From: Caio Novais To: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH 08/12] drm/amd/display: Remove two unused variables 'speakers' and 'channels' and remove unused function 'speakers_to_channels' Date: Mon, 27 Mar 2023 20:33:49 -0300 Message-Id: <20230327233353.64081-9-caionovais@usp.br> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230327233353.64081-1-caionovais@usp.br> References: <20230327233353.64081-1-caionovais@usp.br> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Felipe Clark , Wenjing Liu , =?utf-8?q?Ma=C3=ADra_Canal?= , Mario Limonciello , Jun Lei , Charlene Liu , Gabe Teeger , Rodrigo Siqueira , Taimur Hassan , Aurabindo Pillai , Alvin Lee , George Shen , Hamza Mahfooz , Chaitanya Dhere , Alan Liu , Mukul Joshi , =?utf-8?q?Andr=C3=A9_Almeida?= , Jingwen Zhu , Guo Zhengkui , Leo Li , Melissa Wen , Le Ma , Jiapeng Chong , Caio Novais , Martin Leung , Ryan Lin , Brian Chang , Sung Joon Kim , Yifan Zhang , Jack Xiao , Dillon Varone , Tom Chung , Wesley Chalmers , Qingqing Zhuo , "Pan, Xinhui" , Zhan Liu , Roman Li , =?utf-8?q?Christi?= =?utf-8?q?an_K=C3=B6nig?= , Wayne Lin , Alex Deucher , Ethan Wellenreiter , Nicholas Kazlauskas , Joshua Ashton , Hawking Zhang Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Compiling AMD GPU drivers displays two warnings: drivers/gpu/drm/amd/amdgpu/../display/dc/dcn31/dcn31_apg.c: In function ‘apg31_se_audio_setup’: drivers/gpu/drm/amd/amdgpu/../display/dc/dcn31/dcn31_apg.c:117:18: warning: variable ‘channels’ set but not used [-Wunused-but-set-variable] and drivers/gpu/drm/amd/amdgpu/../display/dc/dcn31/dcn31_apg.c:116:18: warning: variable ‘speakers’ set but not used [-Wunused-but-set-variable] Get rid of them by removing the variables and the function "speakers_to_channels". Signed-off-by: Caio Novais --- .../gpu/drm/amd/display/dc/dcn31/dcn31_apg.c | 39 ------------------- 1 file changed, 39 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/dcn31/dcn31_apg.c b/drivers/gpu/drm/amd/display/dc/dcn31/dcn31_apg.c index 24e9ff65434d..e94d0ba915ce 100644 --- a/drivers/gpu/drm/amd/display/dc/dcn31/dcn31_apg.c +++ b/drivers/gpu/drm/amd/display/dc/dcn31/dcn31_apg.c @@ -72,40 +72,6 @@ static void apg31_disable( REG_UPDATE(APG_CONTROL2, APG_ENABLE, 0); } -static union audio_cea_channels speakers_to_channels( - struct audio_speaker_flags speaker_flags) -{ - union audio_cea_channels cea_channels = {0}; - - /* these are one to one */ - cea_channels.channels.FL = speaker_flags.FL_FR; - cea_channels.channels.FR = speaker_flags.FL_FR; - cea_channels.channels.LFE = speaker_flags.LFE; - cea_channels.channels.FC = speaker_flags.FC; - - /* if Rear Left and Right exist move RC speaker to channel 7 - * otherwise to channel 5 - */ - if (speaker_flags.RL_RR) { - cea_channels.channels.RL_RC = speaker_flags.RL_RR; - cea_channels.channels.RR = speaker_flags.RL_RR; - cea_channels.channels.RC_RLC_FLC = speaker_flags.RC; - } else { - cea_channels.channels.RL_RC = speaker_flags.RC; - } - - /* FRONT Left Right Center and REAR Left Right Center are exclusive */ - if (speaker_flags.FLC_FRC) { - cea_channels.channels.RC_RLC_FLC = speaker_flags.FLC_FRC; - cea_channels.channels.RRC_FRC = speaker_flags.FLC_FRC; - } else { - cea_channels.channels.RC_RLC_FLC = speaker_flags.RLC_RRC; - cea_channels.channels.RRC_FRC = speaker_flags.RLC_RRC; - } - - return cea_channels; -} - static void apg31_se_audio_setup( struct apg *apg, unsigned int az_inst, @@ -113,17 +79,12 @@ static void apg31_se_audio_setup( { struct dcn31_apg *apg31 = DCN31_APG_FROM_APG(apg); - uint32_t speakers = 0; - uint32_t channels = 0; ASSERT(audio_info); /* This should not happen.it does so we don't get BSOD*/ if (audio_info == NULL) return; - speakers = audio_info->flags.info.ALLSPEAKERS; - channels = speakers_to_channels(audio_info->flags.speaker_flags).all; - /* DisplayPort only allows for one audio stream with stream ID 0 */ REG_UPDATE(APG_CONTROL2, APG_DP_AUDIO_STREAM_ID, 0); From patchwork Mon Mar 27 23:33:50 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Caio Novais X-Patchwork-Id: 13190260 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 93A60C76195 for ; Mon, 27 Mar 2023 23:35:42 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 03BD210E7CB; Mon, 27 Mar 2023 23:35:42 +0000 (UTC) Received: from mail-oi1-x22c.google.com (mail-oi1-x22c.google.com [IPv6:2607:f8b0:4864:20::22c]) by gabe.freedesktop.org (Postfix) with ESMTPS id 907F410E7CB for ; Mon, 27 Mar 2023 23:35:40 +0000 (UTC) Received: by mail-oi1-x22c.google.com with SMTP id r14so2020964oiw.12 for ; Mon, 27 Mar 2023 16:35:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=usp.br; s=usp-google; t=1679960140; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1A2mIjPdUqhr5Ice4vp7gIRuK6chByRV3cyN7aavT0E=; b=hBEZEu/Fg8Z7uqZ/Ekz1hHMkGIiWSFF5sR50cANSTAnWulG9QmfK+wwFoes5VSYTRh htMmf303bnpibjbmVMsR9SPCc51HKUstFFhpmUbInbdSvxo7XOCdedKUFZ8ZtXeJ7/FA 238eQJQE4A1BarBX9h8IbgyVHKEJmOM2bfBO2yN40h1Yw8KQ3rxQ/tQW4pQ1x4wP5cwj x4RDRYoVZB/R5SC67RF1rxAyAA1Nu27ewQa8soq4BzP4HWRC7hBCY2FiqLFMYboWuy++ x2mBeYBSEDmh/XqmaVCK4Cp6GkEDyA9YmnvG/o4ecItjja9Cz2eSbfxPBnJSBpJvtT0J pvug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679960140; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1A2mIjPdUqhr5Ice4vp7gIRuK6chByRV3cyN7aavT0E=; b=4VpmwgCESmr+FW2jpV4Gw4RQMt/oThYoR3iUpIL/JiywE5NXb+8YHEQPLYBX4KVCAt T0qqgPqQ30IONRmmry6gz27sxpfmSU9kSd7AKniw+yVdL/PStqtVXj5HrIHm9K1dF+TT BzdEZOIXIoM69mV/seHLEKIxlPCPkUKOPAB+ZZ+TaUxoAtm7zVJZPeOV6Cmj/wHEIjkI NUBtnqlo0NIYu699PpnewCUgkEBpJ5nUUb63uHID+nLkKW4yqxABf65AOkY7N58F8aml 3kYlVNo81VzEgHoat9W/HLp6Isjr4NXNsjU4Hknkl6EODbqxRn9XOwl2yThVIRmRaB57 J0sw== X-Gm-Message-State: AO0yUKXIIeM/B6cD0M1qlKU5i9RZ6/qBevC5r0gqrxmYa9hVjPjsCPM0 2NQ3D7EL5B+YKCY/xb+IjHD0TA== X-Google-Smtp-Source: AK7set/XpIaBnrd0Il1RA6TJi7frFciWmH9SabrmY2R33L9ZbylSXEKtU1Nfc4VXuM45NiWKMhJC9Q== X-Received: by 2002:a05:6808:58:b0:386:f58a:2262 with SMTP id v24-20020a056808005800b00386f58a2262mr5575924oic.57.1679960139887; Mon, 27 Mar 2023 16:35:39 -0700 (PDT) Received: from ARCHaio.localdomain ([2804:1b3:a2c0:c911:919f:bd20:4f2a:8383]) by smtp.gmail.com with ESMTPSA id b186-20020aca34c3000000b00389295e8424sm1643409oia.45.2023.03.27.16.35.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Mar 2023 16:35:39 -0700 (PDT) From: Caio Novais To: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH 09/12] drm/amd/display: Remove two unused variables 'is_pipe_split_expected' and 'state' Date: Mon, 27 Mar 2023 20:33:50 -0300 Message-Id: <20230327233353.64081-10-caionovais@usp.br> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230327233353.64081-1-caionovais@usp.br> References: <20230327233353.64081-1-caionovais@usp.br> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Felipe Clark , Wenjing Liu , =?utf-8?q?Ma=C3=ADra_Canal?= , Mario Limonciello , Jun Lei , Charlene Liu , Gabe Teeger , Rodrigo Siqueira , Taimur Hassan , Aurabindo Pillai , Alvin Lee , George Shen , Hamza Mahfooz , Chaitanya Dhere , Alan Liu , Mukul Joshi , =?utf-8?q?Andr=C3=A9_Almeida?= , Jingwen Zhu , Guo Zhengkui , Leo Li , Melissa Wen , Le Ma , Jiapeng Chong , Caio Novais , Martin Leung , Ryan Lin , Brian Chang , Sung Joon Kim , Yifan Zhang , Jack Xiao , Dillon Varone , Tom Chung , Wesley Chalmers , Qingqing Zhuo , "Pan, Xinhui" , Zhan Liu , Roman Li , =?utf-8?q?Christi?= =?utf-8?q?an_K=C3=B6nig?= , Wayne Lin , Alex Deucher , Ethan Wellenreiter , Nicholas Kazlauskas , Joshua Ashton , Hawking Zhang Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Compiling AMD GPU drivers displays two warnings: drivers/gpu/drm/amd/amdgpu/../display/dc/dcn32/dcn32_resource.c: In function ‘dcn32_acquire_post_bldn_3dlut’: drivers/gpu/drm/amd/amdgpu/../display/dc/dcn32/dcn32_resource.c:1614:31: warning: variable ‘state’ set but not used [-Wunused-but-set-variable] and drivers/gpu/drm/amd/amdgpu/../display/dc/dcn32/dcn32_resource.c: In function ‘dcn32_populate_dml_pipes_from_context’: drivers/gpu/drm/amd/amdgpu/../display/dc/dcn32/dcn32_resource.c:1916:17: warning: variable ‘is_pipe_split_expected’ set but not used [-Wunused-but-set-variable] Get rid of them by removing the variables. Signed-off-by: Caio Novais --- drivers/gpu/drm/amd/display/dc/dcn32/dcn32_resource.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_resource.c b/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_resource.c index 74e50c09bb62..3435d3294e0b 100644 --- a/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_resource.c +++ b/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_resource.c @@ -1611,7 +1611,6 @@ bool dcn32_acquire_post_bldn_3dlut( struct dc_transfer_func **shaper) { bool ret = false; - union dc_3dlut_state *state; ASSERT(*lut == NULL && *shaper == NULL); *lut = NULL; @@ -1620,7 +1619,6 @@ bool dcn32_acquire_post_bldn_3dlut( if (!res_ctx->is_mpc_3dlut_acquired[mpcc_id]) { *lut = pool->mpc_lut[mpcc_id]; *shaper = pool->mpc_shaper[mpcc_id]; - state = &pool->mpc_lut[mpcc_id]->state; res_ctx->is_mpc_3dlut_acquired[mpcc_id] = true; ret = true; } @@ -1913,7 +1911,6 @@ int dcn32_populate_dml_pipes_from_context( struct resource_context *res_ctx = &context->res_ctx; struct pipe_ctx *pipe; bool subvp_in_use = false; - uint8_t is_pipe_split_expected[MAX_PIPES] = {0}; struct dc_crtc_timing *timing; dcn20_populate_dml_pipes_from_context(dc, context, pipes, fast_validate); @@ -2002,7 +1999,6 @@ int dcn32_populate_dml_pipes_from_context( } DC_FP_START(); - is_pipe_split_expected[i] = dcn32_predict_pipe_split(context, &pipes[pipe_cnt]); DC_FP_END(); pipe_cnt++; From patchwork Mon Mar 27 23:33:51 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Caio Novais X-Patchwork-Id: 13190261 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E95F9C6FD1D for ; Mon, 27 Mar 2023 23:35:53 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EED8D10E7D0; Mon, 27 Mar 2023 23:35:52 +0000 (UTC) Received: from mail-oi1-x234.google.com (mail-oi1-x234.google.com [IPv6:2607:f8b0:4864:20::234]) by gabe.freedesktop.org (Postfix) with ESMTPS id A922A10E7CE for ; Mon, 27 Mar 2023 23:35:50 +0000 (UTC) Received: by mail-oi1-x234.google.com with SMTP id bk5so7700562oib.6 for ; Mon, 27 Mar 2023 16:35:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=usp.br; s=usp-google; t=1679960150; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=K1xhDxA3uWDRifG4IvLBAoRIIiYm0r4QC9LLNbKp2X8=; b=hvoaJX2ufI+udaK8mtxiLI21DzeH7JurXG/B43jOARKu83aSms5p/jUB7lwFs6omfL C3MvJEbwKrp4+zN7nS9bwwLJRstOf0GeeBnUjX0wuSPeyXQ2hqrkBQek1SQGMIiX+KCX /4ZPrhOgZvJ0MEOfcTm3nKfKoZUGeUiv8O33K6TquSH+CmZVXyqzo50twDCInP4i9q9l LtUwMM4WfNHC2cmc/CLIiaJJAaok/ssG3j/4jAMDz7SP/mcITFs8jlPilmDmUbIu1rpa S8HtZoIjJX3ZkBhEtr41i+hLJVS4ef1KC5FtF535WpCQQdngJk+XZwGB3Wp0bFrZvPsJ rcZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679960150; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=K1xhDxA3uWDRifG4IvLBAoRIIiYm0r4QC9LLNbKp2X8=; b=q0Yabs1h77i95KIz5WUVkoZPMpg8valPEV/0qLdd4KfyFR1dHpox0Gp6z8jEjrVq2N 9rHHbrg9hHlWG6WmgVjlDnzrdZ+BKSsSZdQt1a7VB6tRu9goE6/DDXLlkKNbL/jnL/yJ 0uYW8VelKPdr9P1oQwssSpN4GYVFb8mEvx2qyUC3cfrwiWJKBqx/2e1cob9oADudZmo9 8wlj9c30kDO5cCcnrsk6L3gtp7wD2Z7npvOzlOjVOOBpU+aEDqpNd8Ajfd9So6XazY4c eEo41LsnJj1mJ1V/EgjhQsW3SsTVeuNo+CGmPWbBK16XNI7FuGH4Yu5e4AGly7aPkIG5 72LQ== X-Gm-Message-State: AO0yUKUWEzgbLwoMBByIHSvq6i2Juket195QRbZfoHLGZ+SWjfWQq5qw TEYQE8QcbzOrVZRRq5siJB1tYQ== X-Google-Smtp-Source: AK7set8NiGmgJV8HERS4O1DEMBfqAEeV4IytdUJ48dLagBB0+Hq6qQQfvpgB8IkKbofF5pTimWiQAg== X-Received: by 2002:aca:6507:0:b0:387:3239:61fa with SMTP id m7-20020aca6507000000b00387323961famr5553985oim.30.1679960149872; Mon, 27 Mar 2023 16:35:49 -0700 (PDT) Received: from ARCHaio.localdomain ([2804:1b3:a2c0:c911:919f:bd20:4f2a:8383]) by smtp.gmail.com with ESMTPSA id b186-20020aca34c3000000b00389295e8424sm1643409oia.45.2023.03.27.16.35.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Mar 2023 16:35:49 -0700 (PDT) From: Caio Novais To: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH 10/12] drm/amd/display: Remove unused variable 'cursor_bpp' Date: Mon, 27 Mar 2023 20:33:51 -0300 Message-Id: <20230327233353.64081-11-caionovais@usp.br> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230327233353.64081-1-caionovais@usp.br> References: <20230327233353.64081-1-caionovais@usp.br> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Felipe Clark , Wenjing Liu , =?utf-8?q?Ma=C3=ADra_Canal?= , Mario Limonciello , Jun Lei , Charlene Liu , Gabe Teeger , Rodrigo Siqueira , Taimur Hassan , Aurabindo Pillai , Alvin Lee , George Shen , Hamza Mahfooz , Chaitanya Dhere , Alan Liu , Mukul Joshi , =?utf-8?q?Andr=C3=A9_Almeida?= , Jingwen Zhu , Guo Zhengkui , Leo Li , Melissa Wen , Le Ma , Jiapeng Chong , Caio Novais , Martin Leung , Ryan Lin , Brian Chang , Sung Joon Kim , Yifan Zhang , Jack Xiao , Dillon Varone , Tom Chung , Wesley Chalmers , Qingqing Zhuo , "Pan, Xinhui" , Zhan Liu , Roman Li , =?utf-8?q?Christi?= =?utf-8?q?an_K=C3=B6nig?= , Wayne Lin , Alex Deucher , Ethan Wellenreiter , Nicholas Kazlauskas , Joshua Ashton , Hawking Zhang Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Compiling AMD GPU drivers displays a warning: drivers/gpu/drm/amd/amdgpu/../display/dc/dcn32/dcn32_resource_helpers.c: In function ‘dcn32_helper_calculate_mall_bytes_for_cursor’: drivers/gpu/drm/amd/amdgpu/../display/dc/dcn32/dcn32_resource_helpers.c:62:18: warning: variable ‘cursor_bpp’ set but not used [-Wunused-but-set-variable] Get rid of it by removing the variable. Signed-off-by: Caio Novais --- drivers/gpu/drm/amd/display/dc/dcn32/dcn32_resource_helpers.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_resource_helpers.c b/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_resource_helpers.c index 3a2d7bcc4b6d..a616cf078cf4 100644 --- a/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_resource_helpers.c +++ b/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_resource_helpers.c @@ -59,25 +59,21 @@ uint32_t dcn32_helper_calculate_mall_bytes_for_cursor( { struct hubp *hubp = pipe_ctx->plane_res.hubp; uint32_t cursor_size = hubp->curs_attr.pitch * hubp->curs_attr.height; - uint32_t cursor_bpp = 4; uint32_t cursor_mall_size_bytes = 0; switch (pipe_ctx->stream->cursor_attributes.color_format) { case CURSOR_MODE_MONO: cursor_size /= 2; - cursor_bpp = 4; break; case CURSOR_MODE_COLOR_1BIT_AND: case CURSOR_MODE_COLOR_PRE_MULTIPLIED_ALPHA: case CURSOR_MODE_COLOR_UN_PRE_MULTIPLIED_ALPHA: cursor_size *= 4; - cursor_bpp = 4; break; case CURSOR_MODE_COLOR_64BIT_FP_PRE_MULTIPLIED: case CURSOR_MODE_COLOR_64BIT_FP_UN_PRE_MULTIPLIED: cursor_size *= 8; - cursor_bpp = 8; break; } From patchwork Mon Mar 27 23:33:52 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Caio Novais X-Patchwork-Id: 13190262 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0B045C6FD1D for ; Mon, 27 Mar 2023 23:36:04 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E514610E413; Mon, 27 Mar 2023 23:36:02 +0000 (UTC) Received: from mail-oi1-x22c.google.com (mail-oi1-x22c.google.com [IPv6:2607:f8b0:4864:20::22c]) by gabe.freedesktop.org (Postfix) with ESMTPS id 47F3710E413 for ; Mon, 27 Mar 2023 23:36:00 +0000 (UTC) Received: by mail-oi1-x22c.google.com with SMTP id r14so2021419oiw.12 for ; Mon, 27 Mar 2023 16:36:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=usp.br; s=usp-google; t=1679960160; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1STa2/pWkCDUQgTVLH0svd7MRisCAzPtmwfg6lpY0tI=; b=qPr+/DvkkL35CXSg4gE7/ktKUvTDyUTO7/IL0lvUrUhq8xvT+h0HhqzQfjWn1sHUfq En1aRSU2RJDmigFYzTkS8EzveTOuSZurTNaXQXuMC6z/L0zjjcJ8pOP/RAK6YNbcQw4q N5w7bZZE64NLFvAe+hhsuZfaHKcZTlvPLUVB9WGh8vWvbT6Bw4YEgTBixKkzkX8laK7u c3mserAVKXZC8U5cNFsmkDDulr/6NVBOx3crHKcKt03a7xXztRoIGeA5RCQKYfaqLqZm P+MTr26pEMPaE0/LT8tYpGLXoDohT7fYS5w7xLTwM+j6dYp92VoQgWbJwQ7Uly27Grox qGtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679960160; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1STa2/pWkCDUQgTVLH0svd7MRisCAzPtmwfg6lpY0tI=; b=vBXedN4blba1ma+ik7krKud8djN+1CcqKGMCC9JaPW3rDkwBsWyoWNjEYJl0HJjSSN shxN/QjMMfQq2SsySdvPAFOp44ejDPLuLtAc2859qJgoN5L8/uUZGUXRiI+9hDI3xizL Pg+q6lxTdmUtGNpn/hPzuDWQZrkTdToNRP2WOPmepZX4QlP3OOrfbpHxZAjCA361LSfQ r7yEQ9uTSx/rgO+qunqKOjA1CnCThL74XQXQszFMMoUZ6qpiGWOJ2Yef5h+V3b9hTaf3 mpjSRkUK+Fz5Xf4lCxYItU9l1ZXm+mXUochkL3egQrqIn/pKLyvAoW83B0bN7GzOczwF 5GiQ== X-Gm-Message-State: AO0yUKUIlhouw9uO36hMF+Q1yavS1ZIUBgtAGILHXM0v0ndHlDsXUX4f qhG8sK4+15f+SIb0EzG18AKS/A== X-Google-Smtp-Source: AK7set8j4D0nhypplSsU3HBthDUICnrtCgmJYFcK94O5rdy1CxC8OtORoO7uyBWCp1vj0T0Q4dZCWA== X-Received: by 2002:a05:6808:659:b0:383:caf3:a30e with SMTP id z25-20020a056808065900b00383caf3a30emr5533117oih.17.1679960159943; Mon, 27 Mar 2023 16:35:59 -0700 (PDT) Received: from ARCHaio.localdomain ([2804:1b3:a2c0:c911:919f:bd20:4f2a:8383]) by smtp.gmail.com with ESMTPSA id b186-20020aca34c3000000b00389295e8424sm1643409oia.45.2023.03.27.16.35.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Mar 2023 16:35:59 -0700 (PDT) From: Caio Novais To: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH 11/12] drm/amd/display: Remove unused variable 'scl_enable' Date: Mon, 27 Mar 2023 20:33:52 -0300 Message-Id: <20230327233353.64081-12-caionovais@usp.br> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230327233353.64081-1-caionovais@usp.br> References: <20230327233353.64081-1-caionovais@usp.br> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Felipe Clark , Wenjing Liu , =?utf-8?q?Ma=C3=ADra_Canal?= , Mario Limonciello , Jun Lei , Charlene Liu , Gabe Teeger , Rodrigo Siqueira , Taimur Hassan , Aurabindo Pillai , Alvin Lee , George Shen , Hamza Mahfooz , Chaitanya Dhere , Alan Liu , Mukul Joshi , =?utf-8?q?Andr=C3=A9_Almeida?= , Jingwen Zhu , Guo Zhengkui , Leo Li , Melissa Wen , Le Ma , Jiapeng Chong , Caio Novais , Martin Leung , Ryan Lin , Brian Chang , Sung Joon Kim , Yifan Zhang , Jack Xiao , Dillon Varone , Tom Chung , Wesley Chalmers , Qingqing Zhuo , "Pan, Xinhui" , Zhan Liu , Roman Li , =?utf-8?q?Christi?= =?utf-8?q?an_K=C3=B6nig?= , Wayne Lin , Alex Deucher , Ethan Wellenreiter , Nicholas Kazlauskas , Joshua Ashton , Hawking Zhang Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Compiling AMD GPU drivers displays a warning: drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn31/display_rq_dlg_calc_31.c: In function ‘dml_rq_dlg_get_dlg_params’: drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn31/display_rq_dlg_calc_31.c:905:14: warning: variable ‘scl_enable’ set but not used [-Wunused-but-set-variable] Get rid of it by removing the variable. Signed-off-by: Caio Novais --- .../gpu/drm/amd/display/dc/dml/dcn31/display_rq_dlg_calc_31.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/dml/dcn31/display_rq_dlg_calc_31.c b/drivers/gpu/drm/amd/display/dc/dml/dcn31/display_rq_dlg_calc_31.c index 35d10b4d018b..2244e4fb8c96 100644 --- a/drivers/gpu/drm/amd/display/dc/dml/dcn31/display_rq_dlg_calc_31.c +++ b/drivers/gpu/drm/amd/display/dc/dml/dcn31/display_rq_dlg_calc_31.c @@ -902,7 +902,6 @@ static void dml_rq_dlg_get_dlg_params( double hratio_c; double vratio_l; double vratio_c; - bool scl_enable; unsigned int swath_width_ub_l; unsigned int dpte_groups_per_row_ub_l; @@ -1020,7 +1019,6 @@ static void dml_rq_dlg_get_dlg_params( hratio_c = scl->hscl_ratio_c; vratio_l = scl->vscl_ratio; vratio_c = scl->vscl_ratio_c; - scl_enable = scl->scl_enable; swath_width_ub_l = rq_dlg_param->rq_l.swath_width_ub; dpte_groups_per_row_ub_l = rq_dlg_param->rq_l.dpte_groups_per_row_ub; From patchwork Mon Mar 27 23:33:53 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Caio Novais X-Patchwork-Id: 13190263 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 76636C761A6 for ; Mon, 27 Mar 2023 23:36:14 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 832A910E7A1; Mon, 27 Mar 2023 23:36:13 +0000 (UTC) Received: from mail-oi1-x229.google.com (mail-oi1-x229.google.com [IPv6:2607:f8b0:4864:20::229]) by gabe.freedesktop.org (Postfix) with ESMTPS id B846110E7A1 for ; Mon, 27 Mar 2023 23:36:10 +0000 (UTC) Received: by mail-oi1-x229.google.com with SMTP id q27so6960013oiw.0 for ; Mon, 27 Mar 2023 16:36:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=usp.br; s=usp-google; t=1679960170; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=DMjKJJljMmxLa3Ljhxg1VmcGN3uGAZRfG7BjQI50ULI=; b=yZcXL9yyvDZKCVJzbqsl/6xiSdbujypjw3qnCm+WCPI+oYss4rXX79NJb6EhbtXhp5 LYJdAEiuKIwajKd2vSdA8Vsn+SLgotaZnv312ScdaCXG6RSNfhjqzidGZ5FaTWmOddcu UqsdHJyw7JByhHBlwA+ANsEOdFyhKPDFuKMOTDQZxeEmDeFBVCSDD74RXqiDfE4TlQV+ sTpfn15kjRl3szo+IakedBOdd3wUF6wP+o07P8dSqHEkdd5/zmw/xhwmhb9f3Jl9QUvJ nKqDWBehFY5QznZ12WccPFZIrMinZI+bzFXpCrPzOj+NO8w+KAs7YglMRg0fwMJgGOPy pFaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679960170; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DMjKJJljMmxLa3Ljhxg1VmcGN3uGAZRfG7BjQI50ULI=; b=5I7ak58a872Ft1PCB/4EscSuIoYHKTlar7qJEyhCa68ZFtFsG4ALjSOJARMwHXTr5c UKRc7PzNXCSez+wTmxTMRPyzSy+8BE0IIafGjBsEoucCXg/nmqGcfw+BRgLS0/jLyvA8 BZKbyxtmM4et2BXcA3iy0Zh/VCU7dBeGfmxnhR1iInwOrMkHRYB672A2C7x8/I61DY5x e80IuwmpLoz41flDz09ASNdRGgS5J9SwPNAPZAwPCPENqFIR1DOtHyHQaeV7GicrHOXi d5ze5ahBo9KfsOKl0ui1Rxq3z2ah9VflylOLnijopeY/ndPunpP4ATlxaTVkhgdh14mi 7PdQ== X-Gm-Message-State: AO0yUKXauauwF6jiSqVYznNZ0q8+cTwTjbMVsx2rcknUO6IvPzb9XWoV 79sp6XDwXkd+02jxBkXVPQvK3A== X-Google-Smtp-Source: AK7set9oAz6sAJk9i+Yr1zEBONLpWWppxu2w98hCDmfDs6XKH+G2nHgnPlqdPGuqAbSZfcMHN2iseA== X-Received: by 2002:a05:6808:7cf:b0:383:f04d:5d41 with SMTP id f15-20020a05680807cf00b00383f04d5d41mr5941639oij.59.1679960170022; Mon, 27 Mar 2023 16:36:10 -0700 (PDT) Received: from ARCHaio.localdomain ([2804:1b3:a2c0:c911:919f:bd20:4f2a:8383]) by smtp.gmail.com with ESMTPSA id b186-20020aca34c3000000b00389295e8424sm1643409oia.45.2023.03.27.16.36.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Mar 2023 16:36:09 -0700 (PDT) From: Caio Novais To: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH 12/12] drm/amd/display: Remove two unused variables 'result_write_min_hblank' and 'hblank_size' Date: Mon, 27 Mar 2023 20:33:53 -0300 Message-Id: <20230327233353.64081-13-caionovais@usp.br> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230327233353.64081-1-caionovais@usp.br> References: <20230327233353.64081-1-caionovais@usp.br> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Felipe Clark , Wenjing Liu , =?utf-8?q?Ma=C3=ADra_Canal?= , Mario Limonciello , Jun Lei , Charlene Liu , Gabe Teeger , Rodrigo Siqueira , Taimur Hassan , Aurabindo Pillai , Alvin Lee , George Shen , Hamza Mahfooz , Chaitanya Dhere , Alan Liu , Mukul Joshi , =?utf-8?q?Andr=C3=A9_Almeida?= , Jingwen Zhu , Guo Zhengkui , Leo Li , Melissa Wen , Le Ma , Jiapeng Chong , Caio Novais , Martin Leung , Ryan Lin , Brian Chang , Sung Joon Kim , Yifan Zhang , Jack Xiao , Dillon Varone , Tom Chung , Wesley Chalmers , Qingqing Zhuo , "Pan, Xinhui" , Zhan Liu , Roman Li , =?utf-8?q?Christi?= =?utf-8?q?an_K=C3=B6nig?= , Wayne Lin , Alex Deucher , Ethan Wellenreiter , Nicholas Kazlauskas , Joshua Ashton , Hawking Zhang Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Compiling AMD GPU drivers displays a warning: drivers/gpu/drm/amd/amdgpu/../display/dc/link/protocols/link_dp_capability.c: In function ‘dpcd_set_source_specific_data’: drivers/gpu/drm/amd/amdgpu/../display/dc/link/protocols/link_dp_capability.c:1290:32: warning: variable ‘result_write_min_hblank’ set but not used [-Wunused-but-set-variable] Get rid of it by removing the variable 'result_write_min_hblank' and 'hblank_size'. Signed-off-by: Caio Novais --- .../drm/amd/display/dc/link/protocols/link_dp_capability.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_capability.c b/drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_capability.c index d4370856f164..7392fcf17653 100644 --- a/drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_capability.c +++ b/drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_capability.c @@ -1287,7 +1287,6 @@ void dc_link_overwrite_extended_receiver_cap( void dpcd_set_source_specific_data(struct dc_link *link) { if (!link->dc->vendor_signature.is_valid) { - enum dc_status result_write_min_hblank = DC_NOT_SUPPORTED; struct dpcd_amd_signature amd_signature = {0}; struct dpcd_amd_device_id amd_device_id = {0}; @@ -1324,16 +1323,10 @@ void dpcd_set_source_specific_data(struct dc_link *link) if (link->ctx->dce_version >= DCN_VERSION_2_0 && link->dc->caps.min_horizontal_blanking_period != 0) { - uint8_t hblank_size = (uint8_t)link->dc->caps.min_horizontal_blanking_period; - - result_write_min_hblank = core_link_write_dpcd(link, - DP_SOURCE_MINIMUM_HBLANK_SUPPORTED, (uint8_t *)(&hblank_size), - sizeof(hblank_size)); } DC_TRACE_LEVEL_MESSAGE(DAL_TRACE_LEVEL_INFORMATION, WPP_BIT_FLAG_DC_DETECTION_DP_CAPS, "result=%u link_index=%u enum dce_version=%d DPCD=0x%04X min_hblank=%u branch_dev_id=0x%x branch_dev_name='%c%c%c%c%c%c'", - result_write_min_hblank, link->link_index, link->ctx->dce_version, DP_SOURCE_MINIMUM_HBLANK_SUPPORTED,