From patchwork Tue Apr 4 01:01:41 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Rix X-Patchwork-Id: 13198953 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 010A8C76196 for ; Tue, 4 Apr 2023 01:02:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232191AbjDDBCc (ORCPT ); Mon, 3 Apr 2023 21:02:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33478 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229451AbjDDBCb (ORCPT ); Mon, 3 Apr 2023 21:02:31 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4994D8F for ; Mon, 3 Apr 2023 18:01:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680570106; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=/kgwTdEq8eWs80cfso32AdLhlnP5Vyd62XPeXkyQic8=; b=Q71GmNd6pmCX48OUdll+OLXcS+Ewn5PXmER/kNrOHrSZy7dsNfc8UWzzTLli0bU5bELu4T 9LM3YLyuPm4iGkMD3p0Gkg5E3xlb0X2OXj5aT+V3c9JyurcD9WX+vehRMMlV7oVnDlbQqE GkehqvEyYCuiGqM5MxlQbbXpMYN11Iw= Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-246-bsx9lP-RP82nVtry9I4YoA-1; Mon, 03 Apr 2023 21:01:45 -0400 X-MC-Unique: bsx9lP-RP82nVtry9I4YoA-1 Received: by mail-qk1-f199.google.com with SMTP id d187-20020a3768c4000000b00746864b272cso13994406qkc.15 for ; Mon, 03 Apr 2023 18:01:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680570105; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=/kgwTdEq8eWs80cfso32AdLhlnP5Vyd62XPeXkyQic8=; b=K4P1m3EJ34TqdShPb1GA+PWHy4e9uBrDbh8yaloFQURRUwKhs69a0SBGJGtwEXtbpq jAE5hqlD2E+UZ72nAtbajZ40kl9IqHzEE8FNNboFsBu39bxItdQfto4lvnWA1QXYLc91 L2q6s487Lls1f9BBmIvhZ9CFRKC2ZGD49X/cTWyVi8ZALNc7X6KLo7QxksUqFwjcIk66 mH8zEvPFNGEYwc/kVYhMdj8BPTfq87ohC9K53+ypWU8TZZculY8KeMHsxUsb3a1ULE7i oiwWvE25NO7uuCc1VU+8unE4ZK9jsHsyRTAgch4NsQLmYHMfO8LvhryAQjW9MBoqrEhw JNpA== X-Gm-Message-State: AAQBX9dwJiz6Wc47UCmuXcNqWEShJagflkwXrQZV0ml/aJHnIIcnlhqy LHDJ4f+zs0FXdGFJgN1avjK396C4SBJ9fxr0JgJQCcnLGYx7GBw2aSSHYuuT79ZWd3MsIbfyNNg 6SnETBa9W8GT0 X-Received: by 2002:a05:622a:100b:b0:3e3:8035:7bf5 with SMTP id d11-20020a05622a100b00b003e380357bf5mr961143qte.20.1680570104821; Mon, 03 Apr 2023 18:01:44 -0700 (PDT) X-Google-Smtp-Source: AKy350bNXHbG+GGFq1pygRDtwRxuoxPCHH2JeIrzvilbJxlSawKX6UyrBx97SzhYID2kaxXtUzkiyg== X-Received: by 2002:a05:622a:100b:b0:3e3:8035:7bf5 with SMTP id d11-20020a05622a100b00b003e380357bf5mr961106qte.20.1680570104565; Mon, 03 Apr 2023 18:01:44 -0700 (PDT) Received: from dell-per740-01.7a2m.lab.eng.bos.redhat.com (nat-pool-bos-t.redhat.com. [66.187.233.206]) by smtp.gmail.com with ESMTPSA id n15-20020ac8674f000000b003d65e257f10sm2886209qtp.79.2023.04.03.18.01.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Apr 2023 18:01:44 -0700 (PDT) From: Tom Rix To: seanjc@google.com, pbonzini@redhat.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com Cc: x86@kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Tom Rix Subject: [PATCH] KVM: x86: set varaiable mitigate_smt_rsb storage-class-specifier to static Date: Mon, 3 Apr 2023 21:01:41 -0400 Message-Id: <20230404010141.1913667-1-trix@redhat.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org smatch reports arch/x86/kvm/x86.c:199:20: warning: symbol 'mitigate_smt_rsb' was not declared. Should it be static? This variable is only used in one file so it should be static. Signed-off-by: Tom Rix --- arch/x86/kvm/x86.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index 8bb8f226f51f..4ce3411d35f3 100644 --- a/arch/x86/kvm/x86.c +++ b/arch/x86/kvm/x86.c @@ -196,7 +196,7 @@ bool __read_mostly eager_page_split = true; module_param(eager_page_split, bool, 0644); /* Enable/disable SMT_RSB bug mitigation */ -bool __read_mostly mitigate_smt_rsb; +static bool __read_mostly mitigate_smt_rsb; module_param(mitigate_smt_rsb, bool, 0444); /*