From patchwork Tue Apr 4 09:19:08 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 13199361 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 44044C6FD1D for ; Tue, 4 Apr 2023 09:19:32 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.517692.803410 (Exim 4.92) (envelope-from ) id 1pjcot-0007QL-0Z; Tue, 04 Apr 2023 09:19:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 517692.803410; Tue, 04 Apr 2023 09:19:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjcos-0007QE-TQ; Tue, 04 Apr 2023 09:19:14 +0000 Received: by outflank-mailman (input) for mailman id 517692; Tue, 04 Apr 2023 09:19:13 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjcor-0007Q6-PJ for xen-devel@lists.xenproject.org; Tue, 04 Apr 2023 09:19:13 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on20629.outbound.protection.outlook.com [2a01:111:f400:fe1a::629]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c35be60a-d2c9-11ed-85db-49a42c6b2330; Tue, 04 Apr 2023 11:19:13 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB9PR04MB9915.eurprd04.prod.outlook.com (2603:10a6:10:4ec::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.30; Tue, 4 Apr 2023 09:19:10 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%6]) with mapi id 15.20.6254.035; Tue, 4 Apr 2023 09:19:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c35be60a-d2c9-11ed-85db-49a42c6b2330 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dXjcnHJV9t+ebL3yCyqlnnc4xs4LSzhBG1Zpqfj77IpBYLumNKSlxc41/z9rBXwttrZZcZ2/ULA3oaBKVTWHh6045oGFdEBxxC5azCYLbC8MIu+Kp1R41cE7cBQi/c+b1N4Lx6WIQV/D+XvvSqiugJP/qUJmsLkhPlOuKlHYzKAed2spZAcok49NpzowxO6NX62Q5d7o+wZFiE6bp5rcRY+xYL7k6KMf9x8Sch+pU4G4smx5DI5aPJDk6ZVjk1X5Pc0e9e+fyZuc7r9Oq+z+t+8Hz0SG3HPECNpmukyeFK3d5pq/ebxIoDnVRu0zdN6d48dCZfj3WMn3muknoYMzKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/7N904AxklSbnMiROFbdWJfhWDMU/a+PNtwY8Ooo9QI=; b=KbUUh1GlFBg2IcBus5lH0FsROpj0cozNVxCc8zXm1upBnO+msKgoiVR1qaf4gvoXE+n5/a7ASNGqWS+SpeuooV0PSJjEWEKAvq04uFXFYXv2wWwc15pV9LfkeJl1WrGXNoKZ6XVZsSJXlbCjoNzgRtPmT2kXNQyalh/nmGqVNokNdBerSpBmlmhtJzpLETCX9rLAvZ9OyI8cPsl5pu84Vzn7t/XyzNA2x453Ava+/H0ZtsNBf1bBl6Mt9OF1ph6nDdzhJu7Cef57c85tTzp6s8z31PurCSLjhjWFIR29kWug6FWQokKj5kwws2LalG+VQQY2aNx5yto9mEjj+S3TZw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/7N904AxklSbnMiROFbdWJfhWDMU/a+PNtwY8Ooo9QI=; b=gq3VuFEVaKpovtmJTLz+v4FBDbEcZHYDVK1kj/ChC8bBeNwf0o8h98rZCU68lIVD7kj1la8WN1tUpb/ZrnNtNGnIPR0BMew7JnTfhjNy5itjBMtqfOv+LPVd1D8OlO2ejqQ2niQ6/24/bSyrNkM68Zd4JqVn0hntr4jd8wFwASn6jtW/gUxFa3wTX7lFp/E4+LTuNFBKz+NU7LMZF1gtgaJfpzxZ9vQFEci5V/iQx8FULPpyQPb/8jwgYlJf6ERk3raYERTuPgs8cRSS4QzpCKZR6ZJ+5v/frcApd64MD8xmBKpEztGTsPEOuzUIQsNrWZQKJ62ENGRLLt1E2UnWwA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 4 Apr 2023 11:19:08 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 From: Jan Beulich Subject: [PATCH v2] x86/PV: ignore PAE_MODE ELF note for 64-bit Dom0 To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?utf-8?q?Roger_Pau_Monn=C3=A9?= Content-Language: en-US X-ClientProxiedBy: FR2P281CA0102.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9c::16) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB9PR04MB9915:EE_ X-MS-Office365-Filtering-Correlation-Id: 377ba6c8-602c-49ac-00ba-08db34eda5c3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: JCDSsrggbx3+5PNTDltoIx1wBJfxgNSyv5T55+HkKh4uSkIH/jLUmpV4W3wRpjsUG4CCq/gtamMiVJFouVUnE8FUV6JKeqCSxQs00jlJtzor00P7WZv2eejb4hsubN5Heo/NRo009VmiYgcD9YBU1UbvE34+MRn3M3gHQKLoQl+FVuacrhhLzhrfL4u2uatAXEbWmBDDZRdcrT6QnuFx/9qpTbsrBjDBMu64cBEPnXFwevF04El8kV++9ZgqWdWN0oUJteNzlWhF9KlHIUPz7E1q9rr88Fch0CP8uhmdmK4uukW0fGtY3a41Fwfk4H+whOuVV5ZkXSQi2i7D/4AQb4JJPZ4bG2feibwPwS3WBv+qhgCzmwLdH3TiQhXkP7hCLuL8NeP1qKnSS7x+Vexi7MW6JQM9cbs7hSWE2IIni6Zd8jCbCnTO/rhg6HlK3UI6DZHsttO9JRe888Icp3sXBT0+odL5WN8nj+5dPW+1hlOHUPAUgCA12GfMnXtHOK1JTzUdRzWx6HSZOubAz4QD0xEuya8GIpr5MJONSNTpmNPG3izV2XgTvei87ZFe9c5T39rYWtQDB1b3zphNWdy+xi70CVLN2a02buLvjbZRbIToCeh584t3EDQshfqnozbjbr+s9qdWESNM2gOnBAL7CQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39860400002)(396003)(136003)(346002)(366004)(376002)(451199021)(38100700002)(8676002)(66476007)(66556008)(66946007)(5660300002)(8936002)(41300700001)(316002)(31686004)(6916009)(4326008)(478600001)(2906002)(31696002)(54906003)(83380400001)(86362001)(186003)(36756003)(2616005)(6486002)(6512007)(26005)(6506007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?+qdjO5W4bbKqALu/7Txs6KFxiear?= =?utf-8?q?aoPdY60FX5sQ9i5P12HuKquFSooBwv+lFOj/2f6OeULBPxPBztu3rgQUvHfSdDNpr?= =?utf-8?q?qrFqStf2C5w1RdPfX9UtfF32g7B0CA2RhOIqmWsWtCzsTB/rAQMdkgFxBmeZ5pBgt?= =?utf-8?q?XK4eRAEmtU04nCclpFmDIOTFO5xcYZTyO6AE4TpPdnxZTfGLtLHZ6DhCbVsUKUSOa?= =?utf-8?q?peQJEQ9CekjyLOo5pt5ziyXU36HTVzrFv4UpjU7hkYyZQcal3Y29WraD91lX7eWg6?= =?utf-8?q?JEPbeh9SFpoBSb/pcTU8wnt3/2Dim3ijZYSFpiRfaQDB/b1Li0A6BoNBKyyKCalMy?= =?utf-8?q?4I80oU4HX21W5Q7iNowMNex6PMG01zFtJNdHDip/xf7gudK9E4TQAS/Y4n+yoD3Gr?= =?utf-8?q?oLBBWPjrR64GoP/57TS4uHCorb19qLUIhArMJNpWi8RgdTG5mZfI6LV9xJMcs/xZV?= =?utf-8?q?KwTIBh6og+ddP38X4X9hWGHTYaEpp2FeufT/Afpgr17nvmNiRnRJ9iFxTKVR3u2xh?= =?utf-8?q?zTkCH6EgbweOLwwzPtaYc3f8/K8YboWzZ7XidmgV4qIZrhrgswSYbnt8sndRugYrD?= =?utf-8?q?3N/W75LOKZKmjkLSXt+kiizSrw89KBhpZziIytoN+0Z2Z9TBd1ZICBTXogOLYapzT?= =?utf-8?q?+ScyabIM5S/ydPhP63dGhNxGDxLZzocXNxEVP+lK9jXrtMj02H/x1jFTX8O3fpxb7?= =?utf-8?q?Fxvh+0syR1tbZUZKi7zIEXJudOqjAxuzrADKeKhOQJwl9S5xfrSdzG9nvLh69hEre?= =?utf-8?q?ty+EBppAtgdfl5qjNMKLl1mDXri8/r7egk6l3it+CgXE0siDiA1UMEBwk0/AkttfB?= =?utf-8?q?6KQz7pshrZjv4iJPV2lBcPscXdgSId+8Nnm5L8xpQaO1E24/vaL1r5frw0mOC1ySn?= =?utf-8?q?/X+7Y4c2HwWN+nPSXFwUkt0RAH+IGueP/H05Xi0F62GSGa1vV370iviboQF8IxlrG?= =?utf-8?q?9lco+FyNaRD9UQyWdjoUqzs5edh45pFIMnTPYDIIYLjEpSwAkspfE9CfxM3bMUujC?= =?utf-8?q?I6+appGppKqK9wujh3McCH1oYflq2SGxBdDZyeGH4FuDk0aoYySLq1q30sH/4BxSL?= =?utf-8?q?PB6upSpn19Wtur6ou03N3VfuDDV9zHcajK5sBsGCrY/tnirbPyu4IVnvAKOE4EBeS?= =?utf-8?q?rwpSdNU/szsoosK4BDoIhijaTqWYyq9LkOQdNZz5buufFylpeAbYNNMTMkmJhqGWy?= =?utf-8?q?PJCYPA3JThwA2RopNpZWnqXBxx/ipE5fzOI9N9FNEBZfLiZb+qTwEJi0tjZqxNjub?= =?utf-8?q?V73rXXFxeqnDc/H6nbZV+IfGvh5p1uzBW4uM7Yh5n4G+iOe47/YXPuxwFhnWBP8B7?= =?utf-8?q?spWAip+/4TQLq5cfZu5iam/Fcc95dtbCOxz/JyVboeRtYf9R8qMP6IcuC/oNVqord?= =?utf-8?q?xiOJqCYCWfyyF7t1s2ybcyGMLlW5XOf3mUfkVkWIVI2+tqAf+5MW59uJSgNSIN+Nj?= =?utf-8?q?vh2o3cWntTLgr3TWecivxaoC+Bk7sOOBxlFipVziOs8mWTJiI+SrmgCEK8xZxF0gn?= =?utf-8?q?F6Xz8srBHW6q?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 377ba6c8-602c-49ac-00ba-08db34eda5c3 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2023 09:19:09.8621 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: tEidxJEAFU9n8QurnQZpXBuQbrcU2rn6fKoGU2O42ACtUe0gZQRAwZuT+ZL9nSydLI4ZYFhiEXhdCmuxs6cAxg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB9915 Besides a printk() the main effect is slight corruption of the start info magic: While that's meant to be xen-3.0-x86_64, it wrongly ended up as xen-3.0-x86_64p. Note that no known users exist that would have developed a dependency on the bogus magic string. In particular Linux, NetBSD, and mini-os have been checked. Fixes: 460060f83d41 ("libelf: use for x86 dom0 builder") Signed-off-by: Jan Beulich Acked-by: Roger Pau Monné Acked-by: Andrew Cooper --- RFC: While Linux works fine with the adjustment, I'm not entirely certain of external tools (crash?) having grown a dependency. It may be worth noting that XenoLinux and its forward ports never had this ELF note in 64-bit kernels, so in principle it may be reasonable to expect that no such dependency exists anywhere. Prior to "x86/PV32: restore PAE-extended-CR3 logic" that (meaningless for 64-bit domains) VM-assist could also be engaged, based on the ELF note's value. I expect that change to go in first, at which point the description here is going to be correct (in not mentioning this VM- assist aspect). --- v2: Extend description. --- a/xen/arch/x86/pv/dom0_build.c +++ b/xen/arch/x86/pv/dom0_build.c @@ -459,8 +459,13 @@ int __init dom0_construct_pv(struct doma compat = is_pv_32bit_domain(d); if ( elf_64bit(&elf) && machine == EM_X86_64 ) + { compatible = true; + /* Zap meaningless setting which kernels may carry by mistake. */ + parms.pae = 0; + } + if ( elf_msb(&elf) ) compatible = false;