From patchwork Tue Apr 4 11:59:00 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Geert Uytterhoeven X-Patchwork-Id: 13199710 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 051E3C761A6 for ; Tue, 4 Apr 2023 11:59:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234512AbjDDL7O (ORCPT ); Tue, 4 Apr 2023 07:59:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39724 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234503AbjDDL7M (ORCPT ); Tue, 4 Apr 2023 07:59:12 -0400 Received: from xavier.telenet-ops.be (xavier.telenet-ops.be [IPv6:2a02:1800:120:4::f00:14]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9F74F35B3 for ; Tue, 4 Apr 2023 04:59:10 -0700 (PDT) Received: from ramsan.of.borg ([84.195.187.55]) by xavier.telenet-ops.be with bizsmtp id gbz42900P1C8whw01bz4yR; Tue, 04 Apr 2023 13:59:08 +0200 Received: from rox.of.borg ([192.168.97.57]) by ramsan.of.borg with esmtp (Exim 4.95) (envelope-from ) id 1pjfIm-00FxwM-QC; Tue, 04 Apr 2023 13:59:04 +0200 Received: from geert by rox.of.borg with local (Exim 4.95) (envelope-from ) id 1pjfJY-000xCe-KW; Tue, 04 Apr 2023 13:59:04 +0200 From: Geert Uytterhoeven To: Dario Binacchi , Vincent Mailhol , Wolfgang Grandegger , Marc Kleine-Budde Cc: linux-can@vger.kernel.org, netdev@vger.kernel.org, Geert Uytterhoeven Subject: [PATCH] can: CAN_BXCAN should depend on ARCH_STM32 Date: Tue, 4 Apr 2023 13:59:00 +0200 Message-Id: <40095112efd1b2214e4223109fd9f0c6d0158a2d.1680609318.git.geert+renesas@glider.be> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org The STMicroelectronics STM32 basic extended CAN Controller (bxCAN) is only present on STM32 SoCs. Hence drop the "|| OF" part from its dependency rule, to prevent asking the user about this driver when configuring a kernel without STM32 SoC support. Fixes: f00647d8127be4d3 ("can: bxcan: add support for ST bxCAN controller") Signed-off-by: Geert Uytterhoeven Reviewed-by: Simon Horman --- Until v3[1], BXCAN depended on "(ARCH_STM32 || COMPILE_TEST) && OF". v4[2] changed this from "&& OF" to "|| OF", for no apparent reason, and without mentioning this in the changelog. [1] https://lore.kernel.org/all/20220828133329.793324-5-dario.binacchi@amarulasolutions.com [2] https://lore.kernel.org/all/20220925175209.1528960-6-dario.binacchi@amarulasolutions.com --- drivers/net/can/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/can/Kconfig b/drivers/net/can/Kconfig index 3ceccafd701b2a31..b190007c01bec5f4 100644 --- a/drivers/net/can/Kconfig +++ b/drivers/net/can/Kconfig @@ -95,7 +95,7 @@ config CAN_AT91 config CAN_BXCAN tristate "STM32 Basic Extended CAN (bxCAN) devices" - depends on OF || ARCH_STM32 || COMPILE_TEST + depends on ARCH_STM32 || COMPILE_TEST depends on HAS_IOMEM select CAN_RX_OFFLOAD help