From patchwork Tue Apr 4 15:28:07 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chao Yu X-Patchwork-Id: 13200475 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9F16FC6FD1D for ; Tue, 4 Apr 2023 15:28:31 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1pjiaE-0004lz-0B; Tue, 04 Apr 2023 15:28:30 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pjiaC-0004ls-Sy for linux-f2fs-devel@lists.sourceforge.net; Tue, 04 Apr 2023 15:28:29 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:Message-Id: Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=KnP3f2zy8ZWGbJP/zUtUn0pDZ9v1KBSCrSRFLAWSSpE=; b=m0OiW4YI2oV5nOJUv5arAM4bB0 if1y2M1yzX6Rq8UdbSyBGSJKH+zt3FyhPAcJtRNZZDOHFeUA0MhbmRKp7Ppjog7p8wk9S1k6JIpuo z7E3zxxkp/TYVwPP3H+/riOzFNBh6VuZCkMHx/H8f1tWla1YfSuSjJk01AQ3R+0MI9dE=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date:Subject:Cc:To:From :Sender:Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post: List-Owner:List-Archive; bh=KnP3f2zy8ZWGbJP/zUtUn0pDZ9v1KBSCrSRFLAWSSpE=; b=G 5ebkEbfTGxxJSThzyWUvDP9mikOObf2/lvFWwPTacyYXaj2l4QHJgSzmN6XklwBIawKGEn3FGvt9t ipPq6xvC3GS7SJiXdN+Y8YdvX6NmB5GhmMNVKEluKsBtXZirmY1qfsKhJFzvcWQ+ajWtm3tyivGIi 0jmBIBuZn9QGi0ak=; Received: from dfw.source.kernel.org ([139.178.84.217]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1pjia7-00F1We-U9 for linux-f2fs-devel@lists.sourceforge.net; Tue, 04 Apr 2023 15:28:29 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 89D65635F9 for ; Tue, 4 Apr 2023 15:28:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 31949C433D2; Tue, 4 Apr 2023 15:28:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680622098; bh=Q9R/0spYK1JLY5KmDAtd1V4FUjv3MQUTeOhn9KqE2eQ=; h=From:To:Cc:Subject:Date:From; b=Hy0iHLZYL/ciUUtKwh3G/xrFsOkIo3kS/TW2h3qr3W/E584v9VOPFckjvxO8A0U9i 2zvFkaBpxbRPL7lBNJTHoZYdr8XT3MQM08MgcujaE5m8o7nc6Jx5CltK5362P7tklU 8FesFNJ6gFb8xWP67kUf2KA1RF1Zn/acIsH7Iw6wR44KkUcgq2XftXyGs3R1ezQnO+ qz1USJUspK+Z3GMCmqFNACTZ8ztYZLuhLs6sAs+zrw2GnNZUoMz03S28Ge0zV8QxXh p5wRQjDQnzslsTj+CFRA/vQLJXEit4qrtlCtgxOaN7wonpGNR8ukcqpYYlvBETX9a4 8b6DS3nl6n0KQ== From: Chao Yu To: jaegeuk@kernel.org Date: Tue, 4 Apr 2023 23:28:07 +0800 Message-Id: <20230404152807.4987-1-chao@kernel.org> X-Mailer: git-send-email 2.36.1 MIME-Version: 1.0 X-Headers-End: 1pjia7-00F1We-U9 Subject: [f2fs-dev] [PATCH v2] f2fs: fix to check readonly condition correctly X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net With below case, it can mount multi-device image w/ rw option, however one of secondary device is set as ro, later update will cause panic, so let's introduce f2fs_dev_is_readonly(), and check multi-devices rw status in f2fs_remount() w/ it in order to avoid such inconsistent mount status. mkfs.f2fs -c /dev/zram1 /dev/zram0 -f blockdev --setro /dev/zram1 mount -t f2fs dev/zram0 /mnt/f2fs mount: /mnt/f2fs: WARNING: source write-protected, mounted read-only. mount -t f2fs -o remount,rw mnt/f2fs dd if=/dev/zero of=/mnt/f2fs/file bs=1M count=8192 kernel BUG at fs/f2fs/inline.c:258! RIP: 0010:f2fs_write_inline_data+0x23e/0x2d0 [f2fs] Call Trace: f2fs_write_single_data_page+0x26b/0x9f0 [f2fs] f2fs_write_cache_pages+0x389/0xa60 [f2fs] __f2fs_write_data_pages+0x26b/0x2d0 [f2fs] f2fs_write_data_pages+0x2e/0x40 [f2fs] do_writepages+0xd3/0x1b0 __writeback_single_inode+0x5b/0x420 writeback_sb_inodes+0x236/0x5a0 __writeback_inodes_wb+0x56/0xf0 wb_writeback+0x2a3/0x490 wb_do_writeback+0x2b2/0x330 wb_workfn+0x6a/0x260 process_one_work+0x270/0x5e0 worker_thread+0x52/0x3e0 kthread+0xf4/0x120 ret_from_fork+0x29/0x50 Signed-off-by: Chao Yu --- v2: - update commit message to describe details of the issue. - fix to do the check in f2fs_remount(). fs/f2fs/f2fs.h | 5 +++++ fs/f2fs/super.c | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h index 2d4a7ef62537..52f3badced21 100644 --- a/fs/f2fs/f2fs.h +++ b/fs/f2fs/f2fs.h @@ -4446,6 +4446,11 @@ static inline bool f2fs_hw_is_readonly(struct f2fs_sb_info *sbi) return false; } +static inline bool f2fs_dev_is_readonly(struct f2fs_sb_info *sbi) +{ + return f2fs_sb_has_readonly(sbi) || f2fs_hw_is_readonly(sbi); +} + static inline bool f2fs_lfs_mode(struct f2fs_sb_info *sbi) { return F2FS_OPTION(sbi).fs_mode == FS_MODE_LFS; diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c index d016f398fcad..75597a107157 100644 --- a/fs/f2fs/super.c +++ b/fs/f2fs/super.c @@ -2321,7 +2321,7 @@ static int f2fs_remount(struct super_block *sb, int *flags, char *data) if (f2fs_readonly(sb) && (*flags & SB_RDONLY)) goto skip; - if (f2fs_sb_has_readonly(sbi) && !(*flags & SB_RDONLY)) { + if (f2fs_dev_is_readonly(sbi) && !(*flags & SB_RDONLY)) { err = -EROFS; goto restore_opts; }