From patchwork Wed Apr 5 16:10:42 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sebastian Reichel X-Patchwork-Id: 13202165 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACC85C76188 for ; Wed, 5 Apr 2023 16:10:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231796AbjDEQK4 (ORCPT ); Wed, 5 Apr 2023 12:10:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35520 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231838AbjDEQKy (ORCPT ); Wed, 5 Apr 2023 12:10:54 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B60296591; Wed, 5 Apr 2023 09:10:49 -0700 (PDT) Received: from jupiter.universe (dyndsl-091-248-212-122.ewe-ip-backbone.de [91.248.212.122]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: sre) by madras.collabora.co.uk (Postfix) with ESMTPSA id A49476603050; Wed, 5 Apr 2023 17:10:47 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1680711047; bh=pH06ncEy562f9n+iewFlXxRQME64qy/bVTx4Y1ixGtE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=oneGGk8xcXoWVLep21/VHMQDqfYRYGypWEaXiJ8yrXYtKvUyDVRIs9REsqODis+1u wIYTNgUkdcPdmZslNXJoYJp7QTbGV7PoocqHln78WXY1Nm2SnLZKvMQtYVEFw4YOuu bwMXAeUd3okPgddbDUICzlEUHw2qfMk+VDJtS92ZnQ8XEJB+sUw4qrc00PJRzLNa1A 9ImviMLKuHZ6XePKiSdoNlVanj1CgHxoWNS1LtQoUJfnkP0gm4xGFPDDAU6S99x523 AZ2QIMg3SxTC5zfX/T4a9yFYZBYAQH6EnwqVt4gKBGRw+w3PXyiVrKQfIJuABZofl3 STrlVcQ9UnxIw== Received: by jupiter.universe (Postfix, from userid 1000) id 424484807E0; Wed, 5 Apr 2023 18:10:45 +0200 (CEST) From: Sebastian Reichel To: Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Sebastian Reichel , kernel@collabora.com Subject: [PATCHv2 1/2] net: ethernet: stmmac: dwmac-rk: rework optional clock handling Date: Wed, 5 Apr 2023 18:10:42 +0200 Message-Id: <20230405161043.46190-2-sebastian.reichel@collabora.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230405161043.46190-1-sebastian.reichel@collabora.com> References: <20230405161043.46190-1-sebastian.reichel@collabora.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org The clock requesting code is quite repetitive. Fix this by requesting the clocks in a loop. Also use devm_clk_get_optional instead of devm_clk_get, since the old code effectively handles them as optional clocks. This removes error messages about missing clocks for platforms not using them and correct -EPROBE_DEFER handling. The new code also tries to get "clk_mac_ref" and "clk_mac_refout" when the PHY is not configured as PHY_INTERFACE_MODE_RMII to keep the code simple. This is possible since we use devm_clk_get_optional() for the clock lookup anyways. Suggested-by: Jakub Kicinski Fixes: 7ad269ea1a2b7 ("GMAC: add driver for Rockchip RK3288 SoCs integrated GMAC") Signed-off-by: Sebastian Reichel Reviewed-by: Simon Horman --- .../net/ethernet/stmicro/stmmac/dwmac-rk.c | 63 ++++++------------- 1 file changed, 20 insertions(+), 43 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c index 4b8fd11563e4..6fdad0f10d6f 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c @@ -1475,54 +1475,31 @@ static int rk_gmac_clk_init(struct plat_stmmacenet_data *plat) { struct rk_priv_data *bsp_priv = plat->bsp_priv; struct device *dev = &bsp_priv->pdev->dev; - int ret; + int i, ret; + struct { + struct clk **ptr; + const char *name; + } clocks[] = { + { &bsp_priv->mac_clk_rx, "mac_clk_rx" }, + { &bsp_priv->mac_clk_tx, "mac_clk_tx" }, + { &bsp_priv->aclk_mac, "aclk_mac" }, + { &bsp_priv->pclk_mac, "pclk_mac" }, + { &bsp_priv->clk_mac, "stmmaceth" }, + { &bsp_priv->clk_mac_ref, "clk_mac_ref" }, + { &bsp_priv->clk_mac_refout, "clk_mac_refout" }, + { &bsp_priv->clk_mac_speed, "clk_mac_speed" }, + }; bsp_priv->clk_enabled = false; - bsp_priv->mac_clk_rx = devm_clk_get(dev, "mac_clk_rx"); - if (IS_ERR(bsp_priv->mac_clk_rx)) - dev_err(dev, "cannot get clock %s\n", - "mac_clk_rx"); - - bsp_priv->mac_clk_tx = devm_clk_get(dev, "mac_clk_tx"); - if (IS_ERR(bsp_priv->mac_clk_tx)) - dev_err(dev, "cannot get clock %s\n", - "mac_clk_tx"); - - bsp_priv->aclk_mac = devm_clk_get(dev, "aclk_mac"); - if (IS_ERR(bsp_priv->aclk_mac)) - dev_err(dev, "cannot get clock %s\n", - "aclk_mac"); - - bsp_priv->pclk_mac = devm_clk_get(dev, "pclk_mac"); - if (IS_ERR(bsp_priv->pclk_mac)) - dev_err(dev, "cannot get clock %s\n", - "pclk_mac"); - - bsp_priv->clk_mac = devm_clk_get(dev, "stmmaceth"); - if (IS_ERR(bsp_priv->clk_mac)) - dev_err(dev, "cannot get clock %s\n", - "stmmaceth"); - - if (bsp_priv->phy_iface == PHY_INTERFACE_MODE_RMII) { - bsp_priv->clk_mac_ref = devm_clk_get(dev, "clk_mac_ref"); - if (IS_ERR(bsp_priv->clk_mac_ref)) - dev_err(dev, "cannot get clock %s\n", - "clk_mac_ref"); - - if (!bsp_priv->clock_input) { - bsp_priv->clk_mac_refout = - devm_clk_get(dev, "clk_mac_refout"); - if (IS_ERR(bsp_priv->clk_mac_refout)) - dev_err(dev, "cannot get clock %s\n", - "clk_mac_refout"); - } + for (i=0; i < ARRAY_SIZE(clocks); i++) { + *clocks[i].ptr = devm_clk_get_optional(dev, clocks[i].name); + if (IS_ERR(*clocks[i].ptr)) + return dev_err_probe(dev, PTR_ERR(*clocks[i].ptr), + "cannot get clock %s\n", + clocks[i].name); } - bsp_priv->clk_mac_speed = devm_clk_get(dev, "clk_mac_speed"); - if (IS_ERR(bsp_priv->clk_mac_speed)) - dev_err(dev, "cannot get clock %s\n", "clk_mac_speed"); - if (bsp_priv->clock_input) { dev_info(dev, "clock input from PHY\n"); } else { From patchwork Wed Apr 5 16:10:43 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sebastian Reichel X-Patchwork-Id: 13202166 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 082DFC7619A for ; Wed, 5 Apr 2023 16:10:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232235AbjDEQK5 (ORCPT ); Wed, 5 Apr 2023 12:10:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35398 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231664AbjDEQKy (ORCPT ); Wed, 5 Apr 2023 12:10:54 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B6098659C; Wed, 5 Apr 2023 09:10:49 -0700 (PDT) Received: from jupiter.universe (dyndsl-091-248-212-122.ewe-ip-backbone.de [91.248.212.122]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: sre) by madras.collabora.co.uk (Postfix) with ESMTPSA id C41F56603101; Wed, 5 Apr 2023 17:10:47 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1680711047; bh=O0OERdh8YQllL/WUi4nWvlzY8+V5Fv1hvisy2ugrnhI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=WbxXH31kvJ+rymvSpUIGGj1exJoQutsqaeLZcu701DEv+NQ7wP4UW7nVEyD04xuFp NkypRVHronXrDyCFhgdNiXm90w7sdnmP01aDBPD4iRtRPG9ZvfM8w6SNzcwyv93Oxc 3rbxyPq2DJz9qIDdV5sx4fanYq5qk9mUw2nlZOjoGSlaI+gGUF9kniOpQPLnTfJY4h Ze/4h+X8VQR0EpEugKxeUzD7F7+2NTVRFUELRksEIvcrB6dYM90r4D2A4lbK3Tj6Tj MaG1hwYcQ6q+dDf2TGsN0eLMEfZB34PlL4Brk6VMlUYWhGmoLqsXdKt68lNLWORwPg gvBQ8c+gnGdeg== Received: by jupiter.universe (Postfix, from userid 1000) id 4482B4807E3; Wed, 5 Apr 2023 18:10:45 +0200 (CEST) From: Sebastian Reichel To: Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Sebastian Reichel , kernel@collabora.com Subject: [PATCHv2 2/2] net: ethernet: stmmac: dwmac-rk: fix optional phy regulator handling Date: Wed, 5 Apr 2023 18:10:43 +0200 Message-Id: <20230405161043.46190-3-sebastian.reichel@collabora.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230405161043.46190-1-sebastian.reichel@collabora.com> References: <20230405161043.46190-1-sebastian.reichel@collabora.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org The usual devm_regulator_get() call already handles "optional" regulators by returning a valid dummy and printing a warning that the dummy regulator should be described properly. This code open coded the same behaviour, but masked any errors that are not -EPROBE_DEFER and is quite noisy. This change effectively unmasks and propagates regulators errors not involving -ENODEV, downgrades the error print to warning level if no regulator is specified and captures the probe defer message for /sys/kernel/debug/devices_deferred. Fixes: 2e12f536635f8 ("net: stmmac: dwmac-rk: Use standard devicetree property for phy regulator") Signed-off-by: Sebastian Reichel --- drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c index 6fdad0f10d6f..d9deba110d4b 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c @@ -1656,14 +1656,11 @@ static struct rk_priv_data *rk_gmac_setup(struct platform_device *pdev, } } - bsp_priv->regulator = devm_regulator_get_optional(dev, "phy"); + bsp_priv->regulator = devm_regulator_get(dev, "phy"); if (IS_ERR(bsp_priv->regulator)) { - if (PTR_ERR(bsp_priv->regulator) == -EPROBE_DEFER) { - dev_err(dev, "phy regulator is not available yet, deferred probing\n"); - return ERR_PTR(-EPROBE_DEFER); - } - dev_err(dev, "no regulator found\n"); - bsp_priv->regulator = NULL; + ret = PTR_ERR(bsp_priv->regulator); + dev_err_probe(dev, ret, "failed to get phy regulator\n"); + return ERR_PTR(ret); } ret = of_property_read_string(dev->of_node, "clock_in_out", &strings);