From patchwork Sat Apr 15 00:37:52 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SeongJae Park X-Patchwork-Id: 13212230 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 146E4C77B71 for ; Sat, 15 Apr 2023 00:38:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9D6FF90000B; Fri, 14 Apr 2023 20:38:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 95F39900002; Fri, 14 Apr 2023 20:38:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8008590000B; Fri, 14 Apr 2023 20:38:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 721D1900002 for ; Fri, 14 Apr 2023 20:38:09 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 43B2D1C6202 for ; Sat, 15 Apr 2023 00:38:09 +0000 (UTC) X-FDA: 80681763498.28.0E36506 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf09.hostedemail.com (Postfix) with ESMTP id 9AC4E140015 for ; Sat, 15 Apr 2023 00:38:07 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="NBcuk7R/"; spf=pass (imf09.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681519087; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MhTz6d6oVgpFx/Sb9wUAPGcWrqLArJdIllPwx5eQr0g=; b=bUcqzwEWnRyFVxI4QzuNUFUu2qoXJudFyefveu1//+TMl+QtuPM5xF35ZDoLbPQvGc+giT j2bzcK3hz7flH+pvRezmB3tgu5k1q9AeGGAJeb09QxshEvRSLEJjE6cd2Ea4AB7s0Lrr2/ EZ1E366A+gGfcZJZc19OgOxg1DeI3E8= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="NBcuk7R/"; spf=pass (imf09.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681519087; a=rsa-sha256; cv=none; b=msQuQ/A4ngaFYES+NqhaimA6bvGCd6W+kRJ47togF46sUUgS9EpFwELMVWhhJXr7OGq3Pl RULXU+XWbEgZg2VF8o8Sxo0jiGE7E95IoxEusK7zAgBYoylmBSkXmSa8c37JayIafTgciN F0547cfa7VAUmXwQ4G3a0Du+1evmU/E= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D00F364AD8; Sat, 15 Apr 2023 00:38:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E298CC433D2; Sat, 15 Apr 2023 00:38:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681519086; bh=Es+n5/VxwrYKRoTO9yEi5YcqrEo9wXUokpGjthhzOWE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=NBcuk7R/SX1FJHH9tUOzXxSzgOXFK5Jqi5KCLIAbzLZtDX8DdLN45vwOdbrn1N1Bd ISFzPFRifzqI3bAVZzGdl/W1i5fyj7JBkfcRYA6n5DohQ6mh2Ix3ROfzk831+gA0ZR bRSv3oYmsL6/IWhXgz1fKZVmbVInyF7xieLyHmQjX6oC0Xc2afdRsl6x1z+/LDnExG 1+CQygGAwJFtemC6iFzc9RhEWz1lNHq3Mc/sKmuLymiUmppai4Mh+/fRUNHarwkHb8 uLzBIfFqYcUXuzqJd9X5Z31m+r0KoTaLCL7r9iW38GqiwmhGGHihJmJ3FINdoI30vC bPR3UO5U7u5CA== From: SeongJae Park To: akpm@linux-foundation.org Cc: vbabka@suse.cz, linux-mm@kvack.org, linux-kernel@vger.kernel.org, SeongJae Park Subject: [PATCH 1/2] mm/slab: add a missing semicolon on SLAB_TYPESAFE_BY_RCU example code Date: Sat, 15 Apr 2023 00:37:52 +0000 Message-Id: <20230415003754.1852-2-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230415003754.1852-1-sj@kernel.org> References: <20230415003754.1852-1-sj@kernel.org> MIME-Version: 1.0 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 9AC4E140015 X-Rspam-User: X-Stat-Signature: rooyi7jos1arh7q57e5mqy4zi45fwo8d X-HE-Tag: 1681519087-338747 X-HE-Meta: U2FsdGVkX197L0dSdPIfhXiGZbEH5sCZaYuYjVOGEp/gaxtKYucorTOD9ysAadyYGp4Hg+9WGXUUzGT/6b1DEAdKB5lEHgsXXackFMtV4b9LlSCP/iX3bHEE0fmtu0VSZSUevpkcq7XkvApnmQdFcS5FghIu4SeqUiWhsOBWyiEISEMnUCzmNxdTPKYQP/ZUKZmkPu1UOMLU6eUNRo5iQWLwZ9pPGz0jDUasuNDSe9NdkIX00V0FIz/0T7bvgIEVKkuQUSX41wdPyvfViPYHgSy5lEFLd/xeVz23Fnz9iMC++d+sl7zD8Xz1MrkMVyYkjXaZ2RYBiW0MQU9xDLB4Pf6OPgdbhwojY1aA76kIrA1bzEZIPMjCDml34hwQ3K0+qJnfnHN7vv3NQS42FLS27AUc04FGbJKTZnjnU+SwEPKdnJgzDYPcVkiRDEjeoS+Le22/JWQ3rJ5bnrRHsYcc0b4jwXv7P43qsldZUDwoqnBgeRTZhYtgDc2mubHfXHemhx6PWQ9kb0LalO6rvZ8nt8/IZwTLKU8PXXXZhYx4ZlBH2mvg/2GVv4/pmS2c55+vBeAIlmTo7fSQtsJ+2Gz9rWT2iv85g8qBYY3HXSdDwD3Y8ZA/JRTS0IJ8hgnXaWR8Yr3UevAEWqjmGzh2OgZHEjgIj+zldgX+wB0sGxT4Ifk42PdMOBeLTCztnU1Ja8hhDT336XVsrlnxWgR7wcCOw3EmlwpM+/NSEr/Y6hspzCJ5sN28tQq5DsYA4FFI0G3+oXMwo+nvnCfGeaaUf5NZBCZmbAfmrHMKj5NBCNfzOkuXLC+iJU5fwIANXaBagK7f9xR+u4gosux+ZGfFNa6lE5DRNIwMyX0VMvnxhogZEt8RKydGk5LXne8nkkYvE0rCD9ikwmmnT5nakYfrpaB1PwpTizROTmV5uyvWIKaOU4FU61wImc8nSfOr+FsB0KJBjie+DMsEuCTjm+yKEAS EjdgfBon dFXIq1xMCua1qbKoqjbeyG7FpP778Nec/O1hyvKBgv+1j11Yv+zKmv9VpQTBGdtb7+aMvWlPRax20+GhyDMrn03R522/kL9RczqlnqGXFMLDkjQhhenandtBgIhtoQeDNNiqCm9mM9nuqyJYmkaBPUCFIohFSE+WBWvyJkJWR0u5vfu0cq5ezUEtK3PnXVA/1AIDpdNXHgVT9ZM9bnyGoAEeDfdftfQ2DQMkyyRFw9eeD67YH7q9dyU9FjE/eiXiSOm+MKiVqINc2vU5q+ZYo+ZC64gm91JQjvTm7+s4Rhj746PwWuO8LK6DmqGZotdR0Sa9aW6bNHSjQV2jmLwBeBj3/2tjpPRAbOXY9vJy0J5nW3Th70ta4l+7uZmEe7CmefTT8ggaPuQmLduXdGwi3lKwAow== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: An example code snippet for SLAB_TYPESAFE_BY_RCU is missing a semicolon. Add it. Signed-off-by: SeongJae Park --- include/linux/slab.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/slab.h b/include/linux/slab.h index f8b1d63c63a3..b18e56c6f06c 100644 --- a/include/linux/slab.h +++ b/include/linux/slab.h @@ -53,7 +53,7 @@ * stays valid, the trick to using this is relying on an independent * object validation pass. Something like: * - * rcu_read_lock() + * rcu_read_lock(); * again: * obj = lockless_lookup(key); * if (obj) { From patchwork Sat Apr 15 00:37:53 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SeongJae Park X-Patchwork-Id: 13212231 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78AF5C77B76 for ; Sat, 15 Apr 2023 00:38:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 14BC090000C; Fri, 14 Apr 2023 20:38:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0D614900002; Fri, 14 Apr 2023 20:38:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E1AEE90000C; Fri, 14 Apr 2023 20:38:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id D02D8900002 for ; Fri, 14 Apr 2023 20:38:10 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id A99F31A0416 for ; Sat, 15 Apr 2023 00:38:10 +0000 (UTC) X-FDA: 80681763540.19.DDAEBBD Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf21.hostedemail.com (Postfix) with ESMTP id 1DEEB1C0007 for ; Sat, 15 Apr 2023 00:38:08 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=RQRUhO4B; spf=pass (imf21.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681519089; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/jcEvfQQtVBvRPQ2PnEx5l1i3yxHAcPky8oDPHsGMPY=; b=U2b7gd2YeCK+nR409WR3k6gpzLUHXzDGYX8ezcQq7jCuFzWD27YhwLuozNJRyD40KYwucN XXTCAkuH4FO+4fj1LwRgXH7SSiFLtVv4smf/NgQEmxS2qeLmYHpB1tHUJ1iv17PyjnG7gr Nnmrxjn9fKpqdBWiFyJYROXx4XaKCQk= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=RQRUhO4B; spf=pass (imf21.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681519089; a=rsa-sha256; cv=none; b=2IlWpHiSPesF0L/GJbGU+6au+nHt2a1jmWdeuM8kGWVe3tpK7vqs0kACgKjrEirJ+1LQpb RAkhSQ85cYpF23NG2tloiFT6BEe7eQ5l0unv9d2UA/LIyv5kCy29Zhx8a8UbFS8EuEYWcL TC4jU+kFI4s7kPN2tqYP3R5clzYOWMs= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4BA4164B48; Sat, 15 Apr 2023 00:38:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 645CEC4339E; Sat, 15 Apr 2023 00:38:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681519087; bh=W5jwPfe3GbEvKKWR+zzbHPFAxqpHbCJnsJu/eHhmiUM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=RQRUhO4Bt8p+Np1+9FS1Nj59CKTjCe8d9cnYKb6XZIsxMJUvxQhlHqae65OBMzA8i YWxisIEN6YNPNQvLj6G37HMUZTY7tRxwBN1uF82A6lMjKhJePduP9R17bWwzMCe/BE ptkG6Y51I5W+H9FPwRHsxkrSAvMw09GqeW33UPuxkSS+B5VJ6IdKDS4eojDfI/B6SR 7df4wPUhmy89w/FJ6JElwUCRboQriSjJ7HfIn9SM/8d/nDocjPX+R/58DPU4z+n9eV nRbK/ZxHc96n67ElviO+PHvWU86xxYfwHjoj4sC7/bQPCaqKOBp6h9gAOLHigyhV2B U4VN8mBVyqrOQ== From: SeongJae Park To: akpm@linux-foundation.org Cc: vbabka@suse.cz, linux-mm@kvack.org, linux-kernel@vger.kernel.org, SeongJae Park Subject: [PATCH 2/2] mm/slab: break up RCU readers on SLAB_TYPESAFE_BY_RCU example code Date: Sat, 15 Apr 2023 00:37:53 +0000 Message-Id: <20230415003754.1852-3-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230415003754.1852-1-sj@kernel.org> References: <20230415003754.1852-1-sj@kernel.org> MIME-Version: 1.0 X-Stat-Signature: fn3rw9xaucoqs3ha7ed5tcjf5jox8tys X-Rspam-User: X-Rspamd-Queue-Id: 1DEEB1C0007 X-Rspamd-Server: rspam06 X-HE-Tag: 1681519088-716738 X-HE-Meta: U2FsdGVkX19zYtUrsD2GrgkPYJCZeSTQcf63IEY2PKRvEfzhFDvkiP/lXEo/47xuphsAlrUH/ipXYF/qsvQga0/DoS3SbMPNA2+JLz8PJvO+rOjdcTtJy0Vl/QPnnQjq6C7RudaIINcsRj3dE6iOwM/w0UQcFCVgiKMaJt+C2rUMG84bUrImDBuIt9S+IJUrHvABOB6XkVQxFkQmNx4DzIUd4oyH/pfQbl74esEixFC+cxOCBCGQBlDQPqec7acKI9nu7Re4vday0WLfedjmqBSqgMUrXB5th9sb9CSf6OlII++Xx1NBjglZilUe9POXINIqrajEMhBzBwD1ZtdudBkNcPYNWp3PRyjL4wwnBS346mu1X14KMyCqnl4X7qCl4tQu7M0BywforaAuEvbaU5+OmnbLOVU9NQRP1cwpgGrpFEp2A0ngvkpEyZbPaj6yl3UZY4uQGw9/7CgIV+LmZG196Ygp2N0rwrYNq48oi8eGUpCrboOtGWBmocXcbMm5LI8K9V+j/BG/zZkZMfVuqKGET1TONqcJsm53NmfYc8CVPlkU7/tHJHAHqgsjLw5P4s35mkIl/6lfwC3dn3xkwhZ2/DwTUZ7naXgR1M+XGrlDfXoHWfzYMVlZB3UofDBh8vNiWr5pJtjDLBvDSQCA8cN4BKOK5yjGB8m7OWeMR9HXLi6d6c+nz51FxV22NmG+RUXcd9XVEety1V0wkV/r20R+B7qUv7/IFGhJkVjF55HOAjcjAtF8mlS1ZiYMQ/rxYN2J9ULoJNhcJZWt/NZ6phoGgS0+rlVw+iq+TXAMBuFhx5HWaII7pwLEiMv+nmhj4WWElCMNi33W9rU3ECnO6hPxOnHPesaJM7HW0Y0Ua7Ni6Mg1dz8nHPrvjSTAzLpNrG4Ts23SRojfpeU2pfbASrVjJE1AIxKNZz+Xalq8FHnaeMN0MFybFKWaD4QnMz7avXf+y3CpIEVKg2UvgIi MFldTGGs pIcUo4Zmu2Ajq0Vbs+kZ09sbie3G8EVZxVYqHObPXmSaG5NtftuhgEdlij4xJ44G3Y3NhAJVhiWf5sfGLwDCQvZHXMymMLKx0bosCoEZ6LfSPvlt+AOOH79lBj5fB6BVBRkej0Qf2yqMhYAvSU3oKJDFTP2F0w6j5iBXQN4tU2goiHiQPyJZpf8f4NBcyK4UBXCUyIJmwf0n79T2C/QhzxuFnlnRhf+hRj3dQy+rg9Wc8arS4TdZjSjKd0cN1Ns2TbhZMdeakf8ty5wJgeDxog0ipo2+YsRDjDknGyBAcD41DrZ2OmRmBupUv7Htp2ZmPdHVaPc/Dy5cSM1cMBl1mqmGhi29X1EoE0mMcjmyamnmxv5eXUkJqU2MChcOqR7es5/qLGPgVyREMurmlvuXE3YN24g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The SLAB_TYPESAFE_BY_RCU example code snippet is having not tiny RCU read-side critical section. 'Documentation/RCU/rculist_nulls.rst' has similar example code snippet, and commit da82af04352b ("doc: Update and wordsmith rculist_nulls.rst") has broken it. Apply the change to SLAB_TYPESAFE_BY_RCU example code snippet, too. Signed-off-by: SeongJae Park --- include/linux/slab.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/include/linux/slab.h b/include/linux/slab.h index b18e56c6f06c..a2fd57322c9c 100644 --- a/include/linux/slab.h +++ b/include/linux/slab.h @@ -53,15 +53,16 @@ * stays valid, the trick to using this is relying on an independent * object validation pass. Something like: * + * begin: * rcu_read_lock(); - * again: * obj = lockless_lookup(key); * if (obj) { * if (!try_get_ref(obj)) // might fail for free objects - * goto again; + * goto begin; * * if (obj->key != key) { // not the object we expected * put_ref(obj); + * rcu_read_unlock(); * goto again; * } * }