From patchwork Tue Apr 18 09:35:41 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 13215310 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6F957C77B71 for ; Tue, 18 Apr 2023 09:36:09 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.522701.812223 (Exim 4.92) (envelope-from ) id 1pohka-0005F5-N8; Tue, 18 Apr 2023 09:35:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 522701.812223; Tue, 18 Apr 2023 09:35:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pohka-0005Ey-KJ; Tue, 18 Apr 2023 09:35:48 +0000 Received: by outflank-mailman (input) for mailman id 522701; Tue, 18 Apr 2023 09:35:48 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pohka-0005Es-96 for xen-devel@lists.xenproject.org; Tue, 18 Apr 2023 09:35:48 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on20600.outbound.protection.outlook.com [2a01:111:f400:7e1b::600]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 64ac5037-ddcc-11ed-b21f-6b7b168915f2; Tue, 18 Apr 2023 11:35:45 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB8624.eurprd04.prod.outlook.com (2603:10a6:102:21b::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.45; Tue, 18 Apr 2023 09:35:44 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae%2]) with mapi id 15.20.6298.045; Tue, 18 Apr 2023 09:35:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 64ac5037-ddcc-11ed-b21f-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=e00X9ptd8NzNCDjQIN9sLm4B7Nmi54ZeJUZL0VYiZMe2Xuu5Sjfn7SWsC4hFknkMh9iEE4f/SjJ7qQ3dDjZFYihXNo6DCv9JN4bzn2QMRlA9SYiGffGk5UMu8ck1Zwf/VcmnK2temYijxskMSUgT3f2C3BAwTZ9YOUJuvaK/SU5FzWw8/7LyxZqs6RnAcAIdB9O8j1vBRQ9FZgEQ4h4gzZRFC376kQcetJ18P6C8bDmrIvE2k4KDAYbuv4AIhemSRnKPakQAafRcueBf7m2EeBAzEK+s15eq288yZ99vKGFM8loNXrDH8aK+tVXTz6tAXEpYQpUSWObWAAPkEmxjQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sKyDnkik5ayw5gfaTdlRNJoU3D5nuUPMckTjZzUPdmc=; b=UCEttQOT8Ag4EhyV5k70RSl20QVmPAsabIKdWjrRZVa4TA9fgkjdVU6x/fR+wngYq7m4RevniH1XybZPLTqUvRodnvR20c9qvHQlv93Ulro9qh9HvUyfFUrUSy18elSD7BSJ8D1ZUr76Zn6mg/QERoeVly36hwMR56YJABDUBCCKZyPouoEz3pv07DgLCRdDxGQjvWm4zrj94ELWIaZRW3wDutE2VtaZ+GeXche6HrnoUdNDCP3CIHNl1VXqoVkZi8t+L1H8MvJ6NNj41N3SnSCmaafw+YdNRFy8Dn9Let3NfW8ON6iBp4+RtqGWpP8dpstTKaOvl87YvVldlahjPg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sKyDnkik5ayw5gfaTdlRNJoU3D5nuUPMckTjZzUPdmc=; b=p7eLVAnSq/ohPYXPSslioZFOh7Pv7oGwBvSaRj/XZ+t2atFHuafDjjbnEE7TkBmdCYoj1xktQtrgyYjUa9f/b3S4tqFLx7Y5dHWZ/TV8diRFvk76OL0hSqJnCE04OHGvhuyXum7jm+v1YSJkwsddGEArUyeP09pagx4ntm82VzgQXSlAlrSem6CxEKSoF57e2UGPWt2BxrWxsOY9NbZRcDuGxczGLbV+gTJ9ZUBuEdC5sOihGCgsOf7j9Gw5EDi1l0Uhd4G0hw+tYmN7880jxMD/wMaaJDrYjXT6sujyRKywK1+GISdzwk+04PJ09YCuYGu3lrb8H1uqDnnNSXIVFA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 18 Apr 2023 11:35:41 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?utf-8?q?Roger_Pau_Monn=C3=A9?= From: Jan Beulich Subject: [PATCH] x86: cpu{id,}_policy_updated() can be static X-ClientProxiedBy: FRYP281CA0013.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10::23) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB8624:EE_ X-MS-Office365-Filtering-Correlation-Id: cff6c923-2c5a-44c3-e011-08db3ff047a9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: KQOx2KRzWEqvnPhJGUSgkZJKHIE/xqNOjp5KdRH0Uu7Ah79fp473iitDvwIjWqfO9H1T/OKEUYT755+Nwf+1KEhRiPiasL2jle8LtESoGwwWtdao1kEQKdsAwTcvtxLS+rwcTGeCaFSpYOQzAeRPLn0/5WbAUVKnenQKdii90Bv0MkydvIoVqutcofLUes6tyKpTiMHZAxt3bxSOKePw38KvxlAStFjjZBPXr/vPNl7rklrmQi6jLW0NooftuUttHcH3WuAWXEnBe6TvR4EmbAGHbhSHDNY9VjRgTX2/4iwUZ5sMnoA5gcZEen3lCO2tnnQfuKefaiqUx2ib/WzZh8GciHKz40ADDivZCNAEGQqS366oUkRSLxFquLCjcy79YmHSFXPU8wkbSYjc0WSj3qCBVxvI9F0PQjUb6AkZnay+bOBm9FkPLOKBPUW/JC7WcO0reQQpEtMmGvP3sGs3noTHEL3K/uHBu/dGMsQCDp8B4DqUCA0WxioNmSY5xM49HXg5juOpcTbedGmuaSlqcqlBJbqCEyeRay6hW6gY2hTZs6yfVrf9ngf3IgzL44K6qeQF3sKZiL7eqY0ljerF5XBg1FpJp00EN2HTZ9LIha7h7lYpUNWXTXcifugFb4+7erzfrj9T7Lxnj1JGSRDdEw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(346002)(136003)(366004)(376002)(39860400002)(396003)(451199021)(36756003)(38100700002)(8936002)(8676002)(5660300002)(2906002)(86362001)(31696002)(478600001)(6486002)(54906003)(31686004)(186003)(2616005)(6512007)(66946007)(6506007)(66476007)(26005)(41300700001)(316002)(83380400001)(6916009)(4326008)(66556008)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?U2bisc1ObI6IZSs+5Kz4sXeO7Bu3?= =?utf-8?q?fQLPgDzv6QPGyZtv6dUl8mhhnuuVzggZLGda8QbxSxGK5afD1AqvPwwF0Dr10DL89?= =?utf-8?q?GDUWSPG5DzUKSCc8rAYaJ8mk/Z7N1E21CgdtK0+rOOT0D1yo+VZqARM9djKCrJQ+a?= =?utf-8?q?LbN07ZJ22qiG1aFO/ZSzTFOuObZCazQaky1tVk7dJyt7xToJoNO6IQw4ZzIgm4yLb?= =?utf-8?q?j4E5BPb676rAwbp4QFmcLeBj85mtGZzDfFKGHtIjHbSq9HR05Q/23o7ZxkxY+v/3O?= =?utf-8?q?WntDDLmR4qdS0BiPOCBUOedyN7/uxjinqSiulrve2NxQJ8zYH+kedZSUZByHX8DNR?= =?utf-8?q?xAPDdL+A59QDjdfdAIJdjkSO4FJbSLi+aEvQnq8yOXLlgVDzD5saVmE7pBS/5B87b?= =?utf-8?q?3gsi6XcB9Zsz+l7wGWC2GYnoiO5RqNIofLm1VeI7EliphqkQXMBpgyrxA1s/KxXWl?= =?utf-8?q?66fTkz0+3xFvTr/McNhq55rs2IfSVOGIIKfuG0Cqr799sEuoZY0by4oHje0HL8Y/U?= =?utf-8?q?9pytNdGWMTjH6FOz+6BuWDk6Bf92GuEiw+3SL/rUo98Is6ZRozJFh8xdfxDL+YdbP?= =?utf-8?q?qhvUm0R3ngucHbsuxCN/9Wlh7UfrJ/DcI+KilFKTVQkB6FCmM2BwXrraB7el8nZwj?= =?utf-8?q?czYfJbc4Wvh8WAtTq9b1EunvLefm3TYHrZ1oIplrMbQRO/8sZBYFCKI+NZfIlJLBi?= =?utf-8?q?mfwQzbNVrJ6HR4qMYZMnwwrO1mi8BNEfFtNC3n/yvNsqWyENm3e+yBsPZ8t9Z7soj?= =?utf-8?q?lKba+xM1o+6bdZlPK0jEK7+NA/V7jEe4mOemGfAulGS+dxlOZ1bgN1+NKfhEZg+sB?= =?utf-8?q?t1K12D+2Ud5MXhkXaEsIBOg5pFcm9YViKmQKQPV5UthZngxPwcKAJBedjbuVDdHwt?= =?utf-8?q?2yWIPzSG8ihSXK16oS0tYpawh4cpG8RSdxdPUex5tQfmd+QP41SLgdwKY/LDzkTj9?= =?utf-8?q?emELkh3WWfi+ALJk4H8zqATuh8u+FqyVIYIDlxzVk+E9cv+804CQumLpX7ucChf8l?= =?utf-8?q?XNLTGFySp/167Xv1Dk4yR72XrDOGsMIVoKLYwAdN972QgmK525Buc/R8PJ2hso33e?= =?utf-8?q?COUdJjzjK5TB36kPcfEBQ2Onq+WC3qi6tvomha2AE4HOcK5Mr8mKv5zEwwd+K6H75?= =?utf-8?q?a9XyxUVTqotkaWufYLBCLy88BaJsZr2gqYOgljekBZm83rtPcQvLX2qhMrrAiqAx3?= =?utf-8?q?nH5qlB2jCMx+NGryoJ4ZTmpr43q22dmiJc2QUY37G3CJsdMRMIT2UUo/9gifSsEzd?= =?utf-8?q?NOQb8t79obCk+v0uYRzr0fA3fDeq9LQ1NV58pcDrBqZHPAUMONd9Pjr3NrCh/F9Kl?= =?utf-8?q?+5JpTZYndct/sRDdm1BXwhKNubOJ/iB9q7D/9K7KKt1WlMVM7NdlTuDRX+GKkD20W?= =?utf-8?q?liT5P3vAwJyOGM9bbBVr7I3+buMSWttBh3gPyWwc/1c5izg4acvh3wgMgxPQ9EFIm?= =?utf-8?q?CNPsUgWB3zceGUpoexk7nFoknckSHiIzY9YiMmkbkEbWrcUMNDRcdXDjEcPU7gyVm?= =?utf-8?q?lMs1hOJtjh0N?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: cff6c923-2c5a-44c3-e011-08db3ff047a9 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Apr 2023 09:35:43.1204 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hpqkQ3kao7DFMo6yGrjscESP9BsYSZ8JyScEocp1ieLIxh5HNLrFe7/CL1YNBM4Lo860KTvDQJ3p5LHtwkZbSQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8624 The function merely needs moving earlier in the file to avoid the need for a forward declaration. While moving it, also rename it following the recent folding of CPUID and MSR policies. Signed-off-by: Jan Beulich Acked-by: Roger Pau Monné --- a/xen/arch/x86/domain.c +++ b/xen/arch/x86/domain.c @@ -288,6 +288,16 @@ void update_guest_memory_policy(struct v } } +/* + * Called during vcpu construction, and each time the toolstack changes the + * CPUID configuration for the domain. + */ +static void cpu_policy_updated(struct vcpu *v) +{ + if ( is_hvm_vcpu(v) ) + hvm_cpuid_policy_changed(v); +} + void domain_cpu_policy_changed(struct domain *d) { const struct cpu_policy *p = d->arch.cpu_policy; @@ -446,7 +456,7 @@ void domain_cpu_policy_changed(struct do for_each_vcpu ( d, v ) { - cpuid_policy_updated(v); + cpu_policy_updated(v); /* If PMU version is zero then the guest doesn't have VPMU */ if ( boot_cpu_data.x86_vendor == X86_VENDOR_INTEL && @@ -591,7 +601,7 @@ int arch_vcpu_create(struct vcpu *v) { vpmu_initialise(v); - cpuid_policy_updated(v); + cpu_policy_updated(v); } return rc; @@ -2416,16 +2426,6 @@ int domain_relinquish_resources(struct d return 0; } -/* - * Called during vcpu construction, and each time the toolstack changes the - * CPUID configuration for the domain. - */ -void cpuid_policy_updated(struct vcpu *v) -{ - if ( is_hvm_vcpu(v) ) - hvm_cpuid_policy_changed(v); -} - void arch_dump_domain_info(struct domain *d) { paging_dump_domain_info(d); --- a/xen/arch/x86/include/asm/domain.h +++ b/xen/arch/x86/include/asm/domain.h @@ -83,8 +83,6 @@ void toggle_guest_mode(struct vcpu *); /* x86/64: toggle guest page tables between kernel and user modes. */ void toggle_guest_pt(struct vcpu *); -void cpuid_policy_updated(struct vcpu *v); - /* * Initialise a hypercall-transfer page. The given pointer must be mapped * in Xen virtual address space (accesses are not validated or checked).