From patchwork Fri Apr 21 01:01:32 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Rix X-Patchwork-Id: 13219325 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3326BC77B73 for ; Fri, 21 Apr 2023 01:02:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232636AbjDUBCZ (ORCPT ); Thu, 20 Apr 2023 21:02:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58014 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231835AbjDUBCY (ORCPT ); Thu, 20 Apr 2023 21:02:24 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BB55CB0 for ; Thu, 20 Apr 2023 18:01:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1682038896; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=gqaNSPIG3egbVU/231FllxDEwXJCGtSU1G0fwdxkTnY=; b=bGcgwLBZcXR51qtDo8QJrDvWRGHNMmLZ5mDvYZC1fDyl12fcsPKJhHRNVUZVxsLwpFcABH VHKspkQnAbE7jnmfBewH4TOSwuZ3HEwH2LqojINH+seRa+5v37CIrCYh/FjFphTgdrda+j ++6UIJQy9DPNu9z3LUHbhYRsL8iia58= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-593-4fWYvGSWMKiXiwNbZXffww-1; Thu, 20 Apr 2023 21:01:35 -0400 X-MC-Unique: 4fWYvGSWMKiXiwNbZXffww-1 Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-3ee15d30190so8695601cf.1 for ; Thu, 20 Apr 2023 18:01:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682038895; x=1684630895; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=gqaNSPIG3egbVU/231FllxDEwXJCGtSU1G0fwdxkTnY=; b=L1DWtEtAaa2fFktVcS1vM4lNVxhHkDdpc0qZrt9/We5KW4gjQDP7DCFlFTRela4ebn gPtTumTxvV78c1ebMVmhTuyAq2e7jTgCrWjeDGR/bdMlHLGqSZJ9KV4q6BYnIGsTFsfk Da+sXIGR70UN32n3qBrpmN6asay1l8fjhpTVmBwAkTETFgEXLBexzDoUQs45AWhrQwFS +mqkpMxX3DhM8c6Bgrts5ybK8DEspiM05qFfbOYw8Dub68mDw8ujiLR+iuuo74/ol1TW 3hmPKx28h8kzlk8OSXQFHfUdSTFHXEgAZ+i9zuS82tkUla7G2u7vCUhXbLYTMi0IZh6R LLfg== X-Gm-Message-State: AAQBX9fAW5lyFpd3j5QPwQVYZBVpEMmG2vPOBOJiSm00SkO3ynwTOpg9 0D0U8SbmiINygxFTHZA7x1o1qsMJB9hbSBphvg9yifUAcS0VEXxODz9xMOErXAsMu02Gr75l/fD ZYU5ts5MXWKy1BnuEQORNVi3uF0ZK X-Received: by 2002:a05:622a:1812:b0:3d9:525d:f024 with SMTP id t18-20020a05622a181200b003d9525df024mr6177117qtc.28.1682038894944; Thu, 20 Apr 2023 18:01:34 -0700 (PDT) X-Google-Smtp-Source: AKy350Z9MGDHoM5IgGuEW+LbaHPP9uqc55u+dxchvXXi/TlvPPj+ER2zP7d/2B7M5G7OGn6mH++c3g== X-Received: by 2002:a05:622a:1812:b0:3d9:525d:f024 with SMTP id t18-20020a05622a181200b003d9525df024mr6177086qtc.28.1682038894641; Thu, 20 Apr 2023 18:01:34 -0700 (PDT) Received: from dell-per740-01.7a2m.lab.eng.bos.redhat.com (nat-pool-bos-t.redhat.com. [66.187.233.206]) by smtp.gmail.com with ESMTPSA id g17-20020ac87d11000000b003edce7e34bfsm908086qtb.81.2023.04.20.18.01.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Apr 2023 18:01:34 -0700 (PDT) From: Tom Rix To: trond.myklebust@hammerspace.com, anna@kernel.org Cc: linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org, Tom Rix Subject: [PATCH] NFS: set varaiable nfs_netfs_debug_id storage-class-specifier to static Date: Thu, 20 Apr 2023 21:01:32 -0400 Message-Id: <20230421010132.3898278-1-trix@redhat.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org smatch reports fs/nfs/fscache.c:260:10: warning: symbol 'nfs_netfs_debug_id' was not declared. Should it be static? This variable is only used in its defining file, so it should be static Signed-off-by: Tom Rix --- fs/nfs/fscache.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/nfs/fscache.c b/fs/nfs/fscache.c index 95c2b3056e2b..8c35d88a84b1 100644 --- a/fs/nfs/fscache.c +++ b/fs/nfs/fscache.c @@ -257,7 +257,7 @@ int nfs_netfs_readahead(struct readahead_control *ractl) return 0; } -atomic_t nfs_netfs_debug_id; +static atomic_t nfs_netfs_debug_id; static int nfs_netfs_init_request(struct netfs_io_request *rreq, struct file *file) { rreq->netfs_priv = get_nfs_open_context(nfs_file_open_context(file));