From patchwork Sun Apr 23 15:34:28 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Rix X-Patchwork-Id: 13221399 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 38A5AC6FD18 for ; Sun, 23 Apr 2023 15:35:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=bGUCDzU5aWN0ytkATD/iP7mUxQ6oNIoOucThuWJ0KqY=; b=IyWE1ESUisILFf TpaLL+5YhkJ2dgMiBhK+3U9RR0xGDgP44uYH/sGZQ+Qff8AR5Wu7z3QsCpx/3DS1TzEo7WvlLicBI WANgF5lajuvfQu4g+nfEfJL8YHh21AFvPtW68+RhPCRUfJdLOxKGk885Ir8sKGsV9FTgvJ7kzd5hk fCaZN2ipziQgDl8i5kNktll+IqQMP0K3gWV0Z7piJHlV2WEAGyTJbBxhEJd3vDvsJpzon12hqpUg0 8Nd4SXvJtM3eT90Pm7W3m9HPlmQlilnSy4RT1tVDE8GNS8PQ2epdXuurxg5svAjBpc24NNlmOtn1U KPR5El5eIS7qI26L+7Xg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pqbjb-00ETVj-2g; Sun, 23 Apr 2023 15:34:39 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pqbjZ-00ETVL-0A for linux-arm-kernel@lists.infradead.org; Sun, 23 Apr 2023 15:34:38 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1682264075; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=6SqLgVIvmYoBeVscKlefF4YVXTcxu2vwftyHT1Y86s4=; b=IbRxEQh8ymD98Et2riVhqLJ9ne1xRR4Uvxv4td4uo58cjszO036tR1glxZpTpwTbTDhnC9 qv8OkE26at5MInwxVFhgS8ln24iiHiqpArIvzPJ1rls1GhKQ9MNsm8f8JWs6fU8ugjq3fY ws4QsW91eQyQm+n62H7j5YBAKQr8Akw= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-118-Y-CgAWUoNu2C95YneF3mrA-1; Sun, 23 Apr 2023 11:34:31 -0400 X-MC-Unique: Y-CgAWUoNu2C95YneF3mrA-1 Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-3f0a12ab268so1220301cf.1 for ; Sun, 23 Apr 2023 08:34:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682264071; x=1684856071; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=6SqLgVIvmYoBeVscKlefF4YVXTcxu2vwftyHT1Y86s4=; b=H0UzvyLMxPcLL4QkiwMoqxv4LJGGK9OcC+Nj5BrFwnEfwSSUVY17+ObJR7W18jV58q dCYupBO44vNw5dpa7L2H8xU9QSuvcZ52PT8EAbbF13xh8Wh1SJyvLL7lceScXM1UbqY5 XZ1T3vf41NIo9MpFlZYrdaFzYQlYWGtzrxyoJynZSHbGCuV4R+Mi1BGz+E5f6O2snDb7 uQN8y9c/Bect/g6ArrKlUB/t7t/okxXJs3VblDhIMxEEmHaO/tXBaCeSQmPB1dfFcS0G ivDlO+tkpUcZrvd64GDF7niEoXymvBZvR4AzRqPu7M741z3NKBuor3ooL71BxJJ+BV0S reeQ== X-Gm-Message-State: AAQBX9dZoyXvGmS6a5khPbcGASza70wL+eKKa9atN74WSouhqj1r2BxA jUN2bbl86lME7Go0ayCnZ9IUVokcIZYAM/3NC5K9AEM59rOGNpySwM1vtflKqrlRBC9AWDfud1S bSmiv3lTArIUI3HAsHqaxpL127iXfkmbOhpY= X-Received: by 2002:a05:622a:353:b0:3ef:3cdf:c29d with SMTP id r19-20020a05622a035300b003ef3cdfc29dmr19870211qtw.52.1682264070986; Sun, 23 Apr 2023 08:34:30 -0700 (PDT) X-Google-Smtp-Source: AKy350a3Nh0lPR6tJZeIU/ILJ6y6gRnF/+mxuC2FZU4C6ru1VswVmKRM5wNg2IwQGrBj2ocevTHgSw== X-Received: by 2002:a05:622a:353:b0:3ef:3cdf:c29d with SMTP id r19-20020a05622a035300b003ef3cdfc29dmr19870187qtw.52.1682264070767; Sun, 23 Apr 2023 08:34:30 -0700 (PDT) Received: from dell-per740-01.7a2m.lab.eng.bos.redhat.com (nat-pool-bos-t.redhat.com. [66.187.233.206]) by smtp.gmail.com with ESMTPSA id ey19-20020a05622a4c1300b003ef324c6fa3sm2334416qtb.52.2023.04.23.08.34.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Apr 2023 08:34:30 -0700 (PDT) From: Tom Rix To: mark.rutland@arm.com, lpieralisi@kernel.org, sudeep.holla@arm.com Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Tom Rix Subject: [PATCH] firmware: smccc: set variables smccc_soc_id_version,revision storage-class-specifier to static Date: Sun, 23 Apr 2023 11:34:28 -0400 Message-Id: <20230423153428.3938525-1-trix@redhat.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230423_083437_157402_0ED25751 X-CRM114-Status: GOOD ( 10.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org smatch reports drivers/firmware/smccc/smccc.c:20:21: warning: symbol 'smccc_soc_id_version' was not declared. Should it be static? drivers/firmware/smccc/smccc.c:21:21: warning: symbol 'smccc_soc_id_revision' was not declared. Should it be static? These variables are only used in their defining file so should be static Signed-off-by: Tom Rix Acked-by: Sudeep Holla --- drivers/firmware/smccc/smccc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/firmware/smccc/smccc.c b/drivers/firmware/smccc/smccc.c index db818f9dcb8e..0cf4c45de417 100644 --- a/drivers/firmware/smccc/smccc.c +++ b/drivers/firmware/smccc/smccc.c @@ -17,8 +17,8 @@ static enum arm_smccc_conduit smccc_conduit = SMCCC_CONDUIT_NONE; bool __ro_after_init smccc_trng_available = false; u64 __ro_after_init smccc_has_sve_hint = false; -s32 __ro_after_init smccc_soc_id_version = SMCCC_RET_NOT_SUPPORTED; -s32 __ro_after_init smccc_soc_id_revision = SMCCC_RET_NOT_SUPPORTED; +static s32 __ro_after_init smccc_soc_id_version = SMCCC_RET_NOT_SUPPORTED; +static s32 __ro_after_init smccc_soc_id_revision = SMCCC_RET_NOT_SUPPORTED; void __init arm_smccc_version_init(u32 version, enum arm_smccc_conduit conduit) {