From patchwork Wed Apr 26 04:11:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Tzvetomir Stoyanov (VMware)" X-Patchwork-Id: 13224000 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B069EC77B60 for ; Wed, 26 Apr 2023 04:11:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239168AbjDZELc (ORCPT ); Wed, 26 Apr 2023 00:11:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60150 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239034AbjDZELb (ORCPT ); Wed, 26 Apr 2023 00:11:31 -0400 Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [IPv6:2a00:1450:4864:20::331]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C394DE4E for ; Tue, 25 Apr 2023 21:11:29 -0700 (PDT) Received: by mail-wm1-x331.google.com with SMTP id 5b1f17b1804b1-3f199696149so28481265e9.0 for ; Tue, 25 Apr 2023 21:11:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682482288; x=1685074288; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=6IKmn/5HIcqgUNOg33rzqTGpxgxCRBh+q9beHG4w2KM=; b=JpDY+2Hx3XUOsD5p93y5U0jqWg/1R30RhzprYlXr/wfZgDdQbRhm+W27yseljsBINk +9c1r94veyM5wa+Mf+YglGBu7Doe9eNHHP4UHINNT0X35FahMcl4KkrfO5gZ+8LDvP0y wDOOqm4Q7aLUqwj6Cuxyl4iu80LLo7inVeOUGvOXaFPg6VFOwlHK3X8FZMwvekUZIRt5 lX/pb1nNKXeMYJsAJ+ZO40QGMKEfnwluybsNfwhRJdz68jf2pO2uedun7c0hRdg7g2y5 orORn7+x3Msh++d73R0FvM5pAl74UsCU7/yMlJLlxEDUnvTXRM109U8sWctjuy5/QvZk 9KkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682482288; x=1685074288; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6IKmn/5HIcqgUNOg33rzqTGpxgxCRBh+q9beHG4w2KM=; b=ByXqs7ZbbFBvB07ZzXol59GeG/5v+R/kxAcVHjBWItkLZ8bl0/2bhp7yrStppkdgLV NMv7oNPmd7LAyGhal1Xwc5pbIk4R7s99IJFhcumE1hG1JCCpzBsaeGY//xu84i6B/fPz 2SrnuO2eUTpKHC6nGNGKnyRY2OerM+p0Gh70tG7vkLP/ZM6tFbbUwE1S18M66SRGd8Qp ouOkXaAvbQzTZj0ipdPJWvUP482yEKDt17WvFYdnjYLuiAEMAHIbgzRi60VyBLAhmvjs ij6okePCq6MvnhNz/r/Hbd676m7U+2w5gNXTfV+9vTH2V5qM3zRHYPpa+adW6inlWDkS B20A== X-Gm-Message-State: AAQBX9eenxu/iAJxNBbzlgqXSh2FVYd7mauPsuYxVqD8Bu8dxcKqSFkE uxhk7Y39x4igE5SH0N+GIEszdqQWGoE1zA== X-Google-Smtp-Source: AKy350Yr1yk2qdFgd324FfIrbRHpzteV6qMMHOghyIZdEbFWeOUJxkxW3QAD+fpDu91ZvWxa4FM3rg== X-Received: by 2002:a1c:c907:0:b0:3ed:3d89:1b4b with SMTP id f7-20020a1cc907000000b003ed3d891b4bmr12757057wmb.8.1682482288025; Tue, 25 Apr 2023 21:11:28 -0700 (PDT) Received: from oberon.zico.biz (77-85-190-39.ip.btc-net.bg. [77.85.190.39]) by smtp.gmail.com with ESMTPSA id m5-20020a5d6a05000000b002f01e181c4asm14648107wru.5.2023.04.25.21.11.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Apr 2023 21:11:27 -0700 (PDT) From: "Tzvetomir Stoyanov (VMware)" To: rostedt@goodmis.org Cc: linux-trace-devel@vger.kernel.org Subject: [PATCH v2 1/3] libtracefs: New API to reset ftrace instance Date: Wed, 26 Apr 2023 07:11:22 +0300 Message-Id: <20230426041124.69544-2-tz.stoyanov@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230426041124.69544-1-tz.stoyanov@gmail.com> References: <20230426041124.69544-1-tz.stoyanov@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org Resetting a ftrace instance to its default state is not a trivial task. A lot of trace files have to be modified, with different syntaxes and in strict order. Although there is such functionality in "trace-cmd reset" command, it will be good to have it in the tracefs library as well. A new API tracefs_instance_reset() is introduced, which resets given ftrace instance to its default state. The logic and most of the helper functions from "trace-cmd reset" command are copied in the tracefs library. Signed-off-by: Tzvetomir Stoyanov (VMware) --- include/tracefs-local.h | 1 + include/tracefs.h | 1 + src/tracefs-instance.c | 207 ++++++++++++++++++++++++++++++++++++++++ src/tracefs-utils.c | 20 ++++ 4 files changed, 229 insertions(+) diff --git a/include/tracefs-local.h b/include/tracefs-local.h index 2007d26..da99a30 100644 --- a/include/tracefs-local.h +++ b/include/tracefs-local.h @@ -64,6 +64,7 @@ int trace_get_instance(struct tracefs_instance *instance); /* Can be overridden */ void tracefs_warning(const char *fmt, ...); +char *strstrip(char *str); int str_read_file(const char *file, char **buffer, bool warn); char *trace_append_file(const char *dir, const char *name); char *trace_find_tracing_dir(bool debugfs); diff --git a/include/tracefs.h b/include/tracefs.h index 3547b5a..5e9d84b 100644 --- a/include/tracefs.h +++ b/include/tracefs.h @@ -23,6 +23,7 @@ int tracefs_tracing_dir_is_mounted(bool mount, const char **path); struct tracefs_instance; void tracefs_instance_free(struct tracefs_instance *instance); +void tracefs_instance_reset(struct tracefs_instance *instance); struct tracefs_instance *tracefs_instance_create(const char *name); struct tracefs_instance *tracefs_instance_alloc(const char *tracing_dir, const char *name); diff --git a/src/tracefs-instance.c b/src/tracefs-instance.c index 57f5c7f..b3ed983 100644 --- a/src/tracefs-instance.c +++ b/src/tracefs-instance.c @@ -1239,3 +1239,210 @@ char *tracefs_instance_get_affinity(struct tracefs_instance *instance) return set; } + +static int clear_trigger(const char *file) +{ + char trigger[BUFSIZ]; + char *save = NULL; + char *line; + char *buf; + int size; + int len; + int ret; + + size = str_read_file(file, &buf, true); + if (size < 1) + return 0; + + trigger[0] = '!'; + + for (line = strtok_r(buf, "\n", &save); line; line = strtok_r(NULL, "\n", &save)) { + if (line[0] == '#') + continue; + len = strlen(line); + if (len > BUFSIZ - 2) + len = BUFSIZ - 2; + strncpy(trigger + 1, line, len); + trigger[len + 1] = '\0'; + /* We don't want any filters or extra on the line */ + strtok(trigger, " "); + write_file(file, trigger, O_WRONLY); + } + + free(buf); + + /* + * Some triggers have an order in removing them. + * They will not be removed if done in the wrong order. + */ + size = str_read_file(file, &buf, true); + if (size < 1) + return 0; + + ret = 0; + for (line = strtok(buf, "\n"); line; line = strtok(NULL, "\n")) { + if (line[0] == '#') + continue; + ret = 1; + break; + } + free(buf); + return ret; +} + +static void disable_func_stack_trace_instance(struct tracefs_instance *instance) +{ + char *content; + char *cond; + int size; + + content = tracefs_instance_file_read(instance, "current_tracer", &size); + if (!content) + return; + cond = strstrip(content); + if (memcmp(cond, "function", size - (cond - content)) != 0) + goto out; + + tracefs_option_disable(instance, TRACEFS_OPTION_FUNC_STACKTRACE); + out: + free(content); +} + +static void reset_cpu_mask(struct tracefs_instance *instance) +{ + int cpus = sysconf(_SC_NPROCESSORS_CONF); + int fullwords = (cpus - 1) / 32; + int bits = (cpus - 1) % 32 + 1; + int len = (fullwords + 1) * 9; + char buf[len + 1]; + + buf[0] = '\0'; + sprintf(buf, "%x", (unsigned int)((1ULL << bits) - 1)); + while (fullwords-- > 0) + strcat(buf, ",ffffffff"); + + tracefs_instance_file_write(instance, "tracing_cpumask", buf); +} + +static void clear_func_filter(struct tracefs_instance *instance, const char *file) +{ + char filter[BUFSIZ]; + char *line; + char *buf; + char *p; + int len; + + buf = tracefs_instance_file_read(instance, file, NULL); + if (!buf) + return; + + /* Now remove filters */ + filter[0] = '!'; + + /* + * To delete a filter, we need to write a '!filter' + * to the file for each filter. + */ + for (line = strtok(buf, "\n"); line; line = strtok(NULL, "\n")) { + if (line[0] == '#') + continue; + len = strlen(line); + if (len > BUFSIZ - 2) + len = BUFSIZ - 2; + + strncpy(filter + 1, line, len); + filter[len + 1] = '\0'; + /* + * To remove "unlimited" filters, we must remove + * the ":unlimited" from what we write. + */ + p = strstr(filter, ":unlimited"); + if (p) { + *p = '\0'; + len = p - filter; + } + /* + * The write to this file expects white space + * at the end :-p + */ + filter[len] = '\n'; + filter[len+1] = '\0'; + tracefs_instance_file_append(instance, file, filter); + } +} + +static void clear_func_filters(struct tracefs_instance *instance) +{ + int i; + const char * const files[] = { "set_ftrace_filter", + "set_ftrace_notrace", + "set_graph_function", + "set_graph_notrace", + "stack_trace_filter", + NULL }; + + for (i = 0; files[i]; i++) + clear_func_filter(instance, files[i]); +} + +/** + * tracefs_instance_reset - Reset a ftrace instance to its default state + * @instance - a ftrace instance to be reseted + * + * The main logic and the helper functions are copied from + * trace-cmd/tracecmd/trace-record.c, trace_reset() + */ +void tracefs_instance_reset(struct tracefs_instance *instance) +{ + int has_trigger = -1; + char **systems; + struct stat st; + char **events; + char *file; + int i, j; + + tracefs_trace_off(instance); + disable_func_stack_trace_instance(instance); + tracefs_tracer_clear(instance); + tracefs_instance_file_write(instance, "events/enable", "0"); + tracefs_instance_file_write(instance, "set_ftrace_pid", ""); + tracefs_instance_file_clear(instance, "trace"); + + systems = tracefs_event_systems(NULL); + if (systems) { + for (i = 0; systems[i]; i++) { + events = tracefs_system_events(NULL, systems[i]); + if (!events) + continue; + for (j = 0; events[j]; j++) { + file = tracefs_event_get_file(instance, systems[i], + events[j], "filter"); + write_file(file, "0", O_WRONLY | O_TRUNC); + tracefs_put_tracing_file(file); + + file = tracefs_event_get_file(instance, systems[i], + events[j], "trigger"); + if (has_trigger < 0) { + /* Check if the kernel is configured with triggers */ + if (stat(file, &st) < 0) + has_trigger = 0; + else + has_trigger = 1; + } + if (has_trigger) + clear_trigger(file); + tracefs_put_tracing_file(file); + } + tracefs_list_free(events); + } + tracefs_list_free(systems); + } + + tracefs_instance_file_write(instance, "error_log", " "); + tracefs_instance_file_write(instance, "trace_clock", "local"); + tracefs_instance_file_write(instance, "set_event_pid", ""); + reset_cpu_mask(instance); + clear_func_filters(instance); + tracefs_instance_file_write(instance, "tracing_max_latency", "0"); + tracefs_trace_on(instance); +} diff --git a/src/tracefs-utils.c b/src/tracefs-utils.c index 9acf2ad..ef90677 100644 --- a/src/tracefs-utils.c +++ b/src/tracefs-utils.c @@ -319,6 +319,26 @@ void tracefs_put_tracing_file(char *name) free(name); } +/* The function is copied from trace-cmd */ +__hidden char *strstrip(char *str) +{ + char *s; + + if (!str) + return NULL; + + s = str + strlen(str) - 1; + while (s >= str && isspace(*s)) + s--; + s++; + *s = '\0'; + + for (s = str; *s && isspace(*s); s++) + ; + + return s; +} + __hidden int str_read_file(const char *file, char **buffer, bool warn) { char stbuf[BUFSIZ]; From patchwork Wed Apr 26 04:11:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Tzvetomir Stoyanov (VMware)" X-Patchwork-Id: 13224001 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88424C77B78 for ; Wed, 26 Apr 2023 04:11:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239034AbjDZELd (ORCPT ); Wed, 26 Apr 2023 00:11:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60152 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229537AbjDZELc (ORCPT ); Wed, 26 Apr 2023 00:11:32 -0400 Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [IPv6:2a00:1450:4864:20::32b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8209910E6 for ; Tue, 25 Apr 2023 21:11:30 -0700 (PDT) Received: by mail-wm1-x32b.google.com with SMTP id 5b1f17b1804b1-3f1950f5628so52966515e9.3 for ; Tue, 25 Apr 2023 21:11:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682482289; x=1685074289; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=wzYybfXXAZ5J1gON+2zGMGIU9NemBBzTFdv7qTXZpWw=; b=Tsc/GRPlgC6RlywaJNCX5ilYmGUFuRVWphr6VyR4hiEmxOzOMHDm8NRpYTNGnkBrFa qhGO2+D4t9Sfjwsm1j8fJTpRLJELfW7NNtDfXznbmDrzk/WLEY6NHikzY19q1jsjYj4I VSsJAHaH+APrbkgi1FcfLeJCxYLReYCsl8ZZES1TBkHflj70VQm5DR6Gn9egeXD4ElBx WMiMCSNOARrn2s+pKHEFOExuk9wpVxaRarJmSnk3XTw93DpMJrVgVVQtB4Uv+yAtuvOm HsT/MTyVAcUc5utT1gX13xMTaww7P1iT/hiHAHUW0uLu68biaRk9TizwmzvRpK5Zyp2i +RVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682482289; x=1685074289; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wzYybfXXAZ5J1gON+2zGMGIU9NemBBzTFdv7qTXZpWw=; b=jFWAHvNXjlwwog4EJ1WMCRjRyPe8qk1ko9AWGbSFf46lPNpYM9zPyOi664h65nWMKA jBdlJKHK5jnpRiRRdvAAtAE72I771svMfjDXBQRvurzoKjJ4tTmhPBv3gM8D1T+fCXAe 2d9jTYshQF4ebVC+W5M35lexKCjdheKcDR5W5oZ9OCXy22aNasZ3zuwoRIKduEgimlJ+ hXRino76zkJBU2lKnqu+FVRO/9uy64iV+qpi59vzqVQhGUPSlhoX0nszEuufWPEWoL7V zA3wzfvr9Wiim+vWlzyMK1fMM10FDL5+H8Il33DbtUxzGfUssMBc2oxlnaUsv+dD3ILw 1Nwg== X-Gm-Message-State: AAQBX9dG+3I/4tWt/Sfh2KFQd1ZhVZTNi+ojQFdaCOieHEOzn+LN59Jt GQUd99ovB/hiD+6OgFEO9Lo= X-Google-Smtp-Source: AKy350YgFxmVNDQ7MikeS6snchCN5PxGrcQVp5tPLEjpKS1EwZ+o/4TIyhVj1H8aZ8xZeeDAdjylyA== X-Received: by 2002:adf:f845:0:b0:303:3880:9273 with SMTP id d5-20020adff845000000b0030338809273mr11260093wrq.17.1682482289057; Tue, 25 Apr 2023 21:11:29 -0700 (PDT) Received: from oberon.zico.biz (77-85-190-39.ip.btc-net.bg. [77.85.190.39]) by smtp.gmail.com with ESMTPSA id m5-20020a5d6a05000000b002f01e181c4asm14648107wru.5.2023.04.25.21.11.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Apr 2023 21:11:28 -0700 (PDT) From: "Tzvetomir Stoyanov (VMware)" To: rostedt@goodmis.org Cc: linux-trace-devel@vger.kernel.org Subject: [PATCH v2 2/3] libtracefs: Documentation for tracefs_instance_reset() Date: Wed, 26 Apr 2023 07:11:23 +0300 Message-Id: <20230426041124.69544-3-tz.stoyanov@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230426041124.69544-1-tz.stoyanov@gmail.com> References: <20230426041124.69544-1-tz.stoyanov@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org The newly introduced API tracefs_instance_reset() should be described in the tracefs man pages. Signed-off-by: Tzvetomir Stoyanov (VMware) --- Documentation/libtracefs-instances-manage.txt | 7 +++++-- Documentation/libtracefs.txt | 1 + 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/Documentation/libtracefs-instances-manage.txt b/Documentation/libtracefs-instances-manage.txt index c03a272..1e0735e 100644 --- a/Documentation/libtracefs-instances-manage.txt +++ b/Documentation/libtracefs-instances-manage.txt @@ -4,7 +4,7 @@ libtracefs(3) NAME ---- tracefs_instance_create, tracefs_instance_destroy, tracefs_instance_alloc, tracefs_instance_free, -tracefs_instance_is_new, tracefs_instances - Manage trace instances. +tracefs_instance_is_new, tracefs_instances, tracefs_instance_reset - Manage trace instances. SYNOPSIS -------- @@ -18,6 +18,7 @@ struct tracefs_instance pass:[*]*tracefs_instance_alloc*(const char pass:[*]_tra void *tracefs_instance_free*(struct tracefs_instance pass:[*]_instance_); bool *tracefs_instance_is_new*(struct tracefs_instance pass:[*]_instance_); char pass:[**]*tracefs_instances*(const char pass:[*]_regex_); +void *tracefs_instance_reset*(struct tracefs_instance pass:[*]_instance_); -- @@ -60,6 +61,8 @@ it will match all instances that exist. The returned list must be freed with *tracefs_list_free*(3). Note, if no instances are found an empty list is returned and that too needs to be free with *tracefs_list_free*(3). +The *tracefs_instance_reset*() function resets the given _instance_ to its default state. + RETURN VALUE ------------ The *tracefs_instance_create()* and *tracefs_instance_alloc()* functions return a pointer to @@ -106,7 +109,7 @@ struct tracefs_instance *inst = tracefs_instance_alloc(NULL, "bar"); } ... - + tracefs_instance_reset(inst); tracefs_instance_free(inst); -- FILES diff --git a/Documentation/libtracefs.txt b/Documentation/libtracefs.txt index c3f448d..052e1c9 100644 --- a/Documentation/libtracefs.txt +++ b/Documentation/libtracefs.txt @@ -25,6 +25,7 @@ Trace instances: struct tracefs_instance pass:[*]*tracefs_instance_alloc*(const char pass:[*]_tracing_dir_, const char pass:[*]_name_); void *tracefs_instance_free*(struct tracefs_instance pass:[*]_instance_); char pass:[**]*tracefs_instances*(const char pass:[*]_regex_); + void *tracefs_instance_reset*(struct tracefs_instance pass:[*]_instance_); bool *tracefs_instance_is_new*(struct tracefs_instance pass:[*]_instance_); bool *tracefs_file_exists*(struct tracefs_instance pass:[*]_instance_, char pass:[*]_name_); bool *tracefs_dir_exists*(struct tracefs_instance pass:[*]_instance_, char pass:[*]_name_); From patchwork Wed Apr 26 04:11:24 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Tzvetomir Stoyanov (VMware)" X-Patchwork-Id: 13224002 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 622D4C77B7C for ; Wed, 26 Apr 2023 04:11:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229537AbjDZELf (ORCPT ); Wed, 26 Apr 2023 00:11:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60160 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239173AbjDZELd (ORCPT ); Wed, 26 Apr 2023 00:11:33 -0400 Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BD34783 for ; Tue, 25 Apr 2023 21:11:31 -0700 (PDT) Received: by mail-wr1-x42f.google.com with SMTP id ffacd0b85a97d-304935cc79bso1138161f8f.2 for ; Tue, 25 Apr 2023 21:11:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682482290; x=1685074290; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=TCKOPaMP4q9P/VNYovFPbb/y5w02ooNr3lYu2DBlEqk=; b=ezh6YMBmeDx8nddZOYcXz4O41QtlncTQl8DPuWPhERj+Q55t6lv0Le5AjaSWl7RMb+ IAWhOXNaOPSEVO4TDGQqD/WgUl6KcTzxYidU8bJIEPjJzQOL9qQTfmg1oAaH+tSbME3q N/7DfypKrdYRYa3PUKVGd+1kFCdkkcFqw41ZInQ2fBCf5pS/7mXK78aL40NXKtJ8fGzi lbkbiZ6WXzXcGJYcSTug2TZSB5xh+Rwx7v4K1AMFS8cbgE3sk2tPfixUK2duH+etwMZ7 v6EEti6nXKd8uR0oVa6dSV9R5tJLI2WR5SIxEI+Te/jy4VPD4JnzhvU541htxKd5SRyZ 4bbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682482290; x=1685074290; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TCKOPaMP4q9P/VNYovFPbb/y5w02ooNr3lYu2DBlEqk=; b=inn3CWs0cEaIYAv3fX4gEKh/ZlE9DFQvq8ibHfg5v/HJTDCSm2wko+kdoYz3Y7ETSr LTTXVyDC1rIbt5JY+MwpDIGVwJDs9nRXznh63PtIDYY2zI9vUaI7VORSZzr9F8NzmYza Ph8c/wONb97c8et42RG2GoAETQChs1CoGHxVKV5KrsGOY3U+DkMKUpOzJ/ouXdxlWqyF sglIrce6jtH3Xf1hoJK+HBsA5UzMuiyu253ELy5XMRqCAmmxSqAJJFb2MxvvsWq5uhtu KRCMMfdXSr8pWi16xcbkRASkzjIqUDbPckt6jCbxF5aicjexC1ay3zGshmaOb2w8sdBE 7x9g== X-Gm-Message-State: AAQBX9dov0Vyv7vsKtAaSjW4PA1hWhRdmrPI7wgV3tn8Y+tye4tzwzsy yoZtF40adAbINatJJfbtu/mxVpHJYcmthw== X-Google-Smtp-Source: AKy350YAHvunf6DLXziOQaDOrlXXHkthy88bSejNs8UkYFEsQZaEdMAa8kvij6WHOdZGGrxampqUSg== X-Received: by 2002:a5d:5381:0:b0:304:794c:1534 with SMTP id d1-20020a5d5381000000b00304794c1534mr7158751wrv.4.1682482289915; Tue, 25 Apr 2023 21:11:29 -0700 (PDT) Received: from oberon.zico.biz (77-85-190-39.ip.btc-net.bg. [77.85.190.39]) by smtp.gmail.com with ESMTPSA id m5-20020a5d6a05000000b002f01e181c4asm14648107wru.5.2023.04.25.21.11.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Apr 2023 21:11:29 -0700 (PDT) From: "Tzvetomir Stoyanov (VMware)" To: rostedt@goodmis.org Cc: linux-trace-devel@vger.kernel.org Subject: [PATCH v2 3/3] libtracefs: Unit test for tracefs_instance_reset() Date: Wed, 26 Apr 2023 07:11:24 +0300 Message-Id: <20230426041124.69544-4-tz.stoyanov@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230426041124.69544-1-tz.stoyanov@gmail.com> References: <20230426041124.69544-1-tz.stoyanov@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org The logic of the tracefs_instance_reset() is complex and should be covered by the unit tests of the tracefs library. Signed-off-by: Tzvetomir Stoyanov (VMware) --- utest/tracefs-utest.c | 183 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 183 insertions(+) diff --git a/utest/tracefs-utest.c b/utest/tracefs-utest.c index e0e3c07..47f65cb 100644 --- a/utest/tracefs-utest.c +++ b/utest/tracefs-utest.c @@ -1618,6 +1618,187 @@ static void test_instance_file(void) free(inst_dir); } +static bool test_check_file_content(struct tracefs_instance *instance, char *file, + char *content, bool full_match, bool ignore_comments) +{ + char *save = NULL; + char *buf, *line; + bool ret = false; + int len; + + if (!tracefs_file_exists(instance, file)) + return false; + + buf = tracefs_instance_file_read(instance, file, NULL); + if (strlen(content) == 0) { + /* check for empty file */ + if (!buf) + return true; + if (!ignore_comments) { + if (strlen(buf) > 0) + goto out; + } else { + line = strtok_r(buf, "\n", &save); + while (line) { + if (line[0] != '#') + goto out; + line = strtok_r(NULL, "\n", &save); + } + } + } else { + if (!buf || strlen(buf) < 1) + return false; + if (full_match) { + /* strip the newline */ + len = strlen(buf) - 1; + while (buf[len] == '\n' || buf[len] == '\r') { + buf[len] = '\0'; + len = strlen(buf) - 1; + if (len < 0) + goto out; + } + if (strcmp(buf, content)) + goto out; + } else { + if (!strstr(buf, content)) + goto out; + } + } + + ret = true; +out: + free(buf); + return ret; +} + +static bool test_check_event_file_content(struct tracefs_instance *instance, + char *system, char *event, char *file, + char *content, bool full_match, bool ignore_comments) +{ + char *efile; + int ret; + + ret = asprintf(&efile, "events/%s/%s/%s", system, event, file); + if (ret <= 0) + return false; + ret = test_check_file_content(instance, efile, content, full_match, ignore_comments); + free(efile); + return ret; +} + +static bool check_cpu_mask(struct tracefs_instance *instance) +{ + int cpus = sysconf(_SC_NPROCESSORS_CONF); + int fullwords = (cpus - 1) / 32; + int bits = (cpus - 1) % 32 + 1; + int len = (fullwords + 1) * 9; + char buf[len + 1]; + + buf[0] = '\0'; + sprintf(buf, "%x", (unsigned int)((1ULL << bits) - 1)); + while (fullwords-- > 0) + strcat(buf, ",ffffffff"); + + return test_check_file_content(instance, "tracing_cpumask", buf, true, false); +} + +static bool test_instance_check_default_state(struct tracefs_instance *instance) +{ + char **systems; + char **events; + int i, j; + int ok; + + if (tracefs_trace_is_on(instance) != 1) + return false; + if (!test_check_file_content(instance, "current_tracer", "nop", true, false)) + return false; + if (!test_check_file_content(instance, "events/enable", "0", true, false)) + return false; + if (!test_check_file_content(instance, "set_ftrace_pid", "no pid", true, false)) + return false; + if (!test_check_file_content(instance, "trace", "", true, true)) + return false; + if (!test_check_file_content(instance, "error_log", "", true, false)) + return false; + if (!test_check_file_content(instance, "trace_clock", "[local]", false, false)) + return false; + if (!test_check_file_content(instance, "set_event_pid", "", true, false)) + return false; + if (!test_check_file_content(instance, "tracing_max_latency", "0", true, false)) + return false; + if (!test_check_file_content(instance, "set_ftrace_filter", "", true, true)) + return false; + if (!test_check_file_content(instance, "set_ftrace_notrace", "", true, true)) + return false; + if (!check_cpu_mask(instance)) + return false; + + ok = 1; + systems = tracefs_event_systems(NULL); + if (systems) { + for (i = 0; systems[i]; i++) { + events = tracefs_system_events(NULL, systems[i]); + if (!events) + continue; + for (j = 0; events[j]; j++) { + if (!test_check_event_file_content(instance, systems[i], events[j], + "enable", "0", true, false)) + break; + if (!test_check_event_file_content(instance, systems[i], events[j], + "filter", "none", true, false)) + break; + if (!test_check_event_file_content(instance, systems[i], events[j], + "trigger", "", true, true)) + break; + } + if (events[j]) + ok = 0; + tracefs_list_free(events); + if (!ok) + return false; + } + tracefs_list_free(systems); + } + + return true; +} + +static void test_instance_reset(void) +{ + struct tracefs_instance *instance = NULL; + const char *name = get_rand_str(); + + CU_TEST(tracefs_instance_exists(name) == false); + instance = tracefs_instance_create(name); + CU_TEST(instance != NULL); + + CU_TEST(test_instance_check_default_state(instance) == true); + + CU_TEST(tracefs_tracer_set(instance, TRACEFS_TRACER_HWLAT) == 0); + CU_TEST(tracefs_event_enable(instance, "bridge", "fdb_delete") == 0); + CU_TEST(tracefs_instance_file_write(instance, "set_ftrace_pid", "5") > 0); + CU_TEST(tracefs_instance_file_write(instance, "trace_clock", "global") > 0); + CU_TEST(tracefs_instance_file_write(instance, "set_event_pid", "5") > 0); + CU_TEST(tracefs_instance_file_write(instance, "set_ftrace_filter", + "schedule:stacktrace") > 0); + CU_TEST(tracefs_instance_file_write(instance, "set_ftrace_notrace", + "schedule:stacktrace") > 0); + CU_TEST(tracefs_instance_file_write(instance, "tracing_cpumask", "0f") > 0); + CU_TEST(tracefs_instance_file_write(instance, "events/syscalls/sys_exit_read/trigger", + "enable_event:kmem:kmalloc:1") > 0); + CU_TEST(tracefs_instance_file_write(instance, "events/bridge/fdb_delete/filter", + "common_pid == 5") > 0); + + CU_TEST(test_instance_check_default_state(instance) == false); + + tracefs_instance_reset(instance); + CU_TEST(test_instance_check_default_state(instance) == true); + + CU_TEST(tracefs_instance_destroy(instance) == 0); + tracefs_instance_free(instance); +} + static bool check_fd_name(int fd, const char *dir, const char *name) { char link[PATH_MAX + 1]; @@ -2354,6 +2535,8 @@ void test_tracefs_lib(void) test_file_fd); CU_add_test(suite, "instance file descriptor", test_instance_file); + CU_add_test(suite, "instance reset", + test_instance_reset); CU_add_test(suite, "systems and events APIs", test_system_event); CU_add_test(suite, "tracefs_iterate_raw_events API",