From patchwork Fri May 5 00:19:46 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Palmer Dabbelt X-Patchwork-Id: 13231925 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D759EC77B73 for ; Fri, 5 May 2023 00:21:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:To:From:Cc: Content-Transfer-Encoding:MIME-Version:Message-Id:Date:Subject:Reply-To: Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=8TmpvJbU96K5mWAE+i9LXk7p3PZGa9UIfo8DUIyUZ0c=; b=C2zgVozD9Byts4 hMzx3oeiA9Fkz0977Nu07t1qwyPHeryUy1iwrsFcWRYtllaizs2EcpG0c0BNY0stbsDJM4oPxUTXm yaEfXfaa4aMl3HOW/pJmix6LpAgafnlTFrbLr4wbYGk9pbvz039Lgx5FMfHUWn9Ft+4SR87MVqxT5 S2rmGNpzVHX+uwmn446V2zPMzzcuckiwq2HM/9AGgDwNT8zhS96kknLx7YyMrrXMG42nKEGx4i2iq x0aOtptucVHLMWZrvoIz8iq0t2rjG6An10EpXU9tMHMN9vBY7UdhiJqNtnqeI2limzLPXwcUlfcpm nOoQUeDMgIR1rVCF5UJw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pujBw-009Nqs-1p; Fri, 05 May 2023 00:20:56 +0000 Received: from mail-pj1-x1034.google.com ([2607:f8b0:4864:20::1034]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pujBs-009NoS-12 for linux-mediatek@lists.infradead.org; Fri, 05 May 2023 00:20:55 +0000 Received: by mail-pj1-x1034.google.com with SMTP id 98e67ed59e1d1-24e015fcf3dso910560a91.3 for ; Thu, 04 May 2023 17:20:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20221208.gappssmtp.com; s=20221208; t=1683246048; x=1685838048; h=to:from:cc:content-transfer-encoding:mime-version:message-id:date :subject:from:to:cc:subject:date:message-id:reply-to; bh=8TmpvJbU96K5mWAE+i9LXk7p3PZGa9UIfo8DUIyUZ0c=; b=LSbtL8+iwnX5GqWaGBkCj5rkG6Gk0y6hZi+1w189U0O1tCpGD2Jutew6l7t00+dHHM pmmTo2/kAT2zb4bZQ0AjNDI6QlsMybGTy8m+4VKZQG3FPpbhOR4GwsQYHTo1JSrYTtSq j1toePpqa6F4s3B12xkrFCc+UiRr62QzyiMy9O0juqjTlObi9W6dP4l8w6PcYjf+DcMI DDloLYjO69NWdgdFxg9r4fWhltlDq3NNHeRGUSiHau4SwNxHUXaUbQ/RXnd8RenvO0e4 Hh5VRijo3++skLzX7LkAV7l2JC2q4j27oeaQzVzEl4iSKl9g7maZbyXCp/JzF7u1gxmZ 9RwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683246048; x=1685838048; h=to:from:cc:content-transfer-encoding:mime-version:message-id:date :subject:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=8TmpvJbU96K5mWAE+i9LXk7p3PZGa9UIfo8DUIyUZ0c=; b=XxqBuN3o5XG57bLVp03gPdczIoPuXD4up5t6bNuCk3MoSf21pZb6L9DI4V6shyX6dC 1dj/mo8vSKv033YtkrvlV4Tm31Z+BgAZWpDyAY+4X9v3epgU7cpq1GPUf5VcZg7IAQM4 iPWw7FjMuT1VJWHnNZoLP207dCKnTAc6Hp9tR3yLp0JTNM3qfcCyKeFTRyt0Q1ODuusL DpKRG9zRJCQJ6/LfH7GiqbN627R3ip+8nSvkqFwMCfy8MrWL4dARGnDBNF9iHWQlxCf8 h9cboYAieUoluZrLlKUmrft7C2ATOxslJIVOatabGflbn6e6MDC8lS2tfP+hlPdMGVTa KPiA== X-Gm-Message-State: AC+VfDy+ip+bYFfz4UWxC1wU+wkRMMxgOkzLHHfFtlSCLOfpXhtXRtQk ZfTEufoFGKG9Z2mCCuObMTI45Q== X-Google-Smtp-Source: ACHHUZ43/6VUqC/4H/Fyb8yXxZtcJhQwJ+Pf66SFGn86RioprdSlGVfrxR7XKatPpG2zpuh26E5OqA== X-Received: by 2002:a17:90b:3e83:b0:24d:dc79:5901 with SMTP id rj3-20020a17090b3e8300b0024ddc795901mr3994645pjb.26.1683246047965; Thu, 04 May 2023 17:20:47 -0700 (PDT) Received: from localhost ([135.180.227.0]) by smtp.gmail.com with ESMTPSA id cq2-20020a17090af98200b002470b9503desm3659179pjb.55.2023.05.04.17.20.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 May 2023 17:20:47 -0700 (PDT) Subject: [PATCH] phy: mediatek: Remove unusued ret and check Date: Thu, 4 May 2023 17:19:46 -0700 Message-Id: <20230505001945.10179-1-palmer@rivosinc.com> X-Mailer: git-send-email 2.40.0 MIME-Version: 1.0 Cc: chunkuang.hu@kernel.org, p.zabel@pengutronix.de, chunfeng.yun@mediatek.com, kishon@kernel.org, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, linux@rivosinc.com, Palmer Dabbelt From: Palmer Dabbelt To: vkoul@kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230504_172052_356997_7B5E754D X-CRM114-Status: GOOD ( 12.36 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org From: Palmer Dabbelt This trips up a maybe-uninitialized warning, but it's actually just not used. Signed-off-by: Palmer Dabbelt --- I just stumbled into this one when trying to test Linus' master. I'm not sure it's a sane fix, but I'm not using the driver. No rush no my end, I'll just keep the fix around in my local tree for now. --- drivers/phy/mediatek/phy-mtk-hdmi-mt8195.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/phy/mediatek/phy-mtk-hdmi-mt8195.c b/drivers/phy/mediatek/phy-mtk-hdmi-mt8195.c index abfc077fb0a8..3fc0913ec73b 100644 --- a/drivers/phy/mediatek/phy-mtk-hdmi-mt8195.c +++ b/drivers/phy/mediatek/phy-mtk-hdmi-mt8195.c @@ -213,7 +213,7 @@ static int mtk_hdmi_pll_calc(struct mtk_hdmi_phy *hdmi_phy, struct clk_hw *hw, u64 tmds_clk, pixel_clk, da_hdmitx21_ref_ck, ns_hdmipll_ck, pcw; u8 txpredivs[4] = { 2, 4, 6, 12 }; u32 fbkdiv_low; - int i, ret; + int i; pixel_clk = rate; tmds_clk = pixel_clk; @@ -295,8 +295,6 @@ static int mtk_hdmi_pll_calc(struct mtk_hdmi_phy *hdmi_phy, struct clk_hw *hw, mtk_hdmi_pll_set_hw(hw, PLL_PREDIV, fbkdiv_high, fbkdiv_low, PLL_FBKDIV_HS3, posdiv1, posdiv2, txprediv, txposdiv, digital_div); - if (ret) - return -EINVAL; return 0; }