From patchwork Tue May 9 15:24:25 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Minwoo Im X-Patchwork-Id: 13235886 Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 57C1517FEE for ; Tue, 9 May 2023 15:24:52 +0000 (UTC) Received: by mail-pf1-f182.google.com with SMTP id d2e1a72fcca58-6439b410679so3752271b3a.0 for ; Tue, 09 May 2023 08:24:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683645892; x=1686237892; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Vyr+apyl4rf0JIzVOh3eQ3ozl2SeH9P0a8gHOxOKkIs=; b=jH+ZIQdAHDND6cvO/qCI04ZDNBlOTIXP5ufUkp/H2r8JTB95muW+mvfmPxAq+J3g1n G8u7Y48aBPQPezNhg5fsCMXtqRg5nUPf6tUcvYj2kRR54Ny4zzhTZ8MM0s8DYL0ry//A 1dP3baRphA7Yb5tXIjHDy3l56xalgio9oCuzLVewc/FvsfbRC6GVLrda9cvKFxX+kR3E Rklhzr8LjnNhOVhFv2jgNOx/Zi7hsqrm5Jbfs08fYRsOOiLfE1zRH1Y7y+KAwhH6teJ5 g6iQ5FA42x10lYwY3h0T1qUuRnUKHjpl7egIjM1eAZ2QqFRSOhbKZb4LpI+DSEQB1TOj v6Yg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683645892; x=1686237892; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Vyr+apyl4rf0JIzVOh3eQ3ozl2SeH9P0a8gHOxOKkIs=; b=Psejg4Q9QtzTgQaV21NP6ZINb74Nk9FNkOPW1Tj6/bSzQoaVNiQLszf4DAUC78kitQ gsLCvuCZ6HZyg8658CzuheirdBkCAXmUfgEnBDTqXwFuh6I0oIOnRHgRp0BQFJxFbfNe QafEyz1qwZs60qJy27ZjcYFjEn8KS8/Bo04wXjF9T2bGvz3AmarSDG0UJndUYe1yGZsV h/G/tOrWo4QAXr79pnveadb/RMD4gNlgH+5T0Ze0z3rL0sLjy0LoXxWOzYz0f9Z57NDM k5lLu+6ml587lPwAInwsM3SJcaJaAbu5SzP7F4d2STSklDPWzEBWl+d4jfvI4/ul6I06 gtww== X-Gm-Message-State: AC+VfDzK0aOnBc8JIRL0PAqpKO66qxcQVHcHtxHhyAKqS1m4Pp5GARdV FLRmo1sZpyF/p2hcjM0AiSM= X-Google-Smtp-Source: ACHHUZ4OLUMIpz/C9s5AvMa2qC8uAizriCj+aiq/qyh9FUJg+ndTLjWXS291fjHOp+/jIvPRL7BF1w== X-Received: by 2002:a05:6a00:16c4:b0:643:9dcd:abba with SMTP id l4-20020a056a0016c400b006439dcdabbamr21619366pfc.29.1683645891703; Tue, 09 May 2023 08:24:51 -0700 (PDT) Received: from localhost ([1.230.133.98]) by smtp.gmail.com with ESMTPSA id s4-20020a62e704000000b006414b2c9efasm1894351pfh.123.2023.05.09.08.24.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 May 2023 08:24:51 -0700 (PDT) From: Minwoo Im To: linux-cxl@vger.kernel.org, nvdimm@lists.linux.dev Cc: Dave Jiang , Dan Williams , Vishal Verma , Minwoo Im Subject: [ndctl PATCH 1/3] cxl/list: Fix typo in cxl-list documentation Date: Wed, 10 May 2023 00:24:25 +0900 Message-Id: <20230509152427.6920-2-minwoo.im.dev@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230509152427.6920-1-minwoo.im.dev@gmail.com> References: <20230509152427.6920-1-minwoo.im.dev@gmail.com> Precedence: bulk X-Mailing-List: nvdimm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 s/the returned the returned object/the returned object s/ellided/elided s/hierararchy/hierarchy s/specifed/specified s/identidier/identifier s/scenerios/scenarios Signed-off-by: Minwoo Im Reviewed-by: Dave Jiang --- Documentation/cxl/cxl-list.txt | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/Documentation/cxl/cxl-list.txt b/Documentation/cxl/cxl-list.txt index c64d65d3ffbe..838de4086678 100644 --- a/Documentation/cxl/cxl-list.txt +++ b/Documentation/cxl/cxl-list.txt @@ -18,9 +18,9 @@ instances along with some of their major attributes. Options can be specified to limit the output to specific objects. When a single object type is specified the return json object is an array of just those objects, when multiple objects types are specified the -returned the returned object may be an array of arrays with the inner -array named for the given object type. The top-level arrays are ellided -when the objects can nest under a higher object-type in the hierararchy. +returned object may be an array of arrays with the inner +array named for the given object type. The top-level arrays are elided +when the objects can nest under a higher object-type in the hierarchy. The potential top-level array names and their nesting properties are: "anon memdevs":: (disabled memory devices) do not nest @@ -34,7 +34,7 @@ The potential top-level array names and their nesting properties are: "endpoint decoders":: nest under endpoints, or ports (if endpoints are not emitted) or buses (if endpoints and ports are not emitted) -Filters can by specifed as either a single identidier, a space separated +Filters can be specified as either a single identifier, a space separated quoted string, or a comma separated list. When multiple filter identifiers are specified within a filter string, like "-m mem0,mem1,mem2", they are combined as an 'OR' filter. When multiple @@ -263,7 +263,7 @@ OPTIONS --buses:: Include 'bus' / CXL root object(s) in the listing. Typically, on ACPI systems the bus object is a singleton associated with the ACPI0017 - device, but there are test scenerios where there may be multiple CXL + device, but there are test scenarios where there may be multiple CXL memory hierarchies. ---- # cxl list -B From patchwork Tue May 9 15:24:26 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Minwoo Im X-Patchwork-Id: 13235887 Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 81C0617FEE for ; Tue, 9 May 2023 15:24:57 +0000 (UTC) Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-643a6f993a7so3275295b3a.1 for ; Tue, 09 May 2023 08:24:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683645897; x=1686237897; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=rhv/anInD/+eHNMylLX7tViymCuVD4zqzVYkaDHoG8E=; b=OX4n0XS+zPrgpeUkeUYDhcD7uGudBKnxepmYKdzyk3GZy+rRo6uTzLvTFqAwVaFjaT CEIKg7lqkkwO8m+tg82q0u49Ah2Fm41KcbCwfAMDVdXFcr4xNNvcfU6I2DHxjBIJNgE3 CPQI7HIG8TsUB6nVSu1N23vk+yp4AJANq5lyxGVrm9m//aoyrhMxhdaCn11KQs3A9/v3 dk73rZ9zz4/YNNp+c3ApH8SjlCZJgdb/yf9NGYf0kYbb7IA/T+W31laYieNRTu+IJie/ 6To+rH4bSE+MErJ+bq+sm8rh6HmR+LpcrymbgxgfUcRoTztLeeNXd1VJpINKO84Peowr 4qaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683645897; x=1686237897; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rhv/anInD/+eHNMylLX7tViymCuVD4zqzVYkaDHoG8E=; b=SvhOoQbjP/oqBfa8hgf2kchVxwXRtKuuOB1zHkwlztRdtMRA67NlR4gnjCFhvUgK9X VArWYb4baIa5inFA4VKeHqQUwvJ+ZMKLB+RdESX6Tc/ceXMB4oqPOVbbtXUadDtlBdMo vrwEcOijnW2dtFLTkqFr/8M+tWW8ELUiGPsVbWxjGvH7ZE/xwcQO3PRoChGZozO4PwSm pH+/UX+3GSqMGz+KWxW8fOdbAid7AV7wVSfjoXMN/aZkbQy1RW/xnwgwBCp55E+emwQ5 s3hS7EQXulnMfsq9TrLQYPTiJC0bPxfUaJyhzEM41vjPlIsjHb1f7DPxMY6MMwN1kzjc ksew== X-Gm-Message-State: AC+VfDxqoKQxjefljRvmsBYlFk+/vWZGY4/FX5BM0Ygr6d3UK5uwkQcb VCw1c24PKl4QfSOlFs9ngCE= X-Google-Smtp-Source: ACHHUZ43P8qZFo2/PVS5RGVoJgFKAVDU4EJBqELFbTlBc/dA/UsNDplL8j6RDfP5jyr5lYGZbd8M9Q== X-Received: by 2002:a05:6a20:54a2:b0:100:8592:9a7f with SMTP id i34-20020a056a2054a200b0010085929a7fmr9309140pzk.45.1683645896856; Tue, 09 May 2023 08:24:56 -0700 (PDT) Received: from localhost ([1.230.133.98]) by smtp.gmail.com with ESMTPSA id 63-20020a630142000000b0051303d3e3c5sm1508556pgb.42.2023.05.09.08.24.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 May 2023 08:24:56 -0700 (PDT) From: Minwoo Im To: linux-cxl@vger.kernel.org, nvdimm@lists.linux.dev Cc: Dave Jiang , Dan Williams , Vishal Verma , Minwoo Im Subject: [ndctl PATCH 2/3] cxl: region: remove redundant func name from error Date: Wed, 10 May 2023 00:24:26 +0900 Message-Id: <20230509152427.6920-3-minwoo.im.dev@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230509152427.6920-1-minwoo.im.dev@gmail.com> References: <20230509152427.6920-1-minwoo.im.dev@gmail.com> Precedence: bulk X-Mailing-List: nvdimm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 If user does not provide `-s, --size` option and there's no ep_min_size configured, it prints error log like the following. This patch removes redundant repeated function name from the log. Before: root@vm:~/work# cxl create-region -m -d decoder0.0 -w 1 -g 1024 mem0 cxl region: create_region: create_region: unable to determine region size cxl region: cmd_create_region: created 0 regions After: root@vm:~/work# cxl create-region -m -d decoder0.0 -w 1 -g 1024 mem0 cxl region: create_region: unable to determine region size cxl region: cmd_create_region: created 0 regions Signed-off-by: Minwoo Im Reviewed-by: Dave Jiang --- cxl/region.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/cxl/region.c b/cxl/region.c index 07ce4a319fd0..71f152d9e5a5 100644 --- a/cxl/region.c +++ b/cxl/region.c @@ -607,7 +607,8 @@ static int create_region(struct cxl_ctx *ctx, int *count, } else if (p->ep_min_size) { size = p->ep_min_size * p->ways; } else { - log_err(&rl, "%s: unable to determine region size\n", __func__); + log_err(&rl, "unable to determine region size\n"); + return -ENXIO; } max_extent = cxl_decoder_get_max_available_extent(p->root_decoder); From patchwork Tue May 9 15:24:27 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Minwoo Im X-Patchwork-Id: 13235888 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D6B847499 for ; Tue, 9 May 2023 15:25:00 +0000 (UTC) Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-1ab1b79d3a7so41430895ad.3 for ; Tue, 09 May 2023 08:25:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683645900; x=1686237900; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=TX3aP/5DthuPCekKZDcqCd6crocwyObcAs1lRnioK90=; b=F5MUoBUE5u7DgsnADrU5ePszG0mAePgoJ0z1HVnRECMkTIO8vxBhxasZ7uC203/mk0 eJophLn+d41ivCp0VZ0mekoyPYXrbfTTw98yEMc/534O0JJlQW4gNfsE2q4oYoZHeU82 +2gmUQeRDsxRBLXFtwlhKorwSPaPybs0rsGVaurZlbo9H+KL3sNzcScM65Zr2IuOgu7q L5w5GctN9NyaN9IIvUfAOZ1Gf6kxwm8QP9Ddpp+yUlANGtmtA/CWkpEKGfbaZbym5WJD t1nP/ZL8eIMtxsK5qCXOl9MkFjSQcRp/lHvOC4Bmfna6HzMjLdiQP0vtMJlrgzALUYZM r7cA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683645900; x=1686237900; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TX3aP/5DthuPCekKZDcqCd6crocwyObcAs1lRnioK90=; b=YlCCCUxdPVniyOTRFeC6fqxzfEgr2kPcoLUPMM+cJdOnpcP+HMvZXEsvg5L6vAaHui HJkOtV/0Jm/luDOAt2CXjLubBATuz9dxfKbi/dBJHneLRR7fJAn7UmLM3tC8ylxujsXB TbNgI1UGUk3nq6KukUmpXtuheSdRkSe6q4z+9zWrg4wVbvKHzUWPJLFOG/RpX+x+Pgwt YPc+q80f5fgdKoGQXb6Ps4hDLJDcBcSQelVMfJfQ7N96xWYg1/4wqO+QXeJskn3HmmZw 8NfhlE/OQdVHfg7L+/u4t+WYrWQAgLJgUq4kfcSuj66PjPxwhe5i8igvLv8/ZwGSroZL CV+Q== X-Gm-Message-State: AC+VfDyYEmef9CJr95laXIzOtD0jsdfKjnP4hV0Figxk4pHrm+IInaxj l6PVFlEhqoFF10I9qA048Bo= X-Google-Smtp-Source: ACHHUZ7qgn7AWYXmlGL/WnKq4Wk7cwfgJorb5hF6+xT0HWc/i8XXrOIez/uRh4nQJe7Z+IERMa3vbA== X-Received: by 2002:a17:903:2308:b0:19d:778:ff5 with SMTP id d8-20020a170903230800b0019d07780ff5mr18797505plh.15.1683645900506; Tue, 09 May 2023 08:25:00 -0700 (PDT) Received: from localhost ([1.230.133.98]) by smtp.gmail.com with ESMTPSA id j9-20020a17090276c900b001aaeaa27dd5sm1697344plt.252.2023.05.09.08.24.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 May 2023 08:25:00 -0700 (PDT) From: Minwoo Im To: linux-cxl@vger.kernel.org, nvdimm@lists.linux.dev Cc: Dave Jiang , Dan Williams , Vishal Verma , Minwoo Im Subject: [ndctl PATCH 3/3] cxl: fix changed function name in a comment Date: Wed, 10 May 2023 00:24:27 +0900 Message-Id: <20230509152427.6920-4-minwoo.im.dev@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230509152427.6920-1-minwoo.im.dev@gmail.com> References: <20230509152427.6920-1-minwoo.im.dev@gmail.com> Precedence: bulk X-Mailing-List: nvdimm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 cxl_memdev_target_find_decoder() has been renamed to cxl_memdev_find_decoder in Commit 21b089025178 ("cxl: add a 'create-region' command"). Fix function name in a comment. Signed-off-by: Minwoo Im Reviewed-by: Dave Jiang --- cxl/region.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cxl/region.c b/cxl/region.c index 71f152d9e5a5..45f0c6a3771c 100644 --- a/cxl/region.c +++ b/cxl/region.c @@ -676,7 +676,7 @@ static int create_region(struct cxl_ctx *ctx, int *count, } if (cxl_decoder_get_mode(ep_decoder) != p->mode) { /* - * The memdev_target_find_decoder() helper returns a free + * The cxl_memdev_find_decoder() helper returns a free * decoder whose size has been checked for 0. * Thus it is safe to change the mode here if needed. */