From patchwork Tue May 9 16:35:55 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Kumar, M Chetan" X-Patchwork-Id: 13235952 X-Patchwork-Delegate: kuba@kernel.org Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 395BEF9DD for ; Tue, 9 May 2023 16:36:49 +0000 (UTC) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4E96D10C8 for ; Tue, 9 May 2023 09:36:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1683650208; x=1715186208; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=zuljIzkfizdHuUsUAR0Oz/jiFbRdWXo8zoG65jNaFKE=; b=fOukSsk1Fl1KU91BdwF4J3T/VHWzWfk61M7r9W8Gg6AOgumNVpHYZcTe Z3B+rXGrEkk9Uar++82hWTV4J1Tfd3w49q2n5nSNZDLE6G04Rsynm0GDf KLzss9tKDFO199/TKynmCFmddGjRUPuPX/HK90Mdk4E2GU6Zb2ViJtvd2 zWKvtmQhSQwCMYy2aoQ1+xKnJ2fu8Qhf+uiaudAimGs/bj7yo3cWYB3ng AI5LvFfPdJXPCHYuPciSWThXzZ9kJBajzvTvDHRFECXNNGQ5ifQZ+lx+s MK5yN76BTZbYF5FvGlNVnOQBm5+7uyjDXSfYo3cOyQu3HE6HaJEWL+RHs A==; X-IronPort-AV: E=McAfee;i="6600,9927,10705"; a="339216833" X-IronPort-AV: E=Sophos;i="5.99,262,1677571200"; d="scan'208";a="339216833" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 May 2023 09:36:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10705"; a="823175900" X-IronPort-AV: E=Sophos;i="5.99,262,1677571200"; d="scan'208";a="823175900" Received: from bswcg4446240.iind.intel.com ([10.224.174.140]) by orsmga004.jf.intel.com with ESMTP; 09 May 2023 09:36:29 -0700 From: m.chetan.kumar@linux.intel.com To: netdev@vger.kernel.org Cc: kuba@kernel.org, davem@davemloft.net, johannes@sipsolutions.net, ryazanov.s.a@gmail.com, loic.poulain@linaro.org, linuxwwan@intel.com, m.chetan.kumar@intel.com, edumazet@google.com, pabeni@redhat.com, M Chetan Kumar Subject: [PATCH net-next 1/3] net: wwan: iosm: remove unused macro definition Date: Tue, 9 May 2023 22:05:55 +0530 Message-Id: <0697e811cb7f10b4fd8f99e66bda1329efdd3d1d.1683649868.git.m.chetan.kumar@linux.intel.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net X-Patchwork-Delegate: kuba@kernel.org From: M Chetan Kumar IOSM_IF_ID_PAYLOAD is defined but not used. Remove it to avoid unexpected usage. Signed-off-by: M Chetan Kumar Reviewed-by: Simon Horman --- drivers/net/wwan/iosm/iosm_ipc_wwan.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/wwan/iosm/iosm_ipc_wwan.c b/drivers/net/wwan/iosm/iosm_ipc_wwan.c index 4c9022a93e01..ff747fc79aaf 100644 --- a/drivers/net/wwan/iosm/iosm_ipc_wwan.c +++ b/drivers/net/wwan/iosm/iosm_ipc_wwan.c @@ -18,8 +18,6 @@ #define IOSM_IP_TYPE_IPV4 0x40 #define IOSM_IP_TYPE_IPV6 0x60 -#define IOSM_IF_ID_PAYLOAD 2 - /** * struct iosm_netdev_priv - netdev WWAN driver specific private data * @ipc_wwan: Pointer to iosm_wwan struct From patchwork Tue May 9 16:36:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Kumar, M Chetan" X-Patchwork-Id: 13235951 X-Patchwork-Delegate: kuba@kernel.org Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C4EAA1800B for ; Tue, 9 May 2023 16:36:48 +0000 (UTC) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CAC5EE77 for ; Tue, 9 May 2023 09:36:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1683650207; x=1715186207; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=Hni16i5Cv4v7UKEYgKZ9dvt/WKA0+SRGtrvmuKFM+mI=; b=XjmM28k71GLoY43X8bcxv5mr/Qr2y6EQCyJ/+c30qrOU4ZBSve+EtNI+ K7ACagj6CYFurMhxE3cnblI/NSpoSFx0afQhxYHHK8gmJyJ8OGytn7f3E ggQstOsTywO34ryhUqXLu4F4+sVI8IEHi5s31sjTEVrKL+jAxxpThoxgp B0RDYSo3X1pfSTQuUlTLdkCRzfNZye9vq0zy3OaxdbGH4AVI/nV9hXOc4 Lzd8uqrH3gPmGUTVDXiCYOA75nK1cBz1Saw4bYX2+GHBoc7UM5bXOXqsK xrDJU42bzdwNp3e9VbJGVovz17G3vn+EX0ES+02hqmAbuB1wHQAS7h1mI A==; X-IronPort-AV: E=McAfee;i="6600,9927,10705"; a="350015192" X-IronPort-AV: E=Sophos;i="5.99,262,1677571200"; d="scan'208";a="350015192" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 May 2023 09:36:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10705"; a="693046504" X-IronPort-AV: E=Sophos;i="5.99,262,1677571200"; d="scan'208";a="693046504" Received: from bswcg4446240.iind.intel.com ([10.224.174.140]) by orsmga007.jf.intel.com with ESMTP; 09 May 2023 09:36:44 -0700 From: m.chetan.kumar@linux.intel.com To: netdev@vger.kernel.org Cc: kuba@kernel.org, davem@davemloft.net, johannes@sipsolutions.net, ryazanov.s.a@gmail.com, loic.poulain@linaro.org, linuxwwan@intel.com, m.chetan.kumar@intel.com, edumazet@google.com, pabeni@redhat.com, M Chetan Kumar Subject: [PATCH net-next 2/3] net: wwan: iosm: remove unused enum definition Date: Tue, 9 May 2023 22:06:22 +0530 Message-Id: <8295a6138f13c686590ee4021384ee992f717408.1683649868.git.m.chetan.kumar@linux.intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <0697e811cb7f10b4fd8f99e66bda1329efdd3d1d.1683649868.git.m.chetan.kumar@linux.intel.com> References: <0697e811cb7f10b4fd8f99e66bda1329efdd3d1d.1683649868.git.m.chetan.kumar@linux.intel.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net X-Patchwork-Delegate: kuba@kernel.org From: M Chetan Kumar ipc_time_unit enum is defined but not used. Remove it to avoid unexpected usage. Signed-off-by: M Chetan Kumar Reviewed-by: Simon Horman --- drivers/net/wwan/iosm/iosm_ipc_imem.h | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/drivers/net/wwan/iosm/iosm_ipc_imem.h b/drivers/net/wwan/iosm/iosm_ipc_imem.h index e700dc8bfe0a..93d57aa7854a 100644 --- a/drivers/net/wwan/iosm/iosm_ipc_imem.h +++ b/drivers/net/wwan/iosm/iosm_ipc_imem.h @@ -140,17 +140,6 @@ enum ipc_channel_state { IMEM_CHANNEL_CLOSING, }; -/* Time Unit */ -enum ipc_time_unit { - IPC_SEC = 0, - IPC_MILLI_SEC = 1, - IPC_MICRO_SEC = 2, - IPC_NANO_SEC = 3, - IPC_PICO_SEC = 4, - IPC_FEMTO_SEC = 5, - IPC_ATTO_SEC = 6, -}; - /** * enum ipc_ctype - Enum defining supported channel type needed for control * /IP traffic. From patchwork Tue May 9 16:36:35 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Kumar, M Chetan" X-Patchwork-Id: 13235953 X-Patchwork-Delegate: kuba@kernel.org Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0DA0618018 for ; Tue, 9 May 2023 16:37:03 +0000 (UTC) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 01BB13AAE for ; Tue, 9 May 2023 09:37:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1683650222; x=1715186222; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=YFiT4bPCtuXxy6+RTYQDj3JE4QUOovgWV4z/WyuUFrk=; b=MY9WYF3sdsvgZ4ttuhOsbYdOAKT6xUuNsFCTCzJu3CKgr419yk3e676J i8W96g5RA+klikhDpJPdq7zJ9en5wZs2VxI3vSqECAVnQsDzrxMcYSPU8 KGzIPhTjyL0ysJAX6NZmZm4bT9sXR9WyQu3mo2TGAe6PV4h3QmPYNOlmg uIDtyOE8VUTzJOkQ4CQO/szd5ag4hqrrr7qjPI3yM3wfOG9BRepEql6tV 8cIwYd/DmTIP1OigfuMgMqfg71iuAghRq1Yzo0VAZz4NkOc8VW7elzDyk +6vwJCudDwcSrzmocbc8W3NwRV9X4SG8pZXNI3jw+KYSVBwtz9LJOey7q Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10705"; a="350015266" X-IronPort-AV: E=Sophos;i="5.99,262,1677571200"; d="scan'208";a="350015266" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 May 2023 09:37:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10705"; a="693046582" X-IronPort-AV: E=Sophos;i="5.99,262,1677571200"; d="scan'208";a="693046582" Received: from bswcg4446240.iind.intel.com ([10.224.174.140]) by orsmga007.jf.intel.com with ESMTP; 09 May 2023 09:36:57 -0700 From: m.chetan.kumar@linux.intel.com To: netdev@vger.kernel.org Cc: kuba@kernel.org, davem@davemloft.net, johannes@sipsolutions.net, ryazanov.s.a@gmail.com, loic.poulain@linaro.org, linuxwwan@intel.com, m.chetan.kumar@intel.com, edumazet@google.com, pabeni@redhat.com, M Chetan Kumar Subject: [PATCH net-next 3/3] net: wwan: iosm: clean up unused struct members Date: Tue, 9 May 2023 22:06:35 +0530 Message-Id: <92ee483d79dfc871ed7408da8fec60b395ff3a9c.1683649868.git.m.chetan.kumar@linux.intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <0697e811cb7f10b4fd8f99e66bda1329efdd3d1d.1683649868.git.m.chetan.kumar@linux.intel.com> References: <0697e811cb7f10b4fd8f99e66bda1329efdd3d1d.1683649868.git.m.chetan.kumar@linux.intel.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net X-Patchwork-Delegate: kuba@kernel.org From: M Chetan Kumar Below members are unused. - td_tag member defined in struct ipc_pipe. - adb_finish_timer & params defined in struct iosm_mux. Remove it to avoid unexpected usage. Signed-off-by: M Chetan Kumar Reviewed-by: Simon Horman --- drivers/net/wwan/iosm/iosm_ipc_imem.h | 2 -- drivers/net/wwan/iosm/iosm_ipc_mux.h | 4 ---- 2 files changed, 6 deletions(-) diff --git a/drivers/net/wwan/iosm/iosm_ipc_imem.h b/drivers/net/wwan/iosm/iosm_ipc_imem.h index 93d57aa7854a..5664ac507c90 100644 --- a/drivers/net/wwan/iosm/iosm_ipc_imem.h +++ b/drivers/net/wwan/iosm/iosm_ipc_imem.h @@ -193,7 +193,6 @@ enum ipc_hp_identifier { * @pipe_nr: Pipe identification number * @irq: Interrupt vector * @dir: Direction of data stream in pipe - * @td_tag: Unique tag of the buffer queued * @buf_size: Buffer size (in bytes) for preallocated * buffers (for DL pipes) * @nr_of_queued_entries: Aueued number of entries @@ -213,7 +212,6 @@ struct ipc_pipe { u32 pipe_nr; u32 irq; enum ipc_mem_pipe_dir dir; - u32 td_tag; u32 buf_size; u16 nr_of_queued_entries; u8 is_open:1; diff --git a/drivers/net/wwan/iosm/iosm_ipc_mux.h b/drivers/net/wwan/iosm/iosm_ipc_mux.h index 9968bb885c1f..17ca8d1f9397 100644 --- a/drivers/net/wwan/iosm/iosm_ipc_mux.h +++ b/drivers/net/wwan/iosm/iosm_ipc_mux.h @@ -333,9 +333,7 @@ struct mux_acb { * @wwan_q_offset: This will hold the offset of the given instance * Useful while passing or receiving packets from * wwan/imem layer. - * @adb_finish_timer: Timer for forcefully finishing the ADB * @acb_tx_sequence_nr: Sequence number for the ACB header. - * @params: user configurable parameters * @adb_tx_sequence_nr: Sequence number for ADB header * @acc_adb_size: Statistic data for logging * @acc_payload_size: Statistic data for logging @@ -367,9 +365,7 @@ struct iosm_mux { long long ul_data_pend_bytes; struct mux_acb acb; int wwan_q_offset; - struct hrtimer adb_finish_timer; u16 acb_tx_sequence_nr; - struct ipc_params *params; u16 adb_tx_sequence_nr; unsigned long long acc_adb_size; unsigned long long acc_payload_size;