From patchwork Wed May 10 14:20:45 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yann Dirson X-Patchwork-Id: 13236957 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3C74DC7EE23 for ; Wed, 10 May 2023 14:21:06 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.532846.829178 (Exim 4.92) (envelope-from ) id 1pwkgT-0005IV-Py; Wed, 10 May 2023 14:20:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 532846.829178; Wed, 10 May 2023 14:20:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pwkgT-0005IK-N0; Wed, 10 May 2023 14:20:49 +0000 Received: by outflank-mailman (input) for mailman id 532846; Wed, 10 May 2023 14:20:48 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pwkgS-0004iD-EI for xen-devel@lists.xenproject.org; Wed, 10 May 2023 14:20:48 +0000 Received: from mail145-2.atl61.mandrillapp.com (mail145-2.atl61.mandrillapp.com [198.2.145.2]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id dad8aec9-ef3d-11ed-b229-6b7b168915f2; Wed, 10 May 2023 16:20:47 +0200 (CEST) Received: from pmta06.mandrill.prod.atl01.rsglab.com (localhost [127.0.0.1]) by mail145-2.atl61.mandrillapp.com (Mailchimp) with ESMTP id 4QGcd956WjzQXlPFg for ; Wed, 10 May 2023 14:20:45 +0000 (GMT) Received: from [37.26.189.201] by mandrillapp.com id 744e931c24524562bfbf8de669d17973; Wed, 10 May 2023 14:20:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dad8aec9-ef3d-11ed-b229-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vates.fr; s=mandrill; t=1683728445; x=1683988945; i=yann.dirson@vates.fr; bh=zAC0Ae3ADV1q0oYr8YU1ywFE0/ZKiWQ1G1f22odEco4=; h=From:Subject:To:Cc:Message-Id:In-Reply-To:References:Feedback-ID: Date:MIME-Version:Content-Type:Content-Transfer-Encoding:CC:Date: Subject:From; b=Kj1Ho4iXXfCMhGxo3aF+cXoQGKCGeR4P19lSWLIjUBbPsKvH7Q2NL8HrUw0HJcvk4 oCN4Bgp1w6Fc1dR1z9hn5kxP14MUlcMCBXMp+vaXMJmNuEmsfNdim7RBIZezTMffjJ 3vXWtT9qGf1zd2fQenvD2Xwm3SWwSkuKtBG6GEk4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mandrillapp.com; i=@mandrillapp.com; q=dns/txt; s=mandrill; t=1683728445; h=From : Subject : To : Cc : Message-Id : In-Reply-To : References : Date : MIME-Version : Content-Type : Content-Transfer-Encoding : From : Subject : Date : X-Mandrill-User : List-Unsubscribe; bh=zAC0Ae3ADV1q0oYr8YU1ywFE0/ZKiWQ1G1f22odEco4=; b=VsFXzHXGU9IlXJo58FzA8k4ETK4yIM/0qkcbYa2wEMjImyq0KBQTrHwN11Qk0uplLjex3o lcCboXhNDg01TfOaBoa+MBvTawS3o4Df3M3T2A6F46OGV6LygGFFLbqkGP9QirohernNbc63 asF5ammT7nJKv5uPMtX0nx9vvEQyo= From: Yann Dirson Subject: =?utf-8?q?=5BPATCH_1/3=5D_docs=3A_fix_complex-and-wrong_xenstore-pa?= =?utf-8?q?th_wording?= X-Mailer: git-send-email 2.30.2 X-Bm-Disclaimer: Yes X-Bm-Milter-Handled: 9664e26d-c55d-4176-ac64-680cfb7c5564 X-Bm-Transport-Timestamp: 1683728439569 To: xen-devel@lists.xenproject.org Cc: xihuan.yang@citrix.com, min.li1@citrix.com, Yann Dirson Message-Id: <20230510142011.1120417-2-yann.dirson@vates.fr> In-Reply-To: <20230510142011.1120417-1-yann.dirson@vates.fr> References: <20230510142011.1120417-1-yann.dirson@vates.fr> X-Native-Encoded: 1 X-Report-Abuse: =?utf-8?q?Please_forward_a_copy_of_this_message=2C_including?= =?utf-8?q?_all_headers=2C_to_abuse=40mandrill=2Ecom=2E_You_can_also_report_?= =?utf-8?q?abuse_here=3A_https=3A//mandrillapp=2Ecom/contact/abuse=3Fid=3D30?= =?utf-8?q?504962=2E744e931c24524562bfbf8de669d17973?= X-Mandrill-User: md_30504962 Feedback-ID: 30504962:30504962.20230510:md Date: Wed, 10 May 2023 14:20:45 +0000 MIME-Version: 1.0 "0 or 1 ... to indicate whether it is capable or incapable, respectively" is luckily just swapped words. Making this shorter will make the reading easier. Signed-off-by: Yann Dirson Reviewed-by: Juergen Gross --- docs/misc/xenstore-paths.pandoc | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/docs/misc/xenstore-paths.pandoc b/docs/misc/xenstore-paths.pandoc index f07ef90f63..a604f6b1c6 100644 --- a/docs/misc/xenstore-paths.pandoc +++ b/docs/misc/xenstore-paths.pandoc @@ -454,9 +454,8 @@ The precise protocol is not yet documented. #### ~/control/feature-suspend = (""|"0"|"1") [w] These may be initialized to "" by the toolstack and may then be set -to 0 or 1 by a guest to indicate whether it is capable or incapable, -respectively, of responding to the corresponding command when written -to ~/control/shutdown. +to 0 or 1 by a guest to indicate whether it is capable of responding +to the corresponding command when written to ~/control/shutdown. A toolstack may then sample the feature- value at the point of issuing a PV control command and respond accordingly: @@ -507,9 +506,8 @@ string back to the control node. #### ~/control/feature-laptop-slate-mode = (""|"0"|"1") [w] This may be initialized to "" by the toolstack and may then be set -to 0 or 1 by a guest to indicate whether it is capable or incapable, -respectively, of responding to a mode value written to -~/control/laptop-slate-mode. +to 0 or 1 by a guest to indicate whether it is capable of responding +to a mode value written to ~/control/laptop-slate-mode. ### Domain Controlled Paths From patchwork Wed May 10 14:20:48 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yann Dirson X-Patchwork-Id: 13236958 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 60E0BC7EE26 for ; Wed, 10 May 2023 14:21:05 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.532848.829189 (Exim 4.92) (envelope-from ) id 1pwkgW-0005bu-5I; Wed, 10 May 2023 14:20:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 532848.829189; Wed, 10 May 2023 14:20:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pwkgW-0005bj-0C; Wed, 10 May 2023 14:20:52 +0000 Received: by outflank-mailman (input) for mailman id 532848; Wed, 10 May 2023 14:20:50 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pwkgU-00050N-SL for xen-devel@lists.xenproject.org; Wed, 10 May 2023 14:20:50 +0000 Received: from mail179-5.suw41.mandrillapp.com (mail179-5.suw41.mandrillapp.com [198.2.179.5]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id dc275159-ef3d-11ed-8611-37d641c3527e; Wed, 10 May 2023 16:20:49 +0200 (CEST) Received: from pmta12.mandrill.prod.suw01.rsglab.com (localhost [127.0.0.1]) by mail179-5.suw41.mandrillapp.com (Mailchimp) with ESMTP id 4QGcdD1wztzG0CPF8 for ; Wed, 10 May 2023 14:20:48 +0000 (GMT) Received: from [37.26.189.201] by mandrillapp.com id 79b70f81d945472da965fc1d3c800edb; Wed, 10 May 2023 14:20:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dc275159-ef3d-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vates.fr; s=mandrill; t=1683728448; x=1683988948; i=yann.dirson@vates.fr; bh=zh8bKuTJDXhG/twy2I/iCoJrgotk0dfjxsaWcv5SUiY=; h=From:Subject:To:Cc:Message-Id:In-Reply-To:References:Feedback-ID: Date:MIME-Version:Content-Type:Content-Transfer-Encoding:CC:Date: Subject:From; b=con50Mxc/lRoi20nT7KPR1TmqwK4XIu8wlbc9wkoVawOg4ybxoor6ylrPCfzDUKWe 8CTw+fAMTOY9Xckla4nxmyNgiIhjJu3zXcmJl9cwTnj9YHiW39WbvvsGuJ1Pq4CoJb L20kIEoh1uSrjbcvX/3ZtaC53cDc2v/qCbm7qaBw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mandrillapp.com; i=@mandrillapp.com; q=dns/txt; s=mandrill; t=1683728448; h=From : Subject : To : Cc : Message-Id : In-Reply-To : References : Date : MIME-Version : Content-Type : Content-Transfer-Encoding : From : Subject : Date : X-Mandrill-User : List-Unsubscribe; bh=zh8bKuTJDXhG/twy2I/iCoJrgotk0dfjxsaWcv5SUiY=; b=N3FXD+417OnrqbjigIfwiEMoA7Ugbz0IAVTDbXhkRzJ6X5h0KekRvP9oZ/ddJ4SDC6bg7o v+eAcmKSEIRBNEaydIpQUbVCpclEQH1G2ErQbxSowgusidN4C46/J/d2cOXGA7jYL8ns6tSy 3JsIDF4kMeBW8QSRfcbywZ3PLXVhk= From: Yann Dirson Subject: =?utf-8?q?=5BPATCH_2/3=5D_docs=3A_document_=7E/control/feature-ball?= =?utf-8?q?oon?= X-Mailer: git-send-email 2.30.2 X-Bm-Disclaimer: Yes X-Bm-Milter-Handled: 9664e26d-c55d-4176-ac64-680cfb7c5564 X-Bm-Transport-Timestamp: 1683728444990 To: xen-devel@lists.xenproject.org Cc: xihuan.yang@citrix.com, min.li1@citrix.com, Yann Dirson Message-Id: <20230510142011.1120417-3-yann.dirson@vates.fr> In-Reply-To: <20230510142011.1120417-1-yann.dirson@vates.fr> References: <20230510142011.1120417-1-yann.dirson@vates.fr> X-Native-Encoded: 1 X-Report-Abuse: =?utf-8?q?Please_forward_a_copy_of_this_message=2C_including?= =?utf-8?q?_all_headers=2C_to_abuse=40mandrill=2Ecom=2E_You_can_also_report_?= =?utf-8?q?abuse_here=3A_https=3A//mandrillapp=2Ecom/contact/abuse=3Fid=3D30?= =?utf-8?q?504962=2E79b70f81d945472da965fc1d3c800edb?= X-Mandrill-User: md_30504962 Feedback-ID: 30504962:30504962.20230510:md Date: Wed, 10 May 2023 14:20:48 +0000 MIME-Version: 1.0 This flag has been in use by XAPI for a long time (was present at creation of the github xen-api/squeezed repo in 2013), and could be used by other toolstacks. Signed-off-by: Yann Dirson --- docs/misc/xenstore-paths.pandoc | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/docs/misc/xenstore-paths.pandoc b/docs/misc/xenstore-paths.pandoc index a604f6b1c6..6c4e2c3da2 100644 --- a/docs/misc/xenstore-paths.pandoc +++ b/docs/misc/xenstore-paths.pandoc @@ -509,6 +509,12 @@ This may be initialized to "" by the toolstack and may then be set to 0 or 1 by a guest to indicate whether it is capable of responding to a mode value written to ~/control/laptop-slate-mode. +#### ~/control/feature-balloon + +This may be initialized to "" by the toolstack and may then be set to +0 or 1 by a guest to indicate whether it is capable of memory +ballooning, and responds to values written to ~/memory/target. + ### Domain Controlled Paths #### ~/data/* [w] From patchwork Wed May 10 14:20:48 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yann Dirson X-Patchwork-Id: 13236955 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 84992C77B7D for ; Wed, 10 May 2023 14:21:04 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.532849.829198 (Exim 4.92) (envelope-from ) id 1pwkgX-0005sR-C1; Wed, 10 May 2023 14:20:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 532849.829198; Wed, 10 May 2023 14:20:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pwkgX-0005sI-8e; Wed, 10 May 2023 14:20:53 +0000 Received: by outflank-mailman (input) for mailman id 532849; Wed, 10 May 2023 14:20:51 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pwkgV-00050N-SX for xen-devel@lists.xenproject.org; Wed, 10 May 2023 14:20:51 +0000 Received: from mail145-2.atl61.mandrillapp.com (mail145-2.atl61.mandrillapp.com [198.2.145.2]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id dc518e69-ef3d-11ed-8611-37d641c3527e; Wed, 10 May 2023 16:20:49 +0200 (CEST) Received: from pmta06.mandrill.prod.atl01.rsglab.com (localhost [127.0.0.1]) by mail145-2.atl61.mandrillapp.com (Mailchimp) with ESMTP id 4QGcdD3vF4zQXlPFj for ; Wed, 10 May 2023 14:20:48 +0000 (GMT) Received: from [37.26.189.201] by mandrillapp.com id ff8208a920b241e18369e93a82372d38; Wed, 10 May 2023 14:20:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dc518e69-ef3d-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vates.fr; s=mandrill; t=1683728448; x=1683988948; i=yann.dirson@vates.fr; bh=ZwL8RO7m/XPAyFca6sOKxBF5d9RSDwmjnqFvJINXGyI=; h=From:Subject:To:Cc:Message-Id:In-Reply-To:References:Feedback-ID: Date:MIME-Version:Content-Type:Content-Transfer-Encoding:CC:Date: Subject:From; b=lutkl4UF1sjyKfPv3tb8+clPcK7umW8O0rxkERBr5Uu9sLMkTZRRa7SQTLrV0ZJ5b 3NDfiH04If4CwUlycWr+J4d6y3dRz4J4+F0bu/8lKQvTbNrO477V0Z2dGxLoIlfT0M EIzH4HwLogCUoksCcML4iXo6V9P+RgebWWLBFaRw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mandrillapp.com; i=@mandrillapp.com; q=dns/txt; s=mandrill; t=1683728448; h=From : Subject : To : Cc : Message-Id : In-Reply-To : References : Date : MIME-Version : Content-Type : Content-Transfer-Encoding : From : Subject : Date : X-Mandrill-User : List-Unsubscribe; bh=ZwL8RO7m/XPAyFca6sOKxBF5d9RSDwmjnqFvJINXGyI=; b=Z6eABEsqG28450+P64bvOre/1WX7u0ACZAgBxq16N6/VIcxrbxsO20uRKO81ZJj6zRTFqi nLCBy20au5vShYLtS2jx6w4bS6ZR7KJP+xJGTPyywCZtAS6rYIUOCVGpGWAfl6sodB9IqpNR W1YWYHwVENgQchqPDUnc2UBGCuEtk= From: Yann Dirson Subject: =?utf-8?q?=5BPATCH_3/3=5D_libxl=3A_create_=7E/control/feature-ballo?= =?utf-8?q?on?= X-Mailer: git-send-email 2.30.2 X-Bm-Disclaimer: Yes X-Bm-Milter-Handled: 9664e26d-c55d-4176-ac64-680cfb7c5564 X-Bm-Transport-Timestamp: 1683728447378 To: xen-devel@lists.xenproject.org Cc: xihuan.yang@citrix.com, min.li1@citrix.com, Yann Dirson , zithro Message-Id: <20230510142011.1120417-4-yann.dirson@vates.fr> In-Reply-To: <20230510142011.1120417-1-yann.dirson@vates.fr> References: <20230510142011.1120417-1-yann.dirson@vates.fr> X-Native-Encoded: 1 X-Report-Abuse: =?utf-8?q?Please_forward_a_copy_of_this_message=2C_including?= =?utf-8?q?_all_headers=2C_to_abuse=40mandrill=2Ecom=2E_You_can_also_report_?= =?utf-8?q?abuse_here=3A_https=3A//mandrillapp=2Ecom/contact/abuse=3Fid=3D30?= =?utf-8?q?504962=2Eff8208a920b241e18369e93a82372d38?= X-Mandrill-User: md_30504962 Feedback-ID: 30504962:30504962.20230510:md Date: Wed, 10 May 2023 14:20:48 +0000 MIME-Version: 1.0 Like other feature controls it has to be created by the toolstack before the guest can advertise the feature. Reported-by: zithro Signed-off-by: Yann Dirson --- tools/libs/light/libxl_create.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tools/libs/light/libxl_create.c b/tools/libs/light/libxl_create.c index ec8eab02c2..85eccc90cd 100644 --- a/tools/libs/light/libxl_create.c +++ b/tools/libs/light/libxl_create.c @@ -863,6 +863,9 @@ retry_transaction: libxl__xs_mknod(gc, t, GCSPRINTF("%s/control/sysrq", dom_path), rwperm, ARRAY_SIZE(rwperm)); + libxl__xs_mknod(gc, t, + GCSPRINTF("%s/control/feature-balloon", dom_path), + rwperm, ARRAY_SIZE(rwperm)); libxl__xs_mknod(gc, t, GCSPRINTF("%s/data", dom_path),