From patchwork Thu May 11 22:05:35 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 13238494 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CDF70C7EE22 for ; Thu, 11 May 2023 22:07:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=E8Q+tBaaYskzauPjWFnHayDJlvaj5LMUfZeaf2NrQbQ=; b=LSvdaf68R6s/duLUQE94lHyK7q RldTFYaHuBe6sTYrK/34t9IjLnJNp6QSz0LZfTm//Wzz26PH/bL2FDu1p0EE3a46qCwGQhYgHrCIC HiypY0xIhvCqRsAyGjuNf2XeGEvayOYTO+l+yitpTKB9uJ0OEFuGv3Bl37SKJnhI7jrCyn6UhscdD owpaCEsZuc0v15aOHCFkq9X/VEJ9jKl3zgf+ibvfCJ55JFaX0cjspc4l/ykXRQW/OiGhXjAQ0NzMf OQt5lAa/8U+VN2mZdTl62YltcUTYevUkmbuzCGm5i2LSXJKlWHZhJkkmAE6Ol3aKn/GxG2vMX8PrT DqZ2SimQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pxERZ-00A89H-0Z; Thu, 11 May 2023 22:07:25 +0000 Received: from mail-pg1-x52f.google.com ([2607:f8b0:4864:20::52f]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pxERU-00A864-2C for linux-mediatek@lists.infradead.org; Thu, 11 May 2023 22:07:22 +0000 Received: by mail-pg1-x52f.google.com with SMTP id 41be03b00d2f7-5304d0d1eddso1861731a12.2 for ; Thu, 11 May 2023 15:07:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1683842839; x=1686434839; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=E8Q+tBaaYskzauPjWFnHayDJlvaj5LMUfZeaf2NrQbQ=; b=jO3XvKkwtvxNz993+Li+17L6pa4w/TVRvEMY4tUBXUiXVgPBB5uE1U72Py0ADFowqw 4UhdzKHqnYW3oIJhRX6Ezvcu9lKjTsfbJHjTMphXNHjJgnIFfy0PwACd0pi08JOHNN5O k+3Cb/D+sfCroFVfwv7zboAl4BRPgefSneMLY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683842839; x=1686434839; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=E8Q+tBaaYskzauPjWFnHayDJlvaj5LMUfZeaf2NrQbQ=; b=E+lcMi4x4uWPlscUuK2x7K0bd6YSNawFt7DYhBkqf123VuTJ0HgOKBygQA1pGeSB8G DHUbJ+kxmeB6kCYbMEW5cxrl/xYsgRZkPjNmSPCtWWE2+YBJ8xsHtZsWng7U0E12Q0lo /PcjHjw77oo3qpZmtqIcbCvJnau7D6svRNVIHWKq0M3EhiL0b/DoNZPgw2xGUy2i0nqU 3vqE5rzo0joJSfVaCNlYhQCIKvDKKzO10V7a2qEP2z8VN/IQVKJl0ZXrN6aCLnVGTSUD VVJMDUUCkb0n/QR8jeFBML09mTQG8x26LA66CKKVXglrXQIGRiVb91myXFKW7PkjQGNx qMIg== X-Gm-Message-State: AC+VfDy8hJ8FntLnvpls1e46ggHba7bCu94FaEcLbJeEl38T5lP3Rc98 aJUAjqm9UR+GobhbCe7OqcxJpA== X-Google-Smtp-Source: ACHHUZ69G7krdwEzUJkF+GCEatd/o1CBrA0/WhHGMcIG6ybMy7MqBpZJm1nTPpJLTV07Tq+WcxoYhA== X-Received: by 2002:a17:90b:234f:b0:250:2d63:7b79 with SMTP id ms15-20020a17090b234f00b002502d637b79mr23492520pjb.43.1683842839570; Thu, 11 May 2023 15:07:19 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:15c:9d:2:b96a:d776:ee3:e572]) by smtp.gmail.com with ESMTPSA id h24-20020a17090a9c1800b00247735d1463sm17589457pjp.39.2023.05.11.15.07.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 May 2023 15:07:18 -0700 (PDT) From: Douglas Anderson To: Marc Zyngier , Thomas Gleixner , Rob Herring , Krzysztof Kozlowski , Matthias Brugger Cc: devicetree@vger.kernel.org, linux-mediatek@lists.infradead.org, wenst@chromium.org, Eddie Huang , Allen-KH Cheng , Ben Ho , Weiyi Lu , AngeloGioacchino Del Regno , linux-arm-kernel@lists.infradead.org, Tinghan Shen , jwerner@chromium.org, Hsin-Hsiung Wang , yidilin@chromium.org, Seiya Wang , Douglas Anderson , Conor Dooley , linux-kernel@vger.kernel.org Subject: [PATCH 1/6] dt-bindings: interrupt-controller: arm,gic-v3: Add quirk for Mediatek SoCs w/ broken FW Date: Thu, 11 May 2023 15:05:35 -0700 Message-ID: <20230511150539.1.Iabe67a827e206496efec6beb5616d5a3b99c1e65@changeid> X-Mailer: git-send-email 2.40.1.606.ga4b1b128d6-goog In-Reply-To: <20230511150539.6.Ia0b6ebbaa351e3cd67e201355b9ae67783c7d718@changeid> References: <20230511150539.6.Ia0b6ebbaa351e3cd67e201355b9ae67783c7d718@changeid> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230511_150720_721341_22BD0DC6 X-CRM114-Status: GOOD ( 19.27 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org When trying to turn on the "pseudo NMI" kernel feature in Linux, it was discovered that all Mediatek-based Chromebooks that ever shipped (at least ones with GICv3) had a firmware bug where they wouldn't save certain GIC "GICR" registers properly. If a processor ever entered a suspend/idle mode where the GICR registers lost state then they'd be reset to their default state. As a result of the bug, if you try to enable "pseudo NMIs" on the affected devices then certain interrupts will unexpectedly get promoted to be "pseudo NMIs" and cause crashes / freezes / general mayhem. ChromeOS is looking to start turning on "pseudo NMIs" in production to make crash reports more actionable. To do so, we will release firmware updates for at least some of the affected Mediatek Chromebooks. However, even when we update the firmware of a Chromebook it's always possible that a user will end up booting with old firmware. We need to be able to detect when we're running with firmware that will crash and burn if pseudo NMIs are enabled. The current plan is: * Update the device trees of all affected Chromebooks to include the 'mediatek,gicr-save-quirk' property. The kernel can use this to know not to enable certain features like "pseudo NMI". NOTE: device trees for Chromebooks are never baked into the firmware but are bundled with the kernel. A kernel will never be configured to use "pseudo NMIs" and be bundled with an old device tree. * When we get a fixed firmware for one of these Chromebooks, it will patch the device tree to remove this property. For some details, you can also see the public bug Signed-off-by: Douglas Anderson Reviewed-by: Julius Werner --- .../bindings/interrupt-controller/arm,gic-v3.yaml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.yaml b/Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.yaml index 92117261e1e1..8c251caae537 100644 --- a/Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.yaml +++ b/Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.yaml @@ -166,6 +166,12 @@ properties: resets: maxItems: 1 + mediatek,gicr-save-quirk: + type: boolean + description: + Asserts that the firmware on this device has issues saving and restoring + GICR registers when CPUs are powered off. + dependencies: mbi-ranges: [ msi-controller ] msi-controller: [ mbi-ranges ] From patchwork Thu May 11 22:05:36 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 13238504 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DC364C7EE25 for ; Thu, 11 May 2023 23:16:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=7GXLLz1cb9WjUR21vBHXCkRjhHYZlPAU9fn/3rFZSY4=; b=QbVMdaK8LGlxv1zneLDwiySnKW NpaTqQcMz2JfHz1eyBbgTNHbYB0dRJybiS+SyRGPQp6sRGzEbmM0/GwdNNxNlFNLzIei6DiNzxgQ8 PgoxXGxhBpCJUgHB138GshGTX3S9VwI4XNBlcY523XCTy0bIi23q9ork4TZ2JV5qhUpdg0+4pDBH7 r7vENWAj9lGpE6MWnlNsWU3nScexMjlZpCe8yGVbfjUEB/dARrNGxTMBHS1USJx9hfWEO7iROOsdM a0I6Dq1cQxC3w1sE9XzSUNOWQJ8s/bLxZXlI3LybVwFhv7GG3cD/ZQI0UKtDKbCPxUHcvUaxeFJtf 9SE770Qg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pxFW8-00AJZx-1z; Thu, 11 May 2023 23:16:12 +0000 Received: from mail-pj1-x1036.google.com ([2607:f8b0:4864:20::1036]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pxERX-00A874-0D for linux-mediatek@lists.infradead.org; Thu, 11 May 2023 22:07:24 +0000 Received: by mail-pj1-x1036.google.com with SMTP id 98e67ed59e1d1-24df4ef05d4so8016513a91.2 for ; Thu, 11 May 2023 15:07:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1683842842; x=1686434842; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=7GXLLz1cb9WjUR21vBHXCkRjhHYZlPAU9fn/3rFZSY4=; b=DExkZbfiK7dYHdPhxBr1koLSFcgH+8Qe2mzgYfxjWSP/l0Qrezi1bLqTam26KdtwOY 39sMwKChIzmpXPLMiTALhfSPVRkRfcYA+JkOOmLwzXXWNweNCgMnDBwgihE9jkZ+CdoO a5jxyKCc+96tFL1pYbjuJVvHn82u64k8LtHmI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683842842; x=1686434842; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7GXLLz1cb9WjUR21vBHXCkRjhHYZlPAU9fn/3rFZSY4=; b=RvjfgLjlqD1mC9DvmCE/UsiR/TNHc4//qA7XQI+SWws+ejXXAIssxYsz/BsS6mCtVL naWjLEbHNDxV3ppj7SWT9cveRT8F3urZ66DETI6UTVksCTH1571m3IvgVWNg+RqaYSe0 /t+mzn1GsDownyBQ3XwEohsoSavNnh2kdWifSbDQr80TDHvnt8F2lPICuwE15ZDU9Cz7 gl7IFqv3yhzXAgDubrNC8sxMJDrHulPXRmsGNH60k82/3O8TzwuQWWzh+R9aKnkko6oW maFKPocGtaAOJjB7Buv5gfd15V6mF/5rlCfFjKv6wjQdxaiLk40BSwwiHSqXjIWSKGeU 6uCg== X-Gm-Message-State: AC+VfDy2TIG7siUHVGJWzLPnUhf0mTWRbCTCoRYV+bE+lHndnrhvk+NE Jqhq+xQOThNV5/9h7Tbu6WDcHA== X-Google-Smtp-Source: ACHHUZ4O5zM/KyCHiemx57/c7GppmLu6526CqNtTflW6Intyj5K7H5YpwWAlewMUVbSxiahggfCiOw== X-Received: by 2002:a17:90b:28b:b0:246:9ef5:3c45 with SMTP id az11-20020a17090b028b00b002469ef53c45mr23147850pjb.13.1683842841770; Thu, 11 May 2023 15:07:21 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:15c:9d:2:b96a:d776:ee3:e572]) by smtp.gmail.com with ESMTPSA id h24-20020a17090a9c1800b00247735d1463sm17589457pjp.39.2023.05.11.15.07.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 May 2023 15:07:21 -0700 (PDT) From: Douglas Anderson To: Marc Zyngier , Thomas Gleixner , Rob Herring , Krzysztof Kozlowski , Matthias Brugger Cc: devicetree@vger.kernel.org, linux-mediatek@lists.infradead.org, wenst@chromium.org, Eddie Huang , Allen-KH Cheng , Ben Ho , Weiyi Lu , AngeloGioacchino Del Regno , linux-arm-kernel@lists.infradead.org, Tinghan Shen , jwerner@chromium.org, Hsin-Hsiung Wang , yidilin@chromium.org, Seiya Wang , Douglas Anderson , linux-kernel@vger.kernel.org Subject: [PATCH 2/6] irqchip/gic-v3: Disable pseudo NMIs on Mediatek devices w/ firmware issues Date: Thu, 11 May 2023 15:05:36 -0700 Message-ID: <20230511150539.2.I88dc0a0eb1d9d537de61604cd8994ecc55c0cac1@changeid> X-Mailer: git-send-email 2.40.1.606.ga4b1b128d6-goog In-Reply-To: <20230511150539.6.Ia0b6ebbaa351e3cd67e201355b9ae67783c7d718@changeid> References: <20230511150539.6.Ia0b6ebbaa351e3cd67e201355b9ae67783c7d718@changeid> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230511_150723_141360_7E7E52AF X-CRM114-Status: GOOD ( 22.77 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Some Chromebooks with Mediatek SoCs have a problem where the firmware doesn't properly save/restore certain GICR registers. Newer Chromebooks should fix this issue and we may be able to do firmware updates for old Chromebooks. At the moment, the only known issue with these Chromebooks is that we can't enable "pseudo NMIs" since the priority register can be lost. Enabling "pseudo NMIs" on Chromebooks with the problematic firmware causes crashes and freezes. Let's detect devices with this problem and then disable "pseudo NMIs" on them. We'll detect the problem by looking for the presence of the "mediatek,gicr-save-quirk" property in the GIC device tree node. Any devices with fixed firmware will not have this property. Our detection plan works because we never bake a Chromebook's device tree into firmware. Instead, device trees are always bundled with the kernel. We'll update the device trees of all affected Chromebooks and then we'll never enable "pseudo NMI" on a kernel that is bundled with old device trees. When a firmware update is shipped that fixes this issue it will know to patch the device tree to remove the property. In order to make this work, the quick detection mechanism of the GICv3 code is extended to be able to look for properties in addition to looking at "compatible". Signed-off-by: Douglas Anderson --- drivers/irqchip/irq-gic-common.c | 8 ++++++-- drivers/irqchip/irq-gic-common.h | 1 + drivers/irqchip/irq-gic-v3.c | 20 ++++++++++++++++++++ 3 files changed, 27 insertions(+), 2 deletions(-) diff --git a/drivers/irqchip/irq-gic-common.c b/drivers/irqchip/irq-gic-common.c index a610821c8ff2..de47b51cdadb 100644 --- a/drivers/irqchip/irq-gic-common.c +++ b/drivers/irqchip/irq-gic-common.c @@ -16,7 +16,11 @@ void gic_enable_of_quirks(const struct device_node *np, const struct gic_quirk *quirks, void *data) { for (; quirks->desc; quirks++) { - if (!of_device_is_compatible(np, quirks->compatible)) + if (quirks->compatible && + !of_device_is_compatible(np, quirks->compatible)) + continue; + if (quirks->property && + !of_property_read_bool(np, quirks->property)) continue; if (quirks->init(data)) pr_info("GIC: enabling workaround for %s\n", @@ -28,7 +32,7 @@ void gic_enable_quirks(u32 iidr, const struct gic_quirk *quirks, void *data) { for (; quirks->desc; quirks++) { - if (quirks->compatible) + if (quirks->compatible || quirks->property) continue; if (quirks->iidr != (quirks->mask & iidr)) continue; diff --git a/drivers/irqchip/irq-gic-common.h b/drivers/irqchip/irq-gic-common.h index 27e3d4ed4f32..3db4592cda1c 100644 --- a/drivers/irqchip/irq-gic-common.h +++ b/drivers/irqchip/irq-gic-common.h @@ -13,6 +13,7 @@ struct gic_quirk { const char *desc; const char *compatible; + const char *property; bool (*init)(void *data); u32 iidr; u32 mask; diff --git a/drivers/irqchip/irq-gic-v3.c b/drivers/irqchip/irq-gic-v3.c index 6fcee221f201..161cc8957e8b 100644 --- a/drivers/irqchip/irq-gic-v3.c +++ b/drivers/irqchip/irq-gic-v3.c @@ -39,6 +39,7 @@ #define FLAGS_WORKAROUND_GICR_WAKER_MSM8996 (1ULL << 0) #define FLAGS_WORKAROUND_CAVIUM_ERRATUM_38539 (1ULL << 1) +#define FLAGS_WORKAROUND_MTK_GICR_SAVE (1ULL << 2) #define GIC_IRQ_TYPE_PARTITION (GIC_IRQ_TYPE_LPI + 1) @@ -1720,6 +1721,15 @@ static bool gic_enable_quirk_msm8996(void *data) return true; } +static bool gic_enable_quirk_mtk_gicr(void *data) +{ + struct gic_chip_data *d = data; + + d->flags |= FLAGS_WORKAROUND_MTK_GICR_SAVE; + + return true; +} + static bool gic_enable_quirk_cavium_38539(void *data) { struct gic_chip_data *d = data; @@ -1792,6 +1802,11 @@ static const struct gic_quirk gic_quirks[] = { .compatible = "qcom,msm8996-gic-v3", .init = gic_enable_quirk_msm8996, }, + { + .desc = "GICv3: Mediatek Chromebook GICR save problem", + .property = "mediatek,gicr-save-quirk", + .init = gic_enable_quirk_mtk_gicr, + }, { .desc = "GICv3: HIP06 erratum 161010803", .iidr = 0x0204043b, @@ -1834,6 +1849,11 @@ static void gic_enable_nmi_support(void) if (!gic_prio_masking_enabled()) return; + if (gic_data.flags & FLAGS_WORKAROUND_MTK_GICR_SAVE) { + pr_warn("Skipping NMI enable due to firmware issues\n"); + return; + } + ppi_nmi_refs = kcalloc(gic_data.ppi_nr, sizeof(*ppi_nmi_refs), GFP_KERNEL); if (!ppi_nmi_refs) return; From patchwork Thu May 11 22:05:37 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 13238496 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A3470C7EE25 for ; Thu, 11 May 2023 22:07:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=jGmB8F2e98GdWrgyT4B5IleiARSuWWe2Ulwy2r0MhKE=; b=mNQ5xcW+IirwzXUpWY40tG8rsl 4GQltrPngyKJauA9CMo34rO5Trjp6KozZwRXhSQRRHaVYPTwuCl0T9eKRQWhFBp9OW/WO7T3xi5mD KFBQQ7QT3tRUFOA+PHOJw9diB/BaRECdPDAZ0jZnwq9ailNSWUZLr4qct2jr7gvZpLZaB3Atl4JbS HtL/wcCm9zNR2+fRkJS2gvhb1zMoNL4992zy2Jq3N5DeNEhg0AgLByyVDXOGYr06+OGTmvV0Zr7on j4tGToGUPSeY5aBOD4+QuwRQDCi5vKOwPwhOQGgLuMdX10kg0WWTONKmNQVp4dTv1iHUVfTBZ1vB/ hIKIr9vQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pxERx-00A8HS-09; Thu, 11 May 2023 22:07:49 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pxERv-00A8Gh-2M for linux-mediatek@bombadil.infradead.org; Thu, 11 May 2023 22:07:47 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:MIME-Version :References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=jGmB8F2e98GdWrgyT4B5IleiARSuWWe2Ulwy2r0MhKE=; b=pUgLxCbAxCpxLous4XDK5wZYaI tyyK5MGW2LP/ff8GES4xuUfkktD7263d6BfRNi6ZwsN/c+Frg2jCOYaeqzES9PIcf6PYYM5sXDf4z WbIIQsShA3i571bEmGyah+0jDNUb3b6La4Fe9yLXGvTugS0ELjwfU3KDqAy0VmDhfVyHgIe3eCcih qNsHbak8wxXxDO3qR+PyYIQwPx1EoWnfph017gmBAh8xj73r/rPloTFUx8A5fS35MvizLrAgcXwrY kdyL/xQm7uXo6kCJOilQjrYxvNAVcZruOoh2OF9hVO5z9WODtz1QC2Q0Tb8ksdDkBci+UH1zwcvTG C5gjKiWQ==; Received: from mail-pj1-x1033.google.com ([2607:f8b0:4864:20::1033]) by desiato.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pxERi-008PTu-1v for linux-mediatek@lists.infradead.org; Thu, 11 May 2023 22:07:43 +0000 Received: by mail-pj1-x1033.google.com with SMTP id 98e67ed59e1d1-24dfc3c662eso6322691a91.3 for ; Thu, 11 May 2023 15:07:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1683842844; x=1686434844; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=jGmB8F2e98GdWrgyT4B5IleiARSuWWe2Ulwy2r0MhKE=; b=a8ROuWQy9au/LGDatW3Yczkvz1oDRSIPWobGizLtzk0TsyfsXDteYsoxk4LFs2lq9I zmg18AmauzAwY5tL3x5orosIDGNmfVPcTnQE8EGCRj40rRYHapv4Zj4uHo4PiAkpJjE9 p+5iV3Raay93vAOnpWhbkitqUW6+lsDByEF10= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683842844; x=1686434844; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jGmB8F2e98GdWrgyT4B5IleiARSuWWe2Ulwy2r0MhKE=; b=fKzQM+sclhL/Ogsz3ZZoheXbSlQ41U8QS5nHAG3RoCHfMPV25yTuKzYmAxmSws4s55 Y16eF9YAHMY6WUfk9W/Exe0Yo7TAq1HmK4MjFZ4G2RJxaoogJOTpL9Mx/Ez44O4Owdlj ZAESS2l9F4FmhoVUT34WtnB6IhtVuB0m7df/XIcNftwRRnx7Q47xpz+/eEt7t2+PMnOa f1eEutIMuoXjVhEhtokyZNW8YLmgEDO2F9ZSLoE+CvC7mvVzWE+n830GyJEkQZk+3oQ6 8E65SReCKz+ClvrfySdF/tm0nkH1abZluAmCAEhTQaRgApeMu6PdjvVZ5uhLvZCHDRMh Hk8A== X-Gm-Message-State: AC+VfDwB4bIOs464ILsvd0XiC8/Mqyx7rB+f3ffBlFYEa96jJHe6RDUq /SbcEDDML1ZbkWkOvaGvOl3ELA== X-Google-Smtp-Source: ACHHUZ4L4GfuFi0ir2OtEqoC+3EwK8m+Ei92ubWuNmIPIwYD0THA24Kk7jcXZ4JIs8vWNH+/tZYPUA== X-Received: by 2002:a17:90a:2d6:b0:252:a2e5:4c3f with SMTP id d22-20020a17090a02d600b00252a2e54c3fmr1747848pjd.25.1683842844119; Thu, 11 May 2023 15:07:24 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:15c:9d:2:b96a:d776:ee3:e572]) by smtp.gmail.com with ESMTPSA id h24-20020a17090a9c1800b00247735d1463sm17589457pjp.39.2023.05.11.15.07.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 May 2023 15:07:23 -0700 (PDT) From: Douglas Anderson To: Marc Zyngier , Thomas Gleixner , Rob Herring , Krzysztof Kozlowski , Matthias Brugger Cc: devicetree@vger.kernel.org, linux-mediatek@lists.infradead.org, wenst@chromium.org, Eddie Huang , Allen-KH Cheng , Ben Ho , Weiyi Lu , AngeloGioacchino Del Regno , linux-arm-kernel@lists.infradead.org, Tinghan Shen , jwerner@chromium.org, Hsin-Hsiung Wang , yidilin@chromium.org, Seiya Wang , Douglas Anderson , Conor Dooley , linux-kernel@vger.kernel.org Subject: [PATCH 3/6] arm64: dts: mediatek: mt8183: Add mediatek,gicr-save-quirk Date: Thu, 11 May 2023 15:05:37 -0700 Message-ID: <20230511150539.3.I525a2ed4260046d43c885ee1275e91707743df1c@changeid> X-Mailer: git-send-email 2.40.1.606.ga4b1b128d6-goog In-Reply-To: <20230511150539.6.Ia0b6ebbaa351e3cd67e201355b9ae67783c7d718@changeid> References: <20230511150539.6.Ia0b6ebbaa351e3cd67e201355b9ae67783c7d718@changeid> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230511_230738_589586_115B2E69 X-CRM114-Status: UNSURE ( 9.30 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Firmware shipped on mt8183 Chromebooks is affected by the GICR save/restore issue as described by the patch ("dt-bindings: interrupt-controller: arm,gic-v3: Add quirk for Mediatek SoCs w/ broken FW"). Add the quirk property. Fixes: e526c9bc11f8 ("arm64: dts: Add Mediatek SoC MT8183 and evaluation board dts and Makefile") Signed-off-by: Douglas Anderson Reviewed-by: Julius Werner --- arch/arm64/boot/dts/mediatek/mt8183.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi index 5169779d01df..39545172fce5 100644 --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi @@ -709,6 +709,7 @@ gic: interrupt-controller@c000000 { <0 0x0c400000 0 0x2000>, /* GICC */ <0 0x0c410000 0 0x1000>, /* GICH */ <0 0x0c420000 0 0x2000>; /* GICV */ + mediatek,gicr-save-quirk; interrupts = ; ppi-partitions { From patchwork Thu May 11 22:05:38 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 13238505 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C3D17C7EE22 for ; Thu, 11 May 2023 23:16:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=K+dvOm04w8PPu/rImCk8a3YHkXAbeV87AIPZhDPscPw=; b=y4tn8VPb9nh/3J9gLBSKOeAZXp uolDUNiQ+BJtlv5uFr4gSQ8Os0CCs6rre8jpVOf1lvtuch2+/x9/A7Uc+yWLvwQGGXDzyb+p1wUHr eOF4Iya1Bu/ZJeLTiqT4mZ5RRzlFMXRQ9woUO5QR6R934Stwt0gzbXwvtEu3g6+EKBYVyl5lSiDFL rxTar2m/zOK3gRVnlcKU2wNKnOjBNZCAPuqmdLEwgQ2X1aD1JfOyV6Hk+oK0W1B8Dd8RQA6RJhuXT opEF4BlhjHaYC061OqvMDJXbNhvQiJGFhHNiR1uMun6V1Wgg4aJ7SPM2uOiEtm1ITQmk31GYUSz1U kczk4sjg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pxFW9-00AJaS-1h; Thu, 11 May 2023 23:16:13 +0000 Received: from mail-pj1-x1034.google.com ([2607:f8b0:4864:20::1034]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pxERb-00A8AB-37 for linux-mediatek@lists.infradead.org; Thu, 11 May 2023 22:07:29 +0000 Received: by mail-pj1-x1034.google.com with SMTP id 98e67ed59e1d1-24de2954bc5so6380224a91.1 for ; Thu, 11 May 2023 15:07:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1683842847; x=1686434847; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=K+dvOm04w8PPu/rImCk8a3YHkXAbeV87AIPZhDPscPw=; b=hssIu15bC0KSO0j4n4UiTUSK1g1EmW3565jzwwoTqGY6zacsfwczA5MEV+3WEIgL51 FaOLFcYy4qZNQX5hyMTUAZC8ss2jKpC9yFQP3B0jicwEflxxCKpWdWKbuC6pxB1ydPks q1YL08QBU2trw5ls56AwM/YC2p94uMB+870ko= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683842847; x=1686434847; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=K+dvOm04w8PPu/rImCk8a3YHkXAbeV87AIPZhDPscPw=; b=B0LGXg9NZZ12dz0tOZwXnzNDEJOnxCgIyBgUFszxNNaalGb7YA4j/pb0FXobKlSuhR tny6DP89DHLqG3l5i1Zi74emqe1nzfsizBCxyY97BE4n/atnFKqFIoy3A/xKluvR/3lo XYLNVxly/47eQHsGxlpB/eaB3uwFwgZGvATRVGQBD/wfO5SOYffOyrApAStqjnjyJQ+S AuryLtiEaDp8dnZGHrQNeuFPEYKGXuD6UsdFxsZIdqFCCfIQf8esZL/VCBFc41P0MX4b /xGjxhsIbWEpIVmaK4AUunhUnfoHEPonEPZH7mIanKCzeRPStVDigIhdxs6W0jyAhmuL Mo2g== X-Gm-Message-State: AC+VfDyeYhOdoXyiBa1g3EqKM87SSp0QNulYTvlZPQUgaPDGV/bEIo/5 0cqSAuJZ+FeCx5WcV2c2P7xmu9cQOt/vk4vY0j4= X-Google-Smtp-Source: ACHHUZ41RE00te4Ijen+NU2VZLSRZZeq3ieV/CReVKY7S7BpZdh+5eIYWsjWa5jYSCS63ssl+OjuTQ== X-Received: by 2002:a17:90b:1804:b0:24e:39d2:ab80 with SMTP id lw4-20020a17090b180400b0024e39d2ab80mr22819969pjb.4.1683842846799; Thu, 11 May 2023 15:07:26 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:15c:9d:2:b96a:d776:ee3:e572]) by smtp.gmail.com with ESMTPSA id h24-20020a17090a9c1800b00247735d1463sm17589457pjp.39.2023.05.11.15.07.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 May 2023 15:07:25 -0700 (PDT) From: Douglas Anderson To: Marc Zyngier , Thomas Gleixner , Rob Herring , Krzysztof Kozlowski , Matthias Brugger Cc: devicetree@vger.kernel.org, linux-mediatek@lists.infradead.org, wenst@chromium.org, Eddie Huang , Allen-KH Cheng , Ben Ho , Weiyi Lu , AngeloGioacchino Del Regno , linux-arm-kernel@lists.infradead.org, Tinghan Shen , jwerner@chromium.org, Hsin-Hsiung Wang , yidilin@chromium.org, Seiya Wang , Douglas Anderson , Conor Dooley , linux-kernel@vger.kernel.org Subject: [PATCH 4/6] arm64: dts: mediatek: mt8186: Add mediatek,gicr-save-quirk Date: Thu, 11 May 2023 15:05:38 -0700 Message-ID: <20230511150539.4.Iaa0ee05cf0362540fda50dd6a0d87ee35dccd88b@changeid> X-Mailer: git-send-email 2.40.1.606.ga4b1b128d6-goog In-Reply-To: <20230511150539.6.Ia0b6ebbaa351e3cd67e201355b9ae67783c7d718@changeid> References: <20230511150539.6.Ia0b6ebbaa351e3cd67e201355b9ae67783c7d718@changeid> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230511_150728_001401_2F5408E2 X-CRM114-Status: UNSURE ( 9.54 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Firmware shipped on mt8186 Chromebooks is affected by the GICR save/restore issue as described by the patch ("dt-bindings: interrupt-controller: arm,gic-v3: Add quirk for Mediatek SoCs w/ broken FW"). Add the quirk property. Fixes: 2e78620b1350 ("arm64: dts: Add MediaTek MT8186 dts and evaluation board and Makefile") Signed-off-by: Douglas Anderson --- arch/arm64/boot/dts/mediatek/mt8186.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/mediatek/mt8186.dtsi b/arch/arm64/boot/dts/mediatek/mt8186.dtsi index 5e83d4e9efa4..09fbd8f9ea52 100644 --- a/arch/arm64/boot/dts/mediatek/mt8186.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt8186.dtsi @@ -336,6 +336,7 @@ gic: interrupt-controller@c000000 { reg = <0 0x0c000000 0 0x40000>, <0 0x0c040000 0 0x200000>; interrupts = ; + mediatek,gicr-save-quirk; ppi-partitions { ppi_cluster0: interrupt-partition-0 { From patchwork Thu May 11 22:05:39 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 13238495 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BC9B6C77B7C for ; Thu, 11 May 2023 22:07:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=4oNdmLNDKUs/TKLR+gsT5NpmW/ws1iPV3pHW3NShG8U=; b=yxJYcAFK2il6a5fToDC1efkOsF wWyn5c3aSH88HJJUrTj3QYn/eOOQ68LBEeCscDN3oMnpFYFdheTw7l+GBMCrqg2AEKWt17Ar29Kqm 99Efq3GmEuDI04PlphX3IpgJ6jdKd4fWd4RUf6YxF+7TMQyVKceg+tvFDdDQly/hE91Y4+q25Z5nS 3XumU2eBMMCE9RaJsJ4XA9hXUjVCyhtMLZqYVjl90AYptret4x/br4GCLoPssuK1JpCPVysgBxIfe U04nObvBYzoSXCNdLdrqxnoSa7ynZkanWSzolDbGBSBIA88rHlyQSySAzGiEVhkyTeRv+C+IO9Uif bA6BikRQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pxERu-00A8GH-1m; Thu, 11 May 2023 22:07:46 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pxERt-00A8Fq-1v for linux-mediatek@bombadil.infradead.org; Thu, 11 May 2023 22:07:45 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:MIME-Version :References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=4oNdmLNDKUs/TKLR+gsT5NpmW/ws1iPV3pHW3NShG8U=; b=klo61syUbNDK5zkR2MQQJZHyzd RHCf4LK6EwCfe6mL9dUli9kgkRfpdI75+6P0opoIncv99AayyRmdm9TC+0upeGvVantMvWtnPlZo6 vWThSmVkm7fL6mcY7YqldgYBZaoPmN2zWiYykWgvXUO+naBB4QQztI9C5MaCF+XMRCw5Xl1E+T04s m9btoL1UlZsd7M/o6bH5iUqtvft5wzK931ExF6ty0fJKbkxxpMea0orZl860oY9+SD3b28QCTNAlT ffu7WkoOq7VKt8kQSI8qztLKoh0DqjajTA6naCTtvitU5Un/OXELQfrZSqWZ0aqY2r+G7ClZxd5Sc rC7cO1Og==; Received: from mail-pj1-x1033.google.com ([2607:f8b0:4864:20::1033]) by desiato.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pxERi-008PU4-1v for linux-mediatek@lists.infradead.org; Thu, 11 May 2023 22:07:43 +0000 Received: by mail-pj1-x1033.google.com with SMTP id 98e67ed59e1d1-250175762b8so7936086a91.1 for ; Thu, 11 May 2023 15:07:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1683842849; x=1686434849; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4oNdmLNDKUs/TKLR+gsT5NpmW/ws1iPV3pHW3NShG8U=; b=FKICgaJfahEVpza6/yNir+fScXx3x3STtdt4nOBeEqwSVZml+ci7oo7WA4LOpHskZg yP1GfbFkAfnafJDiyRdUcrop9yvD/R/KlOyppyOUZYqxS6ThoYq6mLS4Y42Vc70gg1rQ PTkOZyGoUNqzdK7YbeppQldT1a34MEx609nmE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683842849; x=1686434849; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4oNdmLNDKUs/TKLR+gsT5NpmW/ws1iPV3pHW3NShG8U=; b=MIFJrN+ZLevsoLgZq3xMykmQb624p4D9023AhRveaOUrI0IMyhWaGKYL2vu6fBtsh1 ut7MWrFknsUtF5YgEaZ8ZQxbDpSEtxrOvbD36zZXzRaGuAvSJe2/yz2r45tpgO10QGtP WMThQsSVenfR1rzFt72g4ZWy8LhX1fwkGM94p7l06M+rkrbKVNlJ02c+ADZgSL/E65b3 gCGyraGhcvrzxIml+/JQ6dPHQatkCSw7y3AuNdfZtPkCmQhwmQO2ijjFFkYOyujWy5bT vpLD7ejCvKETKcd2MzrdsYzoPlbJf9Y4xY/FDiZCqv3raMUV3Pe8MO2LgsQmlzFxoc1S 5BOg== X-Gm-Message-State: AC+VfDx2FNNN16wQpHMn2ftoeeITc8fe3/MfY9FPvdECBYMEli9ZGsnD FonfXHevfjVzYNxVcqJZ3KYNrg== X-Google-Smtp-Source: ACHHUZ7KHoYJUF8QcmYx3zYXY/ErcV8fKCA+CWgEODGDRJgk0tu1drw3OSzYGpFg9Cpo3TKkns7Hxw== X-Received: by 2002:a17:90b:3a8e:b0:247:6ead:d0ed with SMTP id om14-20020a17090b3a8e00b002476eadd0edmr23026494pjb.28.1683842848965; Thu, 11 May 2023 15:07:28 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:15c:9d:2:b96a:d776:ee3:e572]) by smtp.gmail.com with ESMTPSA id h24-20020a17090a9c1800b00247735d1463sm17589457pjp.39.2023.05.11.15.07.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 May 2023 15:07:28 -0700 (PDT) From: Douglas Anderson To: Marc Zyngier , Thomas Gleixner , Rob Herring , Krzysztof Kozlowski , Matthias Brugger Cc: devicetree@vger.kernel.org, linux-mediatek@lists.infradead.org, wenst@chromium.org, Eddie Huang , Allen-KH Cheng , Ben Ho , Weiyi Lu , AngeloGioacchino Del Regno , linux-arm-kernel@lists.infradead.org, Tinghan Shen , jwerner@chromium.org, Hsin-Hsiung Wang , yidilin@chromium.org, Seiya Wang , Douglas Anderson , Conor Dooley , linux-kernel@vger.kernel.org Subject: [PATCH 5/6] arm64: dts: mediatek: mt8192: Add mediatek,gicr-save-quirk Date: Thu, 11 May 2023 15:05:39 -0700 Message-ID: <20230511150539.5.Ie7e600278ffbed55a1e5a58178203787b1449b35@changeid> X-Mailer: git-send-email 2.40.1.606.ga4b1b128d6-goog In-Reply-To: <20230511150539.6.Ia0b6ebbaa351e3cd67e201355b9ae67783c7d718@changeid> References: <20230511150539.6.Ia0b6ebbaa351e3cd67e201355b9ae67783c7d718@changeid> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230511_230738_988919_966ED7D6 X-CRM114-Status: UNSURE ( 9.18 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Firmware shipped on mt8192 Chromebooks is affected by the GICR save/restore issue as described by the patch ("dt-bindings: interrupt-controller: arm,gic-v3: Add quirk for Mediatek SoCs w/ broken FW"). Add the quirk property. Fixes: 48489980e27e ("arm64: dts: Add Mediatek SoC MT8192 and evaluation board dts and Makefile") Signed-off-by: Douglas Anderson Reviewed-by: Julius Werner --- arch/arm64/boot/dts/mediatek/mt8192.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/mediatek/mt8192.dtsi b/arch/arm64/boot/dts/mediatek/mt8192.dtsi index 5c30caf74026..8931c59c69f4 100644 --- a/arch/arm64/boot/dts/mediatek/mt8192.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt8192.dtsi @@ -412,6 +412,7 @@ gic: interrupt-controller@c000000 { reg = <0 0x0c000000 0 0x40000>, <0 0x0c040000 0 0x200000>; interrupts = ; + mediatek,gicr-save-quirk; ppi-partitions { ppi_cluster0: interrupt-partition-0 {