From patchwork Mon May 15 09:38:15 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "zhaoyang.huang" X-Patchwork-Id: 13241097 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 657D6C77B7D for ; Mon, 15 May 2023 09:39:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 03F41900016; Mon, 15 May 2023 05:39:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F314C900002; Mon, 15 May 2023 05:39:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E21FC900016; Mon, 15 May 2023 05:39:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id C658B900002 for ; Mon, 15 May 2023 05:39:05 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 966CA40ADE for ; Mon, 15 May 2023 09:39:05 +0000 (UTC) X-FDA: 80791990650.02.7EBC7EE Received: from SHSQR01.spreadtrum.com (mx1.unisoc.com [222.66.158.135]) by imf03.hostedemail.com (Postfix) with ESMTP id D06B62000A for ; Mon, 15 May 2023 09:39:02 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=none; spf=pass (imf03.hostedemail.com: domain of zhaoyang.huang@unisoc.com designates 222.66.158.135 as permitted sender) smtp.mailfrom=zhaoyang.huang@unisoc.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684143544; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references; bh=iiWOKtHtIyydA4AgntJEknjCMUl8hqeYHFcPBaGXHDs=; b=0ALFNhvtAbuOUpqcZDv/cFghq76PRZTcQijd2imR227eo2J2BE0uQcOJ24BSZsXqgXPZ7Q kwtjVQR1cKp4avxDW1ZBiLOoqwZuYyneBV1NjjX4GBeZ+PQWNTx3PuOgltBC/BllYW5VgI ZB8fIsr4sFn9xQNm9Dx89oXeRlWZHZk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684143544; a=rsa-sha256; cv=none; b=a6gZY1u+ehdnTyExQc6+6KDZZcB1UVc2GukY5JEItQRUMN7glLF4JwctJQtNJ+/url69Wn ogvUe3TDam7SNbKWuFhq9s/osDS6apliTsC7Ui6kSec0i9gXetwHjmrsar/AG2+z9Fb/rN xBUq111/bjSCmaZAS/h3DXvi6Nf6vPs= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=none; spf=pass (imf03.hostedemail.com: domain of zhaoyang.huang@unisoc.com designates 222.66.158.135 as permitted sender) smtp.mailfrom=zhaoyang.huang@unisoc.com; dmarc=none Received: from SHSend.spreadtrum.com (bjmbx01.spreadtrum.com [10.0.64.7]) by SHSQR01.spreadtrum.com with ESMTP id 34F9cZ6P075415; Mon, 15 May 2023 17:38:35 +0800 (+08) (envelope-from zhaoyang.huang@unisoc.com) Received: from bj03382pcu.spreadtrum.com (10.0.74.65) by BJMBX01.spreadtrum.com (10.0.64.7) with Microsoft SMTP Server (TLS) id 15.0.1497.23; Mon, 15 May 2023 17:38:31 +0800 From: "zhaoyang.huang" To: Andrew Morton , Matthew Wilcox , Minchan Kim , Joonsoo Kim , , , Zhaoyang Huang , Subject: [Resend PATCHv2] mm: skip CMA pages when they are not available Date: Mon, 15 May 2023 17:38:15 +0800 Message-ID: <1684143495-12872-1-git-send-email-zhaoyang.huang@unisoc.com> X-Mailer: git-send-email 1.9.1 MIME-Version: 1.0 X-Originating-IP: [10.0.74.65] X-ClientProxiedBy: SHCAS03.spreadtrum.com (10.0.1.207) To BJMBX01.spreadtrum.com (10.0.64.7) X-MAIL: SHSQR01.spreadtrum.com 34F9cZ6P075415 X-Rspamd-Queue-Id: D06B62000A X-Stat-Signature: t695gtk9ri1qpy9ac91na44jc3tdoy8e X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1684143542-278689 X-HE-Meta: U2FsdGVkX1/3wICIV/q7fG0qyIf2hrn3gkrStqcqUwWsU44EcWq0JB7OC7aRKePY1yaUcv07DZZBuNNzd1kbH31wALvtEputNhyCMaAwlhNgdkhxiko0bCpTYoHmW66+JX1UIkoN1ffVzUF3WfxrCHJgdUXByR+KQOJN3Jbae0hbc1rNmC/S2TW0FyXK2aVkQ2fnnuBJVkKCQ/LHRDLcf+3PKmbvTmRnfiBphY49xgJjZ+VSEM//4IEVbmHnM7ahlJnxCiQYYwNM4a6vcJi9b3/9tkHjL8xotMK7iS4BLPUSi64Q6e4cLagLkQ0++85UX9kCrxtyX0NJ0xpXhCixLwYxn2v+o2CJ2DahuFmMvBC+97yZjxTRqlSjL7Hf59xlJybBktoUc1qVBMuWDvgq/IPwkhFBlJ/pXzeHdB/Awx2xJbOf2UBLDYUzKhimtlnuZL9nyqKEJksEedZ5e2Ilv0J++wjgCPM3DtWmQ8fJP/sQJqTWfUSvGrv0hi8bFjWlWYOt2fn/tapwm7HdcJWBxacihO3tpNCZs7zSqJfPk5mkjHq+PYw+UmISex4FpSsKb4h6EJtXyfmNdQRJBh6FoElUgUbROZ/tzHu47GdaIUuIXVeJXOnZQ+++yqWue05Tco/36VfZhhDthkf4HeI41fFvoBNfdONLo+lhH349Q0Q54pndUL9HKGNNlgsM2z5GIMgt4A7nLX0NjU6IXPLxtz2xG3zCerq0/3P3riGZnUj720aihB2QCvNj57Elngh3yfeX60mXjW/DJc022hSU6ZjzO3ICwgyIG1lYZjJo+Pe8y73yghZaZN7HITqc6kQBp1tBsE0vVwhoJMJA8A60ZeTcFmUlWmhY1xdHdQV2xud8vZETvUztWfUO1n31kDqvQFQFV4CGHUyAk9aCmgFwqZ5ruIJTFXwcSPq1A0H1abRA9bHranS2aJvXUagwO0EEC8AkxFdLACBlWjr1Ubo mgr9xPJd nQWmLRFoYt9J4DV6d7WwXdbMWkBR8efjRbA0LhbUiuu63lhefibWETyMATdc/CdI8brrwXYthftR4Zaxm9RkuSl1tvsoDJGSvEYswGnvpEwHPAy7PfwNfsOFeH5I4HhFlhtG+b/7uMBAVNSPP7yDfUwZQzRjhSf40q/56WinlwJVlgzkvQRKiAHH4d33JHde7lFfkhcs78IPEEG9wOdBXbHOo2kowePrTcU87tTlKVjMgW7i1C6Jvb6r9FjqrCPb75lLz X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Zhaoyang Huang This patch fixes unproductive reclaiming of CMA pages by skipping them when they are not available for current context. It is arise from bellowing OOM issue, which caused by large proportion of MIGRATE_CMA pages among free pages. There has been commit(168676649) to fix it by trying CMA pages first instead of fallback in rmqueue. I would like to propose another one from reclaiming perspective. 04166 < 4> [ 36.172486] [03-19 10:05:52.172] ActivityManager: page allocation failure: order:0, mode:0xc00(GFP_NOIO), nodemask=(null),cpuset=foreground,mems_allowed=0 0419C < 4> [ 36.189447] [03-19 10:05:52.189] DMA32: 0*4kB 447*8kB (C) 217*16kB (C) 124*32kB (C) 136*64kB (C) 70*128kB (C) 22*256kB (C) 3*512kB (C) 0*1024kB 0*2048kB 0*4096kB = 35848kB 0419D < 4> [ 36.193125] [03-19 10:05:52.193] Normal: 231*4kB (UMEH) 49*8kB (MEH) 14*16kB (H) 13*32kB (H) 8*64kB (H) 2*128kB (H) 0*256kB 1*512kB (H) 0*1024kB 0*2048kB 0*4096kB = 3236kB ...... 041EA < 4> [ 36.234447] [03-19 10:05:52.234] SLUB: Unable to allocate memory on node -1, gfp=0xa20(GFP_ATOMIC) 041EB < 4> [ 36.234455] [03-19 10:05:52.234] cache: ext4_io_end, object size: 64, buffer size: 64, default order: 0, min order: 0 041EC < 4> [ 36.234459] [03-19 10:05:52.234] node 0: slabs: 53,objs: 3392, free: 0 Signed-off-by: Zhaoyang Huang --- v2: update commit message and fix build error when CONFIG_CMA is not set --- --- mm/vmscan.c | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/mm/vmscan.c b/mm/vmscan.c index bd6637f..19fb445 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -2225,10 +2225,16 @@ static unsigned long isolate_lru_folios(unsigned long nr_to_scan, unsigned long nr_skipped[MAX_NR_ZONES] = { 0, }; unsigned long skipped = 0; unsigned long scan, total_scan, nr_pages; + bool cma_cap = true; + struct page *page; LIST_HEAD(folios_skipped); total_scan = 0; scan = 0; + if ((IS_ENABLED(CONFIG_CMA)) && !current_is_kswapd() + && (gfp_migratetype(sc->gfp_mask) != MIGRATE_MOVABLE)) + cma_cap = false; + while (scan < nr_to_scan && !list_empty(src)) { struct list_head *move_to = src; struct folio *folio; @@ -2239,12 +2245,17 @@ static unsigned long isolate_lru_folios(unsigned long nr_to_scan, nr_pages = folio_nr_pages(folio); total_scan += nr_pages; - if (folio_zonenum(folio) > sc->reclaim_idx) { + page = &folio->page; + + if ((folio_zonenum(folio) > sc->reclaim_idx) +#ifdef CONFIG_CMA + || (get_pageblock_migratetype(page) == MIGRATE_CMA && !cma_cap) +#endif + ) { nr_skipped[folio_zonenum(folio)] += nr_pages; move_to = &folios_skipped; goto move; } - /* * Do not count skipped folios because that makes the function * return with no isolated folios if the LRU mostly contains