From patchwork Mon May 15 11:40:43 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Rix X-Patchwork-Id: 13241300 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01742C7EE22 for ; Mon, 15 May 2023 11:54:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241571AbjEOLyc (ORCPT ); Mon, 15 May 2023 07:54:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50476 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238913AbjEOLyL (ORCPT ); Mon, 15 May 2023 07:54:11 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E9E0D5272 for ; Mon, 15 May 2023 04:40:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1684150847; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=/HfDmifvLEGL+myxWzfdruEc+v2HKRtI9dyoUcoziAo=; b=A4rRvO5m79mqYdz9HC3L0AfX6r5hd4GUxT5gZ1Jlbs60+bs6S605HA6u6OK2X3VMfmX1vy bUsIG42Wj0iwM+HLWXZdic7iqjh9A9sLcnV5RwDhEI4hUwBVfDK4QaUAG/GxkvxG9IbSV1 7TyKPygrLo42Prt9fL9CueuGRXEopcE= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-550-XEbJd9R0P425pYymCnlJNw-1; Mon, 15 May 2023 07:40:46 -0400 X-MC-Unique: XEbJd9R0P425pYymCnlJNw-1 Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-621257e86daso117367226d6.1 for ; Mon, 15 May 2023 04:40:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684150846; x=1686742846; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=/HfDmifvLEGL+myxWzfdruEc+v2HKRtI9dyoUcoziAo=; b=gthgO9AkYw9kGBAJt6VAsWmUm1N3FRkNnug5A2K4fUWnE+5VjoyA22hbCXTtyaHGJU ectfoa/jl461QrfyS5VY9pmaVPWp1tGOhdBD78+jp0Hqs/q6j1pRBd6RJpBG5WCMNP1Q PshUAQlFWBlAzy7ZUaARYmB9I8EcpK45rBDGoFkFfSwIkZgZYh8DsaMcPX/O8iPHVKHd qGQitg9tfXsihtJ5kSGP+IbwbDCIZn2Acfr814OTpYDInp5wr1AWxjUOhTOIxuHwAM7Z pZ+PGXJ1CqtsvvQyw2a5pNDUiFsHufWXk/7mlvyLqeSuxbwRSouVFanjp38+3E1V1cGy NUdg== X-Gm-Message-State: AC+VfDyo0+WxVz41MBZbtugC/WnrezKckFizyGZpnq3LyMAuA+q9Y5mv t5E6+hfQCafIvU+FMxX9YhWJHF2BB/wedOlvu5R/j5rp3aLuZJ5sQcFgk5hCpIdicvyRlMm2gVi udVLTTCL1zqJdS/Htmjgo X-Received: by 2002:a05:6214:1304:b0:616:5a74:4577 with SMTP id pn4-20020a056214130400b006165a744577mr54341307qvb.11.1684150846157; Mon, 15 May 2023 04:40:46 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ64/L+1AICd+CF8YmLfYaYQhL090U6OJPKtYRrix5mOzOc05j2LN9MIevk3HkocPx5eb3HtIA== X-Received: by 2002:a05:6214:1304:b0:616:5a74:4577 with SMTP id pn4-20020a056214130400b006165a744577mr54341271qvb.11.1684150845813; Mon, 15 May 2023 04:40:45 -0700 (PDT) Received: from dell-per740-01.7a2m.lab.eng.bos.redhat.com (nat-pool-bos-t.redhat.com. [66.187.233.206]) by smtp.gmail.com with ESMTPSA id s29-20020a05621412dd00b0061693e61dbfsm4794108qvv.63.2023.05.15.04.40.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 May 2023 04:40:45 -0700 (PDT) From: Tom Rix To: bryan.odonoghue@linaro.org, linux@roeck-us.net, heikki.krogerus@linux.intel.com, agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, gregkh@linuxfoundation.org Cc: linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Tom Rix Subject: [PATCH] usb: typec: qcom: set pm8150b_typec_res storage-class-specifier to static Date: Mon, 15 May 2023 07:40:43 -0400 Message-Id: <20230515114043.3452010-1-trix@redhat.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org smatch reports drivers/usb/typec/tcpm/qcom/qcom_pmic_typec.c:323:29: warning: symbol 'pm8150b_typec_res' was not declared. Should it be static? This variable is only used in its defining file, so it should be static Signed-off-by: Tom Rix Reviewed-by: Bryan O'Donoghue Reviewed-by: Heikki Krogerus Reviewed-by: Guenter Roeck --- drivers/usb/typec/tcpm/qcom/qcom_pmic_typec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec.c b/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec.c index 191458ce4a06..937e855a6c4c 100644 --- a/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec.c +++ b/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec.c @@ -320,7 +320,7 @@ static struct pmic_typec_port_resources pm8150b_port_res = { .nr_irqs = 7, }; -struct pmic_typec_resources pm8150b_typec_res = { +static struct pmic_typec_resources pm8150b_typec_res = { .pdphy_res = &pm8150b_pdphy_res, .port_res = &pm8150b_port_res, };