From patchwork Wed May 17 02:18:49 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Dybcio X-Patchwork-Id: 13244068 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B29FC7EE2A for ; Wed, 17 May 2023 02:19:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231685AbjEQCTA (ORCPT ); Tue, 16 May 2023 22:19:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41858 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231860AbjEQCS7 (ORCPT ); Tue, 16 May 2023 22:18:59 -0400 Received: from mail-lj1-x22e.google.com (mail-lj1-x22e.google.com [IPv6:2a00:1450:4864:20::22e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BD4963A87 for ; Tue, 16 May 2023 19:18:57 -0700 (PDT) Received: by mail-lj1-x22e.google.com with SMTP id 38308e7fff4ca-2ad89c7a84fso1356471fa.2 for ; Tue, 16 May 2023 19:18:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1684289936; x=1686881936; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Jz3z44BI7g+ZmvQgxzmcrsNHfKROiTCAupO35cRRnoc=; b=kClaBUy5lYVkbTQ4Y1cUJwNbIfWweEZ9YpHHoXgU0YAabya48bWQJ40fOFY8occH7R iUB537yrAKyH8y3/CZ35khah+4shCszE2vw8LGliDpoRT5ERpRRuqG9SpIX62FlqxasE 8AJkq8nNQfzYEihmiNM85u3oaaKAZy3FguBd13dlM3v+CIETv/2BvrvvzXrVeWhAzIKs 9lXsNIFCACfT69BlQ5jKdewnUKK/Q9u+2A2ny73nGHLR/l9zCOuO1L056nZgFbbuRc+Z 7akF67a/qZiybKXtnhzhAwFAzs8wmgMBmLMN5pLR64GRNeIUC2oxF6/zVOYSsB9FZgHe YJiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684289936; x=1686881936; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Jz3z44BI7g+ZmvQgxzmcrsNHfKROiTCAupO35cRRnoc=; b=Qq4XWlvIPoKrRSbRd6hNH444JSrhYGh01ilbp10ZEloRalXKtKYZgPu+c0yv1LRnp1 kx6XmVe7aOlNev9xoqaN6Z7OL7IMkcJDObAeNoHIkL9tUxGDRTD5/+jHn38Y81PbzYlx xBg3tPcYH23NsHPgG61lU86ye7DHh8LCT5YN7GZ9w7lEjqdlPofKJNhqAcQRryBnptFz z5Kw3arUK31W5KlrgAqIjz/Wm6F/HtWXO9iskQPlWBPwLEpfs5orr8wsnRnIXHlp9O6F xuA2/afEn3iuzm3qHl9iAw0T9Uj8eHnVfNClKoYpK13eRbfig4yU4TO98D4DruC5qeCU ADAw== X-Gm-Message-State: AC+VfDxJoAZJ0lrX8BJRZmV3Pt9gy4syT4xz/L7L9VIj370JH2zN1/Ks NHnsdKDhq7C4LRQi6HnO+n6dnw== X-Google-Smtp-Source: ACHHUZ66dOMCy0XMY0FXupx0/9rdyz37oDv9BaNAMlw1txb6SKgIFfXhT/CSzr6/Wir6weBJvgNNvQ== X-Received: by 2002:a2e:3e08:0:b0:2ac:767c:ae14 with SMTP id l8-20020a2e3e08000000b002ac767cae14mr8096551lja.19.1684289935902; Tue, 16 May 2023 19:18:55 -0700 (PDT) Received: from [10.167.154.1] (public-gprs529629.centertel.pl. [31.61.188.30]) by smtp.gmail.com with ESMTPSA id z22-20020a2e9656000000b002af01da6c67sm384232ljh.32.2023.05.16.19.18.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 May 2023 19:18:55 -0700 (PDT) From: Konrad Dybcio Date: Wed, 17 May 2023 04:18:49 +0200 Subject: [PATCH 1/2] dt-bindings: cache: qcom,llcc: Fix SM8550 description MIME-Version: 1.0 Message-Id: <20230517-topic-kailua-llcc-v1-1-d57bd860c43e@linaro.org> References: <20230517-topic-kailua-llcc-v1-0-d57bd860c43e@linaro.org> In-Reply-To: <20230517-topic-kailua-llcc-v1-0-d57bd860c43e@linaro.org> To: Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Manivannan Sadhasivam , "Borislav Petkov (AMD)" Cc: Marijn Suijten , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.12.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1684289932; l=955; i=konrad.dybcio@linaro.org; s=20230215; h=from:subject:message-id; bh=+mECFcNGWfDIiv+m+e4NFJpbpPzCAtKBP5iEoJkWFJE=; b=t3vQgRkUriq5xl5T/CjwoBBUauqUfLsRKPULgh8X7ioEfzBYhNw0iUT5FNdZEQihgTiSD5Rva OprF4TwyDHzB5BeGxYNfSuMznWbDpTY8gyrTP9HSDQCX2NRww3xkUPP X-Developer-Key: i=konrad.dybcio@linaro.org; a=ed25519; pk=iclgkYvtl2w05SSXO5EjjSYlhFKsJ+5OSZBjOkQuEms= Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org SM8550 (LLCCv4.1) has 4 register regions, this was not described between its addition and the restructurization that happened in the commit referenced in the fixes tag. Fix it. Fixes: 43aa006e074c ("dt-bindings: arm: msm: Fix register regions used for LLCC banks") Signed-off-by: Konrad Dybcio Acked-by: Manivannan Sadhasivam Acked-by: Krzysztof Kozlowski --- Documentation/devicetree/bindings/cache/qcom,llcc.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/cache/qcom,llcc.yaml b/Documentation/devicetree/bindings/cache/qcom,llcc.yaml index d8b91944180a..44892aa589fd 100644 --- a/Documentation/devicetree/bindings/cache/qcom,llcc.yaml +++ b/Documentation/devicetree/bindings/cache/qcom,llcc.yaml @@ -129,6 +129,7 @@ allOf: - qcom,sm8250-llcc - qcom,sm8350-llcc - qcom,sm8450-llcc + - qcom,sm8550-llcc then: properties: reg: From patchwork Wed May 17 02:18:50 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Dybcio X-Patchwork-Id: 13244069 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A31A5C77B7A for ; Wed, 17 May 2023 02:19:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231889AbjEQCTB (ORCPT ); Tue, 16 May 2023 22:19:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41916 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231886AbjEQCTB (ORCPT ); Tue, 16 May 2023 22:19:01 -0400 Received: from mail-lj1-x236.google.com (mail-lj1-x236.google.com [IPv6:2a00:1450:4864:20::236]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5D5AE3AB1 for ; Tue, 16 May 2023 19:18:59 -0700 (PDT) Received: by mail-lj1-x236.google.com with SMTP id 38308e7fff4ca-2ac80ed7f26so1354281fa.1 for ; Tue, 16 May 2023 19:18:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1684289937; x=1686881937; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=PiwfnxHpTyL1B4ayjglsH0C61007tFWAsNvE7dIFkrY=; b=mu6X2ZUoQp+726STqGqjI0ZOiQpGbbIU7rq2AdIvry4lqNAzlMVFVmsEyYmwYITzp5 A7+LL3MbY6GXK3dQy00cdOUfJAWY4Ow6VX4Yf0RRFRSPnHvYvP0FG6E0FZNhX+HuZQ3d goeTIrFpX0S2kYONiaFuqxMPkBIaJH8jHPRQDmTRXiuljr5tKgYCtoLnEKfiNd3es3XC jxeYkG8i9MdO9Plrv2p54/ZgSVGcMLW/ApGkgeJDP4HwfRqJnc/ErPHOH8zE/eZs4Hp4 KK79O0IKAxXyrU2NozVLhlF4jai/eBTASoiqesubrA1SUcbt6IUh99oq6vOPhwD4cBvZ v1aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684289937; x=1686881937; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PiwfnxHpTyL1B4ayjglsH0C61007tFWAsNvE7dIFkrY=; b=KB618s9WRk7RLG+Wy0QAdNbMIuQBvskYep1IZ7cbmDVBbHTuK/+e7saRSXevon1NRu yi2hr3qFLpOIPn11o0UvdcYpNzW89JbyEd/5XL4PPXyKx6jbbYUgyGKkmuwu8yHC806O HN6JL5dSbBNSIPw/iZfgRW+FUZ7RzhqRNxfUjxbDY10uLki2DMlvMSJ4AHpH8SSVmaXF wZVRtDk2GLlApTia94U44aXf2oiaxy5O2ytWY/5+jYLEJqYAUA6EvPNwZiFQ+4pHyGS3 JJdFJPWp/Fv7XJyIWUKLKz6F42pV17V4mH7jNrz2USO8yYu1/LvtdaDLmrx/qFwOdMoQ uZnw== X-Gm-Message-State: AC+VfDyfXHguvmno8HY51rCuuMzujWMIlg2nyPzVapH2XMZ/eL5qVee0 e1ft55VI1yedw8p8g0GAMLlvGA== X-Google-Smtp-Source: ACHHUZ7D+LOuI/MHSp0j2cZk14xGuFren+3QxYP0Kp6IpsCXfPo+KsUQD4fBUk5Qb5FWBNmZiVW0jQ== X-Received: by 2002:a2e:90ca:0:b0:2a7:f1e8:b08 with SMTP id o10-20020a2e90ca000000b002a7f1e80b08mr8368282ljg.19.1684289937496; Tue, 16 May 2023 19:18:57 -0700 (PDT) Received: from [10.167.154.1] (public-gprs529629.centertel.pl. [31.61.188.30]) by smtp.gmail.com with ESMTPSA id z22-20020a2e9656000000b002af01da6c67sm384232ljh.32.2023.05.16.19.18.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 May 2023 19:18:57 -0700 (PDT) From: Konrad Dybcio Date: Wed, 17 May 2023 04:18:50 +0200 Subject: [PATCH 2/2] arm64: dts: qcom: sm8550: Use the correct LLCC register scheme MIME-Version: 1.0 Message-Id: <20230517-topic-kailua-llcc-v1-2-d57bd860c43e@linaro.org> References: <20230517-topic-kailua-llcc-v1-0-d57bd860c43e@linaro.org> In-Reply-To: <20230517-topic-kailua-llcc-v1-0-d57bd860c43e@linaro.org> To: Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Manivannan Sadhasivam , "Borislav Petkov (AMD)" Cc: Marijn Suijten , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.12.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1684289932; l=1384; i=konrad.dybcio@linaro.org; s=20230215; h=from:subject:message-id; bh=9WupzzHlTXR6Yx1uELACzjwgFEN+yOqghs8q/dMHZUU=; b=rFjT625Yg2dYY1oD64UITRGGu/MBYdyR/8rF4bL7kaslFDWb1Tds8XtFi8cYWb3v0dYnaS8oc AOCfXsDEx+VCRfOIOvSGgSBuj87pLKKbwZ1dY8CRC0910fhCY8F1KXs X-Developer-Key: i=konrad.dybcio@linaro.org; a=ed25519; pk=iclgkYvtl2w05SSXO5EjjSYlhFKsJ+5OSZBjOkQuEms= Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org During the ABI-breaking (for good reasons) conversion of the LLCC register description, SM8550 was not taken into account, resulting in LLCC being broken on any kernel containing the patch referenced in the fixes tag. Fix it by describing the regions properly. Fixes: ee13b5008707 ("qcom: llcc/edac: Fix the base address used for accessing LLCC banks") Signed-off-by: Konrad Dybcio Acked-by: Manivannan Sadhasivam --- arch/arm64/boot/dts/qcom/sm8550.dtsi | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sm8550.dtsi b/arch/arm64/boot/dts/qcom/sm8550.dtsi index 6e9bad8f6f33..70ae7e2e900a 100644 --- a/arch/arm64/boot/dts/qcom/sm8550.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8550.dtsi @@ -3762,9 +3762,16 @@ gem_noc: interconnect@24100000 { system-cache-controller@25000000 { compatible = "qcom,sm8550-llcc"; - reg = <0 0x25000000 0 0x800000>, + reg = <0 0x25000000 0 0x200000>, + <0 0x25200000 0 0x200000>, + <0 0x25400000 0 0x200000>, + <0 0x25600000 0 0x200000>, <0 0x25800000 0 0x200000>; - reg-names = "llcc_base", "llcc_broadcast_base"; + reg-names = "llcc0_base", + "llcc1_base", + "llcc2_base", + "llcc3_base", + "llcc_broadcast_base"; interrupts = ; };