From patchwork Wed May 17 11:14:05 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 13244722 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AD241C77B7A for ; Wed, 17 May 2023 11:15:53 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 78B4D1F6; Wed, 17 May 2023 13:15:00 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 78B4D1F6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1684322150; bh=5DZBLVR8fj7Hlj/5x/U4EV4FdPn3n+QxCrvKnSjDzIY=; h=From:To:Cc:Subject:Date:List-Id:List-Archive:List-Help:List-Owner: List-Post:List-Subscribe:List-Unsubscribe:From; b=aR8ggdweEVnmQBz0L65pR5JoEQGmCTClxusZJBCw7qDtnzKMfhF2yPZiePot4xjnO dGjS1z6NnSbFPbFRrv2C2lM6g2ME4k8PtPDJau7yj/ftIc8vFZCTAAO6rTT8HzBc5w 88YEX7GKEScRTJu6DxojwTSlxLthD0FJNu2xZhXo= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 7F47EF80549; Wed, 17 May 2023 13:14:55 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 88966F80549; Wed, 17 May 2023 13:14:54 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 2D1FAF80548; Wed, 17 May 2023 13:14:48 +0200 (CEST) Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [IPv6:2a00:1450:4864:20::636]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 4A2D8F8016A for ; Wed, 17 May 2023 13:14:40 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 4A2D8F8016A Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=sIfEiJbF Received: by mail-ej1-x636.google.com with SMTP id a640c23a62f3a-965f7bdab6bso111872366b.3 for ; Wed, 17 May 2023 04:14:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1684322079; x=1686914079; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=8f/Ov+L9lgAMMtQvsESvWR48vQlBSC6eGHRApShSvK4=; b=sIfEiJbFesnboqrvDwg/JbxitCUki5aOESmQeTg6BQTaFmpQel55ARJNOzBd8Mm4FZ fL+tqM9jp+I4U1fmvk7eAQehUtyk/TO+AAf9RFsKbKkkeNL6LvaF4LYZf9tyVKUlhdHG i/DH2lMxWzJ7WPE4l4CfVfUWeP2GrHWEytoP6jrQX7Zkda97O0tWivR4CwTB9QHVEG1K rBrCq0Y2omMSb5Z4kuCIJMQcJtoef5ryB9wcSy0/JXqX6taG1+ccb7qg58us2ne/Zb0p 7V10XrAmSJFkQZ4ZLTGvktUpzOfMUh1Q3cz8HYSdwZJS0JiMw8iiZs2Yq8MuIiFD1/N1 tN3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684322079; x=1686914079; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=8f/Ov+L9lgAMMtQvsESvWR48vQlBSC6eGHRApShSvK4=; b=RPb9Sz9qrXXSa1Tc+4wpZCDYn8OY5K+xJ00ViAlMnC1Ox07sTw1kARP5JlmkecRp7Q KkjsbPzhT54csEXrw4WWsj47z/JV5hXp6gZZqjPhlBwCdZxpfnYsdwh9oNG/be22FMww KUadCghb7oeqNfRtY9KoTBLRDZGT/AMrOlagb7LbXnJm7IoiX8g/gsIPAJZopVFZTD6P cUXtiIDyxT72CdWSnQSj9E6QrQnkbBuLZI09q19az6ew6b3OeR/Z6CI+sST7ZspsmSp+ /AcLWIrPxPJ1YMc6qcAQXGQIRRst3p6ytN061SMWKQE5PfUJq871utkS1S0Izg6w5zKt WwVA== X-Gm-Message-State: AC+VfDw4fHSsxXGrKAYXw2VyFFE1bcGh9qe4dk9S6Bu2bX6ZT94KXy3w oRaKKI+NLN34cjkEj70VbrfwWA== X-Google-Smtp-Source: ACHHUZ4W3Tqy+kmA5/CrSkwq+i+Z6QU84MiGKQFNv45sP/3v7DwL6mlpqoPP47j1FG0KjZyNBcEakA== X-Received: by 2002:a17:906:9c83:b0:95f:4889:412a with SMTP id fj3-20020a1709069c8300b0095f4889412amr39964429ejc.33.1684322078958; Wed, 17 May 2023 04:14:38 -0700 (PDT) Received: from krzk-bin.. ([2a02:810d:15c0:828:c9ff:4c84:dd21:568d]) by smtp.gmail.com with ESMTPSA id ml18-20020a170906cc1200b0094f124a37c4sm12326880ejb.18.2023.05.17.04.14.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 May 2023 04:14:38 -0700 (PDT) From: Krzysztof Kozlowski To: Oder Chiou , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 01/12] ASoC: codecs: rt1308: do not store status in state container Date: Wed, 17 May 2023 13:14:05 +0200 Message-Id: <20230517111416.424420-1-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Message-ID-Hash: NB4HZR5Y4DYO6DHJ2TK6MENQ2GCSELM7 X-Message-ID-Hash: NB4HZR5Y4DYO6DHJ2TK6MENQ2GCSELM7 X-MailFrom: krzysztof.kozlowski@linaro.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Driver in its update status callback stores Soundwire device status in state container but it never uses it later. Simplify the code a bit. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Pierre-Louis Bossart --- sound/soc/codecs/rt1308-sdw.c | 5 +---- sound/soc/codecs/rt1308-sdw.h | 1 - 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/sound/soc/codecs/rt1308-sdw.c b/sound/soc/codecs/rt1308-sdw.c index 1797af824f60..313e97c94532 100644 --- a/sound/soc/codecs/rt1308-sdw.c +++ b/sound/soc/codecs/rt1308-sdw.c @@ -304,9 +304,6 @@ static int rt1308_update_status(struct sdw_slave *slave, { struct rt1308_sdw_priv *rt1308 = dev_get_drvdata(&slave->dev); - /* Update the status */ - rt1308->status = status; - if (status == SDW_SLAVE_UNATTACHED) rt1308->hw_init = false; @@ -314,7 +311,7 @@ static int rt1308_update_status(struct sdw_slave *slave, * Perform initialization only if slave status is present and * hw_init flag is false */ - if (rt1308->hw_init || rt1308->status != SDW_SLAVE_ATTACHED) + if (rt1308->hw_init || status != SDW_SLAVE_ATTACHED) return 0; /* perform I/O transfers required for Slave initialization */ diff --git a/sound/soc/codecs/rt1308-sdw.h b/sound/soc/codecs/rt1308-sdw.h index 04ff18fa18e2..f816c73e247e 100644 --- a/sound/soc/codecs/rt1308-sdw.h +++ b/sound/soc/codecs/rt1308-sdw.h @@ -159,7 +159,6 @@ struct rt1308_sdw_priv { struct snd_soc_component *component; struct regmap *regmap; struct sdw_slave *sdw_slave; - enum sdw_slave_status status; struct sdw_bus_params params; bool hw_init; bool first_hw_init; From patchwork Wed May 17 11:14:06 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 13244724 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E253EC77B7A for ; Wed, 17 May 2023 11:16:46 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id D69EB741; Wed, 17 May 2023 13:15:54 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz D69EB741 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1684322204; bh=RvpHwH01qmPYAihvG2vJZiuCzGTzttgPxBWb44p2wLo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=khpcKNh4ZJGQqqwLyfDv+T9vZP3TBFzdY3VkBAcNKFpZL6ZM+lIxJfGmSIjaVADOe pJX5+9wgg3P4o9njn527Kcs+lCaoVcC/fVttyXlhqT0ds5YMjt8Egkci8sfRzTxEla P6e3FtwvU/5BQjyjYuxI8CY6XkIuZYhkNB5EGW+M= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 7DA1FF8057A; Wed, 17 May 2023 13:15:02 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 7D913F8057A; Wed, 17 May 2023 13:15:01 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 3270CF80548; Wed, 17 May 2023 13:14:51 +0200 (CEST) Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [IPv6:2a00:1450:4864:20::629]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id E2B59F8016D for ; Wed, 17 May 2023 13:14:41 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz E2B59F8016D Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=Xtqjci4X Received: by mail-ej1-x629.google.com with SMTP id a640c23a62f3a-9661047f8b8so107440666b.0 for ; Wed, 17 May 2023 04:14:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1684322080; x=1686914080; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=MAqmALiwc11sAnAJSge5XtvJDOci8R9bv0tfhhHhu0U=; b=Xtqjci4XXLDyaSfLmoL3GH9a66Wn20m9qX10IAhmV5YCbC9FqW/gSQhxvp8mMTJpNE OeovLhwFZuK2cGjdqe0dZkA9Ub46RgWo31XNE4W8793NsgsxRjrvggmNki0sdcC711fF f4VYa5bA9X8UtiOddbUZ+4s80EGBHLCOYPLlv7FjFz++siY4Rfl+xFnUnRq5tDfWMf88 AcFqRubiMXgUBXyoKYD71Q1lzNzWT1TNX/S9RO0oqx8xKSTXTVnILq8W6YCY/mTaNHVz fV3YGEd2vKyHx/ryBmYY5Q105wjikO7EQ32VB9OLbL2lkz05+s6dOtVtyoXpk67lVD61 iSaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684322080; x=1686914080; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MAqmALiwc11sAnAJSge5XtvJDOci8R9bv0tfhhHhu0U=; b=i04NwTa279p7D9h9H1r5/IgKc1le71MK4gGEJULNV/OKDxzJdoovWOvMOI+/v8krgJ Md/JEA6sNl8TGEg3E53W+oE5YudTD7QU7H+nErUMK10W715JztvChViTW33Lvwkopcnn ax7qISaDhOXYIGH2KnQTLejO0VetXcp2pD4Akxjsayw+e8ztuIqGphO/w3G9WxGEZIZW QOsqcXo4/AOnGJHVdjy1uLgR8+P/teWYxOkPGdB1GfXB2BvLYIN02SIWvWdKiJL8N78b LMQZhBHFeZE/KDiiZxObAz0XwKIVv0SrARo88jNcdryTqDHLGfxrmuXSpXqWknAU0mio tY6w== X-Gm-Message-State: AC+VfDzskOxsSuLtX6sQw9hPe20bZ2pd9KKHxslXR2menJc8hUZAuRdS BRPpoBrUehGQxC4PevI/C2H8og== X-Google-Smtp-Source: ACHHUZ6HWoBfX2XrD7IXrL+hJZA8QoR0fr8+uZLTZShrjMYmoYmQnhgXL7NPlQyHhFag68Tv7SlmAQ== X-Received: by 2002:a17:907:1614:b0:8a5:8620:575 with SMTP id hb20-20020a170907161400b008a586200575mr38600206ejc.3.1684322079941; Wed, 17 May 2023 04:14:39 -0700 (PDT) Received: from krzk-bin.. ([2a02:810d:15c0:828:c9ff:4c84:dd21:568d]) by smtp.gmail.com with ESMTPSA id ml18-20020a170906cc1200b0094f124a37c4sm12326880ejb.18.2023.05.17.04.14.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 May 2023 04:14:39 -0700 (PDT) From: Krzysztof Kozlowski To: Oder Chiou , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 02/12] ASoC: codecs: rt1316: do not store status in state container Date: Wed, 17 May 2023 13:14:06 +0200 Message-Id: <20230517111416.424420-2-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230517111416.424420-1-krzysztof.kozlowski@linaro.org> References: <20230517111416.424420-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Message-ID-Hash: CCAAXSV6VCX472LGHHO7LCGPYLSO47Y2 X-Message-ID-Hash: CCAAXSV6VCX472LGHHO7LCGPYLSO47Y2 X-MailFrom: krzysztof.kozlowski@linaro.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Driver in its update status callback stores Soundwire device status in state container but it never uses it later. Simplify the code a bit. Signed-off-by: Krzysztof Kozlowski --- sound/soc/codecs/rt1316-sdw.c | 5 +---- sound/soc/codecs/rt1316-sdw.h | 1 - 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/sound/soc/codecs/rt1316-sdw.c b/sound/soc/codecs/rt1316-sdw.c index 2ee5e763e345..601b76320124 100644 --- a/sound/soc/codecs/rt1316-sdw.c +++ b/sound/soc/codecs/rt1316-sdw.c @@ -323,9 +323,6 @@ static int rt1316_update_status(struct sdw_slave *slave, { struct rt1316_sdw_priv *rt1316 = dev_get_drvdata(&slave->dev); - /* Update the status */ - rt1316->status = status; - if (status == SDW_SLAVE_UNATTACHED) rt1316->hw_init = false; @@ -333,7 +330,7 @@ static int rt1316_update_status(struct sdw_slave *slave, * Perform initialization only if slave status is present and * hw_init flag is false */ - if (rt1316->hw_init || rt1316->status != SDW_SLAVE_ATTACHED) + if (rt1316->hw_init || status != SDW_SLAVE_ATTACHED) return 0; /* perform I/O transfers required for Slave initialization */ diff --git a/sound/soc/codecs/rt1316-sdw.h b/sound/soc/codecs/rt1316-sdw.h index e37121655bc1..dc1bfe40edd3 100644 --- a/sound/soc/codecs/rt1316-sdw.h +++ b/sound/soc/codecs/rt1316-sdw.h @@ -42,7 +42,6 @@ struct rt1316_sdw_priv { struct snd_soc_component *component; struct regmap *regmap; struct sdw_slave *sdw_slave; - enum sdw_slave_status status; struct sdw_bus_params params; bool hw_init; bool first_hw_init; From patchwork Wed May 17 11:14:07 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 13244723 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1A465C77B7A for ; Wed, 17 May 2023 11:16:40 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 87C5D207; Wed, 17 May 2023 13:15:48 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 87C5D207 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1684322198; bh=tzh5dXFEpZxgW78Np01x+PKGa8FiJTOjSub2GDhH/8c=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=uX+V1MWKSC2oiTmzpkMFpcY30vOTIkUrjw/QEH6I6Mzy1x0D84d9GOBNhzAaTR8hs BzbhcN36D+8NVbzeE29Xm6N4sHNX6hdVLTcxcjJXhOdfNrpqOoGyUt5oKTmyT+ixnz bTHixSakzB6Wiei2NTFI5MEBtIfidvXySqF0qCCs= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 58B69F80272; Wed, 17 May 2023 13:14:58 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 6DA7BF80272; Wed, 17 May 2023 13:14:57 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 913C8F80548; Wed, 17 May 2023 13:14:49 +0200 (CEST) Received: from mail-ej1-x62a.google.com (mail-ej1-x62a.google.com [IPv6:2a00:1450:4864:20::62a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 4DFD0F80272 for ; Wed, 17 May 2023 13:14:42 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 4DFD0F80272 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=ZZNYO7Tc Received: by mail-ej1-x62a.google.com with SMTP id a640c23a62f3a-965f7bdab6bso111880466b.3 for ; Wed, 17 May 2023 04:14:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1684322081; x=1686914081; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=if7YQ3Jqyx8UU5QrJc7rocl2hzsm+T3skIrYgPJcbZ8=; b=ZZNYO7TcWQf/4w4gaLWDpyEDeka0OZxVnDIc5sRFsbyL/9iZbbCbx8vZeGO60WRFhB YLphCf2UBV/33sliiaI7pZOZcIbc4EdrzIGyc1D2yJtr5YqERyrQU6BHQw7geeHsJMgi A+7VlGTrw60J1oVPDJM1snYMD83sN+QavQAzljMoYOar3YRW+z75gZmjxEhfoGggEpyk iRtTJBOWA3sqG0ZOyMgr1A9JmnQySodh9VbOmIl2ePjKQol4vaxxWXB2+jg+lFNtGEpC P0iYa3Fh1tOvll/kwkHI+dcf6CvViL7HlLsqo05a+Pd7MhA4g2mCWbXJlRTm80zUD3yL zezQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684322081; x=1686914081; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=if7YQ3Jqyx8UU5QrJc7rocl2hzsm+T3skIrYgPJcbZ8=; b=MGYm+exnp+IrqAMvmrqcL6Y4WqJ8/BBtbDB9DfM6LJhTxrmnGcDkFTTvd0dBewS3y3 hHKMkmlPhvRhL+YSQlV8UaazmnqpV2bSPy9VRbUSbhBHFMMa4rtKpnPJbgtvp5pPzem9 C02r7vvfkfALy21Xnex0ew5KDrSGmQpZAd2601JlOjZz8XtsiFQj2ikDkawHQYfahf92 ZKa6syKRVlOf3tuE6tbd9VEzPRZvzfOeAJ88xafAZpET/kk3VG5s7Z78443zcVTfAWhF hJj/Ie6uW9mXLpeANnyRzeYSEK8+HZCXgJeEjVFRKArtpZ5uWszE2BICDwb9rXDzvhyr hdRw== X-Gm-Message-State: AC+VfDxavvB4/i3QHb9C1zPnkPKD6pJdzCYpAQcIW5+IfdGCsZnr+qxm NKyQPteo47E4PjnrwtUqaZMW8A== X-Google-Smtp-Source: ACHHUZ5y2fv3RY686++601FfyO2aihA2Vrj8kltsyQOYUSLWJ+uJ9GBrL9eipsMCxlpfhVJxYk99QA== X-Received: by 2002:a17:906:5d11:b0:96f:181b:87da with SMTP id g17-20020a1709065d1100b0096f181b87damr66787ejt.69.1684322081001; Wed, 17 May 2023 04:14:41 -0700 (PDT) Received: from krzk-bin.. ([2a02:810d:15c0:828:c9ff:4c84:dd21:568d]) by smtp.gmail.com with ESMTPSA id ml18-20020a170906cc1200b0094f124a37c4sm12326880ejb.18.2023.05.17.04.14.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 May 2023 04:14:40 -0700 (PDT) From: Krzysztof Kozlowski To: Oder Chiou , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 03/12] ASoC: codecs: rt1318: do not store status in state container Date: Wed, 17 May 2023 13:14:07 +0200 Message-Id: <20230517111416.424420-3-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230517111416.424420-1-krzysztof.kozlowski@linaro.org> References: <20230517111416.424420-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Message-ID-Hash: 2YFNH3YUNMPUORNNQDY46D2ZSTAILQ2B X-Message-ID-Hash: 2YFNH3YUNMPUORNNQDY46D2ZSTAILQ2B X-MailFrom: krzysztof.kozlowski@linaro.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Driver in its update status callback stores Soundwire device status in state container but it never uses it later. Simplify the code a bit. Signed-off-by: Krzysztof Kozlowski --- sound/soc/codecs/rt1318-sdw.c | 5 +---- sound/soc/codecs/rt1318-sdw.h | 1 - 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/sound/soc/codecs/rt1318-sdw.c b/sound/soc/codecs/rt1318-sdw.c index 795accedc22c..3751d923611c 100644 --- a/sound/soc/codecs/rt1318-sdw.c +++ b/sound/soc/codecs/rt1318-sdw.c @@ -456,9 +456,6 @@ static int rt1318_update_status(struct sdw_slave *slave, { struct rt1318_sdw_priv *rt1318 = dev_get_drvdata(&slave->dev); - /* Update the status */ - rt1318->status = status; - if (status == SDW_SLAVE_UNATTACHED) rt1318->hw_init = false; @@ -466,7 +463,7 @@ static int rt1318_update_status(struct sdw_slave *slave, * Perform initialization only if slave status is present and * hw_init flag is false */ - if (rt1318->hw_init || rt1318->status != SDW_SLAVE_ATTACHED) + if (rt1318->hw_init || status != SDW_SLAVE_ATTACHED) return 0; /* perform I/O transfers required for Slave initialization */ diff --git a/sound/soc/codecs/rt1318-sdw.h b/sound/soc/codecs/rt1318-sdw.h index 85918c184f16..86e83d63a017 100644 --- a/sound/soc/codecs/rt1318-sdw.h +++ b/sound/soc/codecs/rt1318-sdw.h @@ -88,7 +88,6 @@ struct rt1318_sdw_priv { struct snd_soc_component *component; struct regmap *regmap; struct sdw_slave *sdw_slave; - enum sdw_slave_status status; struct sdw_bus_params params; bool hw_init; bool first_hw_init; From patchwork Wed May 17 11:14:08 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 13244742 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 87EDEC77B75 for ; Wed, 17 May 2023 11:20:31 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 7362282A; Wed, 17 May 2023 13:19:39 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 7362282A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1684322429; bh=5A+u31d9cvQOefS+rAXPmsmb/kUKAXdw4oQfS5rt5+Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=mH3AOMI7J2P/InB8A7EHe0tiYbcXzBi1tCvDgpzSU5WKbM24StmBfB4WTzbCB5SG1 whOxPlmEF7jF8lBJ7v4q29LRWuA/M4p6MFBwW+0MyPqIHrwWSJmV49+HxFVzJtidO7 QcD9Obir6hhmyVC07NZJaRhsPppmlCK0W5C9papY= Received: by alsa1.perex.cz (Postfix, from userid 50401) id CA1B3F80588; Wed, 17 May 2023 13:17:08 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 1EE7BF802E8; Wed, 17 May 2023 13:17:08 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id DF814F80272; Wed, 17 May 2023 13:17:01 +0200 (CEST) Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [IPv6:2a00:1450:4864:20::52f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 1AAC7F8025A for ; Wed, 17 May 2023 13:14:43 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 1AAC7F8025A Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=AzaZ4guz Received: by mail-ed1-x52f.google.com with SMTP id 4fb4d7f45d1cf-510b56724caso8456530a12.1 for ; Wed, 17 May 2023 04:14:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1684322082; x=1686914082; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=HEOOEjR671HfmOXPgQqMUHzrdAM2unOi/T1lUcVo2j0=; b=AzaZ4guzFC7mjzLyKRvNGAUkMMT+3Wa2whIOYVnJeD+QyZ8EBww+DnbNc8pW9F8KvM RoEO4BMABU8T3j9OJeY7RXkgrFJO88Qc3bpF9ewu6lRPm01+JjTV7QXpBSOJo38+G8bp apympiZR1cjbuuKJFlidTumihU9/KGAQLnnSaSrQSiGNyPYssn1XKliSaqWAnHV21pwQ atF8ps54PE8dNWH2cPVxYzif9k97D77l9URcXuo+ehsuiyRzh0F5C97ifI6JIyvQj6w5 SyOurd9nCf0A2D4c4Zw5WLOYPJ79xD5KufmjXXKv+Vzwwnbe+w/A0c4Ay9Jig7OrVISB VBTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684322082; x=1686914082; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HEOOEjR671HfmOXPgQqMUHzrdAM2unOi/T1lUcVo2j0=; b=MuZnpa1HlzXEKZfktd4WVPLr1bz0DHAUS77om3VytiNZ88p5R3w6LgZgUwRhDZ+ouF ghLBzC1gUdyqAPBakq472TP8/YL+QvgOW6Ns4EsG6IN80jSb9hP8EGd14OIBSPXqQ4dS LQS1tGZFt4/HGJrmb1tIylMYthBAH5kvNbMJz8K9cb7RWsDnQf2VuCFrIu3XPwlBRvOw oCiMSRQd0JuKUovIZW8sgSD3hYy2D94LlYNEkH1TgzxEFT8Zc5k8kGCytsrkYZKVZG2s lYB3WxL0+Yhp/uY+ff7T5puEHytsZ1CPl3K36sC+n0tFtoHnROsoGUHiT92GeuPNJ1TU wnMg== X-Gm-Message-State: AC+VfDyZl+p+xDQXw0aY9bFLBTS4fRX2A81k6u41ff7SKhbJrCOEVYPm tXNLjjHiiZWF4Sa8msOXF6iU+w== X-Google-Smtp-Source: ACHHUZ59bqvno6jHhPiAuS2Tvt4ztbcI9pGqM5YYNJMWeveZwz+QiRkdhrj2byFPUKW1FIM+Mx3+Tw== X-Received: by 2002:a17:907:3e21:b0:94f:2020:b5dd with SMTP id hp33-20020a1709073e2100b0094f2020b5ddmr1773127ejc.24.1684322082024; Wed, 17 May 2023 04:14:42 -0700 (PDT) Received: from krzk-bin.. ([2a02:810d:15c0:828:c9ff:4c84:dd21:568d]) by smtp.gmail.com with ESMTPSA id ml18-20020a170906cc1200b0094f124a37c4sm12326880ejb.18.2023.05.17.04.14.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 May 2023 04:14:41 -0700 (PDT) From: Krzysztof Kozlowski To: Oder Chiou , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 04/12] ASoC: codecs: rt5682: do not store status in state container Date: Wed, 17 May 2023 13:14:08 +0200 Message-Id: <20230517111416.424420-4-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230517111416.424420-1-krzysztof.kozlowski@linaro.org> References: <20230517111416.424420-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Message-ID-Hash: U2EAF2IVTVLF4UM24LGOS2HJFHM5Z3PC X-Message-ID-Hash: U2EAF2IVTVLF4UM24LGOS2HJFHM5Z3PC X-MailFrom: krzysztof.kozlowski@linaro.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Driver in its update status callback stores Soundwire device status in state container but it never uses it later. Simplify the code a bit. Signed-off-by: Krzysztof Kozlowski --- sound/soc/codecs/rt5682-sdw.c | 5 +---- sound/soc/codecs/rt5682.h | 1 - 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/sound/soc/codecs/rt5682-sdw.c b/sound/soc/codecs/rt5682-sdw.c index 6e3b5c5eced1..67404f45389f 100644 --- a/sound/soc/codecs/rt5682-sdw.c +++ b/sound/soc/codecs/rt5682-sdw.c @@ -500,9 +500,6 @@ static int rt5682_update_status(struct sdw_slave *slave, { struct rt5682_priv *rt5682 = dev_get_drvdata(&slave->dev); - /* Update the status */ - rt5682->status = status; - if (status == SDW_SLAVE_UNATTACHED) rt5682->hw_init = false; @@ -510,7 +507,7 @@ static int rt5682_update_status(struct sdw_slave *slave, * Perform initialization only if slave status is present and * hw_init flag is false */ - if (rt5682->hw_init || rt5682->status != SDW_SLAVE_ATTACHED) + if (rt5682->hw_init || status != SDW_SLAVE_ATTACHED) return 0; /* perform I/O transfers required for Slave initialization */ diff --git a/sound/soc/codecs/rt5682.h b/sound/soc/codecs/rt5682.h index d568c6993c33..301d1817f8f1 100644 --- a/sound/soc/codecs/rt5682.h +++ b/sound/soc/codecs/rt5682.h @@ -1440,7 +1440,6 @@ struct rt5682_priv { bool disable_irq; struct mutex calibrate_mutex; struct sdw_slave *slave; - enum sdw_slave_status status; struct sdw_bus_params params; bool hw_init; bool first_hw_init; From patchwork Wed May 17 11:14:09 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 13244726 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2FF60C77B7A for ; Wed, 17 May 2023 11:17:11 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 0C71A1FE; Wed, 17 May 2023 13:16:19 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 0C71A1FE DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1684322229; bh=WQAEl/gZZ5NDWQLu66XAjj06GOPtDZqOY+L7Y6XaC2o=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=cMfcdeUb8Ac5svX1fsutmXkqKAk1reWLGf4SXJ7RI2HI+xZPfxPoyPGknzBkY6VMW LP7xH3aDT8zbexYW+hJ8GUSYMHlyJy6OJB7T9ZVtayWG2i6zthT4Te8wZC4LvGhSf3 JZHQt17zaxNfmrYX7YjSu7+xDd2Mz91tJ++5pHeU= Received: by alsa1.perex.cz (Postfix, from userid 50401) id D0986F80589; Wed, 17 May 2023 13:15:08 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 1CD48F805A1; Wed, 17 May 2023 13:15:08 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 5971EF80551; Wed, 17 May 2023 13:14:54 +0200 (CEST) Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [IPv6:2a00:1450:4864:20::62c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 1E2AEF80431 for ; Wed, 17 May 2023 13:14:44 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 1E2AEF80431 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=jbpNsTPc Received: by mail-ej1-x62c.google.com with SMTP id a640c23a62f3a-9659443fb56so88803066b.2 for ; Wed, 17 May 2023 04:14:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1684322083; x=1686914083; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Djo3KigDLCeskb1s75wtfFqne73QM8Ssl3dvuMpTj8I=; b=jbpNsTPcndoFQHxB+zZE1pvWH6PB3oOk0GGSHncVFq60Pzl6/guO3elUgCzUb1JJ+Q PQViAH4X+DushQPeB5Y5oeEEQEDP3KD/iPA0Ba77Q1ahp2/9sa+QlD2OOprF3UBIrBJ6 34Co2bwv+wutKc8XkhQCkHobGDC9RF38e1IxFFGN4RV19S759tGHdeMOdsqFQ1G9bmcS WMgKTAtKG1OC927Cy8zgj0w2ELDbAcK4InSxId+JgPETgPIQcBnlUrIIJMJ9OC+DHO8p SsFH+tQwFz9uLp9jUA7Jb7HwfnADeDu7jdutszLl1wIveRUC8OV4jK+Iw0uwUZ86jtUx Zl3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684322083; x=1686914083; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Djo3KigDLCeskb1s75wtfFqne73QM8Ssl3dvuMpTj8I=; b=dQqud5ADgnfy+yL5tYD0aNzRskAHdie7JndnjyU2z/CWGErQM6p3J0sNSaICwtGIwO TsFzaRn1Rg5mJ856a8E90eJS6KoSXiK+rDBQTG0NM89kZ83mYDH2yx0oMf4OyIZFrfgr sRuw1vBBSybMQwQumuq+KfFW6ixdA6osdx0ptVpVz2cpoTDv+eWBSYJHc5/JqU/QQVD0 hVFtuFTR0GvPtiZB2AS4UJeLBXKSkCh9hdJ70DI231oNljdiP0vSiN5wJpZ2H65uzsGs 5oHUUBpdMMrAepZRIFoh1AxZn+xf45mTdgcD/7DW5vtBgfJhKsx7enAyi202joeicF7/ O7Dw== X-Gm-Message-State: AC+VfDw0BrXaHRs2a3gEWAWNEpi3hGueoOyUrrRp7j0UimoifgZ/2RAp 4/k/jM736E2Czke9pAUjaPryLQ== X-Google-Smtp-Source: ACHHUZ5mFQSEguv8gaktTRSSdWDKj7/SzUCfiPmUxPkyuqet8SRiloCcTWaYK0ZnTY5zuXJpdG1PxQ== X-Received: by 2002:a17:907:940e:b0:94e:e5fe:b54f with SMTP id dk14-20020a170907940e00b0094ee5feb54fmr36761324ejc.23.1684322083094; Wed, 17 May 2023 04:14:43 -0700 (PDT) Received: from krzk-bin.. ([2a02:810d:15c0:828:c9ff:4c84:dd21:568d]) by smtp.gmail.com with ESMTPSA id ml18-20020a170906cc1200b0094f124a37c4sm12326880ejb.18.2023.05.17.04.14.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 May 2023 04:14:42 -0700 (PDT) From: Krzysztof Kozlowski To: Oder Chiou , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 05/12] ASoC: codecs: rt700: do not store status in state container Date: Wed, 17 May 2023 13:14:09 +0200 Message-Id: <20230517111416.424420-5-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230517111416.424420-1-krzysztof.kozlowski@linaro.org> References: <20230517111416.424420-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Message-ID-Hash: W7467CMCAKB7SZEDJKHQNXRI2ULN4OUF X-Message-ID-Hash: W7467CMCAKB7SZEDJKHQNXRI2ULN4OUF X-MailFrom: krzysztof.kozlowski@linaro.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Driver in its update status callback stores Soundwire device status in state container but it never uses it later. Simplify the code a bit. Signed-off-by: Krzysztof Kozlowski --- sound/soc/codecs/rt700-sdw.c | 5 +---- sound/soc/codecs/rt700.h | 1 - 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/sound/soc/codecs/rt700-sdw.c b/sound/soc/codecs/rt700-sdw.c index 96fc5f36d0d0..ba7767bee07c 100644 --- a/sound/soc/codecs/rt700-sdw.c +++ b/sound/soc/codecs/rt700-sdw.c @@ -315,9 +315,6 @@ static int rt700_update_status(struct sdw_slave *slave, { struct rt700_priv *rt700 = dev_get_drvdata(&slave->dev); - /* Update the status */ - rt700->status = status; - if (status == SDW_SLAVE_UNATTACHED) rt700->hw_init = false; @@ -325,7 +322,7 @@ static int rt700_update_status(struct sdw_slave *slave, * Perform initialization only if slave status is present and * hw_init flag is false */ - if (rt700->hw_init || rt700->status != SDW_SLAVE_ATTACHED) + if (rt700->hw_init || status != SDW_SLAVE_ATTACHED) return 0; /* perform I/O transfers required for Slave initialization */ diff --git a/sound/soc/codecs/rt700.h b/sound/soc/codecs/rt700.h index 93c44005d38c..491774d207de 100644 --- a/sound/soc/codecs/rt700.h +++ b/sound/soc/codecs/rt700.h @@ -15,7 +15,6 @@ struct rt700_priv { struct regmap *regmap; struct regmap *sdw_regmap; struct sdw_slave *slave; - enum sdw_slave_status status; struct sdw_bus_params params; bool hw_init; bool first_hw_init; From patchwork Wed May 17 11:14:10 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 13244741 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 134ABC77B75 for ; Wed, 17 May 2023 11:20:19 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 0BAA8207; Wed, 17 May 2023 13:19:27 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 0BAA8207 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1684322417; bh=ErUVptLwjAWleKLanlVJn6PN6qQXAwVR/mzA1LzGfRI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=JSp+pIrR+oGS6EAu9HvLoKeeuvMIXlpO8AjCpe8YZRhk80JGSLw/NF1/7UuuTxPUN sIn5tdbpad34NSQ3EPVi2DemkHbEK7ZdrHoOWYHBTk5nSLVgBaLsxrG7P1QNGTey1z Sf/di3cHCo2gN4ivIh19P593p4YoS8B3OIASJR2w= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 467EEF80552; Wed, 17 May 2023 13:17:06 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id BE4F9F80272; Wed, 17 May 2023 13:17:05 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 46761F80272; Wed, 17 May 2023 13:17:01 +0200 (CEST) Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [IPv6:2a00:1450:4864:20::630]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id EE443F802E8 for ; Wed, 17 May 2023 13:14:45 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz EE443F802E8 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=qT9Hm+vi Received: by mail-ej1-x630.google.com with SMTP id a640c23a62f3a-965ab8ed1fcso104502266b.2 for ; Wed, 17 May 2023 04:14:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1684322084; x=1686914084; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=zsBtC5TfGJN3p6qkzFAO4W1v8Rx/+dqGizHb8O0Kemg=; b=qT9Hm+viZyjnW7qF9Tzwr3hYeysA5pkm7FIUW8J6gLL8bgZy2Q3yNgT634YhZqiWXt k2MqRXHxAe+PmDwkPQUqE8iTWCPWWgWZ7Wrp9BSGk5BYbqOcg/HArsgi2gSe+eokW/uP iQwAHoCP7iIxVJnUnRHW5XQJz542/vhvdUCwqUSrfLrEQHWEZ5BSbEvKAJPBMGE/8A6f Vc6MBE0s/VAxY6GIBGVXRP+JaPbiASGjXUx4NRGq4FVtjNwFwDg7H+eaoVlSN/ht3ZUJ qubKLdGAGqj8EOn9uTpWMtNq0g5Hruw9Bog2kjlwZ3GWxs/IvHpul99eqw1y/f+zgmr8 Dqbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684322084; x=1686914084; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zsBtC5TfGJN3p6qkzFAO4W1v8Rx/+dqGizHb8O0Kemg=; b=K5SAFfzC69oKarYmcjB8Us32OFpwhJXjhgT2Nyd4MKoDBEH13bQVDWPVflNzzmvMSW rGfvhCCpSKRYVXsV8tIboWtNA/6GCZbFGfuM4+1DkGt9Uze++VYqk1f527dg48lkP3iQ C+33r0gYiYhL6Tp+NTyGzzMzbQnrCj3E0402RtXr6UpcHLIX+1AoWOsOe/85Sgyjc1iC GVtFjTMA2LXB63b1rzHkpXf0cZNzReP07rLKIThbMg0m3z7ipNDxMrD+eEGiSzxgBZOH C2ep8HlTkXnAjuL33l2ct2V3/lU7z7A6EHkuNIP2v+xISv/6393fErKVILO/t9ns1Jto 0r7w== X-Gm-Message-State: AC+VfDy1CBfQlqKwpHU+ILn4y7b6dQEy9TlVHFLYggx4uPGcBb6oRbtK YpqJBvXQQOvF8qiA9BGCmhZJAQ== X-Google-Smtp-Source: ACHHUZ7mlo6nRWUJn035zVTJntmQFAoQhlG3G9/1Y3edyg3inGAnP3I4evAsUjOZr5Yt9vQpd/Zwjg== X-Received: by 2002:a17:907:5c7:b0:961:be96:b0e6 with SMTP id wg7-20020a17090705c700b00961be96b0e6mr34403065ejb.68.1684322084257; Wed, 17 May 2023 04:14:44 -0700 (PDT) Received: from krzk-bin.. ([2a02:810d:15c0:828:c9ff:4c84:dd21:568d]) by smtp.gmail.com with ESMTPSA id ml18-20020a170906cc1200b0094f124a37c4sm12326880ejb.18.2023.05.17.04.14.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 May 2023 04:14:43 -0700 (PDT) From: Krzysztof Kozlowski To: Oder Chiou , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 06/12] ASoC: codecs: rt711-sdca: do not store status in state container Date: Wed, 17 May 2023 13:14:10 +0200 Message-Id: <20230517111416.424420-6-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230517111416.424420-1-krzysztof.kozlowski@linaro.org> References: <20230517111416.424420-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Message-ID-Hash: XJJUQU7BEYLP3RJS5WR5GAIK3J5LBFXV X-Message-ID-Hash: XJJUQU7BEYLP3RJS5WR5GAIK3J5LBFXV X-MailFrom: krzysztof.kozlowski@linaro.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Driver in its update status callback stores Soundwire device status in state container but it never uses it later. Simplify the code a bit. Signed-off-by: Krzysztof Kozlowski --- sound/soc/codecs/rt711-sdca-sdw.c | 5 +---- sound/soc/codecs/rt711-sdca.h | 1 - 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/sound/soc/codecs/rt711-sdca-sdw.c b/sound/soc/codecs/rt711-sdca-sdw.c index 51f3335343e0..2c5eb28259dc 100644 --- a/sound/soc/codecs/rt711-sdca-sdw.c +++ b/sound/soc/codecs/rt711-sdca-sdw.c @@ -143,9 +143,6 @@ static int rt711_sdca_update_status(struct sdw_slave *slave, { struct rt711_sdca_priv *rt711 = dev_get_drvdata(&slave->dev); - /* Update the status */ - rt711->status = status; - if (status == SDW_SLAVE_UNATTACHED) rt711->hw_init = false; @@ -168,7 +165,7 @@ static int rt711_sdca_update_status(struct sdw_slave *slave, * Perform initialization only if slave status is present and * hw_init flag is false */ - if (rt711->hw_init || rt711->status != SDW_SLAVE_ATTACHED) + if (rt711->hw_init || status != SDW_SLAVE_ATTACHED) return 0; /* perform I/O transfers required for Slave initialization */ diff --git a/sound/soc/codecs/rt711-sdca.h b/sound/soc/codecs/rt711-sdca.h index 22076f268577..11d421e8ab2b 100644 --- a/sound/soc/codecs/rt711-sdca.h +++ b/sound/soc/codecs/rt711-sdca.h @@ -19,7 +19,6 @@ struct rt711_sdca_priv { struct regmap *regmap, *mbq_regmap; struct snd_soc_component *component; struct sdw_slave *slave; - enum sdw_slave_status status; struct sdw_bus_params params; bool hw_init; bool first_hw_init; From patchwork Wed May 17 11:14:11 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 13244743 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D11CDC77B75 for ; Wed, 17 May 2023 11:20:54 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id AF51A1F4; Wed, 17 May 2023 13:20:02 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz AF51A1F4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1684322452; bh=IakYSP4Uh17qdBtq00fNOlaLb30g+Dofuda+Er60KeY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=mVMdOMIBNWJovYm+bKX+FfdvLM3WM2uyWGIfO57C+ciRsDDXrtJFk2iQcOS8Lz7G6 jQ8XjZvugvuPjWhHn0LKP+0bgObgCAmG17kiiz8jFKa9UGwV/itV5OcsXy01/5xD9R SCmMG0PsrkDY5JtKGPUDJTxPZzbQEt3u9v0FeV/U= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 7B88FF805AB; Wed, 17 May 2023 13:17:12 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 08532F805AB; Wed, 17 May 2023 13:17:12 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 9F81AF8025A; Wed, 17 May 2023 13:17:02 +0200 (CEST) Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [IPv6:2a00:1450:4864:20::631]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id EF19BF8053D for ; Wed, 17 May 2023 13:14:46 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz EF19BF8053D Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=hIdANJjD Received: by mail-ej1-x631.google.com with SMTP id a640c23a62f3a-965cc5170bdso94618266b.2 for ; Wed, 17 May 2023 04:14:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1684322085; x=1686914085; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=orOtZCSMdy0LOUQiF3GDNtFNR/PCT+bEnkKVYg6k6GY=; b=hIdANJjDwebuLejzh1gdqt+267DcEVSuEXFFfZttIJwmQVKZZhGt5sC81zWStiXcRj VkXD93TUaA6p5/xnMn+t1KsA2k9XWbfzDLmphIbNyQCMePhqmJwZ0QIctyh5cwm8q4wy jpGo6s5Hd6p6eKRAO0ltyCLM8otD/mS7+HaUb4FFNTthYyMbM30oBOfYkgfq+MXolgz5 OrfMgBCLybw5ytMdkTg+It68qT+icGoIHEi0KynM6uNo5zrHoHcKNS540jcbGu4+XgBj KS6QniH0sv0gGfn4aAtNBHezfiPEI5b6LpAL/hI7ksQoRcMW9Z2nBnGJkQPfI8i5ovSr ydYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684322085; x=1686914085; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=orOtZCSMdy0LOUQiF3GDNtFNR/PCT+bEnkKVYg6k6GY=; b=ADYQctc6rHvZtiYTA8rNZNPGekH3AgfdD7EEEt0V0j6IKBv01fy8CFS3PI2EaydaKj 8J9gibSuNaHZDy+FGCvIA2Q0g2RDkBOv4Sxtyk72Mzc3aN34v2hhpeG+1J/DnbPNxZvV EHxZNUsGtQFmGB7WoE+6zF/aRUwsoxU729plGawPJ8/kRR4K7ykqMGnPtMoE/ui4JX5E nsGq2YgB+tVR9Mr7/9N2dtB1UfKx5TvAMA6pb+GqakAlD4/oQR048k8XwmAGTfO4eIOL uCuI1Yszy2Jh5mF0XUPPTh+5Lkkj7Ep1Gs1wjkFD1vh1tG7fWMWkjbgUVBflCv4rYoDo xOLA== X-Gm-Message-State: AC+VfDxrXlaV99vYgm705Wt5i204Q/OST3/hvkeY1tyEh/pLxdaWRBYD 5Z1+B3CbbNWemniegwm8kpGYKw== X-Google-Smtp-Source: ACHHUZ59InEiEFagluPob/jRCVm/OnOiFjG4/CRAJ+B+r/pybagONxCqHhmhRqrqagLoPDquLlcEYA== X-Received: by 2002:a17:907:7e86:b0:969:b2e2:4f3b with SMTP id qb6-20020a1709077e8600b00969b2e24f3bmr31186355ejc.51.1684322085181; Wed, 17 May 2023 04:14:45 -0700 (PDT) Received: from krzk-bin.. ([2a02:810d:15c0:828:c9ff:4c84:dd21:568d]) by smtp.gmail.com with ESMTPSA id ml18-20020a170906cc1200b0094f124a37c4sm12326880ejb.18.2023.05.17.04.14.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 May 2023 04:14:44 -0700 (PDT) From: Krzysztof Kozlowski To: Oder Chiou , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 07/12] ASoC: codecs: rt711: do not store status in state container Date: Wed, 17 May 2023 13:14:11 +0200 Message-Id: <20230517111416.424420-7-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230517111416.424420-1-krzysztof.kozlowski@linaro.org> References: <20230517111416.424420-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Message-ID-Hash: QFH4IIPZDYX7RNLL6H56SWG5L6RLTEGR X-Message-ID-Hash: QFH4IIPZDYX7RNLL6H56SWG5L6RLTEGR X-MailFrom: krzysztof.kozlowski@linaro.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Driver in its update status callback stores Soundwire device status in state container but it never uses it later. Simplify the code a bit. Signed-off-by: Krzysztof Kozlowski --- sound/soc/codecs/rt711-sdw.c | 5 +---- sound/soc/codecs/rt711.h | 1 - 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/sound/soc/codecs/rt711-sdw.c b/sound/soc/codecs/rt711-sdw.c index 4fe68bcf2a7c..b8ed3c6236d8 100644 --- a/sound/soc/codecs/rt711-sdw.c +++ b/sound/soc/codecs/rt711-sdw.c @@ -319,9 +319,6 @@ static int rt711_update_status(struct sdw_slave *slave, { struct rt711_priv *rt711 = dev_get_drvdata(&slave->dev); - /* Update the status */ - rt711->status = status; - if (status == SDW_SLAVE_UNATTACHED) rt711->hw_init = false; @@ -329,7 +326,7 @@ static int rt711_update_status(struct sdw_slave *slave, * Perform initialization only if slave status is present and * hw_init flag is false */ - if (rt711->hw_init || rt711->status != SDW_SLAVE_ATTACHED) + if (rt711->hw_init || status != SDW_SLAVE_ATTACHED) return 0; /* perform I/O transfers required for Slave initialization */ diff --git a/sound/soc/codecs/rt711.h b/sound/soc/codecs/rt711.h index b31351f11df9..491e357191f9 100644 --- a/sound/soc/codecs/rt711.h +++ b/sound/soc/codecs/rt711.h @@ -15,7 +15,6 @@ struct rt711_priv { struct regmap *sdw_regmap; struct snd_soc_component *component; struct sdw_slave *slave; - enum sdw_slave_status status; struct sdw_bus_params params; bool hw_init; bool first_hw_init; From patchwork Wed May 17 11:14:12 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 13244725 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 15056C77B75 for ; Wed, 17 May 2023 11:17:05 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id CD191201; Wed, 17 May 2023 13:16:13 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz CD191201 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1684322223; bh=gOCFW+czvs5/FtDVB7qpuxbW4fyvAsTQZKe2NB38AB0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=o2P3Z4SNldiS2oRPy3teMoyl8ylzuqAvsyeG1Sagy2JgcU+i64fhv1LJ92HT2eWJO Y1d+TlOkr+B/ZxPTXjTWQbms0tGkFTyEglQtd8r2pb7FKPSuvwGZQIA+e72TrhlyR8 xVBFiMjxSZCYM3hdviQxqoSkRUWN+/D/Q17W5B5I= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 1C40DF8059F; Wed, 17 May 2023 13:15:06 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 6F5DCF80587; Wed, 17 May 2023 13:15:05 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id F3A07F80548; Wed, 17 May 2023 13:14:52 +0200 (CEST) Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [IPv6:2a00:1450:4864:20::52d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id ECEC0F8016A for ; Wed, 17 May 2023 13:14:47 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz ECEC0F8016A Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=dJ/Pmlpb Received: by mail-ed1-x52d.google.com with SMTP id 4fb4d7f45d1cf-510bcd2d6b8so5691596a12.0 for ; Wed, 17 May 2023 04:14:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1684322086; x=1686914086; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=QAU6nE7Iv32gPNvrQJaHKSe4IIom2DPSRL0YbepC1JY=; b=dJ/PmlpbNmfHmuYdjH3uO1ElApNK26oJ6na+aMD1yfJb05UDsLjz0xzUQTE/abm0yF zbx6naNOO2gKrAAsT5hyVVuz+j8ikJ/doxEQfVfSDF/ljofMQWyaBDeE9u14oK62/Wg/ xSIAetdKH2r59SbWqeWex5CKGvgTBS+G52EYglrZnOGuq2IENBj4Zwqrl/aLWic6zaTR 0NIY3KBh7oR+Z1I6Gxv/gf2kMRHJkoQGBahe4Y8/aVsAb7rBDD9/A+yas/Ild289fXk8 EfK+Znx5j8oBJa9m6rR/Oo4lqtGuzB5qoV2RwqJcdqyxLiOMlxeuo0sWGQY4pjqC/RCT Ro5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684322086; x=1686914086; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QAU6nE7Iv32gPNvrQJaHKSe4IIom2DPSRL0YbepC1JY=; b=GWqt0K9unJ8ffaopVNch+nUnC1gwfvLh2PdFregw3hMqPh/i/TkdLjxdBL2Yp7hTyC aRUweNIirR4nEjYKLobeC2+3ZAPdSlXdK7WVRbdFHfp5jDpUIlIFlbIBvRc2aaDFMp/F cCSVkwKIlq/yCTUrIVnRVy4pm4DsJkBWH+ZMLnPIHLJ76Qp5O9pbCaipRKsmEJA5WkLD xdqC+gTyD8EC4f0VGTkBMFpCOsFOyhC9P1UoPxTwUU1hlnTA/vDnOVGuh4uPQIxBD3OW k/+FI1Ud4yFeKOo8x9+lRBTS+8h2w2O0PJtBnE1p8Pl/OcgeEP3+6soJHySAt27WF/bC sh/Q== X-Gm-Message-State: AC+VfDwjTQeFqDVdd8ITDpaH4YdACKT7eet32McGYSeBH42NhOLGvXRr Rube5hZCQqYKumygFMgwe0sgdg== X-Google-Smtp-Source: ACHHUZ62iLS7FU6ngzK688zw4Cj+axv3xqRuHEDoRc8fnW0FTcROJc2cF0ZL0r8I9am/kqhPnH+4GA== X-Received: by 2002:a17:907:6da0:b0:959:b757:e49 with SMTP id sb32-20020a1709076da000b00959b7570e49mr1997236ejc.1.1684322086159; Wed, 17 May 2023 04:14:46 -0700 (PDT) Received: from krzk-bin.. ([2a02:810d:15c0:828:c9ff:4c84:dd21:568d]) by smtp.gmail.com with ESMTPSA id ml18-20020a170906cc1200b0094f124a37c4sm12326880ejb.18.2023.05.17.04.14.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 May 2023 04:14:45 -0700 (PDT) From: Krzysztof Kozlowski To: Oder Chiou , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 08/12] ASoC: codecs: rt712-sdca-dmic: do not store status in state container Date: Wed, 17 May 2023 13:14:12 +0200 Message-Id: <20230517111416.424420-8-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230517111416.424420-1-krzysztof.kozlowski@linaro.org> References: <20230517111416.424420-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Message-ID-Hash: 3Q33BJI5D345JIEMKGU76PW4KBI3F77O X-Message-ID-Hash: 3Q33BJI5D345JIEMKGU76PW4KBI3F77O X-MailFrom: krzysztof.kozlowski@linaro.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Driver in its update status callback stores Soundwire device status in state container but it never uses it later. Simplify the code a bit. Signed-off-by: Krzysztof Kozlowski --- sound/soc/codecs/rt712-sdca-dmic.c | 5 +---- sound/soc/codecs/rt712-sdca-dmic.h | 1 - 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/sound/soc/codecs/rt712-sdca-dmic.c b/sound/soc/codecs/rt712-sdca-dmic.c index 09807b6d6353..847198e6c07e 100644 --- a/sound/soc/codecs/rt712-sdca-dmic.c +++ b/sound/soc/codecs/rt712-sdca-dmic.c @@ -803,9 +803,6 @@ static int rt712_sdca_dmic_update_status(struct sdw_slave *slave, { struct rt712_sdca_dmic_priv *rt712 = dev_get_drvdata(&slave->dev); - /* Update the status */ - rt712->status = status; - if (status == SDW_SLAVE_UNATTACHED) rt712->hw_init = false; @@ -813,7 +810,7 @@ static int rt712_sdca_dmic_update_status(struct sdw_slave *slave, * Perform initialization only if slave status is present and * hw_init flag is false */ - if (rt712->hw_init || rt712->status != SDW_SLAVE_ATTACHED) + if (rt712->hw_init || status != SDW_SLAVE_ATTACHED) return 0; /* perform I/O transfers required for Slave initialization */ diff --git a/sound/soc/codecs/rt712-sdca-dmic.h b/sound/soc/codecs/rt712-sdca-dmic.h index 74c29677c251..110154e74efe 100644 --- a/sound/soc/codecs/rt712-sdca-dmic.h +++ b/sound/soc/codecs/rt712-sdca-dmic.h @@ -16,7 +16,6 @@ struct rt712_sdca_dmic_priv { struct regmap *mbq_regmap; struct snd_soc_component *component; struct sdw_slave *slave; - enum sdw_slave_status status; struct sdw_bus_params params; bool hw_init; bool first_hw_init; From patchwork Wed May 17 11:14:13 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 13244727 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DE48EC77B7A for ; Wed, 17 May 2023 11:17:29 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 8E7891F6; Wed, 17 May 2023 13:16:37 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 8E7891F6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1684322247; bh=WgUdedY/WH5OwU74JtzaexaFbol08w3Rp/bgU1G8p4A=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=k1igNzZSwIgjPRablCEWjAmpeSLblraa79LnnzDYMmrS+1OCPsvJtRZLiS8oQPjhZ Vy4DbPAfAUPKZTVOvV2CvrPBuxq7AX/BwPfhLtR6PwBLVx8K9PdiUguwDkL3NJxgt3 O5hSUlJxteExpc5X5iKrau9Pjstx4glTnIjr3umo= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 17C12F805B2; Wed, 17 May 2023 13:15:12 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 66C0AF805B0; Wed, 17 May 2023 13:15:11 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 1175FF80272; Wed, 17 May 2023 13:14:55 +0200 (CEST) Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [IPv6:2a00:1450:4864:20::629]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 6190FF80272 for ; Wed, 17 May 2023 13:14:48 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 6190FF80272 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=Q18UZ1h8 Received: by mail-ej1-x629.google.com with SMTP id a640c23a62f3a-96b0235c10bso104904566b.3 for ; Wed, 17 May 2023 04:14:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1684322087; x=1686914087; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=7XA3XbezCgMB9jc3ic4kluul6uNj+0DU/xxzeFgKHBE=; b=Q18UZ1h8k0fFvwih1EOsNVJXAjQsdHXNFlqphn0hwbg48vgVEor0zN78LCEayppAZf ODLE6k/+kOXM86OJ7nPnn6kgKgT3iAVFA/CrP4Ss+joOCpD2pmqp78mGWJ/8Xf8pSCa+ uGZKeHASaKnoKcS+giX3EI1tr2Uj6i15udXE9GApmffv9qgpfeoBg4AZKgU0xbwdRFq0 Cw9uMa+TyjssV2P1Ua1UuJps5Uelyr8p5kM1kTaB8KjBkwyvUlQ7XG0yQUTXHCTLIU3h QxQB0lrj058pFXy6HUFeEHjxwqJE5T6EonVtsO7nM/I1lSYV8orCpoVgQtVisN5rQnI8 JopA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684322087; x=1686914087; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7XA3XbezCgMB9jc3ic4kluul6uNj+0DU/xxzeFgKHBE=; b=Nq7EFQvJl7TiCpAMcC1WF5Gbn6N9Qc/jpSJlOYChjDY0FeO57hCX2jY56vUAHZp1Ev nZRkn+lU4YIydRSCF3U1P43a7yAFq0ZAI9DGwu4P85t/3VE3qy3fCeaH8DEIIGmzriyY vp4P4FxiK0+KTp2rA9Eo07XeD+tE2Dh7UqPfAeG3jrg8iusux5FrEhZv57l+byOKP5J6 JvQ5j1MHHJb4UhZMcXiRPcV2AQ3OJAWn/juJZfcDtl4QWndcRbhvi2VSu9DsZ72i9Vbu ehKa++k6dg73x62TpNOSxhXAVvNq+1Vfc9c1709xCIgoyeXankjC54EC90H+yz4OWf4n A4sA== X-Gm-Message-State: AC+VfDytUBRuNr39KXePwMBPjBtuod7qbXUsaWeyx7b8DfnSIsdWumX9 +b8d7lqc4F74fy26ZEReCykqFA== X-Google-Smtp-Source: ACHHUZ68BtJy2sMkNQIbg/Wtsj1k/B1TxsFqCJyZxOarUMUtFl7IHdShMhfk+H0m0bLuqGRG3za2DA== X-Received: by 2002:a17:907:72c7:b0:969:f677:11c8 with SMTP id du7-20020a17090772c700b00969f67711c8mr25495472ejc.45.1684322087476; Wed, 17 May 2023 04:14:47 -0700 (PDT) Received: from krzk-bin.. ([2a02:810d:15c0:828:c9ff:4c84:dd21:568d]) by smtp.gmail.com with ESMTPSA id ml18-20020a170906cc1200b0094f124a37c4sm12326880ejb.18.2023.05.17.04.14.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 May 2023 04:14:46 -0700 (PDT) From: Krzysztof Kozlowski To: Oder Chiou , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 09/12] ASoC: codecs: rt712-sdca: do not store status in state container Date: Wed, 17 May 2023 13:14:13 +0200 Message-Id: <20230517111416.424420-9-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230517111416.424420-1-krzysztof.kozlowski@linaro.org> References: <20230517111416.424420-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Message-ID-Hash: 3R22N72MAS5ELYC23UH6SQVLK6IPTNRI X-Message-ID-Hash: 3R22N72MAS5ELYC23UH6SQVLK6IPTNRI X-MailFrom: krzysztof.kozlowski@linaro.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Driver in its update status callback stores Soundwire device status in state container but it never uses it later. Simplify the code a bit. Signed-off-by: Krzysztof Kozlowski --- sound/soc/codecs/rt712-sdca-sdw.c | 5 +---- sound/soc/codecs/rt712-sdca.h | 1 - 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/sound/soc/codecs/rt712-sdca-sdw.c b/sound/soc/codecs/rt712-sdca-sdw.c index 3f319459dfec..8f65516e7562 100644 --- a/sound/soc/codecs/rt712-sdca-sdw.c +++ b/sound/soc/codecs/rt712-sdca-sdw.c @@ -140,9 +140,6 @@ static int rt712_sdca_update_status(struct sdw_slave *slave, { struct rt712_sdca_priv *rt712 = dev_get_drvdata(&slave->dev); - /* Update the status */ - rt712->status = status; - if (status == SDW_SLAVE_UNATTACHED) rt712->hw_init = false; @@ -165,7 +162,7 @@ static int rt712_sdca_update_status(struct sdw_slave *slave, * Perform initialization only if slave status is present and * hw_init flag is false */ - if (rt712->hw_init || rt712->status != SDW_SLAVE_ATTACHED) + if (rt712->hw_init || status != SDW_SLAVE_ATTACHED) return 0; /* perform I/O transfers required for Slave initialization */ diff --git a/sound/soc/codecs/rt712-sdca.h b/sound/soc/codecs/rt712-sdca.h index c6a94a23f46e..ff79e03118ce 100644 --- a/sound/soc/codecs/rt712-sdca.h +++ b/sound/soc/codecs/rt712-sdca.h @@ -20,7 +20,6 @@ struct rt712_sdca_priv { struct regmap *mbq_regmap; struct snd_soc_component *component; struct sdw_slave *slave; - enum sdw_slave_status status; struct sdw_bus_params params; bool hw_init; bool first_hw_init; From patchwork Wed May 17 11:14:14 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 13244728 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 03556C77B75 for ; Wed, 17 May 2023 11:17:50 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 25DA11F9; Wed, 17 May 2023 13:16:59 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 25DA11F9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1684322269; bh=gqqToe5R3xNC5wyr0vNW9VJjDx9NkWZdFijLc2DGSNw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=pG2/RGPAWpbyg/PpIgk7JOPl9XNku/vBRI4i+P9wHY1qGQJntPPuPPQ0dS88uu4Dx VJhdSF0bABLMKC1WxtxsZIumnWeN6wdGlVz93ViLFr0ABmOZbpxpWASmRvtDkE7j4h XXih4DzP+v5k72qBP4IbA1kcLzA9FfSkJRPKswAU= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 0C1AEF805BA; Wed, 17 May 2023 13:15:15 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 94555F805BD; Wed, 17 May 2023 13:15:14 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id C4EBAF8056F; Wed, 17 May 2023 13:14:57 +0200 (CEST) Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [IPv6:2a00:1450:4864:20::631]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 66023F80542 for ; Wed, 17 May 2023 13:14:49 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 66023F80542 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=QqGyQVcP Received: by mail-ej1-x631.google.com with SMTP id a640c23a62f3a-96adcb66f37so113368566b.1 for ; Wed, 17 May 2023 04:14:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1684322088; x=1686914088; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Hg++FY7yhGIzwZILizitxUpO+7bfMUehzjto7GaiR9Q=; b=QqGyQVcP+weCBDwAlfPGPZeH7eur+A3XKLVELVFzsWtZeDa7EsfvnyemqYCx8tfCso zOrofL/zOLGID7x8MwR30/XR59YqTg6r/In4AqWvuGtx74kLRZUPGQmL5hE7w4SPgqYJ 0GUTOUkDk82Bb29FXqsk8pfyiH19q8+t5AhX17sBgZe1yZrr4CIrdBj1eN+XHUyYRDBE d4Xh9182yu35iRsGleQ97I/W2rPAftQCyoUARli+pbGhkOf1Ur3sk44FNy+kTqB4tEDj SpE+jAq8Y9nUdeVZqMOafAEPfIociyC8A8fp9Ms6a6Zb47kbcL+bF0yJw9fpE4q+6mD/ nWog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684322088; x=1686914088; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Hg++FY7yhGIzwZILizitxUpO+7bfMUehzjto7GaiR9Q=; b=BNDdMk2HR5wB5PztHyrd/Ou0P3Sw56ylX94NequM4x/IIhO0NErsqyxm5KDF9IxJxF 5drZZWy8AHLxmFjTaIDDH00JWWQuYHYvsGjIGyuatsCVPXfzUqwmw2DWOSjLHCYy+CFZ PMTJI7CcmJvh2cRez/qhHw0G8+twmjj2UaztwETfWZJKBnZe5ozwSvdHlfxjgaCt9X5a maqwB2X/iXteJbE8QV/XyjB4DjVrfn7xl2WlTEpm9ZZU3MtqBI0JEWKrT5OW10X4NKL9 WDcATCdp4GJcRdVw6tFTVK27dx/jXJPUTFPOkZBBUM3uh8S8Q6Bkf/lJ6LCwAXRxYZat DGJg== X-Gm-Message-State: AC+VfDzDcak11HWGKdVKTHLaRm1kw8sfgrW0kplfzqf6UIWqAPGlGova RuT5FSykRlsSyAnvf5VkTX9Fk2xHtAlfxDH5Zns= X-Google-Smtp-Source: ACHHUZ6agdt+8cNAIrQlXTt4TZimiL3AU9u8hB11RhwhOm4cME5bRrbuGTkjGC1nNc9gCeh7XqrNVw== X-Received: by 2002:a17:907:9496:b0:96a:ff7f:692 with SMTP id dm22-20020a170907949600b0096aff7f0692mr10101998ejc.68.1684322088601; Wed, 17 May 2023 04:14:48 -0700 (PDT) Received: from krzk-bin.. ([2a02:810d:15c0:828:c9ff:4c84:dd21:568d]) by smtp.gmail.com with ESMTPSA id ml18-20020a170906cc1200b0094f124a37c4sm12326880ejb.18.2023.05.17.04.14.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 May 2023 04:14:48 -0700 (PDT) From: Krzysztof Kozlowski To: Oder Chiou , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 10/12] ASoC: codecs: rt715-sdca: do not store status in state container Date: Wed, 17 May 2023 13:14:14 +0200 Message-Id: <20230517111416.424420-10-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230517111416.424420-1-krzysztof.kozlowski@linaro.org> References: <20230517111416.424420-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Message-ID-Hash: 3VRYRGHNPRORD4CEPNLQLWRM7ZQZ6GXT X-Message-ID-Hash: 3VRYRGHNPRORD4CEPNLQLWRM7ZQZ6GXT X-MailFrom: krzysztof.kozlowski@linaro.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Driver in its update status callback stores Soundwire device status in state container but it never uses it later. Simplify the code a bit. Signed-off-by: Krzysztof Kozlowski --- sound/soc/codecs/rt715-sdca-sdw.c | 5 +---- sound/soc/codecs/rt715-sdca.h | 1 - 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/sound/soc/codecs/rt715-sdca-sdw.c b/sound/soc/codecs/rt715-sdca-sdw.c index 38a82e4e2f95..7e5ddce8097d 100644 --- a/sound/soc/codecs/rt715-sdca-sdw.c +++ b/sound/soc/codecs/rt715-sdca-sdw.c @@ -121,14 +121,11 @@ static int rt715_sdca_update_status(struct sdw_slave *slave, { struct rt715_sdca_priv *rt715 = dev_get_drvdata(&slave->dev); - /* Update the status */ - rt715->status = status; - /* * Perform initialization only if slave status is present and * hw_init flag is false */ - if (rt715->hw_init || rt715->status != SDW_SLAVE_ATTACHED) + if (rt715->hw_init || status != SDW_SLAVE_ATTACHED) return 0; /* perform I/O transfers required for Slave initialization */ diff --git a/sound/soc/codecs/rt715-sdca.h b/sound/soc/codecs/rt715-sdca.h index 7577f3151934..e5d6928ecaba 100644 --- a/sound/soc/codecs/rt715-sdca.h +++ b/sound/soc/codecs/rt715-sdca.h @@ -24,7 +24,6 @@ struct rt715_sdca_priv { int dbg_nid; int dbg_vid; int dbg_payload; - enum sdw_slave_status status; struct sdw_bus_params params; bool hw_init; bool first_hw_init; From patchwork Wed May 17 11:14:15 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 13244730 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 79CB6C77B75 for ; Wed, 17 May 2023 11:18:23 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 755CC74C; Wed, 17 May 2023 13:17:31 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 755CC74C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1684322301; bh=Y475XU+9ClN5OEj+mIHQ9mqPGMAfEGuJKydDrwCsByk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=Ucv7CuQX/Ew9BvwrjhSWNl/WuAfR96eM3x3SidykSo4WOQhqIHuulktnYodKtjR4R qmQ/G8N42qoOGnuxWB7MSo7lo4eLxSymLNDuLrdErLU70Gj392AlwTtyg+8WWyCcSu JU1BqgzzKKwdmapj+zFufHVFhi2ZXw7kVs//xhL4= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 8B6F7F805D5; Wed, 17 May 2023 13:15:20 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 75F02F805D5; Wed, 17 May 2023 13:15:19 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 78E0DF80578; Wed, 17 May 2023 13:15:02 +0200 (CEST) Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [IPv6:2a00:1450:4864:20::62b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 8A3EEF80544 for ; Wed, 17 May 2023 13:14:52 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 8A3EEF80544 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=Mqrza8r6 Received: by mail-ej1-x62b.google.com with SMTP id a640c23a62f3a-96652cb7673so93574666b.0 for ; Wed, 17 May 2023 04:14:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1684322090; x=1686914090; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ikB2y5rvufm/ROET3UaPHVQf0uJXk4esoL2mDQIzzPA=; b=Mqrza8r6L1qVxSOY8tPU3HdOmEKLv1L4y3PLSmB1w5nETDTDauRdLQWLKSc70HZ800 pi7A8pKDIp3UiLkPHkSm2Z9WKbHpPVQqowRRvDdLX9xaXmcZFAqbO+2DgbzQZo92DKPc mfGsvAWTr5zLhsgTVpPH5G7b95kh5eRGV/HhBRsi3O+NGuXyaGLl9tEVU7dTaQROQ9Un HBexjtOtDlBB+58I33xjm/oeXxfhsOTQgIc2wwvKbCqosGiLVZQQHsaMol4RliIown2f KuLWdNzxde/Dr78sqoTvF8zkY//R7v9P+iWX0ABe7GdxGBXLkAz92qty0kQ5+iiERX0c vNtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684322090; x=1686914090; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ikB2y5rvufm/ROET3UaPHVQf0uJXk4esoL2mDQIzzPA=; b=SUiFAjDTpWVN8tBSMvGqkAfeyR9GKHvainz/y9RFGKo/VjqX301gxtpDz3ehMRgPf/ Xfd2qVv9hl9+9XDpCkxpbcbuYdArhEWz4UR0vCfwFMQ3AMv94lJQ5C/bWuxNpqEZjmL2 OngbVJpTGBkhR4Ygker+pjKwMOnj/CqSF5y4ilsX3hlt3jt3CKBbTn1ADHSD/7jFeYbF ktMhmIAwzNhBdNc9e21Cq2aIqBE44vq9w0m8YQj7sTEEcbzn2SGR02ihd/ZgWu2FLNcx nv0SrRYNMmKiPn1DT1DoxBwBBvBZjPKAj8pyc4KIR2LJcWp+VBceyIukJvg08SDXLPfK jy4g== X-Gm-Message-State: AC+VfDxRP7a47//lcX+gysQsstV/bCXxYJFuzGiime9phHxPdH2IGP8v mDunmzuC/sIVwwqsU5xhzIcgyw== X-Google-Smtp-Source: ACHHUZ77Po5iB686z2AKal+Svea6MuM/egkvm4vr7KEKPnMB5+2IdxYBbcnEdkJ1O2aYG7A3MTAXaQ== X-Received: by 2002:a17:907:7fa8:b0:969:8d19:74 with SMTP id qk40-20020a1709077fa800b009698d190074mr35584944ejc.57.1684322090644; Wed, 17 May 2023 04:14:50 -0700 (PDT) Received: from krzk-bin.. ([2a02:810d:15c0:828:c9ff:4c84:dd21:568d]) by smtp.gmail.com with ESMTPSA id ml18-20020a170906cc1200b0094f124a37c4sm12326880ejb.18.2023.05.17.04.14.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 May 2023 04:14:49 -0700 (PDT) From: Krzysztof Kozlowski To: Oder Chiou , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 11/12] ASoC: codecs: rt715: do not store status in state container Date: Wed, 17 May 2023 13:14:15 +0200 Message-Id: <20230517111416.424420-11-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230517111416.424420-1-krzysztof.kozlowski@linaro.org> References: <20230517111416.424420-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Message-ID-Hash: GL64WWA7PHRPNMKEM2ZVXMCAIYLBU3WP X-Message-ID-Hash: GL64WWA7PHRPNMKEM2ZVXMCAIYLBU3WP X-MailFrom: krzysztof.kozlowski@linaro.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Driver in its update status callback stores Soundwire device status in state container but it never uses it later. Simplify the code a bit. Signed-off-by: Krzysztof Kozlowski --- sound/soc/codecs/rt715-sdw.c | 4 +--- sound/soc/codecs/rt715.h | 1 - 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/sound/soc/codecs/rt715-sdw.c b/sound/soc/codecs/rt715-sdw.c index 5ffe9a00dfd8..6db87442b783 100644 --- a/sound/soc/codecs/rt715-sdw.c +++ b/sound/soc/codecs/rt715-sdw.c @@ -417,13 +417,11 @@ static int rt715_update_status(struct sdw_slave *slave, { struct rt715_priv *rt715 = dev_get_drvdata(&slave->dev); - /* Update the status */ - rt715->status = status; /* * Perform initialization only if slave status is present and * hw_init flag is false */ - if (rt715->hw_init || rt715->status != SDW_SLAVE_ATTACHED) + if (rt715->hw_init || status != SDW_SLAVE_ATTACHED) return 0; /* perform I/O transfers required for Slave initialization */ diff --git a/sound/soc/codecs/rt715.h b/sound/soc/codecs/rt715.h index 17a8d041c1c3..12a0ae656d09 100644 --- a/sound/soc/codecs/rt715.h +++ b/sound/soc/codecs/rt715.h @@ -18,7 +18,6 @@ struct rt715_priv { int dbg_nid; int dbg_vid; int dbg_payload; - enum sdw_slave_status status; struct sdw_bus_params params; bool hw_init; bool first_hw_init; From patchwork Wed May 17 11:14:16 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 13244729 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E0532C77B7A for ; Wed, 17 May 2023 11:18:01 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id D2C3B7F1; Wed, 17 May 2023 13:17:09 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz D2C3B7F1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1684322279; bh=FiYgNgYvzQZHBTsYkz9CR3MzXtWoGGqaxLSPfuum1Ss=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=iiNBsAStrx8RnZBxYM90CqXjyeZ6JXTeEL3uYMU2JVjQ28ONK6YpnHQ7eg5Ow2XYq 3eVOpDTJP24GKi0AMiTHjLL3G/au8X/337ck0sRiLaEQLCFPd6cEHq6x2Che6GL2dG qPWFbNZs2g5kkLoK3x6vAChjkpXIgJX46xO7h+Wc= Received: by alsa1.perex.cz (Postfix, from userid 50401) id D2A66F805D4; Wed, 17 May 2023 13:15:17 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id CDAC0F805C5; Wed, 17 May 2023 13:15:16 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id D0B94F80570; Wed, 17 May 2023 13:14:59 +0200 (CEST) Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [IPv6:2a00:1450:4864:20::52d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 63625F8016D for ; Wed, 17 May 2023 13:14:52 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 63625F8016D Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=uMpMaqG1 Received: by mail-ed1-x52d.google.com with SMTP id 4fb4d7f45d1cf-510bcd2d6b8so5692288a12.0 for ; Wed, 17 May 2023 04:14:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1684322092; x=1686914092; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=VnIEpqHICz7MCR44hDCQrdJI2TjC+iEi+weDD/DiHgQ=; b=uMpMaqG1DqCWwx1hCI5PuOhkim7/TDAijWwMpe1ydZKEw+qIhizYVg/cft4VQapzD4 vzRLPboKiuQD0ZoY9vRl7zLw4E7JgW6k5CzgJIlwjvUz6TVW1XPRsfFF2wWQ4R14/pZi pAn7ChTywYn6exjMI1vNn5Ih0jSFSXn7AgpetOMZhQr7x0kzU1k+kk9zfhRC/JIaArDl SvoXQkKGfjFzJnPROvYxvC77bUGONoLXl+YQnBK7TWVdHGzUMY0mmb10gDIlZkXpNXgc VmvfNO4QTLaSiJPS+ROPLbAm2awcyFtVjD0nDsFHebUVzUYXb0H8js0WQ+bS39DRONlF zj1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684322092; x=1686914092; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VnIEpqHICz7MCR44hDCQrdJI2TjC+iEi+weDD/DiHgQ=; b=VTh02Bo/lgwmBzkL1zRLuAwyOjGy2tkckB0sSi2hH6sfWMyYiEHg2U6ql8Z2q3DpD3 aAREjIOckbZglqGqYVBw2JyM0Ilh4nq70pNzuoWP4v1G3fAtdA1Vh89IvN6Nk0BzXFVk j/L1uDAa+1Y2ORza3yfLAhzA+1Wxjd3+IMGJbcAWAoG2RymLmtW8pOpzR/EXfchb6j3J ND/exWBOKfWSGtCl4BG4y6yYsU02xgnmsyx8Pls3ffXxW6zuBORhzi4oC+E7mBzxnoQk EAy36Kmm8+hY7E6tfzKUJAH8trY6UF4d0zNtqzxvJdUOaeNrwxM1QGrX9QX/Tjtv6EaW G8Gg== X-Gm-Message-State: AC+VfDy+/7paTtYtpX0lfj4sNt/59kIcFU+UmJx8K15QL6MuCtbrVH6h up8daMJEDB+q3r/wZQsTzfYLug== X-Google-Smtp-Source: ACHHUZ5o/6icRslOMBgpWvrVIHAHLvuvr5xOTVdS5zygNzE9ImG9M96dMpU+Dv/r1s/UxbSnU5g9IA== X-Received: by 2002:a17:907:6d25:b0:965:d7c7:24db with SMTP id sa37-20020a1709076d2500b00965d7c724dbmr1640573ejc.32.1684322091870; Wed, 17 May 2023 04:14:51 -0700 (PDT) Received: from krzk-bin.. ([2a02:810d:15c0:828:c9ff:4c84:dd21:568d]) by smtp.gmail.com with ESMTPSA id ml18-20020a170906cc1200b0094f124a37c4sm12326880ejb.18.2023.05.17.04.14.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 May 2023 04:14:51 -0700 (PDT) From: Krzysztof Kozlowski To: Oder Chiou , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 12/12] ASoC: codecs: rt722-sdca: do not store status in state container Date: Wed, 17 May 2023 13:14:16 +0200 Message-Id: <20230517111416.424420-12-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230517111416.424420-1-krzysztof.kozlowski@linaro.org> References: <20230517111416.424420-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Message-ID-Hash: ENT44KNLC4ZJI55TTMW66L45ZAJ3OWCS X-Message-ID-Hash: ENT44KNLC4ZJI55TTMW66L45ZAJ3OWCS X-MailFrom: krzysztof.kozlowski@linaro.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Driver in its update status callback stores Soundwire device status in state container but it never uses it later. Simplify the code a bit. Signed-off-by: Krzysztof Kozlowski --- sound/soc/codecs/rt722-sdca-sdw.c | 5 +---- sound/soc/codecs/rt722-sdca.h | 1 - 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/sound/soc/codecs/rt722-sdca-sdw.c b/sound/soc/codecs/rt722-sdca-sdw.c index 0a791a14215e..bfb2dac6bfee 100644 --- a/sound/soc/codecs/rt722-sdca-sdw.c +++ b/sound/soc/codecs/rt722-sdca-sdw.c @@ -163,9 +163,6 @@ static int rt722_sdca_update_status(struct sdw_slave *slave, { struct rt722_sdca_priv *rt722 = dev_get_drvdata(&slave->dev); - /* Update the status */ - rt722->status = status; - if (status == SDW_SLAVE_UNATTACHED) rt722->hw_init = false; @@ -188,7 +185,7 @@ static int rt722_sdca_update_status(struct sdw_slave *slave, * Perform initialization only if slave status is present and * hw_init flag is false */ - if (rt722->hw_init || rt722->status != SDW_SLAVE_ATTACHED) + if (rt722->hw_init || status != SDW_SLAVE_ATTACHED) return 0; /* perform I/O transfers required for Slave initialization */ diff --git a/sound/soc/codecs/rt722-sdca.h b/sound/soc/codecs/rt722-sdca.h index 5bc6184d09aa..44af8901352e 100644 --- a/sound/soc/codecs/rt722-sdca.h +++ b/sound/soc/codecs/rt722-sdca.h @@ -20,7 +20,6 @@ struct rt722_sdca_priv { struct regmap *mbq_regmap; struct snd_soc_component *component; struct sdw_slave *slave; - enum sdw_slave_status status; struct sdw_bus_params params; bool hw_init; bool first_hw_init;