From patchwork Tue May 23 17:14:21 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Michael Kelley (LINUX)" X-Patchwork-Id: 13252700 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 16F55C7EE26 for ; Tue, 23 May 2023 17:15:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=ZzZs7DIG8gWBOfZH6iLj57tGSLDH2TTF8YbKBKw3/8k=; b=KZS5m6Cyx7Im5n S88y6bOWLiJj+RTTtld6lVpF00bHpAUftQyuiQIS1lPB3DLgUvy2oqDRe281IboqNRmJ9KRHV5rnp cPE1pqJLcamd+sKoEiamHCOng6IEkVwHJ/yqH5T5tjwXLyFH1Ef30JS3fJks8psqFMRZkVHFiPZcy zrJRhP6IVF1nwxcUkefTUbQ8Z6NSdNR/Qhar50lCJMy82fo8Xe9jJcKUuGYOYmVgNb81eAtjtA7X6 QGHTna6HSdjXeqoAWo5o8ejdPUNIggFct5dlDbo/Fn+00Q0YcWKUHTSBSnYWJlP0YYprVR6DQLT/r O61jVFmWFrT1SRe/fRvA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q1VbI-00AvIm-2Y; Tue, 23 May 2023 17:15:08 +0000 Received: from [2a01:111:f403:c111::] (helo=DM6FTOPR00CU001.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q1VbG-00AvHO-0C for linux-arm-kernel@lists.infradead.org; Tue, 23 May 2023 17:15:07 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gFTEK1ppAPF4g4F6qc7LbuuCDYnwhNExj1KzhG2/xzoXMpYM/RRm819Rre0yE9GbhZ+UanMwkENDanfQ0o8jSbZMprOfiJdTPRGkBEK/16jgYsheGLxLei2XVt7huZsynzv9CMdiEnFSaxzDzluzjVQJUZg+3ort8xLjDweKKoYgMEvlReEpgsOKDUsqIbLthmQBlZt/4f1r4ADyD/4BnP/Gg8GZM+v0q+HfaaqwAnGt2YXckcmAVbxsTDJ9aWWs3Iy2oBK5BuSG5TTVvspcdQUGEg2OezjP6W185VitgduNyub2wpCFYjH0pW37c34+tO6hXcbGbphoQyZAlaHddQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bWkCBjMumEVdnOiFUDuUb7Y96m9hR7cTb6hMrFPOr3E=; b=aHBXwy+xDkDsWgXPPy1iWYOE3mmrddK0VQVfWlXlKI4P7SYhxx8rvH+Weh7Xe+cQdcQcawnzyRXwWbSuXDgK/AOXrRyP1J2m0lGK6OUlvC7wQjEme9faoeDtO2RmFrSmSjBQugQvBZ8MFS9CMYAcPWfeegAUCaxV3JnAlb2aHzGjgIxaQNhlQnc3PjTr4EeatScKjEg8DhU5AKJRBkKFr/I7hcufspuNNYZk63bhFBhazT9CzFWWm1DcNb3NH6NwidMYP3JIviIHpuHThk3AMcjnF1FQDgg/QprntqUWDXre7VE+zJ1mDq1+d06gMDNdPTMgNOQvB0dxSE56JOKkaA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bWkCBjMumEVdnOiFUDuUb7Y96m9hR7cTb6hMrFPOr3E=; b=iMkbuy1PVhs5sR2KE03fhDdBXXFGgKHXhgBYpnGWAUTUAhwM7hcnjNT+x5qYMu2D+YiFcggioemXAIVOyK8oDLgYZgDSxnrVq4+k3aNlXhiD0qrueJmT4AyG/Y2UiYuQVPNIOKqa8PbM116jc9zsNrUTk/hkb4uSgTVEwGOTo/Q= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=microsoft.com; Received: from DM6PR21MB1370.namprd21.prod.outlook.com (2603:10b6:5:16b::28) by SA3PR21MB3866.namprd21.prod.outlook.com (2603:10b6:806:2fb::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6433.6; Tue, 23 May 2023 17:14:59 +0000 Received: from DM6PR21MB1370.namprd21.prod.outlook.com ([fe80::b7e9:4da1:3c23:35f]) by DM6PR21MB1370.namprd21.prod.outlook.com ([fe80::b7e9:4da1:3c23:35f%6]) with mapi id 15.20.6433.013; Tue, 23 May 2023 17:14:59 +0000 From: Michael Kelley To: kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org, decui@microsoft.com, catalin.marinas@arm.com, will@kernel.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, linux-kernel@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-arm-kernel@lists.infradead.org, x86@kernel.org Cc: mikelley@microsoft.com Subject: [PATCH v2 1/2] x86/hyperv: Fix hyperv_pcpu_input_arg handling when CPUs go online/offline Date: Tue, 23 May 2023 10:14:21 -0700 Message-Id: <1684862062-51576-1-git-send-email-mikelley@microsoft.com> X-Mailer: git-send-email 1.8.3.1 X-ClientProxiedBy: CYXPR03CA0065.namprd03.prod.outlook.com (2603:10b6:930:d1::7) To DM6PR21MB1370.namprd21.prod.outlook.com (2603:10b6:5:16b::28) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6PR21MB1370:EE_|SA3PR21MB3866:EE_ X-MS-Office365-Filtering-Correlation-Id: 822a898c-5334-4b58-85a3-08db5bb13d07 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: BxX5MV5mWgOqWIf/0YUmcuUUrJ8dYI/3+ZkyOKOXcGUG/D1KruFGl94lwjNP7K0fH2rHVkXFeI91eOCimSP759ak9HoBetVqNHIpqDyRbSqeevDFmRvquW6e0WOM/X1/LzFQiTV76m69yrSxJsjFsALnBQy96zosTuIGXetaPNCQ+AdaUSvpdFNflJ8/jI1e+Rn0pj/5K3kc1G5yktKBRztkxMVmsu2L/EOGg91zfbImUkLoOKHGMaUez2dkokwdcWs7heaDoEBx+SdgNA4zhsRujV6bAFwoG8Ixj+YTSbhMKyK+tDxPBL2LcBqRXY0iv7fP9YL6dMj311Yjy0iwD1hNg5JdnoOE6YLcAnu1uKfaZt0ABHyjEFL+onADAfyHFMin1rpM0Mtp043yJUWygLPDmhicIvlKzzHgsJkib0kzhTxDyRGjO8jz2/1kj7SDwdV9IXLtD9YRyqxEsdoZ7qf4nvouUXPhWsIV7DC8dMI+EInIFm58rr4jNdyOeworDzjXpS0RSnTSCFHLEDh8bFMIYCQqP1u7lDiZI0jRBmcm2Cv0TW7DbSZOKGytJ0h6tDbyuvS8L1psS1LZsHKWN0Kr5XOKb2R+qkdF7DqxgpQgxZjKFWDr6DbQprFgGaCgO+47DC3t0JNdTvPKYTeQSUdjYu5lu3kIrnvUF6GBzSY9sbs/LkUGZqxcZ4NdKJKz X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR21MB1370.namprd21.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(346002)(39860400002)(366004)(396003)(136003)(376002)(451199021)(5660300002)(6486002)(6666004)(66946007)(8936002)(786003)(52116002)(316002)(41300700001)(8676002)(10290500003)(107886003)(478600001)(7416002)(4326008)(66556008)(66476007)(2906002)(186003)(6506007)(6512007)(26005)(82950400001)(2616005)(83380400001)(82960400001)(36756003)(86362001)(38350700002)(921005)(38100700002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: WAErviylwowS1miCbzfZdElFWB2GTy1nC1cUZviSSBkZaJEt3QH2eSrxxlT9UL0pSM+mHm/1ZpoIAc+HfjbBHLDMvgM/LXyHQyVK+f99WJ2IRTo6wNUJqnYnoNQHhAKGSTXnVr5jb5v/3zuLTZsIpyz2wXv5y3EctLUkMMnxcyYU2O5naZ7WN5f4xP4VtC0D/HPsVkPI1QT+kbS4z6ADPXysqYlLpA7CZlczTFpPJf748fH5EQjCyqoZvJjUIvnrDqdGZvEHio0S1LZa2ndPUPJ06vd9ajaBm317DikHp5Hes7TOrm0mCyLiy/MrmhYYSbbtQ1Vts9MG+dmK6KxwHPfV1okJznWu4Tn7blR29mAv3yzjOCKPFxSWN6+LaTcR/9YYLvRyowcmwiQzcfUSbKevn2kiDruaXgwli4CvbED/iu2URdZ0urhz9J0gpfD6pfUZUCx2hZUm6eXoZA8Uy2yXcinTaP5NQkcVwOumKJjDd0Q4C7SkNkfoNBeUY4070BzaScfcRW16H1OqkJQq4ldv0jDH71LVRML+TuMp8pQlyHJVR+QSHYLJLTWLDZqFwHV2SZ19C9e5sljlqGkGlgZiUnGMwf945UBRd3xO1u3OQln2Orv60AZU3Y/xmduNYnDVi26sEl36Q2qmudBUDf3Yd+wNPkZcKVaudzrX0fyHzpz3AX0OAX2hyhlTQH1llfcIuRdVy3wxk29tpkVN/8D2AOdM7fOYwnvuPg1p2Kz7e6snqkWd4oIJgwjASU5DgvmlFLrUcHYEYObUfOVfwfiCwzWyL+H8xsGU41JOtOSOjzUH+kvR35ChieC51nzm7dZClV4flMwYXa64PlhlK+xCVfmrg6xZxNsJvFS3b+IB+L0Pi6b5JxcPC+hvN4Wi/XNmIxlmkonLZ9KAzqi2THkkKGPt1SyF8TXO70/UEbB/4rMFsmiixCczBCljztW0/hBpdB+2nJFxkJ2HKHiGXzdwlnBO5OhOlpDcO/w4+2Q5fDilZOvpY0qeIoORfPNNVboInQnxE+13+ErWbZd6g522bDrNt2w/TKHSGiojRu8AwsAp0+m9zj8mAHXf2pYxBj3d97cfqHWOOM7W6U2nbSZ8FmLVf/xVyPAVplDqDXuaBPqxNgV9TtuOB+mKFduF2PbY6WtQttvbiPlIDC1AZdgrQjF6KYR6iC0JjuaWj91gR75X6wZuYCEPU0xU9yKHIm4VkNmBisZKmZxEIXlRmi+d0WlTZreLaNyKMm5ayopYW0ndfoFpyY6naSRyVyEvvbnPgUe9mPp8VDDJHtgzGZBWKQCbLV8f8RD888j6xTQNP+3UivoL6xeg55BIzbXFEIvHTJvkpXwncJhk7evwM3cfbbbGgssCbFq72VHyXepgrvLiweCPfRs2faad9XcDZMEArgH+MkwJHV/ubTxDZWLHD3prO5Gbydff7NuIz0c/glTMEenI7PFrg5SIIPUTMt/fHSNDG2oauGvoPO2234g17vExOQUVVfGSTHkDrt+ZA3L2q8NBF7x+/789OgcWROwrFg5ZXrO2Z6zfADRJWPPYNnt8ENq7ZJbgAQm5g+Y3qC/SU3iMNmA3yl9zvMa2 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: 822a898c-5334-4b58-85a3-08db5bb13d07 X-MS-Exchange-CrossTenant-AuthSource: DM6PR21MB1370.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 May 2023 17:14:59.5735 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: aW2PJaBegIgR9tAGkeTO6J4kbsOa8qB10biWnzNxnqv1OI0cQGloi1RtZclMxBRX9ooP+HXUYGkyDDbDUyRqcQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR21MB3866 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230523_101506_106726_7786A74C X-CRM114-Status: GOOD ( 21.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org These commits a494aef23dfc ("PCI: hv: Replace retarget_msi_interrupt_params with hyperv_pcpu_input_arg") 2c6ba4216844 ("PCI: hv: Enable PCI pass-thru devices in Confidential VMs") update the Hyper-V virtual PCI driver to use the hyperv_pcpu_input_arg because that memory will be correctly marked as decrypted or encrypted for all VM types (CoCo or normal). But problems ensue when CPUs in the VM go online or offline after virtual PCI devices have been configured. When a CPU is brought online, the hyperv_pcpu_input_arg for that CPU is initialized by hv_cpu_init() running under state CPUHP_AP_ONLINE_DYN. But this state occurs after state CPUHP_AP_IRQ_AFFINITY_ONLINE, which may call the virtual PCI driver and fault trying to use the as yet uninitialized hyperv_pcpu_input_arg. A similar problem occurs in a CoCo VM if the MMIO read and write hypercalls are used from state CPUHP_AP_IRQ_AFFINITY_ONLINE. When a CPU is taken offline, IRQs may be reassigned in state CPUHP_TEARDOWN_CPU. Again, the virtual PCI driver may fault trying to use the hyperv_pcpu_input_arg that has already been freed by a higher state. Fix the onlining problem by adding state CPUHP_AP_HYPERV_ONLINE immediately after CPUHP_AP_ONLINE_IDLE (similar to CPUHP_AP_KVM_ONLINE) and before CPUHP_AP_IRQ_AFFINITY_ONLINE. Use this new state for Hyper-V initialization so that hyperv_pcpu_input_arg is allocated early enough. Fix the offlining problem by not freeing hyperv_pcpu_input_arg when a CPU goes offline. Retain the allocated memory, and reuse it if the CPU comes back online later. Signed-off-by: Michael Kelley Reviewed-by: Dexuan Cui Reviewed-by: Vitaly Kuznetsov Acked-by: Borislav Petkov (AMD) --- Changes in v2: * Put CPUHP_AP_HYPERV_ONLINE before CPUHP_AP_KVM_ONLINE [Vitaly Kuznetsov] arch/x86/hyperv/hv_init.c | 2 +- drivers/hv/hv_common.c | 48 +++++++++++++++++++++++----------------------- include/linux/cpuhotplug.h | 1 + 3 files changed, 26 insertions(+), 25 deletions(-) diff --git a/arch/x86/hyperv/hv_init.c b/arch/x86/hyperv/hv_init.c index a5f9474..6c04b52 100644 --- a/arch/x86/hyperv/hv_init.c +++ b/arch/x86/hyperv/hv_init.c @@ -416,7 +416,7 @@ void __init hyperv_init(void) goto free_vp_assist_page; } - cpuhp = cpuhp_setup_state(CPUHP_AP_ONLINE_DYN, "x86/hyperv_init:online", + cpuhp = cpuhp_setup_state(CPUHP_AP_HYPERV_ONLINE, "x86/hyperv_init:online", hv_cpu_init, hv_cpu_die); if (cpuhp < 0) goto free_ghcb_page; diff --git a/drivers/hv/hv_common.c b/drivers/hv/hv_common.c index 64f9cec..542a1d5 100644 --- a/drivers/hv/hv_common.c +++ b/drivers/hv/hv_common.c @@ -364,13 +364,20 @@ int hv_common_cpu_init(unsigned int cpu) flags = irqs_disabled() ? GFP_ATOMIC : GFP_KERNEL; inputarg = (void **)this_cpu_ptr(hyperv_pcpu_input_arg); - *inputarg = kmalloc(pgcount * HV_HYP_PAGE_SIZE, flags); - if (!(*inputarg)) - return -ENOMEM; - if (hv_root_partition) { - outputarg = (void **)this_cpu_ptr(hyperv_pcpu_output_arg); - *outputarg = (char *)(*inputarg) + HV_HYP_PAGE_SIZE; + /* + * hyperv_pcpu_input_arg and hyperv_pcpu_output_arg memory is already + * allocated if this CPU was previously online and then taken offline + */ + if (!*inputarg) { + *inputarg = kmalloc(pgcount * HV_HYP_PAGE_SIZE, flags); + if (!(*inputarg)) + return -ENOMEM; + + if (hv_root_partition) { + outputarg = (void **)this_cpu_ptr(hyperv_pcpu_output_arg); + *outputarg = (char *)(*inputarg) + HV_HYP_PAGE_SIZE; + } } msr_vp_index = hv_get_register(HV_REGISTER_VP_INDEX); @@ -385,24 +392,17 @@ int hv_common_cpu_init(unsigned int cpu) int hv_common_cpu_die(unsigned int cpu) { - unsigned long flags; - void **inputarg, **outputarg; - void *mem; - - local_irq_save(flags); - - inputarg = (void **)this_cpu_ptr(hyperv_pcpu_input_arg); - mem = *inputarg; - *inputarg = NULL; - - if (hv_root_partition) { - outputarg = (void **)this_cpu_ptr(hyperv_pcpu_output_arg); - *outputarg = NULL; - } - - local_irq_restore(flags); - - kfree(mem); + /* + * The hyperv_pcpu_input_arg and hyperv_pcpu_output_arg memory + * is not freed when the CPU goes offline as the hyperv_pcpu_input_arg + * may be used by the Hyper-V vPCI driver in reassigning interrupts + * as part of the offlining process. The interrupt reassignment + * happens *after* the CPUHP_AP_HYPERV_ONLINE state has run and + * called this function. + * + * If a previously offlined CPU is brought back online again, the + * originally allocated memory is reused in hv_common_cpu_init(). + */ return 0; } diff --git a/include/linux/cpuhotplug.h b/include/linux/cpuhotplug.h index 0f1001d..3ceb9df 100644 --- a/include/linux/cpuhotplug.h +++ b/include/linux/cpuhotplug.h @@ -200,6 +200,7 @@ enum cpuhp_state { /* Online section invoked on the hotplugged CPU from the hotplug thread */ CPUHP_AP_ONLINE_IDLE, + CPUHP_AP_HYPERV_ONLINE, CPUHP_AP_KVM_ONLINE, CPUHP_AP_SCHED_WAIT_EMPTY, CPUHP_AP_SMPBOOT_THREADS, From patchwork Tue May 23 17:14:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Michael Kelley (LINUX)" X-Patchwork-Id: 13252701 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2C972C7EE26 for ; Tue, 23 May 2023 17:15:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=c+CCxBZqDjRrxfzO0pBl8Gp3dWhYQukWklRAriEg6KY=; b=w5tZR9PPiczA9O Q/LtOfqu3E3mQB+btkxFr/Myiw72rzX2JLFRLHAt8MDPYkmWfITZqAI7HjZ+NKaIkw4T+9fHZK4va j3wp/5JGLB7Xx6XrwTexHP/Y9XSMy/qoYHgi370E2dRcEP7FS3UKz3FV2cuv8WSY6eq8i7j/1Q8as 7C8YY+plnvSfEb1Fk8Km/y/YQrG+zVrC6CdypiShv81PndG6dZEw8sI713ODEPFLzs3UM+l2W18zt bjJcaoWEr2GyCYwyuCqIdHoj3TAv5CqwkijEViJ369WNqpmsWRXj4/n2X6fb0dKNOCK9HY4xUZRcd DIUJx8S5yzivCrqREc4Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q1VbP-00AvKn-0k; Tue, 23 May 2023 17:15:15 +0000 Received: from [2a01:111:f403:c111::] (helo=DM6FTOPR00CU001.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q1VbH-00AvHO-2M for linux-arm-kernel@lists.infradead.org; Tue, 23 May 2023 17:15:08 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Yk8G+0l8Clkq50x5IBrqOtNFDaQIvf6IOb5Eom2Ug4cjmJIfha/g2bkjizq0PQmYehI2S2l26UHPsc8ovTmQDfoRvTBKsBG62BegNKvZEVdO9X9j/eV/boIWhuswzOgLYYRf8q2OVDkJc+cEiz3YR21onxK2r84tR5GxCWy9g2D1F2kRrwrChtOCwt+yX5gFhc+gR2IQs30xQRoxhjl6Q4/A7otl/0+DsZZbncrxkrKWnxwGe6bdTxxR5eES/2F9TfY6GpA3zfgtg4gCJEyC+AOXuz5znHfcwABYuGCnBkfOvcKhhxi8JKA7iVtpdNNLkKGorrxnp8s+EzsGyBOg4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4gk7P7mm085GcOFy/QlJ6VB8iwPpBiBi9YxJ2vj1nW4=; b=l672DVXn+Yi/UevSjii5ZD9M1wbPIOIdLSp/ibhdTZQMijbnUJlsZQKCsbPJxGEemtLEQBrr/DXHwT3IwF0yMwwxCA0tXaCS42OZhTBqBKOqIVtY9Ptqg5EdnF4+f1CSvw+437BSkhoX3arfPntU832lHSLot0Px4NuoWCUStx5Um9N/+hM4d3AsUxT6nDohCkb5pWDIBJTxKiAjHnu93YvwfQhF3MKnxerCAqVcQfDw89XuFu8b9ejYGRTUPhDOi4qaeq2wHsZdmEioZO1x/EuHuxRMZZgn3149ZLh3U5/JU06FkkhGM95vMaoCXmTqaG7Nh7m5jxnkV+cNUc9lew== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4gk7P7mm085GcOFy/QlJ6VB8iwPpBiBi9YxJ2vj1nW4=; b=FlhlveoAGJ+nOGpnMeCpKHh4P+mAQLTydN9J4/d8qvUHlttTnaWtWaLS7NXi2oNv13DuCnzqw7TVDtFLCNu/pAzwhvL83bgmKhP0F/ffJuqa6SAbedch/nf64/YXsif0gb4kt+rbztsLzn55flmKn1jMEINc2jz03Q9uaWPUoAE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=microsoft.com; Received: from DM6PR21MB1370.namprd21.prod.outlook.com (2603:10b6:5:16b::28) by SA3PR21MB3866.namprd21.prod.outlook.com (2603:10b6:806:2fb::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6433.6; Tue, 23 May 2023 17:15:00 +0000 Received: from DM6PR21MB1370.namprd21.prod.outlook.com ([fe80::b7e9:4da1:3c23:35f]) by DM6PR21MB1370.namprd21.prod.outlook.com ([fe80::b7e9:4da1:3c23:35f%6]) with mapi id 15.20.6433.013; Tue, 23 May 2023 17:15:00 +0000 From: Michael Kelley To: kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org, decui@microsoft.com, catalin.marinas@arm.com, will@kernel.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, linux-kernel@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-arm-kernel@lists.infradead.org, x86@kernel.org Cc: mikelley@microsoft.com Subject: [PATCH v2 2/2] arm64/hyperv: Use CPUHP_AP_HYPERV_ONLINE state to fix CPU online sequencing Date: Tue, 23 May 2023 10:14:22 -0700 Message-Id: <1684862062-51576-2-git-send-email-mikelley@microsoft.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1684862062-51576-1-git-send-email-mikelley@microsoft.com> References: <1684862062-51576-1-git-send-email-mikelley@microsoft.com> X-ClientProxiedBy: CYXPR03CA0065.namprd03.prod.outlook.com (2603:10b6:930:d1::7) To DM6PR21MB1370.namprd21.prod.outlook.com (2603:10b6:5:16b::28) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6PR21MB1370:EE_|SA3PR21MB3866:EE_ X-MS-Office365-Filtering-Correlation-Id: 60c2af2a-798e-43d3-5358-08db5bb13dba X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: EhrF2z2/IgBo1t0yJ4rp7EEvUsWcN2mknhMqS9cweIjmcHscvS2GmwfeBtEODepCZ/gu93nw1eqwa6eZdSc8aXhRQ75LkUruw0IeH+iKWfVMhj3aWvdAD3CsfMo0G5Bfqj34laFHYDt7yJKK2ytOJPRBnGeom27iuRTp5cBqVnbHD+JeJks1hdb+omvyciXgFtSa79s0nA5nxYLK/yJqCmCmJNRlVzYu6XxUiSDb2xKdCJvumCRfONjWeEZQwPyAsdzMUjMQ71jIfxKbsEgAKyvRv80A7LvtaKuh6h6tMy7kEh8yxs91cCweAm/Xj6Sdu/nPtquIl8skDj46SDdbSTpeLXtWYiAy/CQYqeDg7HD80W61FEpQBRTZ4tkKlCdn9G+i0o1gJ99QIj7LJqD1JnohJtAcLujraeZN6eRLKMP+DLX/dW254KloAjgfmb/U7n02BXjLPjsmcyCay+MkRJoJMoUayl48uLC8zavmO/21FbnHmOm65QEcXnp1SDFmLdH0Qmmi2xrPY1FnkqYysRzG/xArRLXJkMBd8i6P+cb17VerNxgo+kQlHGqs198OHFDC7UvOXMoBFjZU4IrBMTzhc6nVFZ04zKesfOiISYmAsV2zkbETzef0lrEBrLRr4rbaULV0/kp1N4+r9WqzGTIXf2iab7uWpjbU5CpO02Gwp05DM4G4iRzxTih1CKLv X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR21MB1370.namprd21.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(346002)(39860400002)(366004)(396003)(136003)(376002)(451199021)(5660300002)(6486002)(6666004)(66946007)(8936002)(786003)(52116002)(316002)(41300700001)(8676002)(10290500003)(107886003)(478600001)(7416002)(4326008)(66556008)(66476007)(2906002)(4744005)(186003)(6506007)(6512007)(26005)(82950400001)(2616005)(83380400001)(82960400001)(36756003)(86362001)(38350700002)(921005)(38100700002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: AbT7skfBffANSrpGwxja+Rl+6kWkc83P9IcOxGwd1TCHlS50kOd1XaPai8G1ZbTrPnB4aYyriPgKsSnNyYjVMc+y/tofqKXIpSyVKmx7yIEWSge4vFkJRUNjYhBYLH0FEYFSAEPMpI8Qt9bumjT2TMLBch3MUAgnGMoUalfth91RSAa6i5vHM36mFExEJrfou+839Cj8tCx7bSy7ogs94lzxHFXyJHcUG3iOf5h6mDewyneQhhWBgjSO/oTggb8xyVbz08p1IBOLL+GZ+BcCZ/DtWsvZnvmQv3i0q6FheOBEH7J8FhJ7lHwJpbH47VAyEunseMJ047xEZcS8+pQeSGLGe7gd4Q5HfnIfPdl50TFgp0wNXaR3CaDmnqIW6Daj+oh+QnQ9efTaOPynYBquoTmL9rUqNL6JbveKodeGlyTQwyai0oLy/2wF+T4USz/OAH/e6ss5eZeSXKZbHhTfmIs8254wMbyeKo/YDoHVniba9wVrnSZ2o/T5YQFeI7Veyfci+/LxgLSXoZQlMP3z8berxgcc2RjHNqQuS3UmQXQ0Fa3sbVG15JcvtP2A/eVP/OjfGgx4fYiruiKhi3YM4/kddMWW2Be8YdVDWyyGXPG7E/1Pks2o93544anZJFeMzSv2zfAiTKUwBbcFSt2PDtZEKalbW9M/uCnzHk7g+LEF3eZKdaS6UfQqqGtrrBBiK+5z8aU5VCVxQwBeg/sRilfhMVywRF/4cGh+jVwmIKCoXwGZzR0kc3V3uBtJDxwZs8xP9Ys3wEFzIxgjQKwlgzTz2g5A07kO57yvrgsXLQrVzLsZ2f2i0o0nci9+yJ9MNTBS3VYnUmlxJVnePOmCNqIT9gZwzn8n6qMqo2EZ/uwWCwOJUZML7GNZ+XQysYPtSPRCJtxHpZYt4LB47JIpgHHLhFYlZGD7UBiQpPdc+Kw4qeJkTQ5LKvV2QLYj+/2corhQzEwwP4ZkOxVgbzZ4F5UQ1K0CtGGPC66+/SGIe6+aUfFCnjIXE1Q27J9oxwcNTs+Q/q50sQW0Pv7K2tekvd2Zx9QiTEYUFFCLpkvbvdWjt6Cfvof7N9+v8VShv78/nQ2iVEE2zPLxm0QSm3KXVRWY48dA7rdPz58Odt2+VvdVjSQxGuB8Vxu5x9IwMIqqrdlNM30osfIv2CiAUk+6MDuE2jA2WX0dXvkwmYA9Oc9rnqK6oDi67Na1bXwuHqYO7eWsnG15QCyPezaxPKE5FyiAwGQ7im/9wH27EaMNehHW1NvlEe2/lE/L0K/9gQOA9LFUShnv4jedN9DJcXKZn5YR4flBZTYgBSg1JeQQMnCGRhtKxCUAx4zllJqpY++p5gmuppVFdzmRZ140gXWF+neyHx/A1Z0tGC2G3svMMf7KX9UJpGNfKKKp78zKUbyqNUELTiLprQIp76EEZO+fQYDxtImu9NUpaufEcoaLGJHSDYZ+/LO2cfVl/Bs+7atNYmk8ZB0I73Ou2nDzkY1q7dJgcLdtlWkyMQkVutH209e8wB670xpFP6CDhq0tTZU/H7+LTjHp0LFJjsZx9NqZydWmxMbgaKRK+xatyPuP70JaJR2rt1TQGXg2Kv6L9jny X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: 60c2af2a-798e-43d3-5358-08db5bb13dba X-MS-Exchange-CrossTenant-AuthSource: DM6PR21MB1370.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 May 2023 17:15:00.7278 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: D8oyL+4Edss9HBk//W0Q1AjatefwftlQQrk7FBl0i2fnVWGMbjNzncLEgrztxsvZAzpAjR9scJu6v70KgLNnug== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR21MB3866 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230523_101507_772987_E51B9E86 X-CRM114-Status: GOOD ( 12.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org State CPUHP_AP_HYPERV_ONLINE has been introduced to correctly sequence the initialization of hyperv_pcpu_input_arg. Use this new state for Hyper-V initialization so that hyperv_pcpu_input_arg is allocated early enough. Signed-off-by: Michael Kelley Reviewed-by: Dexuan Cui --- Changes in v2: * Fixed typo in commit message [Dexuan Cui] arch/arm64/hyperv/mshyperv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/hyperv/mshyperv.c b/arch/arm64/hyperv/mshyperv.c index a406454..f1b8a04 100644 --- a/arch/arm64/hyperv/mshyperv.c +++ b/arch/arm64/hyperv/mshyperv.c @@ -67,7 +67,7 @@ static int __init hyperv_init(void) if (ret) return ret; - ret = cpuhp_setup_state(CPUHP_AP_ONLINE_DYN, "arm64/hyperv_init:online", + ret = cpuhp_setup_state(CPUHP_AP_HYPERV_ONLINE, "arm64/hyperv_init:online", hv_common_cpu_init, hv_common_cpu_die); if (ret < 0) { hv_common_free();