From patchwork Thu May 25 04:01:48 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Haifeng Xu X-Patchwork-Id: 13254754 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E140AC77B7A for ; Thu, 25 May 2023 04:02:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 48753900003; Thu, 25 May 2023 00:02:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 437276B0078; Thu, 25 May 2023 00:02:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2FE89900003; Thu, 25 May 2023 00:02:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 1DB6C6B0075 for ; Thu, 25 May 2023 00:02:51 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id E1996ADF9C for ; Thu, 25 May 2023 04:02:50 +0000 (UTC) X-FDA: 80827431300.12.7C7A27E Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) by imf12.hostedemail.com (Postfix) with ESMTP id 23BAF40002 for ; Thu, 25 May 2023 04:02:47 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=shopee.com header.s=shopee.com header.b=NQJaaIdz; dmarc=pass (policy=reject) header.from=shopee.com; spf=pass (imf12.hostedemail.com: domain of haifeng.xu@shopee.com designates 209.85.210.176 as permitted sender) smtp.mailfrom=haifeng.xu@shopee.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684987368; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=ANsIwyslEqWqt/AnM3EiaC6NohGcLnN3qIazUJUVzP4=; b=poHK2f9AbuhWqlKTkGtCtrUlKVumDcIMaBk6Vxi98pqg7Sd/ZlJGG1tXid7oArs4U4kMPH cZehy2JtLMP8d3s/OvzX8Bbs7rl1LnrFRq69EefkIDf4LQhP2oXyWDiE2kIm97igY8Vorh Ucc9FOEC4htlFR9Yj/7NRxiP8I5JGVs= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=shopee.com header.s=shopee.com header.b=NQJaaIdz; dmarc=pass (policy=reject) header.from=shopee.com; spf=pass (imf12.hostedemail.com: domain of haifeng.xu@shopee.com designates 209.85.210.176 as permitted sender) smtp.mailfrom=haifeng.xu@shopee.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684987368; a=rsa-sha256; cv=none; b=63AsQl4cyFE6h4hzn8sx0ItIYqEPgHgyFxTvpYYIDdGd03EXgCJxG8v3VFo7ZZ9FbYORc8 nVBoW4VFAlN/fiREUhi/AnnnVlZMw8uGde8p95MM+aJUGG8ZcsOLDEP6Y0Vfbp27gBhLHG VeNTAi49MYDuTXd5ZLdvFGy7C1sLBqo= Received: by mail-pf1-f176.google.com with SMTP id d2e1a72fcca58-64d24136685so413505b3a.1 for ; Wed, 24 May 2023 21:02:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shopee.com; s=shopee.com; t=1684987367; x=1687579367; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=ANsIwyslEqWqt/AnM3EiaC6NohGcLnN3qIazUJUVzP4=; b=NQJaaIdzuOmU2ZfoUS/HfLXDpN2lpDz6rxgmnio+kZPpgUMm8yFkHv0hT8FTIcZdVt Ro2TjOvsYI8Sjxrlcl9/rf95KDbQVHMgA1b5mYpT8p72lDYlZA1C5tZy72BZcjaAxdWv 5LloYVYAxTGN2gD10YUAommoIjdIy/149C79MorSY1AtC/EmTjZy/5Hg0tgXhtqZ/Adr CiNne8GdcsARkuTNHNT6MOFjZ+iM6Ydix0MCy/3hqzvExsAklMKN0t5GFNMkV3NW//HI n07UXJRmrOF6W2ZNXMqSbRAxdQBg4fDRbECDjakujwM97aOUZD9iU/igqiVV9oKC9mxF Ghjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684987367; x=1687579367; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ANsIwyslEqWqt/AnM3EiaC6NohGcLnN3qIazUJUVzP4=; b=Ri4f0xtSIB7JnO/5271lRI5wuEXDbmOdlq6cU0/O/SJ8Xr+4MDZUlBP9BvIdrHQBO7 Iql1b3D1nmPYcte2AYJh5dlZZJfmemnRpFNnXd+/RI0qNTZIczNYaks+UYf67/0omWtD 52otXMe+N97OkLriRRx4cCZImA6hnyTXc+hAzJvA7kS/T1ptTH3c3SeZs88mtCn+p4KW 4eeOqh+gme82FOIcba0xR0TD0lZ2t4q8z0But5MnzNX2SaApx6ZKqypoYy6wuyPlA/Du qbxXPGrqNddiOZ5ex9LxEsAr7xYRC9AALlaRBQJu0c6FRdfKMLI7mxJYnrTKpMrhXxeV xctQ== X-Gm-Message-State: AC+VfDwl2NZdfZqmM/3R1PBHzinhb1TC78Xe/K91Ha7V1PjXSWfXGo3X Nmzp9P7gQKpB1Vzd4kvLPOC1gA== X-Google-Smtp-Source: ACHHUZ4M33VfkiEYeZxyk70nhvhOVHqK3x9PsgMDApROp+V/I6KHRI3r1n/c1Qap5fKrlvpfXIq1fA== X-Received: by 2002:a05:6a20:748e:b0:10c:b9ed:6a3f with SMTP id p14-20020a056a20748e00b0010cb9ed6a3fmr1539402pzd.7.1684987366781; Wed, 24 May 2023 21:02:46 -0700 (PDT) Received: from ubuntu-hf2.default.svc.cluster.local ([101.127.248.173]) by smtp.gmail.com with ESMTPSA id i11-20020aa7908b000000b0064c56d04316sm189916pfa.193.2023.05.24.21.02.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 May 2023 21:02:46 -0700 (PDT) From: Haifeng Xu To: akpm@linux-foundation.org Cc: mhocko@suse.com, david@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Haifeng Xu Subject: [PATCH 1/3] mm/mm_init.c: remove comments in zone_spanned_pages_in_node() and zone_absent_pages_in_node() Date: Thu, 25 May 2023 04:01:48 +0000 Message-Id: <20230525040150.1588-1-haifeng.xu@shopee.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Rspam-User: X-Stat-Signature: q9sgyu7fcqaztjj88jsru36u85sr5fqc X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 23BAF40002 X-HE-Tag: 1684987367-977804 X-HE-Meta: U2FsdGVkX1/e+4k9gpCRHDClGCELAN63V56FRVcMc+ihC/mpmoclOWNIkQnDbQR82v/KeLZ/kyiY6ahNaeUZlo3zVyl6kmUOBzlY1G86rH4vuqOX3bJ7Fj6eKQCGfUv0lEjnj9eKhxkDy8l9k9+BzrJHJpNtHgagKKLNUZj2X1MRXNbGSdr4g9PGpbap4AFRL2N4KQ5SvDtPy69IsXRk8YLYBeVWHywidp95EwKBQWN5s4vTxBE/IiMhHPz55pfRim0SSKf9bjkQgmwxK74D26Tp50oEzgpdjwURNX4oKSyYymDB7lpK5Xm0pW24UVhK+oAYcXPaqB5qWopnKOe9uq7laxjAJFMGK9zjKcbwdlrkkrLUpl44dPmhRQrEnn+snO88yo9sJy0OnuXL+1eQCMBXjtwHLqxxGE3EMMGoWO0M3uOPIlOqCcpazZgHVkOFhEYXks0KxIEA1DxTvcYAagqlYEou5mwjmbZsnH4GN3bqlHDW5pnLWhHfGsl4yFGZLE82VZKobB68MWv3gVmmjqj39PK6LNTtcAOTqhQSuY0NNmfL+ylEBngTygcw27otaRtyogKFO0czprhDJoqn+E7OwkhjRWZHrIlLkLtF/fXCAX50acfVnQRBjH9jujuhRKyYkMDxSzyg+YHYc7WVM24c2xlB7IZ4HBq3eawPXlZS9CO5Dt09Miohc8A5RN9eUrDT7XVPjA6GkG3Z1TQQq20iXbL6DIlmYomwoTZ/0JplqPV5VppTdgRLhSf3tQtYBAj3qW5uIswjw2fBqV/YMx8oRFnb4fZKViLq6ttJbz/Z9tcvFggtVxBo8N1olL/hTNZfcErWN2m1meeFJ41DKPYW84yYZmSuda6tj0EyS+C34M9lgDq0j8dXCvRnZZyvp5YEEat8tci3vJFW6ewykUIQpDk+fkp6Ba1HSVTyE2QpMVCMbfOkDCgzhHn8kdKopguek71bnnQhXREWDfu H0zx+IZh UD+kbxqNiTFq8tGyEdZsXl4Uk6z/2wARRDYj5vA8C0HcuANUUptqAsuOvM5Pv2Fod5vwo/rSocI+4cuha6QeiD6iBGVXQDLljkZfsyMpQGighWznlA1SCHgg/lCIE4AZbjIJuixgXt7KZuGibuPTpyfJYn6cAckChx/te1gGjygYaiIzACDt3Xos6/u6iQdcRZwnq+3TvLZbwJuWDdocGoZpJahjThLVrF/YjSGVErpyY65Mob0kz4WxxcHukkZg2w+CkjVs6xDzbITH4Mj8JXWPsGzHz6ne0F7axJHRFCqPAHMBc5havf7fTG7nxInDK+gUg2ktEjsjWRPR6RZT93PgZ9Pa10Q3wVyXGUC0IH+B8kPlGflex/h7jwc4Q2l+UY1Z/mHNQZJUCgBe/z1bJ5JHrRXyzg99YZOGhKkG97EuVfYQ9AlWNykfFCvM0twQ8WU3X X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Since commit 03e85f9d5f1f ("mm/page_alloc: Introduce free_area_init_core_hotplug"), free_area_init_node() doesn't get called in hotplug path anymore, so remove the comments related to it. Signed-off-by: Haifeng Xu --- mm/mm_init.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/mm/mm_init.c b/mm/mm_init.c index 7f7f9c677854..cf55bba04b23 100644 --- a/mm/mm_init.c +++ b/mm/mm_init.c @@ -1174,7 +1174,6 @@ static unsigned long __init zone_absent_pages_in_node(int nid, unsigned long zone_start_pfn, zone_end_pfn; unsigned long nr_absent; - /* When hotadd a new node from cpu_up(), the node should be empty */ if (!node_start_pfn && !node_end_pfn) return 0; @@ -1227,7 +1226,7 @@ static unsigned long __init zone_spanned_pages_in_node(int nid, { unsigned long zone_low = arch_zone_lowest_possible_pfn[zone_type]; unsigned long zone_high = arch_zone_highest_possible_pfn[zone_type]; - /* When hotadd a new node from cpu_up(), the node should be empty */ + if (!node_start_pfn && !node_end_pfn) return 0; From patchwork Thu May 25 04:01:49 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Haifeng Xu X-Patchwork-Id: 13254755 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17718C77B7A for ; Thu, 25 May 2023 04:03:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 98FE8280001; Thu, 25 May 2023 00:03:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 940346B0078; Thu, 25 May 2023 00:03:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 807DD280001; Thu, 25 May 2023 00:03:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 7369D6B0075 for ; Thu, 25 May 2023 00:03:09 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 471B6120476 for ; Thu, 25 May 2023 04:03:09 +0000 (UTC) X-FDA: 80827432098.12.50A5E10 Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) by imf23.hostedemail.com (Postfix) with ESMTP id 8DFB8140012 for ; Thu, 25 May 2023 04:03:05 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=shopee.com header.s=shopee.com header.b=VO447nLY; dmarc=pass (policy=reject) header.from=shopee.com; spf=pass (imf23.hostedemail.com: domain of haifeng.xu@shopee.com designates 209.85.210.170 as permitted sender) smtp.mailfrom=haifeng.xu@shopee.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684987385; a=rsa-sha256; cv=none; b=DrWtz3AoSpst5Qul1UfJN6nJ3qnDzw7SmBnD3IRUHHvIabTvLBWeHduObUxexnrxzYQHQu pNdXzCg9Yc9Yl+q1sQZpduEV0NFsaUzQ2k/M5olLaY1cYESiXn9F39tRk2GVJFBClt9sS7 cTs2zI6zy6iOEO3aS6/+UCBgDDEtAf8= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=shopee.com header.s=shopee.com header.b=VO447nLY; dmarc=pass (policy=reject) header.from=shopee.com; spf=pass (imf23.hostedemail.com: domain of haifeng.xu@shopee.com designates 209.85.210.170 as permitted sender) smtp.mailfrom=haifeng.xu@shopee.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684987385; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=WOXFBlEjJcJ6V9YFOI8yptpCpDKRZLgBqb3BFNypKaI=; b=1gg5JGNpFVuxWde2UJDldaMBDykmkcLYB2OKEgM3fILG1PvSw/KXnrakWbKQNX0zoLm3DB KY6Ut8e11mcu3oFP6EZKDngQ2kmfJoPAUCgpdWZqAPdH9b1H33xcn8JvEihAum3BDDSXRP uJt5jYyXwZ4dMdkjtvP/7sqw376VlIA= Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-64d3bc502ddso1990999b3a.0 for ; Wed, 24 May 2023 21:03:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shopee.com; s=shopee.com; t=1684987384; x=1687579384; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=WOXFBlEjJcJ6V9YFOI8yptpCpDKRZLgBqb3BFNypKaI=; b=VO447nLYcNslTB95FdoOTJFuskVQk5jMcKcrP02WXeDjykcP5O7h70FE25NHPd1yFv V4lah2jbdvfrDYCxZH9TSktvenzbogw/teitAJ6Hd43cc2hQAZYnrAzlFxSOaTCqcZEY DE9HcPswNSY/ZvpSIXfcZEEA/RDdMPVCTj3R3LVLJ2T7g66Bh/OftP86auFWO43QYn0x 9c8fP4xxNH9Yg69myVOoct77jVdwhD3mOs4qiY1whhlIA9PIqoV5lxOJ2OkQOyIH1uXp UrrmDHERBpGc/UpuyXoMe5tVDKr3DH9Rbn21GdqzSaujFFDFbRjBt4LQxuR02H04bcKR PtUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684987384; x=1687579384; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=WOXFBlEjJcJ6V9YFOI8yptpCpDKRZLgBqb3BFNypKaI=; b=OEtNxD61Y9AQnN7bwSVPqMkFdoFOZylhpzajiLazeqSE7A/B+0/OGOZVWglL/TFe9f e14SILvDIwDjdlxiBcu9PXpqBXXlph3EfDCDeUpJ9SH3RpFbKFPErjpU9KzsNpsfEF31 Pmt/ELhYFrcTQsGnjnN4ijpLyg64f6QMrDiHMPd1rCQ418oy6qBxssn/h1L6mhgdibgT MOMrOktk9ablcp8qPHKcS9f+Vj3imd2H4Yl+spr8b1ahW8kkbHgHMCspxX1fbF0UOKND QDFykG0+G/FWb/b+LF4VhVJT1L1f37hwFXPYIIF0k8lAW2xF0mNgpV79iAHEwBaqjCH4 vvYg== X-Gm-Message-State: AC+VfDxzLNfLJRzW2XNJJpa6y/cC5LOblFApoiKqtv9XTu7asSoUAcM8 KcVXid4j0kJbReiPHssV4AP6pg== X-Google-Smtp-Source: ACHHUZ5KDLvsnPMttA35NNkIYcWPtfzYRaU6CCRv6/FNJJk83SuplTOTM88OJQEdxRwdyk+G+FcUBA== X-Received: by 2002:a05:6a20:a115:b0:100:b137:3563 with SMTP id q21-20020a056a20a11500b00100b1373563mr19314283pzk.32.1684987384404; Wed, 24 May 2023 21:03:04 -0700 (PDT) Received: from ubuntu-hf2.default.svc.cluster.local ([101.127.248.173]) by smtp.gmail.com with ESMTPSA id i11-20020aa7908b000000b0064c56d04316sm189916pfa.193.2023.05.24.21.03.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 May 2023 21:03:04 -0700 (PDT) From: Haifeng Xu To: akpm@linux-foundation.org Cc: mhocko@suse.com, david@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Haifeng Xu Subject: [PATCH 2/3] mm/mm_init.c: account absent_page only if spanned_page is non-zero Date: Thu, 25 May 2023 04:01:49 +0000 Message-Id: <20230525040150.1588-2-haifeng.xu@shopee.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 8DFB8140012 X-Stat-Signature: mu53re6hcs3z3kf3sgemi557ybi4xh4j X-HE-Tag: 1684987385-699167 X-HE-Meta: U2FsdGVkX19pkQJZx7LjGgIwsSkcZL3KLdXZiI0D01MVvimRmx+CH8bZ2ZjkOJIXiMocweJrm1lDRsJPbwjXCT0HA4uv/WtLLcv3mW2koA+Qohmkkw72XXFVnUP4SEBrhUOCg1F8/nzUZYzXe/gJ4FUTOc1IW+CnvLoL7xe1aY8rPtB5uvCr3jz8t9gDqeI4NdjSt4RjO7KiwyvHbUVHyF7dCXvgZJx6UYG6Kx/JmVZJlvmGGYxyO9ywlt59axYDt6DOchZdqOCAf6uRvzV+//KfdqhVmq0yZgFX6YyaKY7lyFXOsMTtgGVMeN+uR3UFC9oY9R4ZXFFNWVTUHVyzm5FGyWlTgvoYi5LR0Apk04nIa+w8QRzsJxOlDKOsszOIhevH/dYfRmBZ7YD5lIKOLV4m8HcDrldj5oDWl/jMrb+tFhsNAm04su5OxdgI4cWDWweEvBEWcVhmBk/5t5MN0rgSxmg0zfhWyZcm3LrHWeMMx4YkCV3XpHYLPkxr3Tx1NlhOA2oblLvQQxYOID6RLeXJp9w+/C8h24bXzBPS4Q3l1BmyzNJmdkT7IPbbzMkzDDquofb+CAAH+9lNgESL01/S8ul4xuxet90h1a3I+pyDU24bGc2IszS8ejrBsuD883Nm451g8DGPUA2TMngBOO4YCLOy9I2hsZK2MbEncOBpPOiomnhsjhUrb029TIby5AzA1cSaS+kteyvDsnmn9DsdQb01dMjzzTHzYbn3bn1tB2vimNcx5bqnamznOgqNq2Eof0o0F+7Bt7plUuBHRauMQ5YHu2vrwk1dR5+aNVP1Dnso9fh0FcXnmrz3R4jzmx/O9x6T/MXiINlR2f+NARPf11s6GEt7GylBhrcJ7kkTxWuZbkC1zRW2d3PVyv1KdssdGGHG+D9tK6zf4+RhLogmxaxatWoVwp3uIXD6u2PLHBou80P+BhW+kTmnc1NxDzzV2UKxJ/G5Z07l+XB K56Iy1OQ 50MKeZy0cpdRfa0+cSd8tw9cwVbGfgblOTPuhYhjKsOaKkTXAxlQfwxNswVyIAeniSv+gLH20MlwiKDpT1TiJBUXH6GUVE4g3rr1HraZupP+TtTLybcsAfscg5yBM/DLfPVd5UspzissYTNJO834LZJtdd8ixp6wGwdS7MJkCIDNb+4+VbrZUMRlFK9CDFAJ6trni9JxAO79F8fz5P6R4c9V9g7rghA8cFL/iyckEuTiu9E4ZIuw5XM0fHAjcQT7NyuAUB/TCEX40Aovsvr0IZAYps7/V6pZDt41Q3Jkm8SA+4vkzWdG8HvmqCW2o+3aGyqfoNps6vl7JeLpw0QMNjDyZxiQBhqdTshKWIWs1Rl5Y7SusM3CfZkcdw02LVgr5bIBiqnzYLsZC5YHqPJcDk2U8q7esMbTD8ufb5z0CDNinOkU9s63YvKL5tdY7E1EYwiPD X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: If spanned_page is zero, it's pointless to calculate the number of absent_page. Also, the real size can be assigned to zero directly. Signed-off-by: Haifeng Xu --- mm/mm_init.c | 23 +++++++++++------------ 1 file changed, 11 insertions(+), 12 deletions(-) diff --git a/mm/mm_init.c b/mm/mm_init.c index cf55bba04b23..898af4eb9ce2 100644 --- a/mm/mm_init.c +++ b/mm/mm_init.c @@ -1260,31 +1260,30 @@ static void __init calculate_node_totalpages(struct pglist_data *pgdat, struct zone *zone = pgdat->node_zones + i; unsigned long zone_start_pfn, zone_end_pfn; unsigned long spanned, absent; - unsigned long size, real_size; + unsigned long real_size; spanned = zone_spanned_pages_in_node(pgdat->node_id, i, node_start_pfn, node_end_pfn, &zone_start_pfn, &zone_end_pfn); - absent = zone_absent_pages_in_node(pgdat->node_id, i, - node_start_pfn, - node_end_pfn); - - size = spanned; - real_size = size - absent; - - if (size) + if (spanned) { + absent = zone_absent_pages_in_node(pgdat->node_id, i, + node_start_pfn, + node_end_pfn); + real_size = spanned - absent; zone->zone_start_pfn = zone_start_pfn; - else + } else { + real_size = 0; zone->zone_start_pfn = 0; - zone->spanned_pages = size; + } + zone->spanned_pages = spanned; zone->present_pages = real_size; #if defined(CONFIG_MEMORY_HOTPLUG) zone->present_early_pages = real_size; #endif - totalpages += size; + totalpages += spanned; realtotalpages += real_size; } From patchwork Thu May 25 04:01:50 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Haifeng Xu X-Patchwork-Id: 13254756 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C5DCC77B7E for ; Thu, 25 May 2023 04:03:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D6087280002; Thu, 25 May 2023 00:03:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D10656B0078; Thu, 25 May 2023 00:03:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BD9C6280002; Thu, 25 May 2023 00:03:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id AFD636B0075 for ; Thu, 25 May 2023 00:03:16 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 777E1809AC for ; Thu, 25 May 2023 04:03:16 +0000 (UTC) X-FDA: 80827432392.06.B35E681 Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) by imf04.hostedemail.com (Postfix) with ESMTP id 97F6440005 for ; Thu, 25 May 2023 04:03:13 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=shopee.com header.s=shopee.com header.b=C1d4liKZ; dmarc=pass (policy=reject) header.from=shopee.com; spf=pass (imf04.hostedemail.com: domain of haifeng.xu@shopee.com designates 209.85.210.182 as permitted sender) smtp.mailfrom=haifeng.xu@shopee.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684987393; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=gNj2e5Vi2WIkbEKvTOMKfGlxOu0bnyuA1VYYGOrr0Yo=; b=ux94gi4gO7IF2iGV+rYjo2iNhiLFoSjA/sbg+KqhSty8rvpEh3gUwW7FtTH19AY3Sjuhtd o9d/bo1XWHjhpDoTqhREAWrnsS5ic74ggjrnize/dk1bej9iyNtq1PU6sglf3X+XUYopHr sPSMFboCu2bP817LSAinoM0u/86YKGM= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=shopee.com header.s=shopee.com header.b=C1d4liKZ; dmarc=pass (policy=reject) header.from=shopee.com; spf=pass (imf04.hostedemail.com: domain of haifeng.xu@shopee.com designates 209.85.210.182 as permitted sender) smtp.mailfrom=haifeng.xu@shopee.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684987393; a=rsa-sha256; cv=none; b=lxiO0R5MnyFmdbdXXsEh8m3wCYahFZOJZqD9TDHqQQxfisuWojiNBQIHOkhvOLNSlMEP9o X4cF5Swx/wTeHvdZkiuQVBmJwTY/ejR0h4mZ8DJZc8z8Juml2U82lpIXHRF5HT/fBgj3D0 YYcChO5WdklPFmpxaRMIuAkrtQqOMk8= Received: by mail-pf1-f182.google.com with SMTP id d2e1a72fcca58-64d2a613ec4so1289807b3a.1 for ; Wed, 24 May 2023 21:03:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shopee.com; s=shopee.com; t=1684987392; x=1687579392; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=gNj2e5Vi2WIkbEKvTOMKfGlxOu0bnyuA1VYYGOrr0Yo=; b=C1d4liKZ6puRJ9AH2oIPiS+SjvAzvsi3FfHBafsUWZksEXzfcpaeZOiYFlSc+3EW4C taHtMK6aihD0auG7B6m7TjdFHvOIVce7NXLlxnXdz9fQrfaChbk6HMazh/LuToWoah8i 8OxUImfnhXnQpCFMTYpyIYOA8cJyGzXTdYqyVZ+P1fOqx+7rVFVWXNF9PJy25pyri55f /KxbDXv8WalhMh27Pdc/v5vpjpfMnLVSvuoynurGKjBOmLlxUvPI78yq+8Lk9HKKkU/7 yxUjqWtn1CURH1hJ7nzteV3fY8iW0g2wbbryr0KergvkyF1lo+smv1sjR+oMkRkgZPOY YYtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684987392; x=1687579392; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=gNj2e5Vi2WIkbEKvTOMKfGlxOu0bnyuA1VYYGOrr0Yo=; b=U3I4FF+QnLnfWcYWt6VSLOSVEdz+nVzxsAuV2LDPMShlhIYQhYb6/3/I+KhkH/y/E+ Qk7CH59CQ/9nelzupVhSZ0nzPfv0VqW60/x/ld4tSOSum+7wP5eNSbpm6pI9O0FtmYbO rFVH5o/Vl+x7hGfwE9MmV10uKvVT6j5lgEjEfR3hOpE/XFgnBfuZCoSdVLtu4u5pg6YI OU7jqVa3KY9nU+Ctf2nTG8mFW+dZ80SgyzBwovH/IWoxuYMlRXydd7uPbIRwl5SmdnHR auzTYCkp+/mcJVt0GQ9LN4avUVqC74rwF/FxW53yas3KCzkGN7KXrQ2gKGyrjVjg/a2N F3AQ== X-Gm-Message-State: AC+VfDzy6pGcJCfSfJrLufOvGCM+Kth8I7Vhd4XyXN5uzqCLjA80fFI+ zzID3HHj31gkEm64ufKtzVN5ZA== X-Google-Smtp-Source: ACHHUZ46LHkUfFKGLmC9bs93CWNBwcjgxU+AsZIPWLPp2Gx/kJ5+kN6V2e3c83ee06SiuTOfIrHARg== X-Received: by 2002:aa7:888f:0:b0:648:ebb2:3d6 with SMTP id z15-20020aa7888f000000b00648ebb203d6mr6505780pfe.26.1684987392528; Wed, 24 May 2023 21:03:12 -0700 (PDT) Received: from ubuntu-hf2.default.svc.cluster.local ([101.127.248.173]) by smtp.gmail.com with ESMTPSA id i11-20020aa7908b000000b0064c56d04316sm189916pfa.193.2023.05.24.21.03.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 May 2023 21:03:12 -0700 (PDT) From: Haifeng Xu To: akpm@linux-foundation.org Cc: mhocko@suse.com, david@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Haifeng Xu Subject: [PATCH 3/3] mm/mm_init.c: do not calculate zone_start_pfn/zone_end_pfn in zone_absent_pages_in_node() Date: Thu, 25 May 2023 04:01:50 +0000 Message-Id: <20230525040150.1588-3-haifeng.xu@shopee.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Rspam-User: X-Stat-Signature: 483i116iu7dnoeufyek1ktp1ftcj3d5u X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 97F6440005 X-HE-Tag: 1684987393-185197 X-HE-Meta: U2FsdGVkX1+fwwfsQcyZ+0naJ+dQEt8EDVK+2awt6xN18RT3y+i+OmsnrFJIysBqCqFDD8rah3ysQbhxYGl8RfDOGJsR2rVB/BtdkHlEDwHzlslgdiVHYE/9lvNHLAe+6FhV35QPhc/OqRNlSuAciT92hYJ1yDgiskt6pb76wwWmx7lqzHMpk1nxCc3wSm7MAeMsknSA6ErH64WxN3mB8omJAZSueSo1ALqLHQoyQtXf9QCqzp2uRuj6r2OJAiZOiXxVkwQPJ+Ifbz0wbPzN2f4I2GsNuA4VIF+13Y0X1nIBzG2Apse+QikZrEJZ7OnR0rUqcIkcTRsDly9QbR03nQbGpRxgkyZhxaBFyXhv6D3WMbGz5ccZ6ecik8tFeSdIdqmn2REn4T0mmkd/in9iWJ8QxTJULysjEeHRnFtSa6MEBP5radyVr9yu4Ph4uw1+uB4dnwWwLh5kFp79NwnX+7CcRTusXol31k4EPY9Mft6Wi0hCwVd1CEPCiUleFPiCRRVSVcxlhOtb2KkfDvDEcOn+yaX61GzCj2woXNPg4iHnBlNUb1B0oGApk4iVZoJBXYbO8fv7ueYO2vyZcjRAfrdPC5+8u49pYRE6vckCKBAD6iXCpUjYEcB6ITQb05rFPCdxqIcHxV2vyyLNOFmIVoj7L2WREZucR+0y03F+yytXMED3CTF0asZzHZnAVpX0vtTJfJ87dwY41e1M3IuY/Xarsef+sYyCT2uPlIMS9QjEMuOlEL+Q1uw4pGElcqLXcVt8BSTptKpzDIeF/jrV94MFNGRKb4T8Hgnjbgj8pI7OAFdmZi+SFuPnT0NDpZIQmVJGbZXy+J7wIZHlChnoI9/GbBA+wIVTjTfM/JQfUbunB+Efg9VAJkBxhk6FPM3MN+71HnWV6LuK7Vn1sUnNmiO9cpbw9z7Epk4CSMnQlOtrpioXEwGPi6JhPXOiElW0puN8GFdgr1fkeGKOxiA r/DqIOgh L2reDFlGBOkkKgVP7qdWR0Q7NTUOSNC3dDzL7sUzuuS6bigLzmdTYxHqXFhcN3Qiysm4bnrlVdM9P6pUuJRCmlBryubMa4CPI5zKEr79gQDwgbbunGYg5bhlrvtw375D7ekUCGGFqcoUQCTnNu/lgPl9jV+1HI96MH1H+9OGaEZhFHhm7iAxC0AXeFrXTj1oECrTRsT0Xmr4loF3BG0nPfm55PeGLF4EZ4S7Kh9N/QYf+DhAOKYT9joLULX5JodtM9dN5G+OWP0TcifNHgGJAe4vHlVJefRQkHgAlHDNG6o/l6hk6Ll1zE0EsBOzqGx4TIMvXGN3hXBm5oaAO958B+9SK/iBBb+YIWB1mu7qqeMDxULr50tzk7VuQF4N5PaKNkbwUBnkWjYVZOJQ7peS9jHXQ4bLM4CjGy/YzgK3atxcsw3gZTLFvQhJBIqpcUS1aNG4SAI8UEP2jFieuSpnGnzpoS6Kgsdv6De97 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: In calculate_node_totalpages(), zone_start_pfn/zone_end_pfn are calculated in zone_spanned_pages_in_node(), so use them as parameters instead of node_start_pfn/node_end_pfn and the duplicated calculation process can de dropped. Signed-off-by: Haifeng Xu --- mm/mm_init.c | 35 ++++++++++++----------------------- 1 file changed, 12 insertions(+), 23 deletions(-) diff --git a/mm/mm_init.c b/mm/mm_init.c index 898af4eb9ce2..88c4a9266e2a 100644 --- a/mm/mm_init.c +++ b/mm/mm_init.c @@ -1166,23 +1166,11 @@ unsigned long __init absent_pages_in_range(unsigned long start_pfn, /* Return the number of page frames in holes in a zone on a node */ static unsigned long __init zone_absent_pages_in_node(int nid, unsigned long zone_type, - unsigned long node_start_pfn, - unsigned long node_end_pfn) + unsigned long zone_start_pfn, + unsigned long zone_end_pfn) { - unsigned long zone_low = arch_zone_lowest_possible_pfn[zone_type]; - unsigned long zone_high = arch_zone_highest_possible_pfn[zone_type]; - unsigned long zone_start_pfn, zone_end_pfn; unsigned long nr_absent; - if (!node_start_pfn && !node_end_pfn) - return 0; - - zone_start_pfn = clamp(node_start_pfn, zone_low, zone_high); - zone_end_pfn = clamp(node_end_pfn, zone_low, zone_high); - - adjust_zone_range_for_zone_movable(nid, zone_type, - node_start_pfn, node_end_pfn, - &zone_start_pfn, &zone_end_pfn); nr_absent = __absent_pages_in_range(nid, zone_start_pfn, zone_end_pfn); /* @@ -1254,6 +1242,7 @@ static void __init calculate_node_totalpages(struct pglist_data *pgdat, unsigned long node_end_pfn) { unsigned long realtotalpages = 0, totalpages = 0; + int nid = pgdat->node_id; enum zone_type i; for (i = 0; i < MAX_NR_ZONES; i++) { @@ -1262,15 +1251,15 @@ static void __init calculate_node_totalpages(struct pglist_data *pgdat, unsigned long spanned, absent; unsigned long real_size; - spanned = zone_spanned_pages_in_node(pgdat->node_id, i, - node_start_pfn, - node_end_pfn, - &zone_start_pfn, - &zone_end_pfn); + spanned = zone_spanned_pages_in_node(nid, i, + node_start_pfn, + node_end_pfn, + &zone_start_pfn, + &zone_end_pfn); if (spanned) { - absent = zone_absent_pages_in_node(pgdat->node_id, i, - node_start_pfn, - node_end_pfn); + absent = zone_absent_pages_in_node(nid, i, + zone_start_pfn, + zone_end_pfn); real_size = spanned - absent; zone->zone_start_pfn = zone_start_pfn; } else { @@ -1289,7 +1278,7 @@ static void __init calculate_node_totalpages(struct pglist_data *pgdat, pgdat->node_spanned_pages = totalpages; pgdat->node_present_pages = realtotalpages; - pr_debug("On node %d totalpages: %lu\n", pgdat->node_id, realtotalpages); + pr_debug("On node %d totalpages: %lu\n", nid, realtotalpages); } static unsigned long __init calc_memmap_size(unsigned long spanned_pages,