From patchwork Tue May 30 18:13:48 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 13260892 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7ACB6C77B7A for ; Tue, 30 May 2023 18:15:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232646AbjE3SPC (ORCPT ); Tue, 30 May 2023 14:15:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50570 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231630AbjE3SO7 (ORCPT ); Tue, 30 May 2023 14:14:59 -0400 Received: from mail-pj1-x1032.google.com (mail-pj1-x1032.google.com [IPv6:2607:f8b0:4864:20::1032]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3BCDFE8 for ; Tue, 30 May 2023 11:14:57 -0700 (PDT) Received: by mail-pj1-x1032.google.com with SMTP id 98e67ed59e1d1-256422ad25dso2565516a91.0 for ; Tue, 30 May 2023 11:14:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1685470496; x=1688062496; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=wejmfms/MTruDYODALqcJ51ghyqKDRBVlvqid0DKdUU=; b=ngR8WUfo12QEnVFptE3frRjlZIIv53yMuBehH6/yqZOlhdWodxtvmMkx4cOCKLFU1J Be5nnnNc0oj+fBcVqMR42F8lJMRreGmaZWldywOfCmuKn1xMjguK+JS9revnMtiAt15k E9DV64QoXxjJTIK8Z2cJOcAC1sfuuGrLrLVL8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685470496; x=1688062496; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=wejmfms/MTruDYODALqcJ51ghyqKDRBVlvqid0DKdUU=; b=eSsnhwaAU87peaL3zucPz7QNkAdb8kSdnJDK6cXtkVvyWVIyUkTxmLzeY+olJ3klis 5irgd2XuTYM6lJ1heD+cy66FCSUKIeml5k8BXUQxLs+LlzDzTeD2KSvhKMRUb2gvNqqY 8otO6FOqb48UqrgsK23hOfF3V9Ax3pba52VAKLaO/2OSOnXQ6aE5Xxomq0GAAQ6XswW2 7M0Ip9LQYPwHWeMf/vmhIG3peGhRQ11Hov2bt5c1nniZKig8sGJkbBUmLf/6voeAIwrI xvJh+4N9jwAu3Xlmhd6SpOd9N3ZYVJUt8Vx64Ysgxico3FAE/w/YSn30JGj9ZEWC02mn MGbA== X-Gm-Message-State: AC+VfDwx1yYBS7eXpRnhzOH9jwCpqMZNIt/VUKLYQ6qjHhBeimIYV7+n QJI1KM+Av5sFrFXLAy5/c0I9ow== X-Google-Smtp-Source: ACHHUZ7XQtTdVlY0DHCmMiZA+STEzORTjmprrjia5mLFvW/qUUbtteO21yEtKVNdONuLVxcpl5n8ZA== X-Received: by 2002:a17:90a:b298:b0:256:2ee5:aebc with SMTP id c24-20020a17090ab29800b002562ee5aebcmr3133136pjr.18.1685470496708; Tue, 30 May 2023 11:14:56 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:15c:9d:2:49d0:fe41:5206:ac47]) by smtp.gmail.com with ESMTPSA id m10-20020a17090b068a00b0024df6bbf5d8sm9288614pjz.30.2023.05.30.11.14.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 May 2023 11:14:56 -0700 (PDT) From: Douglas Anderson To: Mark Brown , Vijaya Krishna Nivarthi Cc: Stephen Boyd , Douglas Anderson , Andy Gross , Bjorn Andersson , Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org Subject: [PATCH] spi: spi-qcom-qspi: Add newline to PIO fallback warning Date: Tue, 30 May 2023 11:13:48 -0700 Message-ID: <20230530111348.1.Ibd1f4827e18a26dc802cd6e5ac300d83dc1bc41c@changeid> X-Mailer: git-send-email 2.41.0.rc0.172.g3f132b7071-goog MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org A warning added in commit b5762d95607e ("spi: spi-qcom-qspi: Add DMA mode support") was missing a newline. Add it. Reported-by: Stephen Boyd Closes: https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/4573857/comment/44331d65_79128099/ Fixes: b5762d95607e ("spi: spi-qcom-qspi: Add DMA mode support") Signed-off-by: Douglas Anderson --- drivers/spi/spi-qcom-qspi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/spi-qcom-qspi.c b/drivers/spi/spi-qcom-qspi.c index a3991e617c90..a8a683d6145c 100644 --- a/drivers/spi/spi-qcom-qspi.c +++ b/drivers/spi/spi-qcom-qspi.c @@ -445,7 +445,7 @@ static int qcom_qspi_transfer_one(struct spi_master *master, qcom_qspi_dma_xfer(ctrl); goto exit; } - dev_warn_once(ctrl->dev, "DMA failure, falling back to PIO"); + dev_warn_once(ctrl->dev, "DMA failure, falling back to PIO\n"); ret = 0; /* We'll retry w/ PIO */ }