From patchwork Fri Jun 2 22:16:02 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 13265936 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AA087C7EE29 for ; Fri, 2 Jun 2023 22:47:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=PzcE8j9sSKcXbmvG2R/PItxRkgCD8/mvp5lrgTmApe4=; b=cfqoAu150+Td6l 3v7SNIK4p2LuwmfPJYI5XKX9gNHdkRK19WKKVUrepKp2yZVw5n1rCYGcNB7x1vdFt8KiU+iYmk4D6 MznAZXTa85tUGkEUqe1kQZvdBy8eeMzkwFeNUMJhochc+fZ17b6rsLqljrfCcl8FLLsnDmPfB2t6q NGyzKdm5QpEA3lL7Ho+saRgfuzBUmHi/kooy2XH4YCAIDfTTV88DN8bTyAcFI6u+cEx0cglOrIRrm jKXUX41LXJXtH1Icr82XCc81pmPu8d7Q8P9J5ivpX+fI+8buvkCkSuQL6Kp5P4IS9szPyqyxqNSsh d4XZkZSjgurleiCFUmww==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q5DYR-008609-2C; Fri, 02 Jun 2023 22:47:31 +0000 Received: from mail-ot1-x329.google.com ([2607:f8b0:4864:20::329]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q5DYN-0085zd-1W for linux-arm-kernel@lists.infradead.org; Fri, 02 Jun 2023 22:47:28 +0000 Received: by mail-ot1-x329.google.com with SMTP id 46e09a7af769-6af9f389fc6so288873a34.1 for ; Fri, 02 Jun 2023 15:47:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685746046; x=1688338046; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=YaPsyLeb5FyKRIBkJzm+0FR3Zt6fEWpe98Trce5vtAY=; b=V0UXgYe2Gx2t7JHxptL1ofxL/R+M1XwXVklf7AthTQiiWtixMdWwLU+0x/ffM5AcS/ DEmTvPdGBzhrvHHYi0CoTY58QQS0GhWGwVNsh8JEh9gbNTiubwOZteVqqKTgR3Jp6X4b XCCoP+CLpUyyJAs6gNK5sbf1NDARwkp29vGCRjnnFlh4ltxvqWfDqQAXu7HjaERF8vm+ 3rXN4pFSftPHt165L0FMHeTCd1E2xrLr0lgWIm8W121ZtrNw3l1EiC1iiY466pPCl91w yOJu6VQbmKzdascRw27PEutm9NVTIJ/n2WA8hT/yIf7vmpsjsh3CGlSJH87tnYCZAgJ3 Nhyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685746046; x=1688338046; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=YaPsyLeb5FyKRIBkJzm+0FR3Zt6fEWpe98Trce5vtAY=; b=fFvgGlsLxqVz4fShqF5S3QCG2+WvaubSUK1neGOpZxqPnWsQ+HvLXygfJ8yYPYhtWS bg8j1KrarfHFoL5AfTjS7dvnR2GqS+/kcRZ0LENcQF8kXlERi6ZToeXVvpCcJjRtTzB7 8FhtSTTYTv2l6+CMKaNYg0zUfmJYuAiXyMMBVFM2xb9fnu1JLRECSqIGoFIm6GuvaX72 ZZ52FCUAB9sWH5cUYuerqTDBvIVoPaZwqNoM8tqTkj4nyBwaSeTvT04eBnMR4LK20h41 VPtjFsNqezEA0+OrwlPf6SX0T4zSZkF7E/icrPyQxmL33m3PTabmszCukbGDGOAEpMP/ PvlQ== X-Gm-Message-State: AC+VfDxpF26yJh3LVhOhQDiU+d+PbHBKdO7rI06FC68JED6uQH7mW0dC 6FGhalkWxZ3qGu05PKjXOv18GFERWic= X-Google-Smtp-Source: ACHHUZ6RqSGNNXksBXWmvjRaNtjha/H2AFlj+aOTib8aUYjfs5QsvNzi4Og5/aTAtwzKt9LaY+8mNQ== X-Received: by 2002:a05:6870:c08e:b0:192:beba:7bd with SMTP id c14-20020a056870c08e00b00192beba07bdmr8503650oad.2.1685744175578; Fri, 02 Jun 2023 15:16:15 -0700 (PDT) Received: from fabio-Precision-3551.. ([2804:14c:485:4b61:dad1:c980:e6de:3901]) by smtp.gmail.com with ESMTPSA id k4-20020a4a4304000000b005584e0c8f9csm951587ooj.3.2023.06.02.15.16.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Jun 2023 15:16:15 -0700 (PDT) From: Fabio Estevam To: shawnguo@kernel.org Cc: hs@denx.de, abelvesa@kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Fabio Estevam Subject: [PATCH 1/3] ARM: dts: imx6sx: Remove LDB endpoint Date: Fri, 2 Jun 2023 19:16:02 -0300 Message-Id: <20230602221604.155027-1-festevam@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230602_154727_515507_7149513E X-CRM114-Status: GOOD ( 11.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Fabio Estevam Remove the LDB endpoint description from the common imx6sx.dtsi as it causes regression for boards that has the LCDIF connected directly to a parallel display. Let the LDB endpoint be described in the board devicetree file instead. Fixes: b74edf626c4f ("ARM: dts: imx6sx: Add LDB support") Signed-off-by: Fabio Estevam --- arch/arm/boot/dts/imx6sx.dtsi | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/arch/arm/boot/dts/imx6sx.dtsi b/arch/arm/boot/dts/imx6sx.dtsi index 3a4308666552..41c900929758 100644 --- a/arch/arm/boot/dts/imx6sx.dtsi +++ b/arch/arm/boot/dts/imx6sx.dtsi @@ -863,7 +863,6 @@ port@0 { reg = <0>; ldb_from_lcdif1: endpoint { - remote-endpoint = <&lcdif1_to_ldb>; }; }; @@ -1309,11 +1308,8 @@ lcdif1: lcdif@2220000 { power-domains = <&pd_disp>; status = "disabled"; - ports { - port { - lcdif1_to_ldb: endpoint { - remote-endpoint = <&ldb_from_lcdif1>; - }; + port { + lcdif1_to_ldb: endpoint { }; }; }; From patchwork Fri Jun 2 22:16:03 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 13265914 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4C4D4C7EE2C for ; Fri, 2 Jun 2023 22:23:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=J19ZoesUBiqPxIE196KyYWNUUVofsAS2pnpPvfvW8Cc=; b=4uMmslCsC4M5xf ddFU+SGVcWrxIxZ6iMJbDNEom0bxzpKTbWwO/wjIOrFRu6X/Rog7ZcKjRwFwEE8eeOyEPCfPWJvkd +9tcYwDZbNAORHhd5FebZrJUgBQQQc00z07XzMiuMWgvTGcEvl1wsJAp7Xhxf/v+QStiiZlQmcdsQ WqGUP6c7S2xOgrG2L1Rj5YBlspiI5qmCh1q7lqNXSNPUOd6sZjcTk4yFRGcKxGJA3avlxkwEP32kG dU7EP8ZoZesU+3vV8MBWrlBa+hK0tvhdCWvs6Er2k2D3oLi3/WmvV6PFs9Okj/PjyyfizPXSTMLkG YH+39alNBL2uzdQh6PtQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q5DAU-0083tR-0S; Fri, 02 Jun 2023 22:22:46 +0000 Received: from mail-qt1-x82c.google.com ([2607:f8b0:4864:20::82c]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q5DAR-0083sr-1g for linux-arm-kernel@lists.infradead.org; Fri, 02 Jun 2023 22:22:44 +0000 Received: by mail-qt1-x82c.google.com with SMTP id d75a77b69052e-3f7f53e8444so3095471cf.0 for ; Fri, 02 Jun 2023 15:22:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685744560; x=1688336560; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=mK9ooTnIIPstvRuHFdXn4jUqcXC6NMJg2ggUZKFIvy8=; b=BRTdr3vwHAgPPzQ6E1wQ0mLg5i5bxh1OMeABMF5qKH1xEvKF9GlJgK69Qp0+aXQ/Wm k/RUGA77SSeq9FHmTLj07lO6DmDoO+aNNhXsYr7jWYZjGq4U8wbLH3vCIZpIMDwShG9B 4xHD14wGPhi3/ERV5pL5DXU4JMv9XT7qaggBgt+2GOD675+S4n3h9W3Kxcd6WdAQIUne kgMjdGk+5LhDj+vlt4GhKVFlZXPGHQTDxAHp9upecaaEi74DilIF9DI7vEuD0YEO3jnf xGaBAS0NS9xt/uxhlCCs/tOyF/3fDxdb+N2C3ROEd8DetqaMTGFlHq3+CMRoIM34qXim NOTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685744560; x=1688336560; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mK9ooTnIIPstvRuHFdXn4jUqcXC6NMJg2ggUZKFIvy8=; b=DEHsqRhRf4lb1Jlh2tPNjg+Q0jq8rE+LNM4djkr+IEegXCnQnHbkHRZZz+hQ/N6R4t oT6uVnynVIEGRkBjU/c6cs/VJtNSdmAqN+Wn0elBrQpfdXqwRGRTUsk+/qxtWc7EJiYW 04KL7HnAEgRVN4nin0pi0tQA178yT67eg61ta1bYTVdoN0E6VdS3kTuRY+NR6tyrpAPi k+sHTiB+DKwSIpOjOvwSN/HcJGNS5UhD87emEpdBst7l1iqW1o375y31b3+LpltPYSpY glrD8xF5TLbML2DFLY+biSOirR+/Gu+mpqL71h4baFc0oJrTZEub6mXZaKsmY1DbpxtW GcmQ== X-Gm-Message-State: AC+VfDyXEoQT0VenyX8lsY4jRNgeYB427fM8wLSOuIy8OXdWAnPSLU5f BCJwyCaYmCiRZLq7jcvVQAQ+ejEVP3g= X-Google-Smtp-Source: ACHHUZ5PcZIPcD/CDwiMTGCm6Hjx0oaaa6NIs0etRWPWX9rPJxQ+L5t5kG7HP1j3LClnmyBj1/DBxg== X-Received: by 2002:a05:6870:8184:b0:187:afcb:87ec with SMTP id k4-20020a056870818400b00187afcb87ecmr7646427oae.4.1685744179006; Fri, 02 Jun 2023 15:16:19 -0700 (PDT) Received: from fabio-Precision-3551.. ([2804:14c:485:4b61:dad1:c980:e6de:3901]) by smtp.gmail.com with ESMTPSA id k4-20020a4a4304000000b005584e0c8f9csm951587ooj.3.2023.06.02.15.16.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Jun 2023 15:16:18 -0700 (PDT) From: Fabio Estevam To: shawnguo@kernel.org Cc: hs@denx.de, abelvesa@kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Fabio Estevam Subject: [PATCH 2/3] ARM: dts: imx6sx: Describe the default LCDIF1 parent Date: Fri, 2 Jun 2023 19:16:03 -0300 Message-Id: <20230602221604.155027-2-festevam@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230602221604.155027-1-festevam@gmail.com> References: <20230602221604.155027-1-festevam@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230602_152243_564829_EB24DDB2 X-CRM114-Status: GOOD ( 13.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Fabio Estevam A suitable default for the LCDIF parent is the PLL5 clock, so describe it in the device tree. The imx6sx clock driver harcodes PLL5 as the LCDIF1 parent, but in preparation for removing such hardcoding, describe the parent relationship via devicetree. There are some boards that may want to use a different parent for the LCDIF due to EMI reasons, for example. With this approch, the user can change the LCDIF parent in the board devicetree if needed. Signed-off-by: Fabio Estevam --- arch/arm/boot/dts/imx6sx.dtsi | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/arch/arm/boot/dts/imx6sx.dtsi b/arch/arm/boot/dts/imx6sx.dtsi index 41c900929758..0d549e1f3ced 100644 --- a/arch/arm/boot/dts/imx6sx.dtsi +++ b/arch/arm/boot/dts/imx6sx.dtsi @@ -1305,6 +1305,10 @@ lcdif1: lcdif@2220000 { <&clks IMX6SX_CLK_LCDIF_APB>, <&clks IMX6SX_CLK_DISPLAY_AXI>; clock-names = "pix", "axi", "disp_axi"; + assigned-clocks = <&clks IMX6SX_CLK_LCDIF1_PRE_SEL>, + <&clks IMX6SX_CLK_LCDIF1_SEL>; + assigned-clock-parents = <&clks IMX6SX_CLK_PLL5_VIDEO_DIV>, + <&clks IMX6SX_CLK_LCDIF1_PODF>; power-domains = <&pd_disp>; status = "disabled"; From patchwork Fri Jun 2 22:16:04 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 13265915 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6ED76C7EE2C for ; Fri, 2 Jun 2023 22:23:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=SLyWicqykDmB/T8xVwowopRnSmx5vYtrRInKNIrhjMk=; b=WDF34lyOv+/XFC iaOxRp8FLJHPO+uWV6A4e6XLPmzVingQlo01yA/DRGcv17yBSvzqGbHY3bfVmGeOACH1hfBpLud2z O+YzOteEEW0NMZTtDn4bh/ofLlvUJ5m+leqnYQrEfpLzprn2yzzM9fgNzqkfEaZux0kCpG1NYA4Lg AoCUMjx34w80RKwJ5F7KZL5xCZmX+Vh0H/E/8PIcTEXAsZcnJQoxC+1TbNMTQ2C82808ZWFlU+C/z jIJWiziAYEOEy+NG92jO782ZKUtzApgQhJO2K/TsgXFkZzqjn9/gteUSW65f9K1yiEsHqd2606IXB yvdmuT5FINez4NNTaJ1g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q5DB6-0083yR-2C; Fri, 02 Jun 2023 22:23:24 +0000 Received: from mail-pf1-x42f.google.com ([2607:f8b0:4864:20::42f]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q5DB4-0083xZ-0P for linux-arm-kernel@lists.infradead.org; Fri, 02 Jun 2023 22:23:23 +0000 Received: by mail-pf1-x42f.google.com with SMTP id d2e1a72fcca58-64f48625615so313803b3a.0 for ; Fri, 02 Jun 2023 15:23:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685744599; x=1688336599; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2rErrTpHTVSZk1IodoNCi7TyWfBvMAj2ALKyW0WqhMw=; b=NPBAmaqsmd0W7VRlZNBXGhioB0AvwQU2N8U6fq25Xng4G/X2p1tVdueAHsHJWXprtn 5i6N5IgRM+ebyG3aTIk3Perx5wCvN4gEIUDSSUkuLla+sCRPxHkuaaJYpcJgxGBvyAFT dwEgZa4DqeJiXONHJbkmiBBuM6mjoS2KCDYJuVeiUvhmYkipFq/PQ77yi3krY5Zdu6jT cha24BqIYoAH0mLlT8P4c77/KLNCI+5QXsPphCzw9S/1PHXwtjBXEWkH7Z9y5JyGuxW4 q4QAqIC7+3CqLiCYURWxLbMD93n8Kb8PDY9EMRHyJVmXL0AIVUOZMRRmaFB41cVnjR7F GANA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685744599; x=1688336599; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2rErrTpHTVSZk1IodoNCi7TyWfBvMAj2ALKyW0WqhMw=; b=M44zyzbWDVdJVVYsZKdGQxaEpnvlmRf+iLJXPGAjEul5YsspXIULrju5KX77Sp/p07 3Ex4N38SjCqX2COor+68zCtGjooiRkH4p1L4otNSTf4bdYOGIj5hziO1g+z/zXWVXYPQ JrXc5nHo0XKv3O1P+PDqFfpLoBya7KkBr5vpe2C7qbS4D8wuIB7Ze3/wn+/aC2/QIeMs IJ3V4UuPO3tykArese0lNfkhkfaUywBJyS8BCl3HnW9TJfoz9aEi8Bjy6PKBSnkIUfjI HyQZGyJndLt3nd+VRXXTQlXIHCIQ8UUjJhShgtT2iWgUApA29yLStIfZ+iwCzubsP+K+ poZQ== X-Gm-Message-State: AC+VfDyEZsBZwA4LORgopI+YzArpvAQHndrpveBiX2fQaETspi+q/dzM m22UCEo76aqcRaLZ6kzp051VpQB+3Rs= X-Google-Smtp-Source: ACHHUZ4sxR8twVuVuqR45j0iedDkPDiMF8PknPV7ZyI4sX8skgaWe5xRXuzh3ossftDr0lRyOa3Fcg== X-Received: by 2002:a4a:ba8d:0:b0:547:50b4:9236 with SMTP id d13-20020a4aba8d000000b0054750b49236mr5707180oop.0.1685744182271; Fri, 02 Jun 2023 15:16:22 -0700 (PDT) Received: from fabio-Precision-3551.. ([2804:14c:485:4b61:dad1:c980:e6de:3901]) by smtp.gmail.com with ESMTPSA id k4-20020a4a4304000000b005584e0c8f9csm951587ooj.3.2023.06.02.15.16.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Jun 2023 15:16:21 -0700 (PDT) From: Fabio Estevam To: shawnguo@kernel.org Cc: hs@denx.de, abelvesa@kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Fabio Estevam Subject: [PATCH 3/3] clk: imx: imx6sx: Remove hardcoded LCDIF1 parent Date: Fri, 2 Jun 2023 19:16:04 -0300 Message-Id: <20230602221604.155027-3-festevam@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230602221604.155027-1-festevam@gmail.com> References: <20230602221604.155027-1-festevam@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230602_152322_162577_6491C8A5 X-CRM114-Status: GOOD ( 12.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Fabio Estevam It is not a good idea to hardcode the LCDIF1 parent inside the clock driver because some users may want to use a different clock parent for LCDIF1. One of the reasons could be related to EMI tests. Remove the harcoded LCDIF1 parent as this is better described via devicetree. Signed-off-by: Fabio Estevam --- drivers/clk/imx/clk-imx6sx.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/clk/imx/clk-imx6sx.c b/drivers/clk/imx/clk-imx6sx.c index 3f1502933e59..b110258b9036 100644 --- a/drivers/clk/imx/clk-imx6sx.c +++ b/drivers/clk/imx/clk-imx6sx.c @@ -498,10 +498,6 @@ static void __init imx6sx_clocks_init(struct device_node *ccm_node) clk_set_parent(hws[IMX6SX_CLK_EIM_SLOW_SEL]->clk, hws[IMX6SX_CLK_PLL2_PFD2]->clk); clk_set_rate(hws[IMX6SX_CLK_EIM_SLOW]->clk, 132000000); - /* set parent clock for LCDIF1 pixel clock */ - clk_set_parent(hws[IMX6SX_CLK_LCDIF1_PRE_SEL]->clk, hws[IMX6SX_CLK_PLL5_VIDEO_DIV]->clk); - clk_set_parent(hws[IMX6SX_CLK_LCDIF1_SEL]->clk, hws[IMX6SX_CLK_LCDIF1_PODF]->clk); - /* Set the parent clks of PCIe lvds1 and pcie_axi to be pcie ref, axi */ if (clk_set_parent(hws[IMX6SX_CLK_LVDS1_SEL]->clk, hws[IMX6SX_CLK_PCIE_REF_125M]->clk)) pr_err("Failed to set pcie bus parent clk.\n");