From patchwork Tue Jun 6 08:57:05 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johannes Berg X-Patchwork-Id: 13268735 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06B5EC77B7A for ; Tue, 6 Jun 2023 08:57:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237042AbjFFI50 (ORCPT ); Tue, 6 Jun 2023 04:57:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46150 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237243AbjFFI5U (ORCPT ); Tue, 6 Jun 2023 04:57:20 -0400 Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:191:4433::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 915A010D7; Tue, 6 Jun 2023 01:57:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sipsolutions.net; s=mail; h=Content-Transfer-Encoding:MIME-Version: Message-Id:Date:Subject:Cc:To:From:Content-Type:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-To:Resent-Cc: Resent-Message-ID:In-Reply-To:References; bh=iAvSNf9q5H7Fglw+xBqescyQX0+5g18cx1WVw0mtFJM=; t=1686041835; x=1687251435; b=ucRmKruXVABKqw2i94E4yzYRB+HPv6sk4wqVlkVlVrE8DzJ2ED+brrSIvomsBO86XjbreHH9M0u R+Zg/MA3j5afqmXG0NYBtMBTRUx7bn8zOdURnWRuenCXTjpanDUBROnN6TFv+1W2B8r225g80HK7L St/kPH7gza2FGS87PNxP4zQhFlty+YGgZMioa4BKM23jkI6n+QHkHZVlx04bONT44oRBtddiGgCMm t4JDSz5PqmByALNoxitFcrwxi3BzWLeN273avf2s9Nty+Q9xzHnDvtCG5wI9nTdUlXAB572fDoX45 qrULDZr6h/CszuZdr8zJDfWrqzxaKZ2FXh1A==; Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.96) (envelope-from ) id 1q6SV6-00FTy6-35; Tue, 06 Jun 2023 10:57:13 +0200 From: Johannes Berg To: linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org, linux-doc@vger.kernel.org Cc: Masahiro Yamada , Johannes Berg Subject: [PATCH v2 1/2] kernel-doc: don't let V=1 change outcome Date: Tue, 6 Jun 2023 10:57:05 +0200 Message-Id: <20230606105706.60807b85ff79.I21ab3b54eeebd638676bead3b2f87417944e44f3@changeid> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kbuild@vger.kernel.org From: Johannes Berg The kernel-doc script currently reports a number of issues only in "verbose" mode, but that's initialized from V=1 (via KBUILD_VERBOSE), so if you use KDOC_WERROR=1 then adding V=1 might actually break the build. This is rather unexpected. Change kernel-doc to not change its behaviour wrt. errors (or warnings) when verbose mode is enabled, but rather add separate warning flags (and -Wall) for it. Allow enabling those flags via environment/make variables in the kernel's build system for easier user use, but to not have to parse them in the script itself. Signed-off-by: Johannes Berg Acked-by: Jonathan Corbet --- v2: - parse environment variables in build system rather than the script itself, as suggested by Masahiro Yamada - fix indentation --- scripts/Makefile.build | 7 ++++++- scripts/kernel-doc | 28 +++++++++++++++++++++++----- 2 files changed, 29 insertions(+), 6 deletions(-) diff --git a/scripts/Makefile.build b/scripts/Makefile.build index 9f94fc83f086..90bb5badb0e9 100644 --- a/scripts/Makefile.build +++ b/scripts/Makefile.build @@ -101,7 +101,12 @@ else ifeq ($(KBUILD_CHECKSRC),2) endif ifneq ($(KBUILD_EXTRA_WARN),) - cmd_checkdoc = $(srctree)/scripts/kernel-doc -none $< + cmd_checkdoc = $(srctree)/scripts/kernel-doc -none \ + $(if $(KDOC_WALL), -Wall) \ + $(if $(KDOC_WRETURN), -Wreturn) \ + $(if $(KDOC_WSHORT_DESC), -Wshort-desc) \ + $(if $(KDOC_WSHORT_DESC), -Wcontents-before-sections) \ + $< endif # Compile C sources (.c) diff --git a/scripts/kernel-doc b/scripts/kernel-doc index 2486689ffc7b..8f8440870a0f 100755 --- a/scripts/kernel-doc +++ b/scripts/kernel-doc @@ -23,7 +23,7 @@ kernel-doc - Print formatted kernel documentation to stdout =head1 SYNOPSIS - kernel-doc [-h] [-v] [-Werror] + kernel-doc [-h] [-v] [-Werror] [-Wall] [-Wreturn] [-Wshort-description] [-Wcontents-before-sections] [ -man | -rst [-sphinx-version VERSION] [-enable-lineno] | -none @@ -133,6 +133,9 @@ my $dohighlight = ""; my $verbose = 0; my $Werror = 0; +my $Wreturn = 0; +my $Wshort_desc = 0; +my $Wcontents_before_sections = 0; my $output_mode = "rst"; my $output_preformatted = 0; my $no_doc_sections = 0; @@ -187,9 +190,14 @@ if (defined($ENV{'KCFLAGS'})) { } } +# reading this variable is for backwards compat just in case +# someone was calling it with the variable from outside the +# kernel's build system if (defined($ENV{'KDOC_WERROR'})) { $Werror = "$ENV{'KDOC_WERROR'}"; } +# other environment variables are converted to command-line +# arguments in cmd_checkdoc in the build system # Generated docbook code is inserted in a template at a point where # docbook v3.1 requires a non-zero sequence of RefEntry's; see: @@ -318,6 +326,16 @@ while ($ARGV[0] =~ m/^--?(.*)/) { $verbose = 1; } elsif ($cmd eq "Werror") { $Werror = 1; + } elsif ($cmd eq "Wreturn") { + $Wreturn = 1; + } elsif ($cmd eq "Wshort-desc") { + $Wshort_desc = 1; + } elsif ($cmd eq "Wcontents-before-sections") { + $Wcontents_before_sections = 1; + } elsif ($cmd eq "Wall") { + $Wreturn = 1; + $Wshort_desc = 1; + $Wcontents_before_sections = 1; } elsif (($cmd eq "h") || ($cmd eq "help")) { pod2usage(-exitval => 0, -verbose => 2); } elsif ($cmd eq 'no-doc-sections') { @@ -1748,9 +1766,9 @@ sub dump_function($$) { # This check emits a lot of warnings at the moment, because many # functions don't have a 'Return' doc section. So until the number # of warnings goes sufficiently down, the check is only performed in - # verbose mode. + # -Wreturn mode. # TODO: always perform the check. - if ($verbose && !$noret) { + if ($Wreturn && !$noret) { check_return_section($file, $declaration_name, $return_type); } @@ -2054,7 +2072,7 @@ sub process_name($$) { $state = STATE_NORMAL; } - if (($declaration_purpose eq "") && $verbose) { + if (($declaration_purpose eq "") && $Wshort_desc) { emit_warning("${file}:$.", "missing initial short description on line:\n$_"); } @@ -2103,7 +2121,7 @@ sub process_body($$) { } if (($contents ne "") && ($contents ne "\n")) { - if (!$in_doc_sect && $verbose) { + if (!$in_doc_sect && $Wcontents_before_sections) { emit_warning("${file}:$.", "contents before sections\n"); } dump_section($file, $section, $contents); From patchwork Tue Jun 6 08:57:06 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johannes Berg X-Patchwork-Id: 13268736 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0608EC77B73 for ; Tue, 6 Jun 2023 08:57:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237361AbjFFI51 (ORCPT ); Tue, 6 Jun 2023 04:57:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46172 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237330AbjFFI5V (ORCPT ); Tue, 6 Jun 2023 04:57:21 -0400 Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:191:4433::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 345E310D8; Tue, 6 Jun 2023 01:57:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sipsolutions.net; s=mail; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Content-Type:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-To: Resent-Cc:Resent-Message-ID; bh=6Jfqh7+Yp3/D9bkuECnNj4TIYjvEwVcWvp8C30R7kuM=; t=1686041836; x=1687251436; b=hwGdMiArSI6kAYcv6P3jHPE9yN8Xe1y/FWd2nqq3hz7J3w+ lD/2pi1MlCR8/iRbJV6eijBRT62RgKW79Yt7f6EQ2cQEDDwOKGtom8Jwt+1KoWBsItq20P+YKab6N Ex9fbSySqEGhBCeIMkhUmff2YjIeWBuoo5Qtr6Ej1PWjpHoTC78I0IgGZofnZpxzte2nbbqjqufgy aiu5B66SFluWDk+MKY2m3dv5y0c9IS2nd+HPl62UyA6lnUJDmEyM8wlxEuXh2JfMPFXaVpB1TsY8w V96FBFuiDo40swNQJNh+keurzyvytTC82G8q4HR43OUqfADcaBUvsWRA9rLYLJ0w==; Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.96) (envelope-from ) id 1q6SV7-00FTy6-1G; Tue, 06 Jun 2023 10:57:13 +0200 From: Johannes Berg To: linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org, linux-doc@vger.kernel.org Cc: Masahiro Yamada , Johannes Berg Subject: [PATCH v2 2/2] kbuild: enable kernel-doc -Wall for W=2 Date: Tue, 6 Jun 2023 10:57:06 +0200 Message-Id: <20230606105706.eb8a57848349.Ibd08cad396b630b68d93b2469905ad55b375af65@changeid> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230606105706.60807b85ff79.I21ab3b54eeebd638676bead3b2f87417944e44f3@changeid> References: <20230606105706.60807b85ff79.I21ab3b54eeebd638676bead3b2f87417944e44f3@changeid> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kbuild@vger.kernel.org From: Johannes Berg For W=2, we can enable more kernel-doc warnings, such as missing return value descriptions etc. Signed-off-by: Johannes Berg --- v2: - create command-line instead of exporting an env var, as suggested by Masahiro Yamada --- scripts/Makefile.build | 1 + 1 file changed, 1 insertion(+) diff --git a/scripts/Makefile.build b/scripts/Makefile.build index 90bb5badb0e9..920eeee2cb6e 100644 --- a/scripts/Makefile.build +++ b/scripts/Makefile.build @@ -102,6 +102,7 @@ endif ifneq ($(KBUILD_EXTRA_WARN),) cmd_checkdoc = $(srctree)/scripts/kernel-doc -none \ + $(if $(findstring 2, $(KBUILD_EXTRA_WARN)), -Wall) \ $(if $(KDOC_WALL), -Wall) \ $(if $(KDOC_WRETURN), -Wreturn) \ $(if $(KDOC_WSHORT_DESC), -Wshort-desc) \