From patchwork Wed Jun 7 23:43:52 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kuninori Morimoto X-Patchwork-Id: 13271455 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C3920C77B7A for ; Wed, 7 Jun 2023 23:45:36 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 8B03E82B; Thu, 8 Jun 2023 01:44:44 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 8B03E82B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1686181534; bh=E2eCwt7qkU7LdauJxH11BMjrQnn13YMQvX446QNbNsw=; h=From:To:Cc:Subject:In-Reply-To:References:Date:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=a397AP+mdpsrp93Pc68WyBG8c8OT/v/vhOdIjgYPCbBxuAf/yvHh0f/0c92FR3Q+q nYD6ZXR8h+eBY6gjVXf8czSkauL9y2d/jRsI78aD7FynlezN7MI1o90xfi/AzPuAHx tdSJRZAoaQZ6Rggpe+QqH7g7YbHNrvuhE/uv0I58= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 24B9EF800ED; Thu, 8 Jun 2023 01:44:03 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id AD59FF800ED; Thu, 8 Jun 2023 01:44:02 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 568A0F80549; Thu, 8 Jun 2023 01:43:59 +0200 (CEST) Received: from JPN01-OS0-obe.outbound.protection.outlook.com (mail-os0jpn01on20713.outbound.protection.outlook.com [IPv6:2a01:111:f403:700c::713]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id C034AF800ED for ; Thu, 8 Jun 2023 01:43:53 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz C034AF800ED Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=renesas.com header.i=@renesas.com header.a=rsa-sha256 header.s=selector1 header.b=WVEQIplq ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IzJSYqq45nSsPsNKy7IbcC2gW0OZVSkwTMQxTlzzjG5LX8X4WjgZ+exR9bqFDY9M8MIIeAMeSZKnPWhZVm+wfRHoerySjZFwgMFi+SEMJehVLXtTQ5/wEJrrJuCO8JEhYPPje12QX+DG7dStGzcGgONRc4b80hnW9tV9tbVBLgp9tO69qRf707OKm/Lk5Iu+SsmodRRISb+r2dx4t8TIjDbZjh9HayUxdgMfZ/U2toaEp0ojK+/C06oQbmWDDcIwvgIkgy5LsJP3UIhFz0q9H9kbG0/S2LY2odOuwZMo5Ww6nfuI4LB5BJN413bxEC01/s8gv9/o1xVIlKa3J1bnpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=V2dDgWZ1lwZDbtLxyn0VkYXLlSbrymhX7dubZAyFH5A=; b=IIln2n+Pul4+DQKJ+dem1NLu6tIc9B2922JX0tg0wpBQyRdCGLfOsmpbV3JUNm9VM/aONYFy31gZkOPUqvEtFMQUKyHOUVj4DSppS8OtLzA8z7p4y5Ry+NIrkdpdHH2Fl0BGhsfiV2xXGwsLX/3Y2pStBvnAqjdV8aSltkf9tZx+ZCUshD4tQjSgXyXpVl8n4ISWSNzw53icVZHTNyELG5XI5zmbaWGQluusvXjR7AliWAvnnVukm0qPqLdyEJBVgflRnKEGdnTgMZnPNGdBUFm2SXXHSYFjF5aaSeRyDgUYz1ZdTTlyIGJJEktHzHwPRn4KmCiBxBuNo2WKOPcUGQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=renesas.com; dmarc=pass action=none header.from=renesas.com; dkim=pass header.d=renesas.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=renesas.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=V2dDgWZ1lwZDbtLxyn0VkYXLlSbrymhX7dubZAyFH5A=; b=WVEQIplqzTNJnavzH3zeLBi4R5JC8QLU8jw4LVuuTWCodtDein713qAw4bRB3ezgMi2aoQ80rUyYSdtE4g13ZTo56eF6+dNkh1LdcKpxss5Wu1TU8x9vsJ316zAWlF6FveycK4HBqsb7GUjzpIyE7etPfi+bKXQIYDzX/OkjDR4= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=renesas.com; Received: from OS3PR01MB8426.jpnprd01.prod.outlook.com (2603:1096:604:194::10) by TYWPR01MB11782.jpnprd01.prod.outlook.com (2603:1096:400:3fc::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.32; Wed, 7 Jun 2023 23:43:52 +0000 Received: from OS3PR01MB8426.jpnprd01.prod.outlook.com ([fe80::91e7:a94f:9f75:d840]) by OS3PR01MB8426.jpnprd01.prod.outlook.com ([fe80::91e7:a94f:9f75:d840%6]) with mapi id 15.20.6455.030; Wed, 7 Jun 2023 23:43:52 +0000 Message-ID: <873532hm8a.wl-kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto To: Jaroslav Kysela , Liam Girdwood , Mark Brown , Takashi Iwai Cc: alsa-devel@alsa-project.org Subject: [PATCH 1/4] ASoC: add new trigger ordering method User-Agent: Wanderlust/2.15.9 Emacs/27.1 Mule/6.0 In-Reply-To: <874jnihm8y.wl-kuninori.morimoto.gx@renesas.com> References: <874jnihm8y.wl-kuninori.morimoto.gx@renesas.com> Date: Wed, 7 Jun 2023 23:43:52 +0000 X-ClientProxiedBy: TYCP286CA0320.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:3b7::16) To OS3PR01MB8426.jpnprd01.prod.outlook.com (2603:1096:604:194::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: OS3PR01MB8426:EE_|TYWPR01MB11782:EE_ X-MS-Office365-Filtering-Correlation-Id: c4f6af5f-8082-4529-6f45-08db67b10cc0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: obfVjKcDzavgpVkdbjKapZSXtlUNg5/N6lvwmBomDGoEULrO0yYYHx/icv2l62qX44oBQq5MbuZ/MAOqqi+YjNY+JokFAzK5j3VBQIRS+7sgGtLNIrK2dVllSCBkgNZ0zVbGOrZHUtNjl8fVlv5EId7YiAXASlCbxwd0TNfgHVLOC7Mtw8FU7bnlb7BHaUFMweQUUW/1Yqxf0gRYcpm9/a35Iz4aoqc1uY3/clJeNXOJEFAgETj6LjBR2tcphgKQa6sWypbefKJ+tb+L59tdz107giY0kcEB85ZxvSg1ypl1N2QJXISaIrTsSn3iqLldYxJbZdzyJx8I2vgrQeY/EreBUjgBZrXA74/AIj6x+KFFaZb2FkU18EyW8BiyKm5SDSz+lgjDOp8zuMcahe8oiMEYinsb8M+56fDa7roTHpC7pSFW96727UI3rdqCsjBOGQLDTM3E5ZxznoNflOB6m75d7mke4MmmFHqw5+h6TGYjOQdOn7S6GJTzqmn7FW7t/S0lTQbLU675Cq56JaJA1NwDNel2jf0vjdXWKfg6niP4hr5Rd3lgHyRdWYjR/cdcMltqPL6Bg+M1sCz3ripJpFfigPrCJbTJGb/29hlW1P3x9rjkqt2gaSCNFh12NU8c X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:OS3PR01MB8426.jpnprd01.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(346002)(136003)(376002)(396003)(366004)(39860400002)(451199021)(8676002)(8936002)(4326008)(66556008)(66476007)(5660300002)(66946007)(316002)(41300700001)(110136005)(2906002)(478600001)(186003)(38100700002)(6512007)(26005)(6506007)(86362001)(38350700002)(52116002)(36756003)(6486002)(2616005)(83380400001);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: sOUQt0Wzlip1OW2HQwpFbUBGnQO6Y5PJA1joneLKtgu/SKP8ZCXLohhFSqqwjJ8IKyteerdnKZL4qhrdHF4wI1gPY9r0mBiogbabpRNK4qt3d93MZeX9TH7UGPzREcmaL69CA1xqEFX2xQbSYPXApWy4/pc21ZccXJVaKxvW8RhxGK7J941POUgFxp+rCnRlxJ4xPlWOhcLy/ILyOXu+wXQLHMSSB3nzWWep6kMDpHCLEqS00QyxSPhbEhJGiV/KPfXoIvLzPusWzNL8N5hFPs0CpR68m4nq3RedOFlA6l2cdwtpeap5ho9OpaykIwe/3W41RO24C3O3kXCw7L27w3ewP9tzYpGawTvQxTeo2e1+N4kQ+IKRzh7VhbjLXKdSf50TyfBxE20cpb4rYW5m4gZxBSlKEfukiS/xdyzFmaozrmCIDELslFBI9ZAvNSSl67mQ1+qTvJ7WUgaPDEoLdoRuN1JGNiTt9jbTZI3FK0VzOPKGeMfAxzMn/MXUuZAtsSxXJfuBWdyQYKGuTe6Ymb/a7p6D9UZV+O7nrzWBOP23yLwv6anWfiwGxzVJSTfLYht5G3hKLh+iUS5Bml2UH7Bi7PbPBevDDo7g+Y16VEnNurO12W8nrIigkUKglAZ4i+UHPMs674CRjdNgJyaLKbHTzTprKzMQtGEkw5fjXLsXlNKareGJeKR6g0XPPNICC1SGMpko/YbrSdnVKyBnAffDKWTufKnQLp+/y+3LVxUSW3RFKLkJwIedev9atMPwNolI3aucuGHpe9utoXrZ/YrZ+H/Dnqilb5/1AuOs5sKqtDN4LXB4ZciDIrkyAvuMbZ20l8KpONfNdN8nSbOi/380PZLnIs//4tENhgScWItxpi+q0rJIrQzvg6V84SSqcc5D1+WKwsgVBTA21XcSnAZFSNKQzGRXO89KCqGW5kGIi2PkwAU0tFzgQVznninw3GjtX1wI2V49pQlfTNYD8/vEYPfGJbSuQU78p/+YsqJLHoQpGaZ99CueeAwA++q4mza1g1lGb0iTNc15qYVxEBFGQGresGpyE9iGVonSG3mF2hZdt0gz8nBeUfAK+/hP91DrAp5iLBk0A1xyBpYEA9hKhj5ThdowVnv1u0ya3DjG1umVyP3LG9g4lQm/wy1kZCgkYQKozWqU+SgD5zDcfHta9Fjvd/vaQaNyuoHBcPZWOuNlwA+exF222GwBoAPEPwU04zv49Ce6M93MyxB/HW0OR9NVAOpCzPvXee+lwkgHtzYrqln2vOmxQ/o038w71wsmJ29VXALTgT59d31C+KvII2ru5sMnsNb7cpJtCOdc1mLTZMbOCwLK8Pv01lv7cpMwJBZ5YWC4SXgz7fNP8yOfOwaDflqtFPaC5IUlmsCTHhAzxnT8Gycy28n9obPXNElxG+II+UCGBA2qy1Vk7s9BBu2t3QPF9Jjcn0jjFgtwyWkIGfS2Vi3+voAa9KRIvSI5gTiNuOCEACPUxmMVdWD43o191ooUIs4JaLR2OOntiSrfq/SpoZQfOD9B9qyC5pDod+GTWDdo2TPXMMjvdNW10CxKOy3r7oRHd79xpuorlURRlKosbfbM613K/KIHR4JgbwBle5wprPuxvbA8v8/S2nVXByvwY8uLBV1y68s= X-OriginatorOrg: renesas.com X-MS-Exchange-CrossTenant-Network-Message-Id: c4f6af5f-8082-4529-6f45-08db67b10cc0 X-MS-Exchange-CrossTenant-AuthSource: OS3PR01MB8426.jpnprd01.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jun 2023 23:43:52.5532 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 53d82571-da19-47e4-9cb4-625a166a4a2a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gK6MiFwT3ypOnYm2B3kHdLWljV1HeN4dzbXgu681Nmprx295rg7UH++sd1d/vat/civjgbhAaEUQocdoQs7NuRJkvKNGUTOJuf7jbMn5RVbIh59vHDzgGRRQNZb9Fkno X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYWPR01MB11782 Message-ID-Hash: JA6G6QAZQARUTFBU2CWRPLF3QMK3TAUY X-Message-ID-Hash: JA6G6QAZQARUTFBU2CWRPLF3QMK3TAUY X-MailFrom: kuninori.morimoto.gx@renesas.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Current ASoC is assuming that trigger starting order is Link -> Component -> DAI as default, and its reverse order for stopping. But some Driver / Card want to reorder it for some reasons. We have such flags, but is unbalance like below. struct snd_soc_component_driver :: start_dma_last struct snd_soc_dai_link :: stop_dma_first We want to have more flexible, and more generic method. This patch adds new snd_soc_trigger_order for start/stop at component / DAI-link. Signed-off-by: Kuninori Morimoto --- include/sound/soc-component.h | 9 +++ include/sound/soc.h | 17 +++++ sound/soc/soc-pcm.c | 115 +++++++++++++++++++--------------- 3 files changed, 91 insertions(+), 50 deletions(-) diff --git a/include/sound/soc-component.h b/include/sound/soc-component.h index 0b47603c9db2..c7733382757b 100644 --- a/include/sound/soc-component.h +++ b/include/sound/soc-component.h @@ -158,6 +158,15 @@ struct snd_soc_component_driver { int probe_order; int remove_order; + /* + * soc_pcm_trigger() start/stop sequence. + * see also + * snd_soc_dai_link + * soc_pcm_trigger() + */ + enum snd_soc_trigger_order trigger_start; + enum snd_soc_trigger_order trigger_stop; + /* * signal if the module handling the component should not be removed * if a pcm is open. Setting this would prevent the module diff --git a/include/sound/soc.h b/include/sound/soc.h index 10e4ea0664af..49442583d46d 100644 --- a/include/sound/soc.h +++ b/include/sound/soc.h @@ -607,6 +607,14 @@ int snd_soc_get_strobe(struct snd_kcontrol *kcontrol, int snd_soc_put_strobe(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_value *ucontrol); +enum snd_soc_trigger_order { + /* start stop */ + SND_SOC_TRIGGER_ORDER_DEFAULT = 0, /* Link->Component->DAI DAI->Component->Link */ + SND_SOC_TRIGGER_ORDER_LDC, /* Link->DAI->Component Component->DAI->Link */ + + SND_SOC_TRIGGER_ORDER_MAX, +}; + /* SoC PCM stream information */ struct snd_soc_pcm_stream { const char *stream_name; @@ -707,6 +715,15 @@ struct snd_soc_dai_link { const struct snd_soc_ops *ops; const struct snd_soc_compr_ops *compr_ops; + /* + * soc_pcm_trigger() start/stop sequence. + * see also + * snd_soc_component_driver + * soc_pcm_trigger() + */ + enum snd_soc_trigger_order trigger_start; + enum snd_soc_trigger_order trigger_stop; + /* Mark this pcm with non atomic ops */ unsigned int nonatomic:1; diff --git a/sound/soc/soc-pcm.c b/sound/soc/soc-pcm.c index f16402ee5a19..08b3cbd1754e 100644 --- a/sound/soc/soc-pcm.c +++ b/sound/soc/soc-pcm.c @@ -1071,49 +1071,78 @@ static int soc_pcm_hw_params(struct snd_pcm_substream *substream, return ret; } +#define TRIGGER_MAX 3 +const static +int (*trigger[][TRIGGER_MAX])(struct snd_pcm_substream *substream, int cmd, int rollback) = { + [SND_SOC_TRIGGER_ORDER_DEFAULT] = { + snd_soc_link_trigger, + snd_soc_pcm_component_trigger, + snd_soc_pcm_dai_trigger, + }, + [SND_SOC_TRIGGER_ORDER_LDC] = { + snd_soc_link_trigger, + snd_soc_pcm_dai_trigger, + snd_soc_pcm_component_trigger, + }, +}; + static int soc_pcm_trigger(struct snd_pcm_substream *substream, int cmd) { struct snd_soc_pcm_runtime *rtd = asoc_substream_to_rtd(substream); struct snd_soc_component *component; - int ret = -EINVAL, _ret = 0, start_dma_last = 0, i; + int ret = 0, r = 0, i; int rollback = 0; + int start = 0, stop = 0; + /* + * select START/STOP sequence + */ + for_each_rtd_components(rtd, i, component) { + if (component->driver->trigger_start) + start = component->driver->trigger_start; + if (component->driver->trigger_stop) + stop = component->driver->trigger_stop; + } + if (rtd->dai_link->trigger_start) + start = rtd->dai_link->trigger_start; + if (rtd->dai_link->trigger_stop) + stop = rtd->dai_link->trigger_stop; + + if (start < 0 || start >= SND_SOC_TRIGGER_ORDER_MAX || + stop < 0 || stop >= SND_SOC_TRIGGER_ORDER_MAX) + return -EINVAL; + + /* REMOVE ME */ + for_each_rtd_components(rtd, i, component) { + if (component->driver->start_dma_last) { + start = SND_SOC_TRIGGER_ORDER_LDC; + break; + } + } + if (rtd->dai_link->stop_dma_first) + stop = SND_SOC_TRIGGER_ORDER_LDC; + + /* + * START + */ switch (cmd) { case SNDRV_PCM_TRIGGER_START: case SNDRV_PCM_TRIGGER_RESUME: case SNDRV_PCM_TRIGGER_PAUSE_RELEASE: - /* Do we need to start dma last? */ - for_each_rtd_components(rtd, i, component) { - if (component->driver->start_dma_last) { - start_dma_last = 1; + for (i = 0; i < TRIGGER_MAX; i++) { + r = trigger[start][i](substream, cmd, 0); + if (r < 0) break; - } - } - - ret = snd_soc_link_trigger(substream, cmd, 0); - if (ret < 0) - goto start_err; - - if (start_dma_last) { - ret = snd_soc_pcm_dai_trigger(substream, cmd, 0); - if (ret < 0) - goto start_err; - - ret = snd_soc_pcm_component_trigger(substream, cmd, 0); - } else { - ret = snd_soc_pcm_component_trigger(substream, cmd, 0); - if (ret < 0) - goto start_err; - - ret = snd_soc_pcm_dai_trigger(substream, cmd, 0); } -start_err: - if (ret < 0) - rollback = 1; } - if (rollback) { - _ret = ret; + /* + * Rollback if START failed + * find correspond STOP command + */ + if (r < 0) { + rollback = 1; + ret = r; switch (cmd) { case SNDRV_PCM_TRIGGER_START: cmd = SNDRV_PCM_TRIGGER_STOP; @@ -1127,34 +1156,20 @@ static int soc_pcm_trigger(struct snd_pcm_substream *substream, int cmd) } } + /* + * STOP + */ switch (cmd) { case SNDRV_PCM_TRIGGER_STOP: case SNDRV_PCM_TRIGGER_SUSPEND: case SNDRV_PCM_TRIGGER_PAUSE_PUSH: - if (rtd->dai_link->stop_dma_first) { - ret = snd_soc_pcm_component_trigger(substream, cmd, rollback); - if (ret < 0) - break; - - ret = snd_soc_pcm_dai_trigger(substream, cmd, rollback); - if (ret < 0) - break; - } else { - ret = snd_soc_pcm_dai_trigger(substream, cmd, rollback); - if (ret < 0) - break; - - ret = snd_soc_pcm_component_trigger(substream, cmd, rollback); - if (ret < 0) - break; + for (i = TRIGGER_MAX; i > 0; i--) { + r = trigger[stop][i - 1](substream, cmd, rollback); + if (r < 0) + ret = r; } - ret = snd_soc_link_trigger(substream, cmd, rollback); - break; } - if (_ret) - ret = _ret; - return ret; } From patchwork Wed Jun 7 23:44:00 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kuninori Morimoto X-Patchwork-Id: 13271456 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4E893C7EE25 for ; Wed, 7 Jun 2023 23:45:40 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 486A683E; Thu, 8 Jun 2023 01:44:48 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 486A683E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1686181538; bh=2gkP1bzT4xJ2rTf7JzXA1Y91a/JG2KiC91KqxD2wmD8=; h=From:To:Cc:Subject:In-Reply-To:References:Date:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=Yva+9Bm30rt1IYpuogMhLgLtwenUKyaja98ZAZMaj3C7BoyCn6YEtV6320qV+3IrV GteuViuOTZE7f83b5OQm9dP5apWf4plpLKS7kIjKM/RzRs7dCqlg8ZTwi79rRu4y3p YSI9UsiBcz3AboNlJ/x085AoO78t/n4H44UAvcOM= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 68A59F80549; Thu, 8 Jun 2023 01:44:13 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 1377AF80549; Thu, 8 Jun 2023 01:44:13 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 1A18DF80564; Thu, 8 Jun 2023 01:44:10 +0200 (CEST) Received: from JPN01-OS0-obe.outbound.protection.outlook.com (mail-os0jpn01on20726.outbound.protection.outlook.com [IPv6:2a01:111:f403:700c::726]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 937AEF80552 for ; Thu, 8 Jun 2023 01:44:03 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 937AEF80552 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=renesas.com header.i=@renesas.com header.a=rsa-sha256 header.s=selector1 header.b=VTiVaUth ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AKZKNccnyaHnKMiGj05Mhp99J2xcxY7Ud41q5Mia+/tVj00R8m2e+O+utsy8/7fWpul/Nf26StG9vtO6vOdkii03tX8GtCN9t+JT/RHt6FeqiQlWn+Gv5i4EwpDxbk7KKp9rvZtoiA/7nsKFKH2yDhCxZIlzmRI89ovIgrTptV9YYCBnSWYw/bRZBV0SWUcGuhrs2EqF/L70voso0Pz5jWLPzqnL4lgeLd4ykCi0QNWI1a/WMjkBQjr0q6Iub3BHIoAionqyMxSjEhz/Jy0xkU+YQPoK5D5fQsTEZ8YaTbFkqoqBLfxEK4cToHQS8Xae7ZQXBh0rxEkoo8ejvdHxBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uSMB4Ecq9DAlKwApwYjZ37teSY3Ze/sy8W3Y3UTaGBM=; b=mzP7TFkbUCf9cvcj/Jb6+l8IRjfROWPN0iN8NWqpUKHg/Q2zDcQGRs5ZS4OdIG6SJxIQVHFshzc9f5NtvyQxEBbKjlJHA3UJH+66RF8aEYBzimUOOqFNMNIl27dkE4/Ezn5Ny7yTtMwGXa3n+p2OJ3M8+byFI6mtwbmEKJeXfiQs6hLd6ORhXoBqBQ2/C5XjZNe+pLRhCWiM/vOYGAp2rQJuRp5QYTMOoVvSB7bZhue4hFfqpMGZKEqDaiEDAm9vJTCX8q1fTdS3FpaFkyJzHIzqd6ecjRg0li7BP4z24PPzncOlK0kRGGQbypopbtLTBKOFyM/1tFpaHb1LS2M+sw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=renesas.com; dmarc=pass action=none header.from=renesas.com; dkim=pass header.d=renesas.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=renesas.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uSMB4Ecq9DAlKwApwYjZ37teSY3Ze/sy8W3Y3UTaGBM=; b=VTiVaUthqpnPAxy3O5EZTuAeoJbfmQ2ahZjXqDt3DxixxNajES2WOtEJUek75P95GBHrEKHNVQsaS9UiaexcaGU2XuTiNtw4LcCJvyM8ub3zcp2XPTkk371XFN2hUGjdVSWfvxkVPHzyI2EUqLKOUT7xJDfaQv3uB2MuD4CppN0= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=renesas.com; Received: from OS3PR01MB8426.jpnprd01.prod.outlook.com (2603:1096:604:194::10) by TYWPR01MB11782.jpnprd01.prod.outlook.com (2603:1096:400:3fc::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.32; Wed, 7 Jun 2023 23:44:00 +0000 Received: from OS3PR01MB8426.jpnprd01.prod.outlook.com ([fe80::91e7:a94f:9f75:d840]) by OS3PR01MB8426.jpnprd01.prod.outlook.com ([fe80::91e7:a94f:9f75:d840%6]) with mapi id 15.20.6455.030; Wed, 7 Jun 2023 23:44:00 +0000 Message-ID: <871qimhm83.wl-kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto To: Jaroslav Kysela , Liam Girdwood , Mark Brown , Takashi Iwai , Vijendar Mukunda Cc: alsa-devel@alsa-project.org Subject: [PATCH 2/4] ASoC: amd: use use new trigger ordering method User-Agent: Wanderlust/2.15.9 Emacs/27.1 Mule/6.0 In-Reply-To: <874jnihm8y.wl-kuninori.morimoto.gx@renesas.com> References: <874jnihm8y.wl-kuninori.morimoto.gx@renesas.com> Date: Wed, 7 Jun 2023 23:44:00 +0000 X-ClientProxiedBy: TYCP286CA0324.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:3b7::12) To OS3PR01MB8426.jpnprd01.prod.outlook.com (2603:1096:604:194::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: OS3PR01MB8426:EE_|TYWPR01MB11782:EE_ X-MS-Office365-Filtering-Correlation-Id: 629b14e1-5580-4f41-3eaf-08db67b11180 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: fZ6gdCmmoSpZ3uxJxb14qfOhJWay6QcPqYBUSU/Eo6YpuweBfYJFmnB8mLqNcV9g9iF6Tg/i3UFB8Gd1I5yWZgZjUlOSqhuKKOR/M6mXb/9L3WG3GR8KGUVC3wrLUEhdCczuEUBLizsYP2w9pivr/TWUo3cdq3yBzPgxj+bsovySm7g36dBEqil/zvvsAix+Exvt39MZjj1PPEIWu1CepysFBAcT2R8liLVNOQYVzoT3oLxGDaT1u6qSP6VvqtwCpaMY/2zOzzsjoS3576pwFJEv3Yp6okrHDvoyRMq7ayZSjCGRcxEKcNspfUxmwqqh0IQAIj72ckKgE2YO5rqLxZYxuoqDZng1/5FinCczHb9/RTjcA490JX1S1Sn06jrzF2lOcRNx4/3KzIk9eGrRp717kSoHP2Pw7IfDMr3kQmYPQY/167xIcxOmShlOGXB9E9XA+x9y17LCNOZK6FzZFbzvd0z6H1k4fviAt0M46H3ec/AyjYTLg8CKxa6e3ghnog9wwHFYGZM47Jp4Z5odjSIGpBUvEQjlpUKHXZmlnz13dwW3MeLsR3zQBJKFmxWEOUoZRPWj/6/QKRVT0rInkicVcGIchQ958Y6OlWa55ARrI+2+i6/fTWTs6v67yVe1 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:OS3PR01MB8426.jpnprd01.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(346002)(136003)(376002)(396003)(366004)(39860400002)(451199021)(8676002)(8936002)(4326008)(66556008)(66476007)(5660300002)(66946007)(316002)(41300700001)(110136005)(2906002)(478600001)(186003)(38100700002)(6512007)(26005)(6506007)(86362001)(38350700002)(52116002)(36756003)(6486002)(2616005)(83380400001);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: KAOMfTy8PLFTHtWgSthd6ITDI3Wk4Yd3zZ5+/qxCf0o7ntvEMTDKJGHYnRryn5RiyJIDPmkSDsd5bORNtZZtwzeXYsSpOfD3cFof0HR0uVxSNxiOaPDUrNWABIPhfm7bXCaOgBYCzCtDVnaKyNIsqMXfIf5DvrOtCadxP1uCPukF1T5AO6GWsvney2pIgvFTy0/Le0hEp/zCb3NbszXR+KBH0+zhPzw8Go94+Qh4a73j/iAciFEkU2oWL1ZjSLLOeYa6fOL4PwVRsaH++srNrxV3pLoPTkp8PGOwbeV4ji2l8rIcedYKvIFIDB8wZx3EosBEen8V5qQE5POlDmV7Wwwa432WeXuVyK4R5FKStYUpTTtaXNbh7Bqqz+j9m/rf0WoalJxtbEfYJL33OkasKz/aw1d1BEmsTiRS37neLFinGPjMnby7HUp68vyMsv8p4FtnU1Nv7RA33Jn8f5+waPrh/lPhXDteTOhALkFs/FXsrdd2btYXH6y0V3onkSutvkSe2eNdaivf7o2Tz5Pb5j3QYSvATlADmkS1zSIeABhMNV58Qzq5CgXSMIhtz0xetUHnxEC24V+X6qMogTlKGPw+uPxHJMypporSUJ3f6We9Vfxf6keVvJjCd0JLLvAfdC5nNdFLPMtLycb1shS5TezcT6YQnx0HYN2l646MeIvhz5PK+lARJgsinXLy53epD8AUHSJT5ltkK5i1nUGM7ORuupacppvoI8O4rwKADqdmXiP+3Dighw7CXha/J1Hey5vf7c2ZffBp1tueQ8AhaBp3lnVltNbfYa36mOgXURp1WvSBIRbyv2kblTPdkJ2MyHVhKci+Ykn/nF/8o1/Qfuh9O/mac6Kx5xM/DdIvUWfggXLgslvndymQ4xUhMMfySXZjcKwwzAdqf8ipnWi6tKKVv6wHjT6cgjH0zXRwJtdUzxVEPSHkQbQ3dgWJgWxb7O4ybMImjhA+vtW5dPmkkuki7sIpyKWdS3TRNy8t7e92LWeASUntuelchIani5DYgnk9GnUwYjdG16D/lDs8S1dgUcFbkzERyboddiFZaPdd4hgk9B6xKKGeUQzomNaFnbXqePhwMQzPQoWcSMJM/Y2bMmf5yRBwJqJyn24aa0GlObo37wuIdG9nNtYN5ISfQbMh5sHQtizU1noOQA4qTluZJS94o4m7w4GrKkW4wQuxdglHW9Df2nIFGndUrflHO8vR/s1mZ75H1rxUqQcie49lhFyJ/CBf93/iHbeqm9+8F4pT3EsfR7v1FN+vZXjd1wx6gp6okEyzz0K1RtUhHMSwESzL6g9zg+lgC2p/utqx2RPxnYEonRhc+ZISLIy27pTagoe23CAQdjRG7EAVlOHdjfflw90dLSxB3P8crVgdx9BBxfWby7d5SP4NzEa2RZ9/wkxCLiOmzcJCC28urCROzDEniWntz+4EC+zX6eH6b+B8DhUhgMDhq80PS9qdyEv0L30X5FGbQLSHHITzOIHobjPNqq7NTne9KTZIndACL4e6eMLOfe4DCDdkhQZmpQFacRDil3HLsQVNm0y/ommbos9MKHAu67hx+uheIm+MWM2519Wjcg/+m2R1iyjJTmOfr3VZIul7EpxmRhHmYVXhTC3f6jTwu7mSBatUGks= X-OriginatorOrg: renesas.com X-MS-Exchange-CrossTenant-Network-Message-Id: 629b14e1-5580-4f41-3eaf-08db67b11180 X-MS-Exchange-CrossTenant-AuthSource: OS3PR01MB8426.jpnprd01.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jun 2023 23:44:00.4421 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 53d82571-da19-47e4-9cb4-625a166a4a2a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gxZS3gcvNcW4E7UK8G0RxErtxT2MWFX0vkCpd+2u7Q5gML6b/SX8PqVOdKkpVuMpKhxRzzf3Bdd++HQdoA/L/zR0a4eqT0+2nHSUYVradwR3zaWu8TEUKiK+WLHAo9mR X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYWPR01MB11782 Message-ID-Hash: YPAJACVCRUAII4CUKILQK3FWGONQ3Z3W X-Message-ID-Hash: YPAJACVCRUAII4CUKILQK3FWGONQ3Z3W X-MailFrom: kuninori.morimoto.gx@renesas.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: ASoC is now supporting generic trigger ordering method. This patch switch to use it. Signed-off-by: Kuninori Morimoto --- sound/soc/amd/acp-da7219-max98357a.c | 20 ++++++++++---------- sound/soc/amd/acp-es8336.c | 2 +- 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/sound/soc/amd/acp-da7219-max98357a.c b/sound/soc/amd/acp-da7219-max98357a.c index 375417bd7d6e..7464ca2b596c 100644 --- a/sound/soc/amd/acp-da7219-max98357a.c +++ b/sound/soc/amd/acp-da7219-max98357a.c @@ -524,7 +524,7 @@ static struct snd_soc_dai_link cz_dai_7219_98357[] = { | SND_SOC_DAIFMT_CBP_CFP, .init = cz_da7219_init, .dpcm_playback = 1, - .stop_dma_first = 1, + .trigger_stop = SND_SOC_TRIGGER_ORDER_LDC, .ops = &cz_da7219_play_ops, SND_SOC_DAILINK_REG(designware1, dlgs, platform), }, @@ -534,7 +534,7 @@ static struct snd_soc_dai_link cz_dai_7219_98357[] = { .dai_fmt = SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_NB_NF | SND_SOC_DAIFMT_CBP_CFP, .dpcm_capture = 1, - .stop_dma_first = 1, + .trigger_stop = SND_SOC_TRIGGER_ORDER_LDC, .ops = &cz_da7219_cap_ops, SND_SOC_DAILINK_REG(designware2, dlgs, platform), }, @@ -544,7 +544,7 @@ static struct snd_soc_dai_link cz_dai_7219_98357[] = { .dai_fmt = SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_NB_NF | SND_SOC_DAIFMT_CBP_CFP, .dpcm_playback = 1, - .stop_dma_first = 1, + .trigger_stop = SND_SOC_TRIGGER_ORDER_LDC, .ops = &cz_max_play_ops, SND_SOC_DAILINK_REG(designware3, mx, platform), }, @@ -555,7 +555,7 @@ static struct snd_soc_dai_link cz_dai_7219_98357[] = { .dai_fmt = SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_NB_NF | SND_SOC_DAIFMT_CBP_CFP, .dpcm_capture = 1, - .stop_dma_first = 1, + .trigger_stop = SND_SOC_TRIGGER_ORDER_LDC, .ops = &cz_dmic0_cap_ops, SND_SOC_DAILINK_REG(designware3, adau, platform), }, @@ -566,7 +566,7 @@ static struct snd_soc_dai_link cz_dai_7219_98357[] = { .dai_fmt = SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_NB_NF | SND_SOC_DAIFMT_CBP_CFP, .dpcm_capture = 1, - .stop_dma_first = 1, + .trigger_stop = SND_SOC_TRIGGER_ORDER_LDC, .ops = &cz_dmic1_cap_ops, SND_SOC_DAILINK_REG(designware2, adau, platform), }, @@ -580,7 +580,7 @@ static struct snd_soc_dai_link cz_dai_5682_98357[] = { | SND_SOC_DAIFMT_CBP_CFP, .init = cz_rt5682_init, .dpcm_playback = 1, - .stop_dma_first = 1, + .trigger_stop = SND_SOC_TRIGGER_ORDER_LDC, .ops = &cz_rt5682_play_ops, SND_SOC_DAILINK_REG(designware1, rt5682, platform), }, @@ -590,7 +590,7 @@ static struct snd_soc_dai_link cz_dai_5682_98357[] = { .dai_fmt = SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_NB_NF | SND_SOC_DAIFMT_CBP_CFP, .dpcm_capture = 1, - .stop_dma_first = 1, + .trigger_stop = SND_SOC_TRIGGER_ORDER_LDC, .ops = &cz_rt5682_cap_ops, SND_SOC_DAILINK_REG(designware2, rt5682, platform), }, @@ -600,7 +600,7 @@ static struct snd_soc_dai_link cz_dai_5682_98357[] = { .dai_fmt = SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_NB_NF | SND_SOC_DAIFMT_CBP_CFP, .dpcm_playback = 1, - .stop_dma_first = 1, + .trigger_stop = SND_SOC_TRIGGER_ORDER_LDC, .ops = &cz_rt5682_max_play_ops, SND_SOC_DAILINK_REG(designware3, mx, platform), }, @@ -611,7 +611,7 @@ static struct snd_soc_dai_link cz_dai_5682_98357[] = { .dai_fmt = SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_NB_NF | SND_SOC_DAIFMT_CBP_CFP, .dpcm_capture = 1, - .stop_dma_first = 1, + .trigger_stop = SND_SOC_TRIGGER_ORDER_LDC, .ops = &cz_rt5682_dmic0_cap_ops, SND_SOC_DAILINK_REG(designware3, adau, platform), }, @@ -622,7 +622,7 @@ static struct snd_soc_dai_link cz_dai_5682_98357[] = { .dai_fmt = SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_NB_NF | SND_SOC_DAIFMT_CBP_CFP, .dpcm_capture = 1, - .stop_dma_first = 1, + .trigger_stop = SND_SOC_TRIGGER_ORDER_LDC, .ops = &cz_rt5682_dmic1_cap_ops, SND_SOC_DAILINK_REG(designware2, adau, platform), }, diff --git a/sound/soc/amd/acp-es8336.c b/sound/soc/amd/acp-es8336.c index 89499542c803..5e56d3a53be7 100644 --- a/sound/soc/amd/acp-es8336.c +++ b/sound/soc/amd/acp-es8336.c @@ -149,7 +149,7 @@ static struct snd_soc_dai_link st_dai_es8336[] = { .stream_name = "ES8336 HiFi Play", .dai_fmt = SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_NB_NF | SND_SOC_DAIFMT_CBP_CFP, - .stop_dma_first = 1, + .trigger_stop = SND_SOC_TRIGGER_ORDER_LDC, .dpcm_capture = 1, .dpcm_playback = 1, .init = st_es8336_init, From patchwork Wed Jun 7 23:44:09 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kuninori Morimoto X-Patchwork-Id: 13271457 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 045C6C77B7A for ; Wed, 7 Jun 2023 23:46:01 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id D8CA584A; Thu, 8 Jun 2023 01:45:09 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz D8CA584A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1686181559; bh=JedLMgsuGpKvPbjClm2qG1ONH+8KFgsXrg1AGmJDWRY=; h=From:To:Cc:Subject:In-Reply-To:References:Date:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=aEKXxdZrZc91NAbACaxBX+cnYVOdztelYre8szbkVvlfkTGAmo9FBY3joyMRrl5eA bDAd6qg4aW7wS46CEsgalN2FpvsPeLqrSIZqaFwrUqVD/qCxLTWliiWEeiAlVG131C TLoVBNMRkrvaj6xVLuM/KcObOrJ3WlB32xayCKpM= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 175ABF805A0; Thu, 8 Jun 2023 01:44:16 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 77A46F8057A; Thu, 8 Jun 2023 01:44:16 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id E9D1FF80563; Thu, 8 Jun 2023 01:44:10 +0200 (CEST) Received: from JPN01-OS0-obe.outbound.protection.outlook.com (mail-os0jpn01on20726.outbound.protection.outlook.com [IPv6:2a01:111:f403:700c::726]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id C5E14F80549 for ; Thu, 8 Jun 2023 01:44:08 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz C5E14F80549 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=renesas.com header.i=@renesas.com header.a=rsa-sha256 header.s=selector1 header.b=BlgW4oM8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=N9wfHH17RqMJ8RsnbbYnf6EBJ42noolEYqhQtlh0LiyQ0ILlSUiz7d/DmMbHfvQ4QF14i/lADBIlZxZK74TIJYh6PBpna1T1vGw6qu8qpm+UZs3I9+FjJW6vghn2TQ/N4TtgW5LHlF15idesFHVfXAlFrZMOisWgwDdfmKkFIsq7U1Q/HA0vNuUs4+Kn9JJiv/colLmfu2MBPlDXfdCfaoNClpLCbZygxzmYlJSMu9GqrNnW8uwepWIPO+jvKgf3jTKjYIPYb+UFUjhXfbzcC6ZBechvhyklm7SI5kbG30iYaQX1NoqJYlX3epoF+skkEiPZNUEH2u3D+eMhFgCyrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2fLC9GCw6jiHc6GwdV2jQ+7O1ASraTYwwsIlAvCeFTA=; b=T3nmN0OcfvL3waTVb+HvRtLWaAeVcc2cMmqcbCEgeMCQvmYjFHwZP/PtNdNuwk/hBo5eTSIVeWf0uZazbWgcjWDwdYThtO4wkZhhWdP3JPJTCzQ8Nt25EsiqIvxyRx4T/Qm6BqRk+z/ELi9jzaZCzOkkuZPsbTukAq4YATSN/U5cFomDSzyhh/Cd5Z/wHu0UMxjWyYBEo9/zZQnUZ8Qg4CcC7yfQov+gI7sJPykOPm9X92HBbAGBY5SXF1jxXPy+8rLVnbEtrqAMOcuc5THUTQvf3IL6QdFZkTKQFCLaaj+22GX+y3/3TsliiX3bq3mw/yFc5brm51+tGQC1OsgUgg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=renesas.com; dmarc=pass action=none header.from=renesas.com; dkim=pass header.d=renesas.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=renesas.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2fLC9GCw6jiHc6GwdV2jQ+7O1ASraTYwwsIlAvCeFTA=; b=BlgW4oM8sZdCShPzEr2VyBlMvvjqEuG1t32m4YuFElQqPbdAcgleYLV4cMiVZUbnCotUy/W7RPC7W3AJJuuAPp9QRd6SiudthyPfcT9enrDitoxkCqkyDw8E0cG5ghywPD8ijUKb01uOsXTXJy4UYc3PndemS3I8C87hSIwHOio= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=renesas.com; Received: from OS3PR01MB8426.jpnprd01.prod.outlook.com (2603:1096:604:194::10) by TYWPR01MB11782.jpnprd01.prod.outlook.com (2603:1096:400:3fc::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.32; Wed, 7 Jun 2023 23:44:09 +0000 Received: from OS3PR01MB8426.jpnprd01.prod.outlook.com ([fe80::91e7:a94f:9f75:d840]) by OS3PR01MB8426.jpnprd01.prod.outlook.com ([fe80::91e7:a94f:9f75:d840%6]) with mapi id 15.20.6455.030; Wed, 7 Jun 2023 23:44:09 +0000 Message-ID: <87zg5ag7ne.wl-kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto To: Alexandre Belloni , Claudiu Beznea , Jaroslav Kysela , Liam Girdwood , Mark Brown , Nicolas Ferre , Takashi Iwai Cc: alsa-devel@alsa-project.org Subject: [PATCH 3/4] ASoC: atmel: use use new trigger ordering method User-Agent: Wanderlust/2.15.9 Emacs/27.1 Mule/6.0 In-Reply-To: <874jnihm8y.wl-kuninori.morimoto.gx@renesas.com> References: <874jnihm8y.wl-kuninori.morimoto.gx@renesas.com> Date: Wed, 7 Jun 2023 23:44:09 +0000 X-ClientProxiedBy: TY2PR02CA0030.apcprd02.prod.outlook.com (2603:1096:404:a6::18) To OS3PR01MB8426.jpnprd01.prod.outlook.com (2603:1096:604:194::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: OS3PR01MB8426:EE_|TYWPR01MB11782:EE_ X-MS-Office365-Filtering-Correlation-Id: 9b88aa5f-9c82-4a9d-2b90-08db67b116c3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: w1Ezsy3BhjPT0boqI+W5FSsWBdRklv63B+zDeUDeS+KfIz/OcNk/87J5CmjaCdw4IQukrDcvb/hJ5ghX6Gow3Qe0KdOfcl+bye++M+X4ciLTJV74m/y1VAswFfOQfjSYycV3blEHVZPKDucRk3ywxde+6ioJ7c9bwIaF+/kyCMvNZ+K/e/NPBfwtAaCYY8nEQ2hVzAMCoEXjlgRoXyEZ6zRU7V7qZAIi4nlOo6s4H8nKoBf3WXKQh59wqDkxdqa1NNZlC3QoSATfVsS2sTG3Wdsc2wg7DDJwkfnaYa024Ico0HhVuVZ8dspgUVYa2nIzAebtAZYZdE5R1FtUvYae0EFHQAfSIJ5KdV+QJg0p3FE3UDt1p//28MK5vGTUiK1IRBkzdmLD+b96pJg6JKKru46AKOD1Y6o6CDvJ2IQYPzKSwxxAVqWP5WbOg90Fjoro/a6qOAyAvAJkc9fQ1eBXwoDttnAGQ3YBRONURZIikvcWK0QAKYolVrxoxMrzbV01Q0cAGSJyM0eDgI6MPl540tuuXmEDrgyGBVZkw+s0AWAfd683yN3l50bIIwmc4sjXsCvCxNTWDJrGGvjAHmmSCX/66JmpYmqdaxS4Y3p4gsQPY8vDBQCMllIhN9b6mQpl X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:OS3PR01MB8426.jpnprd01.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(346002)(136003)(376002)(396003)(366004)(39860400002)(451199021)(8676002)(8936002)(4326008)(66556008)(66476007)(5660300002)(66946007)(316002)(41300700001)(110136005)(2906002)(478600001)(4744005)(186003)(38100700002)(6512007)(26005)(6506007)(86362001)(38350700002)(52116002)(36756003)(6486002)(2616005)(83380400001);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: dcfF0ZeeQmje0F1zt4Wjex/Wmki0TAlRYP9Nq8GQjy8fevE6WbODCQ82eFVJVpn2DN2JVsuc2ju+3FhTTfZfj71GKR6mh4lksf20qXVQ6KTK7kjNXDMERVLgwGhpO4SEgNsvr00um+wel9KwLTI953UCs1Zajo322fHotaJUQ0dNnX+xMZ6rrROUHjrfqj0ryV0HXrGHe7Koubclw6f/KFMSBMXejBYrTcb6oNvFyapK/+nu5ojVBGc8NdCDebW/HVoGVMob5KzECKlyNKy4MRfYiOHaidtjiUYRvEk+KCdTOfwzSE0RZ8b2AgPjaUVvavDAszhOXTKbCmHhonnRyhuD6em2tGBOJmugCYCpjBCRX4S1XZXhcueIIytSKm6lrUdFGX8qnkDaoNjCiZquK4jy/P9GcIj0oHq+FOFTBwDTHpUJ4ChIVjJHh83VQ1o5cydAedU+3l6VpkHo9Iy0COjLSLtdfIPs/+zSzGIYmK8y7PBNk8YsA43JGWVg0m3mVhKTAlqxZCZtQpywqB/cQ53OeZ0v4tmq8+OPTwI0kl8UcnkCVOvMPXkNU5Vo00o+1v8n+1BC5Qxj4E8GuW+4cUzvmsPUtSIMwe/0tU4gtoefrLxF1fBGt9ptgQ/F+iW/qduOIE6shh06Q4orw67HFKJC1VZ5X6IGmpDq7Va15PkeRV8CGPpOdYHUP0HPtcQ9xZlFnDmBAP1Jz9FhdcVOARo/N61ooIxmMai4BJxvTDhGizFyoiqC7nBFaHUe3A9Tzivqwn23qz6z3azdc2dFLkiTrLRTqUKdV8jhb4HMe7q8u4owy0nQf29b8ik5TmS/ku+2kzxpdmgNES7XGlz2wpdMPbN2VNCxg+qnrofQr1K6EmDTG8ciEE59JPlGVkJjBJ+9/WvBG8dT2NMXYwS7mgpQnF/4SBzqd3M4Eh1jHnkebpwb2HAK18sPL6Ud05N/wPee/jmT/ApvoP4PdPZ/A+jzcFZUugohgiRpoXfpHP4R2FU4iQLZaSpf6gxhxK7yuv4q+TNBmGRmDb/xe5r4njjHrXLeQiMQxb39eiDyc+fn8qtT+RXCZ2RbQmfKDFtXJb6Ogw7m01xSReaIQl7TFSA5Fq78Eo2h3bSSUMNHPb2CYh55E/pWdMHGAIZOOaPqT5TVRuCDD3Pp58eHH0hhkngUqgoZ31MiMGw23Q/GrRbdKZ+alUc4YKQ7Y4twn6TbJ/8GG9lAbHJFaJnNu0+G9ppX6pQOeIAT4f4w76SXBy7srt9HvRT6HsUOBCFpVqpZRwOJa62EKxvHUYzRFe1vWSo2dpZLuJ9pAB87jh0DHELmv3Z9es3+LAeOFiS/q9Vi2Qt8yTWvSDYU4Lg4hRWQtk9X8wy/S9pabM4tK5SeyqTZrCa33I04Hso9R1yUESN3DBGcjAYIUfHRB9jCIJwAYGGCo1hg60rk8qNaO8H5xqxKRc0COo9GXpaHLoymYIR4ozIeVkLQh9rekyIdIm4od7A9zmT1XtKeBQXmmwXHswA8xg5DLmh9mAKBtkcuvX7wtKUFkoLj00kBHjEhs753ZlIYet7gCB3fjtDVJKFryaowEselAAaHZDCmxOlCKAIXE+BJVHQ3c1L+fqD8C+boh932yXOFpvIizeTb1aCK70A= X-OriginatorOrg: renesas.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9b88aa5f-9c82-4a9d-2b90-08db67b116c3 X-MS-Exchange-CrossTenant-AuthSource: OS3PR01MB8426.jpnprd01.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jun 2023 23:44:09.2634 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 53d82571-da19-47e4-9cb4-625a166a4a2a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: UTVECfE4RrRMVCg3fBvNs0/hEKiX2hkPJdlv2VmgCjtnmfOz2VMsQHciqW583YvAIPL9Ed1/c6tYk+XbsCy1Ncv0MYd7S3fsZHCxQ6HqWuJIwqx2H8XcJo5FM2JKMu96 X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYWPR01MB11782 Message-ID-Hash: U65GBMSUUJLO3CJJBN2V4SPK6HSXS7XQ X-Message-ID-Hash: U65GBMSUUJLO3CJJBN2V4SPK6HSXS7XQ X-MailFrom: kuninori.morimoto.gx@renesas.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: ASoC is now supporting generic trigger ordering method. This patch switch to use it. Signed-off-by: Kuninori Morimoto --- sound/soc/atmel/mchp-pdmc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/atmel/mchp-pdmc.c b/sound/soc/atmel/mchp-pdmc.c index da23855a0e40..c79c73e6791e 100644 --- a/sound/soc/atmel/mchp-pdmc.c +++ b/sound/soc/atmel/mchp-pdmc.c @@ -423,7 +423,7 @@ static const struct snd_soc_component_driver mchp_pdmc_dai_component = { .open = &mchp_pdmc_open, .close = &mchp_pdmc_close, .legacy_dai_naming = 1, - .start_dma_last = 1, + .trigger_start = SND_SOC_TRIGGER_ORDER_LDC, }; static const unsigned int mchp_pdmc_1mic[] = {1}; From patchwork Wed Jun 7 23:44:15 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kuninori Morimoto X-Patchwork-Id: 13271458 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 41015C7EE23 for ; Wed, 7 Jun 2023 23:46:27 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 33C3784D; Thu, 8 Jun 2023 01:45:35 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 33C3784D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1686181585; bh=IOidb0KOJw2PZdJPCPxY3EIQgxosKqGOKSt+bmuTIcA=; h=From:To:Cc:Subject:In-Reply-To:References:Date:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=VadsSWIMsha/1Uxc6Qedblt876rfQRFjMPdXgsV1WdIb6x13HWByFvII/XjI1WUMh 3CKZvwk75mMOJ77TCImaiaTByMvlEyCZMBzXyO5o6BDRRNgIINDhAt76BBCJ7Zy9nl 3vTAoTB3v+QGPLjUZ+BVkZnvi92y5TU+Hog0UNa4= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 0532CF805A9; Thu, 8 Jun 2023 01:44:26 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 59A04F805A8; Thu, 8 Jun 2023 01:44:26 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id AE57AF805A8; Thu, 8 Jun 2023 01:44:23 +0200 (CEST) Received: from JPN01-TYC-obe.outbound.protection.outlook.com (mail-tycjpn01on20726.outbound.protection.outlook.com [IPv6:2a01:111:f403:7010::726]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id B22ACF80587 for ; Thu, 8 Jun 2023 01:44:18 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz B22ACF80587 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=renesas.com header.i=@renesas.com header.a=rsa-sha256 header.s=selector1 header.b=DLoiZ3Lj ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DeU2hHI0puQnB7aMaHsmjGDqtZmQdp/Wo0b6IOgKaQmCEYZB9QFuYg0UPGhZPZHqfssbR6MR3p0wlqZL4L41gI2jD4H34f4BcGKq4KvtzPmdJfykN8s8T8wLu7nO2VKKuW+9gVkmCHcTHayAcG/H/rl3hSrgQBEgkyCwuPoGVkOxHiAxgbIb3J2tc0GrG15Wd13ALEq7vWtZB52IzpBvWOZ/lqEVV8xcQG3ipKLEmM8rVcTNe6sSPBJjTdgkdwJZa155b/O9hePxif/6G6ii0zs/OCNeURSvIyFTgq3ApgWYaK1gPNLow+PeddUQL9FJgQugoJkY1vQ7kE4REabjIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+tPEznnJM588OZuXM6JHjE2cAcDpZbIwvSmG4ObtO6I=; b=L588GmPW+klUXwWPRNVsaxDukjs2mcdZwKakeYyIPzKTh3ta4zUzzjYqe2h0J91Caw42eXGCM1rPA07rcfNzbD8/CScoPSEgS2St7LZGBQzeTWMQoxm2u2FZjzFz+D/4O+X0BORInl8XTARW7lR+fs2fjjJ4u3b3dNvI3Ju5wuH+FSWSOWjZdA0jjiDsAtnIyILzM2oDWM1nKjgVMpYriPYWYd7rryMM00FiT/6fPU6Mr5CpWCerTIE3h3QjtTOvte8V/gTiKTbwt7YP4jbvY64SeslryL7npD91p0YSzI42sACYjYh5rFb+VXst1AA7IIxnslAG1gZKKVYWdDEqjw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=renesas.com; dmarc=pass action=none header.from=renesas.com; dkim=pass header.d=renesas.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=renesas.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+tPEznnJM588OZuXM6JHjE2cAcDpZbIwvSmG4ObtO6I=; b=DLoiZ3LjUpgVnfv+z3zWHwE7/t860Bs98y4pwltrmZ6pASMIYXRykOBQrjuQCl/6inWsbputmsXnD3+vV0HpoVKff0QlYclM6UBPcgxzi7HRywgPn73hhoUigWWldOPABLKshbEdPXop3/TnIiO4p1YaMtYzVAD1oexB4TkEhZw= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=renesas.com; Received: from OS3PR01MB8426.jpnprd01.prod.outlook.com (2603:1096:604:194::10) by TY3PR01MB9745.jpnprd01.prod.outlook.com (2603:1096:400:22e::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6477.19; Wed, 7 Jun 2023 23:44:15 +0000 Received: from OS3PR01MB8426.jpnprd01.prod.outlook.com ([fe80::91e7:a94f:9f75:d840]) by OS3PR01MB8426.jpnprd01.prod.outlook.com ([fe80::91e7:a94f:9f75:d840%6]) with mapi id 15.20.6455.030; Wed, 7 Jun 2023 23:44:15 +0000 Message-ID: <87y1kug7n7.wl-kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto To: Jaroslav Kysela , Liam Girdwood , Mark Brown , Takashi Iwai Cc: alsa-devel@alsa-project.org Subject: [PATCH 4/4] ASoC: remove old trigger ordering method User-Agent: Wanderlust/2.15.9 Emacs/27.1 Mule/6.0 In-Reply-To: <874jnihm8y.wl-kuninori.morimoto.gx@renesas.com> References: <874jnihm8y.wl-kuninori.morimoto.gx@renesas.com> Date: Wed, 7 Jun 2023 23:44:15 +0000 X-ClientProxiedBy: TYWPR01CA0039.jpnprd01.prod.outlook.com (2603:1096:400:17f::14) To OS3PR01MB8426.jpnprd01.prod.outlook.com (2603:1096:604:194::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: OS3PR01MB8426:EE_|TY3PR01MB9745:EE_ X-MS-Office365-Filtering-Correlation-Id: 8dc20695-1022-4b64-b9e8-08db67b11aba X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: A+enixtbs2xNFFKFhqrd0MxdpQZdGFx0e2wi79q2Z+4qRBn7mksFxmy7grY94UiR3oLqQxtielOUHFsaRG4tR4VWt1IaOU86/UcQogs/UEgYy5uWKdjV03yixopLuMIHgi46Cj6v6EQPOqSNWIEfdABcVnJp2Gl3aQ6080+kLrcjz+dLQpbtlX+DiK4dlAUcyOZ/MD2Ksc/VDTODX4OpHZX3hiWJ+pCnlXBZ4A+afBNGhtzEOi1KcC9yFdgreK77Yv6PNNzEE8lvO9FxtSSt9Snucs4W99ctnrySZThXsQ/CXO2dOkawuOs8ol082uHQwi7PhwZUsjoLnJVZaf9RtV0R7PsSBYkm5OAxJz1vWJlcswKjzmmCfH4Rz1cwKy284H1vT0EGG0TNHLzILXBllv1VmvZoK6VOk3X+GgVJ12n8UhopGU1oUz7n7NfhbgmGUFmf3TZqhf/Wbh0n7PPBH8YO0h/nMVHg/xIejaAkEZSMylRYUPpkbajvstS5ff+tidaBuOV3h7cHBiVG7RymcnHppU1f/igAzEcvNPiIZSUNxolpjf2M2Xj9buIV07jF9LDMEWImmTdv3Qd/rzT74UqsXTNxqXxrat+v7sItnwbe4X4qOzBLETaRJCNLj7Em X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:OS3PR01MB8426.jpnprd01.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(376002)(346002)(39860400002)(396003)(136003)(366004)(451199021)(186003)(5660300002)(26005)(6506007)(110136005)(6512007)(2906002)(52116002)(86362001)(6486002)(478600001)(36756003)(38350700002)(38100700002)(66556008)(4326008)(316002)(2616005)(66946007)(8676002)(66476007)(8936002)(41300700001)(83380400001);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 1jQXZcynY6h2Q7EclqJOd1cA1DoQ1yNyRcNM+MLm0ZJNVg/nO+h+kbpk1xEBZhsJkBPWpymLvK/Gt1JHkYLA7STa9YmfqF4bLbt8Ve7XaO8Ca4ZUxGPvVl4CkEjgL7x5IQx4XPL8jZ1D+STu3jk5oBJ4iJnFylDiayt28KozheDBpEfa0VP5t8bAo1OLfmFrCens25jkORqdwJAPOuCq9xN3Wd+pzxsi0k0Zo7AvseWGj2SzqFdpwPUCg1ya/oa9gEjo4zHqoSz1nfX7y3tpwbVHJSN5dWWODidopUKhq65q950Li+aAm52iwXc5G/iVa0ASWNXFzSI9h4Tqtic38d9ePq0L9YMmsBoT3LkGAG7FoK9g9FlW0bOI3hcW3/k8JC4+RnRFxuyhqs7r1SGATBebdkNpMH39Iekg4KhCVAJ0BMYcl31O7csS2PFnhXKGimmBn3nfvUg9MWnsZKoexJFDjFe6RtLyrL+KcjdsipaayrlCsvSVwktVjbVPtW8OjTk48Ye/sXAx/feEUu1l2etpkmSa0DO6BM2RZA+SLDmFF8nkbUVWQZ3EcQWl/CC0o5g8TlJi+WUdTTQRp4lqjwpBWGiexzHreItj1ncpYNMeMH8irtcXqxFC71kN3j+/cdfEXJXYb36EEtWL4NqWEOhat6oCe2kRHqR3OHXjmtjoWtP3VVW8h5cchlgcN5RTEVjsllAvu6sqsqU7hAqOyS3WrglIgnsoWPZqxtsmkJHG1CAF9wt81+WdkbAZpHtKFBnLpMSnDsiUfyeRFiNDSET7A8SrgliREg4V8wY7Pji7bpqWuYyq8OFCtSG/rMFBJkWBCzc+wNovcshk4VZQ2HjOyrWng4DtkFGnrd0jmAP8Zej1R9POxKy4IX+YUuTd7YrChUnwnKewINuoBCyMKRN2WujxkKqlbovl+RWIp0H80bFf6sUkUYP0JVzkt9jmvLRdVZ3e3PKhmfNQBh4pg7xiIS3JjvmSb/xt2O/bf2Krizmnf4fpJkbS5NFnDz4rizsLIthXqGfSktJQ8AmHS/cU9vxzVZ9I8k83wh4aRMudOdfK3c5K79PDt39c0rHuTH1UIK4ct/Z11MFv4IwYIHMtS8LsNZMD1ujbilbWqQkv++HnTFoQAzuszLpLWi7XfDCmohnb4MDA9P91XrnScrA+xiZNv+BJnfn1FLGHhQBfX0LxVJetAwPuZ2OdMo0Oact3Hp8WxH0c9NO69/7WjfETpW8fpMCXxrDX2swoaBKwoogD4wwFWaGN1+ld0mw+GgBHBdXxXDqkLJAlDvIaI+xHKJw0nR4JFbejgZ7yXP8MrUO51U7f7hFppSo+Xj5KeVrgoXp08TGehbHfgIYfvk749DWc0xYTKUPNMRlRF2f1+6nSAkr/sqVCDIKDejiv1UvKLAysMuITYn5lAUZzxlbtFEIArObLQj2JHbQmCqX2wFtQ4GN5KRpjlFHDDfEwZa1E50rn5wWmx9w+HOPFIAMp24uoCDn+F3rRUrg7Reow1fBHKhVOqJgX6YciMKUDoQxw19YLPNePDeL2vCpl9wpSyrj1spVOorVLBsroQVGbKEaSZ3s2JUHUTNLVlh/GhYXgXOLwRwqzZlfpGcXphc2k4/B7LnrWtypvpty65g8= X-OriginatorOrg: renesas.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8dc20695-1022-4b64-b9e8-08db67b11aba X-MS-Exchange-CrossTenant-AuthSource: OS3PR01MB8426.jpnprd01.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jun 2023 23:44:15.9209 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 53d82571-da19-47e4-9cb4-625a166a4a2a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hmxLt5mtVaw9D8QH9nyUVmi0bBzEE8jRDHcxIkgvJGGGJ0mAlFyqgR5k9q6F+rDPLA8k6d4FQzkzv3f604S6Nj5JSaGvXadRwPRG4G4gnf7YbEvQcLXHEDMVp5LRhjym X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY3PR01MB9745 Message-ID-Hash: 47URZCTIO4XC5AL3RG26PXFTGZCHK7AE X-Message-ID-Hash: 47URZCTIO4XC5AL3RG26PXFTGZCHK7AE X-MailFrom: kuninori.morimoto.gx@renesas.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: All drivers switch to use generic trigger ordering method. Let's remove old method. Signed-off-by: Kuninori Morimoto --- include/sound/soc-component.h | 2 -- include/sound/soc.h | 6 ------ sound/soc/soc-pcm.c | 10 ---------- 3 files changed, 18 deletions(-) diff --git a/include/sound/soc-component.h b/include/sound/soc-component.h index c7733382757b..87f248a06271 100644 --- a/include/sound/soc-component.h +++ b/include/sound/soc-component.h @@ -199,8 +199,6 @@ struct snd_soc_component_driver { bool use_dai_pcm_id; /* use DAI link PCM ID as PCM device number */ int be_pcm_base; /* base device ID for all BE PCMs */ - unsigned int start_dma_last; - #ifdef CONFIG_DEBUG_FS const char *debugfs_prefix; #endif diff --git a/include/sound/soc.h b/include/sound/soc.h index 49442583d46d..52bb64d427f5 100644 --- a/include/sound/soc.h +++ b/include/sound/soc.h @@ -762,12 +762,6 @@ struct snd_soc_dai_link { /* Do not create a PCM for this DAI link (Backend link) */ unsigned int ignore:1; - /* This flag will reorder stop sequence. By enabling this flag - * DMA controller stop sequence will be invoked first followed by - * CPU DAI driver stop sequence - */ - unsigned int stop_dma_first:1; - #ifdef CONFIG_SND_SOC_TOPOLOGY struct snd_soc_dobj dobj; /* For topology */ #endif diff --git a/sound/soc/soc-pcm.c b/sound/soc/soc-pcm.c index 08b3cbd1754e..574aa094c990 100644 --- a/sound/soc/soc-pcm.c +++ b/sound/soc/soc-pcm.c @@ -1112,16 +1112,6 @@ static int soc_pcm_trigger(struct snd_pcm_substream *substream, int cmd) stop < 0 || stop >= SND_SOC_TRIGGER_ORDER_MAX) return -EINVAL; - /* REMOVE ME */ - for_each_rtd_components(rtd, i, component) { - if (component->driver->start_dma_last) { - start = SND_SOC_TRIGGER_ORDER_LDC; - break; - } - } - if (rtd->dai_link->stop_dma_first) - stop = SND_SOC_TRIGGER_ORDER_LDC; - /* * START */