From patchwork Fri Jun 9 18:32:52 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Rob Herring (Arm)" X-Patchwork-Id: 13274296 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 061B4C7EE25 for ; Fri, 9 Jun 2023 18:33:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=TLYXAspMeCoAMBx8/+YDwMUZhqhGoWopvGU41CBXof8=; b=W1H9MzaeSEJAdy ChpvyPr1bJoTpABPDBdT0ocVUEK9swnfk1zwnfhlSoUT8DMkcCjfBs+Tvurvuu4/GNlc6V0AbjI0R IDcHbR0oH2rITntgDAfrVxuYX8GOrGpfvxVg1JkgSBINbLPuLMM8/37YIS88qH0GqIX3J5XCe5FjC vRFTWD6QPqVOKIdPtO8rpQAJ8GLKy8lGiZOvBKr0i2GM23kDjBZdp/1B1HfONa96fv/5VDQKtXwjk UpPBEv5ESRciQBb4OyGrVdgImKyQXBFeKt0ouQfeOp3NP/s8ZukhPp5ahPFbUQ/I86J61YLdV7sp9 MaJHB7TqdHwV3xVva70g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q7gv2-00Drsy-1U; Fri, 09 Jun 2023 18:33:04 +0000 Received: from mail-il1-f181.google.com ([209.85.166.181]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q7gv0-00DrsV-0o for linux-arm-kernel@lists.infradead.org; Fri, 09 Jun 2023 18:33:03 +0000 Received: by mail-il1-f181.google.com with SMTP id e9e14a558f8ab-33d0b7114a9so8871675ab.2 for ; Fri, 09 Jun 2023 11:33:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686335581; x=1688927581; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=AGqPwyg/tCD/J3bWMKGMkc2zAlUcbkmqtQu/P2N7szY=; b=fqvu6GXMILW2t/8oCLMPQBic0iXbYmk9E7SFYaC806SHH0B1GgUr8cJqX0V6Ka3edj oDZSl92knRP11ukOPltuakR2SFTZ845xgCQKAY66XEgxgKVh9Ls+jUp4maaRECEypSJC mkWhUPOIaFDNA+qcofZg7vTa8voVCxhxBtChuI7V4CbjZCp59sjIZetYY8LYO+eTX7Sk CUFehN3QTOpk327r80MqLUUf9LskudyWCgeuLlQZtlUGRprQmdsEx2cZZsLEN0HYzi9n xJ8PZAuFIpXhnd8sFXjslRWNo5WXbs71woRC63WxmM2rPI7v73C8z0pSFTyikpUprsh7 gmug== X-Gm-Message-State: AC+VfDwMGms4M0GtP1ATZbSIBWKJsMEMTRSHh47E0vT8mxhM5huVIHGk ZrtY/QTd5C3gITkoVMKsTg== X-Google-Smtp-Source: ACHHUZ63xnHUt+KYexhlyUGxFKu+qwec0nXuVDb8tfC5lnpxyCls7eNjwSR1TYwNepBRh0fjXZ+OuA== X-Received: by 2002:a92:ce11:0:b0:33a:56d6:d9a4 with SMTP id b17-20020a92ce11000000b0033a56d6d9a4mr2619749ilo.10.1686335581349; Fri, 09 Jun 2023 11:33:01 -0700 (PDT) Received: from robh_at_kernel.org ([64.188.179.250]) by smtp.gmail.com with ESMTPSA id p10-20020a92c10a000000b0033b27117120sm1220618ile.13.2023.06.09.11.33.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Jun 2023 11:33:00 -0700 (PDT) Received: (nullmailer pid 1767637 invoked by uid 1000); Fri, 09 Jun 2023 18:32:59 -0000 From: Rob Herring To: =?utf-8?q?Beno=C3=AEt_Cousson?= , Paul Walmsley , Tony Lindgren , Russell King Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] ARM: omap2: Use of_range_to_resource() for "ranges" parsing Date: Fri, 9 Jun 2023 12:32:52 -0600 Message-Id: <20230609183252.1767487-1-robh@kernel.org> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230609_113302_289456_7EE5E38E X-CRM114-Status: GOOD ( 12.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org "ranges" is a standard property with common parsing functions. Users shouldn't be implementing their own parsing of it. Use the recently added of_range_to_resource() function instead for OMAP hwmod. Signed-off-by: Rob Herring --- arch/arm/mach-omap2/omap_hwmod.c | 45 +++++--------------------------- 1 file changed, 6 insertions(+), 39 deletions(-) diff --git a/arch/arm/mach-omap2/omap_hwmod.c b/arch/arm/mach-omap2/omap_hwmod.c index aac4c4ee2528..1e17b5f77588 100644 --- a/arch/arm/mach-omap2/omap_hwmod.c +++ b/arch/arm/mach-omap2/omap_hwmod.c @@ -2194,23 +2194,8 @@ int omap_hwmod_parse_module_range(struct omap_hwmod *oh, struct resource *res) { struct property *prop; - const __be32 *ranges; const char *name; - u32 nr_addr, nr_size; - u64 base, size; - int len, error; - - if (!res) - return -EINVAL; - - ranges = of_get_property(np, "ranges", &len); - if (!ranges) - return -ENOENT; - - len /= sizeof(*ranges); - - if (len < 3) - return -EINVAL; + int err; of_property_for_each_string(np, "compatible", prop, name) if (!strncmp("ti,sysc-", name, 8)) @@ -2219,26 +2204,12 @@ int omap_hwmod_parse_module_range(struct omap_hwmod *oh, if (!name) return -ENOENT; - error = of_property_read_u32(np, "#address-cells", &nr_addr); - if (error) - return -ENOENT; + err = of_range_to_resource(np, 0, res); + if (err) + return err; - error = of_property_read_u32(np, "#size-cells", &nr_size); - if (error) - return -ENOENT; - - if (nr_addr != 1 || nr_size != 1) { - pr_err("%s: invalid range for %s->%pOFn\n", __func__, - oh->name, np); - return -EINVAL; - } - - ranges++; - base = of_translate_address(np, ranges++); - size = be32_to_cpup(ranges); - - pr_debug("omap_hwmod: %s %pOFn at 0x%llx size 0x%llx\n", - oh->name, np, base, size); + pr_debug("omap_hwmod: %s %pOFn at %pR\n", + oh->name, np, &res); if (oh && oh->mpu_rt_idx) { omap_hwmod_fix_mpu_rt_idx(oh, np, res); @@ -2246,10 +2217,6 @@ int omap_hwmod_parse_module_range(struct omap_hwmod *oh, return 0; } - res->start = base; - res->end = base + size - 1; - res->flags = IORESOURCE_MEM; - return 0; }