From patchwork Mon Jun 12 11:45:20 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 13276388 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 744B2C7EE23 for ; Mon, 12 Jun 2023 11:45:39 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.547049.854231 (Exim 4.92) (envelope-from ) id 1q8fzB-00075H-3C; Mon, 12 Jun 2023 11:45:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 547049.854231; Mon, 12 Jun 2023 11:45:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1q8fzB-000759-0P; Mon, 12 Jun 2023 11:45:25 +0000 Received: by outflank-mailman (input) for mailman id 547049; Mon, 12 Jun 2023 11:45:23 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1q8fz9-0006zd-Ld for xen-devel@lists.xenproject.org; Mon, 12 Jun 2023 11:45:23 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on0608.outbound.protection.outlook.com [2a01:111:f400:fe0e::608]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9d3a3d42-0916-11ee-b232-6b7b168915f2; Mon, 12 Jun 2023 13:45:23 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DU2PR04MB9196.eurprd04.prod.outlook.com (2603:10a6:10:2fb::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6477.29; Mon, 12 Jun 2023 11:45:21 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e442:306f:7711:e24c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e442:306f:7711:e24c%5]) with mapi id 15.20.6455.039; Mon, 12 Jun 2023 11:45:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9d3a3d42-0916-11ee-b232-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YibojOIAdW5tPGK2VycNy0yipEcUu2k0A+xhpKTNoBQVWarroikS4pJgYoWE2YdEC/r23QEReyAv7AjGOmY7D9vkNR96Ehxpne1hEh1U+7XMj1YUXFDMdPgvJtimLuXngLHgczOXXuKPPg+GijS/qUkDIkh+qBAay3y456kPP9J0daF8dUxWZDEDk3yMQjy8Q4sbYY9jJikd/GuEeHH+Rg6y9Qh+f5maaZqHp5Y2LY9US6nex5FYBdQtRJkeyw67IHpTl7i3xAsnXkJqVpRSNesxbxHeI1eppYJMz3U4AVAqGfJrcHewubHgVsb8/tu+hPZDeNZ562UwcC/9OnCDfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=U1YzWXeZ3z6bC+mXj26Xjsu53Z/uSpydklQeVDdytmY=; b=kpp+DfTPJPbW4bTuPk3rGFXT4nT+rPAivFHH61hAZk1GPWdCVe4yz0JC8WVRxYeqZpwLq/KGV5hTKzGLLp9LvPLLYPlsHwSK7DeSEc2Rf2Aa10iT7KA0waQ4qHy0zI440FYoJRgy1xTmKjS4M7M8oX8aRSCJkSkt/V2Mogf0os6lHN0xsCIR8C3vLDSnqC1Pc5YhVTXAvyaVLW0DoB8fsHVLJ+mnR4aaonLr50W9d14DiDeD2vnkPgc5R13MwZ6PzfZZ7SrCfy2cbDn59kO/0Zm5IYckCjZKYjGaFHUrmj/0Ny8YY/zhz6auWv7Ol18UQ/JPmskxYn32cZxWXcx1HQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=U1YzWXeZ3z6bC+mXj26Xjsu53Z/uSpydklQeVDdytmY=; b=orqTSxlynbBkXGxentfJ0rDR9LeM/IaftWeMPCXKAPSprBAkCDGzmQla3YrkuNHVQnrtZsU1m3tKhP+1/LdkcDnRBaDRD3iClFkHVWoIlL2lMDRTArb4hwyMCQ2nqfpi4DoMVaXVPgRCHyhd6PqOfwCbHkLlUHQIyEyKDFQzDhlaQ04aY3fvs6XmmzFM4zo9LXW3bjJSox10BkuHQHctYVaTr7tQDANx3ds3SlfTcd5UrASBOrC7lgzQKnte5yJWfpcdl3BYj5Ai7nuaYcTsLGAbGuOAxQWrzAwIijHcnZC05AP0uQQmag2sc9H1W/Q4zAv9U74DX+IcFdgy0ObV9Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 12 Jun 2023 13:45:20 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: [PATCH 1/5] xen-mfndump: drop dead assignment to "page" from lookup_pte_func() Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Anthony Perard , Wei Liu References: <2dc50b58-a4e4-3e32-1876-94412b14b052@suse.com> In-Reply-To: <2dc50b58-a4e4-3e32-1876-94412b14b052@suse.com> X-ClientProxiedBy: FR2P281CA0076.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9a::18) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DU2PR04MB9196:EE_ X-MS-Office365-Filtering-Correlation-Id: 5dd76939-9ab7-4e30-f616-08db6b3a80d1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: arLVgovyo329rgDR+VnOfp7vWkCeFN5E9CfnqrV+WFUgpMAaGpajNNTC7UKw+m7gbqLxw1yx1CnvgZTFaOXElcF0HEzxIMBJrq5Qkhz+75PdBBs/QQZca3nqyFev+EzRTiJGPc1Fw7yEctA1N0sP/dzMJIdP+WKe5S+dj4JiqqChuWQrxDY1Dhxh7BcvHXOIWLLZMgqxmR2MOQywaWlXfgE/r5m2Olx/iRTj5NbIjJx/f6ckAK+Fk2PZRbixZz9BXGppA6aQeSiEC/4W1XB2ltm035Ergrvsq85E+iPNeaHlSF/z+4qODTAq7e3JOsy87k7Ju4nmDaaoHZKy3p9krmJVUZ9gwWRYNdWbFRuS5OPZwL2wkBCqcir6+sF3un5MsQXF2Wppe2aDb0/HPaVZadbjD+A0TL/b5KdT8pepK/DCavIK6k6jJ5/XGrhdxIUcaAV4GTprxOsKoYG74eqrQL0US8J9BJ8DpsoMbml4zC/CGCijhkDtzBDm0aZa2Hc1I46vw3BkU0J0x2UeLpZ929vl7SkmBYUfAn+I0Qj1cVtvI/rVCmnBsavamvc4LODXsbb2dkiZ5tdpqly2bmP6TWCWltfomqh4BehlI2ak72tqF6sCU9TphBIQKWT+BWPvsFQuvUiXx6z9uQF2JhvJO/jTEQF4NniGBw12UXT5FIcHkYAqW44NtKGwIR5QL/Al X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39850400004)(366004)(376002)(346002)(136003)(396003)(451199021)(54906003)(5660300002)(31686004)(4326008)(66946007)(66556008)(6916009)(8936002)(8676002)(41300700001)(316002)(4744005)(186003)(2906002)(478600001)(66476007)(6486002)(6512007)(6506007)(26005)(36756003)(86362001)(2616005)(31696002)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?JBSQCeg2ydLLoF5gJNUDIVG2aMEq?= =?utf-8?q?yERzZeXlyGzEv1qnVQmmQjlleaJly6shTJXCTF/KEzQgYEz3d10xRq7CHDTW2yZtG?= =?utf-8?q?7GHD0dcRHnbn2NxTehgKRmWWBjvUSHXjFT6baNRu4fjZ9UuexB4bwza/siyrGuH2e?= =?utf-8?q?ZvoAXOcczIXCamjn41gkGg0J6vOym2mXvtTOh17AR73xvKibiVMq2ex6WM8GAD9vP?= =?utf-8?q?PsvPFmVc+uCHnHLGbL1UTFgO3ziQgnXUe85aVULBEMGB88A18uNX41NHyBHPw8zum?= =?utf-8?q?J7Er6fyJp3x3dJ7lR3b0HFR0xs+R8vCDLBp3VhmMKpaDBO0kUdpTVbhQXQm/IXEMy?= =?utf-8?q?XMRGOexLgCl5Dzb/pKtIV2mnF+5CL8z6MImqJvRyds9yywYWIuoaPZBw8GH8lnf+7?= =?utf-8?q?vDwXkPvp1AxZPdY/XYV9lNIbHuPein9I3Eg1lUtxUROvlnd01uQ8+4HnffyJntOZ1?= =?utf-8?q?6eBfnnkeoD7bcXuQWpDsgBAKNQBbGRNzeplv2Wqo0kNef4Qi6PKcZ11flaG3sUH6K?= =?utf-8?q?dO0J+7gYn6Qq8I2f/VpZzEIzyeT+vvX3WH1AoqNkThrZLsDup9VfgNCV6cSQv5rjb?= =?utf-8?q?0LAG7/4U7df5E3oTGGCDwkmwvoU5xS9Ih4mfzRyuI61U+e9CIvi3fkQgL68FU3U+o?= =?utf-8?q?YW+ZJnawtsFa9hTL5jqdxHdXz2D0YDZKzzYw9CWG9gquBF56sdBCvcQkUta/ceSIm?= =?utf-8?q?4XiR5P5Tmo33087AQspAob3OPc9gRLR/W9AlSS2rlNDyAHTfLA/qjhjzEna/UbQfl?= =?utf-8?q?kE0Dkon/G0cbY2KC2DmkKlQfJlD/429Ws0w2C1M6X8WcV1hSslLqDID6NG7fa3i9D?= =?utf-8?q?z68NvBnfx1/jTBgeaqP0fFPdimoK4wGxejtmZLitb+5g3sYlyPifxHPezk/KnAtfW?= =?utf-8?q?cXMllUpsZHxmuf1Y0KejAfpfkAf0Rsmh5kWHNFt/vx9uGrjUkzAkqsZIHI7iTveRi?= =?utf-8?q?6T0ReMqLHhl3WDFHXZ6Qutkq2n5muGiZ0l/Y0wJVCMKoPOdDkZIguJrrn3Smp+LP5?= =?utf-8?q?fipIStiO89qmxoe197LuDavBlh3vfE6bRY4YN9WAnikAki3h3qKbqPy//9Ya7GQJD?= =?utf-8?q?L5yVKEJTkOGzVxPHaypbZLtJ9H0TVo+MLPTeOAChythbG9P7hd9AyUdv9El0GaXnL?= =?utf-8?q?aNeA1PLymQDjcP2EJlx6xaEpDxVZlygBIr5d8OHymOhDda3llj0zL5DVMp2ZaGfOJ?= =?utf-8?q?nK6MRnyMUYjHnVNfvJUYG8sr0tg9cNqCiuNIxCfIAVFisT5EUknumA8LuTtsk9TGC?= =?utf-8?q?bqcQIxX+kyhsaDr685LnMBo3KricqSyUzVA+89mx+EMxCWsrHX1kIiIXPjvu92X8h?= =?utf-8?q?wYpKfPFRzroZjzu9WaXLBnaIKeUONJtNOOPwxb/D60bg0HQJVQ8wu5F+FCUN02TU9?= =?utf-8?q?g02GtX5fSQjDYQg9cC/R1PvDNLFjqDJr8MGRQt/tgf1RO6SJvGl+Mgs3iSg2Qbu/M?= =?utf-8?q?HY9UjSte9mSUy3YsK6LWrzm7DLRjctJKFjCxd9bdvwT4qF/eULq2SXrc/SN2JKNre?= =?utf-8?q?5A+BOvsdE6aB?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5dd76939-9ab7-4e30-f616-08db6b3a80d1 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jun 2023 11:45:21.7926 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: OjfulOSW86MDsYfvM438jEvZq2+rmKHzLe20+PzCZVEkVxKuNkXwDobZZKeCFR7PDwpiEdj+9j9hEFMeRXAm1w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB9196 The variable isn't used past the loop, and its value also isn't meaningful across iterations. Reduce its scope to make this more obvious. Coverity ID: 1532310 Fixes: ae763e422430 ("tools/misc: introduce xen-mfndump") Signed-off-by: Jan Beulich Reviewed-by: Jason Andryuk Acked-by: Anthony PERARD --- a/tools/misc/xen-mfndump.c +++ b/tools/misc/xen-mfndump.c @@ -265,7 +265,6 @@ int lookup_pte_func(int argc, char *argv { struct xc_domain_meminfo minfo; xc_domaininfo_t info; - void *page = NULL; unsigned long i, j; int domid, pte_num; xen_pfn_t mfn; @@ -301,6 +300,8 @@ int lookup_pte_func(int argc, char *argv for ( i = 0; i < minfo.p2m_size; i++ ) { + void *page; + if ( !(minfo.pfn_type[i] & XEN_DOMCTL_PFINFO_LTABTYPE_MASK) ) continue; @@ -323,7 +324,6 @@ int lookup_pte_func(int argc, char *argv } munmap(page, XC_PAGE_SIZE); - page = NULL; } xc_unmap_domain_meminfo(xch, &minfo); From patchwork Mon Jun 12 11:46:19 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 13276393 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EC1B6C7EE25 for ; Mon, 12 Jun 2023 11:46:38 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.547061.854250 (Exim 4.92) (envelope-from ) id 1q8g0D-0008FN-MA; Mon, 12 Jun 2023 11:46:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 547061.854250; Mon, 12 Jun 2023 11:46:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1q8g0D-0008FG-JT; Mon, 12 Jun 2023 11:46:29 +0000 Received: by outflank-mailman (input) for mailman id 547061; Mon, 12 Jun 2023 11:46:28 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1q8g0C-0008F8-0v for xen-devel@lists.xenproject.org; Mon, 12 Jun 2023 11:46:28 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on0627.outbound.protection.outlook.com [2a01:111:f400:fe0e::627]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c3719919-0916-11ee-b232-6b7b168915f2; Mon, 12 Jun 2023 13:46:27 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB9424.eurprd04.prod.outlook.com (2603:10a6:102:2b2::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.33; Mon, 12 Jun 2023 11:46:23 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e442:306f:7711:e24c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e442:306f:7711:e24c%5]) with mapi id 15.20.6455.039; Mon, 12 Jun 2023 11:46:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c3719919-0916-11ee-b232-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cuBb1RoVDyFLwaSn2pW2mdhS103q6yLgOy/dymeMaq/6vbJATYYM8L/WP1xmRtbK5+O4uNT8dFOak4OMWC7mH3HU/I67paXlVEntc3iz8ku9CsjcF3GV+PqvOdoGLRAhk8IB1Fda79fdV7kV8jG5cKwfdYiOTqcHypxpzstve8cHDTIx1JMIpHALk8LlywZYDpm7FbE+Gt4cDhdM9WGFflJnlsG85eeh+oPEsOGntZ2aMshsCdhSCqbNMkkV9+Tdr4/JsxVu6A7/1sxHVQiYm2IyfkbKOanDbVFw622P0ARBLU0XszHjAUeJ2Io17aGfE4p2/CLs/teIWH6vwWrrTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+dDuzZO3NY+2JEelv9HlCc27GL3IfXBwOaXL4IVoUlc=; b=Tgx4oLAGyXtu9R+WofTZ1vIT2GoJVcxQAN8E2tc1TU8i0I6pQoFYBiRTTsk+B47GocdxiBRKMmBW2x+xxBS298QJCU/7muajlfIkvHyA6IVQ6eQQULAMlpRSMXZ+0IT+Jxs/C2jX8MIOZQO0R/NL9gv9OevhfrOm6l6hbammN+50ig1lamLCIsIsd+9Z4bvVSfieES3jo/GmXAUhtbGGiPHqzbhmro2fBxFFyuUVGmpAL6wvknGhSZ3yaxLXcEdGvcdwnkKyxJbrCnIiEC4bQ54BcGf2mXTSLcHJh1qsKQg9voLLZo2vkTr4hT0TkPQgiHgnsO2Tb3zryWrxhPQ+Qw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+dDuzZO3NY+2JEelv9HlCc27GL3IfXBwOaXL4IVoUlc=; b=0PxbqoHncnfKxb0EkDIuBDlElfqDg/52LjB3Hum7awJH2xkBWZ45yuG50rRMMNLTQf5AKQbatkRITggZhFuyWe+cX1i2+HGPW8BrS3v9TpP8pC+D9fi0wSpBuEINZmRU/n0HH0bOY1mD1wY3dItfoiIkwC+MMDITp9LfI8javGKjTZoB8PMmVr/owKnexTobhwnjGPrqrsZwqVO3hmWHeUZhfCi2nN4QqBfR+oWkzR8XW77Ys1//ePru+sAjQJ8z8c8cRa+5fj+cSid79ljEkz5KIGHZIseYqheLUqwr5wvbQsyH2FrCoT/GqYR0Ztx+kI9qtOIPtGy5zgVJUTBCBw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <5eda17da-7185-9cf6-7e87-70da57aa0ebc@suse.com> Date: Mon, 12 Jun 2023 13:46:19 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: [PATCH 2/5] libxl: drop dead assignments to "ret" from libxl__domain_config_setdefault() Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Anthony Perard , Wei Liu , Juergen Gross , Daniel Smith References: <2dc50b58-a4e4-3e32-1876-94412b14b052@suse.com> In-Reply-To: <2dc50b58-a4e4-3e32-1876-94412b14b052@suse.com> X-ClientProxiedBy: FR2P281CA0095.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9b::17) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB9424:EE_ X-MS-Office365-Filtering-Correlation-Id: b886b6c6-6e15-4515-cdf0-08db6b3aa47c X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1a9JzZS1gVN6MoesZUCHQqmbztcsCmxJ176c184Z57bQ51Nr4d8AvzKypk5GWhcfTx5Yw7pDLc0rTixQNQXz7H+qXY0FaLUEYGiFBy71ee7AmA4sZno4xY2oPdfPOTrL8cUqMcpYV5x5dEr5s1s+2G1Pv6it7JaVdTO6tx0LVyYnlkrUOue+/zRP7JE6wvu/rDMxpDK1WKdAtqXhvIguMk0/wL+waenZan8IY38IEfIYrk/6vBIpk0Kdb410LlqdztHEKYUMDDj0NQ5/4+Dv6oOazpeLhxGZF+gXDWVPr1mCtuy0BxzpYUOW9vr4dFqQBhdlPsWXCnSvRnxQh418DHNVC/W890qa31nydzTo+wOn0yJa9YUpBuxPpJgQdocWoQTtYkUBGOyrvB+b5Ae4fNeGngIFmrjwu9rI0TnOskRggseQikBWHBVmRHoClzRluXx4OfiqWQOXgC2jE1J3P0tqcSiJHuZFDbF83iCgJ43x7vOkzIdy3WQCg9gPqYLCr9HifINLUVqJ216/IxEUkdi2w6u4nszFJXpQLWnM+xBS/bK3b78sVTbTtVuwkxfKLF60mCAJp/4FGqsfGx1h3DNOPNW07fSY80+RNOScaWT/z6uT1SMYZXwPl4jhYILcSI+4HRvuLIszhmqPEHlYDE8Lm5qm3/iWD294CpyPv9WX2lc06TbuRZmH22K9laIx X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(366004)(376002)(346002)(136003)(396003)(39860400002)(451199021)(478600001)(8936002)(8676002)(54906003)(6506007)(5660300002)(41300700001)(316002)(6486002)(66556008)(6916009)(26005)(186003)(31686004)(4326008)(6512007)(66476007)(66946007)(2616005)(83380400001)(2906002)(38100700002)(86362001)(36756003)(31696002)(101420200003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?1tXuhm1V2slB/+2gdESh71MSjjaY?= =?utf-8?q?ib4g2r8ODOpn2VClbeW88upJDaaeB1n0o/90WoSoy4hUu5vCtjhzrmJRCiCZqKSsx?= =?utf-8?q?HClB7DuRDVC6doj0yb0ZVyQS6oAFLVuJLo/n54Ngng0t2oazxvd/eYdktjywXTjCv?= =?utf-8?q?bZ7g/JigP3nC+w2rCj1nVj0r7urObLyk/dLPnXSYCZhZj0HR6bhZKJdxL9oLiT6w3?= =?utf-8?q?pXvR+uaE1pnObds7zsmk5fAACC2BZeicxPQJU6raVNZuZ+XyXqVUqxmbz9Jatdupa?= =?utf-8?q?XYwpkPMLJKxQPRtt+B/TKvfw1sA9l2JN4+KfxM2iIHJhJCsUm38ITSRUcpLttGEzx?= =?utf-8?q?2nwTEbVBoMcciym69zeU6deYXXF/uhTk7Nj3QxO/dQGNFG/HISrHcJ/xghsVeh7Ey?= =?utf-8?q?az9tjIsuG64k1uqanMcWIl7x+VYzBtIHOYpZhREwpVFJdjEzgmJ14t8IhNFAjnjhj?= =?utf-8?q?FYyuk35VaY5U5pykHXkRzICXPgAHzIcu0mtFNe6DuSyAorA3r60NM+q1dJvSDE3Jf?= =?utf-8?q?76sCL85b1ip1I3Yhi8nym+9ZiM/0jDLjbC8HZGAYKwLBRVZwLJcmo4nXiMBq9GUj2?= =?utf-8?q?7Z8zCp6NYUSCZsAg/I59ml4FR45YfO8qv4vXksuKChbEPGsjkU19DRYCtKWnhSJUS?= =?utf-8?q?EZUqWiPh8BNLx55kv9s3HteXkRSfd+pvbJBhae6LN/umgdCR6eTyvXLgTHh5v35ai?= =?utf-8?q?llKrcp0+GQOmiHdmOXLkOEW+sKeZztx0OAL1DGQEGAmT8/cknsMAj4CbF8iE5iflI?= =?utf-8?q?KnA+crrHjM7WfwvR0Rqz3mH2miA7+/5ZC7hIFfTjhce/x8jJ2+ovVywtWHKbISYTF?= =?utf-8?q?HWrZPLlf90vuu/YpRXMcRgDlb0d/h9SPuuXCAmez6SjaLm3pWhrI6gquXAnqZ70g+?= =?utf-8?q?Hq/Pt9pbIezTfzGOBfCP0bvuvVzDYbWys7xMJBc7EoA9AjsYT0GRHQs1oGXUzjxz0?= =?utf-8?q?6391dkAZESNvz+oyahwv85KjZf7YX4kB74iqWQdyxP9tWVPtU03o/T0nu8gmjPP8I?= =?utf-8?q?bZHtsdhIJL23eNsb3SPjUVKyo/0mMZtWOdR9I/NqNbgDyMRDsVQQY0kvxv50estZl?= =?utf-8?q?hFFMLoTAMaNDMjCXhalBk5BUnhUDjqdnYg37wpJY6URA2v6iQ2jihg/pXdgfzL+rV?= =?utf-8?q?QzNeb//apV7sqan5DSQPCA6iOS2r+B6IToo5VyZxxsPudFw/C2xeiKL2Ay8ih4O1v?= =?utf-8?q?hIh68qo0iEr3wmPA7Ck0vwUExEL7RatC7igmIgUS4DmZrwS4uzGJuN5/TvkgkKTn2?= =?utf-8?q?TtsXuaWK1CV1X1wwYvaCLNYbc0E0KxkmnOY6MwDUT4Bcid1z2WN4RKgTjra8IEvsm?= =?utf-8?q?+7HJ/U1d20MHDR1H5+8OOhuuyod96CsetPc+0vrbljplj7LhUmh9p9Dw/ILOym0ar?= =?utf-8?q?1Y9+aG++Oxfecdgp5gbZe8l0QZGZ4aSSIAwToh939QMu2xFlxIoJsN/XwXv54CLDK?= =?utf-8?q?s9mOtOs7K7ckwi2Xr9YuoGxjk2AuZJDevkoty2UmPx76vlG687YZQBP5t8u7qgd8r?= =?utf-8?q?wnhNW4aU2U1H?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: b886b6c6-6e15-4515-cdf0-08db6b3aa47c X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jun 2023 11:46:21.6682 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ftxTKhRU7ShBGZ0fgaiRi1IUAKzVMDjTlt6cjH/4Wqm1TsSOmzeZ8BopzhCb3u4hSDYISFseHi/e2l6L5P+QaA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9424 The variable needs to be properly set only on the error paths. Coverity ID: 1532311 Fixes: ab4440112bec ("xl / libxl: push parsing of SSID and CPU pool ID down to libxl") Signed-off-by: Jan Beulich Reviewed-by: Juergen Gross Reviewed-by: Daniel P. Smith Acked-by: Anthony PERARD --- If XSM is disabled, is it really useful to issue the 2nd and 3rd calls if the 1st yielded ENOSYS? --- a/tools/libs/light/libxl_create.c +++ b/tools/libs/light/libxl_create.c @@ -1081,13 +1079,12 @@ int libxl__domain_config_setdefault(libx ret = libxl_flask_context_to_sid(ctx, s, strlen(s), &d_config->c_info.ssidref); if (ret) { - if (errno == ENOSYS) { - LOGD(WARN, domid, "XSM Disabled: init_seclabel not supported"); - ret = 0; - } else { + if (errno != ENOSYS) { LOGD(ERROR, domid, "Invalid init_seclabel: %s", s); goto error_out; } + + LOGD(WARN, domid, "XSM Disabled: init_seclabel not supported"); } } @@ -1096,13 +1093,12 @@ int libxl__domain_config_setdefault(libx ret = libxl_flask_context_to_sid(ctx, s, strlen(s), &d_config->b_info.exec_ssidref); if (ret) { - if (errno == ENOSYS) { - LOGD(WARN, domid, "XSM Disabled: seclabel not supported"); - ret = 0; - } else { + if (errno != ENOSYS) { LOGD(ERROR, domid, "Invalid seclabel: %s", s); goto error_out; } + + LOGD(WARN, domid, "XSM Disabled: seclabel not supported"); } } @@ -1111,14 +1107,13 @@ int libxl__domain_config_setdefault(libx ret = libxl_flask_context_to_sid(ctx, s, strlen(s), &d_config->b_info.device_model_ssidref); if (ret) { - if (errno == ENOSYS) { - LOGD(WARN, domid, - "XSM Disabled: device_model_stubdomain_seclabel not supported"); - ret = 0; - } else { + if (errno != ENOSYS) { LOGD(ERROR, domid, "Invalid device_model_stubdomain_seclabel: %s", s); goto error_out; } + + LOGD(WARN, domid, + "XSM Disabled: device_model_stubdomain_seclabel not supported"); } } From patchwork Mon Jun 12 11:46:40 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 13276394 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DD951C7EE25 for ; Mon, 12 Jun 2023 11:46:59 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.547063.854261 (Exim 4.92) (envelope-from ) id 1q8g0T-0000B7-Uz; Mon, 12 Jun 2023 11:46:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 547063.854261; Mon, 12 Jun 2023 11:46:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1q8g0T-0000A3-R1; Mon, 12 Jun 2023 11:46:45 +0000 Received: by outflank-mailman (input) for mailman id 547063; Mon, 12 Jun 2023 11:46:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1q8g0S-0008F8-7B for xen-devel@lists.xenproject.org; Mon, 12 Jun 2023 11:46:44 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on0628.outbound.protection.outlook.com [2a01:111:f400:fe0e::628]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id cd3a102c-0916-11ee-b232-6b7b168915f2; Mon, 12 Jun 2023 13:46:43 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB9424.eurprd04.prod.outlook.com (2603:10a6:102:2b2::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.33; Mon, 12 Jun 2023 11:46:42 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e442:306f:7711:e24c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e442:306f:7711:e24c%5]) with mapi id 15.20.6455.039; Mon, 12 Jun 2023 11:46:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cd3a102c-0916-11ee-b232-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=P2z65NHZLHfHzPGCAaoJqmkwopKeWpZen0NY99NV8MNrBvKSxWzhbSm8iSIJUf5XNlNJH6KrsiGWIu5ZMxQXuPzr/ikF/5jio70MCwLdCXLRrv62FHLHYet/7pfrzTsKtfor8vKpSkAodyXqwy5FsdYLkQddIBkRKhNzTHUMkN5U4bllZB4wYY7UWi6JKGNChwLca4oCfFYQLK8tbuBjp3d62b/kNfF4WVe23FihmuEmn0w37wCiXc0sIodAVw2n0X1eTXnoKxgY/d567MLKYEPeGErJCsJ/FMJvtiUys9/DQb2WGG+DRLhRy+4q5ClzHPP00xqOI8BaJ3cBbS8SRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rPVECL3iX1325C06pRAn0RbvmreO2AjYKQ1yM2vVRJ8=; b=Hb4EbkjUfxA6eW8v6YqVI0lcy8GneIngjRiI0Ypb5Z14bv9DNLRZ/+rFsw+Wb6W7BmBU3HXLaG1QzwzRmtgyjcaVvUU2Gko9exWNs5ST+8zRi28jU24vVElYHUPc54I31o7LM55z3Xudun98GWPeP5zGEqkWWooKxq8GQL6CaT+J1sdO0WYeV6HPN7PiOP2JCrx6TW0J40dXcfcvvNxWWcaSgfWp+RyYPzGqXHHS9Ycw2fwWPzuB0pE9JAUZBPFzE+zEtZ31fQhLH05VDv5ekfcGW79dvQMp+rdT1NnGOv9/yfhFby1/YLL42ZAcFIcU3Y2qP6ns4NSnF/rcdlHFJg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rPVECL3iX1325C06pRAn0RbvmreO2AjYKQ1yM2vVRJ8=; b=3uTip3c+Hntan0MmCkFCY9GXmpA27MUEZ0tmcnb7l/S98uqt8YiW5C+QZ4eTQzENtRWDFs85Yr3Yx3Og3U28bhdgAUmhhq86RXsUY6RMJwfqzdjppSSan0GwwMRkE8RwG/xULGcQ6Vnvt2MU0mG2GXFqzTQfs/C2Bid7kmlDcdr2tfh/LPtlQGdLE+CbQx3KkjCyr08UGOJiDNE7UzQPVGl1VGeY9KpIuQEX1v818CaClYFDc8zBtJkIUsUHj1S9huSZnZ7y9JtqUdLj58IbkdYdIZSDaidpcLveYsC5XYAEDAJVxDGGRY5EIAb2PFjSCd7b0iKX8xeHL8m4ImQdww== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 12 Jun 2023 13:46:40 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: [PATCH 3/5] libxg: drop dead assignment to "ptes" from xc_core_arch_map_p2m_list_rw() Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Anthony Perard , Wei Liu , Juergen Gross References: <2dc50b58-a4e4-3e32-1876-94412b14b052@suse.com> In-Reply-To: <2dc50b58-a4e4-3e32-1876-94412b14b052@suse.com> X-ClientProxiedBy: FR0P281CA0172.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:b4::14) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB9424:EE_ X-MS-Office365-Filtering-Correlation-Id: dbdcf97e-575a-459e-318d-08db6b3ab0be X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dmzPkbX53d/WwDSxNKurA3qeSA/VaGO/h5QllgK5+u2QFoFOiNErvfrycOxP+5Ruu7Bzo325I7Fc6Fi1qS734r6Ta9gb6mJW8Ga91WxprE/p0+uVSrkgzaTkTh0lL2TOYbgC+SiA0vlz/KTSHPxNbrR20wp4ak1lZ8rXqLNbPu3ojZ06Z6uw/kWWQhro6/yxn+uzIzkMEnsCYA3ZerKNH1rSmxIZX89xE6blLHyOYSgkRCyWufrPUd154upPTLmj8DcU85d3BdqIjQzAvo5tzqWUXfuW3puSzAAASz2m3ChdV4XD/V1fzc8bhZoCcTgmP26epmYLASCgnS4tHKVQQ2cEvVYLuccEKEFMH12HWkIihf0eLAC05oBdgK+8EFEbtVqESr+F4DGrCGqzjLq5vAVHX2llSglyKxKLLVO6gL1stUH0g1lSM7Bp9zxB85ul/jnVGUfLQ8hVhmfa5EAkPe9M4o2hLKI5E2Ofisg8BIUJy8AEd3Ci6nncNUD6vAPC6wU9U74GVvJwnoS/ONBVMtRm7rjzb89XH8BEimBLgFPYv6YwzPDAw/m3Doza65eg4JmQ/DobUIdYlvx1Im/SHouua/+xOepqFhuPQuVGp88YdOZUzfFJs1tHNPNCpvSyQssunFKO1nxcL5UK4P6duRIPuzS753e2caZbJWE1fkUFLLxqK4AEgsQQl9zyHxa+ X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(366004)(376002)(346002)(136003)(396003)(39860400002)(451199021)(478600001)(8936002)(107886003)(8676002)(54906003)(6506007)(5660300002)(41300700001)(316002)(6486002)(66556008)(6916009)(26005)(186003)(31686004)(4326008)(6512007)(66476007)(66946007)(2616005)(83380400001)(4744005)(2906002)(38100700002)(86362001)(36756003)(31696002)(70780200001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?p/aOdfra3voJ/Qp88cFuhxArFFUI?= =?utf-8?q?a0p/3AtJszKEe6Hrd1CR37GsngU1pE7ApjpxU9mgJ7oJ7iqdE6u9dbEpYrf2x1BJ0?= =?utf-8?q?ye1V9HsWSaQUD7wD9xh56Go2KDjJJNWY9607akxUkWYAJRAgDIzw+uorlP1QMBDkm?= =?utf-8?q?A7YYWrYI9krUZWvxDtNXNUpH/qpNYJ6YVHZwZoxySaFhzQ6u7BNDmCFupF+xiKlV0?= =?utf-8?q?Hklltrm6aetaFY9xFwSYqX9ZO6JPos65DchtpJbWLdlmTiiMxHHLq2ZegSWur4rTp?= =?utf-8?q?0oGzVTPaJO5JYSiksnz0QiHN0gzqI5Dho70gF9VnR6yzHtNBsUUUf70+vXMm3Yo++?= =?utf-8?q?klqM0UyRe3F1dvQR7m7wmRQyzRowWMO8QItAFTcWg2lGMnCgVqDeljQOx3pwdJjC/?= =?utf-8?q?xt59ySyfkJRfbPKebMjtSsuq5Akfzuk4d02aWeTE0vtUbPhvxLeJvXcuXExIk8bsY?= =?utf-8?q?Yoaclrf33F7v25AaQnbkSJ4Zj7hyba7zDtHZhOcp/1kTX7Ot9lI0bohQQsqPIOhWf?= =?utf-8?q?66rmdhz5cP7eVV5FvzJkzCe27n/qXHhbjGCmlqb7Eza6GOkPn5pF0RbcPBPsv6bNb?= =?utf-8?q?VbNsUloNWNyBrjXJHf8N07b7EU0mpuwvatQ7ke2VweGZDQc1gxE2W+4Z2asp5qcsX?= =?utf-8?q?NryFQikSW0p4jZGjBCFNYxJ8f07hVc+hvBCXNZm0O5g0ziN1Halr3xktizo3A4xIW?= =?utf-8?q?WvJP2hfeDgUiqvc9B6Z6E434Lom/zMT3PtFUgrEYVwfNjYXBgnauVEarRsQwaax9T?= =?utf-8?q?dVp4h7CKYdy1lZMh1y01vSHXHUsQLOQwpUoQpm76McfEDvhN4O+9v6dYv17hZFDfw?= =?utf-8?q?c2bxhFvC9Osgbf0TGtNygLLAXAQ3Y+wVHWGMvqboKuc7a/A5HM77XPkp+SyhQpQTu?= =?utf-8?q?bQabokDQQxYVDiDc7pYrVaaVnyNlwIOfQUByKjj/uPei0YNuHcghP6bLKZu/8H9fB?= =?utf-8?q?dGTBSOCx9174sVZDwcPwob5YtxFSqKeXm25UBN6+rfmKVhxVF6zFQTkKNGF0TrNh+?= =?utf-8?q?2y/2B72SKB9e76yldBAT9NHhvmakrOi66IenwdrKBneJTFQfyVBcunOYZfB2Yub3q?= =?utf-8?q?LaUJcLxa0Us+q8hE8KgerHxynA+eaQNPG8wNyv6B5fRNJc59hHFwwjewxM3TRgHjv?= =?utf-8?q?FsTWN6dOPygjiglE6G671nvTxy5BGr2KWgLA0qYtd7uKaNtR7/U2vNvDytDpVwhBT?= =?utf-8?q?Ww00ST7bTw34O5pYlBBj73IVHGenEvI3jOsUC41SwdvfdU3yKnXjyMJcToJjVGkAA?= =?utf-8?q?/ce01lKkEKkD3yK5dqqPd++/2WhgmaHL1hsMA9N8F1JTxOaycAablJlCkhBiOv6Rd?= =?utf-8?q?jQEaM1OvgDB5eWjRivIC2bKTIe/ZfgzsL7RbyU+5pBHyoTezflj2/bQzfl7KoVvtN?= =?utf-8?q?NeHvaMl0FKW6hWqBIQNq81FphHafCWnEJWF4+wAHgu7BRG7cd68Nf/2wLMAUaccVD?= =?utf-8?q?5005gBNw5mekhTdgHlskL7mw48E9s5nx/9gimSEuM33hpE3ULA6qtjIMk8+uVFQ+J?= =?utf-8?q?56ZYc4obFOjy?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: dbdcf97e-575a-459e-318d-08db6b3ab0be X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jun 2023 11:46:42.2189 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: chZI6/Z//fRkk4+b/7Hm0CbFeNURtfK+8CT/r9k2Hed49sL6V1eYZRbJHuf5x1fH9/9NRFCUztb5J99RUClfyg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9424 The function returns immediately after the enclosing if(). Coverity ID: 1532314 Fixes: bd7a29c3d0b9 ("tools/libs/ctrl: fix xc_core_arch_map_p2m() to support linear p2m table") Signed-off-by: Jan Beulich Reviewed-by: Juergen Gross --- a/tools/libs/guest/xg_core_x86.c +++ b/tools/libs/guest/xg_core_x86.c @@ -210,7 +210,6 @@ xc_core_arch_map_p2m_list_rw(xc_interfac } munmap(ptes, n_pages * PAGE_SIZE); - ptes = NULL; off = p2m_vaddr & ((mask >> shift) << shift); } From patchwork Mon Jun 12 11:47:13 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 13276395 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 29B0FC7EE23 for ; Mon, 12 Jun 2023 11:47:27 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.547071.854271 (Exim 4.92) (envelope-from ) id 1q8g11-0000t4-77; Mon, 12 Jun 2023 11:47:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 547071.854271; Mon, 12 Jun 2023 11:47:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1q8g11-0000sx-4N; Mon, 12 Jun 2023 11:47:19 +0000 Received: by outflank-mailman (input) for mailman id 547071; Mon, 12 Jun 2023 11:47:17 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1q8g0z-0008F8-Qn for xen-devel@lists.xenproject.org; Mon, 12 Jun 2023 11:47:17 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on061f.outbound.protection.outlook.com [2a01:111:f400:fe0e::61f]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e13492d9-0916-11ee-b232-6b7b168915f2; Mon, 12 Jun 2023 13:47:17 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB9424.eurprd04.prod.outlook.com (2603:10a6:102:2b2::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.33; Mon, 12 Jun 2023 11:47:15 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e442:306f:7711:e24c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e442:306f:7711:e24c%5]) with mapi id 15.20.6455.039; Mon, 12 Jun 2023 11:47:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e13492d9-0916-11ee-b232-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jroH4RQ06pKYUqUL/tSj0ZPW84WaSBvwaZOwhLDIX+igvk91SuhBMRIreM9Ul5yZ5xLMfXxlOqHL4xlMR4x7QX0xq+KXKj/vjpovO+Izvvkxm7mcMvUm7vX5a6dewThZQPUYSdTxDJMvmwzzldrYVXUcGDyz1d2wvmrhaqyoSocr0nr4Q6xMoc8At4vWfnP65KJnroDAasMANJP/KbIB1RSoS6OjotDMO/oKN3gGmSXgnXQXEcIqdf7f5nKeat6aJ1lty6T/FPXq6CaQuCXHfGsi+Pmk2VR/Ax49NbX3z7HF9ufbmDEaXn9wWk+kSVcxd4XFAf0PkwoKkmAZ79Dkgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=B+/y/m3EuaFu5IzJQsr10ANAsj4GrJLsTnjbxyCCt7g=; b=KhQDCSOp4CWzl7HCJ1xAJ7Faru+4+vUploMMs7So2jQfup+2Ws+FkPHs0UmwWOUURZ7YVDZHb9WM9HU45o3v1D+qmT0WrPjP7T5uxkSxlA0SwX+K2t/uJzTpA9tPDqTobxF0yyiMQJF3Z98MvzsjAsjqs+mi3AHtWtizCRei77s21folNqu7EeMo265BqSuneZICW+NNZbgG255LRnyRDJ+evEC83WP5nUhu79OngS3mRxgCVSAymnYyTB5XJJZhunhvJC/mEJhtK1MKmYCNUMI/TyQT4tK1I42s1IYCwP0gDoTYE8u+249voX0ssif6P3nNWcL8ifJhfPQBqiDnhw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=B+/y/m3EuaFu5IzJQsr10ANAsj4GrJLsTnjbxyCCt7g=; b=yN21UeDhi+eBaZqW5aDN7U/QlSnQL1POm/nzZbnoSsT+tXiqrOySiYyZDbsLgN8HEJpxla7p7mfARXVINRZKNljiuiZOnKj1Q3I7l2kYZognoMRSv0AVLIWUPWNN/ssXtYCxSp+EtBjxPUPvBzXbPxkDoQUs3MtmjeR0NfhJfCmKWVTfJhjFceulxrp2AZ3zFdWb6X4cqU9SmbCCLWmxtC2Q0CZVl1oJIIR+LFdmSt5dlPIxGlfoTBNxiZjZy5YataXV9i0P5zOEAeGQlTvBSbS5j7xnCd/R1OPSbK8hoc5R7tNzdXSj+eVx46ZPdcUqvEackny71gsx/giWKjWn6w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <89c45e29-fa7e-93e9-a2d5-45991c302794@suse.com> Date: Mon, 12 Jun 2023 13:47:13 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: [PATCH 4/5] libxg: drop dead assignment to "rc" from xc_cpuid_apply_policy() Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Anthony Perard , Wei Liu , Juergen Gross , Andrew Cooper , =?utf-8?q?Roger_Pau_Monn=C3=A9?= References: <2dc50b58-a4e4-3e32-1876-94412b14b052@suse.com> In-Reply-To: <2dc50b58-a4e4-3e32-1876-94412b14b052@suse.com> X-ClientProxiedBy: FR0P281CA0083.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1e::18) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB9424:EE_ X-MS-Office365-Filtering-Correlation-Id: e37195fe-b498-47f9-bd37-08db6b3ac45f X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: DxZssvo65/JcAV/t6goMFqjIykoss3/7Kx4/GehuaRJZZ/BqcX6ivwPuXHvftBHLNTH0AuA2KcqATj0F1S6U+QQX8k32pJglA14dNA7AZsx1pgo+vkLvlFU/ht7rziJ/g9Ag06UmC+bNxvlUEah+jaOXg7SGA/bLl+D6H1XAhLquKzVpqJVpo+3rBsIqOuCxnIIO4VWBF4spHQxJGU7IoJ7l9fMYe7Q2uzD71A3uLWIHSgksAtH6xCST+gZLSWPWrv8l1lsylsPNgaEuC8etQtUGtRtgZJud74zb7YNWsoTLMPS5ORqbxgMuJ3yPoAozsZRUYGe0xh5Vvu3Te+0oSh8u3MJDP17wlSPLW9RrhxHG6FljTD53Ey+3kxriqrMgq1GLAYVKgXgRc1oXE+KcarJzxqdm3UUZ7NV5fJCn6Z9WeTx9H2EjDY5iF4Z15asH57pV3T39c0m0PbdMERc956tWcXXVAVluE1HQwOYX/DRjWSIqMFm/0SQdO4yPP89nLtVOTZzNj7aOtlKaTHK+n2r3VY7TvN9AXOeqamvPzjMyhOImRFi/ApUTLvHp9Plo1JmnlAZmTtxnJno5Sf3rqhHL+jkskrCs3sR2pAX0zi4LrXHk8tbh/0seTufIJgqk0G1KFHBZ8ZjfSlnSxgszwQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(366004)(376002)(346002)(136003)(396003)(39860400002)(451199021)(478600001)(8936002)(8676002)(54906003)(6506007)(5660300002)(41300700001)(316002)(6486002)(66556008)(6916009)(26005)(186003)(31686004)(4326008)(6512007)(66476007)(66946007)(2616005)(83380400001)(2906002)(38100700002)(86362001)(36756003)(31696002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?gOk2zPAqVShPGd8QENiNkfJbIppC?= =?utf-8?q?3GWhsnzfc3UuWZD6c3WnTwpphEzaVs/ZzOZZyGGMWyk6D92bG0Vu1wSg2vGv1Oj3b?= =?utf-8?q?fJWtpaY0onby1gYher0VjiN1HaSguH8HI8yCe0P8rEucNo5k8hsPwQHjxUEk4qkFs?= =?utf-8?q?8cdfl2z5PVq187iEhicrQQCCRmMUVZBRUUjV18lPSlPDqUFuaxn9n0nKSh9VyUWdB?= =?utf-8?q?pW0NsnKvxhHgvPaflXUjKOZ4C9W5BxA2WejgBe1DACao5opsCSCB22i79T6ZgtfOj?= =?utf-8?q?iGazxmPBvsObkOdLUjS3Yec9ayn1fBE0PlPBJlIQOcHP3O584jLO0ktnSCuALYWQ0?= =?utf-8?q?DeYEm/pUjFlifEioY+espKMq0zfDVaPGFSzC+pr6+uPPTWnRpxEQJjYCM3r211w8d?= =?utf-8?q?Ap7f9HxCEH7YhkhIyBNr53DvrkIw8FKHujZ0dtTYr2MY8DDZZg794Qv5yG28flfTX?= =?utf-8?q?tzPPRfqHF3MLQnCS+NlzHm8Dt2hLrXZ+vCGGPTCCu60ktver3xFguwEwg4R4Bffsp?= =?utf-8?q?iREJhYoMIz/OpJieJNoCJ9ZjCJQR8lMy2NEd927xV/z6SVXEYlem+0nuTRMasVfDB?= =?utf-8?q?oNclM+O+3i3U6UceZS9QJ2a+gqqyk0Blo1oGiPB3ggWtZ7aPi0nfF7zFNCNoz+Adr?= =?utf-8?q?5D9DG5LbVIAbvKdWRqK2iTcVP5ftQ9hBvmQ5mGh8Dbt5EfpSzggnveumw9Wl3gB7M?= =?utf-8?q?slqoc+HzM7heib4tUUeGl/9wz/pW92YGdOHar5OOreitza2zIrfW6whgSOIcWBdGN?= =?utf-8?q?61koxVCyeNoWojoPCv4Y7tP0/bhWICQxgAnznngtHYObdKpLhNJHpXIb0GbsP+imo?= =?utf-8?q?TFO2iLrX+fUavWdtC81Ve9+ZIVpA17ynUJTRJgw5STSKXqwHAX5DyZU7+H0WNCu3K?= =?utf-8?q?k2TyOYtH5Xj1kuuOdXi/ds5yNOYqne6Mw71xyOGTvk+bwp9+MKNef5kacv7l+muMs?= =?utf-8?q?1dmkSRuPTgOsk4ug6sc+XWJNR1lzHSTEZMLbpwOig3IgmtCRVOv44n72MqLhj/BGi?= =?utf-8?q?ygb4XwL78prtYcGB37tLGeN3+nZmn3pHgrJxHkXhlfcRiN9BAS/vTaa0DNLg6qmLr?= =?utf-8?q?IxyPwKFQP/W6pzN0IAHfXox39rQKJVWx8kH4aakOViQux0xMINuBq3GPE3O80BXzZ?= =?utf-8?q?DpUG3NDDalt952L6LR76TdLx2HfUdTVW1FbXnFUCpGFplyaKC66cPQIkwoP+mxQFW?= =?utf-8?q?uvM3sII51C2hZE7uopP8y1CVKB0UfysSrnHDfAHB+Iezb+LuExJlD53Qx6263mHCn?= =?utf-8?q?kf0Lpi0DyTKKz8iqyHP/U0mmh2HLHI6v4F6SdENeJMV7yEPJbJRYbW86Xy9hQicvr?= =?utf-8?q?8mGMfK5pvZIVN3nhxAwyCwHwlxqSJP7a35psQvJDdR78DrTAL2/yC4GLi7GkI9x/1?= =?utf-8?q?21LsiHTwk9qgfXTfIsRPivazIzyW4PugytB7hzkc4hBL5eRKIGeUTqmWH/Byv64Ra?= =?utf-8?q?Jg4Bx0iCdZl90mymmGSNnc0/wzMBbHDRjBNzNAUBIPNNEAbNjMux7gOCCbOKwVT6J?= =?utf-8?q?f1plObHl/Dke?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: e37195fe-b498-47f9-bd37-08db6b3ac45f X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jun 2023 11:47:15.1388 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: czparCyPdKRU4+qIQv2WeyjQCfRFeWQltMCb5SODLCg6++m+JPbnHPyiy7Qd53Al44frp8hKRJ5mhDCLUucV3w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9424 "rc" is written immediately below the outer if(). Fold the remaining two if()s. Coverity ID: 1532320 Fixes: 685e922d6f30 ("tools/libxc: Rework xc_cpuid_apply_policy() to use {get,set}_cpu_policy()") Signed-off-by: Jan Beulich Reviewed-by: Juergen Gross Acked-by: Anthony PERARD --- The code in question was subsequently moved by 54463aa79dac ("x86/hvm: Disable MPX by default"). --- a/tools/libs/guest/xg_cpuid_x86.c +++ b/tools/libs/guest/xg_cpuid_x86.c @@ -462,17 +462,12 @@ int xc_cpuid_apply_policy(xc_interface * /* Get the host policy. */ rc = xc_get_cpu_featureset(xch, XEN_SYSCTL_cpu_featureset_host, &len, host_featureset); - if ( rc ) + /* Tolerate "buffer too small", as we've got the bits we need. */ + if ( rc && errno != ENOBUFS ) { - /* Tolerate "buffer too small", as we've got the bits we need. */ - if ( errno == ENOBUFS ) - rc = 0; - else - { - PERROR("Failed to obtain host featureset"); - rc = -errno; - goto out; - } + PERROR("Failed to obtain host featureset"); + rc = -errno; + goto out; } /* Get the domain's default policy. */ From patchwork Mon Jun 12 11:47:50 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 13276396 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E7B45C7EE23 for ; Mon, 12 Jun 2023 11:49:48 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.547080.854280 (Exim 4.92) (envelope-from ) id 1q8g39-0001eu-ML; Mon, 12 Jun 2023 11:49:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 547080.854280; Mon, 12 Jun 2023 11:49:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1q8g39-0001en-Jl; Mon, 12 Jun 2023 11:49:31 +0000 Received: by outflank-mailman (input) for mailman id 547080; Mon, 12 Jun 2023 11:49:30 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1q8g1Z-0008F8-Ps for xen-devel@lists.xenproject.org; Mon, 12 Jun 2023 11:47:53 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on062b.outbound.protection.outlook.com [2a01:111:f400:fe0e::62b]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f6d36afd-0916-11ee-b232-6b7b168915f2; Mon, 12 Jun 2023 13:47:53 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB9424.eurprd04.prod.outlook.com (2603:10a6:102:2b2::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.33; Mon, 12 Jun 2023 11:47:52 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e442:306f:7711:e24c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e442:306f:7711:e24c%5]) with mapi id 15.20.6455.039; Mon, 12 Jun 2023 11:47:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f6d36afd-0916-11ee-b232-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mvLXPY/UuRVEiZdNmc2i9Bd1VhMS8sZM+1rwYaMMAXyFErAUi5kxH+Bc9firnll8L4Pc+2ZKZr7gJ4CpL2QiCdDNyPuncoX7VJ944aEnltfOw4v1PjH/jYldcIEb916qLJo1seoLzFUWRw8llPHCNVBW4l9kSgrvrmc3VgEHwaZ4fsqkCFmLH7CZm+jBMnRvxaRincOjjJT9QhMBLGQa6uom0ns3PufLPgwG40aqdHqCuy4UUaokf8O9dVi/ztn8ePn4d3yPiUWMr9Gn+aNeEF52aLGw6bCb4pDvL8eZYG75gURFqFzfhGEaJZDHK+w1srwqEi/TVWMWugA7HT+/fA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AnyjzGqpglbOicW2phJjjVaeWkQi3azKxAQ6SvQhGCQ=; b=kTV4tS7pn9l4+Jsr73aeYLmCk1/kTmWRsmZEnyTLrAs/u1H1Jrb6BAZnYDu8MtclYFudKcMMkD/DuKhmP+l6Oxm7KlzzpK/WuXgA/GNoR/JIw+sj/BqLOcO3VK4KZSAC5SW6DpdywAldU5gL3OzkmRd0+IQR1GCLNq3tCFLNEgJbpeMERwTpBQuqb3Cy8WOV31CcgG+MQdu7XvTOjBfQ+3aXoRVk9ypFYtvuHg2V9veMPM5XVtpLU/qZd3UQhwRzOVGLtxV1chnUeP/n58JtM/wI5ki2cOdp5VpkNDaVNFT5Qh2n6DcdIQ7FxP1g9jfQF1Y9xpwZdHWO610MaCvoRA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AnyjzGqpglbOicW2phJjjVaeWkQi3azKxAQ6SvQhGCQ=; b=WH0jUf9kVTjOvv5FGCnlBxFMSfGJh+32U90cokiWZwEx0vFb1n3Ua7TtZ5carbTOR9IlonlDeRoMTG0L0LZSGOz5MZhLiV/8RoCc59J44xdRrkMNWFnylMxH0+QvcyehVa6e+mOEVWRD+6+GwHC6sk8bkKVYCPhrus7xCk1UKQRIy7Vfyul9QClTkXgQ8tthMkRqL/gt1aNc6LbkHKXLji93H8+Y1RnwAKAmonjY7HIhV9jbmH8NBTd/wjkTyiS3oURiLyJ7a5CoOh5lkIGIgeB3NygHl3wbjOk/C9oS/Fpobv3vXNcHhdiEO/3ok0ToBR2DO0JBegVKB6GbbvxTXw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <4fcbe916-890a-1dfc-86a8-eef2bafb2801@suse.com> Date: Mon, 12 Jun 2023 13:47:50 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: [PATCH 5/5] libxl: drop dead assignment to transaction variable from libxl__domain_make() Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Anthony Perard , Wei Liu , Juergen Gross References: <2dc50b58-a4e4-3e32-1876-94412b14b052@suse.com> In-Reply-To: <2dc50b58-a4e4-3e32-1876-94412b14b052@suse.com> X-ClientProxiedBy: FR0P281CA0224.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:ac::10) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB9424:EE_ X-MS-Office365-Filtering-Correlation-Id: 94e28055-3421-461a-ab8c-08db6b3ada76 X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ebyXXuCzQdQa1HMgNpnvehe90sh/TgzZAZiHEjSmyG78toWYH8CvL554PN1tF8SfB6jeFvmXbIcvi9dQgaFUBTgM9NbqIwWqP0v6bOZHFmlC55jnvdvYd/VYy3xRkSHh+A02iiswwZ5GjQqqbUQGC6b6MwcPPvcPmRAQBpfIcaAS0ezOHiTbh8jbePHVlKg722r05uHUMX9fzWWfbXFVHvTigPUUbSfvo3a7dvXHbeRSJONsRxB//IkVHHBxNdvJQmcdsO5Qkd+CVHDD8lXieJoOwMolrT0rjrxLODvvlnDvx1ufzD5k51Dqp2t74EMdl0c1ATTVHqy86gw8T9cAn4YHnNujeI3PhDejHhso5Y36cNw2jTodxdDYIeKK3V5km1SZavl+0+34vXD7qDDvpu4psPj9olpPqu2vV63G5r9tASMYMl7+MpN47WB8ZUFaXAORfnuTBDsOhvZaV98ak4K5CX6bNq/N7leU3yjB1EOosftTMFDzna0DBsxwp/+FIvfKSYYc3vtHV3N4NRLp4Wek+l+0lGykOFABaoq7cPhxo+oPMJ1pIDPHz8g1lX7zl0F17EViPNWcBhh68CvxCKu+zF1cnM07P2nwralJRXOeVLsZQe//cTHJzHjw21imWwND7VW8OrK/EtuVZfbD1IjsVkwtsLlORonBuEijSQw3G/Iuq975bHGmGTPAUMDO X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(366004)(376002)(346002)(136003)(396003)(39860400002)(451199021)(478600001)(8936002)(107886003)(8676002)(54906003)(6506007)(5660300002)(41300700001)(316002)(6486002)(66556008)(6916009)(26005)(186003)(31686004)(4326008)(6512007)(66476007)(66946007)(2616005)(4744005)(2906002)(38100700002)(86362001)(36756003)(31696002)(101420200003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?M3ZGRScD2pbvs/Xoaf3xgCAk9hUi?= =?utf-8?q?7nDyfqi+zkyOS9WHoh8h4Ajdo8Whuqf0W5RTmJxboPjW+GMS8Y8XWtIXqmPCxzH9J?= =?utf-8?q?okPVXUPe9gH16GZmwuO4Qbq+O4SR7opB8f4qmHTwuXWBOu6giXYuVzOR7BpgRoSbg?= =?utf-8?q?ABOP0MmOM23mpFdxVg5ejZbLfQGFWkqloj8crXP54L7BItKNkglPejvWJLZo/9hP7?= =?utf-8?q?1uNgzX4NIbx8Ma89GnF/3mKhZvvABU8kw9nJdouz35i4dEU2EelfuHrXqfOErL0xZ?= =?utf-8?q?U8SE4eW3twFmr1A57Fr3ctcATWkg/OIvVow7hxn+LrnVVf7XhJqBM944NY8uqsatP?= =?utf-8?q?4Tmy8ZXjcf40yLI2H1LWQtuhxRzLlqRSFmC3DDRqvJetuUFGAOYsbqKLlfY8n7Ba8?= =?utf-8?q?N8Uac+s0Hxh9YgxNiRxuua2PkAS5RIy5zIbqzn7a44snYCT+3CuCfijnp/Zck3zTG?= =?utf-8?q?QdGy65uBB/Rspn3bD0KXi9OgRwtHGwDv0IxTJZ8aURCLB+h/saJTZtb8SqsrJvtkA?= =?utf-8?q?hKAInYnAciRdqKaTdU6VNYXeGK6etd/wpaLUPVtkOkbB3gNuEJgLukBH9G9bm4Aq8?= =?utf-8?q?Bmcsp5DkAGW/8wWX7KWRQmFhm12wR3NzW9PkvqvU9ezhacP8uuLvDHAzShX2l+F+S?= =?utf-8?q?gWVGfYcjxe5ykI29cFcXdqMDt7QJKUbrovpm5G3SxESCbezD3lZOuS6jJ7XTt5VOb?= =?utf-8?q?qRGX2pCOAFG7QukPqN62jGKjF/Js6rnDYz/PtfMO3W0qvAFN6txNXtve2clqlckn8?= =?utf-8?q?T4IYHOvRZlvKEGtNhRF5imxttPnGhaDQDiRtQRhUj4Gm5f4hr1m/PCkLekOIn5qpN?= =?utf-8?q?Kg/QjZpNUhas1aTe4MRnExfmHXClSmOFPbvwbjz97B7yLncJrqIqY7E6G8kunIcas?= =?utf-8?q?rIoZ6F3VDaVZ/aXRrT2D8IRvL3/PqfFCTIPObvL9CUXYG57ExKVU/pwdBTvN6BQ6j?= =?utf-8?q?dA5LD0g/GUB/akLAPWV0HNxDWWBAf62kIQPp33lPAZL+S6zvgnsMZLIKHWbfVo5Bx?= =?utf-8?q?Rh3xNp3r0HYVLIXiqvgRooAs3LoaqZNW/Xl9Gr/OAJdJJzv9YFDoavyYttt5Oq+cW?= =?utf-8?q?gOM2EFPNvw3MCx3gp+8QsylVFqwTNah6pnScHsGqrpYSmw3s9/xdK3hpm+GXyEV0o?= =?utf-8?q?fMWxbLYRY0UcwW7rXMMiVBmpWkRdHIIIhhnTWPHAbIAuoKZGdXH9UssXPtTF61vGK?= =?utf-8?q?VYxv3/pIv8ZJ2fu63BPb0H57HHkYL/FW4lFhSHWFH+1LIXaDIN1HFwojnwesQipZI?= =?utf-8?q?0DTaNYDdNur1cUO2ne7kCRVunxgJY8EuI5KyP03kFjiAGMq031HT8FvUfxxE+Lg9G?= =?utf-8?q?EZz8m+c50IhajTYNhs5V0ZYThJLepLrXOWgmRoF3fl+MjiRYMfxDwNE5PptDAkwWz?= =?utf-8?q?JZgqBzjEtEMQcCnw+IYEssWoHNyuUiPwuGDf2xWZEUy3/hj4PceMbpqyHEtAf0au7?= =?utf-8?q?lkz73JqRu/IHCArM9kP0ozqhsvyVDz7gHYdL6CoYbdQDPyBTBttBOer77vO44GL9T?= =?utf-8?q?m1Pk8jDT8pyC?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 94e28055-3421-461a-ab8c-08db6b3ada76 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jun 2023 11:47:52.1725 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /LFB5LatvAzoi92dNzBAzRQlOmd+sBQwVlqHq8s2NXFREY+h+P24OGSRwchp1NAQP+OrxcVfnlrMPspsPxsiRg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9424 "t" is written first thing at the "retry_transaction" label. Coverity ID: 1532321 Fixes: 1057300109ea ("libxl: fix error handling (xenstore transaction leak) in libxl__domain_make") Signed-off-by: Jan Beulich Reviewed-by: Juergen Gross Acked-by: Anthony PERARD --- a/tools/libs/light/libxl_create.c +++ b/tools/libs/light/libxl_create.c @@ -909,10 +909,8 @@ retry_transaction: strlen(dom_type)); if (!xs_transaction_end(ctx->xsh, t, 0)) { - if (errno == EAGAIN) { - t = 0; + if (errno == EAGAIN) goto retry_transaction; - } LOGED(ERROR, *domid, "domain creation ""xenstore transaction commit failed"); rc = ERROR_FAIL; goto out;