From patchwork Tue Jun 13 08:52:50 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yunlei He X-Patchwork-Id: 13278166 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4A3F0C77B7A for ; Tue, 13 Jun 2023 08:53:26 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-3.v29.lw.sourceforge.com) by sfs-ml-3.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1q8zmG-0000WP-HH; Tue, 13 Jun 2023 08:53:24 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-3.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1q8zmE-0000WJ-Tn for linux-f2fs-devel@lists.sourceforge.net; Tue, 13 Jun 2023 08:53:23 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=MIME-Version:Content-Type:Content-Transfer-Encoding :Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=nDS93DPhDN5ULBsF3WoR/o9cKItNLzIXPkMTHV0ui04=; b=KSHGuF15z0aheb5go4sQVGJ9cI dccQo3YJNjjLemuN1uRY4YcvtRj9JF0JlxPVfTjpHAJfhLaT+r+w8s0RHtSiq13dzeovCKfLf5/lq U5P7AQLoszIegaSFK7o9maVEWqoejPs6l43k+pLIBDzHkus8SNct7uCuOSUt5XVGd8r8=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Date: Subject:Cc:To:From:Sender:Reply-To:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post: List-Owner:List-Archive; bh=nDS93DPhDN5ULBsF3WoR/o9cKItNLzIXPkMTHV0ui04=; b=g yrZjOEOtXhD03Xm1iUiwbuNKAy62WjictRxVN2DOI883XL/oh93HRdah0gnXOebLVrdvOs5/uqjfk N0x9mYEek2T1MBCldbtVaXyk1ZrXf6CBGj0vxJXgjB0XyEAt5fI33Zg0aYFt9CiUC8eEjvZYnt3Oc RShVYJx1isJwwaoE=; Received: from mail-sgaapc01on2053.outbound.protection.outlook.com ([40.107.215.53] helo=APC01-SG2-obe.outbound.protection.outlook.com) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1q8zmA-0001OB-Nx for linux-f2fs-devel@lists.sourceforge.net; Tue, 13 Jun 2023 08:53:23 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dZu4KjbjDHIMlbRcHdlVEl8w+3mZ+ail4gxtt8nX6w7Hlgi/bh+dpsk6mm8w7NpdUzZ4pjEg6D5c37qzBqVGmg622s4tMsTC1mi7WHTogikq/0evLPP7n/8/sqr3+GGH4y1oFMnEp52HqeW6U+wQp+Li6zjRvEDlQ1NT5iQ8ZNgnX6adibPu05mh9Elo8YKC5LDFwn8f5xaqoF5uIG9GTyMVUH1BNa0xw8AK6eLrWgZkZh1taEJAw+h/Z0yR+7KuGf+E0Td7cZ6uHnpTYnjE7FZ5+O2YDgxMr1x9xKBGMYpLATgMQch8oHG3yGn8nX+FBEaBM25Er4SeCsJIs/scSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nDS93DPhDN5ULBsF3WoR/o9cKItNLzIXPkMTHV0ui04=; b=HNUOHTwPH98NWgyokQNvZgCcI+bvLsWTaOA+P6cfCoGhxFuWDiluc2nWPEiJE0udYJXXGZLBfkJbIVskMgY6Yt5eS9lHFhrRFziRIdmFXctvfHEFn4DjXgl5RqtvyQySwJQAvYJt24hom3Jc+QIIyEy0J5bKSVg3g75sra0/n4doZO/unrC/VAWk9oFW+UlSx+TpCoYw/xY1NW20/dxtTkVOiWxpM1CdoOeyI1al2vYI8NxiDxKpNxHRz5IlzudE59kzA79UdBkkbX/oOnnRXIWw8eCvTURkVOFQCmQR5e01T7F2rSMS2qxcYDiwIGlN0J2qBWiQDRb3cLJcuGLEzA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oppo.com; dmarc=pass action=none header.from=oppo.com; dkim=pass header.d=oppo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oppo.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nDS93DPhDN5ULBsF3WoR/o9cKItNLzIXPkMTHV0ui04=; b=iWFeCgJLLt748iJu/1eGEobvRgWPfsxBSYB5+LQxEjcftgE8A/cQddmfon6WcSy9An2U654cWF8RmNUqEYfL2VCzyZcw7AlZA8UaQXr0RDA0weZcJ8uahN+8DaQ9y85oJn6l58ZcX3FQXLqe1hMupGupikFKZVt9x+L2TG3g8B0= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oppo.com; Received: from TY2PR02MB4479.apcprd02.prod.outlook.com (2603:1096:404:800e::7) by SI2PR02MB5049.apcprd02.prod.outlook.com (2603:1096:4:15e::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6500.21; Tue, 13 Jun 2023 08:53:04 +0000 Received: from TY2PR02MB4479.apcprd02.prod.outlook.com ([fe80::bc4a:4d7a:4c73:76eb]) by TY2PR02MB4479.apcprd02.prod.outlook.com ([fe80::bc4a:4d7a:4c73:76eb%4]) with mapi id 15.20.6500.020; Tue, 13 Jun 2023 08:53:04 +0000 To: jaegeuk@kernel.org, chao@kernel.org Date: Tue, 13 Jun 2023 16:52:50 +0800 Message-Id: <20230613085250.3648491-1-heyunlei@oppo.com> X-Mailer: git-send-email 2.40.1 X-ClientProxiedBy: SI1PR02CA0055.apcprd02.prod.outlook.com (2603:1096:4:1f5::16) To TY2PR02MB4479.apcprd02.prod.outlook.com (2603:1096:404:800e::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: TY2PR02MB4479:EE_|SI2PR02MB5049:EE_ X-MS-Office365-Filtering-Correlation-Id: 6cad789d-0448-4d34-49f1-08db6beb99d6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: w4EQU7pyZWgNNhJNd/E55i81yDz1nZr7azW0WO4/WgvYhamTTuI7dnSNsVx67NhRlu6hOPBXWgbt8l5M85pI9gV+MKHIuZwPu2u0UvFSHP5LOgsIiLMsalHyDDoofMgjI3tClY1kQs9+UfXc6vIhh4qZJbUuVC+XWBZWT4bN8qm13Awjd/Sc6fKkDaz0XllefhQx7Z8xixuE+awrbG5haPoQeUiE5zTz303US8Um7gKm0F729Y74rNTb4d8HzfBYWt2apU4VHZzXCHHXqF067nAntYw/zksirdKfGStd0wgTct6m0scZCkKKzKsbBlmi3hLlTWEGomUsTO1Xn8R2XfaeT6ztOUmSyZyuQzmqUPYFbfcGLxC0+LyPuiKYE90eTz2Ytpdc/oQ5DfKXbcm2Imdrxzo1R9SI7gQhDqIc2xmgUzkZTwITPkVU1MJnYCxBg2n6bY5cYD5QCjamkTU4uNXMwfjOBqOAK2T3MV6I5aaUM5fpQjzFApFzqvo21IZM+1T0YxFqXM66Pl50IYyq70+liwGmcXtipQAn7iygw5asTDBPwh5VV2o+vov0gzDqRdEqvXavg1GlBu41v832TOAMKLkL71Swa7qNw3Va05UWn/iSzN0vvTATl3IJkOnD X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:TY2PR02MB4479.apcprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(39860400002)(376002)(346002)(136003)(366004)(396003)(451199021)(5660300002)(66946007)(66556008)(4326008)(8936002)(8676002)(41300700001)(316002)(186003)(2906002)(478600001)(66476007)(6666004)(107886003)(52116002)(6486002)(1076003)(6512007)(6506007)(26005)(83380400001)(36756003)(86362001)(2616005)(38350700002)(38100700002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: cHGUxKSQqBMZD7f4l7B9MjdHLUtJKbKKebfOgUVE8yFipjrq2krRYGXBmrykmbMQ9TlRJSaYxWKhJgOhiyaxjoNl9gVT0Xyoo5qwYIOCZyKzFDEv5Aw5DgzyfiCyb1+DdUGP85Vyw4Et6Unna7xCMvKORrc5Spi+2NRI5nof7bHGKcjY7MNx/a91YDHiATqmCs74EPuZGDpsXkkH4y8QaKyI7L0yWtBSFkjtSX6o/8UzGJFpWbA03EvEkIC7eoIb4znCaUJIKl8oW2tJJp+hlfm1a9p6bX+kh+8pKKEhP2P4uLW0P2O78cHg7h/NDpLgLjuXu/DNm+xDHtkzGHli3CnBVu+zgltjAAJG0pjhXvvaxdtvZXXylcFZwb/OCblHEv+KUyRwRKgGoaMfwDQHZfk4TKV1sxaSO0ASg4DVP972SFImFdJlWjTR7CIeJg7O3bf7M/eRraqW0qj3ipMANojmSyIWmDyNCvspLu81z5eMVp83HhiewSOnGm3hCCcdYKBOIjSfh/cLmDhQ68OP2tc8WRSzB/qX7qU2RI3IVoPKlMC36sihBolnP2WFFujIw1qSBHR1ap7ICQ1xREorVjOYy8OMHakipVRq2IaEIRIIyh3v5IQekIkLSQZT5cr4lzmrmGdoYtO/IysAuVrCKQpX/kpgQyIm8CEox/AWLLBIcvMsKFgv4yE/uETU5EIpug+yhHxe/mES9+YU6W+pQRs3DzZ5APd043mPpXiooTw2wOLH5jXZ64TSogPUhcUH44eMKSrQ/TDtOpxUTrHSb7EST5E44mGvjdrQg98XTCRz5SyoQxg95AWb35GwAe+Jr3aTFdAzuq3iXZRkpho4biS8bylUVJ1SGzw1CBwTusSHMBIa7UMoTdNfKTZBm4qmDX2m4YRbnIA3hyB8wBem+mbZ21P7FACRpvG0L8MUc5nEbwuNxrdSqDu2KbprorF3oM3+0FXbTNIRWzogT3idd04xcZihyvX4V1MOOFfsWtYnKmZr6dwzPLK4qfxYQE9uTpSvdb+XlwoS3y+CiqVYR6o1pj1tbtdoSOvTR3jV2qZKqULrhswboVXEsCIexXqlr1AYE/2wd3hyip+nSYBH13ewzDCp30360cMGMhZAQbIbJAeTj9CNbOIGrUyvxpbWUDO1d8tRRBVgNoID5lg8ZcibHiENyw4F75irkDiar2QxEmnOFkQZU6yv1RIv8hv+qJhz1JqKMRIP/CnRtHA5aN7XpoSjZH/V6XKNuPcikZFf0XX1Dan6ccC1c1Smm1f256Fsa8i4jm6MnT8nHlhFWXdoWeoms2afyFgP0m2HlbKmIpFe8qOs6S0kv3D1t0gjYNJ5jfEmFa45X+MTIr+OMqd8EFXEyac4wwt6YACvnnBgyX67OaM1vvbZVAe+Fu39FlHVgOnNMtrGksqCgxJD/BEYpJ1JoCBgJwGl6/Fm2tZpZ63r3kO50Y7jSY3NHv010AOsyA/qVhcPFt3xElehGRv/XBPFTLbHwgPJz3XRBTZRhBSbAJCLmaA3Xe2W92Agf7MZ9ZXIFYd8kVckORVxamSCMl5U+W1xnleVX++sD/FdTd5P8n8ukHw5AFxAP7Vc X-OriginatorOrg: oppo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6cad789d-0448-4d34-49f1-08db6beb99d6 X-MS-Exchange-CrossTenant-AuthSource: TY2PR02MB4479.apcprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jun 2023 08:53:04.8135 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f1905eb1-c353-41c5-9516-62b4a54b5ee6 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: JvbMWNE8gsyqYHAzzE8+WSxHJ/Z++KHGB+Lb8CFYfY+xDK52YWTST8GySbWMurg/ABsGvRgS3Au9S1U7AUqYJg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SI2PR02MB5049 X-Headers-End: 1q8zmA-0001OB-Nx Subject: [f2fs-dev] [PATCH] f2fs: not allowed to set file both cold and hot X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Yunlei He via Linux-f2fs-devel From: Yunlei He Reply-To: Yunlei He Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net File set both cold and hot advise bit is confusion, so return EINVAL to avoid this case. Signed-off-by: Yunlei He Reviewed-by: Chao Yu --- fs/f2fs/xattr.c | 3 +++ 1 file changed, 3 insertions(+) -- 2.40.1 diff --git a/fs/f2fs/xattr.c b/fs/f2fs/xattr.c index 213805d3592c..917f3ac9f1a1 100644 --- a/fs/f2fs/xattr.c +++ b/fs/f2fs/xattr.c @@ -127,6 +127,9 @@ static int f2fs_xattr_advise_set(const struct xattr_handler *handler, return -EINVAL; new_advise = new_advise & FADVISE_MODIFIABLE_BITS; + if ((new_advise & FADVISE_COLD_BIT) && (new_advise & FADVISE_HOT_BIT)) + return -EINVAL; + new_advise |= old_advise & ~FADVISE_MODIFIABLE_BITS; F2FS_I(inode)->i_advise = new_advise;