From patchwork Wed Jun 21 09:09:54 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joel Granados X-Patchwork-Id: 13286912 X-Patchwork-Delegate: kuba@kernel.org Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 847C7C8C7 for ; Wed, 21 Jun 2023 09:10:20 +0000 (UTC) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5C75A19AE for ; Wed, 21 Jun 2023 02:10:16 -0700 (PDT) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20230621091015euoutp0294f390bd817c6ddd41696db47224981b~qoYfVxpNY0948409484euoutp02x for ; Wed, 21 Jun 2023 09:10:15 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20230621091015euoutp0294f390bd817c6ddd41696db47224981b~qoYfVxpNY0948409484euoutp02x DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1687338615; bh=OWywfsEHW6wNB9csZSR6nbz7s47Wj0frTeIAnopGDR4=; h=From:To:CC:Subject:Date:In-Reply-To:References:From; b=KSH/H253lKqtKFMDmm8dEdmUj6T6OKFK6Jk8h6UJtHuMTa3CciVENHtKMbLVYwTVd XfOJJdqx2xMDgqj3gTPSlO6avC/i7vleGoAbCN9HcZ3rhLBdLg4QxNeUPREFgUx3mn H3M/DG/ph+jBxp6owAHJ3aYJ1AymgZQIlf3RrZcY= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20230621091014eucas1p1f04da8b1fb1dad1e10c0b30185138bc7~qoYez4JUH2864928649eucas1p1H; Wed, 21 Jun 2023 09:10:14 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id 35.8E.11320.67EB2946; Wed, 21 Jun 2023 10:10:14 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20230621091014eucas1p1a30430568d0f7fec5ccbed31cab73aa0~qoYeXJLcA3218932189eucas1p17; Wed, 21 Jun 2023 09:10:14 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20230621091014eusmtrp258b508b40395627575162a2d27af0935~qoYeWjday2207922079eusmtrp2a; Wed, 21 Jun 2023 09:10:14 +0000 (GMT) X-AuditID: cbfec7f4-97dff70000022c38-a5-6492be760730 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id B9.0F.10549.67EB2946; Wed, 21 Jun 2023 10:10:14 +0100 (BST) Received: from CAMSVWEXC02.scsc.local (unknown [106.1.227.72]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20230621091013eusmtip175549cf05b6fa79e82b1c8d646058274~qoYeM01d-2702427024eusmtip1e; Wed, 21 Jun 2023 09:10:13 +0000 (GMT) Received: from localhost (106.210.248.248) by CAMSVWEXC02.scsc.local (2002:6a01:e348::6a01:e348) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 21 Jun 2023 10:10:13 +0100 From: Joel Granados To: , Kees Cook , Iurii Zaikin , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni CC: Joel Granados , , , Subject: [PATCH 05/11] sysctl: Add a size arg to __register_sysctl_table Date: Wed, 21 Jun 2023 11:09:54 +0200 Message-ID: <20230621091000.424843-6-j.granados@samsung.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230621091000.424843-1-j.granados@samsung.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Originating-IP: [106.210.248.248] X-ClientProxiedBy: CAMSVWEXC01.scsc.local (2002:6a01:e347::6a01:e347) To CAMSVWEXC02.scsc.local (2002:6a01:e348::6a01:e348) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrGKsWRmVeSWpSXmKPExsWy7djP87pl+yalGNzqlLGYc76FxeLpsUfs Fme6cy0ubOtjtdiz9ySLxeVdc9gsbkx4ymhxbIGYxbfTbxgtlu30c+DymN1wkcVjy8qbTB4L NpV6bFrVyebxft9VNo/Pm+QC2KK4bFJSczLLUov07RK4Mp6ffM9SMFOzYvOptWwNjE1KXYyc HBICJhKTp21j6mLk4hASWMEocXHLbVYI5wujxNK/x9lAqoQEPjNKXD6uCNMxqeklG0TRckaJ 1f/PQzlARU+XbGeGcLYySmzaOAesnU1AR+L8mztgCRGQqsN/9zKBJJgF2hklTnzPA7GFBTwk Nj/YwAhiswioSjQfe8sOYvMK2EjMa7rKBLFbXqLt+nSwGk4BW4nzj9+zQNQISpyc+YQFYqa8 RPPW2cwQtoTEwRcvmCF6lSWu71vMBmHXSpzacgvsawmBdk6JvT9fskMkXCTaH9+EsoUlXh3f AmXLSPzfOR+qYTKjxP5/H9ghnNWMEssav0KdZy3RcuUJVIejxJn7m4FO5QCy+SRuvBWEuIhP YtK26cwQYV6JjjahCYwqs5D8MAvJD7OQ/LCAkXkVo3hqaXFuemqxUV5quV5xYm5xaV66XnJ+ 7iZGYFI6/e/4lx2My1991DvEyMTBeIhRgoNZSYRXdtOkFCHelMTKqtSi/Pii0pzU4kOM0hws SuK82rYnk4UE0hNLUrNTUwtSi2CyTBycUg1MW1l+274InHjs+RLZOuXEvSWNdmrtPlLXe2/f YFf/wdpz2vNHt2P1tmwh1+cMm7jc9pltS110PeSwgfCqMx2bP/6YYTnzd8vpmCSZ5T2lRme4 tu5POP51y7aYwkl515bM/l/0wv7v/1jlrVejrxnoPXRyOmqaeWP3hkcndji+KvbP5Hne0Mlz ZMNLman7uIV9Hv7RKro7tVfLem3vhSa99ef2Zwa4fyo9om7OujmIP6Hh2irzyecZTuj0hO25 rrr5l6hxxNdFc6WLDuyxL2p8rru77OkuU6uUZQn85x7Y99oZ7FLNDOsy7pqiG2BxeX1T7ZKb hidaPKzmd/yJajzRlJlx9MgfFyGNJr7/UQ1qSizFGYmGWsxFxYkA+2Nb17kDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrHIsWRmVeSWpSXmKPExsVy+t/xu7pl+yalGFz6zGwx53wLi8XTY4/Y Lc5051pc2NbHarFn70kWi8u75rBZ3JjwlNHi2AIxi2+n3zBaLNvp58DlMbvhIovHlpU3mTwW bCr12LSqk83j/b6rbB6fN8kFsEXp2RTll5akKmTkF5fYKkUbWhjpGVpa6BmZWOoZGpvHWhmZ Kunb2aSk5mSWpRbp2yXoZTw/+Z6lYKZmxeZTa9kaGJuUuhg5OSQETCQmNb1k62Lk4hASWMoo sez3PRaIhIzExi9XWSFsYYk/17qgij4ySszfPpMdwtnKKHHn6itGkCo2AR2J82/uMIMkRAQ+ M0oc/ruXCSTBLNDOKHHiex6ILSzgIbH5wQawBhYBVYnmY2/ZQWxeARuJeU1XmSDWyUu0XZ8O VsMpYCtx/vF7sJOEgGrmf7jMCFEvKHFy5hMWiPnyEs1bZzND2BISB1+8YIaYoyxxfd9iNgi7 VuLz32eMExhFZiFpn4WkfRaS9gWMzKsYRVJLi3PTc4sN9YoTc4tL89L1kvNzNzECI3bbsZ+b dzDOe/VR7xAjEwfjIUYJDmYlEV7ZTZNShHhTEiurUovy44tKc1KLDzGaAv05kVlKNDkfmDLy SuINzQxMDU3MLA1MLc2MlcR5PQs6EoUE0hNLUrNTUwtSi2D6mDg4pRqYpt4wcW7gbtvyd5XO knfBGX+mJNvEPG2y1Mralmmd17wpRfDAzh1Bl3x3/r/0+Z3G75zj0ZtqdSK2ejXffCORxx/v F/UjrnFShJve+t/SnjvmR0+cYpjo6v78rcenfS+9k22eum//xqyaMzMs1iXyKMP+U6F5cssf n1oSoO2+4dvxLwazY4NmfzkaK+36LsW/+4z20kg9hxneU9Tq10+qLP4mfeWy5LW4IxM+Zm/Q DjJpZE3Y9e5/b3L2zWeGteclTq6zuOD9Imz+TZPQH6cK+d+ErH+m1fQzyVo6bJOYonv3nryI U4d26Sp/snok5qak/68o46ZXpzG3m2hOnWthdmhR2zKFZ6b970NeR3YqsRRnJBpqMRcVJwIA PC6WYmEDAAA= X-CMS-MailID: 20230621091014eucas1p1a30430568d0f7fec5ccbed31cab73aa0 X-Msg-Generator: CA X-RootMTR: 20230621091014eucas1p1a30430568d0f7fec5ccbed31cab73aa0 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20230621091014eucas1p1a30430568d0f7fec5ccbed31cab73aa0 References: <20230621091000.424843-1-j.granados@samsung.com> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net X-Patchwork-Delegate: kuba@kernel.org In order to remove the end element from the ctl_table struct arrays, we explicitly define the size when registering the targets. __register_sysctl_table is the first function to grow a size argument. For this commit to focus only on that function, we temporarily implement a size calculation in register_net_sysctl, which is an indirection call for all the network register calls. Signed-off-by: Joel Granados --- fs/proc/proc_sysctl.c | 22 +++++++++++----------- include/linux/sysctl.h | 2 +- ipc/ipc_sysctl.c | 4 +++- ipc/mq_sysctl.c | 4 +++- kernel/ucount.c | 3 ++- net/sysctl_net.c | 8 +++++++- 6 files changed, 27 insertions(+), 16 deletions(-) diff --git a/fs/proc/proc_sysctl.c b/fs/proc/proc_sysctl.c index 09c09c373624..8c415048d540 100644 --- a/fs/proc/proc_sysctl.c +++ b/fs/proc/proc_sysctl.c @@ -1354,27 +1354,20 @@ static struct ctl_dir *sysctl_mkdir_p(struct ctl_dir *dir, const char *path) */ struct ctl_table_header *__register_sysctl_table( struct ctl_table_set *set, - const char *path, struct ctl_table *table) + const char *path, struct ctl_table *table, size_t table_size) { struct ctl_table_root *root = set->dir.header.root; struct ctl_table_header *header; - struct ctl_table_header h_tmp; struct ctl_dir *dir; - struct ctl_table *entry; struct ctl_node *node; - int nr_entries = 0; - - h_tmp.ctl_table = table; - list_for_each_table_entry(entry, (&h_tmp)) - nr_entries++; header = kzalloc(sizeof(struct ctl_table_header) + - sizeof(struct ctl_node)*nr_entries, GFP_KERNEL_ACCOUNT); + sizeof(struct ctl_node)*table_size, GFP_KERNEL_ACCOUNT); if (!header) return NULL; node = (struct ctl_node *)(header + 1); - init_header(header, root, set, node, table, nr_entries); + init_header(header, root, set, node, table, table_size); if (sysctl_check_table(path, header)) goto fail; @@ -1423,8 +1416,15 @@ struct ctl_table_header *__register_sysctl_table( */ struct ctl_table_header *register_sysctl(const char *path, struct ctl_table *table) { + int count = 0; + struct ctl_table *entry; + struct ctl_table_header t_hdr; + + t_hdr.ctl_table = table; + list_for_each_table_entry(entry, (&t_hdr)) + count++; return __register_sysctl_table(&sysctl_table_root.default_set, - path, table); + path, table, count); } EXPORT_SYMBOL(register_sysctl); diff --git a/include/linux/sysctl.h b/include/linux/sysctl.h index 33252ad58ebe..0495c858989f 100644 --- a/include/linux/sysctl.h +++ b/include/linux/sysctl.h @@ -226,7 +226,7 @@ extern void retire_sysctl_set(struct ctl_table_set *set); struct ctl_table_header *__register_sysctl_table( struct ctl_table_set *set, - const char *path, struct ctl_table *table); + const char *path, struct ctl_table *table, size_t table_size); struct ctl_table_header *register_sysctl(const char *path, struct ctl_table *table); void unregister_sysctl_table(struct ctl_table_header * table); diff --git a/ipc/ipc_sysctl.c b/ipc/ipc_sysctl.c index ef313ecfb53a..8c62e443f78b 100644 --- a/ipc/ipc_sysctl.c +++ b/ipc/ipc_sysctl.c @@ -259,7 +259,9 @@ bool setup_ipc_sysctls(struct ipc_namespace *ns) tbl[i].data = NULL; } - ns->ipc_sysctls = __register_sysctl_table(&ns->ipc_set, "kernel", tbl); + ns->ipc_sysctls = __register_sysctl_table(&ns->ipc_set, + "kernel", tbl, + ARRAY_SIZE(ipc_sysctls)); } if (!ns->ipc_sysctls) { kfree(tbl); diff --git a/ipc/mq_sysctl.c b/ipc/mq_sysctl.c index fbf6a8b93a26..ebb5ed81c151 100644 --- a/ipc/mq_sysctl.c +++ b/ipc/mq_sysctl.c @@ -109,7 +109,9 @@ bool setup_mq_sysctls(struct ipc_namespace *ns) tbl[i].data = NULL; } - ns->mq_sysctls = __register_sysctl_table(&ns->mq_set, "fs/mqueue", tbl); + ns->mq_sysctls = __register_sysctl_table(&ns->mq_set, + "fs/mqueue", tbl, + ARRAY_SIZE(mq_sysctls)); } if (!ns->mq_sysctls) { kfree(tbl); diff --git a/kernel/ucount.c b/kernel/ucount.c index ee8e57fd6f90..2b80264bb79f 100644 --- a/kernel/ucount.c +++ b/kernel/ucount.c @@ -104,7 +104,8 @@ bool setup_userns_sysctls(struct user_namespace *ns) for (i = 0; i < UCOUNT_COUNTS; i++) { tbl[i].data = &ns->ucount_max[i]; } - ns->sysctls = __register_sysctl_table(&ns->set, "user", tbl); + ns->sysctls = __register_sysctl_table(&ns->set, "user", tbl, + ARRAY_SIZE(user_table)); } if (!ns->sysctls) { kfree(tbl); diff --git a/net/sysctl_net.c b/net/sysctl_net.c index 4b45ed631eb8..8ee4b74bc009 100644 --- a/net/sysctl_net.c +++ b/net/sysctl_net.c @@ -163,10 +163,16 @@ static void ensure_safe_net_sysctl(struct net *net, const char *path, struct ctl_table_header *register_net_sysctl(struct net *net, const char *path, struct ctl_table *table) { + int count = 0; + struct ctl_table *entry; + if (!net_eq(net, &init_net)) ensure_safe_net_sysctl(net, path, table); - return __register_sysctl_table(&net->sysctls, path, table); + for (entry = table; entry->procname; entry++) + count++; + + return __register_sysctl_table(&net->sysctls, path, table, count); } EXPORT_SYMBOL_GPL(register_net_sysctl); From patchwork Wed Jun 21 09:09:55 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joel Granados X-Patchwork-Id: 13286913 X-Patchwork-Delegate: kuba@kernel.org Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3A2AED2EA for ; Wed, 21 Jun 2023 09:10:34 +0000 (UTC) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DF1011BF5; Wed, 21 Jun 2023 02:10:25 -0700 (PDT) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20230621091023euoutp01ec65ee83be0b4972b071be6b6ce46ddd~qoYnSztar1413414134euoutp01V; Wed, 21 Jun 2023 09:10:23 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20230621091023euoutp01ec65ee83be0b4972b071be6b6ce46ddd~qoYnSztar1413414134euoutp01V DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1687338623; bh=1jgxo9l2TtPgCBIdPe/y+ojPYkgw4g2+N3N/h90OAdE=; h=From:To:CC:Subject:Date:In-Reply-To:References:From; b=rc2oPNlJp42Fpp8u3rDtoPvzPqisaQYsIMpfprmtb7MP8tuJ9U2DITmdFrRyh/Qzc pT0tpbD15aITOcFnJmRIyANBOAePJqI0eBRt9OPkUkkR8nwz853xesTVcq38ltVct+ co62GQHfMbXW3m9DCqqdfu7acJ67HlfjK3RPgyGg= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20230621091023eucas1p122d19ce002f66c6e8a0adbd2e3a30ad4~qoYmz9mgx2848828488eucas1p1W; Wed, 21 Jun 2023 09:10:23 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id BF.8E.11320.E7EB2946; Wed, 21 Jun 2023 10:10:23 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20230621091022eucas1p1c097da50842b23e902e1a674e117e1aa~qoYmASvrd0547605476eucas1p1v; Wed, 21 Jun 2023 09:10:22 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20230621091022eusmtrp236bd2250119bdac5fe33daa3c529b4fd~qoYl7iO_G2182221822eusmtrp2g; Wed, 21 Jun 2023 09:10:22 +0000 (GMT) X-AuditID: cbfec7f4-993ff70000022c38-c8-6492be7e5d77 Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id CF.0F.10549.D7EB2946; Wed, 21 Jun 2023 10:10:22 +0100 (BST) Received: from CAMSVWEXC02.scsc.local (unknown [106.1.227.72]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20230621091021eusmtip237d1f3e24e19ae8cad088c863d5c07c2~qoYlj-NWC1796317963eusmtip2T; Wed, 21 Jun 2023 09:10:21 +0000 (GMT) Received: from localhost (106.210.248.248) by CAMSVWEXC02.scsc.local (2002:6a01:e348::6a01:e348) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 21 Jun 2023 10:10:20 +0100 From: Joel Granados To: , Jason Gunthorpe , Leon Romanovsky , David Ahern , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Joerg Reuter , Ralf Baechle , Pablo Neira Ayuso , Jozsef Kadlecsik , Florian Westphal , Roopa Prabhu , Nikolay Aleksandrov , Alexander Aring , Stefan Schmidt , Miquel Raynal , Steffen Klassert , Herbert Xu , Matthieu Baerts , Mat Martineau , Simon Horman , Julian Anastasov , Remi Denis-Courmont , Santosh Shilimkar , David Howells , Marc Dionne , Neil Horman , Marcelo Ricardo Leitner , Xin Long , Karsten Graul , Wenjia Zhang , Jan Karcher , Jon Maloy , Ying Xue , Martin Schiller CC: Joel Granados , , , , , , , , , , , , , , , , , Subject: [PATCH 06/11] sysctl: Add size to register_net_sysctl function Date: Wed, 21 Jun 2023 11:09:55 +0200 Message-ID: <20230621091000.424843-7-j.granados@samsung.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230621091000.424843-1-j.granados@samsung.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Originating-IP: [106.210.248.248] X-ClientProxiedBy: CAMSVWEXC01.scsc.local (2002:6a01:e347::6a01:e347) To CAMSVWEXC02.scsc.local (2002:6a01:e348::6a01:e348) X-Brightmail-Tracker: H4sIAAAAAAAAA01TaVBTVxid++7LAkzkERy5RTtMUWq1LRZb8ZtWOtBlfNp2yg+tDD+0EV4R FGQIoNRRgYCyFA1LoQHKYlmCbDMQgoACpcomNVbQIIIoEEVEoixKokAJoR3+nfOd79x7zp25 QiwuFdgL/YNCuZAgyRFHviWtbjVoPjzdmOL7UWwlBS2R26G97J4A5urOYph6+JgH2ZoYGua0 iXyYiH5NQ0V9LAW61iEBqJNKESSOrQNZzQyCkfNDPOgpes4HxW/tCAZnhmgwnLMCRYKMAn16 FgU31ed4kGYsxCDvdIE7tQMUdNdn8+FRSxIN8nwZBl3eUx70pxbR0HwlF8FQpZ4CWe4kBtnU MAajso0HN5IWMCi7HlHQK9ch+OtsIw+6KqMF8DKnHUNr3hqQV3TS0Cfr4MPL6+MIMsZvY7h1 eQN0Ti9QcKN6igdT2e/BQ7mGhlSlioKG+FkBqDQBENWlFsCwVovdXdm+oRnMTtzoQGxO2QnW aNjMqkruUmzi1THM1mUOCFh1sxObVxXGVl2M57PXSsopVn6hGbHVBafZ1N5ixI5WKxDbkDdF eTp4W+7w5Y74h3MhWz7/0fLQ6O9dvGB1CXVc+SKNF4nyZ1ACEgoJ8wkxGkITkKVQzCgRKczN wAnIYpFMI6L/daNZmEJk5FYXbRJMhgdpSsosFCNinE+j/t96cvvJMqlBpCy1gGey8JkPiGa8 H5uE1UyOFSnOmRSYCGau0ORxZhFlSmLL7CTqGGuTgWaciGoslmcai5gdpP+O0Hy1AzmjzUAm bMG4Ec2wfimSiLEhHYqRJYwXd2Q1WdiMCflzdBSbveuJtvEPvhmfJJ2qPsqM9VZkrvpbM/6K jCruL+/bkrE2lcCM15GFutylYoRJRaRp/rnATEoRKYqaWT7pMxLTM7Ls8CDRcxew+YVXkd5n NuZAq0iKOmN5LCJxZ8RytCFzRYXMFRUyV1TIQ/gisuPCpIF+nHRrEHfMWSoJlIYF+Tn7HA2s Qov/6fp82/QlVDz2wrkFUULUgogQO64WvV2V4isW+UoifuZCjh4ICTvCSVvQWiHtaCd6363D R8z4SUK5wxwXzIX8p1JCC/tIyvNpcsMbL/pVc7mkLa4x3Ekp13dPBrpHnYg/Tpef8radb5H/ MpB8UFjwd8pYrf5gfOZPuq3Z/JtNYtWnxn8qXUq/uV87Z19z7UtdhIe2ljWuv3VYa+0Qli7u H4zw2Ktz3/46TnjbiZu3hWqbQG2Ev0Xz7E0fJ7cqvCkyumGbNPwL2URP39fus4mhl04OezQd +z6gUOP6YEtFyu7OWpFdZNpghiu+t7vWUO/bp6vbv59Ys3d69/WRtxw7ug2Wz15t3JNwzv7U AYMyFIK91m9amyTJz756frJAMbqnS1/i7bUvOpn4GiPu7tr17jvayHS+4s13nmF7mYCsdBy+ 5uNtl38YdKSlhyQum3GIVPIv28QTHr4EAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA02TeVDUZRzGfX/H7iKz+QOW/A3pqEtYGaws55dAImvs1zQ1/GFZNgQ7sMMR V7vgeJCgCxhnyzEqy7WgLKAGscAKkgxuxH1Eq2AGIfcZhwskJBKw0wz/Pe/zfT/PM9+Z9+Xg pg9ZFpzA0AixJFQUzGftJtpfNv9lc7E+3c92Xo2DNsYZWu78yYb12is46IcmSMjpjiVgvS+J BXOX/yWg7F4cBmNNw2zQpNxGkDS9D2TVywhGfxgm4aFqgQVZ11sQDC4PE7CaagxZiTIM5q9m Y/CbJpWEzLUiHORtQui9O4CB7l4OC8a1KQTIC2Q4jClnSOjPUBHQcD8fwXD5PAay/Gc4yPQj OKyVNJPQlbKBQ0nHOAaP5WMIfrlST0JH+WU2rOS14NCkfBXkZW0EPJG1smClfRbBtdlHOPz+ 8+vQtrSBQVelngR9zpswJO8mIKOkCoO6hOdsqOoOgksdGjaM9PXhHk7Mk+FlnJnrakVM3p0L zNrqEaaq9A+MSWqcxplaxQCb0TRYMUp1JKO+lcBifi39EWPkhQ2IqbwZzWQ8LkbMZGUWYuqU eszzwGmBmyQsMkJ8MCBMGnGM/5UQ7ARCFxDYObgIhPbOXu/YOfKPurv5iYMDz4glR919BAGT uR1kuKYUO1uymEnGoIJllIiMODTlQD/NLMES0W6OKVWE6J7SGcIw2EdXLD0iDdqMftGbyNrS ptQiouOVbxuAakSX5hZsJ7Eoa7p7th/fGvCoPGM65YEabR1w6j5BTyhUmx0cjhn1Ia2J3bMF EJQVXTUdR27ZXMqN7u/lGMoO0PF917YzjahjdPfIPGEodqPzF3TbPpcyoVuzRrd9fPO+rDob N2iafjA5iRtyLOm++hssg/6O1q+PIzniKXbgih24YgeuRPgtxBNHSkP8Q6RCgVQUIo0M9Rf4 hoWo0ebz1jStVtagvOlFgRZhHKRFNAfn87j71el+plw/0bnzYkmYtyQyWCzVIsfNNdNwC3Pf sM3/ERrhLXSydRQ6OLnYOro42fP3cj8K/15kSvmLIsTfiMXhYsn/HMYxsojBvLt7M4JOnH2r 2KLY5j0vOdc9jLt/pfOzqpc45XB4lPw73Z1su/u5wuU1XkXduVPmlqocRfuS32K1t03jnEnO UM8XDdY14Vjyt++vFjakuk40HzRz5fo4G/8zsRoVFTuYFH7d47z9lMdYWeMnz4KOm4x0jgbW VA/q0vy9Ooem9lCiyhszU1DYHo2F6Po9V6wORUzE5bv5Rx3+8hVeboD2ZO0uvU70xs2NtEMX 651VuxoaVwpfnOr6+ulAI7snWmVaHP/Buz72DubJ3Pi1QF3STx6Lamte0VR22oWPyxM7LCMr Tie7Xuriw4nahU8Him+3HUpkzBLO+F59njem8TxZNJe8F+MT0gCR8AgukYr+A/zhRFhnBAAA X-CMS-MailID: 20230621091022eucas1p1c097da50842b23e902e1a674e117e1aa X-Msg-Generator: CA X-RootMTR: 20230621091022eucas1p1c097da50842b23e902e1a674e117e1aa X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20230621091022eucas1p1c097da50842b23e902e1a674e117e1aa References: <20230621091000.424843-1-j.granados@samsung.com> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net X-Patchwork-Delegate: kuba@kernel.org In order to remove the end element from the ctl_table struct arrays, we explicitly define the size when registering the targets. The register_net_sysctl function is an indirection function that gets a new argument. All the functions that call into regster_net_sysctl, in turn, pass a new size of array argument. In general the callers of register_net_sysctl need to add a size argument calculated by ARRAY_size on the ctl_table array. The following files are the ones that fall in this "easy" category: drivers/infiniband/core/iwcm.c drivers/infiniband/core/ucma.c drivers/net/vrf.c include/net/net_namespace.h net/appletalk/sysctl_net_atalk.c net/ax25/sysctl_net_ax25.c net/bridge/br_netfilter_hooks.c net/core/neighbour.c net/core/sysctl_net_core.c net/dccp/sysctl.c net/ieee802154/6lowpan/reassembly.c net/ipv4/devinet.c net/ipv4/ip_fragment.c net/ipv4/route.c net/ipv4/sysctl_net_ipv4.c net/ipv4/xfrm4_policy.c net/ipv6/addrconf.c net/ipv6/netfilter/nf_conntrack_reasm.c net/ipv6/reassembly.c net/ipv6/xfrm6_policy.c net/llc/sysctl_net_llc.c net/mpls/af_mpls.c net/mptcp/ctrl.c net/netfilter/ipvs/ip_vs_ctl.c net/netfilter/ipvs/ip_vs_lblc.c net/netfilter/ipvs/ip_vs_lblcr.c net/netfilter/nf_conntrack_standalone.c net/netfilter/nf_log.c net/netrom/sysctl_net_netrom.c net/phonet/sysctl.c net/rds/ib_sysctl.c net/rds/sysctl.c net/rds/tcp.c net/rose/sysctl_net_rose.c net/rxrpc/sysctl.c net/sctp/sysctl.c net/smc/smc_sysctl.c net/tipc/sysctl.c net/unix/sysctl_net_unix.c net/x25/sysctl_net_x25.c net/xfrm/xfrm_sysctl.c An additional size function was added to the following files in order to calculate the size of an array that is defined in another file: include/net/ipv6.h net/ipv6/icmp.c net/ipv6/route.c net/ipv6/sysctl_net_ipv6.c In this file we add the additional argument: net/sysctl_net.c Signed-off-by: Joel Granados --- drivers/infiniband/core/iwcm.c | 3 +- drivers/infiniband/core/ucma.c | 4 +- drivers/net/vrf.c | 3 +- include/net/ipv6.h | 2 + include/net/net_namespace.h | 4 +- net/appletalk/sysctl_net_atalk.c | 4 +- net/ax25/sysctl_net_ax25.c | 3 +- net/bridge/br_netfilter_hooks.c | 2 +- net/core/neighbour.c | 3 +- net/core/sysctl_net_core.c | 5 +- net/dccp/sysctl.c | 3 +- net/ieee802154/6lowpan/reassembly.c | 6 +- net/ipv4/devinet.c | 6 +- net/ipv4/ip_fragment.c | 6 +- net/ipv4/route.c | 6 +- net/ipv4/sysctl_net_ipv4.c | 6 +- net/ipv4/xfrm4_policy.c | 3 +- net/ipv6/addrconf.c | 3 +- net/ipv6/icmp.c | 5 ++ net/ipv6/netfilter/nf_conntrack_reasm.c | 3 +- net/ipv6/reassembly.c | 6 +- net/ipv6/route.c | 5 ++ net/ipv6/sysctl_net_ipv6.c | 13 +++-- net/ipv6/xfrm6_policy.c | 3 +- net/llc/sysctl_net_llc.c | 9 ++- net/mpls/af_mpls.c | 75 +++++++++++++------------ net/mptcp/ctrl.c | 3 +- net/netfilter/ipvs/ip_vs_ctl.c | 3 +- net/netfilter/ipvs/ip_vs_lblc.c | 5 +- net/netfilter/ipvs/ip_vs_lblcr.c | 5 +- net/netfilter/nf_conntrack_standalone.c | 8 ++- net/netfilter/nf_log.c | 5 +- net/netrom/sysctl_net_netrom.c | 3 +- net/phonet/sysctl.c | 4 +- net/rds/ib_sysctl.c | 4 +- net/rds/sysctl.c | 5 +- net/rds/tcp.c | 3 +- net/rose/sysctl_net_rose.c | 4 +- net/rxrpc/sysctl.c | 3 +- net/sctp/sysctl.c | 7 ++- net/smc/smc_sysctl.c | 3 +- net/sysctl_net.c | 10 +--- net/tipc/sysctl.c | 3 +- net/unix/sysctl_net_unix.c | 3 +- net/x25/sysctl_net_x25.c | 4 +- net/xfrm/xfrm_sysctl.c | 3 +- 46 files changed, 176 insertions(+), 103 deletions(-) diff --git a/drivers/infiniband/core/iwcm.c b/drivers/infiniband/core/iwcm.c index 2b47073c61a6..20627a894c89 100644 --- a/drivers/infiniband/core/iwcm.c +++ b/drivers/infiniband/core/iwcm.c @@ -1193,7 +1193,8 @@ static int __init iw_cm_init(void) goto err_alloc; iwcm_ctl_table_hdr = register_net_sysctl(&init_net, "net/iw_cm", - iwcm_ctl_table); + iwcm_ctl_table, + ARRAY_SIZE(iwcm_ctl_table)); if (!iwcm_ctl_table_hdr) { pr_err("iw_cm: couldn't register sysctl paths\n"); goto err_sysctl; diff --git a/drivers/infiniband/core/ucma.c b/drivers/infiniband/core/ucma.c index bf42650f125b..f737ab0de883 100644 --- a/drivers/infiniband/core/ucma.c +++ b/drivers/infiniband/core/ucma.c @@ -1863,7 +1863,9 @@ static int __init ucma_init(void) goto err1; } - ucma_ctl_table_hdr = register_net_sysctl(&init_net, "net/rdma_ucm", ucma_ctl_table); + ucma_ctl_table_hdr = register_net_sysctl(&init_net, "net/rdma_ucm", + ucma_ctl_table, + ARRAY_SIZE(ucma_ctl_table)); if (!ucma_ctl_table_hdr) { pr_err("rdma_ucm: couldn't register sysctl paths\n"); ret = -ENOMEM; diff --git a/drivers/net/vrf.c b/drivers/net/vrf.c index bdb3a76a352e..edd8f2ba5595 100644 --- a/drivers/net/vrf.c +++ b/drivers/net/vrf.c @@ -1979,7 +1979,8 @@ static int vrf_netns_init_sysctl(struct net *net, struct netns_vrf *nn_vrf) /* init the extra1 parameter with the reference to current netns */ table[0].extra1 = net; - nn_vrf->ctl_hdr = register_net_sysctl(net, "net/vrf", table); + nn_vrf->ctl_hdr = register_net_sysctl(net, "net/vrf", table, + ARRAY_SIZE(vrf_table)); if (!nn_vrf->ctl_hdr) { kfree(table); return -ENOMEM; diff --git a/include/net/ipv6.h b/include/net/ipv6.h index 7332296eca44..37c2737be083 100644 --- a/include/net/ipv6.h +++ b/include/net/ipv6.h @@ -1274,7 +1274,9 @@ static inline int snmp6_unregister_dev(struct inet6_dev *idev) { return 0; } #ifdef CONFIG_SYSCTL struct ctl_table *ipv6_icmp_sysctl_init(struct net *net); +size_t ipv6_icmp_sysctl_table_size(void); struct ctl_table *ipv6_route_sysctl_init(struct net *net); +size_t ipv6_route_sysctl_table_size(void); int ipv6_sysctl_register(void); void ipv6_sysctl_unregister(void); #endif diff --git a/include/net/net_namespace.h b/include/net/net_namespace.h index 78beaa765c73..e6ffe77516eb 100644 --- a/include/net/net_namespace.h +++ b/include/net/net_namespace.h @@ -472,12 +472,12 @@ struct ctl_table; #ifdef CONFIG_SYSCTL int net_sysctl_init(void); struct ctl_table_header *register_net_sysctl(struct net *net, const char *path, - struct ctl_table *table); + struct ctl_table *table, size_t table_size); void unregister_net_sysctl_table(struct ctl_table_header *header); #else static inline int net_sysctl_init(void) { return 0; } static inline struct ctl_table_header *register_net_sysctl(struct net *net, - const char *path, struct ctl_table *table) + const char *path, struct ctl_table *table, size_t table_size) { return NULL; } diff --git a/net/appletalk/sysctl_net_atalk.c b/net/appletalk/sysctl_net_atalk.c index d945b7c0176d..30dcbbb8aeff 100644 --- a/net/appletalk/sysctl_net_atalk.c +++ b/net/appletalk/sysctl_net_atalk.c @@ -47,7 +47,9 @@ static struct ctl_table_header *atalk_table_header; int __init atalk_register_sysctl(void) { - atalk_table_header = register_net_sysctl(&init_net, "net/appletalk", atalk_table); + atalk_table_header = register_net_sysctl(&init_net, "net/appletalk", + atalk_table, + ARRAY_SIZE(atalk_table)); if (!atalk_table_header) return -ENOMEM; return 0; diff --git a/net/ax25/sysctl_net_ax25.c b/net/ax25/sysctl_net_ax25.c index 2154d004d3dc..06afbc14b783 100644 --- a/net/ax25/sysctl_net_ax25.c +++ b/net/ax25/sysctl_net_ax25.c @@ -159,7 +159,8 @@ int ax25_register_dev_sysctl(ax25_dev *ax25_dev) table[k].data = &ax25_dev->values[k]; snprintf(path, sizeof(path), "net/ax25/%s", ax25_dev->dev->name); - ax25_dev->sysheader = register_net_sysctl(&init_net, path, table); + ax25_dev->sysheader = register_net_sysctl(&init_net, path, table, + ARRAY_SIZE(ax25_param_table)); if (!ax25_dev->sysheader) { kfree(table); return -ENOMEM; diff --git a/net/bridge/br_netfilter_hooks.c b/net/bridge/br_netfilter_hooks.c index 1a801fab9543..ebbaef748a48 100644 --- a/net/bridge/br_netfilter_hooks.c +++ b/net/bridge/br_netfilter_hooks.c @@ -1135,7 +1135,7 @@ static int br_netfilter_sysctl_init_net(struct net *net) br_netfilter_sysctl_default(brnet); - brnet->ctl_hdr = register_net_sysctl(net, "net/bridge", table); + brnet->ctl_hdr = register_net_sysctl(net, "net/bridge", table, ARRAY_SIZE(brnf_table)); if (!brnet->ctl_hdr) { if (!net_eq(net, &init_net)) kfree(table); diff --git a/net/core/neighbour.c b/net/core/neighbour.c index ddd0f32de20e..aa5ad1cfc9b1 100644 --- a/net/core/neighbour.c +++ b/net/core/neighbour.c @@ -3842,7 +3842,8 @@ int neigh_sysctl_register(struct net_device *dev, struct neigh_parms *p, snprintf(neigh_path, sizeof(neigh_path), "net/%s/neigh/%s", p_name, dev_name_source); t->sysctl_header = - register_net_sysctl(neigh_parms_net(p), neigh_path, t->neigh_vars); + register_net_sysctl(neigh_parms_net(p), neigh_path, t->neigh_vars, + ARRAY_SIZE(t->neigh_vars)); if (!t->sysctl_header) goto free; diff --git a/net/core/sysctl_net_core.c b/net/core/sysctl_net_core.c index 782273bb93c2..aa615f22507b 100644 --- a/net/core/sysctl_net_core.c +++ b/net/core/sysctl_net_core.c @@ -712,7 +712,8 @@ static __net_init int sysctl_core_net_init(struct net *net) tmp->data += (char *)net - (char *)&init_net; } - net->core.sysctl_hdr = register_net_sysctl(net, "net/core", tbl); + net->core.sysctl_hdr = register_net_sysctl(net, "net/core", tbl, + ARRAY_SIZE(netns_core_table)); if (net->core.sysctl_hdr == NULL) goto err_reg; @@ -745,7 +746,7 @@ static __net_initdata struct pernet_operations sysctl_core_ops = { static __init int sysctl_core_init(void) { - register_net_sysctl(&init_net, "net/core", net_core_table); + register_net_sysctl(&init_net, "net/core", net_core_table, ARRAY_SIZE(net_core_table)); return register_pernet_subsys(&sysctl_core_ops); } diff --git a/net/dccp/sysctl.c b/net/dccp/sysctl.c index ee8d4f5afa72..1140748858b0 100644 --- a/net/dccp/sysctl.c +++ b/net/dccp/sysctl.c @@ -99,7 +99,8 @@ static struct ctl_table_header *dccp_table_header; int __init dccp_sysctl_init(void) { dccp_table_header = register_net_sysctl(&init_net, "net/dccp/default", - dccp_default_table); + dccp_default_table, + ARRAY_SIZE(dccp_default_table)); return dccp_table_header != NULL ? 0 : -ENOMEM; } diff --git a/net/ieee802154/6lowpan/reassembly.c b/net/ieee802154/6lowpan/reassembly.c index a91283d1e5bf..7b717434368c 100644 --- a/net/ieee802154/6lowpan/reassembly.c +++ b/net/ieee802154/6lowpan/reassembly.c @@ -379,7 +379,8 @@ static int __net_init lowpan_frags_ns_sysctl_register(struct net *net) table[1].extra2 = &ieee802154_lowpan->fqdir->high_thresh; table[2].data = &ieee802154_lowpan->fqdir->timeout; - hdr = register_net_sysctl(net, "net/ieee802154/6lowpan", table); + hdr = register_net_sysctl(net, "net/ieee802154/6lowpan", table, + ARRAY_SIZE(lowpan_frags_ns_ctl_table)); if (hdr == NULL) goto err_reg; @@ -411,7 +412,8 @@ static int __init lowpan_frags_sysctl_register(void) { lowpan_ctl_header = register_net_sysctl(&init_net, "net/ieee802154/6lowpan", - lowpan_frags_ctl_table); + lowpan_frags_ctl_table, + ARRAY_SIZE(lowpan_frags_ctl_table)); return lowpan_ctl_header == NULL ? -ENOMEM : 0; } diff --git a/net/ipv4/devinet.c b/net/ipv4/devinet.c index 5deac0517ef7..6360425dfcb2 100644 --- a/net/ipv4/devinet.c +++ b/net/ipv4/devinet.c @@ -2587,7 +2587,8 @@ static int __devinet_sysctl_register(struct net *net, char *dev_name, snprintf(path, sizeof(path), "net/ipv4/conf/%s", dev_name); - t->sysctl_header = register_net_sysctl(net, path, t->devinet_vars); + t->sysctl_header = register_net_sysctl(net, path, t->devinet_vars, + ARRAY_SIZE(t->devinet_vars)); if (!t->sysctl_header) goto free; @@ -2720,7 +2721,8 @@ static __net_init int devinet_init_net(struct net *net) goto err_reg_dflt; err = -ENOMEM; - forw_hdr = register_net_sysctl(net, "net/ipv4", tbl); + forw_hdr = register_net_sysctl(net, "net/ipv4", tbl, + ARRAY_SIZE(ctl_forward_entry)); if (!forw_hdr) goto err_reg_ctl; net->ipv4.forw_hdr = forw_hdr; diff --git a/net/ipv4/ip_fragment.c b/net/ipv4/ip_fragment.c index 69c00ffdcf3e..3d7a82a900b5 100644 --- a/net/ipv4/ip_fragment.c +++ b/net/ipv4/ip_fragment.c @@ -615,7 +615,8 @@ static int __net_init ip4_frags_ns_ctl_register(struct net *net) table[2].data = &net->ipv4.fqdir->timeout; table[3].data = &net->ipv4.fqdir->max_dist; - hdr = register_net_sysctl(net, "net/ipv4", table); + hdr = register_net_sysctl(net, "net/ipv4", table, + ARRAY_SIZE(ip4_frags_ns_ctl_table)); if (!hdr) goto err_reg; @@ -640,7 +641,8 @@ static void __net_exit ip4_frags_ns_ctl_unregister(struct net *net) static void __init ip4_frags_ctl_register(void) { - register_net_sysctl(&init_net, "net/ipv4", ip4_frags_ctl_table); + register_net_sysctl(&init_net, "net/ipv4", ip4_frags_ctl_table, + ARRAY_SIZE(ip4_frags_ctl_table)); } #else static int ip4_frags_ns_ctl_register(struct net *net) diff --git a/net/ipv4/route.c b/net/ipv4/route.c index 98d7e6ba7493..883f4f1ee056 100644 --- a/net/ipv4/route.c +++ b/net/ipv4/route.c @@ -3615,7 +3615,8 @@ static __net_init int sysctl_route_net_init(struct net *net) } tbl[0].extra1 = net; - net->ipv4.route_hdr = register_net_sysctl(net, "net/ipv4/route", tbl); + net->ipv4.route_hdr = register_net_sysctl(net, "net/ipv4/route", tbl, + ARRAY_SIZE(ipv4_route_netns_table)); if (!net->ipv4.route_hdr) goto err_reg; return 0; @@ -3775,6 +3776,7 @@ int __init ip_rt_init(void) */ void __init ip_static_sysctl_init(void) { - register_net_sysctl(&init_net, "net/ipv4/route", ipv4_route_table); + register_net_sysctl(&init_net, "net/ipv4/route", ipv4_route_table, + ARRAY_SIZE(ipv4_route_table)); } #endif diff --git a/net/ipv4/sysctl_net_ipv4.c b/net/ipv4/sysctl_net_ipv4.c index 40fe70fc2015..1821f403efc0 100644 --- a/net/ipv4/sysctl_net_ipv4.c +++ b/net/ipv4/sysctl_net_ipv4.c @@ -1500,7 +1500,8 @@ static __net_init int ipv4_sysctl_init_net(struct net *net) } } - net->ipv4.ipv4_hdr = register_net_sysctl(net, "net/ipv4", table); + net->ipv4.ipv4_hdr = register_net_sysctl(net, "net/ipv4", table, + ARRAY_SIZE(ipv4_net_table)); if (!net->ipv4.ipv4_hdr) goto err_reg; @@ -1538,7 +1539,8 @@ static __init int sysctl_ipv4_init(void) { struct ctl_table_header *hdr; - hdr = register_net_sysctl(&init_net, "net/ipv4", ipv4_table); + hdr = register_net_sysctl(&init_net, "net/ipv4", ipv4_table, + ARRAY_SIZE(ipv4_table)); if (!hdr) return -ENOMEM; diff --git a/net/ipv4/xfrm4_policy.c b/net/ipv4/xfrm4_policy.c index 9403bbaf1b61..ec1d68dbffc3 100644 --- a/net/ipv4/xfrm4_policy.c +++ b/net/ipv4/xfrm4_policy.c @@ -178,7 +178,8 @@ static __net_init int xfrm4_net_sysctl_init(struct net *net) table[0].data = &net->xfrm.xfrm4_dst_ops.gc_thresh; } - hdr = register_net_sysctl(net, "net/ipv4", table); + hdr = register_net_sysctl(net, "net/ipv4", table, + ARRAY_SIZE(xfrm4_policy_table)); if (!hdr) goto err_reg; diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c index 3797917237d0..68a2925c66a5 100644 --- a/net/ipv6/addrconf.c +++ b/net/ipv6/addrconf.c @@ -7086,7 +7086,8 @@ static int __addrconf_sysctl_register(struct net *net, char *dev_name, snprintf(path, sizeof(path), "net/ipv6/conf/%s", dev_name); - p->sysctl_header = register_net_sysctl(net, path, table); + p->sysctl_header = register_net_sysctl(net, path, table, + ARRAY_SIZE(addrconf_sysctl)); if (!p->sysctl_header) goto free; diff --git a/net/ipv6/icmp.c b/net/ipv6/icmp.c index 9edf1f45b1ed..4159662fa214 100644 --- a/net/ipv6/icmp.c +++ b/net/ipv6/icmp.c @@ -1226,4 +1226,9 @@ struct ctl_table * __net_init ipv6_icmp_sysctl_init(struct net *net) } return table; } + +size_t ipv6_icmp_sysctl_table_size(void) +{ + return ARRAY_SIZE(ipv6_icmp_table_template); +} #endif diff --git a/net/ipv6/netfilter/nf_conntrack_reasm.c b/net/ipv6/netfilter/nf_conntrack_reasm.c index d13240f13607..dca8e0aabc51 100644 --- a/net/ipv6/netfilter/nf_conntrack_reasm.c +++ b/net/ipv6/netfilter/nf_conntrack_reasm.c @@ -87,7 +87,8 @@ static int nf_ct_frag6_sysctl_register(struct net *net) table[2].data = &nf_frag->fqdir->high_thresh; table[2].extra1 = &nf_frag->fqdir->low_thresh; - hdr = register_net_sysctl(net, "net/netfilter", table); + hdr = register_net_sysctl(net, "net/netfilter", table, + ARRAY_SIZE(nf_ct_frag6_sysctl_table)); if (hdr == NULL) goto err_reg; diff --git a/net/ipv6/reassembly.c b/net/ipv6/reassembly.c index 5bc8a28e67f9..0688261202de 100644 --- a/net/ipv6/reassembly.c +++ b/net/ipv6/reassembly.c @@ -470,7 +470,8 @@ static int __net_init ip6_frags_ns_sysctl_register(struct net *net) table[1].extra2 = &net->ipv6.fqdir->high_thresh; table[2].data = &net->ipv6.fqdir->timeout; - hdr = register_net_sysctl(net, "net/ipv6", table); + hdr = register_net_sysctl(net, "net/ipv6", table, + ARRAY_SIZE(ip6_frags_ns_ctl_table)); if (!hdr) goto err_reg; @@ -499,7 +500,8 @@ static struct ctl_table_header *ip6_ctl_header; static int ip6_frags_sysctl_register(void) { ip6_ctl_header = register_net_sysctl(&init_net, "net/ipv6", - ip6_frags_ctl_table); + ip6_frags_ctl_table, + ARRAY_SIZE(ip6_frags_ctl_table)); return ip6_ctl_header == NULL ? -ENOMEM : 0; } diff --git a/net/ipv6/route.c b/net/ipv6/route.c index e3aec46bd466..a35470576077 100644 --- a/net/ipv6/route.c +++ b/net/ipv6/route.c @@ -6450,6 +6450,11 @@ struct ctl_table * __net_init ipv6_route_sysctl_init(struct net *net) return table; } + +size_t ipv6_route_sysctl_table_size(void) +{ + return ARRAY_SIZE(ipv6_route_table_template); +} #endif static int __net_init ip6_route_net_init(struct net *net) diff --git a/net/ipv6/sysctl_net_ipv6.c b/net/ipv6/sysctl_net_ipv6.c index 94a0a294c6a1..29f121f513a6 100644 --- a/net/ipv6/sysctl_net_ipv6.c +++ b/net/ipv6/sysctl_net_ipv6.c @@ -275,17 +275,21 @@ static int __net_init ipv6_sysctl_net_init(struct net *net) if (!ipv6_icmp_table) goto out_ipv6_route_table; - net->ipv6.sysctl.hdr = register_net_sysctl(net, "net/ipv6", ipv6_table); + net->ipv6.sysctl.hdr = register_net_sysctl(net, "net/ipv6", + ipv6_table, + ARRAY_SIZE(ipv6_table_template)); if (!net->ipv6.sysctl.hdr) goto out_ipv6_icmp_table; net->ipv6.sysctl.route_hdr = - register_net_sysctl(net, "net/ipv6/route", ipv6_route_table); + register_net_sysctl(net, "net/ipv6/route", ipv6_route_table, + ipv6_route_sysctl_table_size()); if (!net->ipv6.sysctl.route_hdr) goto out_unregister_ipv6_table; net->ipv6.sysctl.icmp_hdr = - register_net_sysctl(net, "net/ipv6/icmp", ipv6_icmp_table); + register_net_sysctl(net, "net/ipv6/icmp", ipv6_icmp_table, + ipv6_icmp_sysctl_table_size()); if (!net->ipv6.sysctl.icmp_hdr) goto out_unregister_route_table; @@ -335,7 +339,8 @@ int ipv6_sysctl_register(void) { int err = -ENOMEM; - ip6_header = register_net_sysctl(&init_net, "net/ipv6", ipv6_rotable); + ip6_header = register_net_sysctl(&init_net, "net/ipv6", ipv6_rotable, + ARRAY_SIZE(ipv6_rotable)); if (!ip6_header) goto out; diff --git a/net/ipv6/xfrm6_policy.c b/net/ipv6/xfrm6_policy.c index eecc5e59da17..27efdb18a018 100644 --- a/net/ipv6/xfrm6_policy.c +++ b/net/ipv6/xfrm6_policy.c @@ -205,7 +205,8 @@ static int __net_init xfrm6_net_sysctl_init(struct net *net) table[0].data = &net->xfrm.xfrm6_dst_ops.gc_thresh; } - hdr = register_net_sysctl(net, "net/ipv6", table); + hdr = register_net_sysctl(net, "net/ipv6", table, + ARRAY_SIZE(xfrm6_policy_table)); if (!hdr) goto err_reg; diff --git a/net/llc/sysctl_net_llc.c b/net/llc/sysctl_net_llc.c index 8443a6d841b0..195296ba29f0 100644 --- a/net/llc/sysctl_net_llc.c +++ b/net/llc/sysctl_net_llc.c @@ -56,8 +56,13 @@ static struct ctl_table_header *llc_station_header; int __init llc_sysctl_init(void) { - llc2_timeout_header = register_net_sysctl(&init_net, "net/llc/llc2/timeout", llc2_timeout_table); - llc_station_header = register_net_sysctl(&init_net, "net/llc/station", llc_station_table); + llc2_timeout_header = register_net_sysctl(&init_net, + "net/llc/llc2/timeout", + llc2_timeout_table, + ARRAY_SIZE(llc2_timeout_table)); + llc_station_header = register_net_sysctl(&init_net, "net/llc/station", + llc_station_table, + ARRAY_SIZE(llc_station_table)); if (!llc2_timeout_header || !llc_station_header) { llc_sysctl_exit(); diff --git a/net/mpls/af_mpls.c b/net/mpls/af_mpls.c index dc5165d3eec4..6f96aae76537 100644 --- a/net/mpls/af_mpls.c +++ b/net/mpls/af_mpls.c @@ -1395,6 +1395,40 @@ static const struct ctl_table mpls_dev_table[] = { { } }; +static int mpls_platform_labels(struct ctl_table *table, int write, + void *buffer, size_t *lenp, loff_t *ppos); +#define MPLS_NS_SYSCTL_OFFSET(field) \ + (&((struct net *)0)->field) + +static const struct ctl_table mpls_table[] = { + { + .procname = "platform_labels", + .data = NULL, + .maxlen = sizeof(int), + .mode = 0644, + .proc_handler = mpls_platform_labels, + }, + { + .procname = "ip_ttl_propagate", + .data = MPLS_NS_SYSCTL_OFFSET(mpls.ip_ttl_propagate), + .maxlen = sizeof(int), + .mode = 0644, + .proc_handler = proc_dointvec_minmax, + .extra1 = SYSCTL_ZERO, + .extra2 = SYSCTL_ONE, + }, + { + .procname = "default_ttl", + .data = MPLS_NS_SYSCTL_OFFSET(mpls.default_ttl), + .maxlen = sizeof(int), + .mode = 0644, + .proc_handler = proc_dointvec_minmax, + .extra1 = SYSCTL_ONE, + .extra2 = &ttl_max, + }, + { } +}; + static int mpls_dev_sysctl_register(struct net_device *dev, struct mpls_dev *mdev) { @@ -1410,7 +1444,7 @@ static int mpls_dev_sysctl_register(struct net_device *dev, /* Table data contains only offsets relative to the base of * the mdev at this point, so make them absolute. */ - for (i = 0; i < ARRAY_SIZE(mpls_dev_table); i++) { + for (i = 0; i < ARRAY_SIZE(mpls_dev_table) - 1; i++) { table[i].data = (char *)mdev + (uintptr_t)table[i].data; table[i].extra1 = mdev; table[i].extra2 = net; @@ -1418,7 +1452,8 @@ static int mpls_dev_sysctl_register(struct net_device *dev, snprintf(path, sizeof(path), "net/mpls/conf/%s", dev->name); - mdev->sysctl = register_net_sysctl(net, path, table); + mdev->sysctl = register_net_sysctl(net, path, table, + ARRAY_SIZE(mpls_dev_table)); if (!mdev->sysctl) goto free; @@ -1432,6 +1467,7 @@ static int mpls_dev_sysctl_register(struct net_device *dev, return -ENOBUFS; } + static void mpls_dev_sysctl_unregister(struct net_device *dev, struct mpls_dev *mdev) { @@ -2636,38 +2672,6 @@ static int mpls_platform_labels(struct ctl_table *table, int write, return ret; } -#define MPLS_NS_SYSCTL_OFFSET(field) \ - (&((struct net *)0)->field) - -static const struct ctl_table mpls_table[] = { - { - .procname = "platform_labels", - .data = NULL, - .maxlen = sizeof(int), - .mode = 0644, - .proc_handler = mpls_platform_labels, - }, - { - .procname = "ip_ttl_propagate", - .data = MPLS_NS_SYSCTL_OFFSET(mpls.ip_ttl_propagate), - .maxlen = sizeof(int), - .mode = 0644, - .proc_handler = proc_dointvec_minmax, - .extra1 = SYSCTL_ZERO, - .extra2 = SYSCTL_ONE, - }, - { - .procname = "default_ttl", - .data = MPLS_NS_SYSCTL_OFFSET(mpls.default_ttl), - .maxlen = sizeof(int), - .mode = 0644, - .proc_handler = proc_dointvec_minmax, - .extra1 = SYSCTL_ONE, - .extra2 = &ttl_max, - }, - { } -}; - static int mpls_net_init(struct net *net) { struct ctl_table *table; @@ -2688,7 +2692,8 @@ static int mpls_net_init(struct net *net) for (i = 0; i < ARRAY_SIZE(mpls_table) - 1; i++) table[i].data = (char *)net + (uintptr_t)table[i].data; - net->mpls.ctl = register_net_sysctl(net, "net/mpls", table); + net->mpls.ctl = register_net_sysctl(net, "net/mpls", table, + ARRAY_SIZE(mpls_table)); if (net->mpls.ctl == NULL) { kfree(table); return -ENOMEM; diff --git a/net/mptcp/ctrl.c b/net/mptcp/ctrl.c index ae20b7d92e28..42dfc834e5c6 100644 --- a/net/mptcp/ctrl.c +++ b/net/mptcp/ctrl.c @@ -150,7 +150,8 @@ static int mptcp_pernet_new_table(struct net *net, struct mptcp_pernet *pernet) table[4].data = &pernet->stale_loss_cnt; table[5].data = &pernet->pm_type; - hdr = register_net_sysctl(net, MPTCP_SYSCTL_PATH, table); + hdr = register_net_sysctl(net, MPTCP_SYSCTL_PATH, table, + ARRAY_SIZE(mptcp_sysctl_table)); if (!hdr) goto err_reg; diff --git a/net/netfilter/ipvs/ip_vs_ctl.c b/net/netfilter/ipvs/ip_vs_ctl.c index 62606fb44d02..abbd30ee3ce0 100644 --- a/net/netfilter/ipvs/ip_vs_ctl.c +++ b/net/netfilter/ipvs/ip_vs_ctl.c @@ -4353,7 +4353,8 @@ static int __net_init ip_vs_control_net_init_sysctl(struct netns_ipvs *ipvs) #endif ret = -ENOMEM; - ipvs->sysctl_hdr = register_net_sysctl(net, "net/ipv4/vs", tbl); + ipvs->sysctl_hdr = register_net_sysctl(net, "net/ipv4/vs", tbl, + ARRAY_SIZE(vs_vars)); if (!ipvs->sysctl_hdr) goto err; ipvs->sysctl_tbl = tbl; diff --git a/net/netfilter/ipvs/ip_vs_lblc.c b/net/netfilter/ipvs/ip_vs_lblc.c index 1b87214d385e..254eb3b61e15 100644 --- a/net/netfilter/ipvs/ip_vs_lblc.c +++ b/net/netfilter/ipvs/ip_vs_lblc.c @@ -570,8 +570,9 @@ static int __net_init __ip_vs_lblc_init(struct net *net) ipvs->sysctl_lblc_expiration = DEFAULT_EXPIRATION; ipvs->lblc_ctl_table[0].data = &ipvs->sysctl_lblc_expiration; - ipvs->lblc_ctl_header = - register_net_sysctl(net, "net/ipv4/vs", ipvs->lblc_ctl_table); + ipvs->lblc_ctl_header = register_net_sysctl(net, "net/ipv4/vs", + ipvs->lblc_ctl_table, + ARRAY_SIZE(vs_vars_table)); if (!ipvs->lblc_ctl_header) { if (!net_eq(net, &init_net)) kfree(ipvs->lblc_ctl_table); diff --git a/net/netfilter/ipvs/ip_vs_lblcr.c b/net/netfilter/ipvs/ip_vs_lblcr.c index ad8f5fea6d3a..0e39a4fd421f 100644 --- a/net/netfilter/ipvs/ip_vs_lblcr.c +++ b/net/netfilter/ipvs/ip_vs_lblcr.c @@ -755,8 +755,9 @@ static int __net_init __ip_vs_lblcr_init(struct net *net) ipvs->sysctl_lblcr_expiration = DEFAULT_EXPIRATION; ipvs->lblcr_ctl_table[0].data = &ipvs->sysctl_lblcr_expiration; - ipvs->lblcr_ctl_header = - register_net_sysctl(net, "net/ipv4/vs", ipvs->lblcr_ctl_table); + ipvs->lblcr_ctl_header = register_net_sysctl(net, "net/ipv4/vs", + ipvs->lblcr_ctl_table, + ARRAY_SIZE(vs_vars_table)); if (!ipvs->lblcr_ctl_header) { if (!net_eq(net, &init_net)) kfree(ipvs->lblcr_ctl_table); diff --git a/net/netfilter/nf_conntrack_standalone.c b/net/netfilter/nf_conntrack_standalone.c index 169e16fc2bce..a3b2029ef098 100644 --- a/net/netfilter/nf_conntrack_standalone.c +++ b/net/netfilter/nf_conntrack_standalone.c @@ -1106,7 +1106,8 @@ static int nf_conntrack_standalone_init_sysctl(struct net *net) table[NF_SYSCTL_CT_BUCKETS].mode = 0444; } - cnet->sysctl_header = register_net_sysctl(net, "net/netfilter", table); + cnet->sysctl_header = register_net_sysctl(net, "net/netfilter", table, + ARRAY_SIZE(nf_ct_sysctl_table)); if (!cnet->sysctl_header) goto out_unregister_netfilter; @@ -1207,8 +1208,9 @@ static int __init nf_conntrack_standalone_init(void) BUILD_BUG_ON(NFCT_INFOMASK <= IP_CT_NUMBER); #ifdef CONFIG_SYSCTL - nf_ct_netfilter_header = - register_net_sysctl(&init_net, "net", nf_ct_netfilter_table); + nf_ct_netfilter_header = register_net_sysctl(&init_net, "net", + nf_ct_netfilter_table, + ARRAY_SIZE(nf_ct_netfilter_table)); if (!nf_ct_netfilter_header) { pr_err("nf_conntrack: can't register to sysctl.\n"); ret = -ENOMEM; diff --git a/net/netfilter/nf_log.c b/net/netfilter/nf_log.c index 8a29290149bd..755f9cf570ce 100644 --- a/net/netfilter/nf_log.c +++ b/net/netfilter/nf_log.c @@ -479,7 +479,8 @@ static int netfilter_log_sysctl_init(struct net *net) (void *)(unsigned long) i; } nf_log_sysctl_fhdr = register_net_sysctl(net, "net/netfilter", - nf_log_sysctl_ftable); + nf_log_sysctl_ftable, + ARRAY_SIZE(nf_log_sysctl_ftable)); if (!nf_log_sysctl_fhdr) goto err_freg; } @@ -489,7 +490,7 @@ static int netfilter_log_sysctl_init(struct net *net) net->nf.nf_log_dir_header = register_net_sysctl(net, "net/netfilter/nf_log", - table); + table, ARRAY_SIZE(nf_log_sysctl_table)); if (!net->nf.nf_log_dir_header) goto err_reg; diff --git a/net/netrom/sysctl_net_netrom.c b/net/netrom/sysctl_net_netrom.c index 79fb2d3f477b..c02b93fd9d4f 100644 --- a/net/netrom/sysctl_net_netrom.c +++ b/net/netrom/sysctl_net_netrom.c @@ -145,7 +145,8 @@ static struct ctl_table nr_table[] = { int __init nr_register_sysctl(void) { - nr_table_header = register_net_sysctl(&init_net, "net/netrom", nr_table); + nr_table_header = register_net_sysctl(&init_net, "net/netrom", + nr_table, ARRAY_SIZE(nr_table)); if (!nr_table_header) return -ENOMEM; return 0; diff --git a/net/phonet/sysctl.c b/net/phonet/sysctl.c index 0d0bf41381c2..0fd0fcb00505 100644 --- a/net/phonet/sysctl.c +++ b/net/phonet/sysctl.c @@ -86,7 +86,9 @@ static struct ctl_table phonet_table[] = { int __init phonet_sysctl_init(void) { - phonet_table_hrd = register_net_sysctl(&init_net, "net/phonet", phonet_table); + phonet_table_hrd = register_net_sysctl(&init_net, "net/phonet", + phonet_table, + ARRAY_SIZE(phonet_table)); return phonet_table_hrd == NULL ? -ENOMEM : 0; } diff --git a/net/rds/ib_sysctl.c b/net/rds/ib_sysctl.c index e4e41b3afce7..102fd4a18df7 100644 --- a/net/rds/ib_sysctl.c +++ b/net/rds/ib_sysctl.c @@ -114,7 +114,9 @@ void rds_ib_sysctl_exit(void) int rds_ib_sysctl_init(void) { - rds_ib_sysctl_hdr = register_net_sysctl(&init_net, "net/rds/ib", rds_ib_sysctl_table); + rds_ib_sysctl_hdr = register_net_sysctl(&init_net, "net/rds/ib", + rds_ib_sysctl_table, + ARRAY_SIZE(rds_ib_sysctl_table)); if (!rds_ib_sysctl_hdr) return -ENOMEM; return 0; diff --git a/net/rds/sysctl.c b/net/rds/sysctl.c index e381bbcd9cc1..5abd2730a1bc 100644 --- a/net/rds/sysctl.c +++ b/net/rds/sysctl.c @@ -102,8 +102,9 @@ int rds_sysctl_init(void) rds_sysctl_reconnect_min = msecs_to_jiffies(1); rds_sysctl_reconnect_min_jiffies = rds_sysctl_reconnect_min; - rds_sysctl_reg_table = - register_net_sysctl(&init_net, "net/rds", rds_sysctl_rds_table); + rds_sysctl_reg_table = register_net_sysctl(&init_net, "net/rds", + rds_sysctl_rds_table, + ARRAY_SIZE(rds_sysctl_rds_table)); if (!rds_sysctl_reg_table) return -ENOMEM; return 0; diff --git a/net/rds/tcp.c b/net/rds/tcp.c index c5b86066ff66..2e90a2570d3b 100644 --- a/net/rds/tcp.c +++ b/net/rds/tcp.c @@ -565,7 +565,8 @@ static __net_init int rds_tcp_init_net(struct net *net) } tbl[RDS_TCP_SNDBUF].data = &rtn->sndbuf_size; tbl[RDS_TCP_RCVBUF].data = &rtn->rcvbuf_size; - rtn->rds_tcp_sysctl = register_net_sysctl(net, "net/rds/tcp", tbl); + rtn->rds_tcp_sysctl = register_net_sysctl(net, "net/rds/tcp", tbl, + ARRAY_SIZE(rds_tcp_sysctl_table)); if (!rtn->rds_tcp_sysctl) { pr_warn("could not register sysctl\n"); err = -ENOMEM; diff --git a/net/rose/sysctl_net_rose.c b/net/rose/sysctl_net_rose.c index d391d7758f52..4f5a1e8b6c54 100644 --- a/net/rose/sysctl_net_rose.c +++ b/net/rose/sysctl_net_rose.c @@ -117,7 +117,9 @@ static struct ctl_table rose_table[] = { void __init rose_register_sysctl(void) { - rose_table_header = register_net_sysctl(&init_net, "net/rose", rose_table); + rose_table_header = register_net_sysctl(&init_net, "net/rose", + rose_table, + ARRAY_SIZE(rose_table)); } void rose_unregister_sysctl(void) diff --git a/net/rxrpc/sysctl.c b/net/rxrpc/sysctl.c index ecaeb4ecfb58..2b5824416036 100644 --- a/net/rxrpc/sysctl.c +++ b/net/rxrpc/sysctl.c @@ -131,7 +131,8 @@ static struct ctl_table rxrpc_sysctl_table[] = { int __init rxrpc_sysctl_init(void) { rxrpc_sysctl_reg_table = register_net_sysctl(&init_net, "net/rxrpc", - rxrpc_sysctl_table); + rxrpc_sysctl_table, + ARRAY_SIZE(rxrpc_sysctl_table)); if (!rxrpc_sysctl_reg_table) return -ENOMEM; return 0; diff --git a/net/sctp/sysctl.c b/net/sctp/sysctl.c index a7a9136198fd..233f37f0fa28 100644 --- a/net/sctp/sysctl.c +++ b/net/sctp/sysctl.c @@ -612,7 +612,8 @@ int sctp_sysctl_net_register(struct net *net) table[SCTP_PF_RETRANS_IDX].extra2 = &net->sctp.ps_retrans; table[SCTP_PS_RETRANS_IDX].extra1 = &net->sctp.pf_retrans; - net->sctp.sysctl_header = register_net_sysctl(net, "net/sctp", table); + net->sctp.sysctl_header = register_net_sysctl(net, "net/sctp", table, + ARRAY_SIZE(sctp_net_table)); if (net->sctp.sysctl_header == NULL) { kfree(table); return -ENOMEM; @@ -634,7 +635,9 @@ static struct ctl_table_header *sctp_sysctl_header; /* Sysctl registration. */ void sctp_sysctl_register(void) { - sctp_sysctl_header = register_net_sysctl(&init_net, "net/sctp", sctp_table); + sctp_sysctl_header = register_net_sysctl(&init_net, "net/sctp", + sctp_table, + ARRAY_SIZE(sctp_table)); } /* Sysctl deregistration. */ diff --git a/net/smc/smc_sysctl.c b/net/smc/smc_sysctl.c index b6f79fabb9d3..9404123883c0 100644 --- a/net/smc/smc_sysctl.c +++ b/net/smc/smc_sysctl.c @@ -81,7 +81,8 @@ int __net_init smc_sysctl_net_init(struct net *net) table[i].data += (void *)net - (void *)&init_net; } - net->smc.smc_hdr = register_net_sysctl(net, "net/smc", table); + net->smc.smc_hdr = register_net_sysctl(net, "net/smc", table, + ARRAY_SIZE(smc_table)); if (!net->smc.smc_hdr) goto err_reg; diff --git a/net/sysctl_net.c b/net/sysctl_net.c index 8ee4b74bc009..1757c18ea065 100644 --- a/net/sysctl_net.c +++ b/net/sysctl_net.c @@ -161,18 +161,12 @@ static void ensure_safe_net_sysctl(struct net *net, const char *path, } struct ctl_table_header *register_net_sysctl(struct net *net, - const char *path, struct ctl_table *table) + const char *path, struct ctl_table *table, size_t table_size) { - int count = 0; - struct ctl_table *entry; - if (!net_eq(net, &init_net)) ensure_safe_net_sysctl(net, path, table); - for (entry = table; entry->procname; entry++) - count++; - - return __register_sysctl_table(&net->sysctls, path, table, count); + return __register_sysctl_table(&net->sysctls, path, table, table_size); } EXPORT_SYMBOL_GPL(register_net_sysctl); diff --git a/net/tipc/sysctl.c b/net/tipc/sysctl.c index 9fb65c988f7f..b9cbc3b359aa 100644 --- a/net/tipc/sysctl.c +++ b/net/tipc/sysctl.c @@ -96,7 +96,8 @@ static struct ctl_table tipc_table[] = { int tipc_register_sysctl(void) { - tipc_ctl_hdr = register_net_sysctl(&init_net, "net/tipc", tipc_table); + tipc_ctl_hdr = register_net_sysctl(&init_net, "net/tipc", tipc_table, + ARRAY_SIZE(tipc_table)); if (tipc_ctl_hdr == NULL) return -ENOMEM; return 0; diff --git a/net/unix/sysctl_net_unix.c b/net/unix/sysctl_net_unix.c index 500129aa710c..92f3bc3cd704 100644 --- a/net/unix/sysctl_net_unix.c +++ b/net/unix/sysctl_net_unix.c @@ -36,7 +36,8 @@ int __net_init unix_sysctl_register(struct net *net) table[0].data = &net->unx.sysctl_max_dgram_qlen; } - net->unx.ctl = register_net_sysctl(net, "net/unix", table); + net->unx.ctl = register_net_sysctl(net, "net/unix", table, + ARRAY_SIZE(unix_table)); if (net->unx.ctl == NULL) goto err_reg; diff --git a/net/x25/sysctl_net_x25.c b/net/x25/sysctl_net_x25.c index e9802afa43d0..4d7c2ee41943 100644 --- a/net/x25/sysctl_net_x25.c +++ b/net/x25/sysctl_net_x25.c @@ -76,7 +76,9 @@ static struct ctl_table x25_table[] = { int __init x25_register_sysctl(void) { - x25_table_header = register_net_sysctl(&init_net, "net/x25", x25_table); + x25_table_header = register_net_sysctl(&init_net, "net/x25", + x25_table, + ARRAY_SIZE(x25_table)); if (!x25_table_header) return -ENOMEM; return 0; diff --git a/net/xfrm/xfrm_sysctl.c b/net/xfrm/xfrm_sysctl.c index 0c6c5ef65f9d..d04b25a47575 100644 --- a/net/xfrm/xfrm_sysctl.c +++ b/net/xfrm/xfrm_sysctl.c @@ -59,7 +59,8 @@ int __net_init xfrm_sysctl_init(struct net *net) if (net->user_ns != &init_user_ns) table[0].procname = NULL; - net->xfrm.sysctl_hdr = register_net_sysctl(net, "net/core", table); + net->xfrm.sysctl_hdr = register_net_sysctl(net, "net/core", table, + ARRAY_SIZE(xfrm_table)); if (!net->xfrm.sysctl_hdr) goto out_register; return 0; From patchwork Wed Jun 21 09:09:56 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joel Granados X-Patchwork-Id: 13286914 X-Patchwork-Delegate: kuba@kernel.org Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7A042C8DA for ; Wed, 21 Jun 2023 09:10:50 +0000 (UTC) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E23AA1FF2; Wed, 21 Jun 2023 02:10:33 -0700 (PDT) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20230621091030euoutp014ad40326cb733a0a56272604c4496620~qoYt05suO1148511485euoutp01L; Wed, 21 Jun 2023 09:10:30 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20230621091030euoutp014ad40326cb733a0a56272604c4496620~qoYt05suO1148511485euoutp01L DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1687338630; bh=A9vJqtefMweXRl5hA0piF7XKpY7+Y1RrvCTm+EtEXlQ=; h=From:To:CC:Subject:Date:In-Reply-To:References:From; b=Ka4ZfoeHZ9KJZ0KIhhdzO1ExiUUNFd4pQTnInOxAgqyf0eUSdqf9fGf4ADqTzHos1 ywZFhN8UlbjrBOzPZnyD8ZTVyakxnTGgnKeSkWsclDeJldAylGgwILHjQdvJGQ1yCF Ta2ndNd0iIyvJvB9swtxZqirf7z/BsD/JzVDihvI= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20230621091030eucas1p2b9431b5e8ae4acfd91cec8a259953008~qoYtbzuHT2538825388eucas1p2C; Wed, 21 Jun 2023 09:10:30 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id 1D.84.37758.58EB2946; Wed, 21 Jun 2023 10:10:30 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20230621091029eucas1p2f9fd694dae3dfbdfffd25dccf4fcb568~qoYsgN9G-1816318163eucas1p2-; Wed, 21 Jun 2023 09:10:29 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20230621091029eusmtrp2a0edd6b63446d061037baf6b483c48bb~qoYsaZmkS2225722257eusmtrp2B; Wed, 21 Jun 2023 09:10:29 +0000 (GMT) X-AuditID: cbfec7f5-815ff7000002937e-7e-6492be85d3cb Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id D9.E1.14344.48EB2946; Wed, 21 Jun 2023 10:10:28 +0100 (BST) Received: from CAMSVWEXC02.scsc.local (unknown [106.1.227.72]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20230621091028eusmtip2a2c40ec1c961aabd77e7ae0ea239ab31~qoYr28XcU1980519805eusmtip2i; Wed, 21 Jun 2023 09:10:28 +0000 (GMT) Received: from localhost (106.210.248.248) by CAMSVWEXC02.scsc.local (2002:6a01:e348::6a01:e348) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 21 Jun 2023 10:10:27 +0100 From: Joel Granados To: , Russell King , Catalin Marinas , Will Deacon , Michael Ellerman , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Gerald Schaefer , Andy Lutomirski , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , , Herbert Xu , "David S. Miller" , Russ Weight , Greg Kroah-Hartman , Phillip Potter , Clemens Ladisch , Arnd Bergmann , Corey Minyard , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Benjamin Herrenschmidt , Song Liu , Robin Holt , Steve Wahl , Sudip Mukherjee , Mark Rutland , "James E.J. Bottomley" , "Martin K. Petersen" , Doug Gilbert , David Howells , Jan Harkes , , Alexander Viro , Christian Brauner , Chuck Lever , Jeff Layton , Trond Myklebust , Anna Schumaker , Jan Kara , Anton Altaparmakov , Mark Fasheh , Joel Becker , Joseph Qi , Kees Cook , Iurii Zaikin , Eric Biggers , "Theodore Y. Ts'o" , "Darrick J. Wong" , John Stultz , Eric Dumazet , Jakub Kicinski , Paolo Abeni , John Johansen , Paul Moore , James Morris , "Serge E. Hallyn" CC: Joel Granados , Nicholas Piggin , Christophe Leroy , Christian Borntraeger , Sven Schnelle , "H. Peter Anvin" , "Rafael J. Wysocki" , Mike Travis , Amir Goldstein , Matthew Bobrowski , Stephen Boyd , , , , , , , , , , , , , , , , , , , , , , , Subject: [PATCH 07/11] sysctl: Add size to register_sysctl Date: Wed, 21 Jun 2023 11:09:56 +0200 Message-ID: <20230621091000.424843-8-j.granados@samsung.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230621091000.424843-1-j.granados@samsung.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Originating-IP: [106.210.248.248] X-ClientProxiedBy: CAMSVWEXC01.scsc.local (2002:6a01:e347::6a01:e347) To CAMSVWEXC02.scsc.local (2002:6a01:e348::6a01:e348) X-Brightmail-Tracker: H4sIAAAAAAAAA01Te0xTdxTe797bewsRdi1m/AJsRBS26ETcWHLcREe26M10zswlW3xtBa5g pOBa1OkyQylvnNE6BgJDEOTRIoWKKAQ6x5CHbLxaqEzU8Iq1CK0iIg9hwmUL/33nfN93ft85 yU9MSvoYN/GhiCheHiEN96IdqcqGybZ18QZ1iF+MiYDylkc0NJkvEdBeqkUQVzVHQZW+QgTK hhwRvFQ3MGCPiSNh4GUdDWNlszQM//kUga3gNIJe9UMG5u49JCC/qY+A5yV3CIhWzdBgKUtA kNUWS4EhVo/AkH6FhtGYaQqMg85gGrfRcKVmhoShhn4GkvrnaLCpDkB7xnMRqPJ0NHRf52A4 W4MgxeoBv5a7QubZqwRkpqkIuHw3SQSFRh2CyQINA82tzyko1eUR0PQsjobaXAKKC14wMNNU TsNfKTJorzwjgkHtNQb0A90ieJJ/m4EH9ycJqKltpiD1nJ0Ge+KoCIzVWTS032wRQUJiFoKE i9UIzuaqSEgx33glOd1PQ/XMDQbqUmsRTE/Mij4O4Yym7dxE3BmKK8kuQZyxu4PkpqfUiMuI /pnmMqM7KE5bUk9yOfU7uPGeVoKrKO4huEuPoiluqONLTtejprmqjHsMV3nTe9eGPY6bQvjw Q8d4+frN3zmGJXbqyCMdvxE/jA6Pi6KR0YqSkYMYs/64vKiVSUaOYglbhHBL2zlynpCwzxBu N0oEYgzhyuQiOhmJFxy56eFCvxDhqxoj9b/owS+xtFBcQ7hB00XMj6LZd3Hb415ynljB9qzA 2Y9tzDxBsjUO2F4QNI9d2A9x8/nLC6Eo1ht3jF9a0Dixm/D9Zh0hhPXE8ea0BY0DG4DbBmyU oFmOmy8MUsJMT6y6lkkKGOM/LBZS8K7CZkMeLeCf8O2Kf4j5QJjVLMOp1VOLD3yK1Vlji5dx wdbGCkbAHniu6uKi4TzCv8/aGaHQIlygHF90f4RjTYOLjkDcWKoXCRdzxndGlguJnLG6Mo0U 2k44MV5yFq3OWLJDxpIdMpbskINIDXLljypkobzi/Qj+uK9CKlMcjQj1DY6U6dGrX9gy2zh+ AxVZn/jWIUKM6hAWk14rnN7Uq0MkTiHSEyd5eeS38qPhvKIOuYspL1entQHNwRI2VBrFH+b5 I7z8P5YQO7hFE/7FiVs+/2J90dpY/7vDriO3cps6TtkOvpG3/+v81ebOiVPKigsDhf3Ht76z j9neuHHHhOmkqcsn823tMn5j/i3vfM8Xfrdd1mYZdMemNfa/PWJ2H4h6r90tOVPu97qhac1l sso2G540InPxsRz+QDm0bqusOrl+MruY89oW9iyoxn8vUbClnNlzOmen7cfXwgJ2f2Wx7ht4 emp5drU2zRK036PXuHNXY2Bwf8jBBDbA8cL1vsNsWeSUuQZk3n7uzmbVmLR31d4TnVGp9k92 +tlSyjiW9Em35OUOKR8mTFl9rAwRqEw7QV0E2/SB7z97sbnT/Ru9y8qVruu2PfI3tLyV31Xh RSnCpBvWkHKF9F+mKDof9AQAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA02Te0xbZRiH851zek5ZhNUO5Ii4YXeJ063j7gsy1On0KMSJMSY6BnRQAW2B 9aIDGSkU5CqBLm6zXMelC+M2KiAQIMqQcZmUrhsdk7GMizAgUMZgTm4WGhP+e77f9/zeL98f LxvnZlAO7MgomVASJRDxyB1E3/qNkcPJ7aow5+xMN6jre0RCt7EEg4GaSgQpzRsENGvrWZDY VcyCNVUXBaakFBzG1jpIWLy2TsLM9ccI5jVZCIZVkxRs3J/EoKz7IQbLVXcxUChXSdhozMVh 6loqgnxdMgHtyVoE7ZeqSZhLWiHAMG4Dt5fmSahuXcVhomuUgvTRDRLmlUEwoF5mgbK0loTB XxmYKbyKIHPaES7U2UNezi8Y5F1UYlD+VzoLrhhqEZTcbcTgmeYqBT39ywTU1JZi0P0khYS2 yxhUaP6hYLW7joSbmWIYaMxmwXhlAwXasUEWLJT1UvBg5BkGrW09BPyUayLBlDbHAkNLPgkD v/WxIDUtH0FqUQuCnMtKHDKNTWYla5SEltUm6u2vGMNtP+ZpSjbBVBVWIcYwqMeZlX9ViFEr fiSZPIWeYCqrOnGmuNOfWRrqx5j6iiGMKXmkIJgJ/adM7ZCKZNqWiwmmWX2f+sT1S76PJFou EzpFREtlR3knXcCV7+IFfFd3L76L2xunvF09eEd8fcKEoshvhZIjviH8iLRbtXiMvgA7Ozez xFIgwzTKQGw2zXGnL18SZaAdbC6nHNFDT2+acytz7kjXPbnDsvAuenUwg7RIC4j+Y6iSshwa EF33uGjLIjmHaN3sML55YcsZsqUL7g1ujcI5rVa0SXN6k3dxvOme8+VbOcHZT+uXSqhNtub4 0CM9tZjluT30D8aLW44V5yitG5snNplrdopMBmTxn6d7fh4nLPP30MqGPNzCNP371BRumbOX NraXkhY+Ry+u/Y1ykK16W129ra7eVi9G+FVkK5RLxeFiqStfKhBL5VHh/NBosRaZl6Kx61l9 E6qYXuB3IIyNOhDNxnm21i9rVWFc6zBBbJxQEh0skYuE0g7kYf5nLu5gFxpt3qooWbCLp7OH i7unl7OHl6cbz976w5g0AZcTLpAJvxEKY4SS/3sY28pBgcnfkm+UTR8oT9SEiGRWKuriS7Pp Pv666qhTkhbDF012QRfYx9A7nRvvqpvsxHtjnPa//yJbNvJRY2zCZFDn0mcpaTPaEMPuV/tE k9mpB6N4aGXdJsGoe24u5FY9z89HEfhdqLqXazrRuhOdyYyIHS0M5H8e4dXcG7BbVHjAaZTZ pz/xAT8wPvL619x8eUWK8r2d8zX2cUnnhx0Px6HmxVfuGXcey3r95J2YiuGyM/Su5ePSiYMP 0kUBuvg3ufisM1/v35hwVlt2pT/Aq26/avZ4U6rH2NrD06HMwrkXnErKbHS5Gg/Nn8GJ8X67 Z7sCxN66wBtTlKHAIWZf1se+IqdD3/MIaYTA5TVcIhX8B9lnSFCdBAAA X-CMS-MailID: 20230621091029eucas1p2f9fd694dae3dfbdfffd25dccf4fcb568 X-Msg-Generator: CA X-RootMTR: 20230621091029eucas1p2f9fd694dae3dfbdfffd25dccf4fcb568 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20230621091029eucas1p2f9fd694dae3dfbdfffd25dccf4fcb568 References: <20230621091000.424843-1-j.granados@samsung.com> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net X-Patchwork-Delegate: kuba@kernel.org In order to remove the end element from the ctl_table struct arrays, we explicitly define the size when registering the targes. We add a size argument to register_sysctl and change all the callers to pass the ARRAY_SIZE of their table arg. Signed-off-by: Joel Granados --- arch/arm/kernel/isa.c | 2 +- arch/arm64/kernel/armv8_deprecated.c | 2 +- arch/arm64/kernel/fpsimd.c | 6 +++-- arch/arm64/kernel/process.c | 3 ++- arch/ia64/kernel/crash.c | 3 ++- arch/powerpc/kernel/idle.c | 3 ++- arch/powerpc/platforms/pseries/mobility.c | 3 ++- arch/s390/appldata/appldata_base.c | 4 +++- arch/s390/kernel/debug.c | 3 ++- arch/s390/kernel/topology.c | 3 ++- arch/s390/mm/cmm.c | 3 ++- arch/s390/mm/pgalloc.c | 3 ++- arch/x86/entry/vdso/vdso32-setup.c | 2 +- arch/x86/kernel/itmt.c | 3 ++- crypto/fips.c | 3 ++- drivers/base/firmware_loader/fallback_table.c | 6 ++--- drivers/cdrom/cdrom.c | 3 ++- drivers/char/hpet.c | 3 ++- drivers/char/ipmi/ipmi_poweroff.c | 3 ++- drivers/gpu/drm/i915/i915_perf.c | 3 ++- drivers/hv/hv_common.c | 3 ++- drivers/macintosh/mac_hid.c | 3 ++- drivers/md/md.c | 3 ++- drivers/misc/sgi-xp/xpc_main.c | 6 +++-- drivers/parport/procfs.c | 11 +++++---- drivers/perf/arm_pmuv3.c | 3 ++- drivers/scsi/scsi_sysctl.c | 3 ++- drivers/scsi/sg.c | 3 ++- fs/cachefiles/error_inject.c | 3 ++- fs/coda/sysctl.c | 3 ++- fs/devpts/inode.c | 3 ++- fs/eventpoll.c | 2 +- fs/lockd/svc.c | 3 ++- fs/nfs/nfs4sysctl.c | 3 ++- fs/nfs/sysctl.c | 3 ++- fs/notify/fanotify/fanotify_user.c | 3 ++- fs/notify/inotify/inotify_user.c | 3 ++- fs/ntfs/sysctl.c | 3 ++- fs/ocfs2/stackglue.c | 3 ++- fs/proc/proc_sysctl.c | 23 ++++++++++--------- fs/verity/signature.c | 4 +++- fs/xfs/xfs_sysctl.c | 3 ++- include/linux/sysctl.h | 6 +++-- kernel/pid_sysctl.h | 2 +- kernel/time/timer.c | 2 +- kernel/ucount.c | 2 +- kernel/utsname_sysctl.c | 2 +- lib/test_sysctl.c | 9 +++++--- net/sunrpc/sysctl.c | 3 ++- net/sunrpc/xprtrdma/svc_rdma.c | 3 ++- net/sunrpc/xprtrdma/transport.c | 4 +++- net/sunrpc/xprtsock.c | 4 +++- net/sysctl_net.c | 2 +- security/apparmor/lsm.c | 3 ++- security/loadpin/loadpin.c | 3 ++- security/yama/yama_lsm.c | 3 ++- 56 files changed, 133 insertions(+), 76 deletions(-) diff --git a/arch/arm/kernel/isa.c b/arch/arm/kernel/isa.c index 20218876bef2..561432e3c55a 100644 --- a/arch/arm/kernel/isa.c +++ b/arch/arm/kernel/isa.c @@ -46,5 +46,5 @@ register_isa_ports(unsigned int membase, unsigned int portbase, unsigned int por isa_membase = membase; isa_portbase = portbase; isa_portshift = portshift; - isa_sysctl_header = register_sysctl("bus/isa", ctl_isa_vars); + isa_sysctl_header = register_sysctl("bus/isa", ctl_isa_vars, ARRAY_SIZE(ctl_isa_vars)); } diff --git a/arch/arm64/kernel/armv8_deprecated.c b/arch/arm64/kernel/armv8_deprecated.c index 1febd412b4d2..68ed60a521a6 100644 --- a/arch/arm64/kernel/armv8_deprecated.c +++ b/arch/arm64/kernel/armv8_deprecated.c @@ -569,7 +569,7 @@ static void __init register_insn_emulation(struct insn_emulation *insn) sysctl->extra2 = &insn->max; sysctl->proc_handler = emulation_proc_handler; - register_sysctl("abi", sysctl); + register_sysctl("abi", sysctl, 1); } } diff --git a/arch/arm64/kernel/fpsimd.c b/arch/arm64/kernel/fpsimd.c index 2fbafa5cc7ac..ecfb2ef6a036 100644 --- a/arch/arm64/kernel/fpsimd.c +++ b/arch/arm64/kernel/fpsimd.c @@ -595,7 +595,8 @@ static struct ctl_table sve_default_vl_table[] = { static int __init sve_sysctl_init(void) { if (system_supports_sve()) - if (!register_sysctl("abi", sve_default_vl_table)) + if (!register_sysctl("abi", sve_default_vl_table, + ARRAY_SIZE(sve_default_vl_table))) return -EINVAL; return 0; @@ -619,7 +620,8 @@ static struct ctl_table sme_default_vl_table[] = { static int __init sme_sysctl_init(void) { if (system_supports_sme()) - if (!register_sysctl("abi", sme_default_vl_table)) + if (!register_sysctl("abi", sme_default_vl_table, + ARRAY_SIZE(sme_default_vl_table))) return -EINVAL; return 0; diff --git a/arch/arm64/kernel/process.c b/arch/arm64/kernel/process.c index 0fcc4eb1a7ab..cfe232960f2f 100644 --- a/arch/arm64/kernel/process.c +++ b/arch/arm64/kernel/process.c @@ -729,7 +729,8 @@ static struct ctl_table tagged_addr_sysctl_table[] = { static int __init tagged_addr_init(void) { - if (!register_sysctl("abi", tagged_addr_sysctl_table)) + if (!register_sysctl("abi", tagged_addr_sysctl_table, + ARRAY_SIZE(tagged_addr_sysctl_table))) return -EINVAL; return 0; } diff --git a/arch/ia64/kernel/crash.c b/arch/ia64/kernel/crash.c index 88b3ce3e66cd..66917b879b2a 100644 --- a/arch/ia64/kernel/crash.c +++ b/arch/ia64/kernel/crash.c @@ -248,7 +248,8 @@ machine_crash_setup(void) if((ret = register_die_notifier(&kdump_init_notifier_nb)) != 0) return ret; #ifdef CONFIG_SYSCTL - register_sysctl("kernel", kdump_ctl_table); + register_sysctl("kernel", kdump_ctl_table, + ARRAY_SIZE(kdump_ctl_table)); #endif return 0; } diff --git a/arch/powerpc/kernel/idle.c b/arch/powerpc/kernel/idle.c index b1c0418b25c8..3807169fc7e7 100644 --- a/arch/powerpc/kernel/idle.c +++ b/arch/powerpc/kernel/idle.c @@ -111,7 +111,8 @@ static struct ctl_table powersave_nap_ctl_table[] = { static int __init register_powersave_nap_sysctl(void) { - register_sysctl("kernel", powersave_nap_ctl_table); + register_sysctl("kernel", powersave_nap_ctl_table, + ARRAY_SIZE(powersave_nap_ctl_table)); return 0; } diff --git a/arch/powerpc/platforms/pseries/mobility.c b/arch/powerpc/platforms/pseries/mobility.c index 6f30113b5468..9fdbee8ee126 100644 --- a/arch/powerpc/platforms/pseries/mobility.c +++ b/arch/powerpc/platforms/pseries/mobility.c @@ -65,7 +65,8 @@ static struct ctl_table nmi_wd_lpm_factor_ctl_table[] = { static int __init register_nmi_wd_lpm_factor_sysctl(void) { - register_sysctl("kernel", nmi_wd_lpm_factor_ctl_table); + register_sysctl("kernel", nmi_wd_lpm_factor_ctl_table, + ARRAY_SIZE(nmi_wd_lpm_factor_ctl_table)); return 0; } diff --git a/arch/s390/appldata/appldata_base.c b/arch/s390/appldata/appldata_base.c index b07b0610950e..54d8ed1c4518 100644 --- a/arch/s390/appldata/appldata_base.c +++ b/arch/s390/appldata/appldata_base.c @@ -408,7 +408,9 @@ static int __init appldata_init(void) appldata_wq = alloc_ordered_workqueue("appldata", 0); if (!appldata_wq) return -ENOMEM; - appldata_sysctl_header = register_sysctl(appldata_proc_name, appldata_table); + appldata_sysctl_header = register_sysctl(appldata_proc_name, + appldata_table, + ARRAY_SIZE(appldata_table)); return 0; } diff --git a/arch/s390/kernel/debug.c b/arch/s390/kernel/debug.c index a85e0c3e7027..002f843e6523 100644 --- a/arch/s390/kernel/debug.c +++ b/arch/s390/kernel/debug.c @@ -1564,7 +1564,8 @@ static int debug_sprintf_format_fn(debug_info_t *id, struct debug_view *view, */ static int __init debug_init(void) { - s390dbf_sysctl_header = register_sysctl("s390dbf", s390dbf_table); + s390dbf_sysctl_header = register_sysctl("s390dbf", s390dbf_table, + ARRAY_SIZE(s390dbf_table)); mutex_lock(&debug_mutex); debug_debugfs_root_entry = debugfs_create_dir(DEBUG_DIR_ROOT, NULL); initialized = 1; diff --git a/arch/s390/kernel/topology.c b/arch/s390/kernel/topology.c index 9fd19530c9a5..372d2c7c9a8e 100644 --- a/arch/s390/kernel/topology.c +++ b/arch/s390/kernel/topology.c @@ -647,7 +647,8 @@ static int __init topology_init(void) set_topology_timer(); else topology_update_polarization_simple(); - register_sysctl("s390", topology_ctl_table); + register_sysctl("s390", topology_ctl_table, + ARRAY_SIZE(topology_ctl_table)); dev_root = bus_get_dev_root(&cpu_subsys); if (dev_root) { diff --git a/arch/s390/mm/cmm.c b/arch/s390/mm/cmm.c index 5300c6867d5e..918816dcb42a 100644 --- a/arch/s390/mm/cmm.c +++ b/arch/s390/mm/cmm.c @@ -379,7 +379,8 @@ static int __init cmm_init(void) { int rc = -ENOMEM; - cmm_sysctl_header = register_sysctl("vm", cmm_table); + cmm_sysctl_header = register_sysctl("vm", cmm_table, + ARRAY_SIZE(cmm_table)); if (!cmm_sysctl_header) goto out_sysctl; #ifdef CONFIG_CMM_IUCV diff --git a/arch/s390/mm/pgalloc.c b/arch/s390/mm/pgalloc.c index 66ab68db9842..a723f1a8236a 100644 --- a/arch/s390/mm/pgalloc.c +++ b/arch/s390/mm/pgalloc.c @@ -35,7 +35,8 @@ static struct ctl_table page_table_sysctl[] = { static int __init page_table_register_sysctl(void) { - return register_sysctl("vm", page_table_sysctl) ? 0 : -ENOMEM; + return register_sysctl("vm", page_table_sysctl, + ARRAY_SIZE(page_table_sysctl)) ? 0 : -ENOMEM; } __initcall(page_table_register_sysctl); diff --git a/arch/x86/entry/vdso/vdso32-setup.c b/arch/x86/entry/vdso/vdso32-setup.c index f3b3cacbcbb0..e28cdba83e0e 100644 --- a/arch/x86/entry/vdso/vdso32-setup.c +++ b/arch/x86/entry/vdso/vdso32-setup.c @@ -72,7 +72,7 @@ static struct ctl_table abi_table2[] = { static __init int ia32_binfmt_init(void) { - register_sysctl("abi", abi_table2); + register_sysctl("abi", abi_table2, ARRAY_SIZE(abi_table2)); return 0; } __initcall(ia32_binfmt_init); diff --git a/arch/x86/kernel/itmt.c b/arch/x86/kernel/itmt.c index 670eb08b972a..58ec95fce798 100644 --- a/arch/x86/kernel/itmt.c +++ b/arch/x86/kernel/itmt.c @@ -105,7 +105,8 @@ int sched_set_itmt_support(void) return 0; } - itmt_sysctl_header = register_sysctl("kernel", itmt_kern_table); + itmt_sysctl_header = register_sysctl("kernel", itmt_kern_table, + ARRAY_SIZE(itmt_kern_table)); if (!itmt_sysctl_header) { mutex_unlock(&itmt_update_mutex); return -ENOMEM; diff --git a/crypto/fips.c b/crypto/fips.c index 92fd506abb21..05a251680700 100644 --- a/crypto/fips.c +++ b/crypto/fips.c @@ -70,7 +70,8 @@ static struct ctl_table_header *crypto_sysctls; static void crypto_proc_fips_init(void) { - crypto_sysctls = register_sysctl("crypto", crypto_sysctl_table); + crypto_sysctls = register_sysctl("crypto", crypto_sysctl_table, + ARRAY_SIZE(crypto_sysctl_table)); } static void crypto_proc_fips_exit(void) diff --git a/drivers/base/firmware_loader/fallback_table.c b/drivers/base/firmware_loader/fallback_table.c index e5ac098d0742..7a2d584233bb 100644 --- a/drivers/base/firmware_loader/fallback_table.c +++ b/drivers/base/firmware_loader/fallback_table.c @@ -50,9 +50,9 @@ static struct ctl_table firmware_config_table[] = { static struct ctl_table_header *firmware_config_sysct_table_header; int register_firmware_config_sysctl(void) { - firmware_config_sysct_table_header = - register_sysctl("kernel/firmware_config", - firmware_config_table); + firmware_config_sysct_table_header = register_sysctl("kernel/firmware_config", + firmware_config_table, + ARRAY_SIZE(firmware_config_table)); if (!firmware_config_sysct_table_header) return -ENOMEM; return 0; diff --git a/drivers/cdrom/cdrom.c b/drivers/cdrom/cdrom.c index 416f723a2dbb..3855da76a16d 100644 --- a/drivers/cdrom/cdrom.c +++ b/drivers/cdrom/cdrom.c @@ -3680,7 +3680,8 @@ static void cdrom_sysctl_register(void) if (!atomic_add_unless(&initialized, 1, 1)) return; - cdrom_sysctl_header = register_sysctl("dev/cdrom", cdrom_table); + cdrom_sysctl_header = register_sysctl("dev/cdrom", cdrom_table, + ARRAY_SIZE(cdrom_table)); /* set the defaults */ cdrom_sysctl_settings.autoclose = autoclose; diff --git a/drivers/char/hpet.c b/drivers/char/hpet.c index ee71376f174b..bb1eb801b20c 100644 --- a/drivers/char/hpet.c +++ b/drivers/char/hpet.c @@ -1027,7 +1027,8 @@ static int __init hpet_init(void) if (result < 0) return -ENODEV; - sysctl_header = register_sysctl("dev/hpet", hpet_table); + sysctl_header = register_sysctl("dev/hpet", hpet_table, + ARRAY_SIZE(hpet_table)); result = acpi_bus_register_driver(&hpet_acpi_driver); if (result < 0) { diff --git a/drivers/char/ipmi/ipmi_poweroff.c b/drivers/char/ipmi/ipmi_poweroff.c index 870659d91db2..46b1ea866da9 100644 --- a/drivers/char/ipmi/ipmi_poweroff.c +++ b/drivers/char/ipmi/ipmi_poweroff.c @@ -675,7 +675,8 @@ static int __init ipmi_poweroff_init(void) pr_info("Power cycle is enabled\n"); #ifdef CONFIG_PROC_FS - ipmi_table_header = register_sysctl("dev/ipmi", ipmi_table); + ipmi_table_header = register_sysctl("dev/ipmi", ipmi_table, + ARRAY_SIZE(ipmi_table)); if (!ipmi_table_header) { pr_err("Unable to register powercycle sysctl\n"); rv = -ENOMEM; diff --git a/drivers/gpu/drm/i915/i915_perf.c b/drivers/gpu/drm/i915/i915_perf.c index 050b8ae7b8e7..f43950219ffc 100644 --- a/drivers/gpu/drm/i915/i915_perf.c +++ b/drivers/gpu/drm/i915/i915_perf.c @@ -5266,7 +5266,8 @@ static int destroy_config(int id, void *p, void *data) int i915_perf_sysctl_register(void) { - sysctl_header = register_sysctl("dev/i915", oa_table); + sysctl_header = register_sysctl("dev/i915", oa_table, + ARRAY_SIZE(oa_table)); return 0; } diff --git a/drivers/hv/hv_common.c b/drivers/hv/hv_common.c index 64f9ceca887b..dd751c391cf7 100644 --- a/drivers/hv/hv_common.c +++ b/drivers/hv/hv_common.c @@ -302,7 +302,8 @@ int __init hv_common_init(void) * message recording won't be available in isolated * guests should the following registration fail. */ - hv_ctl_table_hdr = register_sysctl("kernel", hv_ctl_table); + hv_ctl_table_hdr = register_sysctl("kernel", hv_ctl_table, + ARRAY_SIZE(hv_ctl_table)); if (!hv_ctl_table_hdr) pr_err("Hyper-V: sysctl table register error"); diff --git a/drivers/macintosh/mac_hid.c b/drivers/macintosh/mac_hid.c index d8c4d5664145..5d433ef430fa 100644 --- a/drivers/macintosh/mac_hid.c +++ b/drivers/macintosh/mac_hid.c @@ -243,7 +243,8 @@ static struct ctl_table_header *mac_hid_sysctl_header; static int __init mac_hid_init(void) { - mac_hid_sysctl_header = register_sysctl("dev/mac_hid", mac_hid_files); + mac_hid_sysctl_header = register_sysctl("dev/mac_hid", mac_hid_files, + ARRAY_SIZE(mac_hid_files)); if (!mac_hid_sysctl_header) return -ENOMEM; diff --git a/drivers/md/md.c b/drivers/md/md.c index 8e344b4b3444..c10cc8ddd94d 100644 --- a/drivers/md/md.c +++ b/drivers/md/md.c @@ -9633,7 +9633,8 @@ static int __init md_init(void) mdp_major = ret; register_reboot_notifier(&md_notifier); - raid_table_header = register_sysctl("dev/raid", raid_table); + raid_table_header = register_sysctl("dev/raid", raid_table, + ARRAY_SIZE(raid_table)); md_geninit(); return 0; diff --git a/drivers/misc/sgi-xp/xpc_main.c b/drivers/misc/sgi-xp/xpc_main.c index 6da509d692bb..264b919d0610 100644 --- a/drivers/misc/sgi-xp/xpc_main.c +++ b/drivers/misc/sgi-xp/xpc_main.c @@ -1236,8 +1236,10 @@ xpc_init(void) goto out_1; } - xpc_sysctl = register_sysctl("xpc", xpc_sys_xpc); - xpc_sysctl_hb = register_sysctl("xpc/hb", xpc_sys_xpc_hb); + xpc_sysctl = register_sysctl("xpc", xpc_sys_xpc, + ARRAY_SIZE(xpc_sys_xpc)); + xpc_sysctl_hb = register_sysctl("xpc/hb", xpc_sys_xpc_hb, + ARRAY_SIZE(xpc_sys_xpc_hb)); /* * Fill the partition reserved page with the information needed by diff --git a/drivers/parport/procfs.c b/drivers/parport/procfs.c index 4e5b972c3e26..16cee52f035f 100644 --- a/drivers/parport/procfs.c +++ b/drivers/parport/procfs.c @@ -464,7 +464,8 @@ int parport_proc_register(struct parport *port) err = -ENOENT; goto exit_free_tmp_dir_path; } - t->devices_header = register_sysctl(tmp_dir_path, t->device_dir); + t->devices_header = register_sysctl(tmp_dir_path, t->device_dir, + ARRAY_SIZE(t->device_dir)); if (t->devices_header == NULL) { err = -ENOENT; goto exit_free_tmp_dir_path; @@ -478,7 +479,8 @@ int parport_proc_register(struct parport *port) goto unregister_devices_h; } - t->port_header = register_sysctl(tmp_dir_path, t->vars); + t->port_header = register_sysctl(tmp_dir_path, t->vars, + ARRAY_SIZE(t->vars)); if (t->port_header == NULL) { err = -ENOENT; goto unregister_devices_h; @@ -544,7 +546,7 @@ int parport_device_proc_register(struct pardevice *device) t->vars[0].data = &device->timeslice; - t->sysctl_header = register_sysctl(tmp_dir_path, t->vars); + t->sysctl_header = register_sysctl(tmp_dir_path, t->vars, ARRAY_SIZE(t->vars)); if (t->sysctl_header == NULL) { kfree(t); t = NULL; @@ -579,7 +581,8 @@ static int __init parport_default_proc_register(void) int ret; parport_default_sysctl_table.sysctl_header = - register_sysctl("dev/parport/default", parport_default_sysctl_table.vars); + register_sysctl("dev/parport/default", parport_default_sysctl_table.vars, + ARRAY_SIZE(parport_default_sysctl_table.vars)); if (!parport_default_sysctl_table.sysctl_header) return -ENOMEM; ret = parport_bus_init(); diff --git a/drivers/perf/arm_pmuv3.c b/drivers/perf/arm_pmuv3.c index c98e4039386d..763f9c8acfbf 100644 --- a/drivers/perf/arm_pmuv3.c +++ b/drivers/perf/arm_pmuv3.c @@ -1188,7 +1188,8 @@ static void armv8_pmu_register_sysctl_table(void) static u32 tbl_registered = 0; if (!cmpxchg_relaxed(&tbl_registered, 0, 1)) - register_sysctl("kernel", armv8_pmu_sysctl_table); + register_sysctl("kernel", armv8_pmu_sysctl_table, + ARRAY_SIZE(armv8_pmu_sysctl_table)); } static int armv8_pmu_init(struct arm_pmu *cpu_pmu, char *name, diff --git a/drivers/scsi/scsi_sysctl.c b/drivers/scsi/scsi_sysctl.c index 7f0914ea168f..0378bd63fea4 100644 --- a/drivers/scsi/scsi_sysctl.c +++ b/drivers/scsi/scsi_sysctl.c @@ -25,7 +25,8 @@ static struct ctl_table_header *scsi_table_header; int __init scsi_init_sysctl(void) { - scsi_table_header = register_sysctl("dev/scsi", scsi_table); + scsi_table_header = register_sysctl("dev/scsi", scsi_table, + ARRAY_SIZE(scsi_table)); if (!scsi_table_header) return -ENOMEM; return 0; diff --git a/drivers/scsi/sg.c b/drivers/scsi/sg.c index 037f8c98a6d3..d12cdf875b50 100644 --- a/drivers/scsi/sg.c +++ b/drivers/scsi/sg.c @@ -1646,7 +1646,8 @@ static struct ctl_table_header *hdr; static void register_sg_sysctls(void) { if (!hdr) - hdr = register_sysctl("kernel", sg_sysctls); + hdr = register_sysctl("kernel", sg_sysctls, + ARRAY_SIZE(sg_sysctls)); } static void unregister_sg_sysctls(void) diff --git a/fs/cachefiles/error_inject.c b/fs/cachefiles/error_inject.c index 18de8a876b02..ea6bcce4f6f1 100644 --- a/fs/cachefiles/error_inject.c +++ b/fs/cachefiles/error_inject.c @@ -24,7 +24,8 @@ static struct ctl_table cachefiles_sysctls[] = { int __init cachefiles_register_error_injection(void) { - cachefiles_sysctl = register_sysctl("cachefiles", cachefiles_sysctls); + cachefiles_sysctl = register_sysctl("cachefiles", cachefiles_sysctls, + ARRAY_SIZE(cachefiles_sysctls)); if (!cachefiles_sysctl) return -ENOMEM; return 0; diff --git a/fs/coda/sysctl.c b/fs/coda/sysctl.c index a247c14aaab7..16224a7c6691 100644 --- a/fs/coda/sysctl.c +++ b/fs/coda/sysctl.c @@ -42,7 +42,8 @@ static struct ctl_table coda_table[] = { void coda_sysctl_init(void) { if ( !fs_table_header ) - fs_table_header = register_sysctl("coda", coda_table); + fs_table_header = register_sysctl("coda", coda_table, + ARRAY_SIZE(coda_table)); } void coda_sysctl_clean(void) diff --git a/fs/devpts/inode.c b/fs/devpts/inode.c index fe3db0eda8e4..c17f971a8c4b 100644 --- a/fs/devpts/inode.c +++ b/fs/devpts/inode.c @@ -612,7 +612,8 @@ static int __init init_devpts_fs(void) { int err = register_filesystem(&devpts_fs_type); if (!err) { - register_sysctl("kernel/pty", pty_table); + register_sysctl("kernel/pty", pty_table, + ARRAY_SIZE(pty_table)); } return err; } diff --git a/fs/eventpoll.c b/fs/eventpoll.c index 980483455cc0..e1a0e6a6d3de 100644 --- a/fs/eventpoll.c +++ b/fs/eventpoll.c @@ -327,7 +327,7 @@ static struct ctl_table epoll_table[] = { static void __init epoll_sysctls_init(void) { - register_sysctl("fs/epoll", epoll_table); + register_sysctl("fs/epoll", epoll_table, ARRAY_SIZE(epoll_table)); } #else #define epoll_sysctls_init() do { } while (0) diff --git a/fs/lockd/svc.c b/fs/lockd/svc.c index bb94949bc223..84736267f4e1 100644 --- a/fs/lockd/svc.c +++ b/fs/lockd/svc.c @@ -626,7 +626,8 @@ static int __init init_nlm(void) #ifdef CONFIG_SYSCTL err = -ENOMEM; - nlm_sysctl_table = register_sysctl("fs/nfs", nlm_sysctls); + nlm_sysctl_table = register_sysctl("fs/nfs", nlm_sysctls, + ARRAY_SIZE(nlm_sysctls)); if (nlm_sysctl_table == NULL) goto err_sysctl; #endif diff --git a/fs/nfs/nfs4sysctl.c b/fs/nfs/nfs4sysctl.c index e776200e9a11..4a542ee11e68 100644 --- a/fs/nfs/nfs4sysctl.c +++ b/fs/nfs/nfs4sysctl.c @@ -40,7 +40,8 @@ static struct ctl_table nfs4_cb_sysctls[] = { int nfs4_register_sysctl(void) { nfs4_callback_sysctl_table = register_sysctl("fs/nfs", - nfs4_cb_sysctls); + nfs4_cb_sysctls, + ARRAY_SIZE(nfs4_cb_sysctls)); if (nfs4_callback_sysctl_table == NULL) return -ENOMEM; return 0; diff --git a/fs/nfs/sysctl.c b/fs/nfs/sysctl.c index f39e2089bc4c..9dafd44670e4 100644 --- a/fs/nfs/sysctl.c +++ b/fs/nfs/sysctl.c @@ -34,7 +34,8 @@ static struct ctl_table nfs_cb_sysctls[] = { int nfs_register_sysctl(void) { - nfs_callback_sysctl_table = register_sysctl("fs/nfs", nfs_cb_sysctls); + nfs_callback_sysctl_table = register_sysctl("fs/nfs", nfs_cb_sysctls, + ARRAY_SIZE(nfs_cb_sysctls)); if (nfs_callback_sysctl_table == NULL) return -ENOMEM; return 0; diff --git a/fs/notify/fanotify/fanotify_user.c b/fs/notify/fanotify/fanotify_user.c index 22fb1cf7e1fc..78d3bf479f59 100644 --- a/fs/notify/fanotify/fanotify_user.c +++ b/fs/notify/fanotify/fanotify_user.c @@ -91,7 +91,8 @@ static struct ctl_table fanotify_table[] = { static void __init fanotify_sysctls_init(void) { - register_sysctl("fs/fanotify", fanotify_table); + register_sysctl("fs/fanotify", fanotify_table, + ARRAY_SIZE(fanotify_table)); } #else #define fanotify_sysctls_init() do { } while (0) diff --git a/fs/notify/inotify/inotify_user.c b/fs/notify/inotify/inotify_user.c index 1c4bfdab008d..0ce25c4ddfec 100644 --- a/fs/notify/inotify/inotify_user.c +++ b/fs/notify/inotify/inotify_user.c @@ -90,7 +90,8 @@ static struct ctl_table inotify_table[] = { static void __init inotify_sysctls_init(void) { - register_sysctl("fs/inotify", inotify_table); + register_sysctl("fs/inotify", inotify_table, + ARRAY_SIZE(inotify_table)); } #else diff --git a/fs/ntfs/sysctl.c b/fs/ntfs/sysctl.c index 174fe536a1c0..2c48f48a0b80 100644 --- a/fs/ntfs/sysctl.c +++ b/fs/ntfs/sysctl.c @@ -44,7 +44,8 @@ int ntfs_sysctl(int add) { if (add) { BUG_ON(sysctls_root_table); - sysctls_root_table = register_sysctl("fs", ntfs_sysctls); + sysctls_root_table = register_sysctl("fs", ntfs_sysctls, + ARRAY_SIZE(ntfs_sysctls)); if (!sysctls_root_table) return -ENOMEM; } else { diff --git a/fs/ocfs2/stackglue.c b/fs/ocfs2/stackglue.c index a8d5ca98fa57..9a653875d1c5 100644 --- a/fs/ocfs2/stackglue.c +++ b/fs/ocfs2/stackglue.c @@ -673,7 +673,8 @@ static int __init ocfs2_stack_glue_init(void) strcpy(cluster_stack_name, OCFS2_STACK_PLUGIN_O2CB); - ocfs2_table_header = register_sysctl("fs/ocfs2/nm", ocfs2_nm_table); + ocfs2_table_header = register_sysctl("fs/ocfs2/nm", ocfs2_nm_table, + ARRAY_SIZE(ocfs2_nm_table)); if (!ocfs2_table_header) { printk(KERN_ERR "ocfs2 stack glue: unable to register sysctl\n"); diff --git a/fs/proc/proc_sysctl.c b/fs/proc/proc_sysctl.c index 8c415048d540..66c9d7a07d2e 100644 --- a/fs/proc/proc_sysctl.c +++ b/fs/proc/proc_sysctl.c @@ -43,7 +43,7 @@ struct ctl_table sysctl_mount_point[] = { */ struct ctl_table_header *register_sysctl_mount_point(const char *path) { - return register_sysctl(path, sysctl_mount_point); + return register_sysctl(path, sysctl_mount_point, 0); } EXPORT_SYMBOL(register_sysctl_mount_point); @@ -1414,17 +1414,11 @@ struct ctl_table_header *__register_sysctl_table( * * See __register_sysctl_table for more details. */ -struct ctl_table_header *register_sysctl(const char *path, struct ctl_table *table) +struct ctl_table_header *register_sysctl(const char *path, struct ctl_table *table, + size_t table_size) { - int count = 0; - struct ctl_table *entry; - struct ctl_table_header t_hdr; - - t_hdr.ctl_table = table; - list_for_each_table_entry(entry, (&t_hdr)) - count++; return __register_sysctl_table(&sysctl_table_root.default_set, - path, table, count); + path, table, table_size); } EXPORT_SYMBOL(register_sysctl); @@ -1451,7 +1445,14 @@ EXPORT_SYMBOL(register_sysctl); void __init __register_sysctl_init(const char *path, struct ctl_table *table, const char *table_name) { - struct ctl_table_header *hdr = register_sysctl(path, table); + int count = 0; + struct ctl_table *entry; + struct ctl_table_header t_hdr, *hdr; + + t_hdr.ctl_table = table; + list_for_each_table_entry(entry, (&t_hdr)) + count++; + hdr = register_sysctl(path, table, count); if (unlikely(!hdr)) { pr_err("failed when register_sysctl %s to %s\n", table_name, path); diff --git a/fs/verity/signature.c b/fs/verity/signature.c index b8c51ad40d3a..f617c6a1f16c 100644 --- a/fs/verity/signature.c +++ b/fs/verity/signature.c @@ -103,7 +103,9 @@ static struct ctl_table fsverity_sysctl_table[] = { static int __init fsverity_sysctl_init(void) { - fsverity_sysctl_header = register_sysctl("fs/verity", fsverity_sysctl_table); + fsverity_sysctl_header = register_sysctl("fs/verity", + fsverity_sysctl_table, + ARRAY_SIZE(fsverity_sysctl_table)); if (!fsverity_sysctl_header) { pr_err("sysctl registration failed!\n"); return -ENOMEM; diff --git a/fs/xfs/xfs_sysctl.c b/fs/xfs/xfs_sysctl.c index fade33735393..61075e9c9e37 100644 --- a/fs/xfs/xfs_sysctl.c +++ b/fs/xfs/xfs_sysctl.c @@ -213,7 +213,8 @@ static struct ctl_table xfs_table[] = { int xfs_sysctl_register(void) { - xfs_table_header = register_sysctl("fs/xfs", xfs_table); + xfs_table_header = register_sysctl("fs/xfs", xfs_table, + ARRAY_SIZE(xfs_table)); if (!xfs_table_header) return -ENOMEM; return 0; diff --git a/include/linux/sysctl.h b/include/linux/sysctl.h index 0495c858989f..71d7935e50f0 100644 --- a/include/linux/sysctl.h +++ b/include/linux/sysctl.h @@ -227,7 +227,8 @@ extern void retire_sysctl_set(struct ctl_table_set *set); struct ctl_table_header *__register_sysctl_table( struct ctl_table_set *set, const char *path, struct ctl_table *table, size_t table_size); -struct ctl_table_header *register_sysctl(const char *path, struct ctl_table *table); +struct ctl_table_header *register_sysctl(const char *path, struct ctl_table *table, + size_t table_size); void unregister_sysctl_table(struct ctl_table_header * table); extern int sysctl_init_bases(void); @@ -262,7 +263,8 @@ static inline struct ctl_table_header *register_sysctl_mount_point(const char *p return NULL; } -static inline struct ctl_table_header *register_sysctl(const char *path, struct ctl_table *table) +static inline struct ctl_table_header *register_sysctl(const char *path, struct ctl_table *table, + size_t table_size) { return NULL; } diff --git a/kernel/pid_sysctl.h b/kernel/pid_sysctl.h index d67a4d45bb42..8b24744752cb 100644 --- a/kernel/pid_sysctl.h +++ b/kernel/pid_sysctl.h @@ -48,7 +48,7 @@ static struct ctl_table pid_ns_ctl_table_vm[] = { }; static inline void register_pid_ns_sysctl_table_vm(void) { - register_sysctl("vm", pid_ns_ctl_table_vm); + register_sysctl("vm", pid_ns_ctl_table_vm, ARRAY_SIZE(pid_ns_ctl_table_vm)); } #else static inline void initialize_memfd_noexec_scope(struct pid_namespace *ns) {} diff --git a/kernel/time/timer.c b/kernel/time/timer.c index 63a8ce7177dd..de385b365a7a 100644 --- a/kernel/time/timer.c +++ b/kernel/time/timer.c @@ -265,7 +265,7 @@ static struct ctl_table timer_sysctl[] = { static int __init timer_sysctl_init(void) { - register_sysctl("kernel", timer_sysctl); + register_sysctl("kernel", timer_sysctl, ARRAY_SIZE(timer_sysctl)); return 0; } device_initcall(timer_sysctl_init); diff --git a/kernel/ucount.c b/kernel/ucount.c index 2b80264bb79f..59bf6983f1cf 100644 --- a/kernel/ucount.c +++ b/kernel/ucount.c @@ -365,7 +365,7 @@ static __init int user_namespace_sysctl_init(void) * default set so that registrations in the child sets work * properly. */ - user_header = register_sysctl("user", empty); + user_header = register_sysctl("user", empty, 0); kmemleak_ignore(user_header); BUG_ON(!user_header); BUG_ON(!setup_userns_sysctls(&init_user_ns)); diff --git a/kernel/utsname_sysctl.c b/kernel/utsname_sysctl.c index 019e3a1566cf..24527b155538 100644 --- a/kernel/utsname_sysctl.c +++ b/kernel/utsname_sysctl.c @@ -138,7 +138,7 @@ void uts_proc_notify(enum uts_proc proc) static int __init utsname_sysctl_init(void) { - register_sysctl("kernel", uts_kern_table); + register_sysctl("kernel", uts_kern_table, ARRAY_SIZE(uts_kern_table)); return 0; } diff --git a/lib/test_sysctl.c b/lib/test_sysctl.c index 8036aa91a1cb..83d37a163836 100644 --- a/lib/test_sysctl.c +++ b/lib/test_sysctl.c @@ -166,7 +166,8 @@ static int test_sysctl_setup_node_tests(void) test_data.bitmap_0001 = kzalloc(SYSCTL_TEST_BITMAP_SIZE/8, GFP_KERNEL); if (!test_data.bitmap_0001) return -ENOMEM; - sysctl_test_headers.test_h_setup_node = register_sysctl("debug/test_sysctl", test_table); + sysctl_test_headers.test_h_setup_node = register_sysctl("debug/test_sysctl", test_table, + ARRAY_SIZE(test_table)); if (!sysctl_test_headers.test_h_setup_node) { kfree(test_data.bitmap_0001); return -ENOMEM; @@ -192,7 +193,8 @@ static int test_sysctl_run_unregister_nested(void) struct ctl_table_header *unregister; unregister = register_sysctl("debug/test_sysctl/unregister_error", - test_table_unregister); + test_table_unregister, + ARRAY_SIZE(test_table_unregister)); if (!unregister) return -ENOMEM; @@ -209,7 +211,8 @@ static int test_sysctl_run_register_mount_point(void) sysctl_test_headers.test_h_mnterror = register_sysctl("debug/test_sysctl/mnt/mnt_error", - test_table_unregister); + test_table_unregister, + ARRAY_SIZE(test_table_unregister)); /* * Don't check the result.: * If it fails (expected behavior), return 0. diff --git a/net/sunrpc/sysctl.c b/net/sunrpc/sysctl.c index 93941ab12549..61222addda7e 100644 --- a/net/sunrpc/sysctl.c +++ b/net/sunrpc/sysctl.c @@ -167,7 +167,8 @@ void rpc_register_sysctl(void) { if (!sunrpc_table_header) - sunrpc_table_header = register_sysctl("sunrpc", debug_table); + sunrpc_table_header = register_sysctl("sunrpc", debug_table, + ARRAY_SIZE(debug_table)); } void diff --git a/net/sunrpc/xprtrdma/svc_rdma.c b/net/sunrpc/xprtrdma/svc_rdma.c index f0d5eeed4c88..df7fb9c8b785 100644 --- a/net/sunrpc/xprtrdma/svc_rdma.c +++ b/net/sunrpc/xprtrdma/svc_rdma.c @@ -246,7 +246,8 @@ static int svc_rdma_proc_init(void) goto out_err; svcrdma_table_header = register_sysctl("sunrpc/svc_rdma", - svcrdma_parm_table); + svcrdma_parm_table, + ARRAY_SIZE(svcrdma_parm_table)); return 0; out_err: diff --git a/net/sunrpc/xprtrdma/transport.c b/net/sunrpc/xprtrdma/transport.c index 29b0562d62e7..bf43e05044a3 100644 --- a/net/sunrpc/xprtrdma/transport.c +++ b/net/sunrpc/xprtrdma/transport.c @@ -790,7 +790,9 @@ int xprt_rdma_init(void) #if IS_ENABLED(CONFIG_SUNRPC_DEBUG) if (!sunrpc_table_header) - sunrpc_table_header = register_sysctl("sunrpc", xr_tunables_table); + sunrpc_table_header = register_sysctl("sunrpc", + xr_tunables_table, + ARRAY_SIZE(xr_tunables_table)); #endif return 0; } diff --git a/net/sunrpc/xprtsock.c b/net/sunrpc/xprtsock.c index 5f9030b81c9e..7c3d5ed708be 100644 --- a/net/sunrpc/xprtsock.c +++ b/net/sunrpc/xprtsock.c @@ -3169,7 +3169,9 @@ static struct xprt_class xs_bc_tcp_transport = { int init_socket_xprt(void) { if (!sunrpc_table_header) - sunrpc_table_header = register_sysctl("sunrpc", xs_tunables_table); + sunrpc_table_header = register_sysctl("sunrpc", + xs_tunables_table, + ARRAY_SIZE(xs_tunables_table)); xprt_register_transport(&xs_local_transport); xprt_register_transport(&xs_udp_transport); diff --git a/net/sysctl_net.c b/net/sysctl_net.c index 1757c18ea065..f96e6633fdd3 100644 --- a/net/sysctl_net.c +++ b/net/sysctl_net.c @@ -101,7 +101,7 @@ __init int net_sysctl_init(void) * registering "/proc/sys/net" as an empty directory not in a * network namespace. */ - net_header = register_sysctl("net", empty); + net_header = register_sysctl("net", empty, 0); if (!net_header) goto out; ret = register_pernet_subsys(&sysctl_pernet_ops); diff --git a/security/apparmor/lsm.c b/security/apparmor/lsm.c index f431251ffb91..b77344506cf3 100644 --- a/security/apparmor/lsm.c +++ b/security/apparmor/lsm.c @@ -1785,7 +1785,8 @@ static struct ctl_table apparmor_sysctl_table[] = { static int __init apparmor_init_sysctl(void) { - return register_sysctl("kernel", apparmor_sysctl_table) ? 0 : -ENOMEM; + return register_sysctl("kernel", apparmor_sysctl_table, + ARRAY_SIZE(apparmor_sysctl_table)) ? 0 : -ENOMEM; } #else static inline int apparmor_init_sysctl(void) diff --git a/security/loadpin/loadpin.c b/security/loadpin/loadpin.c index ebae964f7cc9..6f2cc827df41 100644 --- a/security/loadpin/loadpin.c +++ b/security/loadpin/loadpin.c @@ -256,7 +256,8 @@ static int __init loadpin_init(void) enforce ? "" : "not "); parse_exclude(); #ifdef CONFIG_SYSCTL - if (!register_sysctl("kernel/loadpin", loadpin_sysctl_table)) + if (!register_sysctl("kernel/loadpin", loadpin_sysctl_table, + ARRAY_SIZE(loadpin_sysctl_table))) pr_notice("sysctl registration failed!\n"); #endif security_add_hooks(loadpin_hooks, ARRAY_SIZE(loadpin_hooks), "loadpin"); diff --git a/security/yama/yama_lsm.c b/security/yama/yama_lsm.c index 2503cf153d4a..7b8164a4b504 100644 --- a/security/yama/yama_lsm.c +++ b/security/yama/yama_lsm.c @@ -461,7 +461,8 @@ static struct ctl_table yama_sysctl_table[] = { }; static void __init yama_init_sysctl(void) { - if (!register_sysctl("kernel/yama", yama_sysctl_table)) + if (!register_sysctl("kernel/yama", yama_sysctl_table, + ARRAY_SIZE(yama_sysctl_table))) panic("Yama: sysctl registration failed.\n"); } #else From patchwork Wed Jun 21 09:09:57 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joel Granados X-Patchwork-Id: 13286918 X-Patchwork-Delegate: bpf@iogearbox.net Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AB965C2DE for ; Wed, 21 Jun 2023 09:10:57 +0000 (UTC) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 20D61211D; Wed, 21 Jun 2023 02:10:40 -0700 (PDT) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20230621091038euoutp01e123bf7eae2cf2239ff74cab5dc393bb~qoY0vfCZa1411914119euoutp01Y; Wed, 21 Jun 2023 09:10:38 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20230621091038euoutp01e123bf7eae2cf2239ff74cab5dc393bb~qoY0vfCZa1411914119euoutp01Y DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1687338638; bh=QatUAmwjfSE5CpygwEgoo8d+plIGyvB6WfjKfmq8pF4=; h=From:To:CC:Subject:Date:In-Reply-To:References:From; b=WBbh3ysmBwasQEKtTmaoGsleQTqlgmC4R8U/+mJGvSWtNFexng/wooaURelQr0+Ix 8bW/6HMQT73Ttuk4jBTTZ0Ql7yFJyGuRmdDguixw0HvwHLYcsOK8JUwaCs1YNo80PM 2YVN8Dq1QLsiAczxi+aWjbg8pywEOsXt/1a01AMI= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20230621091037eucas1p17e649ac102168b47064feeb1a5d9d0d7~qoY0XqSpU2864928649eucas1p1t; Wed, 21 Jun 2023 09:10:37 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id B0.AE.11320.D8EB2946; Wed, 21 Jun 2023 10:10:37 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20230621091037eucas1p188e11d8064526a5a0549217d5a419647~qoYzsEdLT3017130171eucas1p10; Wed, 21 Jun 2023 09:10:37 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20230621091036eusmtrp23053e0e91e9e88b462059cc6e116b0c7~qoYzpFHdu2207922079eusmtrp2g; Wed, 21 Jun 2023 09:10:36 +0000 (GMT) X-AuditID: cbfec7f4-97dff70000022c38-fb-6492be8d52ed Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 7D.1F.10549.C8EB2946; Wed, 21 Jun 2023 10:10:36 +0100 (BST) Received: from CAMSVWEXC02.scsc.local (unknown [106.1.227.72]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20230621091036eusmtip1064192b2f7098b941992ae887d268647~qoYzRi0Su1210112101eusmtip1N; Wed, 21 Jun 2023 09:10:36 +0000 (GMT) Received: from localhost (106.210.248.248) by CAMSVWEXC02.scsc.local (2002:6a01:e348::6a01:e348) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 21 Jun 2023 10:10:35 +0100 From: Joel Granados To: , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , , Theodore Ts'o , "Jason A. Donenfeld" , Greg Kroah-Hartman , Jiri Slaby , Juergen Gross , Stefano Stabellini , Benjamin LaHaise , Alexander Viro , Christian Brauner , Jeff Layton , Chuck Lever , Jan Kara , Kees Cook , Iurii Zaikin , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Balbir Singh , Eric Biederman , "Naveen N. Rao" , Anil S Keshavamurthy , "David S. Miller" , Masami Hiramatsu , Peter Zijlstra , Will Deacon , Petr Mladek , Sergey Senozhatsky , Juri Lelli , Vincent Guittot , Steven Rostedt , Andrew Morton , Mike Kravetz , Muchun Song , Naoya Horiguchi , "Matthew Wilcox (Oracle)" , David Howells , Jarkko Sakkinen , Paul Moore , James Morris , "Serge E. Hallyn" CC: Joel Granados , "H. Peter Anvin" , Oleksandr Tyshchenko , Amir Goldstein , John Fastabend , Martin KaFai Lau , Song Liu , Yonghong Song , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Waiman Long , Boqun Feng , John Ogness , Dietmar Eggemann , Ben Segall , Mel Gorman , Daniel Bristot de Oliveira , Valentin Schneider , Andy Lutomirski , Will Drewry , Mark Rutland , Miaohe Lin , , , , , , , , , , Subject: [PATCH 08/11] sysctl: Add size to register_sysctl_init Date: Wed, 21 Jun 2023 11:09:57 +0200 Message-ID: <20230621091000.424843-9-j.granados@samsung.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230621091000.424843-1-j.granados@samsung.com> Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Originating-IP: [106.210.248.248] X-ClientProxiedBy: CAMSVWEXC01.scsc.local (2002:6a01:e347::6a01:e347) To CAMSVWEXC02.scsc.local (2002:6a01:e348::6a01:e348) X-Brightmail-Tracker: H4sIAAAAAAAAA01Ta0xTZxj2O+frOYUNUxDDF2Vh6TbH2NBpXPKqKC7Z5nFxUed0N5PJ5YQa BLQFNs3MoKDIVahIt4KjQigIKIiFwLgVZFYshtHJqHIHGSCIcrcDYcBhC/+e932e53uf58cn ph162HXi44HBvDzQ64SUscUld6yN7vFVKt/3TTEukFaQz8AfN/IQTM+k0lA+0IphwtrKQsyc HkO+PpyC8cI5BsbrjAwM3R5DYO5tZkA9GI4hbbCBhfn2fgoyr07RMFAYhSCtMRLDiHIGQ19i MQ3zJZEsRGQWMFBrrGYh5aYTpKojKFBZExF0Na+DtIdbYOSKM1h1uSzcKMikQFmaQ0HJg3QE dckaGtovXsbQEBsA5aZJCorblAz0V8VTED2dhSE5RYmgorIew5+/pTHQkT8vgudxPQzUFdzH YLpzF0Pe9TARZLU0UZAffU0ElsQ+BJdG/kaQmb0BRqsPgdmgpUBX1o2hKdyAIC/5JQsvZmZE 0KpSYzDGGyiY750UQdWFLgrML4YwlN/MYHbv56bPJWCuc/gl5vJ/zUdcalgT5vTXHlJcW1YZ 4pIiRliuTNPOcpFVj1hOWxTC/VX+NRdZ91TE3cpx4zIrBikuxmKmuaLcaOaA6ze2Hr78ieOh vHzTrmO2ssrcBnyydAD98Lt+FoUhswHFIBsxkWwl2p8Ll7CDJAeRMbM4Btku4IkFPGVghWEc EdWj3v8dk2VdWCCyEam6n0IL9gXVPaufQBQj0pkSiRcJRvIeaRxuoxcJR8msHTFZjUvv0hKj DTGrm5lF1RqJJ+nIK15wiMVY8hbJuX58cW0n8SDDqhosnHYh51vUSzFsJDtJY+8zLGjsSf0v j5cwvaCJKE6lBUxIzcAALXjfIC1VmYyAz5J7+kfUYgYi0b1KGq3Jy8RHJEHds3xsDXli1LMC dibzZenLhkuIVM89Z4UhDxFd+CQlqHaQyAePlx0fkhylCi22IZLVxPLUXki0mqhK1LSwtiMX zjskojc1KzpoVnTQrOigRXQucuJDFAF+vGJLIP/9RoVXgCIk0G+jT1BAEVr4hqY540Qpyn4y urEWUWJUi4iYljravVak8nWw8/U6fYaXB30nDznBK2rRejGWOtm9u7Pex0Hi5xXM+/P8SV7+ H0uJbdaFUbn6n5QbZPZ3FY4TZ9xGj1ZezDBK92x6vV85VZkV7Z6UsX0+fQc+5hKuYS0qM3/E r8lj/IDsq+xPawy0q+9n3T2uctPYkPezVTJ3W84nblPs5Je3CkM6dqdIv7AapHv2BhSf3Bx6 UPNBbPvattjDQxb1425NVu+5l9sOZkjNE24lI1crpp27Pg/q99zWMnGqK9F/X+gnSeGzb0ed vSF758p4c4xIg001HrvW6rz99yccLuK0h6Ks5R9/q9++XhdITk1VcLt9ivindY2jR/Yx/6zq 3Xo4uLPccts7fhR7Vj+Ilb/C6zKaK93qtdd9f2z174vjhjosWs+G05dTmw1BpweOyqRYIfPa 7EbLFV7/AndzzmT1BAAA X-Brightmail-Tracker: H4sIAAAAAAAAA02TezBcdxTH53fv3buLmm5E5dZQHR0dI7WsVw8VTf+oXmlm0qnMtNHppDts kbIru0RipINdDSqpCBFsRO2seKyIxxqveMX7UW+SICXeod7vZ7HtjP8+c873e77n/HFYuE4E U5/lLfDniwQ8H2NSk2jZaxgyj66I9bDcnrMAWa6ShI4n2QjWt5NxKJsaIGBlc4AJUXuFBCgL QzFYfrpHwnJtAwkzz5cQdI32kpAwHUqAbLqVCftDkxjI/1zDYerpLQSydikBc2HbBIzHqHDY L5IyQSLPJaGmoZIJ9/NOQXKCBIPYzRgEw736IHtpBXMPDWAzPYsJT3LlGIQVZ2BQ1PMIQW1c Eg5Df8QT0Pq7L5S1rGKgGgwjYbLiNgaR6woC4u6HISh/1kRAd6mMhNfKfQYsRL8hoTa3jYCW +kYCsnNCGKDo78RAGZnJgBcx4wjuzU0gkD/+GBYrXaGrKhWD9JIRAjpDqxBkx+0yYWN7mwED sQkENNyuwmB/dJUBFRHDGHRtzBBQlpdGnr1Ar4ffIei/Z3cJWpmiRHRySCdBF2a+xOhBRQmi 70rmmHRJ0hCTlla8YtKp+QF0X9klWlr7D4MuyDCj5eXTGB31ogun87MiyW9M3TiOImGAP/9D L6HY/4zxD1yw4nDtgWNlY8/hWn/6o4OVrbGFk6MH38f7Gl9k4fQTx+tZVivhVzyFrtcV7qAQ 1FWFopAGi2LbUKslw8Qh67AViFpaNFTXDai8lV6Gmk9SO31RpFqziKiZTosopHnAKkTNZo4e iUj2J1T77CB+2NBlb2lTOw/qjhJwdp0GVR9hecgn2Z9Tr7NVB2ksFsE2oTJyvA/L2mxHaja2 mlCHGVG/9SccWTXYZ6j20fn/lnOkHi10I7X+BNWUOEaoxxtRElUyrmaKqp6awtVzPqL6K+Sk mm9Sy7sTKAbpJh2zJx2zJx2zpyI8C+nyA8S+nr5iLkfM8xUHCDw57kLffHTwEkX1mwXFKOXt IqcGYSxUgygWbqyrbZgf66Gj7cG7EcQXCS+LAnz44hpke3DmXVz/PXfhwU8J/C9z7SxtuTZ2 9pa29nbWxqe0XfwieDpsT54//xc+348v+t+HsTT0QzDijXdB86ur31qcXq7tq68/Z63VF9j7 VaukxzTeuslGuzbRRXrV69Z3oQXRk2560pCd/I79d8vmWTzJnZhKVVqbWXCv8wm/HHP9xPWc augbYwRn1T13ZK1VXbym6ftzH+/XuP63zela79iUCtyvTCC9v67Eht/UdVgsOSsvxYtce0iz DknQ0meuN9rSFRYmjzn3LgwYyBSB7l/EOz9UqJSyrY3z80aBzReVI+wPNLRM19JWBKEOZqYj kq3x71FRRWklVzqMOS1/3V3ODpb1LrQFXRfYCPnFC4aXzmeuMNJOW+vNN4Zvtntnj4+ZtLg5 h5l/6SIcrBqs639gq0p5n3uu0ZgQe/G4ZrhIzPsXGRMQfZsEAAA= X-CMS-MailID: 20230621091037eucas1p188e11d8064526a5a0549217d5a419647 X-Msg-Generator: CA X-RootMTR: 20230621091037eucas1p188e11d8064526a5a0549217d5a419647 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20230621091037eucas1p188e11d8064526a5a0549217d5a419647 References: <20230621091000.424843-1-j.granados@samsung.com> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net X-Patchwork-Delegate: bpf@iogearbox.net In order to remove the end element from the ctl_table struct arrays, we explicitly define the size when registering the targes. We add a size argument to the register_sysctl_init call and pass an ARRAY_SIZE for all the callers. Signed-off-by: Joel Granados --- arch/x86/kernel/cpu/intel.c | 2 +- drivers/char/random.c | 3 ++- drivers/tty/tty_io.c | 2 +- drivers/xen/balloon.c | 3 ++- fs/aio.c | 2 +- fs/coredump.c | 3 ++- fs/dcache.c | 3 ++- fs/exec.c | 3 ++- fs/file_table.c | 3 ++- fs/inode.c | 2 +- fs/locks.c | 2 +- fs/namei.c | 2 +- fs/namespace.c | 3 ++- fs/notify/dnotify/dnotify.c | 3 ++- fs/pipe.c | 3 ++- fs/proc/proc_sysctl.c | 11 ++--------- fs/quota/dquot.c | 3 ++- fs/sysctls.c | 3 ++- fs/userfaultfd.c | 3 ++- include/linux/sysctl.h | 8 +++++--- init/do_mounts_initrd.c | 3 ++- kernel/acct.c | 3 ++- kernel/bpf/syscall.c | 3 ++- kernel/delayacct.c | 3 ++- kernel/exit.c | 3 ++- kernel/hung_task.c | 3 ++- kernel/kexec_core.c | 3 ++- kernel/kprobes.c | 3 ++- kernel/latencytop.c | 3 ++- kernel/locking/lockdep.c | 3 ++- kernel/panic.c | 3 ++- kernel/pid_namespace.c | 3 ++- kernel/printk/sysctl.c | 3 ++- kernel/reboot.c | 3 ++- kernel/sched/autogroup.c | 3 ++- kernel/sched/core.c | 3 ++- kernel/sched/deadline.c | 3 ++- kernel/sched/fair.c | 3 ++- kernel/sched/rt.c | 3 ++- kernel/sched/topology.c | 3 ++- kernel/seccomp.c | 3 ++- kernel/signal.c | 3 ++- kernel/stackleak.c | 3 ++- kernel/sysctl.c | 4 ++-- kernel/trace/ftrace.c | 3 ++- kernel/trace/trace_events_user.c | 3 ++- kernel/umh.c | 3 ++- kernel/watchdog.c | 3 ++- mm/compaction.c | 2 +- mm/hugetlb.c | 2 +- mm/hugetlb_vmemmap.c | 3 ++- mm/memory-failure.c | 3 ++- mm/oom_kill.c | 3 ++- mm/page-writeback.c | 3 ++- security/keys/sysctl.c | 2 +- 55 files changed, 104 insertions(+), 66 deletions(-) diff --git a/arch/x86/kernel/cpu/intel.c b/arch/x86/kernel/cpu/intel.c index 1c4639588ff9..c77a3961443d 100644 --- a/arch/x86/kernel/cpu/intel.c +++ b/arch/x86/kernel/cpu/intel.c @@ -1195,7 +1195,7 @@ static struct ctl_table sld_sysctls[] = { static int __init sld_mitigate_sysctl_init(void) { - register_sysctl_init("kernel", sld_sysctls); + register_sysctl_init("kernel", sld_sysctls, ARRAY_SIZE(sld_sysctls)); return 0; } diff --git a/drivers/char/random.c b/drivers/char/random.c index 253f2ddb8913..8db2ea9e3d66 100644 --- a/drivers/char/random.c +++ b/drivers/char/random.c @@ -1692,7 +1692,8 @@ static struct ctl_table random_table[] = { */ static int __init random_sysctls_init(void) { - register_sysctl_init("kernel/random", random_table); + register_sysctl_init("kernel/random", random_table, + ARRAY_SIZE(random_table)); return 0; } device_initcall(random_sysctls_init); diff --git a/drivers/tty/tty_io.c b/drivers/tty/tty_io.c index c84be40fb8df..63fb3c543b94 100644 --- a/drivers/tty/tty_io.c +++ b/drivers/tty/tty_io.c @@ -3618,7 +3618,7 @@ static struct ctl_table tty_table[] = { */ int __init tty_init(void) { - register_sysctl_init("dev/tty", tty_table); + register_sysctl_init("dev/tty", tty_table, ARRAY_SIZE(tty_table)); cdev_init(&tty_cdev, &tty_fops); if (cdev_add(&tty_cdev, MKDEV(TTYAUX_MAJOR, 0), 1) || register_chrdev_region(MKDEV(TTYAUX_MAJOR, 0), 1, "/dev/tty") < 0) diff --git a/drivers/xen/balloon.c b/drivers/xen/balloon.c index 586a1673459e..e4544262a429 100644 --- a/drivers/xen/balloon.c +++ b/drivers/xen/balloon.c @@ -729,7 +729,8 @@ static int __init balloon_init(void) #ifdef CONFIG_XEN_BALLOON_MEMORY_HOTPLUG set_online_page_callback(&xen_online_page); register_memory_notifier(&xen_memory_nb); - register_sysctl_init("xen/balloon", balloon_table); + register_sysctl_init("xen/balloon", balloon_table, + ARRAY_SIZE(balloon_table)); #endif balloon_add_regions(); diff --git a/fs/aio.c b/fs/aio.c index b0b17bd098bb..b09abe7a14d3 100644 --- a/fs/aio.c +++ b/fs/aio.c @@ -244,7 +244,7 @@ static struct ctl_table aio_sysctls[] = { static void __init aio_sysctl_init(void) { - register_sysctl_init("fs", aio_sysctls); + register_sysctl_init("fs", aio_sysctls, ARRAY_SIZE(aio_sysctls)); } #else #define aio_sysctl_init() do { } while (0) diff --git a/fs/coredump.c b/fs/coredump.c index ece7badf701b..7e55428dce13 100644 --- a/fs/coredump.c +++ b/fs/coredump.c @@ -984,7 +984,8 @@ static struct ctl_table coredump_sysctls[] = { static int __init init_fs_coredump_sysctls(void) { - register_sysctl_init("kernel", coredump_sysctls); + register_sysctl_init("kernel", coredump_sysctls, + ARRAY_SIZE(coredump_sysctls)); return 0; } fs_initcall(init_fs_coredump_sysctls); diff --git a/fs/dcache.c b/fs/dcache.c index 52e6d5fdab6b..f02bfd383e66 100644 --- a/fs/dcache.c +++ b/fs/dcache.c @@ -196,7 +196,8 @@ static struct ctl_table fs_dcache_sysctls[] = { static int __init init_fs_dcache_sysctls(void) { - register_sysctl_init("fs", fs_dcache_sysctls); + register_sysctl_init("fs", fs_dcache_sysctls, + ARRAY_SIZE(fs_dcache_sysctls)); return 0; } fs_initcall(init_fs_dcache_sysctls); diff --git a/fs/exec.c b/fs/exec.c index a466e797c8e2..5572d148738b 100644 --- a/fs/exec.c +++ b/fs/exec.c @@ -2170,7 +2170,8 @@ static struct ctl_table fs_exec_sysctls[] = { static int __init init_fs_exec_sysctls(void) { - register_sysctl_init("fs", fs_exec_sysctls); + register_sysctl_init("fs", fs_exec_sysctls, + ARRAY_SIZE(fs_exec_sysctls)); return 0; } diff --git a/fs/file_table.c b/fs/file_table.c index 372653b92617..23a645521960 100644 --- a/fs/file_table.c +++ b/fs/file_table.c @@ -120,7 +120,8 @@ static struct ctl_table fs_stat_sysctls[] = { static int __init init_fs_stat_sysctls(void) { - register_sysctl_init("fs", fs_stat_sysctls); + register_sysctl_init("fs", fs_stat_sysctls, + ARRAY_SIZE(fs_stat_sysctls)); if (IS_ENABLED(CONFIG_BINFMT_MISC)) { struct ctl_table_header *hdr; hdr = register_sysctl_mount_point("fs/binfmt_misc"); diff --git a/fs/inode.c b/fs/inode.c index 577799b7855f..0a0ad1a2a5d2 100644 --- a/fs/inode.c +++ b/fs/inode.c @@ -135,7 +135,7 @@ static struct ctl_table inodes_sysctls[] = { static int __init init_fs_inode_sysctls(void) { - register_sysctl_init("fs", inodes_sysctls); + register_sysctl_init("fs", inodes_sysctls, ARRAY_SIZE(inodes_sysctls)); return 0; } early_initcall(init_fs_inode_sysctls); diff --git a/fs/locks.c b/fs/locks.c index df8b26a42524..ce5733480aa6 100644 --- a/fs/locks.c +++ b/fs/locks.c @@ -116,7 +116,7 @@ static struct ctl_table locks_sysctls[] = { static int __init init_fs_locks_sysctls(void) { - register_sysctl_init("fs", locks_sysctls); + register_sysctl_init("fs", locks_sysctls, ARRAY_SIZE(locks_sysctls)); return 0; } early_initcall(init_fs_locks_sysctls); diff --git a/fs/namei.c b/fs/namei.c index e4fe0879ae55..9b567af081af 100644 --- a/fs/namei.c +++ b/fs/namei.c @@ -1073,7 +1073,7 @@ static struct ctl_table namei_sysctls[] = { static int __init init_fs_namei_sysctls(void) { - register_sysctl_init("fs", namei_sysctls); + register_sysctl_init("fs", namei_sysctls, ARRAY_SIZE(namei_sysctls)); return 0; } fs_initcall(init_fs_namei_sysctls); diff --git a/fs/namespace.c b/fs/namespace.c index 54847db5b819..e7f251e40485 100644 --- a/fs/namespace.c +++ b/fs/namespace.c @@ -4715,7 +4715,8 @@ static struct ctl_table fs_namespace_sysctls[] = { static int __init init_fs_namespace_sysctls(void) { - register_sysctl_init("fs", fs_namespace_sysctls); + register_sysctl_init("fs", fs_namespace_sysctls, + ARRAY_SIZE(fs_namespace_sysctls)); return 0; } fs_initcall(init_fs_namespace_sysctls); diff --git a/fs/notify/dnotify/dnotify.c b/fs/notify/dnotify/dnotify.c index 190aa717fa32..2c6fe98d6fe1 100644 --- a/fs/notify/dnotify/dnotify.c +++ b/fs/notify/dnotify/dnotify.c @@ -33,7 +33,8 @@ static struct ctl_table dnotify_sysctls[] = { }; static void __init dnotify_sysctl_init(void) { - register_sysctl_init("fs", dnotify_sysctls); + register_sysctl_init("fs", dnotify_sysctls, + ARRAY_SIZE(dnotify_sysctls)); } #else #define dnotify_sysctl_init() do { } while (0) diff --git a/fs/pipe.c b/fs/pipe.c index 2d88f73f585a..8a808fc25552 100644 --- a/fs/pipe.c +++ b/fs/pipe.c @@ -1508,7 +1508,8 @@ static int __init init_pipe_fs(void) } } #ifdef CONFIG_SYSCTL - register_sysctl_init("fs", fs_pipe_sysctls); + register_sysctl_init("fs", fs_pipe_sysctls, + ARRAY_SIZE(fs_pipe_sysctls)); #endif return err; } diff --git a/fs/proc/proc_sysctl.c b/fs/proc/proc_sysctl.c index 66c9d7a07d2e..9670c5b7b5b2 100644 --- a/fs/proc/proc_sysctl.c +++ b/fs/proc/proc_sysctl.c @@ -1443,16 +1443,9 @@ EXPORT_SYMBOL(register_sysctl); * Context: if your base directory does not exist it will be created for you. */ void __init __register_sysctl_init(const char *path, struct ctl_table *table, - const char *table_name) + const char *table_name, size_t table_size) { - int count = 0; - struct ctl_table *entry; - struct ctl_table_header t_hdr, *hdr; - - t_hdr.ctl_table = table; - list_for_each_table_entry(entry, (&t_hdr)) - count++; - hdr = register_sysctl(path, table, count); + struct ctl_table_header *hdr = register_sysctl(path, table, table_size); if (unlikely(!hdr)) { pr_err("failed when register_sysctl %s to %s\n", table_name, path); diff --git a/fs/quota/dquot.c b/fs/quota/dquot.c index ffd40dc3e4e9..7c07654e4253 100644 --- a/fs/quota/dquot.c +++ b/fs/quota/dquot.c @@ -2953,7 +2953,8 @@ static int __init dquot_init(void) printk(KERN_NOTICE "VFS: Disk quotas %s\n", __DQUOT_VERSION__); - register_sysctl_init("fs/quota", fs_dqstats_table); + register_sysctl_init("fs/quota", fs_dqstats_table, + ARRAY_SIZE(fs_dqstats_table)); dquot_cachep = kmem_cache_create("dquot", sizeof(struct dquot), sizeof(unsigned long) * 4, diff --git a/fs/sysctls.c b/fs/sysctls.c index 76a0aee8c229..944254dd92c0 100644 --- a/fs/sysctls.c +++ b/fs/sysctls.c @@ -31,7 +31,8 @@ static struct ctl_table fs_shared_sysctls[] = { static int __init init_fs_sysctls(void) { - register_sysctl_init("fs", fs_shared_sysctls); + register_sysctl_init("fs", fs_shared_sysctls, + ARRAY_SIZE(fs_shared_sysctls)); return 0; } diff --git a/fs/userfaultfd.c b/fs/userfaultfd.c index 0fd96d6e39ce..4c3858769226 100644 --- a/fs/userfaultfd.c +++ b/fs/userfaultfd.c @@ -2219,7 +2219,8 @@ static int __init userfaultfd_init(void) SLAB_HWCACHE_ALIGN|SLAB_PANIC, init_once_userfaultfd_ctx); #ifdef CONFIG_SYSCTL - register_sysctl_init("vm", vm_userfaultfd_table); + register_sysctl_init("vm", vm_userfaultfd_table, + ARRAY_SIZE(vm_userfaultfd_table)); #endif return 0; } diff --git a/include/linux/sysctl.h b/include/linux/sysctl.h index 71d7935e50f0..3074a506592d 100644 --- a/include/linux/sysctl.h +++ b/include/linux/sysctl.h @@ -233,8 +233,9 @@ void unregister_sysctl_table(struct ctl_table_header * table); extern int sysctl_init_bases(void); extern void __register_sysctl_init(const char *path, struct ctl_table *table, - const char *table_name); -#define register_sysctl_init(path, table) __register_sysctl_init(path, table, #table) + const char *table_name, size_t table_size); +#define register_sysctl_init(path, table, size) \ + __register_sysctl_init(path, table, #table, size) extern struct ctl_table_header *register_sysctl_mount_point(const char *path); void do_sysctl_args(void); @@ -254,7 +255,8 @@ extern int no_unaligned_warning; #else /* CONFIG_SYSCTL */ -static inline void register_sysctl_init(const char *path, struct ctl_table *table) +static inline void register_sysctl_init(const char *path, struct ctl_table *table, + size_t table_size) { } diff --git a/init/do_mounts_initrd.c b/init/do_mounts_initrd.c index 34731241377d..2b10abb8c80e 100644 --- a/init/do_mounts_initrd.c +++ b/init/do_mounts_initrd.c @@ -34,7 +34,8 @@ static struct ctl_table kern_do_mounts_initrd_table[] = { static __init int kernel_do_mounts_initrd_sysctls_init(void) { - register_sysctl_init("kernel", kern_do_mounts_initrd_table); + register_sysctl_init("kernel", kern_do_mounts_initrd_table, + ARRAY_SIZE(kern_do_mounts_initrd_table)); return 0; } late_initcall(kernel_do_mounts_initrd_sysctls_init); diff --git a/kernel/acct.c b/kernel/acct.c index 010667ce6080..67125b7c5ca2 100644 --- a/kernel/acct.c +++ b/kernel/acct.c @@ -89,7 +89,8 @@ static struct ctl_table kern_acct_table[] = { static __init int kernel_acct_sysctls_init(void) { - register_sysctl_init("kernel", kern_acct_table); + register_sysctl_init("kernel", kern_acct_table, + ARRAY_SIZE(kern_acct_table)); return 0; } late_initcall(kernel_acct_sysctls_init); diff --git a/kernel/bpf/syscall.c b/kernel/bpf/syscall.c index 14f39c1e573e..a81b5122b16b 100644 --- a/kernel/bpf/syscall.c +++ b/kernel/bpf/syscall.c @@ -5406,7 +5406,8 @@ static struct ctl_table bpf_syscall_table[] = { static int __init bpf_syscall_sysctl_init(void) { - register_sysctl_init("kernel", bpf_syscall_table); + register_sysctl_init("kernel", bpf_syscall_table, + ARRAY_SIZE(bpf_syscall_table)); return 0; } late_initcall(bpf_syscall_sysctl_init); diff --git a/kernel/delayacct.c b/kernel/delayacct.c index 6f0c358e73d8..4ef14cb5b5a0 100644 --- a/kernel/delayacct.c +++ b/kernel/delayacct.c @@ -79,7 +79,8 @@ static struct ctl_table kern_delayacct_table[] = { static __init int kernel_delayacct_sysctls_init(void) { - register_sysctl_init("kernel", kern_delayacct_table); + register_sysctl_init("kernel", kern_delayacct_table, + ARRAY_SIZE(kern_delayacct_table)); return 0; } late_initcall(kernel_delayacct_sysctls_init); diff --git a/kernel/exit.c b/kernel/exit.c index 34b90e2e7cf7..633c7a52ef80 100644 --- a/kernel/exit.c +++ b/kernel/exit.c @@ -95,7 +95,8 @@ static struct ctl_table kern_exit_table[] = { static __init int kernel_exit_sysctls_init(void) { - register_sysctl_init("kernel", kern_exit_table); + register_sysctl_init("kernel", kern_exit_table, + ARRAY_SIZE(kern_exit_table)); return 0; } late_initcall(kernel_exit_sysctls_init); diff --git a/kernel/hung_task.c b/kernel/hung_task.c index 9a24574988d2..816f133266c4 100644 --- a/kernel/hung_task.c +++ b/kernel/hung_task.c @@ -318,7 +318,8 @@ static struct ctl_table hung_task_sysctls[] = { static void __init hung_task_sysctl_init(void) { - register_sysctl_init("kernel", hung_task_sysctls); + register_sysctl_init("kernel", hung_task_sysctls, + ARRAY_SIZE(hung_task_sysctls)); } #else #define hung_task_sysctl_init() do { } while (0) diff --git a/kernel/kexec_core.c b/kernel/kexec_core.c index 3d578c6fefee..63b04e710890 100644 --- a/kernel/kexec_core.c +++ b/kernel/kexec_core.c @@ -1007,7 +1007,8 @@ static struct ctl_table kexec_core_sysctls[] = { static int __init kexec_core_sysctl_init(void) { - register_sysctl_init("kernel", kexec_core_sysctls); + register_sysctl_init("kernel", kexec_core_sysctls, + ARRAY_SIZE(kexec_core_sysctls)); return 0; } late_initcall(kexec_core_sysctl_init); diff --git a/kernel/kprobes.c b/kernel/kprobes.c index 00e177de91cc..06a3ac7993f0 100644 --- a/kernel/kprobes.c +++ b/kernel/kprobes.c @@ -973,7 +973,8 @@ static struct ctl_table kprobe_sysctls[] = { static void __init kprobe_sysctls_init(void) { - register_sysctl_init("debug", kprobe_sysctls); + register_sysctl_init("debug", kprobe_sysctls, + ARRAY_SIZE(kprobe_sysctls)); } #endif /* CONFIG_SYSCTL */ diff --git a/kernel/latencytop.c b/kernel/latencytop.c index 781249098cb6..55050ae0e197 100644 --- a/kernel/latencytop.c +++ b/kernel/latencytop.c @@ -293,7 +293,8 @@ static int __init init_lstats_procfs(void) { proc_create("latency_stats", 0644, NULL, &lstats_proc_ops); #ifdef CONFIG_SYSCTL - register_sysctl_init("kernel", latencytop_sysctl); + register_sysctl_init("kernel", latencytop_sysctl, + ARRAY_SIZE(latencytop_sysctl)); #endif return 0; } diff --git a/kernel/locking/lockdep.c b/kernel/locking/lockdep.c index dcd1d5bfc1e0..1e29cec7e00c 100644 --- a/kernel/locking/lockdep.c +++ b/kernel/locking/lockdep.c @@ -102,7 +102,8 @@ static struct ctl_table kern_lockdep_table[] = { static __init int kernel_lockdep_sysctls_init(void) { - register_sysctl_init("kernel", kern_lockdep_table); + register_sysctl_init("kernel", kern_lockdep_table, + ARRAY_SIZE(kern_lockdep_table)); return 0; } late_initcall(kernel_lockdep_sysctls_init); diff --git a/kernel/panic.c b/kernel/panic.c index 886d2ebd0a0d..0008273d23fd 100644 --- a/kernel/panic.c +++ b/kernel/panic.c @@ -104,7 +104,8 @@ static struct ctl_table kern_panic_table[] = { static __init int kernel_panic_sysctls_init(void) { - register_sysctl_init("kernel", kern_panic_table); + register_sysctl_init("kernel", kern_panic_table, + ARRAY_SIZE(kern_panic_table)); return 0; } late_initcall(kernel_panic_sysctls_init); diff --git a/kernel/pid_namespace.c b/kernel/pid_namespace.c index b43eee07b00c..7fd5e8adc2e8 100644 --- a/kernel/pid_namespace.c +++ b/kernel/pid_namespace.c @@ -472,7 +472,8 @@ static __init int pid_namespaces_init(void) pid_ns_cachep = KMEM_CACHE(pid_namespace, SLAB_PANIC | SLAB_ACCOUNT); #ifdef CONFIG_CHECKPOINT_RESTORE - register_sysctl_init("kernel", pid_ns_ctl_table); + register_sysctl_init("kernel", pid_ns_ctl_table, + ARRAY_SIZE(pid_ns_ctl_table)); #endif register_pid_ns_sysctl_table_vm(); diff --git a/kernel/printk/sysctl.c b/kernel/printk/sysctl.c index c228343eeb97..28f37b86414e 100644 --- a/kernel/printk/sysctl.c +++ b/kernel/printk/sysctl.c @@ -81,5 +81,6 @@ static struct ctl_table printk_sysctls[] = { void __init printk_sysctl_init(void) { - register_sysctl_init("kernel", printk_sysctls); + register_sysctl_init("kernel", printk_sysctls, + ARRAY_SIZE(printk_sysctls)); } diff --git a/kernel/reboot.c b/kernel/reboot.c index 3bba88c7ffc6..cf81d8bfb523 100644 --- a/kernel/reboot.c +++ b/kernel/reboot.c @@ -1277,7 +1277,8 @@ static struct ctl_table kern_reboot_table[] = { static void __init kernel_reboot_sysctls_init(void) { - register_sysctl_init("kernel", kern_reboot_table); + register_sysctl_init("kernel", kern_reboot_table, + ARRAY_SIZE(kern_reboot_table)); } #else #define kernel_reboot_sysctls_init() do { } while (0) diff --git a/kernel/sched/autogroup.c b/kernel/sched/autogroup.c index 991fc9002535..2b9ce82279a5 100644 --- a/kernel/sched/autogroup.c +++ b/kernel/sched/autogroup.c @@ -24,7 +24,8 @@ static struct ctl_table sched_autogroup_sysctls[] = { static void __init sched_autogroup_sysctl_init(void) { - register_sysctl_init("kernel", sched_autogroup_sysctls); + register_sysctl_init("kernel", sched_autogroup_sysctls, + ARRAY_SIZE(sched_autogroup_sysctls)); } #else #define sched_autogroup_sysctl_init() do { } while (0) diff --git a/kernel/sched/core.c b/kernel/sched/core.c index a68d1276bab0..b8c7e01dd78a 100644 --- a/kernel/sched/core.c +++ b/kernel/sched/core.c @@ -4677,7 +4677,8 @@ static struct ctl_table sched_core_sysctls[] = { }; static int __init sched_core_sysctl_init(void) { - register_sysctl_init("kernel", sched_core_sysctls); + register_sysctl_init("kernel", sched_core_sysctls, + ARRAY_SIZE(sched_core_sysctls)); return 0; } late_initcall(sched_core_sysctl_init); diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c index 5a9a4b81c972..2aacf5ea2ff3 100644 --- a/kernel/sched/deadline.c +++ b/kernel/sched/deadline.c @@ -46,7 +46,8 @@ static struct ctl_table sched_dl_sysctls[] = { static int __init sched_dl_sysctl_init(void) { - register_sysctl_init("kernel", sched_dl_sysctls); + register_sysctl_init("kernel", sched_dl_sysctls, + ARRAY_SIZE(sched_dl_sysctls)); return 0; } late_initcall(sched_dl_sysctl_init); diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 373ff5f55884..db09e56c2dd3 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -217,7 +217,8 @@ static struct ctl_table sched_fair_sysctls[] = { static int __init sched_fair_sysctl_init(void) { - register_sysctl_init("kernel", sched_fair_sysctls); + register_sysctl_init("kernel", sched_fair_sysctls, + ARRAY_SIZE(sched_fair_sysctls)); return 0; } late_initcall(sched_fair_sysctl_init); diff --git a/kernel/sched/rt.c b/kernel/sched/rt.c index 00e0e5074115..aab9b900ed6f 100644 --- a/kernel/sched/rt.c +++ b/kernel/sched/rt.c @@ -57,7 +57,8 @@ static struct ctl_table sched_rt_sysctls[] = { static int __init sched_rt_sysctl_init(void) { - register_sysctl_init("kernel", sched_rt_sysctls); + register_sysctl_init("kernel", sched_rt_sysctls, + ARRAY_SIZE(sched_rt_sysctls)); return 0; } late_initcall(sched_rt_sysctl_init); diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c index 6682535e37c8..46d7c3f3e830 100644 --- a/kernel/sched/topology.c +++ b/kernel/sched/topology.c @@ -255,7 +255,8 @@ static struct ctl_table sched_energy_aware_sysctls[] = { static int __init sched_energy_aware_sysctl_init(void) { - register_sysctl_init("kernel", sched_energy_aware_sysctls); + register_sysctl_init("kernel", sched_energy_aware_sysctls, + ARRAY_SIZE(sched_energy_aware_sysctls)); return 0; } diff --git a/kernel/seccomp.c b/kernel/seccomp.c index d3e584065c7f..9683a9a4709d 100644 --- a/kernel/seccomp.c +++ b/kernel/seccomp.c @@ -2386,7 +2386,8 @@ static struct ctl_table seccomp_sysctl_table[] = { static int __init seccomp_sysctl_init(void) { - register_sysctl_init("kernel/seccomp", seccomp_sysctl_table); + register_sysctl_init("kernel/seccomp", seccomp_sysctl_table, + ARRAY_SIZE(seccomp_sysctl_table)); return 0; } diff --git a/kernel/signal.c b/kernel/signal.c index 5ba4150c01a7..19791930f12a 100644 --- a/kernel/signal.c +++ b/kernel/signal.c @@ -4788,7 +4788,8 @@ static struct ctl_table signal_debug_table[] = { static int __init init_signal_sysctls(void) { - register_sysctl_init("debug", signal_debug_table); + register_sysctl_init("debug", signal_debug_table, + ARRAY_SIZE(signal_debug_table)); return 0; } early_initcall(init_signal_sysctls); diff --git a/kernel/stackleak.c b/kernel/stackleak.c index 34c9d81eea94..123844341148 100644 --- a/kernel/stackleak.c +++ b/kernel/stackleak.c @@ -59,7 +59,8 @@ static struct ctl_table stackleak_sysctls[] = { static int __init stackleak_sysctls_init(void) { - register_sysctl_init("kernel", stackleak_sysctls); + register_sysctl_init("kernel", stackleak_sysctls, + ARRAY_SIZE(stackleak_sysctls)); return 0; } late_initcall(stackleak_sysctls_init); diff --git a/kernel/sysctl.c b/kernel/sysctl.c index 48046932d573..2b9b0c8569ba 100644 --- a/kernel/sysctl.c +++ b/kernel/sysctl.c @@ -2321,8 +2321,8 @@ static struct ctl_table vm_table[] = { int __init sysctl_init_bases(void) { - register_sysctl_init("kernel", kern_table); - register_sysctl_init("vm", vm_table); + register_sysctl_init("kernel", kern_table, ARRAY_SIZE(kern_table)); + register_sysctl_init("vm", vm_table, ARRAY_SIZE(vm_table)); return 0; } diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c index 764668467155..84ef42111f78 100644 --- a/kernel/trace/ftrace.c +++ b/kernel/trace/ftrace.c @@ -8219,7 +8219,8 @@ static struct ctl_table ftrace_sysctls[] = { static int __init ftrace_sysctl_init(void) { - register_sysctl_init("kernel", ftrace_sysctls); + register_sysctl_init("kernel", ftrace_sysctls, + ARRAY_SIZE(ftrace_sysctls)); return 0; } late_initcall(ftrace_sysctl_init); diff --git a/kernel/trace/trace_events_user.c b/kernel/trace/trace_events_user.c index b1ecd7677642..ac019cb21b18 100644 --- a/kernel/trace/trace_events_user.c +++ b/kernel/trace/trace_events_user.c @@ -2563,7 +2563,8 @@ static int __init trace_events_user_init(void) if (dyn_event_register(&user_event_dops)) pr_warn("user_events could not register with dyn_events\n"); - register_sysctl_init("kernel", user_event_sysctls); + register_sysctl_init("kernel", user_event_sysctls, + ARRAY_SIZE(user_event_sysctls)); return 0; } diff --git a/kernel/umh.c b/kernel/umh.c index 41088c5c39fd..187a30ff8541 100644 --- a/kernel/umh.c +++ b/kernel/umh.c @@ -565,7 +565,8 @@ static struct ctl_table usermodehelper_table[] = { static int __init init_umh_sysctls(void) { - register_sysctl_init("kernel/usermodehelper", usermodehelper_table); + register_sysctl_init("kernel/usermodehelper", usermodehelper_table, + ARRAY_SIZE(usermodehelper_table)); return 0; } early_initcall(init_umh_sysctls); diff --git a/kernel/watchdog.c b/kernel/watchdog.c index 8e61f21e7e33..dd5a343fadde 100644 --- a/kernel/watchdog.c +++ b/kernel/watchdog.c @@ -847,7 +847,8 @@ static struct ctl_table watchdog_sysctls[] = { static void __init watchdog_sysctl_init(void) { - register_sysctl_init("kernel", watchdog_sysctls); + register_sysctl_init("kernel", watchdog_sysctls, + ARRAY_SIZE(watchdog_sysctls)); } #else #define watchdog_sysctl_init() do { } while (0) diff --git a/mm/compaction.c b/mm/compaction.c index c8bcdea15f5f..ca09cdd72bf3 100644 --- a/mm/compaction.c +++ b/mm/compaction.c @@ -3145,7 +3145,7 @@ static int __init kcompactd_init(void) for_each_node_state(nid, N_MEMORY) kcompactd_run(nid); - register_sysctl_init("vm", vm_compaction); + register_sysctl_init("vm", vm_compaction, ARRAY_SIZE(vm_compaction)); return 0; } subsys_initcall(kcompactd_init) diff --git a/mm/hugetlb.c b/mm/hugetlb.c index f154019e6b84..7838b0c0b82b 100644 --- a/mm/hugetlb.c +++ b/mm/hugetlb.c @@ -4681,7 +4681,7 @@ static struct ctl_table hugetlb_table[] = { static void hugetlb_sysctl_init(void) { - register_sysctl_init("vm", hugetlb_table); + register_sysctl_init("vm", hugetlb_table, ARRAY_SIZE(hugetlb_table)); } #endif /* CONFIG_SYSCTL */ diff --git a/mm/hugetlb_vmemmap.c b/mm/hugetlb_vmemmap.c index 27f001e0f0a2..65885a06269b 100644 --- a/mm/hugetlb_vmemmap.c +++ b/mm/hugetlb_vmemmap.c @@ -597,7 +597,8 @@ static int __init hugetlb_vmemmap_init(void) for_each_hstate(h) { if (hugetlb_vmemmap_optimizable(h)) { - register_sysctl_init("vm", hugetlb_vmemmap_sysctls); + register_sysctl_init("vm", hugetlb_vmemmap_sysctls, + ARRAY_SIZE(hugetlb_vmemmap_sysctls)); break; } } diff --git a/mm/memory-failure.c b/mm/memory-failure.c index 5b663eca1f29..46aef76d8e91 100644 --- a/mm/memory-failure.c +++ b/mm/memory-failure.c @@ -148,7 +148,8 @@ static struct ctl_table memory_failure_table[] = { static int __init memory_failure_sysctl_init(void) { - register_sysctl_init("vm", memory_failure_table); + register_sysctl_init("vm", memory_failure_table, + ARRAY_SIZE(memory_failure_table)); return 0; } late_initcall(memory_failure_sysctl_init); diff --git a/mm/oom_kill.c b/mm/oom_kill.c index 044e1eed720e..500cf2ef9faa 100644 --- a/mm/oom_kill.c +++ b/mm/oom_kill.c @@ -734,7 +734,8 @@ static int __init oom_init(void) { oom_reaper_th = kthread_run(oom_reaper, NULL, "oom_reaper"); #ifdef CONFIG_SYSCTL - register_sysctl_init("vm", vm_oom_kill_table); + register_sysctl_init("vm", vm_oom_kill_table, + ARRAY_SIZE(vm_oom_kill_table)); #endif return 0; } diff --git a/mm/page-writeback.c b/mm/page-writeback.c index db7943999007..9f997de8d12f 100644 --- a/mm/page-writeback.c +++ b/mm/page-writeback.c @@ -2320,7 +2320,8 @@ void __init page_writeback_init(void) cpuhp_setup_state(CPUHP_MM_WRITEBACK_DEAD, "mm/writeback:dead", NULL, page_writeback_cpu_online); #ifdef CONFIG_SYSCTL - register_sysctl_init("vm", vm_page_writeback_sysctls); + register_sysctl_init("vm", vm_page_writeback_sysctls, + ARRAY_SIZE(vm_page_writeback_sysctls)); #endif } diff --git a/security/keys/sysctl.c b/security/keys/sysctl.c index b72b82bb20c6..fa305f74f658 100644 --- a/security/keys/sysctl.c +++ b/security/keys/sysctl.c @@ -71,7 +71,7 @@ struct ctl_table key_sysctls[] = { static int __init init_security_keys_sysctls(void) { - register_sysctl_init("kernel/keys", key_sysctls); + register_sysctl_init("kernel/keys", key_sysctls, ARRAY_SIZE(key_sysctls)); return 0; } early_initcall(init_security_keys_sysctls); From patchwork Wed Jun 21 09:48:00 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joel Granados X-Patchwork-Id: 13287023 X-Patchwork-Delegate: bpf@iogearbox.net Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ADC52DDD5 for ; Wed, 21 Jun 2023 09:48:34 +0000 (UTC) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 532589B; Wed, 21 Jun 2023 02:48:29 -0700 (PDT) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20230621094825euoutp0209eecd8d31f2cfabdd83cf85c72e4328~qo50a_jJ31913319133euoutp02q; Wed, 21 Jun 2023 09:48:25 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20230621094825euoutp0209eecd8d31f2cfabdd83cf85c72e4328~qo50a_jJ31913319133euoutp02q DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1687340905; bh=hW7nv4xAjVfG7za+1C5oUlGPxr8RrFgRO4qPCmCRgg4=; h=From:To:CC:Subject:Date:In-Reply-To:References:From; b=K3sctCymFcQKijBm0VgkYCUiQWu8OaySLv9PcyYhajyJUqUESHYnQiFcJDKUqRHKy WMZs3B/clthEr7af8LhLMFqc132tlqTdPR0sv17/j/LyyEpaXijRylQ7MvYbEgl6iM WZegn1jP4T12AeiJj2APpZMih//0OVyD1zJCGG2k= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20230621094825eucas1p109062517ef579a75526cd98d12967ac2~qo50EVM7n1217412174eucas1p1-; Wed, 21 Jun 2023 09:48:25 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id 65.37.11320.867C2946; Wed, 21 Jun 2023 10:48:24 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20230621094824eucas1p154c97eead5f2de6bceca6359304b775c~qo5zI54sm1171511715eucas1p1z; Wed, 21 Jun 2023 09:48:24 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20230621094824eusmtrp125a30fa1daaa318922ec92952186991d~qo5zF5aWI1292612926eusmtrp1B; Wed, 21 Jun 2023 09:48:24 +0000 (GMT) X-AuditID: cbfec7f4-20132a8000022c38-45-6492c7689305 Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 2B.F5.10549.767C2946; Wed, 21 Jun 2023 10:48:23 +0100 (BST) Received: from CAMSVWEXC02.scsc.local (unknown [106.1.227.72]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20230621094823eusmtip29cf7ab827cf574b4306610d555107eae~qo5yRx4Lo1505515055eusmtip2Y; Wed, 21 Jun 2023 09:48:23 +0000 (GMT) Received: from localhost (106.210.248.248) by CAMSVWEXC02.scsc.local (2002:6a01:e348::6a01:e348) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 21 Jun 2023 10:48:21 +0100 From: Joel Granados To: , Russell King , Catalin Marinas , Will Deacon , Michael Ellerman , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Gerald Schaefer , Andy Lutomirski , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , , Herbert Xu , "David S. Miller" , Russ Weight , Greg Kroah-Hartman , Phillip Potter , Clemens Ladisch , Arnd Bergmann , Corey Minyard , Theodore Ts'o , "Jason A. Donenfeld" , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Jason Gunthorpe , Leon Romanovsky , Benjamin Herrenschmidt , Song Liu , Robin Holt , Steve Wahl , David Ahern , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Sudip Mukherjee , Mark Rutland , "James E.J. Bottomley" , "Martin K. Petersen" , Doug Gilbert , Jiri Slaby , Juergen Gross , Stefano Stabellini , Alexander Viro , Christian Brauner , Benjamin LaHaise , David Howells , Jan Harkes , , Trond Myklebust , Anna Schumaker , Chuck Lever , Jeff Layton , Jan Kara , Anton Altaparmakov , Mark Fasheh , Joel Becker , Joseph Qi , Kees Cook , Iurii Zaikin , Eric Biggers , "Darrick J. Wong" , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Balbir Singh , Eric Biederman , "Naveen N. Rao" , Anil S Keshavamurthy , Masami Hiramatsu , Peter Zijlstra , Petr Mladek , Sergey Senozhatsky , Juri Lelli , Vincent Guittot , John Stultz , Steven Rostedt , Andrew Morton , Mike Kravetz , Muchun Song , Naoya Horiguchi , "Matthew Wilcox (Oracle)" , Joerg Reuter , Ralf Baechle , Pablo Neira Ayuso , Jozsef Kadlecsik , Florian Westphal , Roopa Prabhu , Nikolay Aleksandrov , Alexander Aring , Stefan Schmidt , Miquel Raynal , Steffen Klassert , Matthieu Baerts , Mat Martineau , Simon Horman , Julian Anastasov , Remi Denis-Courmont , Santosh Shilimkar , Marc Dionne , Neil Horman , Marcelo Ricardo Leitner , Xin Long , Karsten Graul , Wenjia Zhang , Jan Karcher , Jon Maloy , Ying Xue , Martin Schiller , John Johansen , Paul Moore , James Morris , "Serge E. Hallyn" , Jarkko Sakkinen CC: Joel Granados , Nicholas Piggin , Christophe Leroy , Christian Borntraeger , Sven Schnelle , "H. Peter Anvin" , "Rafael J. Wysocki" , Mike Travis , Oleksandr Tyshchenko , Amir Goldstein , Matthew Bobrowski , John Fastabend , Martin KaFai Lau , Yonghong Song , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Waiman Long , Boqun Feng , John Ogness , Dietmar Eggemann , Ben Segall , Mel Gorman , Daniel Bristot de Oliveira , Valentin Schneider , Andy Lutomirski , Will Drewry , Stephen Boyd , Miaohe Lin , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Subject: [PATCH 09/11] sysctl: Remove the end element in sysctl table arrays Date: Wed, 21 Jun 2023 11:48:00 +0200 Message-ID: <20230621094817.433842-1-j.granados@samsung.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230621091000.424843-1-j.granados@samsung.com> Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Originating-IP: [106.210.248.248] X-ClientProxiedBy: CAMSVWEXC01.scsc.local (2002:6a01:e347::6a01:e347) To CAMSVWEXC02.scsc.local (2002:6a01:e348::6a01:e348) X-Brightmail-Tracker: H4sIAAAAAAAAA01TbUxTVxjeuff23tKtWD42T5C5jOnmdHzIFn0T1OCiy83mDzWbRv8o2gaY CtoCbg5YpYAVhUFRkAJbB1gZH612wBC2snUNnwmQgPIhClR0rEIBpUjH1wq3W/hz8jx53ud9 3vecHD7paWF8+JFRMRJpVNhpP1pA1TQ6OvwjmlTioLw7wVCgr6DBJN8OnbpyBC/n8km42Kjh wbTjAQNpi1UUPF4w0fDi9qLzMDfRMFPRS4BcMe+kw3/xYKHnCg3GZAMC441KGmxJcxR0jbiD ri6FgKWaZAaeNFoYuGxZoqFTPcMDRbHeGdjUwMCz78sQXLH6gqLajiA/V0HAzQeXedCtnaRB 5chEkHejGUFBXzDYCn3BoS1jYNBuoUCnLyYgqbaUgObpFBrM19Qk/PYjAT9pZxlwZLwK8813 aMhLczasb7MTMJGTT8C1nCQEhsf3eTBV0ups9MhBwPUsZ1JXXQENl5QFCJ6a0im40lNLwxPN Mx5MXrXQUDdfy8Dcy0UeWPQTBJRXynnQUVfJCxWzXd2fsS9TMih2cGyBYvstdpK1tbcgVi1P p9nyCjPJasz72KK/5RQ7cPMuYvV9KprNUtgY9q76IcPW/L6R1Rhi2fv1R/ZvOyrYIZacjoyT SAN3HRdEVPV3MmdzsnhfDWVpkRwNLZBpiM/Hoo9w9QSThgR8T1EpwhV9HRRHphHOHM6kOfIC 4V/1NidxW3GklugRJ9xCeFjXyPxfNas1uCzVCBt6W1cstOgD3DE2QC4L3qLkd3Fh9ehKCikq 8MbDU4vEcpWXaB/OH+9bcVCijdjkfIhlLBTtwOaiB67wt3BqTy5axm6inbjj8QTF1XjglryR FUw6axTV+SSHMf5jdJTkvO/gHmOxq08Cbq3qJ5aHwKKi1/CjnmmCE/bgyks6hsNe2NpU5cK+ uC37KsUZshFuWJxkOFKOsPai3eUOwcndIy7Hbtyl/w5xt+yOe8c9uIncsaom13X5QqxM9cxE G9SrdlCv2kG9agcNIsvQWkms7Ey4RBYcJTkfIAs7I4uNCg84GX3GgJzfsG2xaboW3bJOBZgQ wUcmhPmkn7fwTYNK7CkUh319QSKNPiaNPS2RmdA6PuW3VrhlZ8tJT1F4WIzklERyViL9TyX4 bj5ywifCHH/42/3txsS6o+7xcRd/PiZkYhZCNmX7hX56Qjz5yQHlGkpgDO/KSbPjX9ziLe83 yK8OglZlXBoKHQ9aP5mqnJhtTWB3RZ+LIe4d8d196PlA1WDztnMZaaHKmVK5SfyG1jSYqPRY kzoQr+975fMDB3X1t4vickeYtiKfhI+9jj8NMvyZ6GW9t6EwJLQi6WD4Xu8S0j/4m+TNgc/X +/8TFIcD4xKuM3fTN3vEU+O9wWar5w/N53X0k03HWwrHzn9pfN0w29i+R/NeuvVw8xZte/bD yNGh0hSvnLf3C8sNNuEX20+RASGCQWnuBcG6MnPGoa3J8zc31t+2ndDs/bCs85ofJYsI27qZ lMrC/gXHmSQM9QQAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA02TbUxTZxTH99x7e1tYairiuCEuLmVqwqRQ3jwQIFv4clU0muHCnJN1UoFJ gbWgm2AECjJgKPBBGIXKRJBheauFCSMQK9KyEkFAWMEBtjhex/uLCIUV6hK+PPk/5/x+z5Pz 4bBwm0ymPSs8MkYojhREcElrQrehGXQK1eSEuJQpHaFGN06Ctu8uBgVVChLUCUegs/IBgpU1 GQ5/jA0QkFK/SUC9UsWAxNYiBphyWpmwuDrAhPQNFQGzSSk4KFSJGBhNahIWqjfMR4uGhMkn 8wi0CjPXZXxBQu54IgEF4+1MmCn9GcHLnFEmbP49isE97SsMlhV/YZAgXSfBVJ+Kw8KrUQZs 1mXjUPzrMg5j1akICjqSCTD1ZZDQlKxE0JRXQcJ00hoBr7Nqcege2QU9SzMkVDakYGY1mQkV jes4vG41MCHNsElCXaZ5qhnpeejMX2aAtLiKhN7faVBrmpkwKS9HkDGxD6S1Swhu19iBLOsh BiO3DAyQ5UoxKBlIY0BP6SwJ97urEOSsZqFPnyK6u+c4vZJyk6CHpkwErZArzKXe5zi99jYH 0f2GJZyeftaGaLkijs5PyCRpWcJzgn6gaMHpopYAekn/DKPfrjrSqt/02KkzZ3k+4qjYGOFH YVGSGF/uV3xw5fG9gOfq7sXjux352tvVg+vs5xMijAi/LBQ7+33DC1P1dzKjb2czfhjOLkUJ aNiEpyMrFsVxp27cq0LpyJplwylB1NgdPdPS2EfVLL5gWPIear03nbRAc4h62jPJsFxqEbVY Ub1tkJzDVMfUS3yrYctJOkjVdk1tUzgnz5ZqU8jRFrWHE0DJ/tWTW5ngHKDUiynbmc3xoVru DpCW//ZTN/pyt3krji/VYZwhtrKNmbkz240s/G6q7ZeR7Tpu5qW1MtySKerx2Ni74Ryovqbi d29eoxZM/6AsZJu/Q8/foefv0IsQXo5shbESUahIwudJBCJJbGQo70KUSInMe1HXuvrwEZJP zPHUCGMhNaJYONeW/aEyJ8SGHSL48apQHBUsjo0QStTIwzxnNm6/90KUebEiY4L5ni4efHdP LxcPL083rh37aPRPAhtOqCBGeEkojBaK//cwlpV9AnbsepzB62jXxpv7Iy2SGRYDdGr6ymfs suTlik+k1wOxD/rSU0mH2HOiWrcTT5o/rlkuZDtc1vkP6csPRnTvLbT9cjxguEXbzzpkjN/t z/AWqJo3H+OBeefOGxYja5znr/BLGgLrhnD2ycjvjU63SvWmU3amzwsb6DyJMncW5v/8Tqeo 2WU9kj5QmuFADVQYHXu5cUHSxfLUY/qF06MOZZdYHWPymf2NHLusyptXs7hFvo2as4eCCr44 0T7tGRymzBz/VqWbeC/vzfpa2rXjwSe9g0a1ovjTxUbNnE+4/0W6IMlJ7jJ45mKncDCj+P32 5cOQWGLQ9vgFPdKuBFdUxnMJSZiA74iLJYL/AN+vVrqgBAAA X-CMS-MailID: 20230621094824eucas1p154c97eead5f2de6bceca6359304b775c X-Msg-Generator: CA X-RootMTR: 20230621094824eucas1p154c97eead5f2de6bceca6359304b775c X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20230621094824eucas1p154c97eead5f2de6bceca6359304b775c References: <20230621091000.424843-1-j.granados@samsung.com> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net X-Patchwork-Delegate: bpf@iogearbox.net Remove the empty end element from all the arrays that are passed to the register sysctl calls. In some files this means reducing the explicit array size by one. Also make sure that we are using the size in ctl_table_header instead of evaluating the .procname element. Signed-off-by: Joel Granados --- arch/arm/kernel/isa.c | 4 +- arch/arm64/kernel/armv8_deprecated.c | 8 ++-- arch/arm64/kernel/fpsimd.c | 6 +-- arch/arm64/kernel/process.c | 3 +- arch/ia64/kernel/crash.c | 3 +- arch/powerpc/kernel/idle.c | 3 +- arch/powerpc/platforms/pseries/mobility.c | 3 +- arch/s390/appldata/appldata_base.c | 7 ++-- arch/s390/kernel/debug.c | 3 +- arch/s390/kernel/topology.c | 3 +- arch/s390/mm/cmm.c | 3 +- arch/s390/mm/pgalloc.c | 3 +- arch/x86/entry/vdso/vdso32-setup.c | 3 +- arch/x86/kernel/cpu/intel.c | 3 +- arch/x86/kernel/itmt.c | 3 +- crypto/fips.c | 3 +- drivers/base/firmware_loader/fallback_table.c | 3 +- drivers/cdrom/cdrom.c | 3 +- drivers/char/hpet.c | 13 +++--- drivers/char/ipmi/ipmi_poweroff.c | 3 +- drivers/char/random.c | 3 +- drivers/gpu/drm/i915/i915_perf.c | 33 +++++++-------- drivers/hv/hv_common.c | 3 +- drivers/infiniband/core/iwcm.c | 3 +- drivers/infiniband/core/ucma.c | 3 +- drivers/macintosh/mac_hid.c | 3 +- drivers/md/md.c | 3 +- drivers/misc/sgi-xp/xpc_main.c | 6 +-- drivers/net/vrf.c | 3 +- drivers/parport/procfs.c | 42 ++++++++----------- drivers/perf/arm_pmuv3.c | 3 +- drivers/scsi/scsi_sysctl.c | 3 +- drivers/scsi/sg.c | 3 +- drivers/tty/tty_io.c | 3 +- drivers/xen/balloon.c | 3 +- fs/aio.c | 3 +- fs/cachefiles/error_inject.c | 3 +- fs/coda/sysctl.c | 3 +- fs/coredump.c | 3 +- fs/dcache.c | 3 +- fs/devpts/inode.c | 3 +- fs/eventpoll.c | 3 +- fs/exec.c | 3 +- fs/file_table.c | 3 +- fs/inode.c | 3 +- fs/lockd/svc.c | 3 +- fs/locks.c | 3 +- fs/namei.c | 3 +- fs/namespace.c | 3 +- fs/nfs/nfs4sysctl.c | 3 +- fs/nfs/sysctl.c | 3 +- fs/notify/dnotify/dnotify.c | 3 +- fs/notify/fanotify/fanotify_user.c | 3 +- fs/notify/inotify/inotify_user.c | 3 +- fs/ntfs/sysctl.c | 3 +- fs/ocfs2/stackglue.c | 3 +- fs/pipe.c | 3 +- fs/proc/proc_sysctl.c | 8 ++-- fs/quota/dquot.c | 3 +- fs/sysctls.c | 3 +- fs/userfaultfd.c | 3 +- fs/verity/signature.c | 3 +- fs/xfs/xfs_sysctl.c | 4 +- init/do_mounts_initrd.c | 3 +- ipc/ipc_sysctl.c | 3 +- ipc/mq_sysctl.c | 3 +- kernel/acct.c | 3 +- kernel/bpf/syscall.c | 3 +- kernel/delayacct.c | 3 +- kernel/exit.c | 3 +- kernel/hung_task.c | 3 +- kernel/kexec_core.c | 3 +- kernel/kprobes.c | 3 +- kernel/latencytop.c | 3 +- kernel/locking/lockdep.c | 3 +- kernel/panic.c | 3 +- kernel/pid_namespace.c | 3 +- kernel/pid_sysctl.h | 3 +- kernel/printk/sysctl.c | 3 +- kernel/reboot.c | 3 +- kernel/sched/autogroup.c | 3 +- kernel/sched/core.c | 3 +- kernel/sched/deadline.c | 3 +- kernel/sched/fair.c | 3 +- kernel/sched/rt.c | 3 +- kernel/sched/topology.c | 3 +- kernel/seccomp.c | 3 +- kernel/signal.c | 3 +- kernel/stackleak.c | 3 +- kernel/sysctl.c | 6 +-- kernel/time/timer.c | 3 +- kernel/trace/ftrace.c | 3 +- kernel/trace/trace_events_user.c | 3 +- kernel/ucount.c | 7 ++-- kernel/umh.c | 3 +- kernel/utsname_sysctl.c | 3 +- kernel/watchdog.c | 3 +- lib/test_sysctl.c | 6 +-- mm/compaction.c | 3 +- mm/hugetlb.c | 3 +- mm/hugetlb_vmemmap.c | 3 +- mm/memory-failure.c | 3 +- mm/oom_kill.c | 3 +- mm/page-writeback.c | 3 +- net/appletalk/sysctl_net_atalk.c | 3 +- net/ax25/sysctl_net_ax25.c | 5 +-- net/bridge/br_netfilter_hooks.c | 3 +- net/core/neighbour.c | 14 +++---- net/core/sysctl_net_core.c | 6 +-- net/dccp/sysctl.c | 4 +- net/ieee802154/6lowpan/reassembly.c | 6 +-- net/ipv4/devinet.c | 5 +-- net/ipv4/ip_fragment.c | 6 +-- net/ipv4/route.c | 6 +-- net/ipv4/sysctl_net_ipv4.c | 6 +-- net/ipv4/xfrm4_policy.c | 3 +- net/ipv6/addrconf.c | 5 +-- net/ipv6/icmp.c | 3 +- net/ipv6/netfilter/nf_conntrack_reasm.c | 3 +- net/ipv6/reassembly.c | 6 +-- net/ipv6/route.c | 3 +- net/ipv6/sysctl_net_ipv6.c | 6 +-- net/ipv6/xfrm6_policy.c | 3 +- net/llc/sysctl_net_llc.c | 4 +- net/mpls/af_mpls.c | 10 ++--- net/mptcp/ctrl.c | 3 +- net/netfilter/ipvs/ip_vs_ctl.c | 3 +- net/netfilter/ipvs/ip_vs_lblc.c | 3 +- net/netfilter/ipvs/ip_vs_lblcr.c | 3 +- net/netfilter/nf_conntrack_standalone.c | 10 ++--- net/netfilter/nf_log.c | 5 +-- net/netrom/sysctl_net_netrom.c | 3 +- net/phonet/sysctl.c | 3 +- net/rds/ib_sysctl.c | 3 +- net/rds/sysctl.c | 3 +- net/rds/tcp.c | 3 +- net/rose/sysctl_net_rose.c | 3 +- net/rxrpc/sysctl.c | 3 +- net/sctp/sysctl.c | 10 ++--- net/smc/smc_sysctl.c | 3 +- net/sunrpc/sysctl.c | 3 +- net/sunrpc/xprtrdma/svc_rdma.c | 3 +- net/sunrpc/xprtrdma/transport.c | 3 +- net/sunrpc/xprtsock.c | 3 +- net/tipc/sysctl.c | 3 +- net/unix/sysctl_net_unix.c | 3 +- net/x25/sysctl_net_x25.c | 3 +- net/xfrm/xfrm_sysctl.c | 3 +- security/apparmor/lsm.c | 4 +- security/keys/sysctl.c | 7 ++-- security/loadpin/loadpin.c | 3 +- security/yama/yama_lsm.c | 3 +- 152 files changed, 228 insertions(+), 407 deletions(-) diff --git a/arch/arm/kernel/isa.c b/arch/arm/kernel/isa.c index 561432e3c55a..72b1a0e63d21 100644 --- a/arch/arm/kernel/isa.c +++ b/arch/arm/kernel/isa.c @@ -16,7 +16,7 @@ static unsigned int isa_membase, isa_portbase, isa_portshift; -static struct ctl_table ctl_isa_vars[4] = { +static struct ctl_table ctl_isa_vars[] = { { .procname = "membase", .data = &isa_membase, @@ -35,7 +35,7 @@ static struct ctl_table ctl_isa_vars[4] = { .maxlen = sizeof(isa_portshift), .mode = 0444, .proc_handler = proc_dointvec, - }, {} + } }; static struct ctl_table_header *isa_sysctl_header; diff --git a/arch/arm64/kernel/armv8_deprecated.c b/arch/arm64/kernel/armv8_deprecated.c index 68ed60a521a6..43945a8bb8e0 100644 --- a/arch/arm64/kernel/armv8_deprecated.c +++ b/arch/arm64/kernel/armv8_deprecated.c @@ -52,10 +52,8 @@ struct insn_emulation { int min; int max; - /* - * sysctl for this emulation + a sentinal entry. - */ - struct ctl_table sysctl[2]; + /* sysctl for this emulation */ + struct ctl_table sysctl; }; #define ARM_OPCODE_CONDTEST_FAIL 0 @@ -558,7 +556,7 @@ static void __init register_insn_emulation(struct insn_emulation *insn) update_insn_emulation_mode(insn, INSN_UNDEF); if (insn->status != INSN_UNAVAILABLE) { - sysctl = &insn->sysctl[0]; + sysctl = &insn->sysctl; sysctl->mode = 0644; sysctl->maxlen = sizeof(int); diff --git a/arch/arm64/kernel/fpsimd.c b/arch/arm64/kernel/fpsimd.c index ecfb2ef6a036..37155b4ae893 100644 --- a/arch/arm64/kernel/fpsimd.c +++ b/arch/arm64/kernel/fpsimd.c @@ -588,8 +588,7 @@ static struct ctl_table sve_default_vl_table[] = { .mode = 0644, .proc_handler = vec_proc_do_default_vl, .extra1 = &vl_info[ARM64_VEC_SVE], - }, - { } + } }; static int __init sve_sysctl_init(void) @@ -613,8 +612,7 @@ static struct ctl_table sme_default_vl_table[] = { .mode = 0644, .proc_handler = vec_proc_do_default_vl, .extra1 = &vl_info[ARM64_VEC_SME], - }, - { } + } }; static int __init sme_sysctl_init(void) diff --git a/arch/arm64/kernel/process.c b/arch/arm64/kernel/process.c index cfe232960f2f..ae837130a265 100644 --- a/arch/arm64/kernel/process.c +++ b/arch/arm64/kernel/process.c @@ -723,8 +723,7 @@ static struct ctl_table tagged_addr_sysctl_table[] = { .proc_handler = proc_dointvec_minmax, .extra1 = SYSCTL_ZERO, .extra2 = SYSCTL_ONE, - }, - { } + } }; static int __init tagged_addr_init(void) diff --git a/arch/ia64/kernel/crash.c b/arch/ia64/kernel/crash.c index 66917b879b2a..958ab3bbbdbc 100644 --- a/arch/ia64/kernel/crash.c +++ b/arch/ia64/kernel/crash.c @@ -231,8 +231,7 @@ static struct ctl_table kdump_ctl_table[] = { .maxlen = sizeof(int), .mode = 0644, .proc_handler = proc_dointvec, - }, - { } + } }; #endif diff --git a/arch/powerpc/kernel/idle.c b/arch/powerpc/kernel/idle.c index 3807169fc7e7..f98f7b00d3cf 100644 --- a/arch/powerpc/kernel/idle.c +++ b/arch/powerpc/kernel/idle.c @@ -104,8 +104,7 @@ static struct ctl_table powersave_nap_ctl_table[] = { .maxlen = sizeof(int), .mode = 0644, .proc_handler = proc_dointvec, - }, - {} + } }; static int __init diff --git a/arch/powerpc/platforms/pseries/mobility.c b/arch/powerpc/platforms/pseries/mobility.c index 9fdbee8ee126..48337c9dd3a0 100644 --- a/arch/powerpc/platforms/pseries/mobility.c +++ b/arch/powerpc/platforms/pseries/mobility.c @@ -59,8 +59,7 @@ static struct ctl_table nmi_wd_lpm_factor_ctl_table[] = { .maxlen = sizeof(int), .mode = 0644, .proc_handler = proc_douintvec_minmax, - }, - {} + } }; static int __init register_nmi_wd_lpm_factor_sysctl(void) diff --git a/arch/s390/appldata/appldata_base.c b/arch/s390/appldata/appldata_base.c index 54d8ed1c4518..0e1136b3dc01 100644 --- a/arch/s390/appldata/appldata_base.c +++ b/arch/s390/appldata/appldata_base.c @@ -62,8 +62,7 @@ static struct ctl_table appldata_table[] = { .procname = "interval", .mode = S_IRUGO | S_IWUSR, .proc_handler = appldata_interval_handler, - }, - { }, + } }; /* @@ -352,7 +351,7 @@ int appldata_register_ops(struct appldata_ops *ops) return -EINVAL; /* The last entry must be an empty one */ - ops->ctl_table = kcalloc(2, sizeof(struct ctl_table), GFP_KERNEL); + ops->ctl_table = kcalloc(1, sizeof(struct ctl_table), GFP_KERNEL); if (!ops->ctl_table) return -ENOMEM; @@ -365,7 +364,7 @@ int appldata_register_ops(struct appldata_ops *ops) ops->ctl_table[0].proc_handler = appldata_generic_handler; ops->ctl_table[0].data = ops; - ops->sysctl_header = register_sysctl(appldata_proc_name, ops->ctl_table); + ops->sysctl_header = register_sysctl(appldata_proc_name, ops->ctl_table, 1); if (!ops->sysctl_header) goto out; return 0; diff --git a/arch/s390/kernel/debug.c b/arch/s390/kernel/debug.c index 002f843e6523..24f33be6565d 100644 --- a/arch/s390/kernel/debug.c +++ b/arch/s390/kernel/debug.c @@ -977,8 +977,7 @@ static struct ctl_table s390dbf_table[] = { .maxlen = sizeof(int), .mode = S_IRUGO | S_IWUSR, .proc_handler = s390dbf_procactive, - }, - { } + } }; static struct ctl_table_header *s390dbf_sysctl_header; diff --git a/arch/s390/kernel/topology.c b/arch/s390/kernel/topology.c index 372d2c7c9a8e..931da71b8a4a 100644 --- a/arch/s390/kernel/topology.c +++ b/arch/s390/kernel/topology.c @@ -633,8 +633,7 @@ static struct ctl_table topology_ctl_table[] = { .procname = "topology", .mode = 0644, .proc_handler = topology_ctl_handler, - }, - { }, + } }; static int __init topology_init(void) diff --git a/arch/s390/mm/cmm.c b/arch/s390/mm/cmm.c index 918816dcb42a..1b304352a3e9 100644 --- a/arch/s390/mm/cmm.c +++ b/arch/s390/mm/cmm.c @@ -331,8 +331,7 @@ static struct ctl_table cmm_table[] = { .procname = "cmm_timeout", .mode = 0644, .proc_handler = cmm_timeout_handler, - }, - { } + } }; #ifdef CONFIG_CMM_IUCV diff --git a/arch/s390/mm/pgalloc.c b/arch/s390/mm/pgalloc.c index a723f1a8236a..59444f580d0d 100644 --- a/arch/s390/mm/pgalloc.c +++ b/arch/s390/mm/pgalloc.c @@ -29,8 +29,7 @@ static struct ctl_table page_table_sysctl[] = { .proc_handler = proc_dointvec_minmax, .extra1 = SYSCTL_ZERO, .extra2 = SYSCTL_ONE, - }, - { } + } }; static int __init page_table_register_sysctl(void) diff --git a/arch/x86/entry/vdso/vdso32-setup.c b/arch/x86/entry/vdso/vdso32-setup.c index e28cdba83e0e..ab794f70a550 100644 --- a/arch/x86/entry/vdso/vdso32-setup.c +++ b/arch/x86/entry/vdso/vdso32-setup.c @@ -66,8 +66,7 @@ static struct ctl_table abi_table2[] = { .proc_handler = proc_dointvec_minmax, .extra1 = SYSCTL_ZERO, .extra2 = SYSCTL_ONE, - }, - {} + } }; static __init int ia32_binfmt_init(void) diff --git a/arch/x86/kernel/cpu/intel.c b/arch/x86/kernel/cpu/intel.c index c77a3961443d..d446f2a0fbeb 100644 --- a/arch/x86/kernel/cpu/intel.c +++ b/arch/x86/kernel/cpu/intel.c @@ -1189,8 +1189,7 @@ static struct ctl_table sld_sysctls[] = { .proc_handler = proc_douintvec_minmax, .extra1 = SYSCTL_ZERO, .extra2 = SYSCTL_ONE, - }, - {} + } }; static int __init sld_mitigate_sysctl_init(void) diff --git a/arch/x86/kernel/itmt.c b/arch/x86/kernel/itmt.c index 58ec95fce798..427093e4ef87 100644 --- a/arch/x86/kernel/itmt.c +++ b/arch/x86/kernel/itmt.c @@ -73,8 +73,7 @@ static struct ctl_table itmt_kern_table[] = { .proc_handler = sched_itmt_update_handler, .extra1 = SYSCTL_ZERO, .extra2 = SYSCTL_ONE, - }, - {} + } }; static struct ctl_table_header *itmt_sysctl_header; diff --git a/crypto/fips.c b/crypto/fips.c index 05a251680700..611a86bd2538 100644 --- a/crypto/fips.c +++ b/crypto/fips.c @@ -62,8 +62,7 @@ static struct ctl_table crypto_sysctl_table[] = { .maxlen = 64, .mode = 0444, .proc_handler = proc_dostring - }, - {} + } }; static struct ctl_table_header *crypto_sysctls; diff --git a/drivers/base/firmware_loader/fallback_table.c b/drivers/base/firmware_loader/fallback_table.c index 7a2d584233bb..d7dedfb2f4d0 100644 --- a/drivers/base/firmware_loader/fallback_table.c +++ b/drivers/base/firmware_loader/fallback_table.c @@ -43,8 +43,7 @@ static struct ctl_table firmware_config_table[] = { .proc_handler = proc_douintvec_minmax, .extra1 = SYSCTL_ZERO, .extra2 = SYSCTL_ONE, - }, - { } + } }; static struct ctl_table_header *firmware_config_sysct_table_header; diff --git a/drivers/cdrom/cdrom.c b/drivers/cdrom/cdrom.c index 3855da76a16d..e1c352ebab16 100644 --- a/drivers/cdrom/cdrom.c +++ b/drivers/cdrom/cdrom.c @@ -3668,8 +3668,7 @@ static struct ctl_table cdrom_table[] = { .maxlen = sizeof(int), .mode = 0644, .proc_handler = cdrom_sysctl_handler - }, - { } + } }; static struct ctl_table_header *cdrom_sysctl_header; diff --git a/drivers/char/hpet.c b/drivers/char/hpet.c index bb1eb801b20c..44eaec98f958 100644 --- a/drivers/char/hpet.c +++ b/drivers/char/hpet.c @@ -722,13 +722,12 @@ static int hpet_is_known(struct hpet_data *hdp) static struct ctl_table hpet_table[] = { { - .procname = "max-user-freq", - .data = &hpet_max_freq, - .maxlen = sizeof(int), - .mode = 0644, - .proc_handler = proc_dointvec, - }, - {} + .procname = "max-user-freq", + .data = &hpet_max_freq, + .maxlen = sizeof(int), + .mode = 0644, + .proc_handler = proc_dointvec, + } }; static struct ctl_table_header *sysctl_header; diff --git a/drivers/char/ipmi/ipmi_poweroff.c b/drivers/char/ipmi/ipmi_poweroff.c index 46b1ea866da9..40c43417a42e 100644 --- a/drivers/char/ipmi/ipmi_poweroff.c +++ b/drivers/char/ipmi/ipmi_poweroff.c @@ -655,8 +655,7 @@ static struct ctl_table ipmi_table[] = { .data = &poweroff_powercycle, .maxlen = sizeof(poweroff_powercycle), .mode = 0644, - .proc_handler = proc_dointvec }, - { } + .proc_handler = proc_dointvec } }; static struct ctl_table_header *ipmi_table_header; diff --git a/drivers/char/random.c b/drivers/char/random.c index 8db2ea9e3d66..e2998580afc6 100644 --- a/drivers/char/random.c +++ b/drivers/char/random.c @@ -1682,8 +1682,7 @@ static struct ctl_table random_table[] = { .procname = "uuid", .mode = 0444, .proc_handler = proc_do_uuid, - }, - { } + } }; /* diff --git a/drivers/gpu/drm/i915/i915_perf.c b/drivers/gpu/drm/i915/i915_perf.c index f43950219ffc..e4d7372afb10 100644 --- a/drivers/gpu/drm/i915/i915_perf.c +++ b/drivers/gpu/drm/i915/i915_perf.c @@ -4884,24 +4884,23 @@ int i915_perf_remove_config_ioctl(struct drm_device *dev, void *data, static struct ctl_table oa_table[] = { { - .procname = "perf_stream_paranoid", - .data = &i915_perf_stream_paranoid, - .maxlen = sizeof(i915_perf_stream_paranoid), - .mode = 0644, - .proc_handler = proc_dointvec_minmax, - .extra1 = SYSCTL_ZERO, - .extra2 = SYSCTL_ONE, - }, + .procname = "perf_stream_paranoid", + .data = &i915_perf_stream_paranoid, + .maxlen = sizeof(i915_perf_stream_paranoid), + .mode = 0644, + .proc_handler = proc_dointvec_minmax, + .extra1 = SYSCTL_ZERO, + .extra2 = SYSCTL_ONE, + }, { - .procname = "oa_max_sample_rate", - .data = &i915_oa_max_sample_rate, - .maxlen = sizeof(i915_oa_max_sample_rate), - .mode = 0644, - .proc_handler = proc_dointvec_minmax, - .extra1 = SYSCTL_ZERO, - .extra2 = &oa_sample_rate_hard_limit, - }, - {} + .procname = "oa_max_sample_rate", + .data = &i915_oa_max_sample_rate, + .maxlen = sizeof(i915_oa_max_sample_rate), + .mode = 0644, + .proc_handler = proc_dointvec_minmax, + .extra1 = SYSCTL_ZERO, + .extra2 = &oa_sample_rate_hard_limit, + } }; static u32 num_perf_groups_per_gt(struct intel_gt *gt) diff --git a/drivers/hv/hv_common.c b/drivers/hv/hv_common.c index dd751c391cf7..0216ccd96496 100644 --- a/drivers/hv/hv_common.c +++ b/drivers/hv/hv_common.c @@ -146,8 +146,7 @@ static struct ctl_table hv_ctl_table[] = { .proc_handler = proc_dointvec_minmax, .extra1 = SYSCTL_ZERO, .extra2 = SYSCTL_ONE - }, - {} + } }; static int hv_die_panic_notify_crash(struct notifier_block *self, diff --git a/drivers/infiniband/core/iwcm.c b/drivers/infiniband/core/iwcm.c index 20627a894c89..0147aae8fe9b 100644 --- a/drivers/infiniband/core/iwcm.c +++ b/drivers/infiniband/core/iwcm.c @@ -110,8 +110,7 @@ static struct ctl_table iwcm_ctl_table[] = { .maxlen = sizeof(default_backlog), .mode = 0644, .proc_handler = proc_dointvec, - }, - { } + } }; /* diff --git a/drivers/infiniband/core/ucma.c b/drivers/infiniband/core/ucma.c index f737ab0de883..cbe1ebef2f2e 100644 --- a/drivers/infiniband/core/ucma.c +++ b/drivers/infiniband/core/ucma.c @@ -70,8 +70,7 @@ static struct ctl_table ucma_ctl_table[] = { .maxlen = sizeof max_backlog, .mode = 0644, .proc_handler = proc_dointvec, - }, - { } + } }; struct ucma_file { diff --git a/drivers/macintosh/mac_hid.c b/drivers/macintosh/mac_hid.c index 5d433ef430fa..822517cf4735 100644 --- a/drivers/macintosh/mac_hid.c +++ b/drivers/macintosh/mac_hid.c @@ -235,8 +235,7 @@ static struct ctl_table mac_hid_files[] = { .maxlen = sizeof(int), .mode = 0644, .proc_handler = proc_dointvec, - }, - { } + } }; static struct ctl_table_header *mac_hid_sysctl_header; diff --git a/drivers/md/md.c b/drivers/md/md.c index c10cc8ddd94d..3ad23a7bfbc5 100644 --- a/drivers/md/md.c +++ b/drivers/md/md.c @@ -318,8 +318,7 @@ static struct ctl_table raid_table[] = { .maxlen = sizeof(int), .mode = S_IRUGO|S_IWUSR, .proc_handler = proc_dointvec, - }, - { } + } }; static int start_readonly; diff --git a/drivers/misc/sgi-xp/xpc_main.c b/drivers/misc/sgi-xp/xpc_main.c index 264b919d0610..3e6a598df22a 100644 --- a/drivers/misc/sgi-xp/xpc_main.c +++ b/drivers/misc/sgi-xp/xpc_main.c @@ -109,8 +109,7 @@ static struct ctl_table xpc_sys_xpc_hb[] = { .mode = 0644, .proc_handler = proc_dointvec_minmax, .extra1 = &xpc_hb_check_min_interval, - .extra2 = &xpc_hb_check_max_interval}, - {} + .extra2 = &xpc_hb_check_max_interval} }; static struct ctl_table xpc_sys_xpc[] = { { @@ -120,8 +119,7 @@ static struct ctl_table xpc_sys_xpc[] = { .mode = 0644, .proc_handler = proc_dointvec_minmax, .extra1 = &xpc_disengage_min_timelimit, - .extra2 = &xpc_disengage_max_timelimit}, - {} + .extra2 = &xpc_disengage_max_timelimit} }; static struct ctl_table_header *xpc_sysctl; diff --git a/drivers/net/vrf.c b/drivers/net/vrf.c index edd8f2ba5595..22dedd3671ec 100644 --- a/drivers/net/vrf.c +++ b/drivers/net/vrf.c @@ -1964,8 +1964,7 @@ static const struct ctl_table vrf_table[] = { .proc_handler = vrf_shared_table_handler, /* set by the vrf_netns_init */ .extra1 = NULL, - }, - { }, + } }; static int vrf_netns_init_sysctl(struct net *net, struct netns_vrf *nn_vrf) diff --git a/drivers/parport/procfs.c b/drivers/parport/procfs.c index 16cee52f035f..f6e0121f8904 100644 --- a/drivers/parport/procfs.c +++ b/drivers/parport/procfs.c @@ -259,8 +259,12 @@ PARPORT_MAX_SPINTIME_VALUE; struct parport_sysctl_table { struct ctl_table_header *port_header; struct ctl_table_header *devices_header; - struct ctl_table vars[12]; - struct ctl_table device_dir[2]; +#ifdef CONFIG_PARPORT_1284 + struct ctl_table vars[10]; +#else + struct ctl_table vars[5]; +#endif /* IEEE 1284 support */ + struct ctl_table device_dir[1]; }; static const struct parport_sysctl_table parport_sysctl_template = { @@ -303,9 +307,9 @@ static const struct parport_sysctl_table parport_sysctl_template = { .maxlen = 0, .mode = 0444, .proc_handler = do_hardware_modes - }, + } #ifdef CONFIG_PARPORT_1284 - { + , { .procname = "autoprobe", .data = NULL, .maxlen = 0, @@ -339,9 +343,8 @@ static const struct parport_sysctl_table parport_sysctl_template = { .maxlen = 0, .mode = 0444, .proc_handler = do_autoprobe - }, + } #endif /* IEEE 1284 support */ - {} }, { { @@ -350,20 +353,15 @@ static const struct parport_sysctl_table parport_sysctl_template = { .maxlen = 0, .mode = 0444, .proc_handler = do_active_device - }, - {} + } }, }; struct parport_device_sysctl_table { struct ctl_table_header *sysctl_header; - struct ctl_table vars[2]; - struct ctl_table device_dir[2]; - struct ctl_table devices_root_dir[2]; - struct ctl_table port_dir[2]; - struct ctl_table parport_dir[2]; - struct ctl_table dev_dir[2]; + struct ctl_table vars[1]; + struct ctl_table device_dir[1]; }; static const struct parport_device_sysctl_table @@ -378,8 +376,7 @@ parport_device_sysctl_template = { .proc_handler = proc_doulongvec_ms_jiffies_minmax, .extra1 = (void*) &parport_min_timeslice_value, .extra2 = (void*) &parport_max_timeslice_value - }, - {} + } }, { { @@ -387,18 +384,14 @@ parport_device_sysctl_template = { .data = NULL, .maxlen = 0, .mode = 0555, - }, - {} + } } }; struct parport_default_sysctl_table { struct ctl_table_header *sysctl_header; - struct ctl_table vars[3]; - struct ctl_table default_dir[2]; - struct ctl_table parport_dir[2]; - struct ctl_table dev_dir[2]; + struct ctl_table vars[2]; }; static struct parport_default_sysctl_table @@ -422,8 +415,7 @@ parport_default_sysctl_table = { .proc_handler = proc_dointvec_minmax, .extra1 = (void*) &parport_min_spintime_value, .extra2 = (void*) &parport_max_spintime_value - }, - {} + } } }; @@ -443,7 +435,9 @@ int parport_proc_register(struct parport *port) t->vars[0].data = &port->spintime; for (i = 0; i < 5; i++) { t->vars[i].extra1 = port; +#ifdef CONFIG_PARPORT_1284 t->vars[5 + i].extra2 = &port->probe_info[i]; +#endif /* IEEE 1284 support */ } port_name_len = strnlen(port->name, PARPORT_NAME_MAX_LEN); diff --git a/drivers/perf/arm_pmuv3.c b/drivers/perf/arm_pmuv3.c index 763f9c8acfbf..85285c85bd49 100644 --- a/drivers/perf/arm_pmuv3.c +++ b/drivers/perf/arm_pmuv3.c @@ -1179,8 +1179,7 @@ static struct ctl_table armv8_pmu_sysctl_table[] = { .proc_handler = armv8pmu_proc_user_access_handler, .extra1 = SYSCTL_ZERO, .extra2 = SYSCTL_ONE, - }, - { } + } }; static void armv8_pmu_register_sysctl_table(void) diff --git a/drivers/scsi/scsi_sysctl.c b/drivers/scsi/scsi_sysctl.c index 0378bd63fea4..22c2d055821e 100644 --- a/drivers/scsi/scsi_sysctl.c +++ b/drivers/scsi/scsi_sysctl.c @@ -17,8 +17,7 @@ static struct ctl_table scsi_table[] = { .data = &scsi_logging_level, .maxlen = sizeof(scsi_logging_level), .mode = 0644, - .proc_handler = proc_dointvec }, - { } + .proc_handler = proc_dointvec } }; static struct ctl_table_header *scsi_table_header; diff --git a/drivers/scsi/sg.c b/drivers/scsi/sg.c index d12cdf875b50..102a3640c6c7 100644 --- a/drivers/scsi/sg.c +++ b/drivers/scsi/sg.c @@ -1638,8 +1638,7 @@ static struct ctl_table sg_sysctls[] = { .maxlen = sizeof(int), .mode = 0444, .proc_handler = proc_dointvec, - }, - {} + } }; static struct ctl_table_header *hdr; diff --git a/drivers/tty/tty_io.c b/drivers/tty/tty_io.c index 63fb3c543b94..bd6b12394d76 100644 --- a/drivers/tty/tty_io.c +++ b/drivers/tty/tty_io.c @@ -3608,8 +3608,7 @@ static struct ctl_table tty_table[] = { .proc_handler = proc_dointvec, .extra1 = SYSCTL_ZERO, .extra2 = SYSCTL_ONE, - }, - { } + } }; /* diff --git a/drivers/xen/balloon.c b/drivers/xen/balloon.c index e4544262a429..bef75c236104 100644 --- a/drivers/xen/balloon.c +++ b/drivers/xen/balloon.c @@ -93,8 +93,7 @@ static struct ctl_table balloon_table[] = { .proc_handler = proc_dointvec_minmax, .extra1 = SYSCTL_ZERO, .extra2 = SYSCTL_ONE, - }, - { } + } }; #else diff --git a/fs/aio.c b/fs/aio.c index b09abe7a14d3..f2ed0a34a5d4 100644 --- a/fs/aio.c +++ b/fs/aio.c @@ -238,8 +238,7 @@ static struct ctl_table aio_sysctls[] = { .maxlen = sizeof(aio_max_nr), .mode = 0644, .proc_handler = proc_doulongvec_minmax, - }, - {} + } }; static void __init aio_sysctl_init(void) diff --git a/fs/cachefiles/error_inject.c b/fs/cachefiles/error_inject.c index ea6bcce4f6f1..4fa84880c0d1 100644 --- a/fs/cachefiles/error_inject.c +++ b/fs/cachefiles/error_inject.c @@ -18,8 +18,7 @@ static struct ctl_table cachefiles_sysctls[] = { .maxlen = sizeof(unsigned int), .mode = 0644, .proc_handler = proc_douintvec, - }, - {} + } }; int __init cachefiles_register_error_injection(void) diff --git a/fs/coda/sysctl.c b/fs/coda/sysctl.c index 16224a7c6691..e377e400bfed 100644 --- a/fs/coda/sysctl.c +++ b/fs/coda/sysctl.c @@ -35,8 +35,7 @@ static struct ctl_table coda_table[] = { .maxlen = sizeof(int), .mode = 0600, .proc_handler = proc_dointvec - }, - {} + } }; void coda_sysctl_init(void) diff --git a/fs/coredump.c b/fs/coredump.c index 7e55428dce13..99142426a156 100644 --- a/fs/coredump.c +++ b/fs/coredump.c @@ -978,8 +978,7 @@ static struct ctl_table coredump_sysctls[] = { .maxlen = sizeof(unsigned int), .mode = 0644, .proc_handler = proc_dointvec, - }, - { } + } }; static int __init init_fs_coredump_sysctls(void) diff --git a/fs/dcache.c b/fs/dcache.c index f02bfd383e66..257450fd8f01 100644 --- a/fs/dcache.c +++ b/fs/dcache.c @@ -190,8 +190,7 @@ static struct ctl_table fs_dcache_sysctls[] = { .maxlen = 6*sizeof(long), .mode = 0444, .proc_handler = proc_nr_dentry, - }, - { } + } }; static int __init init_fs_dcache_sysctls(void) diff --git a/fs/devpts/inode.c b/fs/devpts/inode.c index c17f971a8c4b..8d56add71e71 100644 --- a/fs/devpts/inode.c +++ b/fs/devpts/inode.c @@ -68,8 +68,7 @@ static struct ctl_table pty_table[] = { .mode = 0444, .data = &pty_count, .proc_handler = proc_dointvec, - }, - {} + } }; struct pts_mount_opts { diff --git a/fs/eventpoll.c b/fs/eventpoll.c index e1a0e6a6d3de..b0556c52685c 100644 --- a/fs/eventpoll.c +++ b/fs/eventpoll.c @@ -321,8 +321,7 @@ static struct ctl_table epoll_table[] = { .proc_handler = proc_doulongvec_minmax, .extra1 = &long_zero, .extra2 = &long_max, - }, - { } + } }; static void __init epoll_sysctls_init(void) diff --git a/fs/exec.c b/fs/exec.c index 5572d148738b..9458ef2b8028 100644 --- a/fs/exec.c +++ b/fs/exec.c @@ -2164,8 +2164,7 @@ static struct ctl_table fs_exec_sysctls[] = { .proc_handler = proc_dointvec_minmax_coredump, .extra1 = SYSCTL_ZERO, .extra2 = SYSCTL_TWO, - }, - { } + } }; static int __init init_fs_exec_sysctls(void) diff --git a/fs/file_table.c b/fs/file_table.c index 23a645521960..6fec4c691f0a 100644 --- a/fs/file_table.c +++ b/fs/file_table.c @@ -114,8 +114,7 @@ static struct ctl_table fs_stat_sysctls[] = { .proc_handler = proc_dointvec_minmax, .extra1 = &sysctl_nr_open_min, .extra2 = &sysctl_nr_open_max, - }, - { } + } }; static int __init init_fs_stat_sysctls(void) diff --git a/fs/inode.c b/fs/inode.c index 0a0ad1a2a5d2..79c5916cade7 100644 --- a/fs/inode.c +++ b/fs/inode.c @@ -129,8 +129,7 @@ static struct ctl_table inodes_sysctls[] = { .maxlen = 7*sizeof(long), .mode = 0444, .proc_handler = proc_nr_inodes, - }, - { } + } }; static int __init init_fs_inode_sysctls(void) diff --git a/fs/lockd/svc.c b/fs/lockd/svc.c index 84736267f4e1..082fcf6340d4 100644 --- a/fs/lockd/svc.c +++ b/fs/lockd/svc.c @@ -506,8 +506,7 @@ static struct ctl_table nlm_sysctls[] = { .maxlen = sizeof(int), .mode = 0644, .proc_handler = proc_dointvec, - }, - { } + } }; #endif /* CONFIG_SYSCTL */ diff --git a/fs/locks.c b/fs/locks.c index ce5733480aa6..9750076cdd8d 100644 --- a/fs/locks.c +++ b/fs/locks.c @@ -109,9 +109,8 @@ static struct ctl_table locks_sysctls[] = { .maxlen = sizeof(int), .mode = 0644, .proc_handler = proc_dointvec, - }, + } #endif /* CONFIG_MMU */ - {} }; static int __init init_fs_locks_sysctls(void) diff --git a/fs/namei.c b/fs/namei.c index 9b567af081af..b0f8d09c2111 100644 --- a/fs/namei.c +++ b/fs/namei.c @@ -1067,8 +1067,7 @@ static struct ctl_table namei_sysctls[] = { .proc_handler = proc_dointvec_minmax, .extra1 = SYSCTL_ZERO, .extra2 = SYSCTL_TWO, - }, - { } + } }; static int __init init_fs_namei_sysctls(void) diff --git a/fs/namespace.c b/fs/namespace.c index e7f251e40485..780e9292fa52 100644 --- a/fs/namespace.c +++ b/fs/namespace.c @@ -4709,8 +4709,7 @@ static struct ctl_table fs_namespace_sysctls[] = { .mode = 0644, .proc_handler = proc_dointvec_minmax, .extra1 = SYSCTL_ONE, - }, - { } + } }; static int __init init_fs_namespace_sysctls(void) diff --git a/fs/nfs/nfs4sysctl.c b/fs/nfs/nfs4sysctl.c index 4a542ee11e68..5515c2e8afe7 100644 --- a/fs/nfs/nfs4sysctl.c +++ b/fs/nfs/nfs4sysctl.c @@ -33,8 +33,7 @@ static struct ctl_table nfs4_cb_sysctls[] = { .maxlen = sizeof(int), .mode = 0644, .proc_handler = proc_dointvec, - }, - { } + } }; int nfs4_register_sysctl(void) diff --git a/fs/nfs/sysctl.c b/fs/nfs/sysctl.c index 9dafd44670e4..8a71d31e5dc3 100644 --- a/fs/nfs/sysctl.c +++ b/fs/nfs/sysctl.c @@ -28,8 +28,7 @@ static struct ctl_table nfs_cb_sysctls[] = { .maxlen = sizeof(nfs_congestion_kb), .mode = 0644, .proc_handler = proc_dointvec, - }, - { } + } }; int nfs_register_sysctl(void) diff --git a/fs/notify/dnotify/dnotify.c b/fs/notify/dnotify/dnotify.c index 2c6fe98d6fe1..409ca0a9a048 100644 --- a/fs/notify/dnotify/dnotify.c +++ b/fs/notify/dnotify/dnotify.c @@ -28,8 +28,7 @@ static struct ctl_table dnotify_sysctls[] = { .maxlen = sizeof(int), .mode = 0644, .proc_handler = proc_dointvec, - }, - {} + } }; static void __init dnotify_sysctl_init(void) { diff --git a/fs/notify/fanotify/fanotify_user.c b/fs/notify/fanotify/fanotify_user.c index 78d3bf479f59..4c43eb38b9cf 100644 --- a/fs/notify/fanotify/fanotify_user.c +++ b/fs/notify/fanotify/fanotify_user.c @@ -85,8 +85,7 @@ static struct ctl_table fanotify_table[] = { .mode = 0644, .proc_handler = proc_dointvec_minmax, .extra1 = SYSCTL_ZERO - }, - { } + } }; static void __init fanotify_sysctls_init(void) diff --git a/fs/notify/inotify/inotify_user.c b/fs/notify/inotify/inotify_user.c index 0ce25c4ddfec..02b74d8b4e28 100644 --- a/fs/notify/inotify/inotify_user.c +++ b/fs/notify/inotify/inotify_user.c @@ -84,8 +84,7 @@ static struct ctl_table inotify_table[] = { .mode = 0644, .proc_handler = proc_dointvec_minmax, .extra1 = SYSCTL_ZERO - }, - { } + } }; static void __init inotify_sysctls_init(void) diff --git a/fs/ntfs/sysctl.c b/fs/ntfs/sysctl.c index 2c48f48a0b80..fef88fb6a40f 100644 --- a/fs/ntfs/sysctl.c +++ b/fs/ntfs/sysctl.c @@ -27,8 +27,7 @@ static struct ctl_table ntfs_sysctls[] = { .maxlen = sizeof(debug_msgs), .mode = 0644, /* Mode, proc handler. */ .proc_handler = proc_dointvec - }, - {} + } }; /* Storage for the sysctls header. */ diff --git a/fs/ocfs2/stackglue.c b/fs/ocfs2/stackglue.c index 9a653875d1c5..7be619f93960 100644 --- a/fs/ocfs2/stackglue.c +++ b/fs/ocfs2/stackglue.c @@ -657,8 +657,7 @@ static struct ctl_table ocfs2_nm_table[] = { .maxlen = OCFS2_MAX_HB_CTL_PATH, .mode = 0644, .proc_handler = proc_dostring, - }, - { } + } }; static struct ctl_table_header *ocfs2_table_header; diff --git a/fs/pipe.c b/fs/pipe.c index 8a808fc25552..8fab91c2d546 100644 --- a/fs/pipe.c +++ b/fs/pipe.c @@ -1491,8 +1491,7 @@ static struct ctl_table fs_pipe_sysctls[] = { .maxlen = sizeof(pipe_user_pages_soft), .mode = 0644, .proc_handler = proc_doulongvec_minmax, - }, - { } + } }; #endif diff --git a/fs/proc/proc_sysctl.c b/fs/proc/proc_sysctl.c index 9670c5b7b5b2..1debd01209fc 100644 --- a/fs/proc/proc_sysctl.c +++ b/fs/proc/proc_sysctl.c @@ -19,8 +19,9 @@ #include #include "internal.h" -#define list_for_each_table_entry(entry, header) \ - for ((entry) = (header->ctl_table); (entry)->procname; (entry)++) +#define list_for_each_table_entry(entry, header) \ + entry = header->ctl_table; \ + for (size_t i = 0 ; i < header->ctl_table_size ; ++i, entry++) static const struct dentry_operations proc_sys_dentry_operations; static const struct file_operations proc_sys_file_operations; @@ -69,8 +70,7 @@ static struct ctl_table root_table[] = { { .procname = "", .mode = S_IFDIR|S_IRUGO|S_IXUGO, - }, - { } + } }; static struct ctl_table_root sysctl_table_root = { .default_set.dir.header = { diff --git a/fs/quota/dquot.c b/fs/quota/dquot.c index 7c07654e4253..1eb18c8bd639 100644 --- a/fs/quota/dquot.c +++ b/fs/quota/dquot.c @@ -2941,9 +2941,8 @@ static struct ctl_table fs_dqstats_table[] = { .maxlen = sizeof(int), .mode = 0644, .proc_handler = proc_dointvec, - }, + } #endif - { }, }; static int __init dquot_init(void) diff --git a/fs/sysctls.c b/fs/sysctls.c index 944254dd92c0..d6ed656738ff 100644 --- a/fs/sysctls.c +++ b/fs/sysctls.c @@ -25,8 +25,7 @@ static struct ctl_table fs_shared_sysctls[] = { .proc_handler = proc_dointvec_minmax, .extra1 = SYSCTL_ZERO, .extra2 = SYSCTL_MAXOLDUID, - }, - { } + } }; static int __init init_fs_sysctls(void) diff --git a/fs/userfaultfd.c b/fs/userfaultfd.c index 4c3858769226..165b9c52e626 100644 --- a/fs/userfaultfd.c +++ b/fs/userfaultfd.c @@ -44,8 +44,7 @@ static struct ctl_table vm_userfaultfd_table[] = { .proc_handler = proc_dointvec_minmax, .extra1 = SYSCTL_ZERO, .extra2 = SYSCTL_ONE, - }, - { } + } }; #endif diff --git a/fs/verity/signature.c b/fs/verity/signature.c index f617c6a1f16c..05585e93f32b 100644 --- a/fs/verity/signature.c +++ b/fs/verity/signature.c @@ -97,8 +97,7 @@ static struct ctl_table fsverity_sysctl_table[] = { .proc_handler = proc_dointvec_minmax, .extra1 = SYSCTL_ZERO, .extra2 = SYSCTL_ONE, - }, - { } + } }; static int __init fsverity_sysctl_init(void) diff --git a/fs/xfs/xfs_sysctl.c b/fs/xfs/xfs_sysctl.c index 61075e9c9e37..5c6337526070 100644 --- a/fs/xfs/xfs_sysctl.c +++ b/fs/xfs/xfs_sysctl.c @@ -204,10 +204,8 @@ static struct ctl_table xfs_table[] = { .proc_handler = xfs_stats_clear_proc_handler, .extra1 = &xfs_params.stats_clear.min, .extra2 = &xfs_params.stats_clear.max - }, + } #endif /* CONFIG_PROC_FS */ - - {} }; int diff --git a/init/do_mounts_initrd.c b/init/do_mounts_initrd.c index 2b10abb8c80e..a894519efdd3 100644 --- a/init/do_mounts_initrd.c +++ b/init/do_mounts_initrd.c @@ -28,8 +28,7 @@ static struct ctl_table kern_do_mounts_initrd_table[] = { .maxlen = sizeof(int), .mode = 0644, .proc_handler = proc_dointvec, - }, - { } + } }; static __init int kernel_do_mounts_initrd_sysctls_init(void) diff --git a/ipc/ipc_sysctl.c b/ipc/ipc_sysctl.c index 8c62e443f78b..a46d15f5b476 100644 --- a/ipc/ipc_sysctl.c +++ b/ipc/ipc_sysctl.c @@ -175,9 +175,8 @@ static struct ctl_table ipc_sysctls[] = { .proc_handler = proc_dointvec_minmax, .extra1 = SYSCTL_ZERO, .extra2 = SYSCTL_INT_MAX, - }, + } #endif - {} }; static struct ctl_table_set *set_lookup(struct ctl_table_root *root) diff --git a/ipc/mq_sysctl.c b/ipc/mq_sysctl.c index ebb5ed81c151..8191d03b39cb 100644 --- a/ipc/mq_sysctl.c +++ b/ipc/mq_sysctl.c @@ -62,8 +62,7 @@ static struct ctl_table mq_sysctls[] = { .proc_handler = proc_dointvec_minmax, .extra1 = &msg_maxsize_limit_min, .extra2 = &msg_maxsize_limit_max, - }, - {} + } }; static struct ctl_table_set *set_lookup(struct ctl_table_root *root) diff --git a/kernel/acct.c b/kernel/acct.c index 67125b7c5ca2..93417042762b 100644 --- a/kernel/acct.c +++ b/kernel/acct.c @@ -83,8 +83,7 @@ static struct ctl_table kern_acct_table[] = { .maxlen = 3*sizeof(int), .mode = 0644, .proc_handler = proc_dointvec, - }, - { } + } }; static __init int kernel_acct_sysctls_init(void) diff --git a/kernel/bpf/syscall.c b/kernel/bpf/syscall.c index a81b5122b16b..980ad104fff8 100644 --- a/kernel/bpf/syscall.c +++ b/kernel/bpf/syscall.c @@ -5400,8 +5400,7 @@ static struct ctl_table bpf_syscall_table[] = { .data = &bpf_stats_enabled_key.key, .mode = 0644, .proc_handler = bpf_stats_handler, - }, - { } + } }; static int __init bpf_syscall_sysctl_init(void) diff --git a/kernel/delayacct.c b/kernel/delayacct.c index 4ef14cb5b5a0..539cab051d17 100644 --- a/kernel/delayacct.c +++ b/kernel/delayacct.c @@ -73,8 +73,7 @@ static struct ctl_table kern_delayacct_table[] = { .proc_handler = sysctl_delayacct, .extra1 = SYSCTL_ZERO, .extra2 = SYSCTL_ONE, - }, - { } + } }; static __init int kernel_delayacct_sysctls_init(void) diff --git a/kernel/exit.c b/kernel/exit.c index 633c7a52ef80..87cb53a33bbc 100644 --- a/kernel/exit.c +++ b/kernel/exit.c @@ -89,8 +89,7 @@ static struct ctl_table kern_exit_table[] = { .maxlen = sizeof(oops_limit), .mode = 0644, .proc_handler = proc_douintvec, - }, - { } + } }; static __init int kernel_exit_sysctls_init(void) diff --git a/kernel/hung_task.c b/kernel/hung_task.c index 816f133266c4..8d0659453421 100644 --- a/kernel/hung_task.c +++ b/kernel/hung_task.c @@ -312,8 +312,7 @@ static struct ctl_table hung_task_sysctls[] = { .mode = 0644, .proc_handler = proc_dointvec_minmax, .extra1 = SYSCTL_NEG_ONE, - }, - {} + } }; static void __init hung_task_sysctl_init(void) diff --git a/kernel/kexec_core.c b/kernel/kexec_core.c index 63b04e710890..160779e0a503 100644 --- a/kernel/kexec_core.c +++ b/kernel/kexec_core.c @@ -1001,8 +1001,7 @@ static struct ctl_table kexec_core_sysctls[] = { .data = &load_limit_reboot, .mode = 0644, .proc_handler = kexec_limit_handler, - }, - { } + } }; static int __init kexec_core_sysctl_init(void) diff --git a/kernel/kprobes.c b/kernel/kprobes.c index 06a3ac7993f0..ae6b0f78ae6c 100644 --- a/kernel/kprobes.c +++ b/kernel/kprobes.c @@ -967,8 +967,7 @@ static struct ctl_table kprobe_sysctls[] = { .proc_handler = proc_kprobes_optimization_handler, .extra1 = SYSCTL_ZERO, .extra2 = SYSCTL_ONE, - }, - {} + } }; static void __init kprobe_sysctls_init(void) diff --git a/kernel/latencytop.c b/kernel/latencytop.c index 55050ae0e197..bb4dd0691b3c 100644 --- a/kernel/latencytop.c +++ b/kernel/latencytop.c @@ -84,8 +84,7 @@ static struct ctl_table latencytop_sysctl[] = { .maxlen = sizeof(int), .mode = 0644, .proc_handler = sysctl_latencytop, - }, - {} + } }; #endif diff --git a/kernel/locking/lockdep.c b/kernel/locking/lockdep.c index 1e29cec7e00c..0db8af590f87 100644 --- a/kernel/locking/lockdep.c +++ b/kernel/locking/lockdep.c @@ -95,9 +95,8 @@ static struct ctl_table kern_lockdep_table[] = { .maxlen = sizeof(int), .mode = 0644, .proc_handler = proc_dointvec, - }, + } #endif /* CONFIG_LOCK_STAT */ - { } }; static __init int kernel_lockdep_sysctls_init(void) diff --git a/kernel/panic.c b/kernel/panic.c index 0008273d23fd..79786433efda 100644 --- a/kernel/panic.c +++ b/kernel/panic.c @@ -98,8 +98,7 @@ static struct ctl_table kern_panic_table[] = { .maxlen = sizeof(warn_limit), .mode = 0644, .proc_handler = proc_douintvec, - }, - { } + } }; static __init int kernel_panic_sysctls_init(void) diff --git a/kernel/pid_namespace.c b/kernel/pid_namespace.c index 7fd5e8adc2e8..dc7adbd2f412 100644 --- a/kernel/pid_namespace.c +++ b/kernel/pid_namespace.c @@ -311,8 +311,7 @@ static struct ctl_table pid_ns_ctl_table[] = { .proc_handler = pid_ns_ctl_handler, .extra1 = SYSCTL_ZERO, .extra2 = &pid_max, - }, - { } + } }; #endif /* CONFIG_CHECKPOINT_RESTORE */ diff --git a/kernel/pid_sysctl.h b/kernel/pid_sysctl.h index 8b24744752cb..b9528766d2d8 100644 --- a/kernel/pid_sysctl.h +++ b/kernel/pid_sysctl.h @@ -43,8 +43,7 @@ static struct ctl_table pid_ns_ctl_table_vm[] = { .proc_handler = pid_mfd_noexec_dointvec_minmax, .extra1 = SYSCTL_ZERO, .extra2 = SYSCTL_TWO, - }, - { } + } }; static inline void register_pid_ns_sysctl_table_vm(void) { diff --git a/kernel/printk/sysctl.c b/kernel/printk/sysctl.c index 28f37b86414e..d608832b4489 100644 --- a/kernel/printk/sysctl.c +++ b/kernel/printk/sysctl.c @@ -75,8 +75,7 @@ static struct ctl_table printk_sysctls[] = { .proc_handler = proc_dointvec_minmax_sysadmin, .extra1 = SYSCTL_ZERO, .extra2 = SYSCTL_TWO, - }, - {} + } }; void __init printk_sysctl_init(void) diff --git a/kernel/reboot.c b/kernel/reboot.c index cf81d8bfb523..e29d415810c1 100644 --- a/kernel/reboot.c +++ b/kernel/reboot.c @@ -1271,8 +1271,7 @@ static struct ctl_table kern_reboot_table[] = { .maxlen = sizeof(int), .mode = 0644, .proc_handler = proc_dointvec, - }, - { } + } }; static void __init kernel_reboot_sysctls_init(void) diff --git a/kernel/sched/autogroup.c b/kernel/sched/autogroup.c index 2b9ce82279a5..4c558f0de4f7 100644 --- a/kernel/sched/autogroup.c +++ b/kernel/sched/autogroup.c @@ -18,8 +18,7 @@ static struct ctl_table sched_autogroup_sysctls[] = { .proc_handler = proc_dointvec_minmax, .extra1 = SYSCTL_ZERO, .extra2 = SYSCTL_ONE, - }, - {} + } }; static void __init sched_autogroup_sysctl_init(void) diff --git a/kernel/sched/core.c b/kernel/sched/core.c index b8c7e01dd78a..f11ac1d3e315 100644 --- a/kernel/sched/core.c +++ b/kernel/sched/core.c @@ -4671,9 +4671,8 @@ static struct ctl_table sched_core_sysctls[] = { .proc_handler = sysctl_numa_balancing, .extra1 = SYSCTL_ZERO, .extra2 = SYSCTL_FOUR, - }, + } #endif /* CONFIG_NUMA_BALANCING */ - {} }; static int __init sched_core_sysctl_init(void) { diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c index 2aacf5ea2ff3..a6cbdf588590 100644 --- a/kernel/sched/deadline.c +++ b/kernel/sched/deadline.c @@ -40,8 +40,7 @@ static struct ctl_table sched_dl_sysctls[] = { .mode = 0644, .proc_handler = proc_douintvec_minmax, .extra2 = (void *)&sysctl_sched_dl_period_max, - }, - {} + } }; static int __init sched_dl_sysctl_init(void) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index db09e56c2dd3..876f110e696d 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -210,9 +210,8 @@ static struct ctl_table sched_fair_sysctls[] = { .mode = 0644, .proc_handler = proc_dointvec_minmax, .extra1 = SYSCTL_ZERO, - }, + } #endif /* CONFIG_NUMA_BALANCING */ - {} }; static int __init sched_fair_sysctl_init(void) diff --git a/kernel/sched/rt.c b/kernel/sched/rt.c index aab9b900ed6f..2e2d49467dd9 100644 --- a/kernel/sched/rt.c +++ b/kernel/sched/rt.c @@ -51,8 +51,7 @@ static struct ctl_table sched_rt_sysctls[] = { .maxlen = sizeof(int), .mode = 0644, .proc_handler = sched_rr_handler, - }, - {} + } }; static int __init sched_rt_sysctl_init(void) diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c index 46d7c3f3e830..cd3fffecbce3 100644 --- a/kernel/sched/topology.c +++ b/kernel/sched/topology.c @@ -249,8 +249,7 @@ static struct ctl_table sched_energy_aware_sysctls[] = { .proc_handler = sched_energy_aware_handler, .extra1 = SYSCTL_ZERO, .extra2 = SYSCTL_ONE, - }, - {} + } }; static int __init sched_energy_aware_sysctl_init(void) diff --git a/kernel/seccomp.c b/kernel/seccomp.c index 9683a9a4709d..1693f0935904 100644 --- a/kernel/seccomp.c +++ b/kernel/seccomp.c @@ -2380,8 +2380,7 @@ static struct ctl_table seccomp_sysctl_table[] = { .procname = "actions_logged", .mode = 0644, .proc_handler = seccomp_actions_logged_handler, - }, - { } + } }; static int __init seccomp_sysctl_init(void) diff --git a/kernel/signal.c b/kernel/signal.c index 19791930f12a..4a87ba91491f 100644 --- a/kernel/signal.c +++ b/kernel/signal.c @@ -4781,9 +4781,8 @@ static struct ctl_table signal_debug_table[] = { .maxlen = sizeof(int), .mode = 0644, .proc_handler = proc_dointvec - }, + } #endif - { } }; static int __init init_signal_sysctls(void) diff --git a/kernel/stackleak.c b/kernel/stackleak.c index 123844341148..6a9a65ace05a 100644 --- a/kernel/stackleak.c +++ b/kernel/stackleak.c @@ -53,8 +53,7 @@ static struct ctl_table stackleak_sysctls[] = { .proc_handler = stack_erasing_sysctl, .extra1 = SYSCTL_ZERO, .extra2 = SYSCTL_ONE, - }, - {} + } }; static int __init stackleak_sysctls_init(void) diff --git a/kernel/sysctl.c b/kernel/sysctl.c index 2b9b0c8569ba..f1865c593666 100644 --- a/kernel/sysctl.c +++ b/kernel/sysctl.c @@ -2041,9 +2041,8 @@ static struct ctl_table kern_table[] = { .proc_handler = proc_dointvec_minmax, .extra1 = SYSCTL_ONE, .extra2 = SYSCTL_INT_MAX, - }, + } #endif - { } }; static struct ctl_table vm_table[] = { @@ -2314,9 +2313,8 @@ static struct ctl_table vm_table[] = { .proc_handler = proc_dointvec_minmax, .extra1 = (void *)&mmap_rnd_compat_bits_min, .extra2 = (void *)&mmap_rnd_compat_bits_max, - }, + } #endif - { } }; int __init sysctl_init_bases(void) diff --git a/kernel/time/timer.c b/kernel/time/timer.c index de385b365a7a..b7594ac53c99 100644 --- a/kernel/time/timer.c +++ b/kernel/time/timer.c @@ -259,8 +259,7 @@ static struct ctl_table timer_sysctl[] = { .proc_handler = timer_migration_handler, .extra1 = SYSCTL_ZERO, .extra2 = SYSCTL_ONE, - }, - {} + } }; static int __init timer_sysctl_init(void) diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c index 84ef42111f78..7a5a607b6cc2 100644 --- a/kernel/trace/ftrace.c +++ b/kernel/trace/ftrace.c @@ -8213,8 +8213,7 @@ static struct ctl_table ftrace_sysctls[] = { .maxlen = sizeof(int), .mode = 0644, .proc_handler = ftrace_enable_sysctl, - }, - {} + } }; static int __init ftrace_sysctl_init(void) diff --git a/kernel/trace/trace_events_user.c b/kernel/trace/trace_events_user.c index ac019cb21b18..baf48c16d2c5 100644 --- a/kernel/trace/trace_events_user.c +++ b/kernel/trace/trace_events_user.c @@ -2530,8 +2530,7 @@ static struct ctl_table user_event_sysctls[] = { .maxlen = sizeof(unsigned int), .mode = 0644, .proc_handler = set_max_user_events_sysctl, - }, - {} + } }; static int __init trace_events_user_init(void) diff --git a/kernel/ucount.c b/kernel/ucount.c index 59bf6983f1cf..ce7ab90f7953 100644 --- a/kernel/ucount.c +++ b/kernel/ucount.c @@ -85,10 +85,9 @@ static struct ctl_table user_table[] = { #endif #ifdef CONFIG_FANOTIFY UCOUNT_ENTRY("max_fanotify_groups"), - UCOUNT_ENTRY("max_fanotify_marks"), + UCOUNT_ENTRY("max_fanotify_marks") #endif - { } -}; + }; #endif /* CONFIG_SYSCTL */ bool setup_userns_sysctls(struct user_namespace *ns) @@ -96,7 +95,7 @@ bool setup_userns_sysctls(struct user_namespace *ns) #ifdef CONFIG_SYSCTL struct ctl_table *tbl; - BUILD_BUG_ON(ARRAY_SIZE(user_table) != UCOUNT_COUNTS + 1); + BUILD_BUG_ON(ARRAY_SIZE(user_table) != UCOUNT_COUNTS); setup_sysctl_set(&ns->set, &set_root, set_is_seen); tbl = kmemdup(user_table, sizeof(user_table), GFP_KERNEL); if (tbl) { diff --git a/kernel/umh.c b/kernel/umh.c index 187a30ff8541..e1304be4823a 100644 --- a/kernel/umh.c +++ b/kernel/umh.c @@ -559,8 +559,7 @@ static struct ctl_table usermodehelper_table[] = { .maxlen = 2 * sizeof(unsigned long), .mode = 0600, .proc_handler = proc_cap_handler, - }, - { } + } }; static int __init init_umh_sysctls(void) diff --git a/kernel/utsname_sysctl.c b/kernel/utsname_sysctl.c index 24527b155538..8776d45daf3a 100644 --- a/kernel/utsname_sysctl.c +++ b/kernel/utsname_sysctl.c @@ -119,8 +119,7 @@ static struct ctl_table uts_kern_table[] = { .mode = 0644, .proc_handler = proc_do_uts_string, .poll = &domainname_poll, - }, - {} + } }; #ifdef CONFIG_PROC_SYSCTL diff --git a/kernel/watchdog.c b/kernel/watchdog.c index dd5a343fadde..b79e6cfc008c 100644 --- a/kernel/watchdog.c +++ b/kernel/watchdog.c @@ -839,10 +839,9 @@ static struct ctl_table watchdog_sysctls[] = { .proc_handler = proc_dointvec_minmax, .extra1 = SYSCTL_ZERO, .extra2 = SYSCTL_ONE, - }, + } #endif /* CONFIG_SMP */ #endif - {} }; static void __init watchdog_sysctl_init(void) diff --git a/lib/test_sysctl.c b/lib/test_sysctl.c index 83d37a163836..5a9018787d71 100644 --- a/lib/test_sysctl.c +++ b/lib/test_sysctl.c @@ -129,8 +129,7 @@ static struct ctl_table test_table[] = { .maxlen = SYSCTL_TEST_BITMAP_SIZE, .mode = 0644, .proc_handler = proc_do_large_bitmap, - }, - { } + } }; static void test_sysctl_calc_match_int_ok(void) @@ -184,8 +183,7 @@ static struct ctl_table test_table_unregister[] = { .maxlen = sizeof(int), .mode = 0644, .proc_handler = proc_dointvec_minmax, - }, - {} + } }; static int test_sysctl_run_unregister_nested(void) diff --git a/mm/compaction.c b/mm/compaction.c index ca09cdd72bf3..5013f5b7b44b 100644 --- a/mm/compaction.c +++ b/mm/compaction.c @@ -3126,8 +3126,7 @@ static struct ctl_table vm_compaction[] = { .proc_handler = proc_dointvec_minmax_warn_RT_change, .extra1 = SYSCTL_ZERO, .extra2 = SYSCTL_ONE, - }, - { } + } }; static int __init kcompactd_init(void) diff --git a/mm/hugetlb.c b/mm/hugetlb.c index 7838b0c0b82b..5236805aee57 100644 --- a/mm/hugetlb.c +++ b/mm/hugetlb.c @@ -4675,8 +4675,7 @@ static struct ctl_table hugetlb_table[] = { .maxlen = sizeof(unsigned long), .mode = 0644, .proc_handler = hugetlb_overcommit_handler, - }, - { } + } }; static void hugetlb_sysctl_init(void) diff --git a/mm/hugetlb_vmemmap.c b/mm/hugetlb_vmemmap.c index 65885a06269b..b1a2a1089aa3 100644 --- a/mm/hugetlb_vmemmap.c +++ b/mm/hugetlb_vmemmap.c @@ -584,8 +584,7 @@ static struct ctl_table hugetlb_vmemmap_sysctls[] = { .maxlen = sizeof(vmemmap_optimize_enabled), .mode = 0644, .proc_handler = proc_dobool, - }, - { } + } }; static int __init hugetlb_vmemmap_init(void) diff --git a/mm/memory-failure.c b/mm/memory-failure.c index 46aef76d8e91..9bf5dd7a394e 100644 --- a/mm/memory-failure.c +++ b/mm/memory-failure.c @@ -142,8 +142,7 @@ static struct ctl_table memory_failure_table[] = { .proc_handler = proc_dointvec_minmax, .extra1 = SYSCTL_ZERO, .extra2 = SYSCTL_ONE, - }, - { } + } }; static int __init memory_failure_sysctl_init(void) diff --git a/mm/oom_kill.c b/mm/oom_kill.c index 500cf2ef9faa..a05416f798e7 100644 --- a/mm/oom_kill.c +++ b/mm/oom_kill.c @@ -725,8 +725,7 @@ static struct ctl_table vm_oom_kill_table[] = { .maxlen = sizeof(sysctl_oom_dump_tasks), .mode = 0644, .proc_handler = proc_dointvec, - }, - {} + } }; #endif diff --git a/mm/page-writeback.c b/mm/page-writeback.c index 9f997de8d12f..b75aaae6f77b 100644 --- a/mm/page-writeback.c +++ b/mm/page-writeback.c @@ -2290,8 +2290,7 @@ static struct ctl_table vm_page_writeback_sysctls[] = { .maxlen = sizeof(laptop_mode), .mode = 0644, .proc_handler = proc_dointvec_jiffies, - }, - {} + } }; #endif diff --git a/net/appletalk/sysctl_net_atalk.c b/net/appletalk/sysctl_net_atalk.c index 30dcbbb8aeff..3975c1fad48c 100644 --- a/net/appletalk/sysctl_net_atalk.c +++ b/net/appletalk/sysctl_net_atalk.c @@ -39,8 +39,7 @@ static struct ctl_table atalk_table[] = { .maxlen = sizeof(int), .mode = 0644, .proc_handler = proc_dointvec_jiffies, - }, - { }, + } }; static struct ctl_table_header *atalk_table_header; diff --git a/net/ax25/sysctl_net_ax25.c b/net/ax25/sysctl_net_ax25.c index 06afbc14b783..e7e81787e5de 100644 --- a/net/ax25/sysctl_net_ax25.c +++ b/net/ax25/sysctl_net_ax25.c @@ -139,10 +139,9 @@ static const struct ctl_table ax25_param_table[] = { .proc_handler = proc_dointvec_minmax, .extra1 = &min_ds_timeout, .extra2 = &max_ds_timeout - }, + } #endif - - { } /* that's all, folks! */ +/* that's all, folks! */ }; int ax25_register_dev_sysctl(ax25_dev *ax25_dev) diff --git a/net/bridge/br_netfilter_hooks.c b/net/bridge/br_netfilter_hooks.c index ebbaef748a48..dfc37ac00980 100644 --- a/net/bridge/br_netfilter_hooks.c +++ b/net/bridge/br_netfilter_hooks.c @@ -1100,8 +1100,7 @@ static struct ctl_table brnf_table[] = { .maxlen = sizeof(int), .mode = 0644, .proc_handler = brnf_sysctl_call_tables, - }, - { } + } }; static inline void br_netfilter_sysctl_default(struct brnf_net *brnf) diff --git a/net/core/neighbour.c b/net/core/neighbour.c index aa5ad1cfc9b1..096d86013300 100644 --- a/net/core/neighbour.c +++ b/net/core/neighbour.c @@ -3716,7 +3716,7 @@ static int neigh_proc_base_reachable_time(struct ctl_table *ctl, int write, static struct neigh_sysctl_table { struct ctl_table_header *sysctl_header; - struct ctl_table neigh_vars[NEIGH_VAR_MAX + 1]; + struct ctl_table neigh_vars[NEIGH_VAR_MAX]; } neigh_sysctl_template __read_mostly = { .neigh_vars = { NEIGH_SYSCTL_ZERO_INTMAX_ENTRY(MCAST_PROBES, "mcast_solicit"), @@ -3766,9 +3766,8 @@ static struct neigh_sysctl_table { .extra1 = SYSCTL_ZERO, .extra2 = SYSCTL_INT_MAX, .proc_handler = proc_dointvec_minmax, - }, - {}, - }, + } + } }; int neigh_sysctl_register(struct net_device *dev, struct neigh_parms *p, @@ -3779,6 +3778,7 @@ int neigh_sysctl_register(struct net_device *dev, struct neigh_parms *p, const char *dev_name_source; char neigh_path[ sizeof("net//neigh/") + IFNAMSIZ + IFNAMSIZ ]; char *p_name; + size_t neigh_vars_size; t = kmemdup(&neigh_sysctl_template, sizeof(*t), GFP_KERNEL_ACCOUNT); if (!t) @@ -3790,11 +3790,11 @@ int neigh_sysctl_register(struct net_device *dev, struct neigh_parms *p, t->neigh_vars[i].extra2 = p; } + neigh_vars_size = ARRAY_SIZE(t->neigh_vars); if (dev) { dev_name_source = dev->name; /* Terminate the table early */ - memset(&t->neigh_vars[NEIGH_VAR_GC_INTERVAL], 0, - sizeof(t->neigh_vars[NEIGH_VAR_GC_INTERVAL])); + neigh_vars_size = NEIGH_VAR_BASE_REACHABLE_TIME_MS; } else { struct neigh_table *tbl = p->tbl; dev_name_source = "default"; @@ -3843,7 +3843,7 @@ int neigh_sysctl_register(struct net_device *dev, struct neigh_parms *p, p_name, dev_name_source); t->sysctl_header = register_net_sysctl(neigh_parms_net(p), neigh_path, t->neigh_vars, - ARRAY_SIZE(t->neigh_vars)); + neigh_vars_size); if (!t->sysctl_header) goto free; diff --git a/net/core/sysctl_net_core.c b/net/core/sysctl_net_core.c index aa615f22507b..9acde2a110cd 100644 --- a/net/core/sysctl_net_core.c +++ b/net/core/sysctl_net_core.c @@ -652,8 +652,7 @@ static struct ctl_table net_core_table[] = { .mode = 0644, .proc_handler = proc_dointvec_minmax, .extra1 = SYSCTL_ZERO, - }, - { } + } }; static struct ctl_table netns_core_table[] = { @@ -681,8 +680,7 @@ static struct ctl_table netns_core_table[] = { .extra1 = SYSCTL_ZERO, .extra2 = SYSCTL_ONE, .proc_handler = proc_dou8vec_minmax, - }, - { } + } }; static int __init fb_tunnels_only_for_init_net_sysctl_setup(char *str) diff --git a/net/dccp/sysctl.c b/net/dccp/sysctl.c index 1140748858b0..7a5ccae4fc10 100644 --- a/net/dccp/sysctl.c +++ b/net/dccp/sysctl.c @@ -89,9 +89,7 @@ static struct ctl_table dccp_default_table[] = { .maxlen = sizeof(sysctl_dccp_sync_ratelimit), .mode = 0644, .proc_handler = proc_dointvec_ms_jiffies, - }, - - { } + } }; static struct ctl_table_header *dccp_table_header; diff --git a/net/ieee802154/6lowpan/reassembly.c b/net/ieee802154/6lowpan/reassembly.c index 7b717434368c..3d9f2fbb8ec0 100644 --- a/net/ieee802154/6lowpan/reassembly.c +++ b/net/ieee802154/6lowpan/reassembly.c @@ -337,8 +337,7 @@ static struct ctl_table lowpan_frags_ns_ctl_table[] = { .maxlen = sizeof(int), .mode = 0644, .proc_handler = proc_dointvec_jiffies, - }, - { } + } }; /* secret interval has been deprecated */ @@ -350,8 +349,7 @@ static struct ctl_table lowpan_frags_ctl_table[] = { .maxlen = sizeof(int), .mode = 0644, .proc_handler = proc_dointvec_jiffies, - }, - { } + } }; static int __net_init lowpan_frags_ns_sysctl_register(struct net *net) diff --git a/net/ipv4/devinet.c b/net/ipv4/devinet.c index 6360425dfcb2..eeb229b1ab78 100644 --- a/net/ipv4/devinet.c +++ b/net/ipv4/devinet.c @@ -2516,7 +2516,7 @@ static int ipv4_doint_and_flush(struct ctl_table *ctl, int write, static struct devinet_sysctl_table { struct ctl_table_header *sysctl_header; - struct ctl_table devinet_vars[__IPV4_DEVCONF_MAX]; + struct ctl_table devinet_vars[IPV4_DEVCONF_MAX]; } devinet_sysctl = { .devinet_vars = { DEVINET_SYSCTL_COMPLEX_ENTRY(FORWARDING, "forwarding", @@ -2653,8 +2653,7 @@ static struct ctl_table ctl_forward_entry[] = { .proc_handler = devinet_sysctl_forward, .extra1 = &ipv4_devconf, .extra2 = &init_net, - }, - { }, + } }; #endif diff --git a/net/ipv4/ip_fragment.c b/net/ipv4/ip_fragment.c index 3d7a82a900b5..2f8a8ac058da 100644 --- a/net/ipv4/ip_fragment.c +++ b/net/ipv4/ip_fragment.c @@ -579,8 +579,7 @@ static struct ctl_table ip4_frags_ns_ctl_table[] = { .mode = 0644, .proc_handler = proc_dointvec_minmax, .extra1 = &dist_min, - }, - { } + } }; /* secret interval has been deprecated */ @@ -592,8 +591,7 @@ static struct ctl_table ip4_frags_ctl_table[] = { .maxlen = sizeof(int), .mode = 0644, .proc_handler = proc_dointvec_jiffies, - }, - { } + } }; static int __net_init ip4_frags_ns_ctl_register(struct net *net) diff --git a/net/ipv4/route.c b/net/ipv4/route.c index 883f4f1ee056..de0c0f9078b5 100644 --- a/net/ipv4/route.c +++ b/net/ipv4/route.c @@ -3551,8 +3551,7 @@ static struct ctl_table ipv4_route_table[] = { .maxlen = sizeof(int), .mode = 0644, .proc_handler = proc_dointvec, - }, - { } + } }; static const char ipv4_route_flush_procname[] = "flush"; @@ -3585,8 +3584,7 @@ static struct ctl_table ipv4_route_netns_table[] = { .maxlen = sizeof(int), .mode = 0644, .proc_handler = proc_dointvec, - }, - { }, + } }; static __net_init int sysctl_route_net_init(struct net *net) diff --git a/net/ipv4/sysctl_net_ipv4.c b/net/ipv4/sysctl_net_ipv4.c index 1821f403efc0..31306925a35d 100644 --- a/net/ipv4/sysctl_net_ipv4.c +++ b/net/ipv4/sysctl_net_ipv4.c @@ -577,8 +577,7 @@ static struct ctl_table ipv4_table[] = { .proc_handler = proc_douintvec_minmax, .extra1 = &sysctl_fib_sync_mem_min, .extra2 = &sysctl_fib_sync_mem_max, - }, - { } + } }; static struct ctl_table ipv4_net_table[] = { @@ -1469,8 +1468,7 @@ static struct ctl_table ipv4_net_table[] = { .proc_handler = proc_dointvec_minmax, .extra1 = SYSCTL_ZERO, .extra2 = &tcp_plb_max_cong_thresh, - }, - { } + } }; static __net_init int ipv4_sysctl_init_net(struct net *net) diff --git a/net/ipv4/xfrm4_policy.c b/net/ipv4/xfrm4_policy.c index ec1d68dbffc3..40610bb3a75a 100644 --- a/net/ipv4/xfrm4_policy.c +++ b/net/ipv4/xfrm4_policy.c @@ -160,8 +160,7 @@ static struct ctl_table xfrm4_policy_table[] = { .maxlen = sizeof(int), .mode = 0644, .proc_handler = proc_dointvec, - }, - { } + } }; static __net_init int xfrm4_net_sysctl_init(struct net *net) diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c index 68a2925c66a5..c72887ad79a3 100644 --- a/net/ipv6/addrconf.c +++ b/net/ipv6/addrconf.c @@ -7055,9 +7055,6 @@ static const struct ctl_table addrconf_sysctl[] = { .proc_handler = proc_dointvec_minmax, .extra1 = SYSCTL_ZERO, .extra2 = SYSCTL_TWO, - }, - { - /* sentinel */ } }; @@ -7072,7 +7069,7 @@ static int __addrconf_sysctl_register(struct net *net, char *dev_name, if (!table) goto out; - for (i = 0; table[i].data; i++) { + for (i = 0; i < ARRAY_SIZE(addrconf_sysctl); i++) { table[i].data += (char *)p - (char *)&ipv6_devconf; /* If one of these is already set, then it is not safe to * overwrite either of them: this makes proc_dointvec_minmax diff --git a/net/ipv6/icmp.c b/net/ipv6/icmp.c index 4159662fa214..b57e2c447969 100644 --- a/net/ipv6/icmp.c +++ b/net/ipv6/icmp.c @@ -1204,8 +1204,7 @@ static struct ctl_table ipv6_icmp_table_template[] = { .proc_handler = proc_dou8vec_minmax, .extra1 = SYSCTL_ZERO, .extra2 = SYSCTL_ONE, - }, - { }, + } }; struct ctl_table * __net_init ipv6_icmp_sysctl_init(struct net *net) diff --git a/net/ipv6/netfilter/nf_conntrack_reasm.c b/net/ipv6/netfilter/nf_conntrack_reasm.c index dca8e0aabc51..18106042a3ed 100644 --- a/net/ipv6/netfilter/nf_conntrack_reasm.c +++ b/net/ipv6/netfilter/nf_conntrack_reasm.c @@ -61,8 +61,7 @@ static struct ctl_table nf_ct_frag6_sysctl_table[] = { .maxlen = sizeof(unsigned long), .mode = 0644, .proc_handler = proc_doulongvec_minmax, - }, - { } + } }; static int nf_ct_frag6_sysctl_register(struct net *net) diff --git a/net/ipv6/reassembly.c b/net/ipv6/reassembly.c index 0688261202de..b7d7dd6e1f75 100644 --- a/net/ipv6/reassembly.c +++ b/net/ipv6/reassembly.c @@ -435,8 +435,7 @@ static struct ctl_table ip6_frags_ns_ctl_table[] = { .maxlen = sizeof(int), .mode = 0644, .proc_handler = proc_dointvec_jiffies, - }, - { } + } }; /* secret interval has been deprecated */ @@ -448,8 +447,7 @@ static struct ctl_table ip6_frags_ctl_table[] = { .maxlen = sizeof(int), .mode = 0644, .proc_handler = proc_dointvec_jiffies, - }, - { } + } }; static int __net_init ip6_frags_ns_sysctl_register(struct net *net) diff --git a/net/ipv6/route.c b/net/ipv6/route.c index a35470576077..0b2a3afe620e 100644 --- a/net/ipv6/route.c +++ b/net/ipv6/route.c @@ -6417,8 +6417,7 @@ static struct ctl_table ipv6_route_table_template[] = { .proc_handler = proc_dointvec_minmax, .extra1 = SYSCTL_ZERO, .extra2 = SYSCTL_ONE, - }, - { } + } }; struct ctl_table * __net_init ipv6_route_sysctl_init(struct net *net) diff --git a/net/ipv6/sysctl_net_ipv6.c b/net/ipv6/sysctl_net_ipv6.c index 29f121f513a6..0d45a8a32752 100644 --- a/net/ipv6/sysctl_net_ipv6.c +++ b/net/ipv6/sysctl_net_ipv6.c @@ -212,8 +212,7 @@ static struct ctl_table ipv6_table_template[] = { .mode = 0644, .proc_handler = proc_doulongvec_minmax, .extra2 = &ioam6_id_wide_max, - }, - { } + } }; static struct ctl_table ipv6_rotable[] = { @@ -246,9 +245,8 @@ static struct ctl_table ipv6_rotable[] = { .maxlen = sizeof(int), .mode = 0644, .proc_handler = proc_dointvec, - }, + } #endif /* CONFIG_NETLABEL */ - { } }; static int __net_init ipv6_sysctl_net_init(struct net *net) diff --git a/net/ipv6/xfrm6_policy.c b/net/ipv6/xfrm6_policy.c index 27efdb18a018..f3559ff33ff4 100644 --- a/net/ipv6/xfrm6_policy.c +++ b/net/ipv6/xfrm6_policy.c @@ -187,8 +187,7 @@ static struct ctl_table xfrm6_policy_table[] = { .maxlen = sizeof(int), .mode = 0644, .proc_handler = proc_dointvec, - }, - { } + } }; static int __net_init xfrm6_net_sysctl_init(struct net *net) diff --git a/net/llc/sysctl_net_llc.c b/net/llc/sysctl_net_llc.c index 195296ba29f0..520fc52059b1 100644 --- a/net/llc/sysctl_net_llc.c +++ b/net/llc/sysctl_net_llc.c @@ -43,12 +43,10 @@ static struct ctl_table llc2_timeout_table[] = { .maxlen = sizeof(sysctl_llc2_rej_timeout), .mode = 0644, .proc_handler = proc_dointvec_jiffies, - }, - { }, + } }; static struct ctl_table llc_station_table[] = { - { }, }; static struct ctl_table_header *llc2_timeout_header; diff --git a/net/mpls/af_mpls.c b/net/mpls/af_mpls.c index 6f96aae76537..a78daceddf74 100644 --- a/net/mpls/af_mpls.c +++ b/net/mpls/af_mpls.c @@ -1391,8 +1391,7 @@ static const struct ctl_table mpls_dev_table[] = { .mode = 0644, .proc_handler = mpls_conf_proc, .data = MPLS_PERDEV_SYSCTL_OFFSET(input_enabled), - }, - { } + } }; static int mpls_platform_labels(struct ctl_table *table, int write, @@ -1425,8 +1424,7 @@ static const struct ctl_table mpls_table[] = { .proc_handler = proc_dointvec_minmax, .extra1 = SYSCTL_ONE, .extra2 = &ttl_max, - }, - { } + } }; static int mpls_dev_sysctl_register(struct net_device *dev, @@ -1444,7 +1442,7 @@ static int mpls_dev_sysctl_register(struct net_device *dev, /* Table data contains only offsets relative to the base of * the mdev at this point, so make them absolute. */ - for (i = 0; i < ARRAY_SIZE(mpls_dev_table) - 1; i++) { + for (i = 0; i < ARRAY_SIZE(mpls_dev_table); i++) { table[i].data = (char *)mdev + (uintptr_t)table[i].data; table[i].extra1 = mdev; table[i].extra2 = net; @@ -2689,7 +2687,7 @@ static int mpls_net_init(struct net *net) /* Table data contains only offsets relative to the base of * the mdev at this point, so make them absolute. */ - for (i = 0; i < ARRAY_SIZE(mpls_table) - 1; i++) + for (i = 0; i < ARRAY_SIZE(mpls_table); i++) table[i].data = (char *)net + (uintptr_t)table[i].data; net->mpls.ctl = register_net_sysctl(net, "net/mpls", table, diff --git a/net/mptcp/ctrl.c b/net/mptcp/ctrl.c index 42dfc834e5c6..27fb556d2273 100644 --- a/net/mptcp/ctrl.c +++ b/net/mptcp/ctrl.c @@ -127,8 +127,7 @@ static struct ctl_table mptcp_sysctl_table[] = { .proc_handler = proc_dou8vec_minmax, .extra1 = SYSCTL_ZERO, .extra2 = &mptcp_pm_type_max - }, - {} + } }; static int mptcp_pernet_new_table(struct net *net, struct mptcp_pernet *pernet) diff --git a/net/netfilter/ipvs/ip_vs_ctl.c b/net/netfilter/ipvs/ip_vs_ctl.c index abbd30ee3ce0..fef7104ac33e 100644 --- a/net/netfilter/ipvs/ip_vs_ctl.c +++ b/net/netfilter/ipvs/ip_vs_ctl.c @@ -2258,9 +2258,8 @@ static struct ctl_table vs_vars[] = { .maxlen = sizeof(int), .mode = 0644, .proc_handler = proc_dointvec, - }, + } #endif - { } }; #endif diff --git a/net/netfilter/ipvs/ip_vs_lblc.c b/net/netfilter/ipvs/ip_vs_lblc.c index 254eb3b61e15..e6297bb6922b 100644 --- a/net/netfilter/ipvs/ip_vs_lblc.c +++ b/net/netfilter/ipvs/ip_vs_lblc.c @@ -122,8 +122,7 @@ static struct ctl_table vs_vars_table[] = { .maxlen = sizeof(int), .mode = 0644, .proc_handler = proc_dointvec_jiffies, - }, - { } + } }; #endif diff --git a/net/netfilter/ipvs/ip_vs_lblcr.c b/net/netfilter/ipvs/ip_vs_lblcr.c index 0e39a4fd421f..f3056767818b 100644 --- a/net/netfilter/ipvs/ip_vs_lblcr.c +++ b/net/netfilter/ipvs/ip_vs_lblcr.c @@ -293,8 +293,7 @@ static struct ctl_table vs_vars_table[] = { .maxlen = sizeof(int), .mode = 0644, .proc_handler = proc_dointvec_jiffies, - }, - { } + } }; #endif diff --git a/net/netfilter/nf_conntrack_standalone.c b/net/netfilter/nf_conntrack_standalone.c index a3b2029ef098..26efc6f28b34 100644 --- a/net/netfilter/nf_conntrack_standalone.c +++ b/net/netfilter/nf_conntrack_standalone.c @@ -616,11 +616,9 @@ enum nf_ct_sysctl_index { NF_SYSCTL_CT_LWTUNNEL, #endif - __NF_SYSCTL_CT_LAST_SYSCTL, + NF_SYSCTL_CT_LAST_SYSCTL, }; -#define NF_SYSCTL_CT_LAST_SYSCTL (__NF_SYSCTL_CT_LAST_SYSCTL + 1) - static struct ctl_table nf_ct_sysctl_table[] = { [NF_SYSCTL_CT_MAX] = { .procname = "nf_conntrack_max", @@ -955,9 +953,8 @@ static struct ctl_table nf_ct_sysctl_table[] = { .maxlen = sizeof(int), .mode = 0644, .proc_handler = nf_hooks_lwtunnel_sysctl_handler, - }, + } #endif - {} }; static struct ctl_table nf_ct_netfilter_table[] = { @@ -967,8 +964,7 @@ static struct ctl_table nf_ct_netfilter_table[] = { .maxlen = sizeof(int), .mode = 0644, .proc_handler = proc_dointvec, - }, - { } + } }; static void nf_conntrack_standalone_init_tcp_sysctl(struct net *net, diff --git a/net/netfilter/nf_log.c b/net/netfilter/nf_log.c index 755f9cf570ce..686040b5e431 100644 --- a/net/netfilter/nf_log.c +++ b/net/netfilter/nf_log.c @@ -389,7 +389,7 @@ static const struct seq_operations nflog_seq_ops = { #ifdef CONFIG_SYSCTL static char nf_log_sysctl_fnames[NFPROTO_NUMPROTO-NFPROTO_UNSPEC][3]; -static struct ctl_table nf_log_sysctl_table[NFPROTO_NUMPROTO+1]; +static struct ctl_table nf_log_sysctl_table[NFPROTO_NUMPROTO]; static struct ctl_table_header *nf_log_sysctl_fhdr; static struct ctl_table nf_log_sysctl_ftable[] = { @@ -399,8 +399,7 @@ static struct ctl_table nf_log_sysctl_ftable[] = { .maxlen = sizeof(sysctl_nf_log_all_netns), .mode = 0644, .proc_handler = proc_dointvec, - }, - { } + } }; static int nf_log_proc_dostring(struct ctl_table *table, int write, diff --git a/net/netrom/sysctl_net_netrom.c b/net/netrom/sysctl_net_netrom.c index c02b93fd9d4f..133dccdc2201 100644 --- a/net/netrom/sysctl_net_netrom.c +++ b/net/netrom/sysctl_net_netrom.c @@ -139,8 +139,7 @@ static struct ctl_table nr_table[] = { .proc_handler = proc_dointvec_minmax, .extra1 = &min_reset, .extra2 = &max_reset - }, - { } + } }; int __init nr_register_sysctl(void) diff --git a/net/phonet/sysctl.c b/net/phonet/sysctl.c index 0fd0fcb00505..5385e980693e 100644 --- a/net/phonet/sysctl.c +++ b/net/phonet/sysctl.c @@ -80,8 +80,7 @@ static struct ctl_table phonet_table[] = { .maxlen = sizeof(local_port_range), .mode = 0644, .proc_handler = proc_local_port_range, - }, - { } + } }; int __init phonet_sysctl_init(void) diff --git a/net/rds/ib_sysctl.c b/net/rds/ib_sysctl.c index 102fd4a18df7..ee9ec39d9b30 100644 --- a/net/rds/ib_sysctl.c +++ b/net/rds/ib_sysctl.c @@ -102,8 +102,7 @@ static struct ctl_table rds_ib_sysctl_table[] = { .maxlen = sizeof(rds_ib_sysctl_flow_control), .mode = 0644, .proc_handler = proc_dointvec, - }, - { } + } }; void rds_ib_sysctl_exit(void) diff --git a/net/rds/sysctl.c b/net/rds/sysctl.c index 5abd2730a1bc..17b325585bd9 100644 --- a/net/rds/sysctl.c +++ b/net/rds/sysctl.c @@ -88,8 +88,7 @@ static struct ctl_table rds_sysctl_rds_table[] = { .maxlen = sizeof(int), .mode = 0644, .proc_handler = proc_dointvec, - }, - { } + } }; void rds_sysctl_exit(void) diff --git a/net/rds/tcp.c b/net/rds/tcp.c index 2e90a2570d3b..e4abe20c4d2d 100644 --- a/net/rds/tcp.c +++ b/net/rds/tcp.c @@ -85,8 +85,7 @@ static struct ctl_table rds_tcp_sysctl_table[] = { .mode = 0644, .proc_handler = rds_tcp_skbuf_handler, .extra1 = &rds_tcp_min_rcvbuf, - }, - { } + } }; u32 rds_tcp_write_seq(struct rds_tcp_connection *tc) diff --git a/net/rose/sysctl_net_rose.c b/net/rose/sysctl_net_rose.c index 4f5a1e8b6c54..1a244a4d0221 100644 --- a/net/rose/sysctl_net_rose.c +++ b/net/rose/sysctl_net_rose.c @@ -111,8 +111,7 @@ static struct ctl_table rose_table[] = { .proc_handler = proc_dointvec_minmax, .extra1 = &min_window, .extra2 = &max_window - }, - { } + } }; void __init rose_register_sysctl(void) diff --git a/net/rxrpc/sysctl.c b/net/rxrpc/sysctl.c index 2b5824416036..583306fad3ef 100644 --- a/net/rxrpc/sysctl.c +++ b/net/rxrpc/sysctl.c @@ -124,8 +124,7 @@ static struct ctl_table rxrpc_sysctl_table[] = { .proc_handler = proc_dointvec_minmax, .extra1 = (void *)SYSCTL_ONE, .extra2 = (void *)&four, - }, - { } + } }; int __init rxrpc_sysctl_init(void) diff --git a/net/sctp/sysctl.c b/net/sctp/sysctl.c index 233f37f0fa28..93ea4decbb1b 100644 --- a/net/sctp/sysctl.c +++ b/net/sctp/sysctl.c @@ -79,9 +79,7 @@ static struct ctl_table sctp_table[] = { .maxlen = sizeof(sysctl_sctp_wmem), .mode = 0644, .proc_handler = proc_dointvec, - }, - - { /* sentinel */ } + } }; /* The following index defines are used in sctp_sysctl_net_register(). @@ -383,9 +381,7 @@ static struct ctl_table sctp_net_table[] = { .proc_handler = proc_dointvec_minmax, .extra1 = SYSCTL_ZERO, .extra2 = &pf_expose_max, - }, - - { /* sentinel */ } + } }; static int proc_sctp_do_hmac_alg(struct ctl_table *ctl, int write, @@ -604,7 +600,7 @@ int sctp_sysctl_net_register(struct net *net) if (!table) return -ENOMEM; - for (i = 0; table[i].data; i++) + for (i = 0; i < ARRAY_SIZE(sctp_net_table); i++) table[i].data += (char *)(&net->sctp) - (char *)&init_net.sctp; table[SCTP_RTO_MIN_IDX].extra2 = &net->sctp.rto_max; diff --git a/net/smc/smc_sysctl.c b/net/smc/smc_sysctl.c index 9404123883c0..89af1f1dbb58 100644 --- a/net/smc/smc_sysctl.c +++ b/net/smc/smc_sysctl.c @@ -61,8 +61,7 @@ static struct ctl_table smc_table[] = { .mode = 0644, .proc_handler = proc_dointvec_minmax, .extra1 = &min_rcvbuf, - }, - { } + } }; int __net_init smc_sysctl_net_init(struct net *net) diff --git a/net/sunrpc/sysctl.c b/net/sunrpc/sysctl.c index 61222addda7e..f4ac3376c25b 100644 --- a/net/sunrpc/sysctl.c +++ b/net/sunrpc/sysctl.c @@ -159,8 +159,7 @@ static struct ctl_table debug_table[] = { .maxlen = 256, .mode = 0444, .proc_handler = proc_do_xprt, - }, - { } + } }; void diff --git a/net/sunrpc/xprtrdma/svc_rdma.c b/net/sunrpc/xprtrdma/svc_rdma.c index df7fb9c8b785..cbc75193bc70 100644 --- a/net/sunrpc/xprtrdma/svc_rdma.c +++ b/net/sunrpc/xprtrdma/svc_rdma.c @@ -208,8 +208,7 @@ static struct ctl_table svcrdma_parm_table[] = { .proc_handler = proc_dointvec_minmax, .extra1 = &zero, .extra2 = &zero, - }, - { }, + } }; static void svc_rdma_proc_cleanup(void) diff --git a/net/sunrpc/xprtrdma/transport.c b/net/sunrpc/xprtrdma/transport.c index bf43e05044a3..75c789712cd9 100644 --- a/net/sunrpc/xprtrdma/transport.c +++ b/net/sunrpc/xprtrdma/transport.c @@ -136,8 +136,7 @@ static struct ctl_table xr_tunables_table[] = { .maxlen = sizeof(unsigned int), .mode = 0644, .proc_handler = proc_dointvec, - }, - { }, + } }; #endif diff --git a/net/sunrpc/xprtsock.c b/net/sunrpc/xprtsock.c index 7c3d5ed708be..c0c59cd3b31c 100644 --- a/net/sunrpc/xprtsock.c +++ b/net/sunrpc/xprtsock.c @@ -154,8 +154,7 @@ static struct ctl_table xs_tunables_table[] = { .maxlen = sizeof(xs_tcp_fin_timeout), .mode = 0644, .proc_handler = proc_dointvec_jiffies, - }, - { }, + } }; /* diff --git a/net/tipc/sysctl.c b/net/tipc/sysctl.c index b9cbc3b359aa..e492d8c6c6f3 100644 --- a/net/tipc/sysctl.c +++ b/net/tipc/sysctl.c @@ -90,8 +90,7 @@ static struct ctl_table tipc_table[] = { .maxlen = sizeof(sysctl_tipc_bc_retruni), .mode = 0644, .proc_handler = proc_doulongvec_minmax, - }, - {} + } }; int tipc_register_sysctl(void) diff --git a/net/unix/sysctl_net_unix.c b/net/unix/sysctl_net_unix.c index 92f3bc3cd704..716dee11d9e3 100644 --- a/net/unix/sysctl_net_unix.c +++ b/net/unix/sysctl_net_unix.c @@ -18,8 +18,7 @@ static struct ctl_table unix_table[] = { .maxlen = sizeof(int), .mode = 0644, .proc_handler = proc_dointvec - }, - { } + } }; int __net_init unix_sysctl_register(struct net *net) diff --git a/net/x25/sysctl_net_x25.c b/net/x25/sysctl_net_x25.c index 4d7c2ee41943..1e76f96ba77f 100644 --- a/net/x25/sysctl_net_x25.c +++ b/net/x25/sysctl_net_x25.c @@ -70,8 +70,7 @@ static struct ctl_table x25_table[] = { .maxlen = sizeof(int), .mode = 0644, .proc_handler = proc_dointvec, - }, - { }, + } }; int __init x25_register_sysctl(void) diff --git a/net/xfrm/xfrm_sysctl.c b/net/xfrm/xfrm_sysctl.c index d04b25a47575..e2b2c3437fbc 100644 --- a/net/xfrm/xfrm_sysctl.c +++ b/net/xfrm/xfrm_sysctl.c @@ -37,8 +37,7 @@ static struct ctl_table xfrm_table[] = { .maxlen = sizeof(int), .mode = 0644, .proc_handler = proc_dointvec - }, - {} + } }; int __net_init xfrm_sysctl_init(struct net *net) diff --git a/security/apparmor/lsm.c b/security/apparmor/lsm.c index b77344506cf3..67aa6e236e66 100644 --- a/security/apparmor/lsm.c +++ b/security/apparmor/lsm.c @@ -1778,9 +1778,7 @@ static struct ctl_table apparmor_sysctl_table[] = { .maxlen = sizeof(int), .mode = 0600, .proc_handler = apparmor_dointvec, - }, - - { } + } }; static int __init apparmor_init_sysctl(void) diff --git a/security/keys/sysctl.c b/security/keys/sysctl.c index fa305f74f658..7c944ef5a58c 100644 --- a/security/keys/sysctl.c +++ b/security/keys/sysctl.c @@ -54,9 +54,9 @@ struct ctl_table key_sysctls[] = { .proc_handler = proc_dointvec_minmax, .extra1 = (void *) SYSCTL_ZERO, .extra2 = (void *) SYSCTL_INT_MAX, - }, + } #ifdef CONFIG_PERSISTENT_KEYRINGS - { + , { .procname = "persistent_keyring_expiry", .data = &persistent_keyring_expiry, .maxlen = sizeof(unsigned), @@ -64,9 +64,8 @@ struct ctl_table key_sysctls[] = { .proc_handler = proc_dointvec_minmax, .extra1 = (void *) SYSCTL_ZERO, .extra2 = (void *) SYSCTL_INT_MAX, - }, + } #endif - { } }; static int __init init_security_keys_sysctls(void) diff --git a/security/loadpin/loadpin.c b/security/loadpin/loadpin.c index 6f2cc827df41..28b411adbf0b 100644 --- a/security/loadpin/loadpin.c +++ b/security/loadpin/loadpin.c @@ -61,8 +61,7 @@ static struct ctl_table loadpin_sysctl_table[] = { .proc_handler = proc_dointvec_minmax, .extra1 = SYSCTL_ONE, .extra2 = SYSCTL_ONE, - }, - { } + } }; static void set_sysctl(bool is_writable) diff --git a/security/yama/yama_lsm.c b/security/yama/yama_lsm.c index 7b8164a4b504..2d2700af9f6b 100644 --- a/security/yama/yama_lsm.c +++ b/security/yama/yama_lsm.c @@ -456,8 +456,7 @@ static struct ctl_table yama_sysctl_table[] = { .proc_handler = yama_dointvec_minmax, .extra1 = SYSCTL_ZERO, .extra2 = &max_scope, - }, - { } + } }; static void __init yama_init_sysctl(void) {